phorge-phorge/src/applications/diffusion/exception/DiffusionSetupException.php

<?php

final class DiffusionSetupException extends Exception {}
Improve Diffusion error messages and UI for partially imported repositories Summary: - When you have an un-cloned repository, we currently throw random-looking Git/Hg exception. Instead, throw a useful error. - When you have a cloned but undiscovered repository, we show no commits. This is crazy confusing. Instead, show commits as "importing...". - Fix some warnings and errors for empty path table cases, etc. Test Plan: - Wiped database. - Added Mercurial repo without running daemons. Viewed in Diffusion, got a good exception. - Pulled Mercurial repo without discovering it. Got "Importing...". - Discovered Mercurial repo without parsing it. Got "Importing..." plus date information. - Parsed Mercurial repo, got everything working properly. - Added Git repo without running daemons, did all the stuff above, same results. - This doesn't improve SVN much but that's a trickier case since we don't actually make SVN calls and rely only on the parse state. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T776 Differential Revision: https://secure.phabricator.com/D2439 2012-05-10 02:28:57 +02:00			`<?php`

Replace AphrontUsageException with AphrontMalformedRequestException Summary: Ref T1806. Ref T7173. Context here is that I want to fix "you can not log in to this instance" being a confusing mess with an opaque error. To do this without hacks, I want to: - clean up some exception handling behavior (this diff); - modularize exception handling (next diff); - replace confusing, over-general exceptions with tailored ones in the Phacility cluster, using the new modular stuff. This cleans up an awkward "AphrontUsageException" which does some weird stuff right now. In particular, it is extensible and extended in one place in Diffusion, but that extension is meaningless. Realign this as "AphrontMalformedRequestException", which is a better description of what it is and does: raises errors before we can get as far as normal routing and site handling. Test Plan: Hit some of these exceptions, saw the expected "abandon all hope" error page. Reviewers: chad Reviewed By: chad Maniphest Tasks: T1806, T7173 Differential Revision: https://secure.phabricator.com/D14047 2015-09-03 19:04:17 +02:00			`final class DiffusionSetupException extends Exception {}`