Allow ApplicationEditor forms to be reconfigured
Summary:
Ref T9132. This diff doesn't do anything interesting, it just lays the groundwork for more interesting future diffs.
Broadly, the idea here is to let you create multiple views of each edit form. For example, we might create several different "Create Task" forms, like:
- "New Bug Report"
- "New Feature Request"
These would be views of the "Create Task" form, but with various adjustments:
- A form might have additional instructions ("how to file a good bug report").
- A form might have prefilled values for some fields (like particular projects, subscribers, or policies).
- A form might have some fields locked (so they can not be edited) or hidden.
- A form might have a different field order.
- A form might have a limited visibility policy, so only some users can access it.
This diff adds a new storage object (`EditEngineConfiguration`) to keep track of all those customizations and represent "a form which has been configured to look and work a certain way".
This doesn't let these configurations do anything useful/interesting, and you can't access them directly yet, it's just all the boring plumbing to enable more interesting behavior in the future.
Test Plan:
ApplicationEditor forms now let you manage available forms and edit the current form:
{F959025}
There's a new (bare bones) list of all available engines:
{F959030}
And if you jump into an engine, you can see all the forms for it:
{F959038}
The actual form configurations have standard detail/edit pages. The edit pages are themselves driven by ApplicationEditor, of course, so you can edit the form for editing forms.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9132
Differential Revision: https://secure.phabricator.com/D14453
2015-11-04 21:52:52 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
final class PhabricatorEditEngineConfigurationViewController
|
|
|
|
|
extends PhabricatorEditEngineController {
|
|
|
|
|
|
|
|
|
|
public function shouldAllowPublic() {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
|
|
|
$viewer = $this->getViewer();
|
|
|
|
|
|
2015-12-07 23:55:05 +01:00
|
|
|
$config = $this->loadConfigForView();
|
Allow ApplicationEditor forms to be reconfigured
Summary:
Ref T9132. This diff doesn't do anything interesting, it just lays the groundwork for more interesting future diffs.
Broadly, the idea here is to let you create multiple views of each edit form. For example, we might create several different "Create Task" forms, like:
- "New Bug Report"
- "New Feature Request"
These would be views of the "Create Task" form, but with various adjustments:
- A form might have additional instructions ("how to file a good bug report").
- A form might have prefilled values for some fields (like particular projects, subscribers, or policies).
- A form might have some fields locked (so they can not be edited) or hidden.
- A form might have a different field order.
- A form might have a limited visibility policy, so only some users can access it.
This diff adds a new storage object (`EditEngineConfiguration`) to keep track of all those customizations and represent "a form which has been configured to look and work a certain way".
This doesn't let these configurations do anything useful/interesting, and you can't access them directly yet, it's just all the boring plumbing to enable more interesting behavior in the future.
Test Plan:
ApplicationEditor forms now let you manage available forms and edit the current form:
{F959025}
There's a new (bare bones) list of all available engines:
{F959030}
And if you jump into an engine, you can see all the forms for it:
{F959038}
The actual form configurations have standard detail/edit pages. The edit pages are themselves driven by ApplicationEditor, of course, so you can edit the form for editing forms.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9132
Differential Revision: https://secure.phabricator.com/D14453
2015-11-04 21:52:52 +01:00
|
|
|
if (!$config) {
|
|
|
|
|
return id(new Aphront404Response());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$is_concrete = (bool)$config->getID();
|
|
|
|
|
|
|
|
|
|
$actions = $this->buildActionView($config);
|
|
|
|
|
|
|
|
|
|
$properties = $this->buildPropertyView($config)
|
|
|
|
|
->setActionList($actions);
|
|
|
|
|
|
|
|
|
|
$header = id(new PHUIHeaderView())
|
|
|
|
|
->setUser($viewer)
|
|
|
|
|
->setPolicyObject($config)
|
|
|
|
|
->setHeader(pht('Edit Form: %s', $config->getDisplayName()));
|
|
|
|
|
|
|
|
|
|
$box = id(new PHUIObjectBoxView())
|
|
|
|
|
->setHeader($header)
|
|
|
|
|
->addPropertyList($properties);
|
|
|
|
|
|
2015-11-17 18:33:06 +01:00
|
|
|
$field_list = $this->buildFieldList($config);
|
|
|
|
|
|
Allow ApplicationEditor forms to be reconfigured
Summary:
Ref T9132. This diff doesn't do anything interesting, it just lays the groundwork for more interesting future diffs.
Broadly, the idea here is to let you create multiple views of each edit form. For example, we might create several different "Create Task" forms, like:
- "New Bug Report"
- "New Feature Request"
These would be views of the "Create Task" form, but with various adjustments:
- A form might have additional instructions ("how to file a good bug report").
- A form might have prefilled values for some fields (like particular projects, subscribers, or policies).
- A form might have some fields locked (so they can not be edited) or hidden.
- A form might have a different field order.
- A form might have a limited visibility policy, so only some users can access it.
This diff adds a new storage object (`EditEngineConfiguration`) to keep track of all those customizations and represent "a form which has been configured to look and work a certain way".
This doesn't let these configurations do anything useful/interesting, and you can't access them directly yet, it's just all the boring plumbing to enable more interesting behavior in the future.
Test Plan:
ApplicationEditor forms now let you manage available forms and edit the current form:
{F959025}
There's a new (bare bones) list of all available engines:
{F959030}
And if you jump into an engine, you can see all the forms for it:
{F959038}
The actual form configurations have standard detail/edit pages. The edit pages are themselves driven by ApplicationEditor, of course, so you can edit the form for editing forms.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9132
Differential Revision: https://secure.phabricator.com/D14453
2015-11-04 21:52:52 +01:00
|
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
|
|
|
|
|
|
|
|
if ($is_concrete) {
|
|
|
|
|
$crumbs->addTextCrumb(pht('Form %d', $config->getID()));
|
|
|
|
|
} else {
|
|
|
|
|
$crumbs->addTextCrumb(pht('Builtin'));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if ($is_concrete) {
|
|
|
|
|
$timeline = $this->buildTransactionTimeline(
|
|
|
|
|
$config,
|
|
|
|
|
new PhabricatorEditEngineConfigurationTransactionQuery());
|
|
|
|
|
|
|
|
|
|
$timeline->setShouldTerminate(true);
|
|
|
|
|
} else {
|
|
|
|
|
$timeline = null;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return $this->newPage()
|
|
|
|
|
->setCrumbs($crumbs)
|
|
|
|
|
->appendChild(
|
|
|
|
|
array(
|
|
|
|
|
$box,
|
2015-11-17 18:33:06 +01:00
|
|
|
$field_list,
|
Allow ApplicationEditor forms to be reconfigured
Summary:
Ref T9132. This diff doesn't do anything interesting, it just lays the groundwork for more interesting future diffs.
Broadly, the idea here is to let you create multiple views of each edit form. For example, we might create several different "Create Task" forms, like:
- "New Bug Report"
- "New Feature Request"
These would be views of the "Create Task" form, but with various adjustments:
- A form might have additional instructions ("how to file a good bug report").
- A form might have prefilled values for some fields (like particular projects, subscribers, or policies).
- A form might have some fields locked (so they can not be edited) or hidden.
- A form might have a different field order.
- A form might have a limited visibility policy, so only some users can access it.
This diff adds a new storage object (`EditEngineConfiguration`) to keep track of all those customizations and represent "a form which has been configured to look and work a certain way".
This doesn't let these configurations do anything useful/interesting, and you can't access them directly yet, it's just all the boring plumbing to enable more interesting behavior in the future.
Test Plan:
ApplicationEditor forms now let you manage available forms and edit the current form:
{F959025}
There's a new (bare bones) list of all available engines:
{F959030}
And if you jump into an engine, you can see all the forms for it:
{F959038}
The actual form configurations have standard detail/edit pages. The edit pages are themselves driven by ApplicationEditor, of course, so you can edit the form for editing forms.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9132
Differential Revision: https://secure.phabricator.com/D14453
2015-11-04 21:52:52 +01:00
|
|
|
$timeline,
|
|
|
|
|
));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private function buildActionView(
|
|
|
|
|
PhabricatorEditEngineConfiguration $config) {
|
|
|
|
|
$viewer = $this->getViewer();
|
2015-11-17 18:33:06 +01:00
|
|
|
$engine = $config->getEngine();
|
|
|
|
|
$engine_key = $engine->getEngineKey();
|
Allow ApplicationEditor forms to be reconfigured
Summary:
Ref T9132. This diff doesn't do anything interesting, it just lays the groundwork for more interesting future diffs.
Broadly, the idea here is to let you create multiple views of each edit form. For example, we might create several different "Create Task" forms, like:
- "New Bug Report"
- "New Feature Request"
These would be views of the "Create Task" form, but with various adjustments:
- A form might have additional instructions ("how to file a good bug report").
- A form might have prefilled values for some fields (like particular projects, subscribers, or policies).
- A form might have some fields locked (so they can not be edited) or hidden.
- A form might have a different field order.
- A form might have a limited visibility policy, so only some users can access it.
This diff adds a new storage object (`EditEngineConfiguration`) to keep track of all those customizations and represent "a form which has been configured to look and work a certain way".
This doesn't let these configurations do anything useful/interesting, and you can't access them directly yet, it's just all the boring plumbing to enable more interesting behavior in the future.
Test Plan:
ApplicationEditor forms now let you manage available forms and edit the current form:
{F959025}
There's a new (bare bones) list of all available engines:
{F959030}
And if you jump into an engine, you can see all the forms for it:
{F959038}
The actual form configurations have standard detail/edit pages. The edit pages are themselves driven by ApplicationEditor, of course, so you can edit the form for editing forms.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9132
Differential Revision: https://secure.phabricator.com/D14453
2015-11-04 21:52:52 +01:00
|
|
|
|
|
|
|
|
$can_edit = PhabricatorPolicyFilter::hasCapability(
|
|
|
|
|
$viewer,
|
|
|
|
|
$config,
|
|
|
|
|
PhabricatorPolicyCapability::CAN_EDIT);
|
|
|
|
|
|
|
|
|
|
$view = id(new PhabricatorActionListView())
|
|
|
|
|
->setUser($viewer);
|
|
|
|
|
|
2015-11-17 18:33:06 +01:00
|
|
|
$form_key = $config->getIdentifier();
|
Allow ApplicationEditor forms to be reconfigured
Summary:
Ref T9132. This diff doesn't do anything interesting, it just lays the groundwork for more interesting future diffs.
Broadly, the idea here is to let you create multiple views of each edit form. For example, we might create several different "Create Task" forms, like:
- "New Bug Report"
- "New Feature Request"
These would be views of the "Create Task" form, but with various adjustments:
- A form might have additional instructions ("how to file a good bug report").
- A form might have prefilled values for some fields (like particular projects, subscribers, or policies).
- A form might have some fields locked (so they can not be edited) or hidden.
- A form might have a different field order.
- A form might have a limited visibility policy, so only some users can access it.
This diff adds a new storage object (`EditEngineConfiguration`) to keep track of all those customizations and represent "a form which has been configured to look and work a certain way".
This doesn't let these configurations do anything useful/interesting, and you can't access them directly yet, it's just all the boring plumbing to enable more interesting behavior in the future.
Test Plan:
ApplicationEditor forms now let you manage available forms and edit the current form:
{F959025}
There's a new (bare bones) list of all available engines:
{F959030}
And if you jump into an engine, you can see all the forms for it:
{F959038}
The actual form configurations have standard detail/edit pages. The edit pages are themselves driven by ApplicationEditor, of course, so you can edit the form for editing forms.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9132
Differential Revision: https://secure.phabricator.com/D14453
2015-11-04 21:52:52 +01:00
|
|
|
|
|
|
|
|
$base_uri = "/transactions/editengine/{$engine_key}";
|
|
|
|
|
|
|
|
|
|
$is_concrete = (bool)$config->getID();
|
|
|
|
|
if (!$is_concrete) {
|
2015-11-17 18:33:06 +01:00
|
|
|
$save_uri = "{$base_uri}/save/{$form_key}/";
|
Allow ApplicationEditor forms to be reconfigured
Summary:
Ref T9132. This diff doesn't do anything interesting, it just lays the groundwork for more interesting future diffs.
Broadly, the idea here is to let you create multiple views of each edit form. For example, we might create several different "Create Task" forms, like:
- "New Bug Report"
- "New Feature Request"
These would be views of the "Create Task" form, but with various adjustments:
- A form might have additional instructions ("how to file a good bug report").
- A form might have prefilled values for some fields (like particular projects, subscribers, or policies).
- A form might have some fields locked (so they can not be edited) or hidden.
- A form might have a different field order.
- A form might have a limited visibility policy, so only some users can access it.
This diff adds a new storage object (`EditEngineConfiguration`) to keep track of all those customizations and represent "a form which has been configured to look and work a certain way".
This doesn't let these configurations do anything useful/interesting, and you can't access them directly yet, it's just all the boring plumbing to enable more interesting behavior in the future.
Test Plan:
ApplicationEditor forms now let you manage available forms and edit the current form:
{F959025}
There's a new (bare bones) list of all available engines:
{F959030}
And if you jump into an engine, you can see all the forms for it:
{F959038}
The actual form configurations have standard detail/edit pages. The edit pages are themselves driven by ApplicationEditor, of course, so you can edit the form for editing forms.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9132
Differential Revision: https://secure.phabricator.com/D14453
2015-11-04 21:52:52 +01:00
|
|
|
|
|
|
|
|
$view->addAction(
|
|
|
|
|
id(new PhabricatorActionView())
|
|
|
|
|
->setName(pht('Make Editable'))
|
|
|
|
|
->setIcon('fa-pencil')
|
|
|
|
|
->setDisabled(!$can_edit)
|
|
|
|
|
->setWorkflow(true)
|
|
|
|
|
->setHref($save_uri));
|
|
|
|
|
|
|
|
|
|
$can_edit = false;
|
|
|
|
|
} else {
|
2015-11-17 18:33:06 +01:00
|
|
|
$edit_uri = "{$base_uri}/edit/{$form_key}/";
|
Allow ApplicationEditor forms to be reconfigured
Summary:
Ref T9132. This diff doesn't do anything interesting, it just lays the groundwork for more interesting future diffs.
Broadly, the idea here is to let you create multiple views of each edit form. For example, we might create several different "Create Task" forms, like:
- "New Bug Report"
- "New Feature Request"
These would be views of the "Create Task" form, but with various adjustments:
- A form might have additional instructions ("how to file a good bug report").
- A form might have prefilled values for some fields (like particular projects, subscribers, or policies).
- A form might have some fields locked (so they can not be edited) or hidden.
- A form might have a different field order.
- A form might have a limited visibility policy, so only some users can access it.
This diff adds a new storage object (`EditEngineConfiguration`) to keep track of all those customizations and represent "a form which has been configured to look and work a certain way".
This doesn't let these configurations do anything useful/interesting, and you can't access them directly yet, it's just all the boring plumbing to enable more interesting behavior in the future.
Test Plan:
ApplicationEditor forms now let you manage available forms and edit the current form:
{F959025}
There's a new (bare bones) list of all available engines:
{F959030}
And if you jump into an engine, you can see all the forms for it:
{F959038}
The actual form configurations have standard detail/edit pages. The edit pages are themselves driven by ApplicationEditor, of course, so you can edit the form for editing forms.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9132
Differential Revision: https://secure.phabricator.com/D14453
2015-11-04 21:52:52 +01:00
|
|
|
$view->addAction(
|
|
|
|
|
id(new PhabricatorActionView())
|
|
|
|
|
->setName(pht('Edit Form Configuration'))
|
|
|
|
|
->setIcon('fa-pencil')
|
|
|
|
|
->setDisabled(!$can_edit)
|
|
|
|
|
->setWorkflow(!$can_edit)
|
|
|
|
|
->setHref($edit_uri));
|
|
|
|
|
}
|
|
|
|
|
|
2015-11-17 18:33:06 +01:00
|
|
|
$use_uri = $engine->getEditURI(null, "form/{$form_key}/");
|
|
|
|
|
|
|
|
|
|
$view->addAction(
|
|
|
|
|
id(new PhabricatorActionView())
|
|
|
|
|
->setName(pht('Use Form'))
|
|
|
|
|
->setIcon('fa-th-list')
|
|
|
|
|
->setHref($use_uri));
|
|
|
|
|
|
2015-11-18 19:38:12 +01:00
|
|
|
$defaults_uri = "{$base_uri}/defaults/{$form_key}/";
|
|
|
|
|
|
|
|
|
|
$view->addAction(
|
|
|
|
|
id(new PhabricatorActionView())
|
|
|
|
|
->setName(pht('Change Default Values'))
|
|
|
|
|
->setIcon('fa-paint-brush')
|
|
|
|
|
->setHref($defaults_uri)
|
|
|
|
|
->setWorkflow(!$can_edit)
|
|
|
|
|
->setDisabled(!$can_edit));
|
|
|
|
|
|
2015-11-17 18:33:06 +01:00
|
|
|
$reorder_uri = "{$base_uri}/reorder/{$form_key}/";
|
|
|
|
|
|
|
|
|
|
$view->addAction(
|
|
|
|
|
id(new PhabricatorActionView())
|
2015-11-18 19:38:12 +01:00
|
|
|
->setName(pht('Change Field Order'))
|
2015-11-17 18:33:06 +01:00
|
|
|
->setIcon('fa-sort-alpha-asc')
|
|
|
|
|
->setHref($reorder_uri)
|
|
|
|
|
->setWorkflow(true)
|
|
|
|
|
->setDisabled(!$can_edit));
|
|
|
|
|
|
2015-11-18 19:50:09 +01:00
|
|
|
$lock_uri = "{$base_uri}/lock/{$form_key}/";
|
|
|
|
|
|
|
|
|
|
$view->addAction(
|
|
|
|
|
id(new PhabricatorActionView())
|
|
|
|
|
->setName(pht('Lock / Hide Fields'))
|
|
|
|
|
->setIcon('fa-lock')
|
|
|
|
|
->setHref($lock_uri)
|
|
|
|
|
->setWorkflow(true)
|
|
|
|
|
->setDisabled(!$can_edit));
|
|
|
|
|
|
2015-11-19 23:16:44 +01:00
|
|
|
$disable_uri = "{$base_uri}/disable/{$form_key}/";
|
|
|
|
|
|
|
|
|
|
if ($config->getIsDisabled()) {
|
|
|
|
|
$disable_name = pht('Enable Form');
|
|
|
|
|
$disable_icon = 'fa-check';
|
|
|
|
|
} else {
|
|
|
|
|
$disable_name = pht('Disable Form');
|
|
|
|
|
$disable_icon = 'fa-ban';
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$view->addAction(
|
|
|
|
|
id(new PhabricatorActionView())
|
|
|
|
|
->setName($disable_name)
|
|
|
|
|
->setIcon($disable_icon)
|
|
|
|
|
->setHref($disable_uri)
|
|
|
|
|
->setWorkflow(true)
|
|
|
|
|
->setDisabled(!$can_edit));
|
|
|
|
|
|
|
|
|
|
$defaultcreate_uri = "{$base_uri}/defaultcreate/{$form_key}/";
|
|
|
|
|
|
|
|
|
|
if ($config->getIsDefault()) {
|
2015-12-09 13:51:33 +01:00
|
|
|
$defaultcreate_name = pht('Unmark as "Create" Form');
|
2015-11-19 23:16:44 +01:00
|
|
|
$defaultcreate_icon = 'fa-minus';
|
|
|
|
|
} else {
|
2015-12-09 13:51:33 +01:00
|
|
|
$defaultcreate_name = pht('Mark as "Create" Form');
|
2015-11-19 23:16:44 +01:00
|
|
|
$defaultcreate_icon = 'fa-plus';
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$view->addAction(
|
|
|
|
|
id(new PhabricatorActionView())
|
|
|
|
|
->setName($defaultcreate_name)
|
|
|
|
|
->setIcon($defaultcreate_icon)
|
|
|
|
|
->setHref($defaultcreate_uri)
|
|
|
|
|
->setWorkflow(true)
|
|
|
|
|
->setDisabled(!$can_edit));
|
|
|
|
|
|
Allow EditEngine forms to be marked as "edit" forms
Summary:
Ref T9132. Ref T9908. This attempts to move us forward on answering this question:
> Which form gets used when a user clicks "Edit Task"?
One answer is "the same form that was used to create the task". There are several problems with that:
- The form might not exist anymore.
- The user might not have permission to see it.
- Some of the fields might be hidden, essentially preventing them from being edited.
- We have to store the value somewhere and old tasks won't have a value.
- Any instructions on the form probably don't apply to edits.
One answer is "force the default, full form". That's not as problematic, but it means we have no ability to create limited access users who see fewer fields.
The answer in this diff is:
- Forms can be marked as "edit forms".
- We take the user to the first edit form they have permission to see, from a master list.
This allows you to create several forms like:
- Advanced Edit Form (say, all fields -- visible to administrators).
- Basic Edit Form (say, no policies -- visible to trusted users).
- Noob Edit Form (say, no policies, priorities, or status -- visible to everyone).
Then you can give everyone access to "noob", some people access to "basic", and a few people access to "advanced".
This might only be part of the answer. In particular, you can still //use// any edit form you can see, so we could do these things in the future:
- Give you an option to switch to a different form if you want.
- Save the form the task was created with, and use that form by default.
If we do pursue those, we can fall back to this behavior if there's a problem with them (e.g., original form doesn't exist or wasn't recorded).
There's also no "reorder" UI yet, that'll be coming in the next diff.
I'm also going to try to probably make the "create" and "edit" stuff a little more consistent / less weird in a bit.
Test Plan: Marked various forms as edit forms or not edit forms, made edits, hit permissions errors, etc.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9132, T9908
Differential Revision: https://secure.phabricator.com/D14702
2015-12-08 02:11:35 +01:00
|
|
|
if ($config->getIsEdit()) {
|
|
|
|
|
$isedit_name = pht('Unmark as "Edit" Form');
|
|
|
|
|
$isedit_icon = 'fa-minus';
|
|
|
|
|
} else {
|
|
|
|
|
$isedit_name = pht('Mark as "Edit" Form');
|
|
|
|
|
$isedit_icon = 'fa-plus';
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$isedit_uri = "{$base_uri}/defaultedit/{$form_key}/";
|
|
|
|
|
|
|
|
|
|
$view->addAction(
|
|
|
|
|
id(new PhabricatorActionView())
|
|
|
|
|
->setName($isedit_name)
|
|
|
|
|
->setIcon($isedit_icon)
|
|
|
|
|
->setHref($isedit_uri)
|
|
|
|
|
->setWorkflow(true)
|
|
|
|
|
->setDisabled(!$can_edit));
|
|
|
|
|
|
Allow ApplicationEditor forms to be reconfigured
Summary:
Ref T9132. This diff doesn't do anything interesting, it just lays the groundwork for more interesting future diffs.
Broadly, the idea here is to let you create multiple views of each edit form. For example, we might create several different "Create Task" forms, like:
- "New Bug Report"
- "New Feature Request"
These would be views of the "Create Task" form, but with various adjustments:
- A form might have additional instructions ("how to file a good bug report").
- A form might have prefilled values for some fields (like particular projects, subscribers, or policies).
- A form might have some fields locked (so they can not be edited) or hidden.
- A form might have a different field order.
- A form might have a limited visibility policy, so only some users can access it.
This diff adds a new storage object (`EditEngineConfiguration`) to keep track of all those customizations and represent "a form which has been configured to look and work a certain way".
This doesn't let these configurations do anything useful/interesting, and you can't access them directly yet, it's just all the boring plumbing to enable more interesting behavior in the future.
Test Plan:
ApplicationEditor forms now let you manage available forms and edit the current form:
{F959025}
There's a new (bare bones) list of all available engines:
{F959030}
And if you jump into an engine, you can see all the forms for it:
{F959038}
The actual form configurations have standard detail/edit pages. The edit pages are themselves driven by ApplicationEditor, of course, so you can edit the form for editing forms.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9132
Differential Revision: https://secure.phabricator.com/D14453
2015-11-04 21:52:52 +01:00
|
|
|
return $view;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
private function buildPropertyView(
|
|
|
|
|
PhabricatorEditEngineConfiguration $config) {
|
|
|
|
|
$viewer = $this->getViewer();
|
|
|
|
|
|
|
|
|
|
$properties = id(new PHUIPropertyListView())
|
|
|
|
|
->setUser($viewer)
|
|
|
|
|
->setObject($config);
|
|
|
|
|
|
|
|
|
|
return $properties;
|
|
|
|
|
}
|
|
|
|
|
|
2015-11-17 18:33:06 +01:00
|
|
|
private function buildFieldList(PhabricatorEditEngineConfiguration $config) {
|
|
|
|
|
$viewer = $this->getViewer();
|
|
|
|
|
$engine = $config->getEngine();
|
|
|
|
|
|
|
|
|
|
$fields = $engine->getFieldsForConfig($config);
|
|
|
|
|
|
|
|
|
|
$form = id(new AphrontFormView())
|
|
|
|
|
->setUser($viewer)
|
|
|
|
|
->setAction(null);
|
|
|
|
|
|
|
|
|
|
foreach ($fields as $field) {
|
|
|
|
|
$field->setIsPreview(true);
|
|
|
|
|
|
|
|
|
|
$field->appendToForm($form);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
$info = id(new PHUIInfoView())
|
|
|
|
|
->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
|
|
|
|
|
->setErrors(
|
|
|
|
|
array(
|
|
|
|
|
pht('This is a preview of the current form configuration.'),
|
|
|
|
|
));
|
|
|
|
|
|
|
|
|
|
$box = id(new PHUIObjectBoxView())
|
|
|
|
|
->setHeaderText(pht('Form Preview'))
|
|
|
|
|
->setInfoView($info)
|
|
|
|
|
->setForm($form);
|
|
|
|
|
|
|
|
|
|
return $box;
|
|
|
|
|
}
|
Allow ApplicationEditor forms to be reconfigured
Summary:
Ref T9132. This diff doesn't do anything interesting, it just lays the groundwork for more interesting future diffs.
Broadly, the idea here is to let you create multiple views of each edit form. For example, we might create several different "Create Task" forms, like:
- "New Bug Report"
- "New Feature Request"
These would be views of the "Create Task" form, but with various adjustments:
- A form might have additional instructions ("how to file a good bug report").
- A form might have prefilled values for some fields (like particular projects, subscribers, or policies).
- A form might have some fields locked (so they can not be edited) or hidden.
- A form might have a different field order.
- A form might have a limited visibility policy, so only some users can access it.
This diff adds a new storage object (`EditEngineConfiguration`) to keep track of all those customizations and represent "a form which has been configured to look and work a certain way".
This doesn't let these configurations do anything useful/interesting, and you can't access them directly yet, it's just all the boring plumbing to enable more interesting behavior in the future.
Test Plan:
ApplicationEditor forms now let you manage available forms and edit the current form:
{F959025}
There's a new (bare bones) list of all available engines:
{F959030}
And if you jump into an engine, you can see all the forms for it:
{F959038}
The actual form configurations have standard detail/edit pages. The edit pages are themselves driven by ApplicationEditor, of course, so you can edit the form for editing forms.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9132
Differential Revision: https://secure.phabricator.com/D14453
2015-11-04 21:52:52 +01:00
|
|
|
|
|
|
|
|
}
|