2011-03-23 01:08:08 +01:00
|
|
|
/**
|
|
|
|
* @requires multirow-row-manager
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
* javelin-install
|
|
|
|
* javelin-typeahead
|
|
|
|
* javelin-util
|
|
|
|
* javelin-dom
|
|
|
|
* javelin-tokenizer
|
|
|
|
* javelin-typeahead-preloaded-source
|
|
|
|
* javelin-stratcom
|
|
|
|
* javelin-json
|
2011-07-16 07:30:55 +02:00
|
|
|
* phabricator-prefab
|
2011-03-23 01:08:08 +01:00
|
|
|
* @provides herald-rule-editor
|
|
|
|
* @javelin
|
|
|
|
*/
|
|
|
|
|
|
|
|
JX.install('HeraldRuleEditor', {
|
|
|
|
construct : function(config) {
|
|
|
|
var root = JX.$(config.root);
|
|
|
|
this._root = root;
|
|
|
|
|
|
|
|
JX.DOM.listen(
|
|
|
|
root,
|
|
|
|
'click',
|
|
|
|
'create-condition',
|
|
|
|
JX.bind(this, this._onnewcondition));
|
|
|
|
|
|
|
|
JX.DOM.listen(
|
|
|
|
root,
|
|
|
|
'click',
|
|
|
|
'create-action',
|
|
|
|
JX.bind(this, this._onnewaction));
|
|
|
|
|
|
|
|
JX.DOM.listen(root, 'change', null, JX.bind(this, this._onchange));
|
|
|
|
JX.DOM.listen(root, 'submit', null, JX.bind(this, this._onsubmit));
|
|
|
|
|
|
|
|
var conditionsTable = JX.DOM.find(root, 'table', 'rule-conditions');
|
|
|
|
var actionsTable = JX.DOM.find(root, 'table', 'rule-actions');
|
|
|
|
|
|
|
|
this._conditionsRowManager = new JX.MultirowRowManager(conditionsTable);
|
|
|
|
this._conditionsRowManager.listen(
|
|
|
|
'row-removed',
|
|
|
|
JX.bind(this, function(row_id) {
|
|
|
|
delete this._config.conditions[row_id];
|
|
|
|
}));
|
|
|
|
|
|
|
|
this._actionsRowManager = new JX.MultirowRowManager(actionsTable);
|
|
|
|
this._actionsRowManager.listen(
|
|
|
|
'row-removed',
|
|
|
|
JX.bind(this, function(row_id) {
|
|
|
|
delete this._config.actions[row_id];
|
|
|
|
}));
|
|
|
|
|
|
|
|
this._conditionGetters = {};
|
|
|
|
this._conditionTypes = {};
|
|
|
|
this._actionGetters = {};
|
|
|
|
this._actionTypes = {};
|
|
|
|
|
|
|
|
this._config = config;
|
|
|
|
|
|
|
|
var conditions = this._config.conditions;
|
|
|
|
this._config.conditions = [];
|
|
|
|
|
|
|
|
var actions = this._config.actions;
|
|
|
|
this._config.actions = [];
|
|
|
|
|
|
|
|
this._renderConditions(conditions);
|
|
|
|
this._renderActions(actions);
|
|
|
|
},
|
|
|
|
|
|
|
|
members : {
|
|
|
|
_config : null,
|
|
|
|
_root : null,
|
|
|
|
_conditionGetters : null,
|
|
|
|
_conditionTypes : null,
|
|
|
|
_actionGetters : null,
|
|
|
|
_actionTypes : null,
|
|
|
|
_conditionsRowManager : null,
|
|
|
|
_actionsRowManager : null,
|
|
|
|
|
|
|
|
_onnewcondition : function(e) {
|
|
|
|
this._newCondition();
|
|
|
|
e.kill();
|
|
|
|
},
|
|
|
|
_onnewaction : function(e) {
|
|
|
|
this._newAction();
|
|
|
|
e.kill();
|
|
|
|
},
|
|
|
|
_onchange : function(e) {
|
|
|
|
var target = e.getTarget();
|
|
|
|
|
|
|
|
var row = e.getNode(JX.MultirowRowManager.getRowSigil());
|
|
|
|
if (!row) {
|
|
|
|
// Changing the "when all of / any of these..." dropdown.
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (JX.Stratcom.hasSigil(target, 'field-select')) {
|
|
|
|
this._onfieldchange(row);
|
|
|
|
} else if (JX.Stratcom.hasSigil(target, 'condition-select')) {
|
|
|
|
this._onconditionchange(row);
|
|
|
|
} else if (JX.Stratcom.hasSigil(target, 'action-select')) {
|
|
|
|
this._onactionchange(row);
|
|
|
|
}
|
|
|
|
},
|
|
|
|
_onsubmit : function(e) {
|
|
|
|
var rule = JX.DOM.find(this._root, 'input', 'rule');
|
|
|
|
|
|
|
|
var k;
|
|
|
|
|
|
|
|
for (k in this._config.conditions) {
|
|
|
|
this._config.conditions[k][2] = this._getConditionValue(k);
|
|
|
|
}
|
|
|
|
|
|
|
|
var acts = this._config.actions;
|
|
|
|
for (k in this._config.actions) {
|
|
|
|
this._config.actions[k][1] = this._getActionTarget(k);
|
|
|
|
}
|
2011-07-05 23:17:38 +02:00
|
|
|
rule.value = JX.JSON.stringify({
|
2011-03-23 01:08:08 +01:00
|
|
|
conditions: this._config.conditions,
|
|
|
|
actions: this._config.actions
|
|
|
|
});
|
|
|
|
},
|
|
|
|
|
|
|
|
_getConditionValue : function(id) {
|
|
|
|
if (this._conditionGetters[id]) {
|
|
|
|
return this._conditionGetters[id]();
|
|
|
|
}
|
|
|
|
return this._config.conditions[id][2];
|
|
|
|
},
|
|
|
|
|
|
|
|
_getActionTarget : function(id) {
|
|
|
|
if (this._actionGetters[id]) {
|
|
|
|
return this._actionGetters[id]();
|
|
|
|
}
|
|
|
|
return this._config.actions[id][1];
|
|
|
|
},
|
|
|
|
|
|
|
|
_onactionchange : function(r) {
|
|
|
|
var target = JX.DOM.find(r, 'select', 'action-select');
|
|
|
|
var row_id = this._actionsRowManager.getRowID(r);
|
|
|
|
|
|
|
|
this._config.actions[row_id][0] = target.value;
|
|
|
|
|
|
|
|
var target_cell = JX.DOM.find(r, 'td', 'target-cell');
|
|
|
|
var target_input = this._renderTargetInputForRow(row_id);
|
|
|
|
|
|
|
|
JX.DOM.setContent(target_cell, target_input);
|
|
|
|
},
|
|
|
|
_onfieldchange : function(r) {
|
|
|
|
var target = JX.DOM.find(r, 'select', 'field-select');
|
|
|
|
var row_id = this._actionsRowManager.getRowID(r);
|
|
|
|
|
|
|
|
this._config.conditions[row_id][0] = target.value;
|
|
|
|
|
|
|
|
var condition_cell = JX.DOM.find(r, 'td', 'condition-cell');
|
|
|
|
var condition_select = this._renderSelect(
|
|
|
|
this._selectKeys(
|
|
|
|
this._config.info.conditions,
|
|
|
|
this._config.info.conditionMap[target.value]),
|
|
|
|
this._config.conditions[row_id][1],
|
|
|
|
'condition-select');
|
|
|
|
|
|
|
|
JX.DOM.setContent(condition_cell, condition_select);
|
|
|
|
|
|
|
|
this._onconditionchange(r);
|
2013-10-04 02:53:12 +02:00
|
|
|
|
|
|
|
var condition_name = this._config.conditions[row_id][1];
|
2013-10-05 00:17:01 +02:00
|
|
|
if (condition_name == 'unconditionally') {
|
|
|
|
JX.DOM.hide(condition_select);
|
2013-10-04 02:53:12 +02:00
|
|
|
}
|
2011-03-23 01:08:08 +01:00
|
|
|
},
|
|
|
|
_onconditionchange : function(r) {
|
|
|
|
var target = JX.DOM.find(r, 'select', 'condition-select');
|
|
|
|
var row_id = this._conditionsRowManager.getRowID(r);
|
|
|
|
|
|
|
|
this._config.conditions[row_id][1] = target.value;
|
|
|
|
|
|
|
|
var value_cell = JX.DOM.find(r, 'td', 'value-cell');
|
|
|
|
var value_input = this._renderValueInputForRow(row_id);
|
|
|
|
JX.DOM.setContent(value_cell, value_input);
|
|
|
|
},
|
|
|
|
|
|
|
|
_renderTargetInputForRow : function(row_id) {
|
|
|
|
var action = this._config.actions[row_id];
|
|
|
|
var type = this._config.info.targets[action[0]];
|
|
|
|
|
|
|
|
var input = this._buildInput(type);
|
|
|
|
var node = input[0];
|
|
|
|
var get_fn = input[1];
|
|
|
|
var set_fn = input[2];
|
|
|
|
|
|
|
|
if (node) {
|
|
|
|
JX.Stratcom.addSigil(node, 'action-target');
|
|
|
|
}
|
|
|
|
|
|
|
|
var old_type = this._actionTypes[row_id];
|
|
|
|
if (old_type == type || !old_type) {
|
|
|
|
set_fn(this._getActionTarget(row_id));
|
|
|
|
}
|
|
|
|
|
|
|
|
this._actionTypes[row_id] = type;
|
|
|
|
this._actionGetters[row_id] = get_fn;
|
|
|
|
|
|
|
|
return node;
|
|
|
|
},
|
|
|
|
|
|
|
|
_buildInput : function(type) {
|
|
|
|
var input;
|
|
|
|
var get_fn;
|
|
|
|
var set_fn;
|
|
|
|
switch (type) {
|
|
|
|
case 'rule':
|
|
|
|
input = this._renderSelect(this._config.template.rules);
|
|
|
|
get_fn = function() { return input.value; };
|
|
|
|
set_fn = function(v) { input.value = v; };
|
|
|
|
break;
|
|
|
|
case 'email':
|
2011-03-23 04:41:02 +01:00
|
|
|
case 'user':
|
2011-03-23 01:08:08 +01:00
|
|
|
case 'repository':
|
|
|
|
case 'tag':
|
|
|
|
case 'package':
|
Allow Herald to trigger audits for users or projects
Summary:
Allows you to write a commit rule that triggers an audit by a user (personal
rules) or a project (global rules).
Mostly this is trying to make auditing more lightweight and accessible in
environments where setting up Owners packages doesn't make sense.
For instance, Disqus wants a rule like "trigger an audit for everything that
didn't have a Differential revision". While not necessarily scalable, this is a
perfectly reasonable rule for a small company, but a lot of work to implement
with Owners (and you'll get a lot of collateral damage if you don't make every
committer a project owner).
Instead, they can create a project called 'Unreviewed Commits' and write a rule
like:
- When: Differential revision does not exist
- Action: Trigger an Audit for project: "Unreviewed Commits"
Then whoever cares can join that project and they'll see those audits in their
queue, and when they approve/raise on commits their actions will affect the
project audit.
Similarly, if I want to look at all commits that match some other rule (say,
XSS) but only want to do it like once a month, I can just set up an audit rule
and go through the queue when I feel like it.
NOTE: This abuses the 'packagePHID' field to also store user and project PHIDs.
Through the magic of handles, this (apparently) works fine for now; I'll do a
big schema patch soon but have several other edits I want to make at the same
time.
Also:
- Adds an "active" fiew for /audit/, eventually this will be like the
Differential "active" view (stuff that is relevant to you right now).
- On commits, highlight triggered audits you are responsible for.
Test Plan: Added personal and global audit triggers to Herald, reparsed some
commits with --herald, got audits. Browsed all audit interfaces to make sure
nothing exploded. Viewed a commit where I was responsible for only some audits.
Performed audits and made sure the triggers I am supposed to be responsible for
updated properly.
Reviewers: btrahan, jungejason
Reviewed By: jungejason
CC: aran, epriestley
Maniphest Tasks: T904
Differential Revision: https://secure.phabricator.com/D1690
2012-02-27 18:36:30 +01:00
|
|
|
case 'project':
|
2011-03-23 01:08:08 +01:00
|
|
|
var tokenizer = this._newTokenizer(type);
|
|
|
|
input = tokenizer[0];
|
|
|
|
get_fn = tokenizer[1];
|
|
|
|
set_fn = tokenizer[2];
|
|
|
|
break;
|
|
|
|
case 'none':
|
|
|
|
input = '';
|
|
|
|
get_fn = JX.bag;
|
|
|
|
set_fn = JX.bag;
|
|
|
|
break;
|
2013-09-26 23:20:56 +02:00
|
|
|
case 'contentsource':
|
|
|
|
input = this._renderSelect(this._config.template.contentSources);
|
|
|
|
get_fn = function() { return input.value; };
|
|
|
|
set_fn = function(v) { input.value = v; };
|
|
|
|
set_fn(this._config.template.defaultSource);
|
|
|
|
break;
|
2012-03-30 22:51:54 +02:00
|
|
|
case 'flagcolor':
|
|
|
|
input = this._renderSelect(this._config.template.colors);
|
|
|
|
get_fn = function() { return input.value; };
|
|
|
|
set_fn = function(v) { input.value = v; };
|
|
|
|
set_fn(this._config.template.defaultColor);
|
|
|
|
break;
|
2011-03-23 01:08:08 +01:00
|
|
|
default:
|
Update form styles, implement in many places
Summary:
This creates a common form look and feel across the site. I spent a bit of time working out a number of kinks in our various renderings. Some things:
- Font Styles are correctly applied for form elements now.
- Everything lines up!
- Selects are larger, easier to read, interact.
- Inputs have been squared.
- Consistant CSS applied glow (try it!)
- Improved Mobile Responsiveness
- CSS applied to all form elements, not just Aphront
- Many other minor tweaks.
I tried to hit as many high profile forms as possible in an effort to increase consistency. Stopped for now and will follow up after this lands. I know Evan is not a super fan of the glow, but after working with it for a week, it's way cleaner and responsive than the OS controls. Give it a try.
Test Plan: Tested many applications, forms, mobile and tablet.
Reviewers: epriestley, btrahan
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5860
2013-05-07 23:07:06 +02:00
|
|
|
input = JX.$N('input', {type: 'text'});
|
2011-03-23 01:08:08 +01:00
|
|
|
get_fn = function() { return input.value; };
|
|
|
|
set_fn = function(v) { input.value = v; };
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return [input, get_fn, set_fn];
|
|
|
|
},
|
|
|
|
|
|
|
|
_renderValueInputForRow : function(row_id) {
|
|
|
|
var cond = this._config.conditions[row_id];
|
|
|
|
var type = this._config.info.values[cond[0]][cond[1]];
|
|
|
|
|
|
|
|
var input = this._buildInput(type);
|
|
|
|
var node = input[0];
|
|
|
|
var get_fn = input[1];
|
|
|
|
var set_fn = input[2];
|
|
|
|
|
|
|
|
if (node) {
|
|
|
|
JX.Stratcom.addSigil(node, 'condition-value');
|
|
|
|
}
|
|
|
|
|
|
|
|
var old_type = this._conditionTypes[row_id];
|
|
|
|
if (old_type == type || !old_type) {
|
|
|
|
set_fn(this._getConditionValue(row_id));
|
|
|
|
}
|
|
|
|
|
|
|
|
this._conditionTypes[row_id] = type;
|
|
|
|
this._conditionGetters[row_id] = get_fn;
|
|
|
|
|
|
|
|
return node;
|
|
|
|
},
|
|
|
|
|
2012-01-05 22:07:08 +01:00
|
|
|
_newTokenizer : function(type, limit) {
|
2011-03-23 01:08:08 +01:00
|
|
|
var template = JX.$N(
|
|
|
|
'div',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
JX.$H(this._config.template.markup));
|
2011-03-23 01:08:08 +01:00
|
|
|
template = template.firstChild;
|
|
|
|
template.id = '';
|
|
|
|
|
|
|
|
var datasource = new JX.TypeaheadPreloadedSource(
|
|
|
|
this._config.template.source[type]);
|
|
|
|
|
|
|
|
var typeahead = new JX.Typeahead(template);
|
|
|
|
typeahead.setDatasource(datasource);
|
|
|
|
|
|
|
|
var tokenizer = new JX.Tokenizer(template);
|
2012-01-05 22:07:08 +01:00
|
|
|
tokenizer.setLimit(limit);
|
2011-03-23 01:08:08 +01:00
|
|
|
tokenizer.setTypeahead(typeahead);
|
|
|
|
tokenizer.start();
|
|
|
|
|
|
|
|
return [
|
|
|
|
template,
|
|
|
|
function() {
|
|
|
|
return tokenizer.getTokens();
|
|
|
|
},
|
|
|
|
function(map) {
|
|
|
|
for (var k in map) {
|
|
|
|
tokenizer.addToken(k, map[k]);
|
|
|
|
}
|
|
|
|
}];
|
|
|
|
},
|
|
|
|
_selectKeys : function(map, keys) {
|
|
|
|
var r = {};
|
|
|
|
for (var ii = 0; ii < keys.length; ii++) {
|
|
|
|
r[keys[ii]] = map[keys[ii]];
|
|
|
|
}
|
|
|
|
return r;
|
|
|
|
},
|
|
|
|
_renderConditions : function(conditions) {
|
|
|
|
for (var k in conditions) {
|
|
|
|
this._newCondition(conditions[k]);
|
|
|
|
}
|
|
|
|
},
|
|
|
|
_newCondition : function(data) {
|
|
|
|
var row = this._conditionsRowManager.addRow([]);
|
|
|
|
var row_id = this._conditionsRowManager.getRowID(row);
|
|
|
|
this._config.conditions[row_id] = data || [null, null, ''];
|
|
|
|
var r = this._conditionsRowManager.updateRow(
|
|
|
|
row_id,
|
|
|
|
this._renderCondition(row_id));
|
|
|
|
|
|
|
|
this._onfieldchange(r);
|
|
|
|
},
|
|
|
|
_renderCondition : function(row_id) {
|
|
|
|
var field_select = this._renderSelect(
|
|
|
|
this._config.info.fields,
|
|
|
|
this._config.conditions[row_id][0],
|
|
|
|
'field-select');
|
|
|
|
var field_cell = JX.$N('td', {sigil: 'field-cell'}, field_select);
|
|
|
|
|
|
|
|
var condition_cell = JX.$N('td', {sigil: 'condition-cell'});
|
|
|
|
var value_cell = JX.$N('td', {className : 'value', sigil: 'value-cell'});
|
|
|
|
|
|
|
|
return [field_cell, condition_cell, value_cell];
|
|
|
|
},
|
|
|
|
_renderActions : function(actions) {
|
|
|
|
for (var k in actions) {
|
|
|
|
this._newAction(actions[k]);
|
|
|
|
delete actions[k];
|
|
|
|
}
|
|
|
|
},
|
|
|
|
_newAction : function(data) {
|
|
|
|
data = data || [];
|
|
|
|
var temprow = this._actionsRowManager.addRow([]);
|
|
|
|
var row_id = this._actionsRowManager.getRowID(temprow);
|
|
|
|
this._config.actions[row_id] = data;
|
|
|
|
var r = this._actionsRowManager.updateRow(row_id,
|
|
|
|
this._renderAction(data));
|
|
|
|
this._onactionchange(r);
|
|
|
|
},
|
|
|
|
_renderAction : function(action) {
|
|
|
|
var action_select = this._renderSelect(
|
|
|
|
this._config.info.actions,
|
|
|
|
action[0],
|
|
|
|
'action-select');
|
|
|
|
var action_cell = JX.$N('td', {sigil: 'action-cell'}, action_select);
|
|
|
|
|
|
|
|
var target_cell = JX.$N(
|
|
|
|
'td',
|
|
|
|
{className : 'target', sigil : 'target-cell'});
|
|
|
|
|
|
|
|
return [action_cell, target_cell];
|
|
|
|
},
|
|
|
|
_renderSelect : function(map, selected, sigil) {
|
2011-07-16 07:30:55 +02:00
|
|
|
var attrs = {
|
|
|
|
sigil : sigil
|
|
|
|
};
|
|
|
|
return JX.Prefab.renderSelect(map, selected, attrs);
|
2011-03-23 01:08:08 +01:00
|
|
|
}
|
|
|
|
}
|
2011-03-23 01:19:52 +01:00
|
|
|
});
|