revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 03:32:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/maniphest/storage/ManiphestTransaction.php

673 lines
20 KiB
PHP
Raw Normal View History

Render Maniphest fields in an application-transactions-compatible way Summary: Improves transaction rendering for custom fields and standard custom fields. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7054
2013-09-22 01:23:17 +02:00
<?php
Rename ManiphestTransactionPro -> ManiphestTransaction Summary: Ref T2217. Pro is the new standard. Test Plan: Lots of `grep`, made a pile of Maniphest views/edits. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7093
2013-09-24 19:49:06 +02:00
final class ManiphestTransaction
Render Maniphest fields in an application-transactions-compatible way Summary: Improves transaction rendering for custom fields and standard custom fields. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7054
2013-09-22 01:23:17 +02:00
extends PhabricatorApplicationTransaction {
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
const TYPE_TITLE = 'title';
const TYPE_STATUS = 'status';
const TYPE_DESCRIPTION = 'description';
const TYPE_OWNER = 'reassign';
const TYPE_CCS = 'ccs';
const TYPE_PROJECTS = 'projects';
const TYPE_PRIORITY = 'priority';
const TYPE_EDGE = 'edge';
const TYPE_ATTACH = 'attach';
Maniphest - move subpriority edits to be transaction powered Summary: ...this was nice to do for boards, since this diff also starts calling this code in the board move case. The big trick is to use the new expandTransactions hook to expand the subpriority transaction into a priority transaction if pertinent. The other stuff is just about hiding these new subpriority extractions. ...also removes the "edit" UI from the default board since we can't actually edit anything and it thus is buggy. Ref T4422. Next step is to move board edits into the editor with their own little transaction. Test Plan: re-orded tasks on a maniphest query, reloaded, and noted re-order stuck. Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Maniphest Tasks: T4422 Differential Revision: https://secure.phabricator.com/D8358
2014-02-27 18:39:59 +01:00
const TYPE_SUBPRIORITY = 'subpriority';
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
Render Maniphest fields in an application-transactions-compatible way Summary: Improves transaction rendering for custom fields and standard custom fields. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7054
2013-09-22 01:23:17 +02:00
public function getApplicationName() {
return 'maniphest';
}
public function getApplicationTransactionType() {
return ManiphestPHIDTypeTask::TYPECONST;
}
public function getApplicationTransactionCommentObject() {
Add storage for new Maniphest transactions Summary: Ref T2217. Add the tables and comment class for the new stuff. Not used yet. Test Plan: Ran storage upgrade, browsed Maniphest. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7066
2013-09-23 23:24:58 +02:00
return new ManiphestTransactionComment();
Render Maniphest fields in an application-transactions-compatible way Summary: Improves transaction rendering for custom fields and standard custom fields. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7054
2013-09-22 01:23:17 +02:00
}
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
public function getRequiredHandlePHIDs() {
$phids = parent::getRequiredHandlePHIDs();
$new = $this->getNewValue();
$old = $this->getOldValue();
switch ($this->getTransactionType()) {
case self::TYPE_OWNER:
if ($new) {
$phids[] = $new;
}
if ($old) {
$phids[] = $old;
}
break;
case self::TYPE_CCS:
case self::TYPE_PROJECTS:
$phids = array_mergev(
array(
$phids,
nonempty($old, array()),
nonempty($new, array()),
));
break;
case self::TYPE_EDGE:
$phids = array_mergev(
array(
$phids,
array_keys(nonempty($old, array())),
array_keys(nonempty($new, array())),
));
break;
case self::TYPE_ATTACH:
$old = nonempty($old, array());
$new = nonempty($new, array());
$phids = array_mergev(
array(
$phids,
array_keys(idx($new, 'FILE', array())),
array_keys(idx($old, 'FILE', array())),
));
break;
}
return $phids;
}
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
public function shouldHide() {
switch ($this->getTransactionType()) {
case self::TYPE_TITLE:
case self::TYPE_DESCRIPTION:
lipsum - tighten up some test data generation Summary: maniphest tasks were fataling with priority 0 before making sure to add the return null if new object trick to the maniphest pro editor. pholio had a problem where if you had no jpegs you were walking off array_rand. tighten the math and then just return a built-in if no uploaded user images could be found. Fixes T3889. Test Plan: bin/lipsum generate for a few minutes and no errors Reviewers: epriestley Reviewed By: epriestley CC: Korvin, aran Maniphest Tasks: T3889 Differential Revision: https://secure.phabricator.com/D7222
2013-10-05 00:29:32 +02:00
case self::TYPE_PRIORITY:
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
if ($this->getOldValue() === null) {
return true;
} else {
return false;
}
break;
Maniphest - move subpriority edits to be transaction powered Summary: ...this was nice to do for boards, since this diff also starts calling this code in the board move case. The big trick is to use the new expandTransactions hook to expand the subpriority transaction into a priority transaction if pertinent. The other stuff is just about hiding these new subpriority extractions. ...also removes the "edit" UI from the default board since we can't actually edit anything and it thus is buggy. Ref T4422. Next step is to move board edits into the editor with their own little transaction. Test Plan: re-orded tasks on a maniphest query, reloaded, and noted re-order stuck. Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Maniphest Tasks: T4422 Differential Revision: https://secure.phabricator.com/D8358
2014-02-27 18:39:59 +01:00
case self::TYPE_SUBPRIORITY:
return true;
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
}
return false;
}
public function getActionStrength() {
switch ($this->getTransactionType()) {
case self::TYPE_STATUS:
return 1.3;
case self::TYPE_OWNER:
return 1.2;
case self::TYPE_PRIORITY:
return 1.1;
}
return parent::getActionStrength();
}
Add icons, colors and action names to Maniphest timeline view Summary: Ref T2217. These are mostly me making stuff up rather than some bird's-eye view of color and iconography across applications, yell if any of these seem off once this rolls out. Test Plan: - Looked at a bunch of transactions, saw reasonable looking colors and icons. - Sent email, saw appropriate subject line actions. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7075
2013-09-23 23:30:29 +02:00
public function getColor() {
$old = $this->getOldValue();
$new = $this->getNewValue();
switch ($this->getTransactionType()) {
New icons for Maniphest Summary: Fixes 2x white icons, adds 'user' and 'project' icons. Test Plan: tested new states in Maniphest Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7176
2013-09-30 02:53:37 +02:00
case self::TYPE_OWNER:
if ($this->getAuthorPHID() == $new) {
return 'green';
} else if (!$new) {
return 'black';
} else if (!$old) {
return 'green';
} else {
return 'green';
}
Add icons, colors and action names to Maniphest timeline view Summary: Ref T2217. These are mostly me making stuff up rather than some bird's-eye view of color and iconography across applications, yell if any of these seem off once this rolls out. Test Plan: - Looked at a bunch of transactions, saw reasonable looking colors and icons. - Sent email, saw appropriate subject line actions. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7075
2013-09-23 23:30:29 +02:00
case self::TYPE_STATUS:
if ($new == ManiphestTaskStatus::STATUS_OPEN) {
Restore some missing features from Maniphest mail Summary: Ref T2217. Fixes two issues: # The "task created" email didn't include the task description, but should. # We were treaging the "status" event as the "create", but that's kind of a mess. Treat the "title" event as the "create" instead. This makes initial emails say "[Created]". Test Plan: Created some tasks, got better emails. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7115
2013-09-25 20:16:55 +02:00
return 'green';
Add icons, colors and action names to Maniphest timeline view Summary: Ref T2217. These are mostly me making stuff up rather than some bird's-eye view of color and iconography across applications, yell if any of these seem off once this rolls out. Test Plan: - Looked at a bunch of transactions, saw reasonable looking colors and icons. - Sent email, saw appropriate subject line actions. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7075
2013-09-23 23:30:29 +02:00
} else {
return 'black';
}
case self::TYPE_PRIORITY:
if ($old == ManiphestTaskPriority::getDefaultPriority()) {
return 'green';
} else if ($old > $new) {
return 'grey';
} else {
return 'yellow';
}
}
return parent::getColor();
}
public function getActionName() {
$old = $this->getOldValue();
$new = $this->getNewValue();
switch ($this->getTransactionType()) {
case self::TYPE_TITLE:
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
return pht('Retitled');
Add icons, colors and action names to Maniphest timeline view Summary: Ref T2217. These are mostly me making stuff up rather than some bird's-eye view of color and iconography across applications, yell if any of these seem off once this rolls out. Test Plan: - Looked at a bunch of transactions, saw reasonable looking colors and icons. - Sent email, saw appropriate subject line actions. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7075
2013-09-23 23:30:29 +02:00
case self::TYPE_STATUS:
Restore some missing features from Maniphest mail Summary: Ref T2217. Fixes two issues: # The "task created" email didn't include the task description, but should. # We were treaging the "status" event as the "create", but that's kind of a mess. Treat the "title" event as the "create" instead. This makes initial emails say "[Created]". Test Plan: Created some tasks, got better emails. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7115
2013-09-25 20:16:55 +02:00
switch ($new) {
case ManiphestTaskStatus::STATUS_OPEN:
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
if ($old === null) {
return pht('Created');
} else {
return pht('Reopened');
}
Restore some missing features from Maniphest mail Summary: Ref T2217. Fixes two issues: # The "task created" email didn't include the task description, but should. # We were treaging the "status" event as the "create", but that's kind of a mess. Treat the "title" event as the "create" instead. This makes initial emails say "[Created]". Test Plan: Created some tasks, got better emails. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7115
2013-09-25 20:16:55 +02:00
case ManiphestTaskStatus::STATUS_CLOSED_SPITE:
return pht('Spited');
case ManiphestTaskStatus::STATUS_CLOSED_DUPLICATE:
return pht('Merged');
default:
return pht('Closed');
Add icons, colors and action names to Maniphest timeline view Summary: Ref T2217. These are mostly me making stuff up rather than some bird's-eye view of color and iconography across applications, yell if any of these seem off once this rolls out. Test Plan: - Looked at a bunch of transactions, saw reasonable looking colors and icons. - Sent email, saw appropriate subject line actions. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7075
2013-09-23 23:30:29 +02:00
}
case self::TYPE_DESCRIPTION:
return pht('Edited');
case self::TYPE_OWNER:
if ($this->getAuthorPHID() == $new) {
return pht('Claimed');
} else if (!$new) {
return pht('Up For Grabs');
} else if (!$old) {
return pht('Assigned');
} else {
return pht('Reassigned');
}
case self::TYPE_CCS:
return pht('Changed CC');
case self::TYPE_PROJECTS:
return pht('Changed Projects');
case self::TYPE_PRIORITY:
if ($old == ManiphestTaskPriority::getDefaultPriority()) {
return pht('Triaged');
} else if ($old > $new) {
return pht('Lowered Priority');
} else {
return pht('Raised Priority');
}
case self::TYPE_EDGE:
case self::TYPE_ATTACH:
return pht('Attached');
}
return parent::getActionName();
}
public function getIcon() {
$old = $this->getOldValue();
$new = $this->getNewValue();
switch ($this->getTransactionType()) {
New icons for Maniphest Summary: Fixes 2x white icons, adds 'user' and 'project' icons. Test Plan: tested new states in Maniphest Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7176
2013-09-30 02:53:37 +02:00
case self::TYPE_OWNER:
return 'user';
case self::TYPE_CCS:
return 'meta-mta';
Add icons, colors and action names to Maniphest timeline view Summary: Ref T2217. These are mostly me making stuff up rather than some bird's-eye view of color and iconography across applications, yell if any of these seem off once this rolls out. Test Plan: - Looked at a bunch of transactions, saw reasonable looking colors and icons. - Sent email, saw appropriate subject line actions. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7075
2013-09-23 23:30:29 +02:00
case self::TYPE_TITLE:
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
return 'edit';
Restore some missing features from Maniphest mail Summary: Ref T2217. Fixes two issues: # The "task created" email didn't include the task description, but should. # We were treaging the "status" event as the "create", but that's kind of a mess. Treat the "title" event as the "create" instead. This makes initial emails say "[Created]". Test Plan: Created some tasks, got better emails. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7115
2013-09-25 20:16:55 +02:00
case self::TYPE_STATUS:
switch ($new) {
case ManiphestTaskStatus::STATUS_OPEN:
return 'create';
case ManiphestTaskStatus::STATUS_CLOSED_SPITE:
return 'dislike';
case ManiphestTaskStatus::STATUS_CLOSED_DUPLICATE:
return 'delete';
default:
return 'check';
Add icons, colors and action names to Maniphest timeline view Summary: Ref T2217. These are mostly me making stuff up rather than some bird's-eye view of color and iconography across applications, yell if any of these seem off once this rolls out. Test Plan: - Looked at a bunch of transactions, saw reasonable looking colors and icons. - Sent email, saw appropriate subject line actions. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7075
2013-09-23 23:30:29 +02:00
}
case self::TYPE_DESCRIPTION:
return 'edit';
case self::TYPE_PROJECTS:
New icons for Maniphest Summary: Fixes 2x white icons, adds 'user' and 'project' icons. Test Plan: tested new states in Maniphest Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7176
2013-09-30 02:53:37 +02:00
return 'project';
Add icons, colors and action names to Maniphest timeline view Summary: Ref T2217. These are mostly me making stuff up rather than some bird's-eye view of color and iconography across applications, yell if any of these seem off once this rolls out. Test Plan: - Looked at a bunch of transactions, saw reasonable looking colors and icons. - Sent email, saw appropriate subject line actions. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7075
2013-09-23 23:30:29 +02:00
case self::TYPE_PRIORITY:
if ($old == ManiphestTaskPriority::getDefaultPriority()) {
Update priority icons for Maniphest Summary: Adds a normal icon, uses raised and lowered. Test Plan: update a task Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7109
2013-09-25 00:43:31 +02:00
return 'normal-priority';
Add icons, colors and action names to Maniphest timeline view Summary: Ref T2217. These are mostly me making stuff up rather than some bird's-eye view of color and iconography across applications, yell if any of these seem off once this rolls out. Test Plan: - Looked at a bunch of transactions, saw reasonable looking colors and icons. - Sent email, saw appropriate subject line actions. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7075
2013-09-23 23:30:29 +02:00
return pht('Triaged');
} else if ($old > $new) {
Update priority icons for Maniphest Summary: Adds a normal icon, uses raised and lowered. Test Plan: update a task Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7109
2013-09-25 00:43:31 +02:00
return 'lower-priority';
Add icons, colors and action names to Maniphest timeline view Summary: Ref T2217. These are mostly me making stuff up rather than some bird's-eye view of color and iconography across applications, yell if any of these seem off once this rolls out. Test Plan: - Looked at a bunch of transactions, saw reasonable looking colors and icons. - Sent email, saw appropriate subject line actions. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7075
2013-09-23 23:30:29 +02:00
} else {
Update priority icons for Maniphest Summary: Adds a normal icon, uses raised and lowered. Test Plan: update a task Reviewers: epriestley, btrahan Reviewed By: epriestley CC: Korvin, aran Differential Revision: https://secure.phabricator.com/D7109
2013-09-25 00:43:31 +02:00
return 'raise-priority';
Add icons, colors and action names to Maniphest timeline view Summary: Ref T2217. These are mostly me making stuff up rather than some bird's-eye view of color and iconography across applications, yell if any of these seem off once this rolls out. Test Plan: - Looked at a bunch of transactions, saw reasonable looking colors and icons. - Sent email, saw appropriate subject line actions. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7075
2013-09-23 23:30:29 +02:00
}
case self::TYPE_EDGE:
case self::TYPE_ATTACH:
return 'attach';
}
return parent::getIcon();
}
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
public function getTitle() {
$author_phid = $this->getAuthorPHID();
$old = $this->getOldValue();
$new = $this->getNewValue();
switch ($this->getTransactionType()) {
case self::TYPE_TITLE:
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
return pht(
'%s changed the title from "%s" to "%s".',
$this->renderHandleLink($author_phid),
$old,
$new);
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
case self::TYPE_DESCRIPTION:
return pht(
'%s edited the task description.',
$this->renderHandleLink($author_phid));
case self::TYPE_STATUS:
Restore some missing features from Maniphest mail Summary: Ref T2217. Fixes two issues: # The "task created" email didn't include the task description, but should. # We were treaging the "status" event as the "create", but that's kind of a mess. Treat the "title" event as the "create" instead. This makes initial emails say "[Created]". Test Plan: Created some tasks, got better emails. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7115
2013-09-25 20:16:55 +02:00
switch ($new) {
case ManiphestTaskStatus::STATUS_OPEN:
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
if ($old === null) {
return pht(
'%s created this task.',
$this->renderHandleLink($author_phid));
} else {
return pht(
'%s reopened this task.',
$this->renderHandleLink($author_phid));
}
Restore some missing features from Maniphest mail Summary: Ref T2217. Fixes two issues: # The "task created" email didn't include the task description, but should. # We were treaging the "status" event as the "create", but that's kind of a mess. Treat the "title" event as the "create" instead. This makes initial emails say "[Created]". Test Plan: Created some tasks, got better emails. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7115
2013-09-25 20:16:55 +02:00
case ManiphestTaskStatus::STATUS_CLOSED_SPITE:
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
return pht(
Restore some missing features from Maniphest mail Summary: Ref T2217. Fixes two issues: # The "task created" email didn't include the task description, but should. # We were treaging the "status" event as the "create", but that's kind of a mess. Treat the "title" event as the "create" instead. This makes initial emails say "[Created]". Test Plan: Created some tasks, got better emails. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7115
2013-09-25 20:16:55 +02:00
'%s closed this task out of spite.',
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
$this->renderHandleLink($author_phid));
Restore some missing features from Maniphest mail Summary: Ref T2217. Fixes two issues: # The "task created" email didn't include the task description, but should. # We were treaging the "status" event as the "create", but that's kind of a mess. Treat the "title" event as the "create" instead. This makes initial emails say "[Created]". Test Plan: Created some tasks, got better emails. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7115
2013-09-25 20:16:55 +02:00
case ManiphestTaskStatus::STATUS_CLOSED_DUPLICATE:
return pht(
'%s closed this task as a duplicate.',
$this->renderHandleLink($author_phid));
default:
$status_name = idx(
ManiphestTaskStatus::getTaskStatusMap(),
$new,
'???');
return pht(
'%s closed this task as "%s".',
$this->renderHandleLink($author_phid),
$status_name);
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
}
case self::TYPE_OWNER:
if ($author_phid == $new) {
return pht(
'%s claimed this task.',
$this->renderHandleLink($author_phid));
} else if (!$new) {
return pht(
'%s placed this task up for grabs.',
$this->renderHandleLink($author_phid));
} else if (!$old) {
return pht(
'%s assigned this task to %s.',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($new));
} else {
return pht(
'%s reassigned this task from %s to %s.',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($old),
$this->renderHandleLink($new));
}
case self::TYPE_PROJECTS:
$added = array_diff($new, $old);
$removed = array_diff($old, $new);
if ($added && !$removed) {
return pht(
'%s added %d project(s): %s',
$this->renderHandleLink($author_phid),
count($added),
$this->renderHandleList($added));
} else if ($removed && !$added) {
return pht(
'%s removed %d project(s): %s',
$this->renderHandleLink($author_phid),
count($removed),
$this->renderHandleList($removed));
Route Maniphest comments/detail edits through new code Summary: Ref T2217. When you add comments (or use that interface to make updates), ship it through the new code. Test Plan: Added comments, made other changes to Maniphest tasks. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7088
2013-09-23 23:33:09 +02:00
} else if ($removed && $added) {
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
return pht(
Improve some new string translations Summary: Ref T2217. Cleans up some of the "attached %d file(s)" stuff. Test Plan: Generated some of these transactions and verified they render more naturally. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7096
2013-09-24 19:49:54 +02:00
'%s changed project(s), added %d: %s; removed %d: %s',
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
$this->renderHandleLink($author_phid),
count($added),
$this->renderHandleList($added),
count($removed),
$this->renderHandleList($removed));
Route Maniphest comments/detail edits through new code Summary: Ref T2217. When you add comments (or use that interface to make updates), ship it through the new code. Test Plan: Added comments, made other changes to Maniphest tasks. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7088
2013-09-23 23:33:09 +02:00
} else {
// This is hit when rendering previews.
return pht(
'%s changed projects...',
$this->renderHandleLink($author_phid));
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
}
case self::TYPE_PRIORITY:
$old_name = ManiphestTaskPriority::getTaskPriorityName($old);
$new_name = ManiphestTaskPriority::getTaskPriorityName($new);
if ($old == ManiphestTaskPriority::getDefaultPriority()) {
return pht(
'%s triaged this task as "%s" priority.',
$this->renderHandleLink($author_phid),
$new_name);
} else if ($old > $new) {
return pht(
'%s lowered the priority of this task from "%s" to "%s".',
$this->renderHandleLink($author_phid),
$old_name,
$new_name);
} else {
return pht(
'%s raised the priority of this task from "%s" to "%s".',
$this->renderHandleLink($author_phid),
$old_name,
$new_name);
}
case self::TYPE_CCS:
// TODO: Remove this when we switch to subscribers. Just reuse the
// code in the parent.
$clone = clone $this;
$clone->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS);
return $clone->getTitle();
case self::TYPE_EDGE:
// TODO: Remove this when we switch to real edges. Just reuse the
// code in the parent;
$clone = clone $this;
$clone->setTransactionType(PhabricatorTransactions::TYPE_EDGE);
return $clone->getTitle();
case self::TYPE_ATTACH:
$old = nonempty($old, array());
$new = nonempty($new, array());
$new = array_keys(idx($new, 'FILE', array()));
$old = array_keys(idx($old, 'FILE', array()));
$added = array_diff($new, $old);
$removed = array_diff($old, $new);
if ($added && !$removed) {
return pht(
'%s attached %d file(s): %s',
$this->renderHandleLink($author_phid),
count($added),
$this->renderHandleList($added));
} else if ($removed && !$added) {
return pht(
'%s detached %d file(s): %s',
$this->renderHandleLink($author_phid),
count($removed),
$this->renderHandleList($removed));
} else {
return pht(
Improve some new string translations Summary: Ref T2217. Cleans up some of the "attached %d file(s)" stuff. Test Plan: Generated some of these transactions and verified they render more naturally. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7096
2013-09-24 19:49:54 +02:00
'%s changed file(s), attached %d: %s; detached %d: %s',
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
$this->renderHandleLink($author_phid),
count($added),
$this->renderHandleList($added),
count($removed),
$this->renderHandleList($removed));
}
}
return parent::getTitle();
}
Improve feed stories for Maniphest and some more translations Summary: Ref T2217. Render feed stories like "alincoln updated T123" instead of "alincoln updated this task.". Fix up some more translations. Test Plan: Looked at feed, saw something a bit more reasonable. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7108
2013-09-24 23:51:36 +02:00
public function getTitleForFeed(PhabricatorFeedStory $story) {
$author_phid = $this->getAuthorPHID();
$object_phid = $this->getObjectPHID();
$old = $this->getOldValue();
$new = $this->getNewValue();
switch ($this->getTransactionType()) {
case self::TYPE_TITLE:
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
return pht(
'%s renamed %s from "%s" to "%s".',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
$old,
$new);
Improve feed stories for Maniphest and some more translations Summary: Ref T2217. Render feed stories like "alincoln updated T123" instead of "alincoln updated this task.". Fix up some more translations. Test Plan: Looked at feed, saw something a bit more reasonable. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7108
2013-09-24 23:51:36 +02:00
case self::TYPE_DESCRIPTION:
return pht(
'%s edited the description of %s.',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid));
case self::TYPE_STATUS:
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
switch ($new) {
case ManiphestTaskStatus::STATUS_OPEN:
if ($old === null) {
Improve feed stories for Maniphest and some more translations Summary: Ref T2217. Render feed stories like "alincoln updated T123" instead of "alincoln updated this task.". Fix up some more translations. Test Plan: Looked at feed, saw something a bit more reasonable. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7108
2013-09-24 23:51:36 +02:00
return pht(
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
'%s created %s.',
Improve feed stories for Maniphest and some more translations Summary: Ref T2217. Render feed stories like "alincoln updated T123" instead of "alincoln updated this task.". Fix up some more translations. Test Plan: Looked at feed, saw something a bit more reasonable. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7108
2013-09-24 23:51:36 +02:00
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid));
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
} else {
Improve feed stories for Maniphest and some more translations Summary: Ref T2217. Render feed stories like "alincoln updated T123" instead of "alincoln updated this task.". Fix up some more translations. Test Plan: Looked at feed, saw something a bit more reasonable. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7108
2013-09-24 23:51:36 +02:00
return pht(
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
'%s reopened %s.',
Improve feed stories for Maniphest and some more translations Summary: Ref T2217. Render feed stories like "alincoln updated T123" instead of "alincoln updated this task.". Fix up some more translations. Test Plan: Looked at feed, saw something a bit more reasonable. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7108
2013-09-24 23:51:36 +02:00
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid));
Clean up Maniphest transaction rendering a bit more Summary: Ref T2217. This partially retreads the ground from D7115. - We're rendering silly transactions about descriptions when creating tasks. Hide those. - Move the "created" transaction back to status. This fixes two things that are otherwise more of a mess than I'd anticipated: - It fixes Reports without making a mess (see <https://github.com/facebook/phabricator/issues/395>). - It renders old transactions properly (i.e., "created" instead of "reopened" for tasks older than the migration). - Be explicit about action strength, so emails always say the most important thing in the subject. Test Plan: Created and edited tasks, looked at resulting transactions, saw a cleaner transaction record. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7141
2013-09-26 22:48:19 +02:00
}
case ManiphestTaskStatus::STATUS_CLOSED_SPITE:
return pht(
'%s closed %s out of spite.',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid));
case ManiphestTaskStatus::STATUS_CLOSED_DUPLICATE:
return pht(
'%s closed %s as a duplicate.',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid));
default:
$status_name = idx(
ManiphestTaskStatus::getTaskStatusMap(),
$new,
'???');
return pht(
'%s closed %s as "%s".',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
$status_name);
Improve feed stories for Maniphest and some more translations Summary: Ref T2217. Render feed stories like "alincoln updated T123" instead of "alincoln updated this task.". Fix up some more translations. Test Plan: Looked at feed, saw something a bit more reasonable. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7108
2013-09-24 23:51:36 +02:00
}
case self::TYPE_OWNER:
if ($author_phid == $new) {
return pht(
'%s claimed %s.',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid));
} else if (!$new) {
return pht(
'%s placed %s up for grabs.',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid));
} else if (!$old) {
return pht(
'%s assigned %s to %s.',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
$this->renderHandleLink($new));
} else {
return pht(
'%s reassigned %s from %s to %s.',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
$this->renderHandleLink($old),
$this->renderHandleLink($new));
}
case self::TYPE_PROJECTS:
$added = array_diff($new, $old);
$removed = array_diff($old, $new);
if ($added && !$removed) {
return pht(
'%s added %d project(s) to %s: %s',
$this->renderHandleLink($author_phid),
count($added),
$this->renderHandleLink($object_phid),
$this->renderHandleList($added));
} else if ($removed && !$added) {
return pht(
Add some missing non-context translations Summary: We're missing some strings here. Test Plan: {F71857} Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7340
2013-10-17 19:48:44 +02:00
'%s removed %d project(s) from %s: %s',
Improve feed stories for Maniphest and some more translations Summary: Ref T2217. Render feed stories like "alincoln updated T123" instead of "alincoln updated this task.". Fix up some more translations. Test Plan: Looked at feed, saw something a bit more reasonable. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7108
2013-09-24 23:51:36 +02:00
$this->renderHandleLink($author_phid),
count($removed),
$this->renderHandleLink($object_phid),
$this->renderHandleList($removed));
} else if ($removed && $added) {
return pht(
'%s changed project(s) of %s, added %d: %s; removed %d: %s',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
count($added),
$this->renderHandleList($added),
count($removed),
$this->renderHandleList($removed));
}
case self::TYPE_PRIORITY:
$old_name = ManiphestTaskPriority::getTaskPriorityName($old);
$new_name = ManiphestTaskPriority::getTaskPriorityName($new);
if ($old == ManiphestTaskPriority::getDefaultPriority()) {
return pht(
'%s triaged %s as "%s" priority.',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
$new_name);
} else if ($old > $new) {
return pht(
'%s lowered the priority of %s from "%s" to "%s".',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
$old_name,
$new_name);
} else {
return pht(
'%s raised the priority of %s from "%s" to "%s".',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
$old_name,
$new_name);
}
case self::TYPE_CCS:
// TODO: Remove this when we switch to subscribers. Just reuse the
// code in the parent.
$clone = clone $this;
$clone->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS);
return $clone->getTitleForFeed($story);
case self::TYPE_EDGE:
// TODO: Remove this when we switch to real edges. Just reuse the
// code in the parent;
$clone = clone $this;
$clone->setTransactionType(PhabricatorTransactions::TYPE_EDGE);
return $clone->getTitleForFeed($story);
case self::TYPE_ATTACH:
$old = nonempty($old, array());
$new = nonempty($new, array());
$new = array_keys(idx($new, 'FILE', array()));
$old = array_keys(idx($old, 'FILE', array()));
$added = array_diff($new, $old);
$removed = array_diff($old, $new);
if ($added && !$removed) {
return pht(
'%s attached %d file(s) of %s: %s',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
count($added),
$this->renderHandleList($added));
} else if ($removed && !$added) {
return pht(
'%s detached %d file(s) of %s: %s',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
count($removed),
$this->renderHandleList($removed));
} else {
return pht(
'%s changed file(s) for %s, attached %d: %s; detached %d: %s',
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
count($added),
$this->renderHandleList($added),
count($removed),
$this->renderHandleList($removed));
}
}
return parent::getTitleForFeed($story);
}
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
public function hasChangeDetails() {
switch ($this->getTransactionType()) {
case self::TYPE_DESCRIPTION:
return true;
}
return parent::hasChangeDetails();
}
public function renderChangeDetails(PhabricatorUser $viewer) {
Allow CustomField to provide ApplicationTransaction change details Summary: Ref T3886. Ref T418. For fields like "Summary" and "Test Plan" where changes can't be summarized in one line, allow CustomField to provide a "(Show Details)" link and render a diff. Also consolidate some of the existing copy/paste, and simplify this featuer slightly now that we've move to dialogs. Test Plan: {F115918} - Viewed "description"-style field changes in phlux, pholio, legalpad, maniphest, differential, ponder (questions), ponder (answers), and repositories. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T3886, T418 Differential Revision: https://secure.phabricator.com/D8284
2014-02-21 20:53:04 +01:00
return $this->renderTextCorpusChangeDetails(
$viewer,
$this->getOldValue(),
$this->getNewValue());
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
}
Gut ManiphestTransactionEditor Summary: Ref T2217. Removes most of the code from ManiphestTransactionEditor. - Provides mail tag support in ManiphestTransactionEditorPro. - There was one more write (subscribe/unsubscribe button) that I'd missed; modernize that. Test Plan: - Clicked subscribe/unsubscribe. - Made some edits, verified mail had appropriate mail tags. Reviewers: btrahan, garoevans Reviewed By: garoevans CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7091
2013-09-24 15:27:07 +02:00
public function getMailTags() {
$tags = array();
switch ($this->getTransactionType()) {
case self::TYPE_STATUS:
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_STATUS;
break;
case self::TYPE_OWNER:
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_OWNER;
break;
case self::TYPE_CCS:
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_CC;
break;
case self::TYPE_PROJECTS:
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_PROJECTS;
break;
case self::TYPE_PRIORITY:
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_PRIORITY;
break;
Minor, sneak in one fix from future Maniphest patches ahead of review Summary: I goofed this constant when defining mail tags. Auditors: btrahan
2013-09-24 15:49:31 +02:00
case PhabricatorTransactions::TYPE_COMMENT:
Gut ManiphestTransactionEditor Summary: Ref T2217. Removes most of the code from ManiphestTransactionEditor. - Provides mail tag support in ManiphestTransactionEditorPro. - There was one more write (subscribe/unsubscribe button) that I'd missed; modernize that. Test Plan: - Clicked subscribe/unsubscribe. - Made some edits, verified mail had appropriate mail tags. Reviewers: btrahan, garoevans Reviewed By: garoevans CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7091
2013-09-24 15:27:07 +02:00
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_COMMENT;
break;
default:
$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_OTHER;
break;
}
return $tags;
}
Switch Maniphest to modern ApplicationTransaction rendering Summary: Ref T2217. Route transaction rendering through modern code. This just affects the detail page. Some rough edges but nothing significant. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2217 Differential Revision: https://secure.phabricator.com/D7070
2013-09-23 23:29:40 +02:00
Render Maniphest fields in an application-transactions-compatible way Summary: Improves transaction rendering for custom fields and standard custom fields. Test Plan: See screenshot. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7054
2013-09-22 01:23:17 +02:00
}
Copy permalink