revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/resources/sql/patches/042.commentmetadata.sql

12 lines
379 B
MySQL
Raw Normal View History

SQL Patch Management: SQL Changes Summary: Splits out the SQL changes. These are most of the changes, but primarily mechanical: - Moved "initialize.sql" to "0000.legacy.sql" and partially reverted to an older version, such that patches 0000 + 000 + 001 + ... + 137 put us in the right state when applied sequentially. - Removed "create database" commands from all SQL. These are handled by separate DB patches now, so we have the data to do operations like "storage databases" (list databases) and "storage destroy" (drop databases). - Removed "phabricator_" namespace from all SQL, and replaced with "{$NAMESPACE}_" token so we can namespace databases. - Shortened some column lengths so patches apply correctly if originally created as InnoDB; also a few similar tweaks elsewhere. Test Plan: See D2323 for discussion and test plan. Reviewers: edward, vrana, btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T140, T345 Differential Revision: https://secure.phabricator.com/D2329
2012-04-30 16:53:53 +02:00
ALTER TABLE {$NAMESPACE}_differential.differential_comment
Store metadata with Differential and Maniphest comments, and store added reviewers as metadata Summary: The "Add reviewer" implementation is super lazy right now since I didn't want to do a schema change. Man up and add a column. I also plan to store "via" information here (e.g., via email or via mobile). NOTE: This schema change may take a while since the comment table is pretty big in Facebook's install. This needs a little CSS work but I think it's reasonable for now. Test Plan: Made comments on revisions and tasks. Added reviewers to a revision, got linked names instead of a blob of text. Reviewed By: aran Reviewers: tomo, jungejason, tuomaspelkonen, aran Commenters: tomo CC: aran, tomo, epriestley Differential Revision: 394
2011-06-01 20:19:55 +02:00
ADD metadata LONGBLOB NOT NULL;
SQL Patch Management: SQL Changes Summary: Splits out the SQL changes. These are most of the changes, but primarily mechanical: - Moved "initialize.sql" to "0000.legacy.sql" and partially reverted to an older version, such that patches 0000 + 000 + 001 + ... + 137 put us in the right state when applied sequentially. - Removed "create database" commands from all SQL. These are handled by separate DB patches now, so we have the data to do operations like "storage databases" (list databases) and "storage destroy" (drop databases). - Removed "phabricator_" namespace from all SQL, and replaced with "{$NAMESPACE}_" token so we can namespace databases. - Shortened some column lengths so patches apply correctly if originally created as InnoDB; also a few similar tweaks elsewhere. Test Plan: See D2323 for discussion and test plan. Reviewers: edward, vrana, btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T140, T345 Differential Revision: https://secure.phabricator.com/D2329
2012-04-30 16:53:53 +02:00
UPDATE {$NAMESPACE}_differential.differential_comment
Store metadata with Differential and Maniphest comments, and store added reviewers as metadata Summary: The "Add reviewer" implementation is super lazy right now since I didn't want to do a schema change. Man up and add a column. I also plan to store "via" information here (e.g., via email or via mobile). NOTE: This schema change may take a while since the comment table is pretty big in Facebook's install. This needs a little CSS work but I think it's reasonable for now. Test Plan: Made comments on revisions and tasks. Added reviewers to a revision, got linked names instead of a blob of text. Reviewed By: aran Reviewers: tomo, jungejason, tuomaspelkonen, aran Commenters: tomo CC: aran, tomo, epriestley Differential Revision: 394
2011-06-01 20:19:55 +02:00
SET metadata = '{}' WHERE metadata = '';
SQL Patch Management: SQL Changes Summary: Splits out the SQL changes. These are most of the changes, but primarily mechanical: - Moved "initialize.sql" to "0000.legacy.sql" and partially reverted to an older version, such that patches 0000 + 000 + 001 + ... + 137 put us in the right state when applied sequentially. - Removed "create database" commands from all SQL. These are handled by separate DB patches now, so we have the data to do operations like "storage databases" (list databases) and "storage destroy" (drop databases). - Removed "phabricator_" namespace from all SQL, and replaced with "{$NAMESPACE}_" token so we can namespace databases. - Shortened some column lengths so patches apply correctly if originally created as InnoDB; also a few similar tweaks elsewhere. Test Plan: See D2323 for discussion and test plan. Reviewers: edward, vrana, btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T140, T345 Differential Revision: https://secure.phabricator.com/D2329
2012-04-30 16:53:53 +02:00
ALTER TABLE {$NAMESPACE}_maniphest.maniphest_transaction
Store metadata with Differential and Maniphest comments, and store added reviewers as metadata Summary: The "Add reviewer" implementation is super lazy right now since I didn't want to do a schema change. Man up and add a column. I also plan to store "via" information here (e.g., via email or via mobile). NOTE: This schema change may take a while since the comment table is pretty big in Facebook's install. This needs a little CSS work but I think it's reasonable for now. Test Plan: Made comments on revisions and tasks. Added reviewers to a revision, got linked names instead of a blob of text. Reviewed By: aran Reviewers: tomo, jungejason, tuomaspelkonen, aran Commenters: tomo CC: aran, tomo, epriestley Differential Revision: 394
2011-06-01 20:19:55 +02:00
ADD metadata LONGBLOB NOT NULL;
SQL Patch Management: SQL Changes Summary: Splits out the SQL changes. These are most of the changes, but primarily mechanical: - Moved "initialize.sql" to "0000.legacy.sql" and partially reverted to an older version, such that patches 0000 + 000 + 001 + ... + 137 put us in the right state when applied sequentially. - Removed "create database" commands from all SQL. These are handled by separate DB patches now, so we have the data to do operations like "storage databases" (list databases) and "storage destroy" (drop databases). - Removed "phabricator_" namespace from all SQL, and replaced with "{$NAMESPACE}_" token so we can namespace databases. - Shortened some column lengths so patches apply correctly if originally created as InnoDB; also a few similar tweaks elsewhere. Test Plan: See D2323 for discussion and test plan. Reviewers: edward, vrana, btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T140, T345 Differential Revision: https://secure.phabricator.com/D2329
2012-04-30 16:53:53 +02:00
UPDATE {$NAMESPACE}_maniphest.maniphest_transaction
Store metadata with Differential and Maniphest comments, and store added reviewers as metadata Summary: The "Add reviewer" implementation is super lazy right now since I didn't want to do a schema change. Man up and add a column. I also plan to store "via" information here (e.g., via email or via mobile). NOTE: This schema change may take a while since the comment table is pretty big in Facebook's install. This needs a little CSS work but I think it's reasonable for now. Test Plan: Made comments on revisions and tasks. Added reviewers to a revision, got linked names instead of a blob of text. Reviewed By: aran Reviewers: tomo, jungejason, tuomaspelkonen, aran Commenters: tomo CC: aran, tomo, epriestley Differential Revision: 394
2011-06-01 20:19:55 +02:00
SET metadata = '{}' WHERE metadata = '';
Copy permalink