2011-02-06 22:42:00 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
/*
|
2012-05-23 02:47:12 +02:00
|
|
|
* Copyright 2012 Facebook, Inc.
|
2011-02-06 22:42:00 +01:00
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
Drive Differential commit message parsing through extensible fields
Summary:
I think this is the last major step -- use the fields to parse commit messages,
not a hard-coded list of stuff. This adds two primary methods to fields, one to
get all the labels they'll parse (so we can do "CC" and "CCs" and treat them as
the same field) and one to parse the string into a canonical representation
(e.g., lookup reviewers and such).
You'll need to impelement the one block of task-specific stuff I removed in
Facebook's task field:
list($pre_comment) = split(' -- ', $data);
$data = array_filter(preg_split('/[^\d]+/', $pre_comment));
foreach ($data as $k => $v) {
$data[$k] = (int)$v;
}
$data = array_unique($data);
break;
Otherwise I think this is clean.
Test Plan:
- Called the conduit method with various commit messages, parsed fields/errors
seemed correct.
- "arc diff"'d this diff onto localhost, then updated it.
- "arc amend"'d this diff.
Reviewers: jungejason, tuomaspelkonen, aran
Reviewed By: jungejason
CC: aran, jungejason, epriestley
Differential Revision: 829
2011-08-18 21:08:18 +02:00
|
|
|
final class DifferentialFieldParseException extends Exception {
|
2011-02-06 22:42:00 +01:00
|
|
|
|
2012-05-23 02:47:12 +02:00
|
|
|
private $partialParse;
|
|
|
|
|
|
|
|
public function __construct($message, $partial_parse = null) {
|
|
|
|
parent::__construct($message);
|
|
|
|
$this->partialParse = $partial_parse;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getPartialParse() {
|
|
|
|
return $this->partialParse;
|
|
|
|
}
|
2011-02-06 22:42:00 +01:00
|
|
|
}
|