phorge-phorge/src/applications/differential/mail/DifferentialMail.php

<?php

abstract class DifferentialMail extends PhabricatorMail {

  public static function newReplyHandlerForRevision(
    DifferentialRevision $revision) {

    $reply_handler = PhabricatorEnv::newObjectFromConfig(
      'metamta.differential.reply-handler');
    $reply_handler->setMailReceiver($revision);

    return $reply_handler;
  }

}
DifferentialRevisionEditor 2011-01-26 02:17:19 +01:00			`<?php`

Require a viewer to load handles Summary: Unmuck almost all of the we-sort-of-have-viewers-some-of-the-time mess. There are a few notable cases here: - I used Omnipotent users when indexing objects for search. I think this is correct; we do policy filtering when showing results. - I cheated in a bad way in the Remarkup object rule, but fixing this requires fixing all the PhabricatorRemarkupEngine callsites (there are 85). I'll do that in the next diff. - I cheated in a few random places, like when sending mail about package edits. These aren't a big deal. Test Plan: - Grepped for all PhabricatorObjectHandleData references. - Gave them viewers. Reviewers: vrana Reviewed By: vrana CC: aran, edward Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D5151 2013-03-01 02:15:09 +01:00			`abstract class DifferentialMail extends PhabricatorMail {`
DifferentialRevisionEditor 2011-01-26 02:17:19 +01:00
Make reply-to fully work in Maniphest and Differential for open source Phabricator Summary: Hook up the last pieces. This shouldn't impact the Facebook install, EXCEPT that I removed "!accept" and added "!rethink" (plan changes). If you want to continue supporting !accept, you should override the method in your subclass if you don't already. Test Plan: Used the Mail Receiver test console to send mail to tasks and revisions. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 289 2011-05-16 21:31:18 +02:00			`public static function newReplyHandlerForRevision(`
			`DifferentialRevision $revision) {`

Require valid class for certain config settings Summary: It is now possible to set config setting requiring class of certain implementation to something completely else. The consequence is that your Phabricator may stop working after update because you didn't implement some new method. This diff validates the class upon usage. It throws exception which is better than fatal thrown currently after calling undefined method. Better solution would be to validate classes when setting the config but it would be too expensive - respective class definitions would have to be loaded and checked by reflection. I was also thinking about some check script but nobody would run it after changing config. The same behavior should be implemented for these settings: - metamta.mail-adapter - metamta.maniphest.reply-handler - metamta.differential.reply-handler - metamta.diffusion.reply-handler - storage.engine-selector - search.engine-selector - differential.field-selector - maniphest.custom-task-extensions-class - aphront.default-application-configuration-class - controller.oauth-registration Test Plan: Send comment, verify that it pass. Change `metamta.differential.reply-handler` to incompatible class, verify that sending comment shows nice red exception. Set `metamta.differential.reply-handler` to empty string, verify that it throws. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1919 2012-03-15 20:15:23 +01:00			`$reply_handler = PhabricatorEnv::newObjectFromConfig(`
Make reply-to fully work in Maniphest and Differential for open source Phabricator Summary: Hook up the last pieces. This shouldn't impact the Facebook install, EXCEPT that I removed "!accept" and added "!rethink" (plan changes). If you want to continue supporting !accept, you should override the method in your subclass if you don't already. Test Plan: Used the Mail Receiver test console to send mail to tasks and revisions. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 289 2011-05-16 21:31:18 +02:00			`'metamta.differential.reply-handler');`
			`$reply_handler->setMailReceiver($revision);`

			`return $reply_handler;`
			`}`

DifferentialRevisionEditor 2011-01-26 02:17:19 +01:00			`}`