revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 17:28:51 +02:00
Code Issues Releases Wiki Activity
phorge-phorge/webroot/rsrc/css/application/differential/revision-comment.css

50 lines
1.2 KiB
CSS
Raw Normal View History

Basic Differential revision feedback view.
2011-01-30 19:37:36 +01:00
/**
* @provides differential-revision-comment-css
*/
Improve inline comment previews Summary: - When an inline comment preview corresponds to an inline comment on the page, link to it. Just punt in the tough case where the inline is on some other page. - In "haunted" mode, "z" now toggles through three modes: normal, comment area only, and comment + previews. Test Plan: - Viewed visible and not-visible inline comment previews, clicked "View" links. - Tapped "z" a bunch to toggle haunt modes. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T517, T214 Differential Revision: https://secure.phabricator.com/D2041
2012-03-28 19:11:41 +02:00
/* Spooky haunted panel which floats on the bottom of the screen.
Haunt modes are:
- Mode 1: Just the comment box.
- Mode 2: Comment box, comment preview, and inline comment previews.
*/
.differential-haunt-mode-1 .differential-add-comment-panel,
.differential-haunt-mode-2 .differential-add-comment-panel {
Add background to haunted differential comment panel Summary: Warning boxes in a haunted differential comment panel were showing up without a background (so the contents below were showing through). This adds the background. Test Plan: viewed haunted differential comment panel on a diff with lint errors and selected "accept revision". Confirmed that the diff and sidebar did not show through underneath the red warning box. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4154
2012-12-12 00:00:18 +01:00
background-color: #fff;
Allow comment panel to be stuck/unstuck to the bottom of the display Summary: See T303. Enable comment panel haunting. I hid the preview for the sticky panel, which I think is reasonable? Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-64713fa8a7c2a22e5b93/ Reviewed By: broofa Reviewers: broofa, jungejason, aran, tomo, tuomaspelkonen CC: aran, broofa Differential Revision: 615
2011-07-08 22:00:30 +02:00
position: fixed;
width: 100%;
bottom: 0;
right: 0;
left: 0;
overflow: auto;
max-height: 375px;
Duct-tape the "z" haunted comment panel mode back together Summary: Fixes T3898. This feature needs generalization at some point, but just unbreak it for now since a surprising number of users like it. Test Plan: Pressed "z". Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran, spicyj Maniphest Tasks: T3898 Differential Revision: https://secure.phabricator.com/D7366
2013-10-20 01:43:33 +02:00
margin: 0;
Allow comment panel to be stuck/unstuck to the bottom of the display Summary: See T303. Enable comment panel haunting. I hid the preview for the sticky panel, which I think is reasonable? Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-64713fa8a7c2a22e5b93/ Reviewed By: broofa Reviewers: broofa, jungejason, aran, tomo, tuomaspelkonen CC: aran, broofa Differential Revision: 615
2011-07-08 22:00:30 +02:00
box-shadow: 0 0 4px #000;
-webkit-box-shadow: 0 0 4px #000;
-moz-box-shadow: 0 0 4px #000;
}
Duct-tape the "z" haunted comment panel mode back together Summary: Fixes T3898. This feature needs generalization at some point, but just unbreak it for now since a surprising number of users like it. Test Plan: Pressed "z". Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran, spicyj Maniphest Tasks: T3898 Differential Revision: https://secure.phabricator.com/D7366
2013-10-20 01:43:33 +02:00
.differential-haunt-mode-1 .differential-add-comment-panel .phui-box,
.differential-haunt-mode-2 .differential-add-comment-panel .phui-box {
margin: 0;
border-width: 0;
}
Improve inline comment previews Summary: - When an inline comment preview corresponds to an inline comment on the page, link to it. Just punt in the tough case where the inline is on some other page. - In "haunted" mode, "z" now toggles through three modes: normal, comment area only, and comment + previews. Test Plan: - Viewed visible and not-visible inline comment previews, clicked "View" links. - Tapped "z" a bunch to toggle haunt modes. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T517, T214 Differential Revision: https://secure.phabricator.com/D2041
2012-03-28 19:11:41 +02:00
.differential-haunt-mode-2 .differential-add-comment-panel {
max-height: 75%;
}
Duct-tape the "z" haunted comment panel mode back together Summary: Fixes T3898. This feature needs generalization at some point, but just unbreak it for now since a surprising number of users like it. Test Plan: Pressed "z". Reviewers: chad, btrahan Reviewed By: chad CC: chad, aran, spicyj Maniphest Tasks: T3898 Differential Revision: https://secure.phabricator.com/D7366
2013-10-20 01:43:33 +02:00
.differential-haunt-mode-1 .differential-add-comment-panel .phui-header-shell,
.differential-haunt-mode-2 .differential-add-comment-panel .phui-header-shell {
Allow comment panel to be stuck/unstuck to the bottom of the display Summary: See T303. Enable comment panel haunting. I hid the preview for the sticky panel, which I think is reasonable? Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-64713fa8a7c2a22e5b93/ Reviewed By: broofa Reviewers: broofa, jungejason, aran, tomo, tuomaspelkonen CC: aran, broofa Differential Revision: 615
2011-07-08 22:00:30 +02:00
display: none;
}
Improve inline comment previews Summary: - When an inline comment preview corresponds to an inline comment on the page, link to it. Just punt in the tough case where the inline is on some other page. - In "haunted" mode, "z" now toggles through three modes: normal, comment area only, and comment + previews. Test Plan: - Viewed visible and not-visible inline comment previews, clicked "View" links. - Tapped "z" a bunch to toggle haunt modes. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T517, T214 Differential Revision: https://secure.phabricator.com/D2041
2012-03-28 19:11:41 +02:00
.differential-haunt-mode-1 .aphront-panel-preview {
Allow comment panel to be stuck/unstuck to the bottom of the display Summary: See T303. Enable comment panel haunting. I hid the preview for the sticky panel, which I think is reasonable? Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-64713fa8a7c2a22e5b93/ Reviewed By: broofa Reviewers: broofa, jungejason, aran, tomo, tuomaspelkonen CC: aran, broofa Differential Revision: 615
2011-07-08 22:00:30 +02:00
display: none;
}
Improve inline comment previews Summary: - When an inline comment preview corresponds to an inline comment on the page, link to it. Just punt in the tough case where the inline is on some other page. - In "haunted" mode, "z" now toggles through three modes: normal, comment area only, and comment + previews. Test Plan: - Viewed visible and not-visible inline comment previews, clicked "View" links. - Tapped "z" a bunch to toggle haunt modes. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T517, T214 Differential Revision: https://secure.phabricator.com/D2041
2012-03-28 19:11:41 +02:00
.differential-haunt-mode-1 {
Allow comment panel to be stuck/unstuck to the bottom of the display Summary: See T303. Enable comment panel haunting. I hid the preview for the sticky panel, which I think is reasonable? Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-64713fa8a7c2a22e5b93/ Reviewed By: broofa Reviewers: broofa, jungejason, aran, tomo, tuomaspelkonen CC: aran, broofa Differential Revision: 615
2011-07-08 22:00:30 +02:00
padding-bottom: 250px;
}
Copy permalink