2011-01-24 21:07:34 +01:00
|
|
|
<?php
|
|
|
|
|
Rename Conduit classes
Summary: Ref T5655. Rename Conduit classes and provide a `getAPIMethodName` method to declare the API method.
Test Plan:
```
> echo '{}' | arc --conduit-uri='http://phabricator.joshuaspence.com' call-conduit user.whoami
Waiting for JSON parameters on stdin...
{"error":null,"errorMessage":null,"response":{"phid":"PHID-USER-lioqffnwn6y475mu5ndb","userName":"josh","realName":"Joshua Spence","image":"http:\/\/phabricator.joshuaspence.com\/res\/1404425321T\/phabricator\/3eb28cd9\/rsrc\/image\/avatar.png","uri":"http:\/\/phabricator.joshuaspence.com\/p\/josh\/","roles":["admin","verified","approved","activated"]}}
```
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: epriestley, Korvin, hach-que
Maniphest Tasks: T5655
Differential Revision: https://secure.phabricator.com/D9991
2014-07-25 02:54:15 +02:00
|
|
|
final class DifferentialSetDiffPropertyConduitAPIMethod
|
|
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
|
|
|
|
public function getAPIMethodName() {
|
|
|
|
return 'differential.setdiffproperty';
|
|
|
|
}
|
2011-01-24 21:07:34 +01:00
|
|
|
|
|
|
|
public function getMethodDescription() {
|
2014-06-09 20:36:49 +02:00
|
|
|
return 'Attach properties to Differential diffs.';
|
2011-01-24 21:07:34 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function defineParamTypes() {
|
|
|
|
return array(
|
|
|
|
'diff_id' => 'required diff_id',
|
|
|
|
'name' => 'required string',
|
|
|
|
'data' => 'required string',
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function defineReturnType() {
|
|
|
|
return 'void';
|
|
|
|
}
|
|
|
|
|
|
|
|
public function defineErrorTypes() {
|
|
|
|
return array(
|
|
|
|
'ERR_NOT_FOUND' => 'Diff was not found.',
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2012-06-15 02:09:24 +02:00
|
|
|
private static function updateLintStatus($diff_id) {
|
|
|
|
|
2011-08-24 02:16:43 +02:00
|
|
|
$diff = id(new DifferentialDiff())->load($diff_id);
|
|
|
|
if (!$diff) {
|
2012-05-26 07:00:28 +02:00
|
|
|
throw new ConduitException('ERR_NOT_FOUND');
|
2011-08-24 02:16:43 +02:00
|
|
|
}
|
|
|
|
|
2012-06-15 02:09:24 +02:00
|
|
|
// Load the postponed linters attached to this diff.
|
|
|
|
$postponed_linters_property = id(
|
|
|
|
new DifferentialDiffProperty())->loadOneWhere(
|
|
|
|
'diffID = %d AND name = %s',
|
|
|
|
$diff_id,
|
|
|
|
'arc:lint-postponed');
|
|
|
|
if ($postponed_linters_property) {
|
|
|
|
$postponed_linters = $postponed_linters_property->getData();
|
|
|
|
} else {
|
|
|
|
$postponed_linters = array();
|
|
|
|
}
|
|
|
|
|
|
|
|
// Load the lint messages currenty attached to the diff
|
|
|
|
$messages_property = id(new DifferentialDiffProperty())->loadOneWhere(
|
|
|
|
'diffID = %d AND name = %s',
|
|
|
|
$diff_id,
|
2013-02-19 22:33:10 +01:00
|
|
|
'arc:lint');
|
2012-06-15 02:09:24 +02:00
|
|
|
if ($messages_property) {
|
|
|
|
$results = $messages_property->getData();
|
|
|
|
} else {
|
|
|
|
$results = array();
|
|
|
|
}
|
|
|
|
|
2011-08-24 02:16:43 +02:00
|
|
|
$has_error = false;
|
|
|
|
$has_warning = false;
|
|
|
|
foreach ($results as $result) {
|
|
|
|
if ($result['severity'] === ArcanistLintSeverity::SEVERITY_ERROR) {
|
|
|
|
$has_error = true;
|
|
|
|
break;
|
|
|
|
} else if ($result['severity'] ===
|
|
|
|
ArcanistLintSeverity::SEVERITY_WARNING) {
|
|
|
|
$has_warning = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($has_error) {
|
|
|
|
$diff->setLintStatus(DifferentialLintStatus::LINT_FAIL);
|
|
|
|
} else if ($has_warning) {
|
|
|
|
$diff->setLintStatus(DifferentialLintStatus::LINT_WARN);
|
2012-06-15 02:09:24 +02:00
|
|
|
} else if (!empty($postponed_linters)) {
|
|
|
|
$diff->setLintStatus(DifferentialLintStatus::LINT_POSTPONED);
|
2012-12-17 23:37:39 +01:00
|
|
|
} else if ($diff->getLintStatus() != DifferentialLintStatus::LINT_SKIP) {
|
2011-08-24 02:16:43 +02:00
|
|
|
$diff->setLintStatus(DifferentialLintStatus::LINT_OKAY);
|
|
|
|
}
|
|
|
|
$diff->save();
|
|
|
|
}
|
|
|
|
|
2011-01-24 21:07:34 +01:00
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
2011-08-24 02:16:43 +02:00
|
|
|
$diff_id = $request->getValue('diff_id');
|
|
|
|
$name = $request->getValue('name');
|
|
|
|
$data = json_decode($request->getValue('data'), true);
|
|
|
|
|
|
|
|
self::updateDiffProperty($diff_id, $name, $data);
|
|
|
|
|
2012-06-15 02:09:24 +02:00
|
|
|
if ($name === 'arc:lint' || $name == 'arc:lint-postponed') {
|
|
|
|
self::updateLintStatus($diff_id);
|
2011-08-24 02:16:43 +02:00
|
|
|
}
|
|
|
|
|
2011-01-24 21:07:34 +01:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2011-08-24 02:16:43 +02:00
|
|
|
private static function updateDiffProperty($diff_id, $name, $data) {
|
|
|
|
$property = id(new DifferentialDiffProperty())->loadOneWhere(
|
|
|
|
'diffID = %d AND name = %s',
|
|
|
|
$diff_id,
|
|
|
|
$name);
|
|
|
|
if (!$property) {
|
|
|
|
$property = new DifferentialDiffProperty();
|
|
|
|
$property->setDiffID($diff_id);
|
|
|
|
$property->setName($name);
|
|
|
|
}
|
|
|
|
$property->setData($data);
|
|
|
|
$property->save();
|
|
|
|
return $property;
|
|
|
|
}
|
Rename Conduit classes
Summary: Ref T5655. Rename Conduit classes and provide a `getAPIMethodName` method to declare the API method.
Test Plan:
```
> echo '{}' | arc --conduit-uri='http://phabricator.joshuaspence.com' call-conduit user.whoami
Waiting for JSON parameters on stdin...
{"error":null,"errorMessage":null,"response":{"phid":"PHID-USER-lioqffnwn6y475mu5ndb","userName":"josh","realName":"Joshua Spence","image":"http:\/\/phabricator.joshuaspence.com\/res\/1404425321T\/phabricator\/3eb28cd9\/rsrc\/image\/avatar.png","uri":"http:\/\/phabricator.joshuaspence.com\/p\/josh\/","roles":["admin","verified","approved","activated"]}}
```
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: epriestley, Korvin, hach-que
Maniphest Tasks: T5655
Differential Revision: https://secure.phabricator.com/D9991
2014-07-25 02:54:15 +02:00
|
|
|
|
2011-01-24 21:07:34 +01:00
|
|
|
}
|