2012-11-09 02:16:23 +01:00
|
|
|
<?php
|
|
|
|
|
Rename Conduit classes
Summary: Ref T5655. Rename Conduit classes and provide a `getAPIMethodName` method to declare the API method.
Test Plan:
```
> echo '{}' | arc --conduit-uri='http://phabricator.joshuaspence.com' call-conduit user.whoami
Waiting for JSON parameters on stdin...
{"error":null,"errorMessage":null,"response":{"phid":"PHID-USER-lioqffnwn6y475mu5ndb","userName":"josh","realName":"Joshua Spence","image":"http:\/\/phabricator.joshuaspence.com\/res\/1404425321T\/phabricator\/3eb28cd9\/rsrc\/image\/avatar.png","uri":"http:\/\/phabricator.joshuaspence.com\/p\/josh\/","roles":["admin","verified","approved","activated"]}}
```
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: epriestley, Korvin, hach-que
Maniphest Tasks: T5655
Differential Revision: https://secure.phabricator.com/D9991
2014-07-25 02:54:15 +02:00
|
|
|
final class DiffusionGetLintMessagesConduitAPIMethod
|
|
|
|
extends DiffusionConduitAPIMethod {
|
|
|
|
|
|
|
|
public function getAPIMethodName() {
|
|
|
|
return 'diffusion.getlintmessages';
|
|
|
|
}
|
2012-11-09 02:16:23 +01:00
|
|
|
|
|
|
|
public function getMethodStatus() {
|
|
|
|
return self::METHOD_STATUS_UNSTABLE;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getMethodDescription() {
|
2014-06-09 20:36:49 +02:00
|
|
|
return 'Get lint messages for existing code.';
|
2012-11-09 02:16:23 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
public function defineParamTypes() {
|
|
|
|
return array(
|
|
|
|
'arcanistProject' => 'required string',
|
|
|
|
'branch' => 'optional string',
|
|
|
|
'commit' => 'optional string',
|
|
|
|
'files' => 'required list<string>',
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function defineReturnType() {
|
|
|
|
return 'list<dict>';
|
|
|
|
}
|
|
|
|
|
|
|
|
public function defineErrorTypes() {
|
2014-07-10 00:12:48 +02:00
|
|
|
return array();
|
2012-11-09 02:16:23 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
|
|
|
$project = id(new PhabricatorRepositoryArcanistProject())->loadOneWhere(
|
|
|
|
'name = %s',
|
|
|
|
$request->getValue('arcanistProject'));
|
|
|
|
if (!$project || !$project->getRepositoryID()) {
|
|
|
|
return array();
|
|
|
|
}
|
|
|
|
|
|
|
|
$branch_name = $request->getValue('branch');
|
|
|
|
if ($branch_name == '') {
|
2013-09-26 01:54:48 +02:00
|
|
|
$repository = id(new PhabricatorRepositoryQuery())
|
|
|
|
->setViewer($request->getUser())
|
|
|
|
->withIDs(array($project->getRepositoryID()))
|
|
|
|
->executeOne();
|
2012-11-09 02:16:23 +01:00
|
|
|
$branch_name = $repository->getDefaultArcanistBranch();
|
|
|
|
}
|
|
|
|
|
|
|
|
$branch = id(new PhabricatorRepositoryBranch())->loadOneWhere(
|
|
|
|
'repositoryID = %d AND name = %s',
|
|
|
|
$project->getRepositoryID(),
|
|
|
|
$branch_name);
|
|
|
|
if (!$branch || !$branch->getLintCommit()) {
|
|
|
|
return array();
|
|
|
|
}
|
|
|
|
|
|
|
|
$lint_messages = queryfx_all(
|
|
|
|
$branch->establishConnection('r'),
|
|
|
|
'SELECT path, line, code FROM %T WHERE branchID = %d AND path IN (%Ls)',
|
|
|
|
PhabricatorRepository::TABLE_LINTMESSAGE,
|
|
|
|
$branch->getID(),
|
|
|
|
$request->getValue('files'));
|
|
|
|
|
|
|
|
// TODO: Compare commit identifiers of individual files like in
|
|
|
|
// DiffusionBrowseFileController::loadLintMessages().
|
|
|
|
|
|
|
|
return $lint_messages;
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|