2011-01-30 20:02:22 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copyright 2011 Facebook, Inc.
|
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
final class DifferentialAddCommentView extends AphrontView {
|
|
|
|
|
|
|
|
private $revision;
|
|
|
|
private $actions;
|
|
|
|
private $actionURI;
|
2011-01-31 03:52:29 +01:00
|
|
|
private $user;
|
2011-02-06 01:57:21 +01:00
|
|
|
private $draft;
|
2011-01-30 20:02:22 +01:00
|
|
|
|
|
|
|
public function setRevision($revision) {
|
|
|
|
$this->revision = $revision;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setActions(array $actions) {
|
|
|
|
$this->actions = $actions;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setActionURI($uri) {
|
|
|
|
$this->actionURI = $uri;
|
|
|
|
}
|
|
|
|
|
2011-01-31 03:52:29 +01:00
|
|
|
public function setUser(PhabricatorUser $user) {
|
|
|
|
$this->user = $user;
|
|
|
|
}
|
2011-01-30 20:02:22 +01:00
|
|
|
|
2011-02-06 01:57:21 +01:00
|
|
|
public function setDraft($draft) {
|
|
|
|
$this->draft = $draft;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-06-10 03:56:47 +02:00
|
|
|
private function generateWarningView(
|
|
|
|
$status,
|
|
|
|
array $titles,
|
|
|
|
$id,
|
|
|
|
$content) {
|
|
|
|
|
|
|
|
$warning = new AphrontErrorView();
|
|
|
|
$warning->setSeverity(AphrontErrorView::SEVERITY_ERROR);
|
|
|
|
$warning->setWidth(AphrontErrorView::WIDTH_WIDE);
|
|
|
|
$warning->setID($id);
|
|
|
|
$warning->appendChild($content);
|
|
|
|
$warning->setTitle(idx($titles, $status, 'Warning'));
|
|
|
|
|
|
|
|
return $warning;
|
|
|
|
}
|
|
|
|
|
2011-01-31 03:52:29 +01:00
|
|
|
public function render() {
|
2011-02-01 03:05:20 +01:00
|
|
|
|
|
|
|
require_celerity_resource('differential-revision-add-comment-css');
|
|
|
|
|
2011-01-30 21:08:40 +01:00
|
|
|
$revision = $this->revision;
|
|
|
|
|
2011-01-30 20:02:22 +01:00
|
|
|
$form = new AphrontFormView();
|
|
|
|
$form
|
2011-01-31 03:52:29 +01:00
|
|
|
->setUser($this->user)
|
2011-01-30 20:02:22 +01:00
|
|
|
->setAction($this->actionURI)
|
2011-01-30 21:08:40 +01:00
|
|
|
->addHiddenInput('revision_id', $revision->getID())
|
2011-01-30 20:02:22 +01:00
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormSelectControl())
|
|
|
|
->setLabel('Action')
|
2011-01-30 21:08:40 +01:00
|
|
|
->setName('action')
|
2011-02-01 03:05:20 +01:00
|
|
|
->setID('comment-action')
|
2011-10-27 21:32:02 +02:00
|
|
|
->setOptions($this->actions))
|
2011-02-05 07:45:42 +01:00
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormTokenizerControl())
|
|
|
|
->setLabel('Add Reviewers')
|
|
|
|
->setName('reviewers')
|
|
|
|
->setControlID('add-reviewers')
|
|
|
|
->setControlStyle('display: none')
|
|
|
|
->setID('add-reviewers-tokenizer')
|
|
|
|
->setDisableBehavior(true))
|
2011-06-24 21:21:48 +02:00
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormTokenizerControl())
|
|
|
|
->setLabel('Add CCs')
|
|
|
|
->setName('ccs')
|
|
|
|
->setControlID('add-ccs')
|
|
|
|
->setControlStyle('display: none')
|
|
|
|
->setID('add-ccs-tokenizer')
|
|
|
|
->setDisableBehavior(true))
|
2011-01-30 20:02:22 +01:00
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormTextAreaControl())
|
2011-01-30 21:08:40 +01:00
|
|
|
->setName('comment')
|
2011-02-01 03:05:20 +01:00
|
|
|
->setID('comment-content')
|
2011-02-06 01:57:21 +01:00
|
|
|
->setLabel('Comment')
|
2011-07-15 23:17:55 +02:00
|
|
|
->setEnableDragAndDropFileUploads(true)
|
2011-02-06 01:57:21 +01:00
|
|
|
->setValue($this->draft))
|
2011-01-30 20:02:22 +01:00
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormSubmitControl())
|
2011-03-30 01:02:46 +02:00
|
|
|
->setValue('Clowncopterize'));
|
2011-01-30 20:02:22 +01:00
|
|
|
|
2011-02-05 07:45:42 +01:00
|
|
|
Javelin::initBehavior(
|
2011-06-24 21:21:48 +02:00
|
|
|
'differential-add-reviewers-and-ccs',
|
2011-02-05 07:45:42 +01:00
|
|
|
array(
|
2011-06-24 21:21:48 +02:00
|
|
|
'dynamic' => array(
|
|
|
|
'add_reviewers' => array(
|
|
|
|
'tokenizer' => 'add-reviewers-tokenizer',
|
|
|
|
'src' => '/typeahead/common/users/',
|
|
|
|
'row' => 'add-reviewers',
|
2011-10-08 03:25:54 +02:00
|
|
|
'ondemand' => PhabricatorEnv::getEnvConfig('tokenizer.ondemand'),
|
2011-06-24 21:21:48 +02:00
|
|
|
),
|
|
|
|
'add_ccs' => array(
|
|
|
|
'tokenizer' => 'add-ccs-tokenizer',
|
|
|
|
'src' => '/typeahead/common/mailable/',
|
|
|
|
'row' => 'add-ccs',
|
2011-10-08 03:25:54 +02:00
|
|
|
'ondemand' => PhabricatorEnv::getEnvConfig('tokenizer.ondemand'),
|
2011-06-24 21:21:48 +02:00
|
|
|
),
|
|
|
|
),
|
2011-02-05 07:45:42 +01:00
|
|
|
'select' => 'comment-action',
|
|
|
|
));
|
|
|
|
|
2011-06-10 03:56:47 +02:00
|
|
|
$diff = $revision->loadActiveDiff();
|
|
|
|
$lint_warning = null;
|
|
|
|
$unit_warning = null;
|
|
|
|
if ($diff->getLintStatus() >= DifferentialLintStatus::LINT_WARN) {
|
|
|
|
$titles =
|
|
|
|
array(
|
|
|
|
DifferentialLintStatus::LINT_WARN => 'Lint Warning',
|
|
|
|
DifferentialLintStatus::LINT_FAIL => 'Lint Failure',
|
|
|
|
DifferentialLintStatus::LINT_SKIP => 'Lint Skipped'
|
|
|
|
);
|
|
|
|
$content =
|
|
|
|
"<p>This diff has Lint Problems. Make sure you are OK with them ".
|
|
|
|
"before you accept this diff.</p>";
|
|
|
|
$lint_warning = $this->generateWarningView(
|
|
|
|
$diff->getLintStatus(),
|
|
|
|
$titles,
|
|
|
|
'lint-warning',
|
|
|
|
$content);
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($diff->getUnitStatus() >= DifferentialUnitStatus::UNIT_WARN) {
|
|
|
|
$titles =
|
|
|
|
array(
|
|
|
|
DifferentialUnitStatus::UNIT_WARN => 'Unit Tests Warning',
|
|
|
|
DifferentialUnitStatus::UNIT_FAIL => 'Unit Tests Failure',
|
|
|
|
DifferentialUnitStatus::UNIT_SKIP => 'Unit Tests Skipped',
|
|
|
|
DifferentialUnitStatus::UNIT_POSTPONED => 'Unit Tests Postponed'
|
|
|
|
);
|
2011-09-27 19:34:01 +02:00
|
|
|
if ($diff->getUnitStatus() == DifferentialUnitStatus::UNIT_POSTPONED) {
|
|
|
|
$content =
|
|
|
|
"<p>This diff has postponed unit tests. The results should be ".
|
|
|
|
"coming in soon. You should probably wait for them before accepting ".
|
|
|
|
"this diff.</p>";
|
|
|
|
} else {
|
|
|
|
$content =
|
|
|
|
"<p>This diff has Unit Test Problems. Make sure you are OK with ".
|
|
|
|
"them before you accept this diff.</p>";
|
|
|
|
}
|
2011-06-10 03:56:47 +02:00
|
|
|
$unit_warning = $this->generateWarningView(
|
|
|
|
$diff->getUnitStatus(),
|
|
|
|
$titles,
|
|
|
|
'unit-warning',
|
|
|
|
$content);
|
|
|
|
}
|
|
|
|
|
|
|
|
Javelin::initBehavior(
|
|
|
|
'differential-accept-with-errors',
|
|
|
|
array(
|
|
|
|
'select' => 'comment-action',
|
|
|
|
'lint_warning' => $lint_warning ? 'lint-warning' : null,
|
|
|
|
'unit_warning' => $unit_warning ? 'unit-warning' : null,
|
|
|
|
));
|
|
|
|
|
2011-02-03 04:38:43 +01:00
|
|
|
$rev_id = $revision->getID();
|
|
|
|
|
2011-02-01 03:05:20 +01:00
|
|
|
Javelin::initBehavior(
|
|
|
|
'differential-feedback-preview',
|
|
|
|
array(
|
2011-02-03 04:38:43 +01:00
|
|
|
'uri' => '/differential/comment/preview/'.$rev_id.'/',
|
|
|
|
'preview' => 'comment-preview',
|
|
|
|
'action' => 'comment-action',
|
|
|
|
'content' => 'comment-content',
|
|
|
|
|
|
|
|
'inlineuri' => '/differential/comment/inline/preview/'.$rev_id.'/',
|
|
|
|
'inline' => 'inline-comment-preview',
|
2011-02-01 03:05:20 +01:00
|
|
|
));
|
|
|
|
|
Tweak Maniphest CSS, fix remarkup in description change views
Summary:
Various CSS tweaks and fixes:
- Add remarkup styling to description change views, missed this before.
- Fix CSS so that transactions with only one item (e.g., changed priority)
don't have weird floater underneath them.
- Add more space between transaction items.
- Make default background color lighter and less heavy.
- Use beigey color for comment form in Maniphest.
- Share more CSS between Maniphest and Differential (previews, feedback).
- Move "Leap Into Action" call to Differential, replace Maniphest with
thematically-consistent "Weigh In" (obviously, Maniphest has a nautical theme).
Test Plan:
Browsed Maniphest and Differential in a couple browsers, styling all seems
correct.
Reviewed By: tomo
Reviewers: tomo, aran, jungejason, tuomaspelkonen
CC: anjali, aran, tomo
Differential Revision: 328
2011-05-22 17:49:07 +02:00
|
|
|
$panel_view = new AphrontPanelView();
|
|
|
|
$panel_view->appendChild($form);
|
2011-06-10 03:56:47 +02:00
|
|
|
if ($lint_warning) {
|
|
|
|
$panel_view->appendChild($lint_warning);
|
|
|
|
}
|
|
|
|
if ($unit_warning) {
|
|
|
|
$panel_view->appendChild($unit_warning);
|
|
|
|
}
|
Tweak Maniphest CSS, fix remarkup in description change views
Summary:
Various CSS tweaks and fixes:
- Add remarkup styling to description change views, missed this before.
- Fix CSS so that transactions with only one item (e.g., changed priority)
don't have weird floater underneath them.
- Add more space between transaction items.
- Make default background color lighter and less heavy.
- Use beigey color for comment form in Maniphest.
- Share more CSS between Maniphest and Differential (previews, feedback).
- Move "Leap Into Action" call to Differential, replace Maniphest with
thematically-consistent "Weigh In" (obviously, Maniphest has a nautical theme).
Test Plan:
Browsed Maniphest and Differential in a couple browsers, styling all seems
correct.
Reviewed By: tomo
Reviewers: tomo, aran, jungejason, tuomaspelkonen
CC: anjali, aran, tomo
Differential Revision: 328
2011-05-22 17:49:07 +02:00
|
|
|
$panel_view->setHeader('Leap Into Action');
|
|
|
|
$panel_view->addClass('aphront-panel-accent');
|
|
|
|
$panel_view->addClass('aphront-panel-flush');
|
|
|
|
|
2011-01-30 20:02:22 +01:00
|
|
|
return
|
2011-06-08 21:39:03 +02:00
|
|
|
'<div class="differential-add-comment-panel">'.
|
|
|
|
$panel_view->render().
|
|
|
|
'<div class="aphront-panel-preview aphront-panel-flush">'.
|
|
|
|
'<div id="comment-preview">'.
|
|
|
|
'<span class="aphront-panel-preview-loading-text">'.
|
|
|
|
'Loading comment preview...'.
|
|
|
|
'</span>'.
|
|
|
|
'</div>'.
|
|
|
|
'<div id="inline-comment-preview">'.
|
|
|
|
'</div>'.
|
2011-02-01 03:05:20 +01:00
|
|
|
'</div>'.
|
2011-01-30 20:02:22 +01:00
|
|
|
'</div>';
|
|
|
|
}
|
|
|
|
}
|