revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 16:30:59 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/__phutil_library_map__.php

1461 lines
103 KiB
PHP
Raw Normal View History

Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
<?php
/**
* This file is automatically generated. Use 'phutil_mapper.php' to rebuild it.
* @generated
*/
phutil_register_library_map(array(
'class' =>
array(
Allow Celerity to return "304 Not Modified" responses Summary: We always return HTTP 200 right now and don't send a "Last-Modified" header, so browsers download more data then necessary if you sit on a page mashing reload (for example). Test Plan: Used Charles to verify HTTP response codes from 400, 404 and 304 responses. Mashed reload a bunch and saw that the server sent back 304s. Changed the resource hash seed and saw 200s, then 304s on reload. Reviewed By: tuomaspelkonen Reviewers: tuomaspelkonen, jungejason, aran CC: bmaurer, aran, tuomaspelkonen Differential Revision: 253
2011-05-09 10:10:40 +02:00
'Aphront304Response' => 'aphront/response/304',
Write pathway for Differential Comments
2011-01-30 21:08:40 +01:00
'Aphront400Response' => 'aphront/response/400',
Send 403 for admin pages without being admin Summary: I've also moved the response generation for 404 from ##AphrontDefaultApplicationConfiguration## to ##buildResponseString()## Test Plan: Visit / Visit /mail/ Visit /x/ Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley, vrana Differential Revision: https://secure.phabricator.com/D1406
2012-01-15 10:07:56 +01:00
'Aphront403Response' => 'aphront/response/403',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'Aphront404Response' => 'aphront/response/404',
Javelin integration.
2011-01-25 20:57:47 +01:00
'AphrontAjaxResponse' => 'aphront/response/ajax',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontApplicationConfiguration' => 'aphront/applicationconfiguration',
Improve drag-and-drop uploader Summary: Make it discoverable, show uploading progress, show file thumbnails, allow you to remove files, make it a generic form component. Test Plan: Uploaded ducks Reviewed By: tomo Reviewers: aran, tomo, jungejason, tuomaspelkonen CC: anjali, aran, epriestley, tomo Differential Revision: 334
2011-05-23 01:11:41 +02:00
'AphrontAttachedFileView' => 'view/control/attachedfile',
Fix conservative CSRF token cycling limit Summary: We currently cycle CSRF tokens every hour and check for the last two valid ones. This means that a form could go stale in as little as an hour, and is certainly stale after two. When a stale form is submitted, you basically get a terrible heisen-state where some of your data might persist if you're lucky but more likely it all just vanishes. The .js file below outlines some more details. This is a pretty terrible UX and we don't need to be as conservative about CSRF validation as we're being. Remedy this problem by: - Accepting the last 6 CSRF tokens instead of the last 1 (i.e., pages are valid for at least 6 hours, and for as long as 7). - Using JS to refresh the CSRF token every 55 minutes (i.e., pages connected to the internet are valid indefinitely). - Showing the user an explicit message about what went wrong when CSRF validation fails so the experience is less bewildering. They should now only be able to submit with a bad CSRF token if: - They load a page, disconnect from the internet for 7 hours, reconnect, and submit the form within 55 minutes; or - They are actually the victim of a CSRF attack. We could eventually fix the first one by tracking reconnects, which might be "free" once the notification server gets built. It will probably never be an issue in practice. Test Plan: - Reduced CSRF cycle frequency to 2 seconds, submitted a form after 15 seconds, got the CSRF exception. - Reduced csrf-refresh cycle frequency to 3 seconds, submitted a form after 15 seconds, got a clean form post. - Added debugging code the the csrf refresh to make sure it was doing sensible things (pulling different tokens, finding all the inputs). Reviewed By: aran Reviewers: tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 660
2011-07-13 23:05:18 +02:00
'AphrontCSRFException' => 'aphront/exception/csrf',
Build a basic calendar view Summary: This is a very small step toward building a Status and possibly an Oncall tool. Build a calendar view which renders months. Much of my hesitance to bang these tools out is that dealing with dates/calendaring is basically horrible, so I'm trying to ease into it. This calendar is locale-aware and all that jazz. Test Plan: - See: https://secure.phabricator.com/file/view/PHID-FILE-c07a9c663a7d040d2529/ - Verified that months have the right number of days, today is the right day of the week, months begin on the day after previous months end on, etc. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran Commenters: cwbeck, jungejason CC: blair, aran, epriestley, cwbeck, jungejason Differential Revision: 791
2011-08-08 03:26:31 +02:00
'AphrontCalendarMonthView' => 'applications/calendar/view/month',
Tweak style on "Create Another Task" button Summary: Not totally sure I'm in love with this but I think it's somewhat non-terrible, despite the lack of lens flare. Also made "Cancel" take you back to the task if you got to "Create" from "Create Another Task". Test Plan: - Style: https://secure.phabricator.com/file/view/PHID-FILE-ad37d3c1f3b2c7a7a7d1/ - Hit "Cancel" from "Create Another", got sent back to task. - Hit "Cancel" from normal create, got sent back to list. - Tried to save an invalid task after making changes to CC/Projects, changes were preserved. Reviewed By: codeblock Reviewers: hunterbridges, jungejason, tuomaspelkonen, aran, codeblock CC: aran, epriestley, codeblock Differential Revision: 736
2011-07-27 19:46:22 +02:00
'AphrontContextBarView' => 'view/layout/contextbar',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontController' => 'aphront/controller',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'AphrontCrumbsView' => 'view/layout/crumbs',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontDatabaseConnection' => 'storage/connection/base',
'AphrontDefaultApplicationConfiguration' => 'aphront/default/configuration',
'AphrontDefaultApplicationController' => 'aphront/default/controller',
'AphrontDialogResponse' => 'aphront/response/dialog',
'AphrontDialogView' => 'view/dialog',
'AphrontErrorView' => 'view/form/error',
Authentication
2011-01-26 22:21:12 +01:00
'AphrontException' => 'aphront/exception/base',
Improve file preview in Maniphest Summary: Show large thumbnails of attached files in Maniphest. Test Plan: Looked at large thumbnails in Maniphest. Reviewed By: jungejason Reviewers: tomo, aran, jungejason, tuomaspelkonen CC: anjali, aran, epriestley, jungejason Differential Revision: 335
2011-05-23 02:06:42 +02:00
'AphrontFilePreviewView' => 'view/layout/filepreview',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'AphrontFileResponse' => 'aphront/response/file',
MetaMTA
2011-01-26 02:40:21 +01:00
'AphrontFormCheckboxControl' => 'view/form/control/checkbox',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontFormControl' => 'view/form/control/base',
Various fixes, particularly on the revision update workflow.
2011-02-05 02:53:14 +01:00
'AphrontFormDividerControl' => 'view/form/control/divider',
Improve drag-and-drop uploader Summary: Make it discoverable, show uploading progress, show file thumbnails, allow you to remove files, make it a generic form component. Test Plan: Uploaded ducks Reviewed By: tomo Reviewers: aran, tomo, jungejason, tuomaspelkonen CC: anjali, aran, epriestley, tomo Differential Revision: 334
2011-05-23 01:11:41 +02:00
'AphrontFormDragAndDropUploadControl' => 'view/form/control/draganddropupload',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'AphrontFormFileControl' => 'view/form/control/file',
Allow projects to be quickly added from the Maniphest task creation interface Summary: Provide a quick workflow for adding a new project. This ended up being sort of complicated because we don't currently put forms in dialogs. I separated the actual <form /> tag out of the display/layout of AphrontFormView to enable this (the dialog is itself a form). Limitations: if you create a new project and then remove it, it won't appear in the tokenizer until you reload the page. We need to add the ability for the datasource to drop its cache to enable this, which is super complicated. Test Plan: Used "Create new project" to add a new project when creating a task. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: anjali, aran, epriestley Differential Revision: 422
2011-06-10 00:28:29 +02:00
'AphrontFormLayoutView' => 'view/form/layout',
Conduit: user.find
2011-01-24 20:36:53 +01:00
'AphrontFormMarkupControl' => 'view/form/control/markup',
PhabricatorEnv 'infratructure' -> 'infrastructure' (rofl) Recaptcha Email Login / Forgot Password Password Reset
2011-01-31 20:55:26 +01:00
'AphrontFormPasswordControl' => 'view/form/control/password',
'AphrontFormRecaptchaControl' => 'view/form/control/recaptcha',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontFormSelectControl' => 'view/form/control/select',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'AphrontFormStaticControl' => 'view/form/control/static',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontFormSubmitControl' => 'view/form/control/submit',
'AphrontFormTextAreaControl' => 'view/form/control/textarea',
'AphrontFormTextControl' => 'view/form/control/text',
AphrontListFilterView, for list filtering.
2011-04-04 00:50:06 +02:00
'AphrontFormToggleButtonsControl' => 'view/form/control/togglebuttons',
Typeaheads
2011-01-25 22:48:05 +01:00
'AphrontFormTokenizerControl' => 'view/form/control/tokenizer',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontFormView' => 'view/form/base',
Unify headsup action lists. Summary: Test Plan: Reviewers: CC:
2011-02-20 21:50:28 +01:00
'AphrontHeadsupActionListView' => 'view/layout/headsup/actionlist',
'AphrontHeadsupActionView' => 'view/layout/headsup/action',
Provide an "isolated" database connection for testing Summary: This provides a new connection which doesn't connect to anything, so effects can be isolated to the current process (for unit testing). Test Plan: Ran unit tests. Reviewed By: aran Reviewers: aran, tuomaspelkonen, jungejason CC: aran, epriestley Differential Revision: 193
2011-04-30 19:11:41 +02:00
'AphrontIsolatedDatabaseConnection' => 'storage/connection/isolated',
'AphrontIsolatedDatabaseConnectionTestCase' => 'storage/connection/isolated/__tests__',
Examples using JX.View Summary: Provide a dirt-simple working example of client-side templating and reactive programming. Test Plan: Load the examples Reviewers: epriestley, mroch, tomo Reviewed By: epriestley CC: ide, schrockn, aran, rzadorozny, epriestley Differential Revision: 908
2011-09-07 23:01:13 +02:00
'AphrontJavelinView' => 'view/javelin-view',
Provide basic keyboard navigation support for Differential. Summary: ReviewBoard has a fancier version of this feature that's more granular -- the keyboard can focus on individual changes. I think that's good and intend to implement something similar, but this gets us a step closer and gets rid of some of the bookkeeping stuff like making shortcuts discoverable. (I have another brnach with Maniphest merging which also uses fatcow icons, which is why the README seems a little out of context.) Test Plan: Used "j" and "k" to jump between changesets. Pressed "?" and got a list of available shortcuts. Reviewed By: tuomaspelkonen Reviewers: aran, jungejason, tuomaspelkonen CC: moskov, aran, epriestley, tuomaspelkonen Differential Revision: 412
2011-06-08 20:53:10 +02:00
'AphrontKeyboardShortcutsAvailableView' => 'view/widget/keyboardshortcuts',
AphrontListFilterView, for list filtering.
2011-04-04 00:50:06 +02:00
'AphrontListFilterView' => 'view/layout/listfilter',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontMySQLDatabaseConnection' => 'storage/connection/mysql',
'AphrontNullView' => 'view/null',
'AphrontPageView' => 'view/page/base',
AphrontPagerView and UIExamples.
2011-04-01 02:06:33 +02:00
'AphrontPagerView' => 'view/control/pager',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontPanelView' => 'view/layout/panel',
Improve error message for Conduit path problems Summary: A few people in IRC have been having issues here recently. If you misconfigure the IRC bot, e.g., you get a 200 response back with a bunch of login HTML in it. This is unhelpful. Try to detect that a conduit request is going to the wrong path and raise a concise, explicit error which is comprehensible from the CLI. Also created a "PlainText" response and moved the IE nosniff header to the base response object. Test Plan: As a logged-out user, hit various nonsense with "?__conduit__=true" in the URI. Got good error messages. Hit nonsense without it, got login screens. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T775 Differential Revision: https://secure.phabricator.com/D1407
2012-01-15 20:06:13 +01:00
'AphrontPlainTextResponse' => 'aphront/response/plaintext',
Improve schema upgrade workflow for unprivileged users Summary: In a basically reasonable configuration where you connect with a non-privileged user from the web workflow, upgrade_schema.php won't have enough privileges. Allow the user to override the normal auth with -u and -p. Test Plan: Tried to do a schema upgrade with an underprivileged user, got a useful error message instead of garbage. Reviewed By: Girish Reviewers: Girish, davidrecordon, jungejason, tuomaspelkonen, aran CC: aran, epriestley, Girish Differential Revision: 191
2011-04-30 09:18:13 +02:00
'AphrontQueryAccessDeniedException' => 'storage/exception/accessdenied',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontQueryConnectionException' => 'storage/exception/connection',
'AphrontQueryConnectionLostException' => 'storage/exception/connectionlost',
'AphrontQueryCountException' => 'storage/exception/count',
Basic Facebook OAuth implementation.
2011-01-31 06:28:45 +01:00
'AphrontQueryDuplicateKeyException' => 'storage/exception/duplicatekey',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontQueryException' => 'storage/exception/base',
'AphrontQueryObjectMissingException' => 'storage/exception/objectmissing',
'AphrontQueryParameterException' => 'storage/exception/parameter',
'AphrontQueryRecoverableException' => 'storage/exception/recoverable',
Authentication
2011-01-26 22:21:12 +01:00
'AphrontRedirectException' => 'aphront/exception/redirect',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontRedirectResponse' => 'aphront/response/redirect',
Allow revisions to be edited from Maniphest Summary: You can currently attach tasks to revisions from Differential, but not revisions to tasks from Maniphest. Allow editing from either side. This logic is kind of tricky but the alternative was massive code duplication. Test Plan: Added and removed revisions from maniphest. Added and removed tasks from differential. This should have no impact on the Facebook install since none of this is used there. Reviewed By: aran Reviewers: tomo, tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 288
2011-05-16 20:43:39 +02:00
'AphrontReloadResponse' => 'aphront/response/reload',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontRequest' => 'aphront/request',
Make 404 page somewhat prettier.
2011-01-30 18:15:01 +01:00
'AphrontRequestFailureView' => 'view/page/failure',
Add getStrList() to AphrontRequest Summary: - We have a few places where we do some kind of ad-hoc comma list tokenizing, and I'm adding another one in D1290. Add a helper to the request object. - Add some unit tests. Test Plan: - Ran unit tests. - Used PHID manager, Maniphest custom view, and Repository project editor. Reviewers: btrahan, fratrik, jungejason Reviewed By: btrahan CC: aran, btrahan, epriestley Differential Revision: https://secure.phabricator.com/D1302
2012-01-04 06:57:45 +01:00
'AphrontRequestTestCase' => 'aphront/request/__tests__',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontResponse' => 'aphront/response/base',
Create AphrontWriteGuard, a backup mechanism for CSRF validation Summary: Provide a catchall mechanism to find unprotected writes. - Depends on D758. - Similar to WriteOnHTTPGet stuff from Facebook's stack. - Since we have a small number of storage mechanisms and highly structured read/write pathways, we can explicitly answer the question "is this page performing a write?". - Never allow writes without CSRF checks. - This will probably break some things. That's fine: they're CSRF vulnerabilities or weird edge cases that we can fix. But don't push to Facebook for a few days unless you're prepared to deal with this. - **>>> MEGADERP: All Conduit write APIs are currently vulnerable to CSRF! <<<** Test Plan: - Ran some scripts that perform writes (scripts/search indexers), no issues. - Performed normal CSRF submits. - Added writes to an un-CSRF'd page, got an exception. - Executed conduit methods. - Did login/logout (this works because the logged-out user validates the logged-out csrf "token"). - Did OAuth login. - Did OAuth registration. Reviewers: pedram, andrewjcg, erling, jungejason, tuomaspelkonen, aran, codeblock Commenters: pedram CC: aran, epriestley, pedram Differential Revision: 777
2011-08-03 20:49:27 +02:00
'AphrontScopedUnguardedWriteCapability' => 'aphront/writeguard/scopeguard',
Take the first step on the long journey of fixing "Projects" Summary: - Allow more than the 100 most recent projects to be viewed. - Provide some useful filters. - Default the view to your projects, not all projects. - Put query logic in a query object. - Put filter view logic in a view object. We can port more stuff to it later. Test Plan: Looked at active/owned/all projects. Set page size to 5 and paged through projects. Reviewers: btrahan, jungejason, zeeg Reviewed By: btrahan CC: aran, btrahan Differential Revision: 1227
2011-12-17 02:08:18 +01:00
'AphrontSideNavFilterView' => 'view/layout/sidenavfilter',
Conduit server-side basics.
2011-01-24 18:00:29 +01:00
'AphrontSideNavView' => 'view/layout/sidenav',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontTableView' => 'view/control/table',
Some herald improvements.
2011-03-23 04:41:02 +01:00
'AphrontTokenizerTemplateView' => 'view/control/tokenizer',
Some owners read workflows.
2011-04-04 04:20:47 +02:00
'AphrontTypeaheadTemplateView' => 'view/control/typeahead',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontURIMapper' => 'aphront/mapper',
'AphrontView' => 'view/base',
'AphrontWebpageResponse' => 'aphront/response/webpage',
Create AphrontWriteGuard, a backup mechanism for CSRF validation Summary: Provide a catchall mechanism to find unprotected writes. - Depends on D758. - Similar to WriteOnHTTPGet stuff from Facebook's stack. - Since we have a small number of storage mechanisms and highly structured read/write pathways, we can explicitly answer the question "is this page performing a write?". - Never allow writes without CSRF checks. - This will probably break some things. That's fine: they're CSRF vulnerabilities or weird edge cases that we can fix. But don't push to Facebook for a few days unless you're prepared to deal with this. - **>>> MEGADERP: All Conduit write APIs are currently vulnerable to CSRF! <<<** Test Plan: - Ran some scripts that perform writes (scripts/search indexers), no issues. - Performed normal CSRF submits. - Added writes to an un-CSRF'd page, got an exception. - Executed conduit methods. - Did login/logout (this works because the logged-out user validates the logged-out csrf "token"). - Did OAuth login. - Did OAuth registration. Reviewers: pedram, andrewjcg, erling, jungejason, tuomaspelkonen, aran, codeblock Commenters: pedram CC: aran, epriestley, pedram Differential Revision: 777
2011-08-03 20:49:27 +02:00
'AphrontWriteGuard' => 'aphront/writeguard',
PhabricatorEnv 'infratructure' -> 'infrastructure' (rofl) Recaptcha Email Login / Forgot Password Password Reset
2011-01-31 20:55:26 +01:00
'CelerityAPI' => 'infrastructure/celerity/api',
'CelerityResourceController' => 'infrastructure/celerity/controller',
Add cycle detection to celerity mapper Summary: create CelerityResourceGraph, which extends AbstractDirectedGraph. since we've done a bunch of work already to load the resource graph into memory CelerityResourceGraph simply stores a copy and makes loadEdges work off that stored copy. Test Plan: made phabricator-prefab require herald-rule-editor ~/code/phabricator> ./scripts/celerity_mapper.php webroot Finding static resources... Processing 154 files.......................................................................................................................................................... [2011-11-22 11:28:29] EXCEPTION: (Exception) Cycle detected in resource graph: phabricator-prefab => herald-rule-editor => phabricator-prefab at [/Users/btrahan/Dropbox/code/phabricator/scripts/celerity_mapper.php:173] fixed phabricator-prefab requiring herald-rule-editor. re-ran celerity_mapper and no errors! Reviewers: epriestley Reviewed By: epriestley CC: aran, btrahan, epriestley Differential Revision: 1132
2011-11-22 20:36:57 +01:00
'CelerityResourceGraph' => 'infrastructure/celerity/graph',
PhabricatorEnv 'infratructure' -> 'infrastructure' (rofl) Recaptcha Email Login / Forgot Password Password Reset
2011-01-31 20:55:26 +01:00
'CelerityResourceMap' => 'infrastructure/celerity/map',
'CelerityStaticResourceResponse' => 'infrastructure/celerity/response',
Conduit server-side basics.
2011-01-24 18:00:29 +01:00
'ConduitAPIMethod' => 'applications/conduit/method/base',
'ConduitAPIRequest' => 'applications/conduit/protocol/request',
Adding an "ssh" client for conduit Summary: ..."ssh" is in quotes 'cuz this is step 1 and there's no ssh in sight at the moment. Test Plan: ran api.php PHID-USER-xee4ju2teq7mflitwfcs differential.query a few times... - tried valid input, it worked! - tried bad input, it worked in that it failed and told me so! ran api.php crap_user differential.query a few times... - verified error message with respect to crap_user ran api.php PHID-USER-xee4ju2teq7mflitwfcs crap_method a few times... - verified error message with respect to crap_method visited http://phabricator.dev/conduit/method/differential.query a few times... - tried valid input, it worked! Reviewers: epriestley Reviewed By: epriestley CC: aran, btrahan, epriestley Maniphest Tasks: T550 Differential Revision: https://secure.phabricator.com/D1357
2012-01-11 01:48:59 +01:00
'ConduitAPIResponse' => 'applications/conduit/protocol/response',
Add an "arcanist.projectinfo" Conduit call Summary: We currently rely on "remote_hooks_enabled" in .arcconfig to determine whether commands like "arc amend" and "arc merge" should imply "arc mark-committed". However, this is a historical artifact that is now bad for a bunch of reasons: - The option name is confusing, it really means 'repository is tracked'. - The option is hard to discover and generally sucks. - We can empirically determine the right answer since we now know if a project is in a tracked repository. Add a call which arcanist can make on these workflows to figure out if it is interacting with a project in a tracked repository or not. Also added an "isTracked()" convenience method to reduce the number of magic strings all over the place. Test Plan: Ran "arcanist.projectinfo" for nonexistent, untracked and tracked projects. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, epriestley, Makinde Differential Revision: 945
2011-09-16 20:42:45 +02:00
'ConduitAPI_arcanist_Method' => 'applications/conduit/method/arcanist/base',
'ConduitAPI_arcanist_projectinfo_Method' => 'applications/conduit/method/arcanist/projectinfo',
Conduit: conduit.connect
2011-01-24 20:30:10 +01:00
'ConduitAPI_conduit_connect_Method' => 'applications/conduit/method/conduit/connect',
"arc install-certificate", server-side components Summary: Provides a new workflow for making it non-horrible to install certificates. Basically you run "arc install-certificate" and then copy/paste a short token off a webpage and it does the ~/.arcrc edits for you. Test Plan: Installed certificates, used bad tokens, hit rate limiting. Reviewed By: aran Reviewers: aran, jungejason, tuomaspelkonen CC: aran Differential Revision: 460
2011-06-14 21:17:14 +02:00
'ConduitAPI_conduit_getcertificate_Method' => 'applications/conduit/method/conduit/getcertificate',
conduit.ping Summary: Test Plan: Reviewers: CC:
2011-02-19 07:36:32 +01:00
'ConduitAPI_conduit_ping_Method' => 'applications/conduit/method/conduit/ping',
Diffusion/phd/console improvements.
2011-03-15 21:38:14 +01:00
'ConduitAPI_daemon_launched_Method' => 'applications/conduit/method/daemon/launched',
'ConduitAPI_daemon_log_Method' => 'applications/conduit/method/daemon/log',
Add a "createcomment" method to Differential Summary: Added a new method differential.createcomment Task ID: #752014 Test Plan: I created a test diff and called this method via the conduit from a client PHP script to add comments. I confirmed that 1) the comment appeared on the revision, 2) URLs within the comment were turned into hyperlinks, and 3) Phabricator sent a notification email to the people watching the test diff. Reviewers: nh, jungejason, epriestley Reviewed By: nh CC: aran, nh Differential Revision: 1128
2011-11-18 18:16:40 +01:00
'ConduitAPI_differential_createcomment_Method' => 'applications/conduit/method/differential/createcomment',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'ConduitAPI_differential_creatediff_Method' => 'applications/conduit/method/differential/creatediff',
differential.createrevision Summary: Conduit method. Test Plan: Meta Reviewers: CC: Differential Revision: 23
2011-02-06 22:49:23 +01:00
'ConduitAPI_differential_createrevision_Method' => 'applications/conduit/method/differential/createrevision',
differential.find Summary: Test Plan: meta Reviewers: CC:
2011-02-06 23:43:06 +01:00
'ConduitAPI_differential_find_Method' => 'applications/conduit/method/differential/find',
Added a conduit method for getting all the diffs for a revision. Summary: Loading all diffs for a differential revision is needed by at least perflab. Test Plan: Created a simple script that queried the conduit and made sure that it returned correct values. Reviewed By: jungejason Reviewers: jungejason CC: epriestley, jungejason Differential Revision: 155
2011-04-21 00:29:02 +02:00
'ConduitAPI_differential_getalldiffs_Method' => 'applications/conduit/method/differential/getalldiffs',
Conduit: differential.getcommitmessage Summary: Test Plan: Reviewers: CC:
2011-02-09 18:41:26 +01:00
'ConduitAPI_differential_getcommitmessage_Method' => 'applications/conduit/method/differential/getcommitmessage',
differential.getcommitpaths Summary: Test Plan: Reviewers: CC:
2011-02-19 07:28:03 +01:00
'ConduitAPI_differential_getcommitpaths_Method' => 'applications/conduit/method/differential/getcommitpaths',
Provide differential.getdiff, useful for 'arc patch'. Summary: Test Plan: ran 'arc patch' Reviewers: CC:
2011-02-19 07:15:28 +01:00
'ConduitAPI_differential_getdiff_Method' => 'applications/conduit/method/differential/getdiff',
add a getrevision conduit method Summary: Add a method to get the information about a revision, including its full list of diffs. We could add an option to just return the diff IDs if we wanted. For my use case, I need the full set of information for each diff, so fewer round trips is better. This is also how the old json.php page used to work. Test Plan: Tuomas tested it in his sandbox. Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, epriestley CC: tuomaspelkonen Differential Revision: 156
2011-04-21 01:38:16 +02:00
'ConduitAPI_differential_getrevision_Method' => 'applications/conduit/method/differential/getrevision',
Add author to differential.getrevisionfeedback Summary: Add the author PHID to the differential.getrevisionfeedback conduit api method Test Plan: issue differential.getrevisionfeedback query via conduit against a valid revision and verify author phid is included in results Reviewers: epriestley Reviewed By: epriestley CC: epriestley, aran, jungejason, tuomaspelkonen, jonathanhester Differential Revision: 1190
2011-12-12 20:55:55 +01:00
'ConduitAPI_differential_getrevisioncomments_Method' => 'applications/conduit/method/differential/getrevisioncomments',
Added a conduit method for querying revision feedback. Summary: Push tools needs information about differential revision comments. Added a method that returns the needed information. Test Plan: Tested that /intern/push/merges shows correct information. Reviewed By: jungejason Reviewers: jungejason CC: epriestley, jungejason Differential Revision: 152
2011-04-20 01:24:45 +02:00
'ConduitAPI_differential_getrevisionfeedback_Method' => 'applications/conduit/method/differential/getrevisionfeedback',
differential.markcommitted Summary: Test Plan: Reviewers: CC:
2011-02-09 18:48:26 +01:00
'ConduitAPI_differential_markcommitted_Method' => 'applications/conduit/method/differential/markcommitted',
differential.parsecommitmessage Test plan: meta
2011-02-06 22:42:00 +01:00
'ConduitAPI_differential_parsecommitmessage_Method' => 'applications/conduit/method/differential/parsecommitmessage',
Add differential.query conduit method Summary: Created a differential.query conduit method that is built on top of DifferentialRevisionQuery. I also added support for querying by author, ccs, and reviewers to DifferentialRevisionQuery, so feature parity can be brought up to match differential.find and its backing class DifferentialRevisionListData. Test Plan: Tried a few calls to the conduit call using the web interface, and got back reasonable looking data. Reviewers: epriestley, jungejason, btrahan Reviewed By: epriestley CC: aran, nh, epriestley Differential Revision: 1158
2011-12-02 01:57:06 +01:00
'ConduitAPI_differential_query_Method' => 'applications/conduit/method/differential/query',
Conduit: differential.setdiffproperty
2011-01-24 21:07:34 +01:00
'ConduitAPI_differential_setdiffproperty_Method' => 'applications/conduit/method/differential/setdiffproperty',
differential.updaterevision Summary: Test Plan: meta Reviewers: CC: Differential Revision: 24
2011-02-06 23:00:32 +01:00
'ConduitAPI_differential_updaterevision_Method' => 'applications/conduit/method/differential/updaterevision',
Enable updating task->revision assoc Summary: add a conduit method to enable querying revisions' phid from their revision_IDs, and another one to update the task->revision assoc. Test Plan: for querying revision_phid method, tested empty, one, and two revisions in the query. For the one to update the task->revision assoc, I have another diff in facebook which verified it add and remove assoc correctly. Reviewers: tuomaspelkonen, epriestley CC: Differential Revision: 165
2011-04-22 03:47:04 +02:00
'ConduitAPI_differential_updatetaskrevisionassoc_Method' => 'applications/conduit/method/differential/updatetaskrevisionassoc',
Added a conduit call to update arc unit results for a postponed test. Summary: It was not possible before to update arc unit results for a postponed test. This change makes it possible. Also the number of postponed tests are shown in differential. Let me know if this looks too Facebook specific. Test Plan: Tested the conduit call manually from Conduit Console and updated test results for a diff that had 20 postponed tests. Reviewed By: jungejason Reviewers: epriestley, jungejason Commenters: epriestley CC: slawekbiel, aran, tuomaspelkonen, jungejason, epriestley Differential Revision: 416
2011-06-09 01:16:59 +02:00
'ConduitAPI_differential_updateunitresults_Method' => 'applications/conduit/method/differential/updateunitresults',
Expose symbol information over Conduit Summary: I want to add a command like "where is ArcanistUnitTestEngine" to phabot. I also want to add a symbol typeahead to Diffusion and generally finish up that feature since it's useful but only half-implemented. Consolidate the query logic and expose the data over Conduit. Test Plan: Used /symbol/ and Conduit to lookup symbols. Reviewers: btrahan, jungejason Reviewed By: jungejason CC: aran, jungejason Maniphest Tasks: T315 Differential Revision: https://secure.phabricator.com/D1260
2011-12-21 18:39:33 +01:00
'ConduitAPI_diffusion_findsymbols_Method' => 'applications/conduit/method/diffusion/findsymbols',
First cut at diffusion.getcommits method
2011-04-14 01:39:08 +02:00
'ConduitAPI_diffusion_getcommits_Method' => 'applications/conduit/method/diffusion/getcommits',
diffusion.getrecentcommitsbypath Summary: Implement diffusion.getrecentcommitsbypath, a Conduit wrapper over DiffusionHistoryQuery which returns results suitable for consumption by diffusion.getcommits. Test Plan: Conduit console Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley Differential Revision: 315
2011-05-20 00:36:17 +02:00
'ConduitAPI_diffusion_getrecentcommitsbypath_Method' => 'applications/conduit/method/diffusion/getrecentcommitsbypath',
Build basic infrastructure for an activity feed Summary: This defines an extremely basic version of an activity feed, like Facebook's news feed. It doesn't do much of interest yet. Test Plan: Published some feed stories: https://secure.phabricator.com/file/view/PHID-FILE-5061aa72105bbdc05b21/ Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran Commenters: codeblock, jungejason CC: aran, epriestley, codeblock, tuomaspelkonen, jungejason Differential Revision: 593
2011-07-05 17:35:18 +02:00
'ConduitAPI_feed_publish_Method' => 'applications/conduit/method/feed/publish',
Add file.download to Conduit Summary: This is required to make "arc patch" and "arc export" support binary changes. Test Plan: Called from web console and "arc". Reviewed By: aran Reviewers: tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 326
2011-05-21 18:53:50 +02:00
'ConduitAPI_file_download_Method' => 'applications/conduit/method/file/download',
Add a 'file.info' Conduit method Summary: Need this for 'arc upload' and 'arc download'. Given a file PHID or ID, provides information about it. Test Plan: - Implemented 'arc upload' and 'arc download' based on 'file.info'. - Used Conduit API console to test method. Reviewed By: codeblock Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran, codeblock, epriestley Differential Revision: 741
2011-07-29 19:00:16 +02:00
'ConduitAPI_file_info_Method' => 'applications/conduit/method/file/info',
Conduit server-side basics.
2011-01-24 18:00:29 +01:00
'ConduitAPI_file_upload_Method' => 'applications/conduit/method/file/upload',
Provide a basic maniphest.createtask method via Conduit Summary: This could be a lot fancier but let's see what else we need. Also fixed some bugs with maniphest.info. Test Plan: Used the Conduit web console to create some tasks with different values. Reviewers: jungejason, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, jungejason, epriestley Differential Revision: 824
2011-08-18 00:19:48 +02:00
'ConduitAPI_maniphest_Method' => 'applications/conduit/method/maniphest/base',
'ConduitAPI_maniphest_createtask_Method' => 'applications/conduit/method/maniphest/createtask',
Add "maniphest.find" to Conduit Summary: Execute searches like the primary Maniphest task list. Let me know what else you guys need from this API. Test Plan: Executed "maniphest.info" and "maniphest.find" Reviewers: jungejason, tuomaspelkonen, aran, nh Reviewed By: nh CC: blair, skrul, aran, jungejason, epriestley, nh, tuomaspelkonen Differential Revision: 867
2011-08-27 01:52:57 +02:00
'ConduitAPI_maniphest_find_Method' => 'applications/conduit/method/maniphest/find',
Added conduit method to get maniphest transactions Summary: Added a Conduit API method to return all transactions for a given set of task_ids. This will be used to comments and other important information about the tasks. Test Plan: Use Conduit to execute ##maniphest.gettasktransactions## and visually verify that transaction information is returned. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1361
2012-01-11 04:51:55 +01:00
'ConduitAPI_maniphest_gettasktransactions_Method' => 'applications/conduit/method/maniphest/gettasktransactions',
Preliminary Conduit info method for Maniphest tasks. Summary: Provide a simple maniphest.info method for fetching info about a Maniphest task, given its ID. Test Plan: Tested via the web console, and it appeared to work fine. This is preliminary though, but I plan to use it for adding 'Txxx' to phabot. Reviewers: epriestley CC: Differential Revision: 540
2011-06-27 10:00:28 +02:00
'ConduitAPI_maniphest_info_Method' => 'applications/conduit/method/maniphest/info',
Add a "maniphest.update" Conduit method Summary: - Add maniphest.update - Add support for auxiliary fields to maniphest.createtask Test Plan: - Created tasks with maniphest.createtask - Updated tasks with maniphest.update Reviewers: btrahan, jungejason, zeeg Reviewed By: btrahan CC: aran, btrahan Differential Revision: https://secure.phabricator.com/D1330
2012-01-06 04:02:50 +01:00
'ConduitAPI_maniphest_update_Method' => 'applications/conduit/method/maniphest/update',
Provide a paste.create Conduit method Summary: - Allow the console to handle abstract classes correctly. - Move paste dictionary generation to an abstract base class. - Add paste.create. - Add 'objectName', 'parentPHID', and 'content' to Paste info dictionaries (you can use filePHID with file.download to get the content but I think just always sending it back is reasonable). Test Plan: - Use paste.create to create new pastes. - Used paste.info to get existing pastes. - Checked console UI to make sure "paste." didn't show up or anything silly/dumb like that. - Tried to call the method "paste" and got the right exception. Reviewed By: codeblock Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran, codeblock Differential Revision: 747
2011-07-30 03:31:14 +02:00
'ConduitAPI_paste_Method' => 'applications/conduit/method/paste/base',
'ConduitAPI_paste_create_Method' => 'applications/conduit/method/paste/create',
Conduit paste.info method for the pastebin. Summary: This implements a paste.info conduit method, for retrieving info about a paste. Imagine that. Test Plan: [ricky@rhelpad01 method]$ echo '{"paste_id":1}' | arc call-conduit --conduit-uri=http://phabricator.local/api/ paste.info {"error":null,"errorMessage":null,"response":{"id":"1","phid":"PHID-PSTE-10934f3df8ed33c06555","authorPHID":"PHID-USER-9d03e8fa47516d37dc92","filePHID":"PHID-FILE-e85f6a72c773d24f4981","title":"test.php","dateCreated":"1307731614"}} Reviewers: epriestley CC: Differential Revision: 458
2011-06-14 07:21:30 +02:00
'ConduitAPI_paste_info_Method' => 'applications/conduit/method/paste/info',
Adding conduit API method to find owner for the affected file Summary: Adding method that given a path will go up the folder hierarchy until it finds the owning package and return owners for that package. Task ID: #403724 Test Plan: Tried the new API call through console on various path combinations Reviewed By: epriestley Reviewers: epriestley, dpepper, tuomaspelkonen CC: epriestley, Leon Revert Plan: n/a Tags: bootcamp, Push Efficiency - begin *PUBLIC* platform impact section - Bugzilla: # - end platform impact - Differential Revision: 126
2011-04-12 06:51:36 +02:00
'ConduitAPI_path_getowners_Method' => 'applications/conduit/method/path/getowners',
Add user.info and phid.info Conduit methods Summary: Allow user and arbitrary object lookup by PHID. Test Plan: Executed user.whoami, user.info, user.find and phid.info via Conduit console. Reviewers: jungejason, tuomaspelkonen, aran, nh Reviewed By: nh CC: skrul, aran, nh, jungejason, epriestley Differential Revision: 870
2011-08-30 21:03:58 +02:00
'ConduitAPI_phid_Method' => 'applications/conduit/method/phid/base',
'ConduitAPI_phid_info_Method' => 'applications/conduit/method/phid/info',
Provide access to Phriction via Conduit Summary: Provide three Phriction methods for programmatic access to Phriction: - phriction.info: get information about a document - phriction.history: get change history for a document - phriction.edit: create or update a document I moved all the editing/creation logic into a new PhrictionDocumentEditor to share code between the Conduit and Web edit pathways. Test Plan: Got info and history via conduit. Edited and created new pages via conduit and web. Reviewers: hsb, jungejason, tuomaspelkonen, aran, hunterbridges Reviewed By: hunterbridges CC: skrul, aran, hunterbridges Differential Revision: 866
2011-08-26 21:50:28 +02:00
'ConduitAPI_phriction_Method' => 'applications/conduit/method/phriction/base',
'ConduitAPI_phriction_edit_Method' => 'applications/conduit/method/phriction/edit',
'ConduitAPI_phriction_history_Method' => 'applications/conduit/method/phriction/history',
'ConduitAPI_phriction_info_Method' => 'applications/conduit/method/phriction/info',
Add project.query to Conduit Summary: Add a conduit method to query project information. Test Plan: Ran method from API test console. Reviewers: bill, btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T681 Differential Revision: https://secure.phabricator.com/D1444
2012-01-18 01:29:35 +01:00
'ConduitAPI_project_Method' => 'applications/conduit/method/project/base',
'ConduitAPI_project_query_Method' => 'applications/conduit/method/project/query',
Conduit method for slowvote.poll.info. Summary: Provides a slowvote.poll.info method. Test Plan: Web console - seemed to work fine. Reviewers: epriestley, phuzion CC: Differential Revision: 659
2011-07-13 04:18:20 +02:00
'ConduitAPI_slowvote_info_Method' => 'applications/conduit/method/slowvote/info',
Add user.info and phid.info Conduit methods Summary: Allow user and arbitrary object lookup by PHID. Test Plan: Executed user.whoami, user.info, user.find and phid.info via Conduit console. Reviewers: jungejason, tuomaspelkonen, aran, nh Reviewed By: nh CC: skrul, aran, nh, jungejason, epriestley Differential Revision: 870
2011-08-30 21:03:58 +02:00
'ConduitAPI_user_Method' => 'applications/conduit/method/user/base',
Conduit: user.find
2011-01-24 20:36:53 +01:00
'ConduitAPI_user_find_Method' => 'applications/conduit/method/user/find',
Add user.info and phid.info Conduit methods Summary: Allow user and arbitrary object lookup by PHID. Test Plan: Executed user.whoami, user.info, user.find and phid.info via Conduit console. Reviewers: jungejason, tuomaspelkonen, aran, nh Reviewed By: nh CC: skrul, aran, nh, jungejason, epriestley Differential Revision: 870
2011-08-30 21:03:58 +02:00
'ConduitAPI_user_info_Method' => 'applications/conduit/method/user/info',
Provide $request->getUser() for Conduit API Requests Summary: Allow Conduit methods to retrieve the authoritative, logged-in user identity. Test Plan: Ran user.whoami (an authenticated method) and got my info back. Ran conduit.connect (an unauthenticated method) and the world did not explode. Reviewed By: tuomaspelkonen Reviewers: tuomaspelkonen CC: tuomaspelkonen, epriestley Differential Revision: 113
2011-04-08 03:27:39 +02:00
'ConduitAPI_user_whoami_Method' => 'applications/conduit/method/user/whoami',
Conduit server-side basics.
2011-01-24 18:00:29 +01:00
'ConduitException' => 'applications/conduit/protocol/exception',
Very rough cut of DarkConsole + XHProf
2011-02-02 22:48:52 +01:00
'DarkConsole' => 'aphront/console/api',
Add a "Config" plugin to DarkConsole. Summary: This plugin lets you see how the host is configured at runtime. Test Plan: Reviewers: CC:
2011-02-12 01:48:43 +01:00
'DarkConsoleConfigPlugin' => 'aphront/console/plugin/config',
Very rough cut of DarkConsole + XHProf
2011-02-02 22:48:52 +01:00
'DarkConsoleController' => 'aphront/console/controller',
'DarkConsoleCore' => 'aphront/console/core',
'DarkConsoleErrorLogPlugin' => 'aphront/console/plugin/errorlog',
Flesh out some DarkConsole stuff.
2011-02-03 07:38:42 +01:00
'DarkConsoleErrorLogPluginAPI' => 'aphront/console/plugin/errorlog/api',
Add an "Event" plugin to DarkConsole for event inspection Summary: Shows events which a page dispatched, plus all the registered listeners. Test Plan: Pretty basic for now, but works OK: https://secure.phabricator.com/file/view/PHID-FILE-49fcd23081ce55cf9369/ (I also made it dispatch some dummy events to verify they show up.) Reviewers: aran Reviewed By: aran CC: aran Differential Revision: 973
2011-09-30 21:54:17 +02:00
'DarkConsoleEventPlugin' => 'aphront/console/plugin/event',
'DarkConsoleEventPluginAPI' => 'aphront/console/plugin/event/api',
Very rough cut of DarkConsole + XHProf
2011-02-02 22:48:52 +01:00
'DarkConsolePlugin' => 'aphront/console/plugin/base',
'DarkConsoleRequestPlugin' => 'aphront/console/plugin/request',
'DarkConsoleServicesPlugin' => 'aphront/console/plugin/services',
'DarkConsoleXHProfPlugin' => 'aphront/console/plugin/xhprof',
'DarkConsoleXHProfPluginAPI' => 'aphront/console/plugin/xhprof/api',
Hook for database configuration plugin Summary: This permits individual deployments to better configure their database configuration, e.g. to allow more dynamic configuration that reacts to database moves or master/slave replication. Test Plan: Browse Reviewed By: epriestley Reviewers: Girish, epriestley CC: aran, epriestley Differential Revision: 183
2011-04-30 02:23:25 +02:00
'DatabaseConfigurationProvider' => 'applications/base/storage/configuration',
Move 'review' -> 'differential'.
2011-01-24 03:10:20 +01:00
'DifferentialAction' => 'applications/differential/constants/action',
Improve behavior when user submits a no-op action in Differential Summary: See T730 and the slightly-less-pretty version of this in D1398. When a user takes an action in Differential that has no effect (for instance, accepting an already-accepted revision), prompt them: Action Has No Effect You can not accept this revision because it has already been accepted. Do you want to post the feedback anyway, as a normal comment? [Cancel] [Post as Comment] If they have no comment text, the dialog only says "Cancel". I think this is probably the best way to balance all the concerns here -- it might occasionally be a little annoying, but that should be rare, and it should never be confusing (the current workflow is extremely confusing). This also fixes the issue where you can add all sorts of CCs who are already part of the revision, either explicitly or via mentions. Test Plan: Posted some has-effect and has-no-effect comments, made different choices in the dialog, everything seems to work OK? Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, vrana Maniphest Tasks: T730 Differential Revision: https://secure.phabricator.com/D1403
2012-01-14 20:39:22 +01:00
'DifferentialActionHasNoEffectException' => 'applications/differential/exception/noeffect',
AddCommentView
2011-01-30 20:02:22 +01:00
'DifferentialAddCommentView' => 'applications/differential/view/addcomment',
Build an "affected path" index when attaching diffs to revisions Summary: See T262. This creates the index on the Differential side which we need in order to execute this query efficiently on the Diffusion side. Also renames "DiffusionGitPathIDQuery" to "DiffusionPathIDQuery", this query object has nothing to do with git. Test Plan: Attached top-level and sub-level diffs to revisions and verified they populated the table with sensible data. Reviewers: bmaurer, aravindn, fmoo, jungejason, nh, tuomaspelkonen, aran CC: Differential Revision: 931
2011-09-14 19:59:52 +02:00
'DifferentialAffectedPath' => 'applications/differential/storage/affectedpath',
Move Differential's simple fields to the extensible field schema Summary: Differential has a bunch of display-only fields, implement them all as field specifications instead of hard-coded fields. Also add some more documentation and fix redundant string constants in blame rev/revert plan fields. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 807
2011-08-14 20:29:56 +02:00
'DifferentialApplyPatchFieldSpecification' => 'applications/differential/field/specification/applypatch',
Move Differential's read-only fields to the extensible field schema Summary: Move additional fields (which rely on loading handles) to the extensible field classes and out of hardcoding in the controller. Depends on D807. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 808
2011-08-14 21:33:54 +02:00
'DifferentialArcanistProjectFieldSpecification' => 'applications/differential/field/specification/arcanistproject',
'DifferentialAuthorFieldSpecification' => 'applications/differential/field/specification/author',
Add basic auxiliary field storage for Differential Summary: Precursor to building this out to solve T343. This is similar to the Maniphest fields we landed recently, although I think they're dissimilar enough that it isn't worth going crazy trying to make them share code, at least for now. This doesn't really do anything yet, just adds a storage object and a couple of selector/field indirection classes. Test Plan: Ran SQL upgrade script, created an aux field. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 798
2011-08-10 20:29:08 +02:00
'DifferentialAuxiliaryField' => 'applications/differential/storage/auxiliaryfield',
Provide builtin definitions for "Blame Revision" and "Revert Plan" fields Summary: This is just to ease transitions for any installs which use these fields (e.g., Facebook). I'll write some docs and a migration script once this stuff is a little more solid, too. Depends on D800. Technically these are "better" than the current fields since they show up other places than the edit screen (derp derp). Test Plan: Created a field selector which provides these; verified they work by typing stuff into them and saving the revision. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 801
2011-08-11 00:36:18 +02:00
'DifferentialBlameRevisionFieldSpecification' => 'applications/differential/field/specification/blamerev',
DifferentialRevisionEditor
2011-01-26 02:17:19 +01:00
'DifferentialCCWelcomeMail' => 'applications/differential/mail/ccwelcome',
Move Differential's remaining field views to extensble field schema Summary: Move all the rest of the fields into the custom field schema, for revision views. I left a couple of stubs in here (willWriteRevision, didWriteRevision) since I'd planned to do edits here too, but this diff is sort of big-ish already. I'll do all the edit fields in the next revision. Depends on D808. Test Plan: Viewed, edited and conduit'ed some revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 809
2011-08-14 22:55:30 +02:00
'DifferentialCCsFieldSpecification' => 'applications/differential/field/specification/ccs',
Move 'review' -> 'differential'.
2011-01-24 03:10:20 +01:00
'DifferentialChangeType' => 'applications/differential/constants/changetype',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'DifferentialChangeset' => 'applications/differential/storage/changeset',
DifferentialDiffView
2011-01-24 22:18:41 +01:00
'DifferentialChangesetDetailView' => 'applications/differential/view/changesetdetailview',
Javelin integration.
2011-01-25 20:57:47 +01:00
'DifferentialChangesetListView' => 'applications/differential/view/changesetlistview',
DifferentialChangesetView
2011-01-25 00:52:35 +01:00
'DifferentialChangesetParser' => 'applications/differential/parser/changeset',
'DifferentialChangesetViewController' => 'applications/differential/controller/changesetview',
Basic Differential revision feedback view.
2011-01-30 19:37:36 +01:00
'DifferentialComment' => 'applications/differential/storage/comment',
Write pathway for Differential Comments
2011-01-30 21:08:40 +01:00
'DifferentialCommentEditor' => 'applications/differential/editor/comment',
'DifferentialCommentMail' => 'applications/differential/mail/comment',
Differential comment previews.
2011-02-01 03:05:20 +01:00
'DifferentialCommentPreviewController' => 'applications/differential/controller/commentpreview',
Write pathway for Differential Comments
2011-01-30 21:08:40 +01:00
'DifferentialCommentSaveController' => 'applications/differential/controller/commentsave',
Move Differential's read-only fields to the extensible field schema Summary: Move additional fields (which rely on loading handles) to the extensible field classes and out of hardcoding in the controller. Depends on D807. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 808
2011-08-14 21:33:54 +02:00
'DifferentialCommitsFieldSpecification' => 'applications/differential/field/specification/commits',
DifferentialDiffView
2011-01-24 22:18:41 +01:00
'DifferentialController' => 'applications/differential/controller/base',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'DifferentialDAO' => 'applications/differential/storage/base',
Add basic auxiliary field storage for Differential Summary: Precursor to building this out to solve T343. This is similar to the Maniphest fields we landed recently, although I think they're dissimilar enough that it isn't worth going crazy trying to make them share code, at least for now. This doesn't really do anything yet, just adds a storage object and a couple of selector/field indirection classes. Test Plan: Ran SQL upgrade script, created an aux field. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 798
2011-08-10 20:29:08 +02:00
'DifferentialDefaultFieldSelector' => 'applications/differential/field/selector/default',
Move Differential's read-only fields to the extensible field schema Summary: Move additional fields (which rely on loading handles) to the extensible field classes and out of hardcoding in the controller. Depends on D807. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 808
2011-08-14 21:33:54 +02:00
'DifferentialDependenciesFieldSpecification' => 'applications/differential/field/specification/dependencies',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'DifferentialDiff' => 'applications/differential/storage/diff',
DifferentialRevisionEditor
2011-01-26 02:17:19 +01:00
'DifferentialDiffContentMail' => 'applications/differential/mail/diffcontent',
Differential lazyweb diff create workflow.
2011-02-05 21:20:18 +01:00
'DifferentialDiffCreateController' => 'applications/differential/controller/diffcreate',
Conduit: differential.setdiffproperty
2011-01-24 21:07:34 +01:00
'DifferentialDiffProperty' => 'applications/differential/storage/diffproperty',
DifferentialDiffView
2011-01-24 22:18:41 +01:00
'DifferentialDiffTableOfContentsView' => 'applications/differential/view/difftableofcontents',
'DifferentialDiffViewController' => 'applications/differential/controller/diffview',
Improve behavior when user submits a no-op action in Differential Summary: See T730 and the slightly-less-pretty version of this in D1398. When a user takes an action in Differential that has no effect (for instance, accepting an already-accepted revision), prompt them: Action Has No Effect You can not accept this revision because it has already been accepted. Do you want to post the feedback anyway, as a normal comment? [Cancel] [Post as Comment] If they have no comment text, the dialog only says "Cancel". I think this is probably the best way to balance all the concerns here -- it might occasionally be a little annoying, but that should be rare, and it should never be confusing (the current workflow is extremely confusing). This also fixes the issue where you can add all sorts of CCs who are already part of the revision, either explicitly or via mentions. Test Plan: Posted some has-effect and has-no-effect comments, made different choices in the dialog, everything seems to work OK? Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, vrana Maniphest Tasks: T730 Differential Revision: https://secure.phabricator.com/D1403
2012-01-14 20:39:22 +01:00
'DifferentialException' => 'applications/differential/exception/base',
Add reply handler for differential revision Summary: add email reply handler so that the user can reply to a differential email to act on the revision. It generates the reply-to email address, creates email body text with supported commands list, and handle the action request on the differential revision. Right now the reply-to handing is disabled in the config file. But a site using Phabricator can enable it and implement a class inheriting from DifferentialReplyHandler to enable customized email handing. Later we will need to add code to DifferentialMail.php to support sending separate email to each email recipient to achieve better security (see D226). The reply-to will be something like D<revision_id>+<user_id>+<hash>@domain.com. We will create separate task for it. Test Plan: tried comment on a revision from web UI and the email was sent out as before without any change. When a subclass of DifferentialReplyHandler is implemented and enabled, email's reply-to is set and email text is added. Reply to the email with valid command did create action to the revision. Reviewed By: epriestley Reviewers: tuomaspelkonen, epriestley, slawekbiel, dpepper CC: aran, epriestley, jungejason Differential Revision: 224
2011-05-01 04:40:05 +02:00
'DifferentialExceptionMail' => 'applications/differential/mail/exception',
Move Differential's simple fields to the extensible field schema Summary: Differential has a bunch of display-only fields, implement them all as field specifications instead of hard-coded fields. Also add some more documentation and fix redundant string constants in blame rev/revert plan fields. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 807
2011-08-14 20:29:56 +02:00
'DifferentialExportPatchFieldSpecification' => 'applications/differential/field/specification/exportpatch',
'DifferentialFieldDataNotAvailableException' => 'applications/differential/field/exception/notavailable',
Drive Differential commit message parsing through extensible fields Summary: I think this is the last major step -- use the fields to parse commit messages, not a hard-coded list of stuff. This adds two primary methods to fields, one to get all the labels they'll parse (so we can do "CC" and "CCs" and treat them as the same field) and one to parse the string into a canonical representation (e.g., lookup reviewers and such). You'll need to impelement the one block of task-specific stuff I removed in Facebook's task field: list($pre_comment) = split(' -- ', $data); $data = array_filter(preg_split('/[^\d]+/', $pre_comment)); foreach ($data as $k => $v) { $data[$k] = (int)$v; } $data = array_unique($data); break; Otherwise I think this is clean. Test Plan: - Called the conduit method with various commit messages, parsed fields/errors seemed correct. - "arc diff"'d this diff onto localhost, then updated it. - "arc amend"'d this diff. Reviewers: jungejason, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, jungejason, epriestley Differential Revision: 829
2011-08-18 21:08:18 +02:00
'DifferentialFieldParseException' => 'applications/differential/field/exception/parse',
Add basic auxiliary field storage for Differential Summary: Precursor to building this out to solve T343. This is similar to the Maniphest fields we landed recently, although I think they're dissimilar enough that it isn't worth going crazy trying to make them share code, at least for now. This doesn't really do anything yet, just adds a storage object and a couple of selector/field indirection classes. Test Plan: Ran SQL upgrade script, created an aux field. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 798
2011-08-10 20:29:08 +02:00
'DifferentialFieldSelector' => 'applications/differential/field/selector/base',
'DifferentialFieldSpecification' => 'applications/differential/field/specification/base',
Allow Differential custom fields to appear on edit and view interfaces Summary: Depends on D798. Extends custom fields and makes the vaguely useful: they can appear on the edit and view interfaces. This does not integrate them with commit messages yet; that's more complicated but I plan to do it shortly. Test Plan: Implemented a custom field per P123, it correctly appears on the edit interface, persists, validates, and shows up when viewing the revision. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 800
2011-08-10 22:46:01 +02:00
'DifferentialFieldSpecificationIncompleteException' => 'applications/differential/field/exception/incomplete',
'DifferentialFieldValidationException' => 'applications/differential/field/exception/validation',
Drive revision update from Conduit via custom fields Summary: When we create or update a revision, we use a parsed commit message dictionary to edit its fields. Drive consumption of the dictionary through custom fields instead of hardcoding. This requires adding some fields which don't really do anything right now to cover fields which appear only in the commit message. Test Plan: "arc diff"'d this revision against localhost, "arc diff"'d again to update. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 811
2011-08-15 03:52:09 +02:00
'DifferentialGitSVNIDFieldSpecification' => 'applications/differential/field/specification/gitsvnid',
Move Differential's simple fields to the extensible field schema Summary: Differential has a bunch of display-only fields, implement them all as field specifications instead of hard-coded fields. Also add some more documentation and fix redundant string constants in blame rev/revert plan fields. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 807
2011-08-14 20:29:56 +02:00
'DifferentialHostFieldSpecification' => 'applications/differential/field/specification/host',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'DifferentialHunk' => 'applications/differential/storage/hunk',
Bring in JX.Workflow and the inline commenting behavior, plus sync Javelin.
2011-02-02 00:52:04 +01:00
'DifferentialInlineComment' => 'applications/differential/storage/inlinecomment',
InlineComments
2011-02-02 01:42:36 +01:00
'DifferentialInlineCommentEditController' => 'applications/differential/controller/inlinecommentedit',
Inline comment-related fixes.
2011-02-03 04:38:43 +01:00
'DifferentialInlineCommentPreviewController' => 'applications/differential/controller/inlinecommentpreview',
InlineComments
2011-02-02 01:42:36 +01:00
'DifferentialInlineCommentView' => 'applications/differential/view/inlinecomment',
Move Differential's simple fields to the extensible field schema Summary: Differential has a bunch of display-only fields, implement them all as field specifications instead of hard-coded fields. Also add some more documentation and fix redundant string constants in blame rev/revert plan fields. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 807
2011-08-14 20:29:56 +02:00
'DifferentialLinesFieldSpecification' => 'applications/differential/field/specification/lines',
Move Differential's remaining field views to extensble field schema Summary: Move all the rest of the fields into the custom field schema, for revision views. I left a couple of stubs in here (willWriteRevision, didWriteRevision) since I'd planned to do edits here too, but this diff is sort of big-ish already. I'll do all the edit fields in the next revision. Depends on D808. Test Plan: Viewed, edited and conduit'ed some revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 809
2011-08-14 22:55:30 +02:00
'DifferentialLintFieldSpecification' => 'applications/differential/field/specification/lint',
Move 'review' -> 'differential'.
2011-01-24 03:10:20 +01:00
'DifferentialLintStatus' => 'applications/differential/constants/lintstatus',
Display local commit information in Differential Summary: After D857, we try to attach local commit information to revisions. If this information is available, display it on the revision. Design on this is a little rough, I might try to combine this into the revision update view or something like that since we're starting to take up a lot of real estate for metadata. Test Plan: Local diffed this and got some commit info. Reviewers: jungejason, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, epriestley, jungejason Differential Revision: 872
2011-08-30 20:34:07 +02:00
'DifferentialLocalCommitsView' => 'applications/differential/view/localcommits',
DifferentialRevisionEditor
2011-01-26 02:17:19 +01:00
'DifferentialMail' => 'applications/differential/mail/base',
Move Differential's read-only fields to the extensible field schema Summary: Move additional fields (which rely on loading handles) to the extensible field classes and out of hardcoding in the controller. Depends on D807. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 808
2011-08-14 21:33:54 +02:00
'DifferentialManiphestTasksFieldSpecification' => 'applications/differential/field/specification/maniphesttasks',
DifferentialRevisionEditor
2011-01-26 02:17:19 +01:00
'DifferentialNewDiffMail' => 'applications/differential/mail/newdiff',
Move Differential's simple fields to the extensible field schema Summary: Differential has a bunch of display-only fields, implement them all as field specifications instead of hard-coded fields. Also add some more documentation and fix redundant string constants in blame rev/revert plan fields. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 807
2011-08-14 20:29:56 +02:00
'DifferentialPathFieldSpecification' => 'applications/differential/field/specification/path',
Provide basic capabilities to make Differential column width flexible Summary: - Make wrap width settable in PHP. - Dynamically generate max-width based on configurable maximum width. - Constrain non-diff elements to standard width. - Provide a configuration setting. Test Plan: Set various things to 100 / 120, as far as I could tell everything seemed to render sensibly? This should have no effect on 80-col changes. Reviewed By: jdperlow Reviewers: jdperlow, tuomaspelkonen, jungejason, aran CC: aran, jdperlow Differential Revision: 413
2011-06-08 21:39:03 +02:00
'DifferentialPrimaryPaneView' => 'applications/differential/view/primarypane',
Add reply handler for differential revision Summary: add email reply handler so that the user can reply to a differential email to act on the revision. It generates the reply-to email address, creates email body text with supported commands list, and handle the action request on the differential revision. Right now the reply-to handing is disabled in the config file. But a site using Phabricator can enable it and implement a class inheriting from DifferentialReplyHandler to enable customized email handing. Later we will need to add code to DifferentialMail.php to support sending separate email to each email recipient to achieve better security (see D226). The reply-to will be something like D<revision_id>+<user_id>+<hash>@domain.com. We will create separate task for it. Test Plan: tried comment on a revision from web UI and the email was sent out as before without any change. When a subclass of DifferentialReplyHandler is implemented and enabled, email's reply-to is set and email text is added. Reply to the email with valid command did create action to the revision. Reviewed By: epriestley Reviewers: tuomaspelkonen, epriestley, slawekbiel, dpepper CC: aran, epriestley, jungejason Differential Revision: 224
2011-05-01 04:40:05 +02:00
'DifferentialReplyHandler' => 'applications/differential/replyhandler',
Provide builtin definitions for "Blame Revision" and "Revert Plan" fields Summary: This is just to ease transitions for any installs which use these fields (e.g., Facebook). I'll write some docs and a migration script once this stuff is a little more solid, too. Depends on D800. Technically these are "better" than the current fields since they show up other places than the edit screen (derp derp). Test Plan: Created a field selector which provides these; verified they work by typing stuff into them and saving the revision. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 801
2011-08-11 00:36:18 +02:00
'DifferentialRevertPlanFieldSpecification' => 'applications/differential/field/specification/revertplan',
DifferentialRevisionEditor
2011-01-26 02:17:19 +01:00
'DifferentialReviewRequestMail' => 'applications/differential/mail/reviewrequest',
Drive revision update from Conduit via custom fields Summary: When we create or update a revision, we use a parsed commit message dictionary to edit its fields. Drive consumption of the dictionary through custom fields instead of hardcoding. This requires adding some fields which don't really do anything right now to cover fields which appear only in the commit message. Test Plan: "arc diff"'d this revision against localhost, "arc diff"'d again to update. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 811
2011-08-15 03:52:09 +02:00
'DifferentialReviewedByFieldSpecification' => 'applications/differential/field/specification/reviewedby',
Move Differential's remaining field views to extensble field schema Summary: Move all the rest of the fields into the custom field schema, for revision views. I left a couple of stubs in here (willWriteRevision, didWriteRevision) since I'd planned to do edits here too, but this diff is sort of big-ish already. I'll do all the edit fields in the next revision. Depends on D808. Test Plan: Viewed, edited and conduit'ed some revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 809
2011-08-14 22:55:30 +02:00
'DifferentialReviewersFieldSpecification' => 'applications/differential/field/specification/reviewers',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'DifferentialRevision' => 'applications/differential/storage/revision',
Basic Differential revision feedback view.
2011-01-30 19:37:36 +01:00
'DifferentialRevisionCommentListView' => 'applications/differential/view/revisioncommentlist',
'DifferentialRevisionCommentView' => 'applications/differential/view/revisioncomment',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'DifferentialRevisionControlSystem' => 'applications/differential/constants/revisioncontrolsystem',
Added possibility to define custom action links and properties in differential. Summary: There was a need to add old facebook specific action links and properties back to differential. Test Plan: Tested that all the facebook specific links work for multiple different revisions. Reviewed By: epriestley Reviewers: epriestley CC: jungejason, tuomaspelkonen, epriestley Differential Revision: 127
2011-04-13 00:57:29 +02:00
'DifferentialRevisionDetailRenderer' => 'applications/differential/controller/customrenderer',
DifferentialRevisionView
2011-01-27 23:55:52 +01:00
'DifferentialRevisionDetailView' => 'applications/differential/view/revisiondetail',
RevisionEdit
2011-01-25 22:26:09 +01:00
'DifferentialRevisionEditController' => 'applications/differential/controller/revisionedit',
DifferentialRevisionEditor
2011-01-26 02:17:19 +01:00
'DifferentialRevisionEditor' => 'applications/differential/editor/revision',
Emit full URIs to identify Differential revisions Summary: - Previously, used IDs like "33" to match a commit to a Differential revision. This has a namespacing problem because we now have an arbitrarily large number of Phabricator installs in the world, and they may want to track commits from other installs. - In Differential, parse raw IDs or full URIs. Emit only full URIs. - In Repositories, parse only full URIs. - This might cause a few commits to not be picked up in rare circumstances. Users can fix them with "arc mark-committed". This should be exceedingly rare because of hash matching. - There are some caveats for reparsing older repositories, see comments inline. I don't think there's much broad impact here. Test Plan: - Created a new revision, got a full URI. - Updated revision, worked correctly. - Ran unit tests. - Monkeyed with "Differential Revision" field. - Reviewers: btrahan, jungejason Reviewers: btrahan, jungejason Reviewed By: jungejason CC: aran, epriestley, jungejason Maniphest Tasks: T54, T692 Differential Revision: 1250
2011-12-21 00:40:24 +01:00
'DifferentialRevisionIDFieldParserTestCase' => 'applications/differential/field/specification/revisionid/__tests__',
Drive revision update from Conduit via custom fields Summary: When we create or update a revision, we use a parsed commit message dictionary to edit its fields. Drive consumption of the dictionary through custom fields instead of hardcoding. This requires adding some fields which don't really do anything right now to cover fields which appear only in the commit message. Test Plan: "arc diff"'d this revision against localhost, "arc diff"'d again to update. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 811
2011-08-15 03:52:09 +02:00
'DifferentialRevisionIDFieldSpecification' => 'applications/differential/field/specification/revisionid',
RevisionList
2011-01-26 00:19:06 +01:00
'DifferentialRevisionListController' => 'applications/differential/controller/revisionlist',
DifferentialRevisionList
2011-01-27 20:35:04 +01:00
'DifferentialRevisionListData' => 'applications/differential/data/revisionlist',
Separate revision list rendering logic into a RevisionListView Summary: I want to throw this in Diffusion as part of T262, but it's embedded in the controller right now. Split it out. Test Plan: Looked at various revision list views, no changes. Reviewers: jungejason, nh, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, jungejason Differential Revision: 977
2011-10-02 20:42:41 +02:00
'DifferentialRevisionListView' => 'applications/differential/view/revisionlist',
Provide a Differential Revision query class for affected paths Summary: For T262, we need to query for revisions by affected path. We currently have a class called "DifferentialRevisionListData" but it's sort of nasty and it would have been really cumbersome to add this query to it. Instead, this provides a query object more in line with ManiphestTaskQuery, which I'm pretty happy with. I'd eventually like to get rid of DifferentialRevisionListData but it's used in a couple of places right now. Test Plan: Used phpsh to execute queries, got back apparently-sensible result sets. Reviewers: jungejason, nh, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, jungejason, epriestley Differential Revision: 978
2011-10-02 21:03:16 +02:00
'DifferentialRevisionQuery' => 'applications/differential/query/revision',
Move Differential's remaining field views to extensble field schema Summary: Move all the rest of the fields into the custom field schema, for revision views. I left a couple of stubs in here (willWriteRevision, didWriteRevision) since I'd planned to do edits here too, but this diff is sort of big-ish already. I'll do all the edit fields in the next revision. Depends on D808. Test Plan: Viewed, edited and conduit'ed some revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 809
2011-08-14 22:55:30 +02:00
'DifferentialRevisionStatusFieldSpecification' => 'applications/differential/field/specification/revisionstatus',
DifferentialRevisionView
2011-01-27 23:55:52 +01:00
'DifferentialRevisionUpdateHistoryView' => 'applications/differential/view/revisionupdatehistory',
'DifferentialRevisionViewController' => 'applications/differential/controller/revisionview',
Make subscribe/unsubscribe work properly on Revisions. Summary: Test Plan: Reviewers: CC:
2011-02-19 23:36:13 +01:00
'DifferentialSubscribeController' => 'applications/differential/controller/subscribe',
Implement all field edit interfaces on the custom field schema Summary: Moves the revision edit controller to be completely schema-driven. Depends on D810. Test Plan: Edited revisions. Entered intentionally invalid values to trigger error conditions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 810
2011-08-14 23:28:08 +02:00
'DifferentialSummaryFieldSpecification' => 'applications/differential/field/specification/summary',
Tasks can be defined in the commit message (Phabricator part). Summary: Phabricator did not support giving the task ids in the commit message. Currently there is no default implementation for this, but there is a Facebook specific implementation. At some point default implementation for Maniphest tasks to revisions will be added. Test Plan: Tested with the Facebook specific implementation that task ids are recognized in the commit message and tasks are automatically attached to revisions. The task attached to this revision was added from the commit message. Reviewed By: jungejason Reviewers: jungejason, epriestley CC: dpepper, edward, gpatangay, tuomaspelkonen, jungejason Differential Revision: 240996
2011-04-22 02:53:18 +02:00
'DifferentialTasksAttacher' => 'applications/differential/tasks',
Implement all field edit interfaces on the custom field schema Summary: Moves the revision edit controller to be completely schema-driven. Depends on D810. Test Plan: Edited revisions. Entered intentionally invalid values to trigger error conditions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 810
2011-08-14 23:28:08 +02:00
'DifferentialTestPlanFieldSpecification' => 'applications/differential/field/specification/testplan',
'DifferentialTitleFieldSpecification' => 'applications/differential/field/specification/title',
Move Differential's remaining field views to extensble field schema Summary: Move all the rest of the fields into the custom field schema, for revision views. I left a couple of stubs in here (willWriteRevision, didWriteRevision) since I'd planned to do edits here too, but this diff is sort of big-ish already. I'll do all the edit fields in the next revision. Depends on D808. Test Plan: Viewed, edited and conduit'ed some revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 809
2011-08-14 22:55:30 +02:00
'DifferentialUnitFieldSpecification' => 'applications/differential/field/specification/unit',
Move 'review' -> 'differential'.
2011-01-24 03:10:20 +01:00
'DifferentialUnitStatus' => 'applications/differential/constants/unitstatus',
Added a conduit call to update arc unit results for a postponed test. Summary: It was not possible before to update arc unit results for a postponed test. This change makes it possible. Also the number of postponed tests are shown in differential. Let me know if this looks too Facebook specific. Test Plan: Tested the conduit call manually from Conduit Console and updated test results for a diff that had 20 postponed tests. Reviewed By: jungejason Reviewers: epriestley, jungejason Commenters: epriestley CC: slawekbiel, aran, tuomaspelkonen, jungejason, epriestley Differential Revision: 416
2011-06-09 01:16:59 +02:00
'DifferentialUnitTestResult' => 'applications/differential/constants/unittestresult',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionBranchInformation' => 'applications/diffusion/data/branch',
'DiffusionBranchQuery' => 'applications/diffusion/query/branch/base',
'DiffusionBranchTableView' => 'applications/diffusion/view/branchtable',
Diffusion: basic browse view Summary: Synthesizes elements of Diffusion's browse view, Confusion's git support and Phabricator's repository infrastructure to provide a basic browse view for Phabricator Diffusion. This is basically a straight port of Confusion but uses Phabricator's Repository object and uses a real data object instead of arrays. Test Plan: Browsed Javelin in Phabricator at a very basic level. Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson, epriestley Differential Revision: 58
2011-03-08 02:25:47 +01:00
'DiffusionBrowseController' => 'applications/diffusion/controller/browse',
Diffusion: basic file browse capability Summary: Very rough cut of file browsing. Not terribly useful yet, but it does cause file data to appear in the browser window. Test Plan: viewed a file from a git repo Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson Differential Revision: 64
2011-03-08 18:54:55 +01:00
'DiffusionBrowseFileController' => 'applications/diffusion/controller/file',
Diffusion: basic browse view Summary: Synthesizes elements of Diffusion's browse view, Confusion's git support and Phabricator's repository infrastructure to provide a basic browse view for Phabricator Diffusion. This is basically a straight port of Confusion but uses Phabricator's Repository object and uses a real data object instead of arrays. Test Plan: Browsed Javelin in Phabricator at a very basic level. Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson, epriestley Differential Revision: 58
2011-03-08 02:25:47 +01:00
'DiffusionBrowseQuery' => 'applications/diffusion/query/browse/base',
'DiffusionBrowseTableView' => 'applications/diffusion/view/browsetable',
Browse / git improvements.
2011-03-14 06:03:30 +01:00
'DiffusionChangeController' => 'applications/diffusion/controller/change',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'DiffusionCommitChangeTableView' => 'applications/diffusion/view/commitchangetable',
'DiffusionCommitController' => 'applications/diffusion/controller/commit',
Restore "author" link to diffusion Summary: create the page by getting data from the search result. Test Plan: load page with url /author/, /author/valid_username, and /uathor/invalid_username, and verified that it works as expected. Reviewed By: epriestley Reviewers: epriestley, tuomaspelkonen Commenters: tuomaspelkonen CC: hwang, aran, tuomaspelkonen, epriestley, jungejason Differential Revision: 723
2011-07-24 02:09:03 +02:00
'DiffusionCommitListController' => 'applications/diffusion/controller/commitlist',
Show all branches a commit appears on Summary: We show the contextual branch (always the repository default branch) when viewing a commit. Instead, show all branches the commit appears on. Also pull some of the duplicated DiffusionXQuery stuff into a DiffusionQuery base class, I'll do a followup to reduce more duplication. Test Plan: Looked at a commit in Git. My HG and SVN setups are a little borked so I kind of faked tests in them -- I'm fixing them now. Reviewers: btrahan, jungejason, fratrik Reviewed By: btrahan CC: aran Maniphest Tasks: T768 Differential Revision: https://secure.phabricator.com/D1458
2012-01-19 20:49:51 +01:00
'DiffusionContainsQuery' => 'applications/diffusion/query/contains/base',
Rough version of DiffusionHomeController Summary: My strategy here is to synthesize Diffusion + Confusion (jwilson's git support for Diffusion) + Repository/Commit stuff into Phabricator and kill all birds with one stone. This probably involves the least total work since we have to do this port step anyway and a lot of the Phabricator primitives are in better shape than the trunk primitives. Test Plan: Looked at it in my sandbox, which has some parsed commits. Reviewers: jwilson, aran, jungejason CC: Differential Revision: 57
2011-03-08 00:13:36 +01:00
'DiffusionController' => 'applications/diffusion/controller/base',
Rough cut of Diffusion change view.
2011-03-31 02:36:16 +02:00
'DiffusionDiffController' => 'applications/diffusion/controller/diff',
'DiffusionDiffQuery' => 'applications/diffusion/query/diff/base',
Diffusion: basic file browse capability Summary: Very rough cut of file browsing. Not terribly useful yet, but it does cause file data to appear in the browser window. Test Plan: viewed a file from a git repo Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson Differential Revision: 64
2011-03-08 18:54:55 +01:00
'DiffusionFileContent' => 'applications/diffusion/data/filecontent',
'DiffusionFileContentQuery' => 'applications/diffusion/query/filecontent/base',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionGitBranchQuery' => 'applications/diffusion/query/branch/git',
Make tracked git repositories use an implicit 'origin' remote Summary: See T624. I originally wrote this to require an explicit remote, but this creates an ugly "origin:" in all the URIs and makes T270 more difficult. Treat all branch names as implying 'origin/'. Test Plan: - Pulled and imported a fresh copy of libphutil without issues. - Browsed various git repositories. - Browsed Javelin's various branches. - Ran upgrade script, got a bunch of clean 'origin/master' -> 'master' conversions. - Tried to specify an explicit remote in a default branch name. - Unit tests. Reviewers: nh, jungejason, btrahan Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T624 Differential Revision: https://secure.phabricator.com/D1269
2011-12-22 21:24:12 +01:00
'DiffusionGitBranchQueryTestCase' => 'applications/diffusion/query/branch/git/__tests__',
Diffusion: basic browse view Summary: Synthesizes elements of Diffusion's browse view, Confusion's git support and Phabricator's repository infrastructure to provide a basic browse view for Phabricator Diffusion. This is basically a straight port of Confusion but uses Phabricator's Repository object and uses a real data object instead of arrays. Test Plan: Browsed Javelin in Phabricator at a very basic level. Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson, epriestley Differential Revision: 58
2011-03-08 02:25:47 +01:00
'DiffusionGitBrowseQuery' => 'applications/diffusion/query/browse/git',
Show all branches a commit appears on Summary: We show the contextual branch (always the repository default branch) when viewing a commit. Instead, show all branches the commit appears on. Also pull some of the duplicated DiffusionXQuery stuff into a DiffusionQuery base class, I'll do a followup to reduce more duplication. Test Plan: Looked at a commit in Git. My HG and SVN setups are a little borked so I kind of faked tests in them -- I'm fixing them now. Reviewers: btrahan, jungejason, fratrik Reviewed By: btrahan CC: aran Maniphest Tasks: T768 Differential Revision: https://secure.phabricator.com/D1458
2012-01-19 20:49:51 +01:00
'DiffusionGitContainsQuery' => 'applications/diffusion/query/contains/git',
Basic DiffusionGitDiffQuery.
2011-03-31 03:17:36 +02:00
'DiffusionGitDiffQuery' => 'applications/diffusion/query/diff/git',
Diffusion: basic file browse capability Summary: Very rough cut of file browsing. Not terribly useful yet, but it does cause file data to appear in the browser window. Test Plan: viewed a file from a git repo Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson Differential Revision: 64
2011-03-08 18:54:55 +01:00
'DiffusionGitFileContentQuery' => 'applications/diffusion/query/filecontent/git',
Diffusion: rough cut of history view Summary: Very very rough approximation of history view. I left out all the log parsing stuff for now since we should be able to just look it up in a Repository table and I think that'll be a bit faster, although we can muck around and see. Test Plan: Looked at history of a path Reviewed By: jwilson Reviewers: aran, jwilson CC: epriestley, jwilson Differential Revision: 66
2011-03-09 02:31:44 +01:00
'DiffusionGitHistoryQuery' => 'applications/diffusion/query/history/git',
Add more change metadata to SVN and git.
2011-03-31 08:27:06 +02:00
'DiffusionGitLastModifiedQuery' => 'applications/diffusion/query/lastmodified/git',
Diffusion: encapsulate request in DiffusionRequest Summary: Put an indirection layer between controllers and URI management, adding branches to git repositories. Test Plan: Looked at browse, history browse, file browse views, bad branches, bad commits Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson, epriestley Differential Revision: 65
2011-03-08 23:29:02 +01:00
'DiffusionGitRequest' => 'applications/diffusion/request/git',
Diffusion: rough cut of history view Summary: Very very rough approximation of history view. I left out all the log parsing stuff for now since we should be able to just look it up in a Repository table and I think that'll be a bit faster, although we can muck around and see. Test Plan: Looked at history of a path Reviewed By: jwilson Reviewers: aran, jwilson CC: epriestley, jwilson Differential Revision: 66
2011-03-09 02:31:44 +01:00
'DiffusionHistoryController' => 'applications/diffusion/controller/history',
'DiffusionHistoryQuery' => 'applications/diffusion/query/history/base',
'DiffusionHistoryTableView' => 'applications/diffusion/view/historytable',
Rough version of DiffusionHomeController Summary: My strategy here is to synthesize Diffusion + Confusion (jwilson's git support for Diffusion) + Repository/Commit stuff into Phabricator and kill all birds with one stone. This probably involves the least total work since we have to do this port step anyway and a lot of the Phabricator primitives are in better shape than the trunk primitives. Test Plan: Looked at it in my sandbox, which has some parsed commits. Reviewers: jwilson, aran, jungejason CC: Differential Revision: 57
2011-03-08 00:13:36 +01:00
'DiffusionHomeController' => 'applications/diffusion/controller/home',
Add more change metadata to SVN and git.
2011-03-31 08:27:06 +02:00
'DiffusionLastModifiedController' => 'applications/diffusion/controller/lastmodified',
'DiffusionLastModifiedQuery' => 'applications/diffusion/query/lastmodified/base',
Basic support for Mercurial in Diffusion Summary: Change import script plus almost all the view stuff. Still some rough edges but this seems to mostly work. Blame is currently unsupported but I think everything else works properly. Test Plan: Imported the hg repository itself. It doesn't immediately seem completely broken. Here are some screens: https://secure.phabricator.com/file/view/PHID-FILE-1438b71cc7c4a2eb4569/ https://secure.phabricator.com/file/view/PHID-FILE-3cec4f72f39e7de2d041/ https://secure.phabricator.com/file/view/PHID-FILE-2ea4883f160e8e5098f9/ https://secure.phabricator.com/file/view/PHID-FILE-35f751a36ebf65399ade/ All the parsers were able to churn through it without errors. Ran the new "reparse.php" script in various one-commit and repository modes. Browsed/imported some git repos for good measure. NOTE: The hg repository is only 15,000 commits and around 1,000 files. Performance is okay but hg doesn't provide performant, native APIs to get some data efficiently so we have to do some dumb stuff. If some of these interfaces are cripplingly slow or whatever, let me know and we can start bundling some Mercurial extensions with Arcanist. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, Makinde, epriestley Differential Revision: 960
2011-09-26 20:07:38 +02:00
'DiffusionMercurialBranchQuery' => 'applications/diffusion/query/branch/mercurial',
'DiffusionMercurialBrowseQuery' => 'applications/diffusion/query/browse/mercurial',
Show all branches a commit appears on Summary: We show the contextual branch (always the repository default branch) when viewing a commit. Instead, show all branches the commit appears on. Also pull some of the duplicated DiffusionXQuery stuff into a DiffusionQuery base class, I'll do a followup to reduce more duplication. Test Plan: Looked at a commit in Git. My HG and SVN setups are a little borked so I kind of faked tests in them -- I'm fixing them now. Reviewers: btrahan, jungejason, fratrik Reviewed By: btrahan CC: aran Maniphest Tasks: T768 Differential Revision: https://secure.phabricator.com/D1458
2012-01-19 20:49:51 +01:00
'DiffusionMercurialContainsQuery' => 'applications/diffusion/query/contains/mercurial',
Basic support for Mercurial in Diffusion Summary: Change import script plus almost all the view stuff. Still some rough edges but this seems to mostly work. Blame is currently unsupported but I think everything else works properly. Test Plan: Imported the hg repository itself. It doesn't immediately seem completely broken. Here are some screens: https://secure.phabricator.com/file/view/PHID-FILE-1438b71cc7c4a2eb4569/ https://secure.phabricator.com/file/view/PHID-FILE-3cec4f72f39e7de2d041/ https://secure.phabricator.com/file/view/PHID-FILE-2ea4883f160e8e5098f9/ https://secure.phabricator.com/file/view/PHID-FILE-35f751a36ebf65399ade/ All the parsers were able to churn through it without errors. Ran the new "reparse.php" script in various one-commit and repository modes. Browsed/imported some git repos for good measure. NOTE: The hg repository is only 15,000 commits and around 1,000 files. Performance is okay but hg doesn't provide performant, native APIs to get some data efficiently so we have to do some dumb stuff. If some of these interfaces are cripplingly slow or whatever, let me know and we can start bundling some Mercurial extensions with Arcanist. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, Makinde, epriestley Differential Revision: 960
2011-09-26 20:07:38 +02:00
'DiffusionMercurialDiffQuery' => 'applications/diffusion/query/diff/mercurial',
'DiffusionMercurialFileContentQuery' => 'applications/diffusion/query/filecontent/mercurial',
'DiffusionMercurialHistoryQuery' => 'applications/diffusion/query/history/mercurial',
'DiffusionMercurialLastModifiedQuery' => 'applications/diffusion/query/lastmodified/mercurial',
'DiffusionMercurialRequest' => 'applications/diffusion/request/mercurial',
Diffusion: rough cut of history view Summary: Very very rough approximation of history view. I left out all the log parsing stuff for now since we should be able to just look it up in a Repository table and I think that'll be a bit faster, although we can muck around and see. Test Plan: Looked at history of a path Reviewed By: jwilson Reviewers: aran, jwilson CC: epriestley, jwilson Differential Revision: 66
2011-03-09 02:31:44 +01:00
'DiffusionPathChange' => 'applications/diffusion/data/pathchange',
Some Diffusion path change stuff.
2011-03-14 00:19:39 +01:00
'DiffusionPathChangeQuery' => 'applications/diffusion/query/pathchange/base',
Some owners read workflows.
2011-04-04 04:20:47 +02:00
'DiffusionPathCompleteController' => 'applications/diffusion/controller/pathcomplete',
Build an "affected path" index when attaching diffs to revisions Summary: See T262. This creates the index on the Differential side which we need in order to execute this query efficiently on the Diffusion side. Also renames "DiffusionGitPathIDQuery" to "DiffusionPathIDQuery", this query object has nothing to do with git. Test Plan: Attached top-level and sub-level diffs to revisions and verified they populated the table with sensible data. Reviewers: bmaurer, aravindn, fmoo, jungejason, nh, tuomaspelkonen, aran CC: Differential Revision: 931
2011-09-14 19:59:52 +02:00
'DiffusionPathIDQuery' => 'applications/diffusion/query/pathid/base',
Fix a dirname() edge case in Diffusion Summary: dirname('x') returns '.', not '/'; this caused some issues for repositories with files at the root. There are some cases in the parsers where I should probably swap this out too but I'll wait until I'm doing some more rigorous testing since that stuff is a bit fragile and this fixes an immediate issue. Test Plan: Ran unit tests. Viewed a file at root level in a test repository. Reviewers: jungejason, nh, tuomaspelkonen, aran Reviewed By: nh CC: aran, nh Differential Revision: 932
2011-09-14 20:23:39 +02:00
'DiffusionPathQueryTestCase' => 'applications/diffusion/query/pathid/base/__tests__',
Some owners read workflows.
2011-04-04 04:20:47 +02:00
'DiffusionPathValidateController' => 'applications/diffusion/controller/pathvalidate',
Show all branches a commit appears on Summary: We show the contextual branch (always the repository default branch) when viewing a commit. Instead, show all branches the commit appears on. Also pull some of the duplicated DiffusionXQuery stuff into a DiffusionQuery base class, I'll do a followup to reduce more duplication. Test Plan: Looked at a commit in Git. My HG and SVN setups are a little borked so I kind of faked tests in them -- I'm fixing them now. Reviewers: btrahan, jungejason, fratrik Reviewed By: btrahan CC: aran Maniphest Tasks: T768 Differential Revision: https://secure.phabricator.com/D1458
2012-01-19 20:49:51 +01:00
'DiffusionQuery' => 'applications/diffusion/query/base',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionRepositoryController' => 'applications/diffusion/controller/repository',
Diffusion: basic browse view Summary: Synthesizes elements of Diffusion's browse view, Confusion's git support and Phabricator's repository infrastructure to provide a basic browse view for Phabricator Diffusion. This is basically a straight port of Confusion but uses Phabricator's Repository object and uses a real data object instead of arrays. Test Plan: Browsed Javelin in Phabricator at a very basic level. Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson, epriestley Differential Revision: 58
2011-03-08 02:25:47 +01:00
'DiffusionRepositoryPath' => 'applications/diffusion/data/repositorypath',
Diffusion: encapsulate request in DiffusionRequest Summary: Put an indirection layer between controllers and URI management, adding branches to git repositories. Test Plan: Looked at browse, history browse, file browse views, bad branches, bad commits Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson, epriestley Differential Revision: 65
2011-03-08 23:29:02 +01:00
'DiffusionRequest' => 'applications/diffusion/request/base',
Show all branches a commit appears on Summary: We show the contextual branch (always the repository default branch) when viewing a commit. Instead, show all branches the commit appears on. Also pull some of the duplicated DiffusionXQuery stuff into a DiffusionQuery base class, I'll do a followup to reduce more duplication. Test Plan: Looked at a commit in Git. My HG and SVN setups are a little borked so I kind of faked tests in them -- I'm fixing them now. Reviewers: btrahan, jungejason, fratrik Reviewed By: btrahan CC: aran Maniphest Tasks: T768 Differential Revision: https://secure.phabricator.com/D1458
2012-01-19 20:49:51 +01:00
'DiffusionSVNContainsQuery' => 'applications/diffusion/query/contains/svn',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionSvnBrowseQuery' => 'applications/diffusion/query/browse/svn',
Rough cut of Diffusion change view.
2011-03-31 02:36:16 +02:00
'DiffusionSvnDiffQuery' => 'applications/diffusion/query/diff/svn',
Browse / git improvements.
2011-03-14 06:03:30 +01:00
'DiffusionSvnFileContentQuery' => 'applications/diffusion/query/filecontent/svn',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionSvnHistoryQuery' => 'applications/diffusion/query/history/svn',
Add more change metadata to SVN and git.
2011-03-31 08:27:06 +02:00
'DiffusionSvnLastModifiedQuery' => 'applications/diffusion/query/lastmodified/svn',
Add syntax highlight to diffusion. Summary: use XHPAST parser to parse the file, and generate a table for the code to highlight it. This is part of the task of "Port Diffusion's Browse File view to Phabricator". Test Plan: browse file, try commit version, line number functionality. Reviewed By: epriestley Reviewers: epriestley CC: epriestley Differential Revision: 83
2011-03-23 03:34:47 +01:00
'DiffusionSvnRequest' => 'applications/diffusion/request/svn',
Add a simple symbol lookup interface for cross-references Summary: This will get fancier, but here's a basic interface for doing symbol lookups. Still all pretty tentative. Test Plan: Looked up various things, got some sensible results. Reviewers: jungejason, nh, tuomaspelkonen, aran Reviewed By: tuomaspelkonen CC: aran, tuomaspelkonen Differential Revision: 900
2011-09-05 19:43:24 +02:00
'DiffusionSymbolController' => 'applications/diffusion/controller/symbol',
'DiffusionSymbolQuery' => 'applications/diffusion/query/symbol',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionView' => 'applications/diffusion/view/base',
Drydock Rough Cut Summary: Rough cut of Drydock. This is very basic and doesn't do much of use yet (it //does// allocate EC2 machines as host resources and expose interfaces to them), but I think the overall structure is more or less reasonable. == Interfaces Vision: Applications interact with Drydock resources through DrydockInterfaces, like **command**, **filesystem** and **httpd** interfaces. Each interface allows applications to perform some kind of operation on the resource, like executing commands, reading/writing files, or configuring a web server. Interfaces have a concrete, specific API: // Filesystem Interface $fs = $lease->getInterface('filesystem'); // Constants, some day? $fs->writeFile('index.html', 'hello world!'); // Command Interface $cmd = $lease->getInterface('command'); echo $cmd->execx('uptime'); // HTTPD Interface $httpd = $lease->getInterface('httpd'); $httpd->restart(); Interfaces are mostly just stock, although installs might add new interfaces if they expose different ways to interact with resources (for instance, a resource might want to expose a new 'MongoDB' interface or whatever). Currently: We have like part of a command interface. == Leases Vision: Leases keep track of which resources are in use, and what they're being used for. They allow us to know when we need to allocate more resources (too many sandcastles on the existing hosts, e.g.) and when we can release resources (because they are no longer being used). They also give applications something to hold while resources are being allocated. // EXAMPLE: How this should work some day. $allocator = new DrydockAllocator(); $allocator->setResourceType('sandcastle'); $allocator->setAttributes( array( 'diffID' => $diff->getID(), )); $lease = $allocator->allocate(); $diff->setSandcastleLeaseID($lease->getID()); // ... if ($lease->getStatus() == DrydockLeaseStatus::STATUS_ACTIVE) { $sandcastle_link = $lease->getInterface('httpd')->getURI('/'); } else { $sandcastle_link = 'Still building your sandcastle...'; } echo "Sandcastle for this diff: ".$sandcastle_link; // EXAMPLE: How this actually works now. $allocator = new DrydockAllocator(); $allocator->setResourceType('host'); // NOTE: Allocation is currently synchronous but will be task-driven soon. $lease = $allocator->allocate(); Leases are completely stock, installs will not define new lease types. Currently: Leases exist and work but are very very basic. == Resources Vision: Resources represent some actual thing we've put somewhere, whether it's a host, a block of storage, a webroot, or whatever else. Applications interact through resources by acquiring leases to them, and then getting interfaces through these leases. The lease acquisition process has a side effect of allocating new resources if a lease can't be acquired on existing resources (e.g., the application wants storage but all storage resources are full) and things are configured to autoscale. Resources may themselves acquire leases in order to allocate. For instance, a storage resource might first acquire a lease to a host resource. A 'test scaffold' resource might lease a storage resource and a mysql resource. Not all resources are auto-allocate: the entry-level version of Drydock is that you manually allocate a couple boxes and configure them through the web console. Then, e.g., 'storage' / 'webroot' resources allocate on top of them, but the host pool itself does not autoscale. Resources are completely stock, they are abstract shells representing any arbitrary thing. Currently: Resource exist ('host' only) but are very very basic. == Blueprints Vision: Blueprints contain instructions for building interfaces to, (possibly) allocating, updating, managing, and destroying a specific type of resource in a specific location. One way to think of them is that they are scripts for creating and deleting resources. For example, the LocalHost, RemoteHost and EC2Host blueprints can all manage 'host' resources. Eventually, we will support more types of resources (storage, webroot, sandcastle, test scaffold, phacility deployment) and more providers for resource types, some of which will be in the Phabricator mainline and some of which will be custom. Blueprints are very custom and specific to application types, so installs will define new blueprints if they are making significant use of Drydock. Currently: They exist but have few capabilities. The stock blueprints do nearly nothing useful. There is a technically functional blueprint for host allocation in EC2. == Allocator This is just the actual code to execute the lease acquisition process. Test Plan: Ran "drydock_control.php" script, it allocated a machine in EC2, acquired a lease on it, interfaced with it, and then released the lease. Ran it again, got a fresh lease on the existing resource. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D1454
2012-01-11 20:18:40 +01:00
'DrydockAllocator' => 'applications/drydock/allocator/resource',
'DrydockBlueprint' => 'applications/drydock/blueprint/base',
'DrydockCommandInterface' => 'applications/drydock/interface/command/base',
'DrydockConstants' => 'applications/drydock/constants/base',
'DrydockController' => 'applications/drydock/controller/base',
'DrydockDAO' => 'applications/drydock/storage/base',
'DrydockEC2HostBlueprint' => 'applications/drydock/blueprint/ec2host',
'DrydockInterface' => 'applications/drydock/interface/base',
'DrydockLease' => 'applications/drydock/storage/lease',
'DrydockLeaseListController' => 'applications/drydock/controller/leaselist',
'DrydockLeaseStatus' => 'applications/drydock/constants/leasestatus',
'DrydockLocalCommandInterface' => 'applications/drydock/interface/command/local',
'DrydockLocalHostBlueprint' => 'applications/drydock/blueprint/localhost',
'DrydockRemoteHostBlueprint' => 'applications/drydock/blueprint/remotehost',
'DrydockResource' => 'applications/drydock/storage/resource',
'DrydockResourceAllocateController' => 'applications/drydock/controller/resourceallocate',
'DrydockResourceListController' => 'applications/drydock/controller/resourcelist',
'DrydockResourceStatus' => 'applications/drydock/constants/resourcestatus',
'DrydockSSHCommandInterface' => 'applications/drydock/interface/command/ssh',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldAction' => 'applications/herald/storage/action',
'HeraldActionConfig' => 'applications/herald/config/action',
Enable admin to view and delete other users' herald rules Summary: enable admin to delete user's herald rules. This is useful for managing non-active users' rules. For example, ex-employees' rules. The code change includes: - Added a 'All' tab which is only accessible to admin. - Refactor out a HeraldRuleListView which is used by both the home controller and the all rule controller Test Plan: delete an ex-employee rule as an admin; disable myself as admin and verified that I don't have access to view other user's rules and I'am not be able to delete them; also verified that as a non-admin, I can still view, create and delete my own rules. Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, epriestley, jungejason Differential Revision: 1064
2011-11-06 09:07:04 +01:00
'HeraldAllRulesController' => 'applications/herald/controller/all',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldApplyTranscript' => 'applications/herald/storage/transcript/apply',
HeraldCommitAdapter and some related junk.
2011-04-04 08:23:36 +02:00
'HeraldCommitAdapter' => 'applications/herald/adapter/commit',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldCondition' => 'applications/herald/storage/condition',
'HeraldConditionConfig' => 'applications/herald/config/condition',
'HeraldConditionTranscript' => 'applications/herald/storage/transcript/condition',
'HeraldContentTypeConfig' => 'applications/herald/config/contenttype',
Rough cut of Herald home controller.
2011-03-22 21:49:46 +01:00
'HeraldController' => 'applications/herald/controller/base',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldDAO' => 'applications/herald/storage/base',
Herald CSS, plus edit/save/delete.
2011-03-24 19:07:36 +01:00
'HeraldDeleteController' => 'applications/herald/controller/delete',
Rough cut of herald transcripts and Differential adapter.
2011-03-25 05:32:26 +01:00
'HeraldDifferentialRevisionAdapter' => 'applications/herald/adapter/differential',
Very rough cut at Herald test console.
2011-03-24 21:49:21 +01:00
'HeraldDryRunAdapter' => 'applications/herald/adapter/dryrun',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldEffect' => 'applications/herald/engine/effect',
'HeraldEngine' => 'applications/herald/engine/engine',
'HeraldFieldConfig' => 'applications/herald/config/field',
Rough cut of Herald home controller.
2011-03-22 21:49:46 +01:00
'HeraldHomeController' => 'applications/herald/controller/home',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldInvalidConditionException' => 'applications/herald/engine/engine/exception',
'HeraldInvalidFieldException' => 'applications/herald/engine/engine/exception',
Herald 'new rule type' interface.
2011-03-22 22:34:38 +01:00
'HeraldNewController' => 'applications/herald/controller/new',
Very rough cut at Herald test console.
2011-03-24 21:49:21 +01:00
'HeraldObjectAdapter' => 'applications/herald/adapter/base',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldObjectTranscript' => 'applications/herald/storage/transcript/object',
'HeraldRecursiveConditionsException' => 'applications/herald/engine/engine/exception',
herald: add the ability to execute a rule the first time only Summary: - added a new config class for representing the kind of repetition a rule has (once, every time, first time only) - added an email action to herald rules for differential to allow someone to get an email but only the first one - changed the herald rule ui to allow a user to pick the amount of repetition Test Plan: created a test rule and ran it over and over Reviewed By: epriestley Reviewers: epriestley, tuomaspelkonen CC: aran, epriestley, gc3 Revert Plan: Tags: - begin *PUBLIC* platform impact section - Bugzilla: # - end platform impact - Differential Revision: 357
2011-05-28 00:52:26 +02:00
'HeraldRepetitionPolicyConfig' => 'applications/herald/config/repetitionpolicy',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldRule' => 'applications/herald/storage/rule',
Horrendously rough cut of Herald rule editor.
2011-03-22 23:27:52 +01:00
'HeraldRuleController' => 'applications/herald/controller/rule',
Enable admin to view and delete other users' herald rules Summary: enable admin to delete user's herald rules. This is useful for managing non-active users' rules. For example, ex-employees' rules. The code change includes: - Added a 'All' tab which is only accessible to admin. - Refactor out a HeraldRuleListView which is used by both the home controller and the all rule controller Test Plan: delete an ex-employee rule as an admin; disable myself as admin and verified that I don't have access to view other user's rules and I'am not be able to delete them; also verified that as a non-admin, I can still view, create and delete my own rules. Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, epriestley, jungejason Differential Revision: 1064
2011-11-06 09:07:04 +01:00
'HeraldRuleListView' => 'applications/herald/view/rulelist',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldRuleTranscript' => 'applications/herald/storage/transcript/rule',
Created personal vs. global herald rule distingtion Summary: A personal rule only has actions targeting the owner. Likewise, only they can edit the rule. OTOH, a global may affect any target and is editable by anyone. There are no new action types. Instead, type of the rule modifies the available targets and the messaging in the ui. This is beneficial because herald rule adapters don't need to be aware of the difference between emailing the owner of a personal rule and emailing an arbitrary user. This diff sets up the logic and ui for creating personal/global rules. All existing rules have been defaulted to global. TODO: Filter all existing rules into personal/global TODO: Create a UI for surfacing (relevant?) global rules. Test Plan: 1. Created a personal rule to email myself. Created a dumby revision satisfying the conditions of that rule. Verified that I recieved a herald email. 2. Removed my adminship, change the owner of a personal rule. verified that I couldn't edit the rule. 3.Changed rule type to global. verified that I could edit the rule. 4. Verified that admins can edit both global and personal rules. Reviewers: epriestley, jungejason Reviewed By: epriestley CC: aran, zizzy Differential Revision: https://secure.phabricator.com/D1449
2012-01-14 00:24:56 +01:00
'HeraldRuleTypeConfig' => 'applications/herald/config/ruletype',
Very rough cut at Herald test console.
2011-03-24 21:49:21 +01:00
'HeraldTestConsoleController' => 'applications/herald/controller/test',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldTranscript' => 'applications/herald/storage/transcript/base',
Rough cut of herald transcripts and Differential adapter.
2011-03-25 05:32:26 +01:00
'HeraldTranscriptController' => 'applications/herald/controller/transcript',
'HeraldTranscriptListController' => 'applications/herald/controller/transcriptlist',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldValueTypeConfig' => 'applications/herald/config/valuetype',
PhabricatorEnv 'infratructure' -> 'infrastructure' (rofl) Recaptcha Email Login / Forgot Password Password Reset
2011-01-31 20:55:26 +01:00
'Javelin' => 'infrastructure/javelin/api',
Examples using JX.View Summary: Provide a dirt-simple working example of client-side templating and reactive programming. Test Plan: Load the examples Reviewers: epriestley, mroch, tomo Reviewed By: epriestley CC: ide, schrockn, aran, rzadorozny, epriestley Differential Revision: 908
2011-09-07 23:01:13 +02:00
'JavelinReactorExample' => 'applications/uiexample/examples/reactor',
'JavelinViewExample' => 'applications/uiexample/examples/client',
'JavelinViewExampleServerView' => 'applications/uiexample/examples/client',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'LiskDAO' => 'storage/lisk/dao',
Provide connection isolation to Lisk and enable it by default in tests Summary: Allow Lisk to be put into process-isolated mode which establishes only isolated connections. By default, put it into this mode when running unit tests. Build some simple unit tests around object insertion and updating. NOTE: The one flaw in this is that $dao->establishConnection() still punches through the isolation layer. I need to do an API change to fix this though so I'm holding it for now. It will probably just rename getConnection() to establishConnection() and then rename establishConnection() to something scary like establishLiveExternalConnection(). Test Plan: Ran unit tests. Reviewed By: aran Reviewers: aran, tuomaspelkonen, jungejason CC: aran, epriestley Differential Revision: 194
2011-04-30 19:11:59 +02:00
'LiskIsolationTestCase' => 'storage/lisk/dao/__tests__',
'LiskIsolationTestDAO' => 'storage/lisk/dao/__tests__',
'LiskIsolationTestDAOException' => 'storage/lisk/dao/__tests__',
Publish feed stories from Maniphest Summary: I didn't get around to this earlier; add Feed/Maniphest integration. This is partly motivated by wanting Projects to not be terrible. Pretty straightforward. Test Plan: - Created, updated, reassigned and closed a task. - Verified feed stories render reasonably. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T681 Differential Revision: 1232
2011-12-17 22:27:11 +01:00
'ManiphestAction' => 'applications/maniphest/constants/action',
Support for config-based custom fields in Maniphest Test Plan: Add fields to config based on specification on T335. View on Task Edit and Task Detail. Supported types are string, int and select Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley, hunterbridges Differential Revision: 753
2011-07-27 18:49:50 +02:00
'ManiphestAuxiliaryFieldDefaultSpecification' => 'applications/maniphest/auxiliaryfield/default',
'ManiphestAuxiliaryFieldSpecification' => 'applications/maniphest/auxiliaryfield/base',
'ManiphestAuxiliaryFieldTypeException' => 'applications/maniphest/auxiliaryfield/typeexception',
'ManiphestAuxiliaryFieldValidationException' => 'applications/maniphest/auxiliaryfield/validationexception',
Slightly improve Maniphest documentation.
2011-07-04 22:04:22 +02:00
'ManiphestConstants' => 'applications/maniphest/constants/base',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestController' => 'applications/maniphest/controller/base',
'ManiphestDAO' => 'applications/maniphest/storage/base',
Support for config-based custom fields in Maniphest Test Plan: Add fields to config based on specification on T335. View on Task Edit and Task Detail. Supported types are string, int and select Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley, hunterbridges Differential Revision: 753
2011-07-27 18:49:50 +02:00
'ManiphestDefaultTaskExtensions' => 'applications/maniphest/extensions/task',
Support email multiplexing for private Reply-To addresses Summary: Provide a base PhabricatorMailReplyHandler class which handles the plumbing for multiplexing email if necessary and supporting public and private reply handler addressses. DifferentialReplyHandler now extends it, and a new ManiphestReplyHandler also does. The general approach here is that we have three supported cases: - no reply handler, default config, same as what we're doing now - public reply handler, requires overriding classes but just sets "reply-to" to some address the install generates and still sends only one email - private reply handler, provides a default generation mechanism or you can override it and splits mail apart so we send one to each recipient Test Plan: Sent email from Maniphest and Differential with and without reply-handler-domains set. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley Differential Revision: 254
2011-05-10 01:31:26 +02:00
'ManiphestReplyHandler' => 'applications/maniphest/replyhandler',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestTask' => 'applications/maniphest/storage/task',
Key Value Store for ManiphestTask Test Plan: Look at a task detail. Some dummy attributes are automatically added in ManiphestTaskDetailController. Reviewed By: epriestley Differential Revision: 730
2011-07-26 00:34:56 +02:00
'ManiphestTaskAuxiliaryStorage' => 'applications/maniphest/storage/auxiliary',
Show description changes in Maniphest Summary: When a task description is updated, there's currently no way to see the change. Build an "expanded summary" mode for transactions that shows description change details. Also include changes in the email. Test Plan: Changed task descriptions, clicked "show details", read email. Reviewed By: aran Reviewers: tuomaspelkonen, jungejason, aran CC: anjali, aran, epriestley Differential Revision: 320
2011-05-21 03:56:18 +02:00
'ManiphestTaskDescriptionChangeController' => 'applications/maniphest/controller/descriptionchange',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestTaskDetailController' => 'applications/maniphest/controller/taskdetail',
Enable task editing in Maniphest. Summary: Test Plan: Reviewers: CC:
2011-02-20 23:15:53 +01:00
'ManiphestTaskEditController' => 'applications/maniphest/controller/taskedit',
Tweak Maniphest custom fields Summary: - Fix a bug where 'caption' didn't do anything. - Provide an abstract base implementation for extensions. - Add some documentation. - Expose aux fields via conduit. Test Plan: Added some fields like "Dinosaur", "Kilograms" and "derp" on my local install. Read documentation. Reviewed By: jungejason Reviewers: hunterbridges, jungejason, tuomaspelkonen, aran CC: aran, philc, jungejason Differential Revision: 785
2011-08-05 18:44:43 +02:00
'ManiphestTaskExtensions' => 'applications/maniphest/extensions/base',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestTaskListController' => 'applications/maniphest/controller/tasklist',
'ManiphestTaskListView' => 'applications/maniphest/view/tasklist',
Allow Maniphest filtering by "upforgrabs" explicitly Summary: Allow you to filter by "upforgrabs" to find unassigned tasks. Test Plan: Filtered by "upforgrabs". Reviewed By: tuomaspelkonen Reviewers: tuomaspelkonen, jungejason, aran Commenters: aran CC: sandra, anjali, aran, tuomaspelkonen, epriestley Differential Revision: 365
2011-05-28 23:13:12 +02:00
'ManiphestTaskOwner' => 'applications/maniphest/constants/owner',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestTaskPriority' => 'applications/maniphest/constants/priority',
Allow Maniphest tasks to be filtered by Project Summary: Major things taking place here: - A new table for storing <task, project> relationships. - Moved all task query logic into a dedicated class. - Added a "projects" filter to the UI. I was originally going to try to drive this off the main search index but the perf benefits of a custom schema make an overwhelming argument in favor of doing it this way. Test Plan: Filtered tasks by author and owner and zero, one, and more than one project. Exercised all the group/sort options. Ran the index script over my 100k task corpus. Edited task-project membership and verified the index updated. Reviewed By: cadamo Reviewers: gc3, jungejason, cadamo, tuomaspelkonen, aran CC: aran, cadamo, epriestley Differential Revision: 556
2011-06-30 01:16:33 +02:00
'ManiphestTaskProject' => 'applications/maniphest/storage/taskproject',
'ManiphestTaskQuery' => 'applications/maniphest/query',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestTaskStatus' => 'applications/maniphest/constants/status',
Added subscriber view to Maniphest. Summary: People want to see all the tasks they have subscribed to in one view. A new table was added for this to make queries faster. Test Plan: Tested that the view was initially empty. After running the reindex_maniphest.php script, I saw the correct tasks there. Added myself as a subscriber to one task and made sure the view was updated. Removed myself as a subscriber from one task and made sure the view was updated again. Reviewed By: epriestley Reviewers: epriestley, jungejason, codeblock CC: aran, rm, epriestley Differential Revision: 603
2011-07-07 19:24:49 +02:00
'ManiphestTaskSubscriber' => 'applications/maniphest/storage/subscriber',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestTaskSummaryView' => 'applications/maniphest/view/tasksummary',
'ManiphestTransaction' => 'applications/maniphest/storage/transaction',
'ManiphestTransactionDetailView' => 'applications/maniphest/view/transactiondetail',
'ManiphestTransactionEditor' => 'applications/maniphest/editor/transaction',
'ManiphestTransactionListView' => 'applications/maniphest/view/transactionlist',
Add comment previews to Maniphest Summary: Moves shared code from Differential and Maniphest comment previews into PhabricatorShapedRequest, and then implements Maniphest previews. This doesn't implement comment drafts, I'll follow up with that but it requires this and is completely separable. This also always shows the preview as "commented" rather than previewing the actual transaction. I'll follow up with that but I think it will require a little factoring and this is useful even without transaction details. I need to tweak the styling a bit too. Test Plan: Typed text in Maniphest and Differential. Toggled Differential action. Made comments. Reviewed By: rm Reviewers: rm, tuomaspelkonen, jungejason, aran CC: aran, rm Differential Revision: 258
2011-05-10 17:29:28 +02:00
'ManiphestTransactionPreviewController' => 'applications/maniphest/controller/transactionpreview',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestTransactionSaveController' => 'applications/maniphest/controller/transactionsave',
'ManiphestTransactionType' => 'applications/maniphest/constants/transactiontype',
Slightly improve Maniphest documentation.
2011-07-04 22:04:22 +02:00
'ManiphestView' => 'applications/maniphest/view/base',
I guess this can support JS too.
2011-01-30 01:16:09 +01:00
'Phabricator404Controller' => 'applications/base/controller/404',
Add Basic Auditing Functionalities Summary: add basic auditing functionalities. For the related commits for a package, we detect the following conditions which might be suspicious to the owners of the package: * no revision specified * revision not found * author not match * reviewedby not match * owners not involved * commit author not recognized The owners of the package can change the status of the audit entries by accepting it or specify concern. The owner can turn on/off the auditing for a package. Test Plan: * verified that non-owner cannot see the details of the audit and cannot modify it * verified that all the audit reasons can be detected * tested dropdown filtering and package search * verified really normal change not detected * verified accept/concern a commit * tested enable/disable a package for auditing * verified one audit applies to all <commit, packages> to the packages the auditor owns * verified that re-parsing a commit won't have effect if there exists a relationship for <commit, package> already Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, benmathews, btrahan, mpodobnik, prithvi, TomL, epriestley Differential Revision: 1242
2011-12-18 00:52:54 +01:00
'PhabricatorAuditActionConstants' => 'applications/audit/constants/action',
'PhabricatorAuditComment' => 'applications/audit/storage/auditcomment',
'PhabricatorAuditController' => 'applications/audit/controller/base',
'PhabricatorAuditDAO' => 'applications/audit/storage/base',
'PhabricatorAuditEditController' => 'applications/audit/controller/edit',
'PhabricatorAuditStatusConstants' => 'applications/audit/constants/status',
Basic Facebook OAuth implementation.
2011-01-31 06:28:45 +01:00
'PhabricatorAuthController' => 'applications/auth/controller/base',
Build a basic calendar view Summary: This is a very small step toward building a Status and possibly an Oncall tool. Build a calendar view which renders months. Much of my hesitance to bang these tools out is that dealing with dates/calendaring is basically horrible, so I'm trying to ease into it. This calendar is locale-aware and all that jazz. Test Plan: - See: https://secure.phabricator.com/file/view/PHID-FILE-c07a9c663a7d040d2529/ - Verified that months have the right number of days, today is the right day of the week, months begin on the day after previous months end on, etc. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran Commenters: cwbeck, jungejason CC: blair, aran, epriestley, cwbeck, jungejason Differential Revision: 791
2011-08-08 03:26:31 +02:00
'PhabricatorCalendarBrowseController' => 'applications/calendar/controller/browse',
'PhabricatorCalendarController' => 'applications/calendar/controller/base',
Conduit server-side basics.
2011-01-24 18:00:29 +01:00
'PhabricatorConduitAPIController' => 'applications/conduit/controller/api',
"arc install-certificate", server-side components Summary: Provides a new workflow for making it non-horrible to install certificates. Basically you run "arc install-certificate" and then copy/paste a short token off a webpage and it does the ~/.arcrc edits for you. Test Plan: Installed certificates, used bad tokens, hit rate limiting. Reviewed By: aran Reviewers: aran, jungejason, tuomaspelkonen CC: aran Differential Revision: 460
2011-06-14 21:17:14 +02:00
'PhabricatorConduitCertificateToken' => 'applications/conduit/storage/token',
Conduit server-side basics.
2011-01-24 18:00:29 +01:00
'PhabricatorConduitConnectionLog' => 'applications/conduit/storage/connectionlog',
'PhabricatorConduitConsoleController' => 'applications/conduit/controller/console',
'PhabricatorConduitController' => 'applications/conduit/controller/base',
'PhabricatorConduitDAO' => 'applications/conduit/storage/base',
'PhabricatorConduitLogController' => 'applications/conduit/controller/log',
'PhabricatorConduitMethodCallLog' => 'applications/conduit/storage/methodcalllog',
"arc install-certificate", server-side components Summary: Provides a new workflow for making it non-horrible to install certificates. Basically you run "arc install-certificate" and then copy/paste a short token off a webpage and it does the ~/.arcrc edits for you. Test Plan: Installed certificates, used bad tokens, hit rate limiting. Reviewed By: aran Reviewers: aran, jungejason, tuomaspelkonen CC: aran Differential Revision: 460
2011-06-14 21:17:14 +02:00
'PhabricatorConduitTokenController' => 'applications/conduit/controller/token',
Track content sources (email, web, conduit, mobile) for replies Summary: When an object is updated, record the content source for the update. This mostly isn't terribly useful but one concrete thing I want to do with it is let admins audit via-email replies more easily since there are a bunch of options which let you do hyjinx if you intentionally configure them insecurely. I think having a little more auditability around this feature is generally good. At some point I'm going to turn this into a link admins can click to see details. It also allows us to see how frequently different mechanisms are used, and lets you see if someone is at their desk or on a mobile or whatever, at least indirectly. The "tablet" and "mobile" sources are currently unused but I figured I'd throw them in anyway. SMS support should definitely happen at some point. Not 100% sure about the design for this, I might change it to plain text at some point. Test Plan: Updated objects and saw update sources rendered. Reviewers: jungejason, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, epriestley, jungejason Differential Revision: 844
2011-08-22 19:25:45 +02:00
'PhabricatorContentSource' => 'applications/metamta/contentsource/source',
'PhabricatorContentSourceView' => 'applications/metamta/contentsource/view',
More phabricator organizational stuff.
2011-01-23 02:48:55 +01:00
'PhabricatorController' => 'applications/base/controller/base',
Countdown Summary: Addon that allows you to create a live countdown page to some event. Here is the ticket that this code is based on https://secure.phabricator.com/T36 Test Plan: Tested by manually setting dates in the timer.js file and checking if they made sense. I'm not sure if it works across different timezones though. Reviewers: epriestley CC: Differential Revision: 436
2011-06-13 01:06:17 +02:00
'PhabricatorCountdownController' => 'applications/countdown/controller/base',
'PhabricatorCountdownDAO' => 'applications/countdown/storage/base',
'PhabricatorCountdownDeleteController' => 'applications/countdown/controller/delete',
'PhabricatorCountdownEditController' => 'applications/countdown/controller/edit',
'PhabricatorCountdownListController' => 'applications/countdown/controller/list',
'PhabricatorCountdownViewController' => 'applications/countdown/controller/view',
Rough cut of repository tracking Summary: Basic scaffolding for repository tracking, plus daemon infrastructure (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk). Test Plan: parsed Javelin git commit history via daemon Reviewers: CC:
2011-03-07 07:29:22 +01:00
'PhabricatorDaemon' => 'infrastructure/daemon/base',
Improve web tools for viewing daemons Summary: - Provides an "all daemons" view to look at more than the first 15 daemons. - Provides a "combined log" view with a large page size, to quickly look at the log across all the daemons, making it easier to find issues when you have a bunch of the same daemon and only one is having issues. - When viewing the web console on the same host as a daemon, show whether it's running or not. Test Plan: Clicked the various daemon log interfaces. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 215
2011-05-03 02:05:22 +02:00
'PhabricatorDaemonCombinedLogController' => 'applications/daemon/controller/combined',
Rough cut of Workers Summary: workers do work, provided I have written them correctly. perhaps it is so. Test Plan: Reviewers: CC:
2011-03-10 22:48:29 +01:00
'PhabricatorDaemonConsoleController' => 'applications/daemon/controller/console',
More phd stuff.
2011-03-14 23:43:56 +01:00
'PhabricatorDaemonControl' => 'infrastructure/daemon/control',
Rough cut of Workers Summary: workers do work, provided I have written them correctly. perhaps it is so. Test Plan: Reviewers: CC:
2011-03-10 22:48:29 +01:00
'PhabricatorDaemonController' => 'applications/daemon/controller/base',
Diffusion/phd/console improvements.
2011-03-15 21:38:14 +01:00
'PhabricatorDaemonDAO' => 'infrastructure/daemon/storage/base',
'PhabricatorDaemonLog' => 'infrastructure/daemon/storage/log',
'PhabricatorDaemonLogEvent' => 'infrastructure/daemon/storage/event',
Improve web tools for viewing daemons Summary: - Provides an "all daemons" view to look at more than the first 15 daemons. - Provides a "combined log" view with a large page size, to quickly look at the log across all the daemons, making it easier to find issues when you have a bunch of the same daemon and only one is having issues. - When viewing the web console on the same host as a daemon, show whether it's running or not. Test Plan: Clicked the various daemon log interfaces. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 215
2011-05-03 02:05:22 +02:00
'PhabricatorDaemonLogEventsView' => 'applications/daemon/view/daemonlogevents',
'PhabricatorDaemonLogListController' => 'applications/daemon/controller/loglist',
'PhabricatorDaemonLogListView' => 'applications/daemon/view/daemonloglist',
Diffusion/phd/console improvements.
2011-03-15 21:38:14 +01:00
'PhabricatorDaemonLogViewController' => 'applications/daemon/controller/logview',
More phd stuff.
2011-03-14 23:43:56 +01:00
'PhabricatorDaemonReference' => 'infrastructure/daemon/control/reference',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorDaemonTimelineConsoleController' => 'applications/daemon/controller/timeline',
'PhabricatorDaemonTimelineEventController' => 'applications/daemon/controller/timelineevent',
Allow Phabricator storage engines to be extended and configured Summary: See T344. Currently, there's a hard-coded 12MB filesize limit and some awkward interactions with MySQL's max_allowed_packet. Make this system generally more robust: - Move the upload limit to configuration. - Add setup steps which reconcile max_allowed_packet vs MySQL file storage limits. - Add a layer of indirection between uploading files and storage engines. - Allow the definition of new storage engines. - Define a local disk storage engine. - Add a "storage engine selector" class which manages choosing which storage engines to put files in. - Document storage engines. - Document file storage classes. Test Plan: Setup mode: - Disabled MySQL storage engine, misconfigured it, configured it correctly. - Disabled file storage engine, set it to something invalid, set it to something valid. - Verified max_allowed_packet is read correctly. Application mode: - Configured local file storage. - Uploaded large and small files. - Verified larger files were written to local storage. - Verified smaller files were written to MySQL blob storage. Documentation: - Read documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 695
2011-07-20 07:48:38 +02:00
'PhabricatorDefaultFileStorageEngineSelector' => 'applications/files/engineselector/default',
Provide an indirection layer between documents and the search engine Summary: In preparation for adding another search engine (see T355): - Rename "executor" to "engine". - Move all engine-specific operations into the engine. Specifically, this means that indexing moves out of the document store and into the engine (it was sort of silly where it was before). - Split choice of an engine into an overridable "selector" class, a base API, and a concrete MySQL implementation (just like storage engine selection). - Make all callers go through the indirection layer. The default selector just unconditionally selects the MySQL engine, but now (with D786) I can build an Elastic Search engine and you guys can build a multi-target engine if you want and I don't get there fast enough. Test Plan: - Created a new document (task). - Searched for and found it. - Viewed index reconstruction. Reviewed By: jungejason Reviewers: jungejason, amckinley, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 788
2011-08-08 00:14:23 +02:00
'PhabricatorDefaultSearchEngineSelector' => 'applications/search/selector/default',
Show change diffs in Phriction Summary: This is really rough and needs work (particularly, there's some diff code I really need to refactor since I sort-of-copy-pasted it) but basically functional. Show text changes between diffs and allow users to revert to earlier versions. Differential's line-oriented diff style isn't ideal for large blocks of text but I'm betting this is probably good enough in most cases. We can see how bad it is in practice and then fix it if needbe. I added a bunch of support for "description" but didn't add the feature in this diff, I'll either follow up or task it out since it should be a pretty straightforward change. Test Plan: Looked at history for several Phriction documents, clicked "previous change" / "next change", clicked revert buttons. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen CC: aran, hsb, epriestley Differential Revision: 687
2011-07-17 20:06:02 +02:00
'PhabricatorDifferenceEngine' => 'infrastructure/diff/engine',
More phabricator organizational stuff.
2011-01-23 02:48:55 +01:00
'PhabricatorDirectoryCategory' => 'applications/directory/storage/category',
'PhabricatorDirectoryCategoryDeleteController' => 'applications/directory/controller/categorydelete',
'PhabricatorDirectoryCategoryEditController' => 'applications/directory/controller/categoryedit',
'PhabricatorDirectoryCategoryListController' => 'applications/directory/controller/categorylist',
'PhabricatorDirectoryController' => 'applications/directory/controller/base',
'PhabricatorDirectoryDAO' => 'applications/directory/storage/base',
'PhabricatorDirectoryItem' => 'applications/directory/storage/item',
'PhabricatorDirectoryItemDeleteController' => 'applications/directory/controller/itemdelete',
'PhabricatorDirectoryItemEditController' => 'applications/directory/controller/itemedit',
'PhabricatorDirectoryItemListController' => 'applications/directory/controller/itemlist',
'PhabricatorDirectoryMainController' => 'applications/directory/controller/main',
Admin and disabled flags for users Summary: Provide an "isAdmin" flag for users, to designate administrative users. Restore the account editing interface and allow it to set role flags and reset passwords. Provide an "isDisabled" flag for users and shut down all system access for them. Test Plan: Created "admin" and "disabled" users. Did administrative things with the admin user. Tried to do stuff with the disabled user and was rebuffed. Tried to access administrative interfaces with a normal non-admin user and was denied. Reviewed By: aran Reviewers: tuomaspelkonen, jungejason, aran CC: ccheever, aran Differential Revision: 278
2011-05-12 19:06:54 +02:00
'PhabricatorDisabledUserController' => 'applications/auth/controller/disabled',
Revision comment drafts.
2011-02-06 01:57:21 +01:00
'PhabricatorDraft' => 'applications/draft/storage/draft',
'PhabricatorDraftDAO' => 'applications/draft/storage/base',
PhabricatorEnv 'infratructure' -> 'infrastructure' (rofl) Recaptcha Email Login / Forgot Password Password Reset
2011-01-31 20:55:26 +01:00
'PhabricatorEmailLoginController' => 'applications/auth/controller/email',
'PhabricatorEmailTokenController' => 'applications/auth/controller/emailtoken',
'PhabricatorEnv' => 'infrastructure/env',
Lock down accepted next URI values for redirect after login Summary: I locked this down a little bit recently, but make double-extra-super-sure that we aren't sending the user anywhere suspicious or open-redirecty. This also locks down protocol-relative URIs (//evil.com/path) although I don't think any browsers do bad stuff with them in this context, and header injection URIs (although I don't think any of the modern PHP runtimes are vulnerable). Test Plan: - Ran tests. - Hit redirect page with valid and invalid next URIs; was punted to / for invalid ones and to the right place for valid ones. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: arice, aran, epriestley, btrahan Differential Revision: https://secure.phabricator.com/D1369
2012-01-12 01:07:36 +01:00
'PhabricatorEnvTestCase' => 'infrastructure/env/__tests__',
Build an event dispatch mechanism into Phabricator Summary: This is an attempt to satisfy a lot of the one-off requests a little more generally, by providing a relatively generic piece of event architecture. Allow the registation of event listeners which can react to various application events (currently, task editing). I'll doc this a bit better but I wanted to see if anyone had massive objections to doing this or the broad approach. The specific problem I want to address is that one client wants to do a bunch of routing for tasks via email, so it's either build a hook, or have them override most of ManiphestReplyHandler, or something slightly more general like this. Test Plan: Wrote a silly listener that adds "Quack!" to a task every time it is edited and edited some tasks. I was justly rewarded. Reviewers: nh, jungejason, tuomaspelkonen, aran Reviewed By: aran CC: aran, epriestley Differential Revision: 881
2011-08-31 22:25:13 +02:00
'PhabricatorEvent' => 'infrastructure/events/event',
'PhabricatorEventEngine' => 'infrastructure/events/engine',
'PhabricatorEventType' => 'infrastructure/events/constant/type',
Share feed building code Summary: I pretty much copy/pasted this code; rather than do that again now that I want to add feeds to projects, share the code. This "Builder" is a little weird -- I don't want to call it a "View" because it does data access. "Builder" seemed okay. We don't really have much code that does this sort of thing right now, elsewhere. Test Plan: - Viewed public feed. - Viewed private feed. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T681 Differential Revision: 1233
2011-12-18 00:50:37 +01:00
'PhabricatorFeedBuilder' => 'applications/feed/builder/feed',
Publish Differential stories into feed Summary: Basic hookup for Differential -> Feed. Also introduces "one-line" stories for less-important stuff. Test Plan: Interacted with some revisions, got feed stories out of it. Reviewed By: jungejason Reviewers: jungejason, aran, tuomaspelkonen, codeblock CC: aran, jungejason Differential Revision: 632
2011-07-10 00:44:49 +02:00
'PhabricatorFeedConstants' => 'applications/feed/constants/base',
Build basic infrastructure for an activity feed Summary: This defines an extremely basic version of an activity feed, like Facebook's news feed. It doesn't do much of interest yet. Test Plan: Published some feed stories: https://secure.phabricator.com/file/view/PHID-FILE-5061aa72105bbdc05b21/ Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran Commenters: codeblock, jungejason CC: aran, epriestley, codeblock, tuomaspelkonen, jungejason Differential Revision: 593
2011-07-05 17:35:18 +02:00
'PhabricatorFeedController' => 'applications/feed/controller/base',
'PhabricatorFeedDAO' => 'applications/feed/storage/base',
Provide a public view of feed Summary: Depends on D628. Provides a config option so you can set up a public feed, which you can iframe. This needs some work but sort of works. Test Plan: Loaded the public feed as a logged-out user. Reviewed By: codeblock Reviewers: jungejason, tuomaspelkonen, aran, codeblock CC: aran, codeblock Differential Revision: 635
2011-07-10 03:03:59 +02:00
'PhabricatorFeedPublicStreamController' => 'applications/feed/controller/publicstream',
Build basic infrastructure for an activity feed Summary: This defines an extremely basic version of an activity feed, like Facebook's news feed. It doesn't do much of interest yet. Test Plan: Published some feed stories: https://secure.phabricator.com/file/view/PHID-FILE-5061aa72105bbdc05b21/ Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran Commenters: codeblock, jungejason CC: aran, epriestley, codeblock, tuomaspelkonen, jungejason Differential Revision: 593
2011-07-05 17:35:18 +02:00
'PhabricatorFeedQuery' => 'applications/feed/query',
'PhabricatorFeedStory' => 'applications/feed/story/base',
'PhabricatorFeedStoryData' => 'applications/feed/storage/story',
Publish Differential stories into feed Summary: Basic hookup for Differential -> Feed. Also introduces "one-line" stories for less-important stuff. Test Plan: Interacted with some revisions, got feed stories out of it. Reviewed By: jungejason Reviewers: jungejason, aran, tuomaspelkonen, codeblock CC: aran, jungejason Differential Revision: 632
2011-07-10 00:44:49 +02:00
'PhabricatorFeedStoryDifferential' => 'applications/feed/story/differential',
Publish feed stories from Maniphest Summary: I didn't get around to this earlier; add Feed/Maniphest integration. This is partly motivated by wanting Projects to not be terrible. Pretty straightforward. Test Plan: - Created, updated, reassigned and closed a task. - Verified feed stories render reasonably. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T681 Differential Revision: 1232
2011-12-17 22:27:11 +01:00
'PhabricatorFeedStoryManiphest' => 'applications/feed/story/maniphest',
Publish Phriction edits to feed Summary: Basic integration between Phriction and feed. Test Plan: Created and edited some documents, they published to feed. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, hsb Differential Revision: 653
2011-07-12 16:23:04 +02:00
'PhabricatorFeedStoryPhriction' => 'applications/feed/story/phriction',
Build basic infrastructure for an activity feed Summary: This defines an extremely basic version of an activity feed, like Facebook's news feed. It doesn't do much of interest yet. Test Plan: Published some feed stories: https://secure.phabricator.com/file/view/PHID-FILE-5061aa72105bbdc05b21/ Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran Commenters: codeblock, jungejason CC: aran, epriestley, codeblock, tuomaspelkonen, jungejason Differential Revision: 593
2011-07-05 17:35:18 +02:00
'PhabricatorFeedStoryPublisher' => 'applications/feed/publisher',
'PhabricatorFeedStoryReference' => 'applications/feed/storage/storyreference',
Improve feed stories with "style", and build basic status update stories. Summary: Straightfoward iteration on feed. Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-d07077119dc834e76618/ Reviewed By: codeblock Reviewers: jungejason, aran, tuomaspelkonen, codeblock CC: aran, codeblock, epriestley Differential Revision: 631
2011-07-09 22:28:09 +02:00
'PhabricatorFeedStoryStatus' => 'applications/feed/story/status',
Publish Differential stories into feed Summary: Basic hookup for Differential -> Feed. Also introduces "one-line" stories for less-important stuff. Test Plan: Interacted with some revisions, got feed stories out of it. Reviewed By: jungejason Reviewers: jungejason, aran, tuomaspelkonen, codeblock CC: aran, jungejason Differential Revision: 632
2011-07-10 00:44:49 +02:00
'PhabricatorFeedStoryTypeConstants' => 'applications/feed/constants/story',
Build basic infrastructure for an activity feed Summary: This defines an extremely basic version of an activity feed, like Facebook's news feed. It doesn't do much of interest yet. Test Plan: Published some feed stories: https://secure.phabricator.com/file/view/PHID-FILE-5061aa72105bbdc05b21/ Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran Commenters: codeblock, jungejason CC: aran, epriestley, codeblock, tuomaspelkonen, jungejason Differential Revision: 593
2011-07-05 17:35:18 +02:00
'PhabricatorFeedStoryUnknown' => 'applications/feed/story/unknown',
'PhabricatorFeedStoryView' => 'applications/feed/view/story',
'PhabricatorFeedStreamController' => 'applications/feed/controller/stream',
'PhabricatorFeedView' => 'applications/feed/view/base',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'PhabricatorFile' => 'applications/files/storage/file',
Provide a setting which forces all file views to be served from an alternate domain Summary: See D758, D759. - Provide a strongly recommended setting which permits configuration of an alternate domain. - Lock cookies down better: set them on the exact domain, and use SSL-only if the configuration is HTTPS. - Prevent Phabriator from setting cookies on other domains. This assumes D759 will land, it is not effective without that change. Test Plan: - Attempted to login from a different domain and was rejected. - Logged out, logged back in normally. - Put install in setup mode and verified it revealed a warning. - Configured an alterate domain. - Tried to view an image with an old URI, got a 400. - Went to /files/ and verified links rendered to the alternate domain. - Viewed an alternate domain file. - Tried to view an alternate domain file without the secret key, got a 404. Reviewers: andrewjcg, erling, aran, tuomaspelkonen, jungejason, codeblock CC: aran Differential Revision: 760
2011-08-02 07:24:00 +02:00
'PhabricatorFileAltViewController' => 'applications/files/controller/altview',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'PhabricatorFileController' => 'applications/files/controller/base',
'PhabricatorFileDAO' => 'applications/files/storage/base',
Allow files to be deleted Summary: A couple of people mentioned that they've had users accidentally upload sensitive files. Allow files to be deleted. (At some point it might be nice to keep the file handle around and log who deleted it, but this addresses the immediate problem without needing too much work.) Test Plan: Deleted some files. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T780 Differential Revision: https://secure.phabricator.com/D1423
2012-01-16 22:26:44 +01:00
'PhabricatorFileDeleteController' => 'applications/files/controller/delete',
Drag-and-drop upload for Maniphest Summary: This needs a bunch of UI polish (critically, it's totally undiscoverable) but it basically works correctly. I'll clean it up in some followups. Test Plan: Uploaded some files via drag-and-drop, made comments, etc. Reviewed By: aran Reviewers: tomo, aran, jungejason, tuomaspelkonen CC: anjali, aran Differential Revision: 332
2011-05-22 20:55:10 +02:00
'PhabricatorFileDropUploadController' => 'applications/files/controller/dropupload',
Image macros for Phabricator! Summary: Added long waited image macro support for differential and others. Test Plan: Tried a couple of different macros and made sure they appear nicely in the comment preview. Made sure that the normal comments are shown correctly. Reviewed By: epriestley Reviewers: epriestley CC: jungejason, tuomaspelkonen, epriestley Differential Revision: 129
2011-04-14 00:15:48 +02:00
'PhabricatorFileImageMacro' => 'applications/files/storage/imagemacro',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'PhabricatorFileListController' => 'applications/files/controller/list',
Web editor/browser for image macros Summary: Restores the old "pokedex" feature and allows easy definition of new macros. Only good can come of this! Critical feature!! Test Plan: nyancat Reviewed By: tuomaspelkonen Reviewers: aran, bh, tomo, jungejason, tuomaspelkonen CC: aran, tuomaspelkonen Differential Revision: 220
2011-05-03 19:45:45 +02:00
'PhabricatorFileMacroDeleteController' => 'applications/files/controller/macrodelete',
'PhabricatorFileMacroEditController' => 'applications/files/controller/macroedit',
'PhabricatorFileMacroListController' => 'applications/files/controller/macrolist',
Restore image proxying to Remarkup Summary: Previously, Remarkup allowed you to paste in an image URI and get an inline image. However, it did this by hotlinking the image which isn't so hot in an open source product. Restore this feature, but use image proxying instead. The existing image macro code does most of the work. There is a mild security risk depending on the network setup so I've left this default-disabled and made a note about it. It should be safe to enable for Facebook. Test Plan: Pasted in image and non-image links, got reasonable behavior. Verified proxying appears to work. Verified that file:// shenanigans produce 400. Reviewed By: tuomaspelkonen Reviewers: aran, jungejason, tuomaspelkonen Commenters: cpiro CC: aran, cpiro, tuomaspelkonen Differential Revision: 214
2011-05-02 23:20:24 +02:00
'PhabricatorFileProxyController' => 'applications/files/controller/proxy',
'PhabricatorFileProxyImage' => 'applications/files/storage/proxyimage',
Files - kill tabs Summary: kill tabs for Files application. Technique is the "filter list" on the left hand side, with separation for "Files" versus "Image Macros". UI quirks include: - the page title does not change for the 3 files filters while it does change for each of the two image macro filters. - standalone "file" pages do not have the filter view - you can visit /file/upload/ standalone and it doesn't have the pretty filter list on it Please do give direction on these quirks if you like. :) This change also neuters the ?author= functionality for files. The code is written such that it can easily be brought back. Test Plan: clicked around on the filters, liked what I saw. uploaded files fancy-like and basic-like and it worked! made image macros and it worked! Reviewers: epriestley Reviewed By: epriestley CC: aran, btrahan, epriestley Maniphest Tasks: T631 Differential Revision: 1219
2011-12-15 07:37:23 +01:00
'PhabricatorFileSideNavView' => 'applications/files/view/sidenav',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'PhabricatorFileStorageBlob' => 'applications/files/storage/storageblob',
Allow Phabricator storage engines to be extended and configured Summary: See T344. Currently, there's a hard-coded 12MB filesize limit and some awkward interactions with MySQL's max_allowed_packet. Make this system generally more robust: - Move the upload limit to configuration. - Add setup steps which reconcile max_allowed_packet vs MySQL file storage limits. - Add a layer of indirection between uploading files and storage engines. - Allow the definition of new storage engines. - Define a local disk storage engine. - Add a "storage engine selector" class which manages choosing which storage engines to put files in. - Document storage engines. - Document file storage classes. Test Plan: Setup mode: - Disabled MySQL storage engine, misconfigured it, configured it correctly. - Disabled file storage engine, set it to something invalid, set it to something valid. - Verified max_allowed_packet is read correctly. Application mode: - Configured local file storage. - Uploaded large and small files. - Verified larger files were written to local storage. - Verified smaller files were written to MySQL blob storage. Documentation: - Read documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 695
2011-07-20 07:48:38 +02:00
'PhabricatorFileStorageEngine' => 'applications/files/engine/base',
'PhabricatorFileStorageEngineSelector' => 'applications/files/engineselector/base',
Basic image thumbnailing Summary: This is still very rough but provides basic support for generating image thumbnails. I need to separate stuff out a bit but I'm going to integrate into Maniphest before I hit the profile stuff so this seems like a reasonable starting point. Test Plan: Generated some image thumbnails in various sizes. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 333
2011-05-22 23:40:51 +02:00
'PhabricatorFileTransformController' => 'applications/files/controller/transform',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'PhabricatorFileUploadController' => 'applications/files/controller/upload',
Improve error messages when hitting PHP file upload issues Summary: See T429. When you hit certain errors, you get less-than-helpful messages like "upload error 3". Instead, produce human-readable errors. Test Plan: Simulated errors, verified user receives decent error messages. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran, startupguy CC: aran Differential Revision: 816
2011-08-16 21:37:50 +02:00
'PhabricatorFileUploadException' => 'applications/files/exception/upload',
Files - kill tabs Summary: kill tabs for Files application. Technique is the "filter list" on the left hand side, with separation for "Files" versus "Image Macros". UI quirks include: - the page title does not change for the 3 files filters while it does change for each of the two image macro filters. - standalone "file" pages do not have the filter view - you can visit /file/upload/ standalone and it doesn't have the pretty filter list on it Please do give direction on these quirks if you like. :) This change also neuters the ?author= functionality for files. The code is written such that it can easily be brought back. Test Plan: clicked around on the filters, liked what I saw. uploaded files fancy-like and basic-like and it worked! made image macros and it worked! Reviewers: epriestley Reviewed By: epriestley CC: aran, btrahan, epriestley Maniphest Tasks: T631 Differential Revision: 1219
2011-12-15 07:37:23 +01:00
'PhabricatorFileUploadView' => 'applications/files/view/upload',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'PhabricatorFileViewController' => 'applications/files/controller/view',
Add a garbage collector daemon Summary: Phabricator generates a bunch of data that we don't need to keep around forever, add a GC daemon to get rid of it with some basic configuration options. This needs a couple more diffs to get some of the details but I think this is a reasonable start. I also fixed a couple of UI things related to this, e.g. the daemon logs page going crazy when a daemon gets stuck in a loop and dumps tons of data to stdout. Test Plan: - Ran gc daemon in 'phd debug' mode and saw it delete stuff, then sleep once it had cleaned everything up. - Mucked around with TTLs and verified they work correctly. - Viewed gc'd transcripts in the web interface and made sure they displayed okay. - Viewed daemon logs before/after garbage collection. - Running some run-at / run-for tests now, I'll update if the daemon doesn't shut off in ~10-15 minutes. :P Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran CC: aran, tuomaspelkonen, epriestley Differential Revision: 583
2011-07-03 18:47:31 +02:00
'PhabricatorGarbageCollectorDaemon' => 'infrastructure/daemon/garbagecollector',
Rough cut of Workers Summary: workers do work, provided I have written them correctly. perhaps it is so. Test Plan: Reviewers: CC:
2011-03-10 22:48:29 +01:00
'PhabricatorGoodForNothingWorker' => 'infrastructure/daemon/workers/worker/goodfornothing',
Move object-selector closable to being usable. Summary: Test Plan: Reviewers: CC:
2011-02-17 23:32:01 +01:00
'PhabricatorHandleObjectSelectorDataView' => 'applications/phid/handle/view/selector',
Move most remaining sha1() calls to HMAC Summary: - For context, see T547. This is the last (maybe?) in a series of diffs that moves us off raw sha1() calls in order to make it easier to audit the codebase for correct use of hash functions. - This breaks CSRF tokens. Any open forms will generate an error when submitted, so maybe upgrade off-peak. - We now generate HMAC mail keys but accept MAC or HMAC. In a few months, we can remove the MAC version. - The only remaining callsite is Conduit. We can't use HMAC since Arcanist would need to know the key. {T550} provides a better solution to this, anyway. Test Plan: - Verified CSRF tokens generate properly. - Manually changed CSRF to an incorrect value and got an error. - Verified mail generates with a new mail hash. - Verified Phabricator accepts both old and new mail hashes. - Verified Phabricator rejects bad mail hashes. - Checked user log, things look OK. Reviewers: btrahan, jungejason, benmathews Reviewed By: btrahan CC: aran, epriestley, btrahan Maniphest Tasks: T547 Differential Revision: 1237
2011-12-18 20:00:39 +01:00
'PhabricatorHash' => 'infrastructure/util/hash',
Provide basic structure for keyboard shortcuts Summary: Implements a simple infrastructure for keyboard shortcuts, see T184, and a "help" shortcut. There's a lot of room for refinement here but I think it basically works. Each shortcut can also provide a "tooltip" handler which allows it to show help when the alt/option key is held down. Test Plan: Pressed "?" and got help. Pressed "?" in various contexts where it should not activate (modifier keys, text input focused) and didn't get help. Reviewers: aran, tuomaspelkonen, jungejason CC: moskov Differential Revision: 362
2011-05-28 20:36:00 +02:00
'PhabricatorHelpController' => 'applications/help/controller/base',
'PhabricatorHelpKeyboardShortcutController' => 'applications/help/controller/keyboardshortcut',
Very basic IRC Bot Summary: This is sort of a silly/fun project but I think there's some utility. For example, mroch added some handlers to an eggdrop or something similar to look for "D12345" and print out the title/link, which was actually pretty useful. We could also add logging here and subsume the more-or-less unowned Facebook tool that does the same thing, especially since we can get a bunch of good stuff it doesn't support (like search) more or less for free. This is also an easy way to provide some example code for writing Conduit system agents. This is a minimal implementation which creates a bot that connects to a hard-coded server and sits there indefinitely. Next steps: - Add conduit/sysagent support - Write differential/maniphest/diffusion handlers - Move configuration to the web interface (?) and integrate with phd - Write a logging handler? Test Plan: Ran bot with "exec_daemon.php", it connected to the hard-coded server and sat there indefinitely. Reviewed By: aran Reviewers: codeblock, mroch, tuomaspelkonen, aran, jungejason CC: aran, epriestley Differential Revision: 283
2011-05-15 18:29:48 +02:00
'PhabricatorIRCBot' => 'infrastructure/daemon/irc/bot',
Add an example notification handler to the IRC bot Summary: Simple notificaiton handler that reads the difx event timeline and posts notifications to IRC. Test Plan: Ran it in #phabricator. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Differential Revision: https://secure.phabricator.com/D1337
2012-01-06 20:31:00 +01:00
'PhabricatorIRCDifferentialNotificationHandler' => 'infrastructure/daemon/irc/handler/differentialnotification',
Very basic IRC Bot Summary: This is sort of a silly/fun project but I think there's some utility. For example, mroch added some handlers to an eggdrop or something similar to look for "D12345" and print out the title/link, which was actually pretty useful. We could also add logging here and subsume the more-or-less unowned Facebook tool that does the same thing, especially since we can get a bunch of good stuff it doesn't support (like search) more or less for free. This is also an easy way to provide some example code for writing Conduit system agents. This is a minimal implementation which creates a bot that connects to a hard-coded server and sits there indefinitely. Next steps: - Add conduit/sysagent support - Write differential/maniphest/diffusion handlers - Move configuration to the web interface (?) and integrate with phd - Write a logging handler? Test Plan: Ran bot with "exec_daemon.php", it connected to the hard-coded server and sat there indefinitely. Reviewed By: aran Reviewers: codeblock, mroch, tuomaspelkonen, aran, jungejason CC: aran, epriestley Differential Revision: 283
2011-05-15 18:29:48 +02:00
'PhabricatorIRCHandler' => 'infrastructure/daemon/irc/handler/base',
'PhabricatorIRCMessage' => 'infrastructure/daemon/irc/message',
Add an "IRC Object Name" handler for D12345 Summary: I need to add some more conduit methods / info to make this at all useful but here's some basics. Test Plan: Hung out in #phabot-test Reviewed By: mroch Reviewers: mroch, codeblock, aran, jungejason, tuomaspelkonen CC: aran, mroch, epriestley Differential Revision: 300
2011-05-17 23:40:25 +02:00
'PhabricatorIRCObjectNameHandler' => 'infrastructure/daemon/irc/handler/objectname',
Very basic IRC Bot Summary: This is sort of a silly/fun project but I think there's some utility. For example, mroch added some handlers to an eggdrop or something similar to look for "D12345" and print out the title/link, which was actually pretty useful. We could also add logging here and subsume the more-or-less unowned Facebook tool that does the same thing, especially since we can get a bunch of good stuff it doesn't support (like search) more or less for free. This is also an easy way to provide some example code for writing Conduit system agents. This is a minimal implementation which creates a bot that connects to a hard-coded server and sits there indefinitely. Next steps: - Add conduit/sysagent support - Write differential/maniphest/diffusion handlers - Move configuration to the web interface (?) and integrate with phd - Write a logging handler? Test Plan: Ran bot with "exec_daemon.php", it connected to the hard-coded server and sat there indefinitely. Reviewed By: aran Reviewers: codeblock, mroch, tuomaspelkonen, aran, jungejason CC: aran, epriestley Differential Revision: 283
2011-05-15 18:29:48 +02:00
'PhabricatorIRCProtocolHandler' => 'infrastructure/daemon/irc/handler/protocol',
Allow affiliations to carry project ownership information; transform profile images correctly Summary: This is sort of doing two things at once: - Add an "isOwner" flag to Project Affiliation to lay the groundwork for T237. - Rename the "QuickCreate" workflow to "Create" and funnel all creation through it. - Reorganize the image transformation stuff and use it to correctly crop/resize uploaded images. Test Plan: Created and edited projects and affailiations. Uploaded project, user, and profile photos. Verified existing thumbnailing in Maniphest still works properly. Reviewed By: cadamo Reviewers: cadamo, aran, jungejason, tuomaspelkonen CC: aran, epriestley, cadamo Differential Revision: 529
2011-06-26 17:37:47 +02:00
'PhabricatorImageTransformer' => 'applications/files/transform',
Add test to check all symbols can be loaded Summary: make sure all symboles can be loaded to avoid issues like missing methods in descendants of abstract base class. Test Plan: ran it and verified it passes; remove a method in a descendant class and verified that the test failed. Reviewers: epriestley, nh Reviewed By: nh CC: aran, nh, jungejason Differential Revision: 1023
2011-10-20 03:26:21 +02:00
'PhabricatorInfrastructureTestCase' => 'infrastructure/__tests__',
Bring Javelin into Phabricator via git submodule, not copy-and-paste Summary: Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt packages. This is not so great. Pull it in as a submodule instead and make all the Phabriator resources declare proper dependency trees. Add Javelin linting. Test Plan: I tried to run through pretty much all the JS functionality on the site. This is still a high-risk change, but I did a pretty thorough test Differential: inline comments, revealing diffs, list tokenizers, comment preview, editing/deleting comments, add review action. Maniphest: list tokenizer, comment actions Herald: rule editing, tokenizers, add/remove rows Reviewed By: tomo Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen CC: aran, tomo, epriestley Differential Revision: 223
2011-05-04 00:11:55 +02:00
'PhabricatorJavelinLinter' => 'infrastructure/lint/linter/javelin',
'PhabricatorLintEngine' => 'infrastructure/lint/engine',
More phabricator organizational stuff.
2011-01-23 02:48:55 +01:00
'PhabricatorLiskDAO' => 'applications/base/storage/lisk',
Allow Phabricator storage engines to be extended and configured Summary: See T344. Currently, there's a hard-coded 12MB filesize limit and some awkward interactions with MySQL's max_allowed_packet. Make this system generally more robust: - Move the upload limit to configuration. - Add setup steps which reconcile max_allowed_packet vs MySQL file storage limits. - Add a layer of indirection between uploading files and storage engines. - Allow the definition of new storage engines. - Define a local disk storage engine. - Add a "storage engine selector" class which manages choosing which storage engines to put files in. - Document storage engines. - Document file storage classes. Test Plan: Setup mode: - Disabled MySQL storage engine, misconfigured it, configured it correctly. - Disabled file storage engine, set it to something invalid, set it to something valid. - Verified max_allowed_packet is read correctly. Application mode: - Configured local file storage. - Uploaded large and small files. - Verified larger files were written to local storage. - Verified smaller files were written to MySQL blob storage. Documentation: - Read documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 695
2011-07-20 07:48:38 +02:00
'PhabricatorLocalDiskFileStorageEngine' => 'applications/files/engine/localdisk',
Improve time localization code Summary: - We throw on a missing date right now, in the DateTime constructor. This can happen in reasonable cases and this is display code, so handle it more gracefully (see T520). - This stuff is a little slow and we sometimes render many hundreds of dates per page. I've been seeing it in profiles on and off. Memoize timezones to improve performance. - Some minor code duplication that would have become less-minor with the constructor change, consolidate the logic. - Add some unit tests and a little documentation. Test Plan: - Ran unit tests. - Profiled 1,000 calls to phabricator_datetime(), cost dropped from ~49ms to ~19ms with addition of memoization. This is still slower than I'd like but I don't think there's an easy way to squeeze it down further. Reviewers: ajtrichards, jungejason, nh, tuomaspelkonen, aran Reviewed By: ajtrichards CC: aran, ajtrichards, epriestley Differential Revision: 966
2011-09-27 18:03:55 +02:00
'PhabricatorLocalTimeTestCase' => 'view/utils/__tests__',
Basic Facebook OAuth implementation.
2011-01-31 06:28:45 +01:00
'PhabricatorLoginController' => 'applications/auth/controller/login',
Validate logins, and simplify email password resets Summary: - There are some recent reports of login issues, see T755 and T754. I'm not really sure what's going on, but this is an attempt at getting some more information. - When we login a user by setting 'phusr' and 'phsid', send them to /login/validate/ to validate that the cookies actually got set. - Do email password resets in two steps: first, log the user in. Redirect them through validate, then give them the option to reset their password. - Don't CSRF logged-out users. It technically sort of works most of the time right now, but is silly. If we need logged-out CSRF we should generate it in some more reliable way. Test Plan: - Logged in with username/password. - Logged in with OAuth. - Logged in with email password reset. - Sent bad values to /login/validate/, got appropriate errors. - Reset password. - Verified next_uri still works. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan, j3kuntz Maniphest Tasks: T754, T755 Differential Revision: https://secure.phabricator.com/D1353
2012-01-10 23:42:07 +01:00
'PhabricatorLoginValidateController' => 'applications/auth/controller/validate',
Basic Facebook OAuth implementation.
2011-01-31 06:28:45 +01:00
'PhabricatorLogoutController' => 'applications/auth/controller/logout',
PHPMailerLite
2011-01-26 18:33:31 +01:00
'PhabricatorMailImplementationAdapter' => 'applications/metamta/adapter/base',
Add basic Amazon SES support. Summary: Test Plan: Reviewers: CC:
2011-02-08 06:08:32 +01:00
'PhabricatorMailImplementationAmazonSESAdapter' => 'applications/metamta/adapter/amazonses',
PHPMailerLite
2011-01-26 18:33:31 +01:00
'PhabricatorMailImplementationPHPMailerLiteAdapter' => 'applications/metamta/adapter/phpmailerlite',
Add support for SendGrid as an outbound mail adapter Summary: SendGrid is a popular mail delivery platform, similar to Amazon SES. Provide support for delivering email via their REST API. Test Plan: Created a SendGrid account, configured my local install to use it, sent some mail, received mail. Reviewers: tuomaspelkonen, jungejason, aran CC: ccheever Differential Revision: 347
2011-05-26 19:00:26 +02:00
'PhabricatorMailImplementationSendGridAdapter' => 'applications/metamta/adapter/sendgrid',
Fix a threading issue with Amazon SES Summary: Amazon SES does not allow us to set a Message-ID header, which means that threads are incorrect in Mail.app (and presumably other applications which respect In-Reply-To and References) because the initial email does not have anything which attaches it to the rest of the thread. To fix this, never rely on Message-ID if the mailer doesn't support Message-ID. (In the Amazon SES case, Amazon generates its own Message-ID which we can't know ahead of time). I additionally used all the Lisk isolation from the other tests to make this testable and wrote tests for it. I also moved the idea of a thread ID lower in the stack and out of DifferentialMail, which should not be responsible for implementation details. NOTE: If you push this, it will cause a one-time break of threading for everyone using Outlook since I've changed the seed for generating Thread-Index. I feel like this is okay to avoid introducing more complexity here. Test Plan: Created and then updated a revision, messages delivered over Amazon SES threaded correctly in Mail.app. Verified headers. Unit tests. Reviewed By: rm Reviewers: aran, tuomaspelkonen, jungejason, rm Commenters: aran CC: aran, rm, epriestley Differential Revision: 195
2011-04-30 20:47:00 +02:00
'PhabricatorMailImplementationTestAdapter' => 'applications/metamta/adapter/test',
Support email multiplexing for private Reply-To addresses Summary: Provide a base PhabricatorMailReplyHandler class which handles the plumbing for multiplexing email if necessary and supporting public and private reply handler addressses. DifferentialReplyHandler now extends it, and a new ManiphestReplyHandler also does. The general approach here is that we have three supported cases: - no reply handler, default config, same as what we're doing now - public reply handler, requires overriding classes but just sets "reply-to" to some address the install generates and still sends only one email - private reply handler, provides a default generation mechanism or you can override it and splits mail apart so we send one to each recipient Test Plan: Sent email from Maniphest and Differential with and without reply-handler-domains set. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley Differential Revision: 254
2011-05-10 01:31:26 +02:00
'PhabricatorMailReplyHandler' => 'applications/metamta/replyhandler/base',
Generalize the markup engine factory Summary: This thing services every app but it lives inside Differential right now. Pull it out, and separate the factory interfaces per-application. This will let us accommodate changes we need to make for Phriction to support wiki linking. Test Plan: Tested remarkup in differential, diffusion, maniphest, people, slowvote. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, hsb Differential Revision: 646
2011-07-12 00:58:32 +02:00
'PhabricatorMarkupEngine' => 'applications/markup/engine',
Allow tweaking of Differential mail by using events Summary: Allow tweaking Differential mail before sending. Test Plan: Wrote a listener renaming Differential attachments and it worked without problems. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley, mareksapota, davidreuss Differential Revision: 1091
2011-11-09 00:15:44 +01:00
'PhabricatorMetaMTAAttachment' => 'applications/metamta/storage/mail',
MetaMTA
2011-01-26 02:40:21 +01:00
'PhabricatorMetaMTAController' => 'applications/metamta/controller/base',
'PhabricatorMetaMTADAO' => 'applications/metamta/storage/base',
Very basic daemon infrastructure, plus MetaMTA daemon. Summary: Amazon SES seems to be working well, except that it takes more than a second to send mail in-process. Kick it out of process. (Between this and the ImplementationAdapter layer, MetaMTA almost makes sense. :/) Test Plan: Ran the daemon and got a flood of unsent test email. Reviewers: CC:
2011-02-10 02:39:55 +01:00
'PhabricatorMetaMTADaemon' => 'applications/metamta/daemon/mta',
Fix reply email parsing for linebreaks in "On <date>, <user> wrote:" quote identifier Summary: Move the parser to a separate class so it can be easily unit tested, add some tests. Properly parse emails with linebreaks in the quote line. Test Plan: Ran unit tests, used mail receiver to reply to an object. Reviewed By: cadamo Reviewers: aran, jungejason, tuomaspelkonen, cadamo CC: aran, cadamo, epriestley Differential Revision: 392
2011-06-01 17:33:14 +02:00
'PhabricatorMetaMTAEmailBodyParser' => 'applications/metamta/parser',
'PhabricatorMetaMTAEmailBodyParserTestCase' => 'applications/metamta/parser/__tests__',
MetaMTA
2011-01-26 02:40:21 +01:00
'PhabricatorMetaMTAListController' => 'applications/metamta/controller/list',
'PhabricatorMetaMTAMail' => 'applications/metamta/storage/mail',
Fix a threading issue with Amazon SES Summary: Amazon SES does not allow us to set a Message-ID header, which means that threads are incorrect in Mail.app (and presumably other applications which respect In-Reply-To and References) because the initial email does not have anything which attaches it to the rest of the thread. To fix this, never rely on Message-ID if the mailer doesn't support Message-ID. (In the Amazon SES case, Amazon generates its own Message-ID which we can't know ahead of time). I additionally used all the Lisk isolation from the other tests to make this testable and wrote tests for it. I also moved the idea of a thread ID lower in the stack and out of DifferentialMail, which should not be responsible for implementation details. NOTE: If you push this, it will cause a one-time break of threading for everyone using Outlook since I've changed the seed for generating Thread-Index. I feel like this is okay to avoid introducing more complexity here. Test Plan: Created and then updated a revision, messages delivered over Amazon SES threaded correctly in Mail.app. Verified headers. Unit tests. Reviewed By: rm Reviewers: aran, tuomaspelkonen, jungejason, rm Commenters: aran CC: aran, rm, epriestley Differential Revision: 195
2011-04-30 20:47:00 +02:00
'PhabricatorMetaMTAMailTestCase' => 'applications/metamta/storage/mail/__tests__',
Mailing lists
2011-01-26 19:40:38 +01:00
'PhabricatorMetaMTAMailingList' => 'applications/metamta/storage/mailinglist',
'PhabricatorMetaMTAMailingListEditController' => 'applications/metamta/controller/mailinglistedit',
'PhabricatorMetaMTAMailingListsController' => 'applications/metamta/controller/mailinglists',
Support email replies in Phabricator Summary: Provides support for per-user x per-object unique reply-to email addresses, plus SMTP integration. This does not actually make Phabricator use these in outbound email. Test Plan: Used test console to validate in-Phabricator routing and handling. Piped emails into the "mail_handler.php" script to validate mail parsing. Configured sendmail and sent mail to Phabricator. Technically I haven't conducted all parts of this test on the same machine since I lost the will to configure more SMTP servers after configuring phabricator.com Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 226
2011-05-05 08:09:42 +02:00
'PhabricatorMetaMTAReceiveController' => 'applications/metamta/controller/receive',
'PhabricatorMetaMTAReceivedListController' => 'applications/metamta/controller/receivedlist',
'PhabricatorMetaMTAReceivedMail' => 'applications/metamta/storage/receivedmail',
MetaMTA
2011-01-26 02:40:21 +01:00
'PhabricatorMetaMTASendController' => 'applications/metamta/controller/send',
Enable SendGrid Parse API as an inbound email handler Summary: Sendmail is seriously difficult to configure; SendGrid is extremely easy. It's also pretty expensive ($80/mo) but there are a bunch of startups that already have plans so it's effectively free for them. Test Plan: Configured SendGrid and sent reply email through it. Reviewed By: aran Reviewers: tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 376
2011-05-30 20:07:05 +02:00
'PhabricatorMetaMTASendGridReceiveController' => 'applications/metamta/controller/sendgridreceive',
MetaMetaView
2011-01-26 18:08:26 +01:00
'PhabricatorMetaMTAViewController' => 'applications/metamta/controller/view',
Allow Phabricator storage engines to be extended and configured Summary: See T344. Currently, there's a hard-coded 12MB filesize limit and some awkward interactions with MySQL's max_allowed_packet. Make this system generally more robust: - Move the upload limit to configuration. - Add setup steps which reconcile max_allowed_packet vs MySQL file storage limits. - Add a layer of indirection between uploading files and storage engines. - Allow the definition of new storage engines. - Define a local disk storage engine. - Add a "storage engine selector" class which manages choosing which storage engines to put files in. - Document storage engines. - Document file storage classes. Test Plan: Setup mode: - Disabled MySQL storage engine, misconfigured it, configured it correctly. - Disabled file storage engine, set it to something invalid, set it to something valid. - Verified max_allowed_packet is read correctly. Application mode: - Configured local file storage. - Uploaded large and small files. - Verified larger files were written to local storage. - Verified smaller files were written to MySQL blob storage. Documentation: - Read documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 695
2011-07-20 07:48:38 +02:00
'PhabricatorMySQLFileStorageEngine' => 'applications/files/engine/mysql',
Modularize oauth.
2011-02-28 04:47:22 +01:00
'PhabricatorOAuthDefaultRegistrationController' => 'applications/auth/controller/oauthregistration/default',
Github OAuth Summary: Test Plan: Reviewers: CC:
2011-02-21 07:47:56 +01:00
'PhabricatorOAuthDiagnosticsController' => 'applications/auth/controller/oauthdiagnostics',
'PhabricatorOAuthFailureView' => 'applications/auth/view/oauthfailure',
'PhabricatorOAuthLoginController' => 'applications/auth/controller/oauth',
'PhabricatorOAuthProvider' => 'applications/auth/oauth/provider/base',
'PhabricatorOAuthProviderFacebook' => 'applications/auth/oauth/provider/facebook',
'PhabricatorOAuthProviderGithub' => 'applications/auth/oauth/provider/github',
Add Google as an OAuth2 provider (BETA) Summary: This is pretty straightforward, except: - We need to request read/write access to the address book to get the account ID (which we MUST have) and real name, email and account name (which we'd like to have). This is way more access than we should need, but there's apparently no "get_loggedin_user_basic_information" type of call in the Google API suite (or, at least, I couldn't find one). - We can't get the profile picture or profile URI since there's no Plus API access and Google users don't have meaningful public pages otherwise. - Google doesn't save the fact that you've authorized the app, so every time you want to login you need to reaffirm that you want to give us silly amounts of access. Phabricator sessions are pretty long-duration though so this shouldn't be a major issue. Test Plan: - Registered, logged out, and logged in with Google. - Registered, logged out, and logged in with Facebook / Github to make sure I didn't break anything. - Linked / unlinked Google accounts. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: aran CC: aran, epriestley, Makinde Differential Revision: 916
2011-09-09 01:37:22 +02:00
'PhabricatorOAuthProviderGoogle' => 'applications/auth/oauth/provider/google',
Modularize oauth.
2011-02-28 04:47:22 +01:00
'PhabricatorOAuthRegistrationController' => 'applications/auth/controller/oauthregistration/base',
OAuth linking/unlinking controls. Summary: Test Plan: Reviewers: CC:
2011-02-22 07:51:34 +01:00
'PhabricatorOAuthUnlinkController' => 'applications/auth/controller/unlink',
Share Revision/Task attaching code Summary: We have this code in two places; split it into an editor class so we can share it. This also fixes some probems with this field not //detaching// tasks properly. Test Plan: - Created a revision with no attached tasks. - Attached it to a task. - Updated it. - Detached it. - Used web UI to attach/detach tasks/revisions. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan, epriestley Differential Revision: 1225
2011-12-16 23:45:10 +01:00
'PhabricatorObjectAttachmentEditor' => 'applications/search/editor/attach',
Basic task dependencies for Maniphest Summary: This allows you to edit dependencies. It is a better patch than it used to be. It depends on D725. - If you create a cycle, it just throws an exception and aborts the workflow. It should not do this. - Tasks which depend on the current task aren't shown in the UI. Need to add a new table for this. - Transaction text says "attached Task" but should probably say "added a dependency on task". Test Plan: Created valid and invalid dependencies between tasks. Created valid and invalid dependencies between revisions. Reviewed By: tuomaspelkonen Reviewers: davidreuss, jungejason, tuomaspelkonen, aran Commenters: codeblock CC: aran, codeblock, tuomaspelkonen, epriestley Differential Revision: 595
2011-07-05 22:18:47 +02:00
'PhabricatorObjectGraph' => 'applications/phid/graph',
PhabricatorObjectHandles
2011-01-26 18:02:09 +01:00
'PhabricatorObjectHandle' => 'applications/phid/handle',
Add object status to Handles Summary: We use ObjectHandles as proxy objects which can refer to any other object in the system. Add the concept of the underlying object's "status" (e.g., open, closed or busy). This allows us to render completed tasks and revisions with strikethrough. In the future, if we implement OOO or something, we could render users with a "busy" status if they're on vacation, etc. Test Plan: Viewed a task with closed revisions and dependencies: https://secure.phabricator.com/file/view/PHID-FILE-6183e81286fa3288d33d/ Reviewed By: codeblock Reviewers: codeblock, hunterbridges, jungejason, tuomaspelkonen, aran CC: aran, codeblock Differential Revision: 772
2011-08-03 15:37:18 +02:00
'PhabricatorObjectHandleConstants' => 'applications/phid/handle/const/base',
PhabricatorObjectHandles
2011-01-26 18:02:09 +01:00
'PhabricatorObjectHandleData' => 'applications/phid/handle/data',
Add object status to Handles Summary: We use ObjectHandles as proxy objects which can refer to any other object in the system. Add the concept of the underlying object's "status" (e.g., open, closed or busy). This allows us to render completed tasks and revisions with strikethrough. In the future, if we implement OOO or something, we could render users with a "busy" status if they're on vacation, etc. Test Plan: Viewed a task with closed revisions and dependencies: https://secure.phabricator.com/file/view/PHID-FILE-6183e81286fa3288d33d/ Reviewed By: codeblock Reviewers: codeblock, hunterbridges, jungejason, tuomaspelkonen, aran CC: aran, codeblock Differential Revision: 772
2011-08-03 15:37:18 +02:00
'PhabricatorObjectHandleStatus' => 'applications/phid/handle/const/status',
Very basic Object Selector interface. Summary: Interface for selecting objects to attach to other objects (e.g., Maniphest tasks to Differential diffs and vice versa). Test Plan: still rough Reviewers: CC:
2011-02-17 07:14:09 +01:00
'PhabricatorObjectSelectorDialog' => 'view/control/objectselector',
Add Related Commits for Owners Summary: For each commit, find the affected packages, and provide a way to search by package. Test Plan: create commits that touch and don't touch two packages, and verify that they display correctly in all the UI pages. Reviewers: epriestley, blair, nh, tuomaspelkonen Reviewed By: epriestley CC: benmathews, aran, epriestley, btrahan, jungejason, mpodobnik, prithvi Maniphest Tasks: T83 Differential Revision: 1208
2011-12-14 09:53:25 +01:00
'PhabricatorOwnerPathQuery' => 'applications/owners/query/path',
'PhabricatorOwnerRelatedListController' => 'applications/owners/controller/relatedlist',
owners
2011-04-03 23:48:36 +02:00
'PhabricatorOwnersController' => 'applications/owners/controller/base',
'PhabricatorOwnersDAO' => 'applications/owners/storage/base',
Some owners write workflows.
2011-04-04 07:03:27 +02:00
'PhabricatorOwnersDeleteController' => 'applications/owners/controller/delete',
owners
2011-04-03 23:48:36 +02:00
'PhabricatorOwnersDetailController' => 'applications/owners/controller/detail',
Some owners write workflows.
2011-04-04 07:03:27 +02:00
'PhabricatorOwnersEditController' => 'applications/owners/controller/edit',
owners
2011-04-03 23:48:36 +02:00
'PhabricatorOwnersListController' => 'applications/owners/controller/list',
'PhabricatorOwnersOwner' => 'applications/owners/storage/owner',
'PhabricatorOwnersPackage' => 'applications/owners/storage/package',
Add Related Commits for Owners Summary: For each commit, find the affected packages, and provide a way to search by package. Test Plan: create commits that touch and don't touch two packages, and verify that they display correctly in all the UI pages. Reviewers: epriestley, blair, nh, tuomaspelkonen Reviewed By: epriestley CC: benmathews, aran, epriestley, btrahan, jungejason, mpodobnik, prithvi Maniphest Tasks: T83 Differential Revision: 1208
2011-12-14 09:53:25 +01:00
'PhabricatorOwnersPackageCommitRelationship' => 'applications/owners/storage/packagecommitrelationship',
owners
2011-04-03 23:48:36 +02:00
'PhabricatorOwnersPath' => 'applications/owners/storage/path',
Introduce PHID generation.
2011-01-23 06:09:13 +01:00
'PhabricatorPHID' => 'applications/phid/storage/phid',
Change hard-coded PHID types to constants. Summary: add a constants module src/applications/phid/constants/PhabricatorPHIDConstants. Test Plan: Execute applications which were using the hard-coded string. Differential Revision: 44 Reviewed By: epriestley Reviewers: epriestley CC: epriestley
2011-03-03 03:58:21 +01:00
'PhabricatorPHIDConstants' => 'applications/phid/constants',
Introduce PHID generation.
2011-01-23 06:09:13 +01:00
'PhabricatorPHIDController' => 'applications/phid/controller/base',
'PhabricatorPHIDDAO' => 'applications/phid/storage/base',
PhabricatorObjectHandles
2011-01-26 18:02:09 +01:00
'PhabricatorPHIDLookupController' => 'applications/phid/controller/lookup',
Pastebin Summary: This is Paste. It needs some work, but epriestley recommended that I just commit something that works, and expand on that later. Specifically, it lacks the ability to view a raw paste right now, and to turn off line numbers, making it hard to copy/paste from for now. It works for showing other people code, however. Test Plan: Pasted stuff, and was able to view it, and see it in the list on /paste/. Put a file extension in the title, and saw that syntax highlighting worked as expected. Reviewers: epriestley CC: Differential Revision: 424
2011-06-10 08:53:53 +02:00
'PhabricatorPaste' => 'applications/paste/storage/paste',
'PhabricatorPasteController' => 'applications/paste/controller/base',
'PhabricatorPasteDAO' => 'applications/paste/storage/base',
"Paste" application tweaks Summary: Tweaks to the paste app: - I realized that unlike all the other apps, it makes more sense for the default view of this one to be "create paste" instead of "list pastes" since when you access the application directly you are most often wanting to share something. Swap list out of the default slot and make edit the default. - Make the textarea bigger (usability). - Allow you to copy an existing paste. - Implement 'raw view'. - Tweak/adjust list view (usability, formatting). - Tweak page titles. Test Plan: Created, copied, and listed pastes. Viewed raw paste. Created an invalid paste. Tried to create a copy of a nonexistant paste. Reviewed By: codeblock Reviewers: codeblock, jungejason, aran, tuomaspelkonen CC: aran, epriestley, codeblock Differential Revision: 456
2011-06-14 04:12:30 +02:00
'PhabricatorPasteListController' => 'applications/paste/controller/list',
Pastebin Summary: This is Paste. It needs some work, but epriestley recommended that I just commit something that works, and expand on that later. Specifically, it lacks the ability to view a raw paste right now, and to turn off line numbers, making it hard to copy/paste from for now. It works for showing other people code, however. Test Plan: Pasted stuff, and was able to view it, and see it in the list on /paste/. Put a file extension in the title, and saw that syntax highlighting worked as expected. Reviewers: epriestley CC: Differential Revision: 424
2011-06-10 08:53:53 +02:00
'PhabricatorPasteViewController' => 'applications/paste/controller/view',
Basic user/account tool.
2011-01-24 03:09:16 +01:00
'PhabricatorPeopleController' => 'applications/people/controller/base',
'PhabricatorPeopleEditController' => 'applications/people/controller/edit',
'PhabricatorPeopleListController' => 'applications/people/controller/list',
Provide an activity log for login and administrative actions Summary: This isn't complete, but I figured I'd ship it for review while it's still smallish. Provide an activity log for high-level system actions (logins, admin actions). This basically allows two things to happen: - The log itself is useful if there are shenanigans. - Password login can check it and start CAPTCHA'ing users after a few failed attempts. I'm going to change how the admin stuff works a little bit too, since right now you can make someone an agent, grab their certificate, revert them back to a normal user, and then act on their behalf over Conduit. This is a little silly, I'm going to move "agent" to the create workflow instead. I'll also add a confirm/email step to the administrative password reset flow. Test Plan: Took various administrative and non-administrative actions, they appeared in the logs. Filtered the logs in a bunch of different ways. Reviewers: jungejason, tuomaspelkonen, aran CC: Differential Revision: 302
2011-05-18 03:42:21 +02:00
'PhabricatorPeopleLogsController' => 'applications/people/controller/logs',
Basic user/account tool.
2011-01-24 03:09:16 +01:00
'PhabricatorPeopleProfileController' => 'applications/people/controller/profile',
Rough cut of Project profile improvements Summary: - Old page was useless and dumb. - New page looks a little less bad, functions a little less poorly. - Still lots of work to be done. Test Plan: - Viewed a project. - Clicked all the links on the left nav. - Here is a screenshot: https://secure.phabricator.com/file/view/PHID-FILE-4buzquotb3fo4dhlicrw/ Reviewers: btrahan, jungejason Reviewed By: jungejason CC: aran, jungejason Maniphest Tasks: T681 Differential Revision: 1246
2011-12-17 05:01:38 +01:00
'PhabricatorProfileHeaderView' => 'view/layout/profileheader',
Rough cut of projects. Summary: Test Plan: Reviewers: CC:
2011-02-21 03:41:23 +01:00
'PhabricatorProject' => 'applications/project/storage/project',
'PhabricatorProjectAffiliation' => 'applications/project/storage/affiliation',
'PhabricatorProjectAffiliationEditController' => 'applications/project/controller/editaffiliation',
'PhabricatorProjectController' => 'applications/project/controller/base',
Allow affiliations to carry project ownership information; transform profile images correctly Summary: This is sort of doing two things at once: - Add an "isOwner" flag to Project Affiliation to lay the groundwork for T237. - Rename the "QuickCreate" workflow to "Create" and funnel all creation through it. - Reorganize the image transformation stuff and use it to correctly crop/resize uploaded images. Test Plan: Created and edited projects and affailiations. Uploaded project, user, and profile photos. Verified existing thumbnailing in Maniphest still works properly. Reviewed By: cadamo Reviewers: cadamo, aran, jungejason, tuomaspelkonen CC: aran, epriestley, cadamo Differential Revision: 529
2011-06-26 17:37:47 +02:00
'PhabricatorProjectCreateController' => 'applications/project/controller/create',
Rough cut of projects. Summary: Test Plan: Reviewers: CC:
2011-02-21 03:41:23 +01:00
'PhabricatorProjectDAO' => 'applications/project/storage/base',
Provide wiki pages for projects Summary: Provide tighter integration between Projects and Phriction. Partly, I have most of a rewrite for the Projects homepage ready but it's not currently possible to publish feed stories about a project so all the feeds are empty/boring. This partly makes them more useful and partly just provides a tool integration point. - When you create a project, all the wiki pages in projects/<project_name>/* are associated with it. - Publish updates to those pages as being related to the project so they'll show up in project feeds. - Show a project link on those pages. This is very "convention over configuration" but I think it's the right approach. We could provide some sort of, like, "@project=derp" tag to let you associated arbitrary pages to projects later, but just letting you move pages is probably far better. Test Plan: - Ran upgrade scripts against stupidly named projects ("der", " der", " der ", "der (2)", " der (2) (2)", etc). Ended up with uniquely named projects. - Ran unit tests. - Created /projects/ wiki documents and made sure they displayed correctly. - Verified feed stories publish as project-related. - Edited projects, including perfomring a name-colliding edit. - Created projects, including performing a name-colliding create. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley, btrahan Maniphest Tasks: T681 Differential Revision: 1231
2011-12-17 20:58:55 +01:00
'PhabricatorProjectEditor' => 'applications/project/editor/project',
Rough cut of projects. Summary: Test Plan: Reviewers: CC:
2011-02-21 03:41:23 +01:00
'PhabricatorProjectListController' => 'applications/project/controller/list',
Provide wiki pages for projects Summary: Provide tighter integration between Projects and Phriction. Partly, I have most of a rewrite for the Projects homepage ready but it's not currently possible to publish feed stories about a project so all the feeds are empty/boring. This partly makes them more useful and partly just provides a tool integration point. - When you create a project, all the wiki pages in projects/<project_name>/* are associated with it. - Publish updates to those pages as being related to the project so they'll show up in project feeds. - Show a project link on those pages. This is very "convention over configuration" but I think it's the right approach. We could provide some sort of, like, "@project=derp" tag to let you associated arbitrary pages to projects later, but just letting you move pages is probably far better. Test Plan: - Ran upgrade scripts against stupidly named projects ("der", " der", " der ", "der (2)", " der (2) (2)", etc). Ended up with uniquely named projects. - Ran unit tests. - Created /projects/ wiki documents and made sure they displayed correctly. - Verified feed stories publish as project-related. - Edited projects, including perfomring a name-colliding edit. - Created projects, including performing a name-colliding create. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley, btrahan Maniphest Tasks: T681 Differential Revision: 1231
2011-12-17 20:58:55 +01:00
'PhabricatorProjectNameCollisionException' => 'applications/project/exception/namecollison',
Rough cut of projects. Summary: Test Plan: Reviewers: CC:
2011-02-21 03:41:23 +01:00
'PhabricatorProjectProfile' => 'applications/project/storage/profile',
'PhabricatorProjectProfileController' => 'applications/project/controller/profile',
Project list and profile view modifications Summary: Added some change on the project's list view, to show information about active tasks, population, etc. Also modified the "profile view", and added a class "PhabricatorProfileView" to render the profile, both on projects and users. Test Plan: play around the project directory :) Reviewers: epriestley ericfrenkiel CC: Differential Revision: 477
2011-06-18 10:13:56 +02:00
'PhabricatorProjectProfileEditController' => 'applications/project/controller/profileedit',
Take the first step on the long journey of fixing "Projects" Summary: - Allow more than the 100 most recent projects to be viewed. - Provide some useful filters. - Default the view to your projects, not all projects. - Put query logic in a query object. - Put filter view logic in a view object. We can port more stuff to it later. Test Plan: Looked at active/owned/all projects. Set page size to 5 and paged through projects. Reviewers: btrahan, jungejason, zeeg Reviewed By: btrahan CC: aran, btrahan Differential Revision: 1227
2011-12-17 02:08:18 +01:00
'PhabricatorProjectQuery' => 'applications/project/query/project',
Project list and profile view modifications Summary: Added some change on the project's list view, to show information about active tasks, population, etc. Also modified the "profile view", and added a class "PhabricatorProfileView" to render the profile, both on projects and users. Test Plan: play around the project directory :) Reviewers: epriestley ericfrenkiel CC: Differential Revision: 477
2011-06-18 10:13:56 +02:00
'PhabricatorProjectStatus' => 'applications/project/constants/status',
Allow Phabricator storage engines to be extended and configured Summary: See T344. Currently, there's a hard-coded 12MB filesize limit and some awkward interactions with MySQL's max_allowed_packet. Make this system generally more robust: - Move the upload limit to configuration. - Add setup steps which reconcile max_allowed_packet vs MySQL file storage limits. - Add a layer of indirection between uploading files and storage engines. - Allow the definition of new storage engines. - Define a local disk storage engine. - Add a "storage engine selector" class which manages choosing which storage engines to put files in. - Document storage engines. - Document file storage classes. Test Plan: Setup mode: - Disabled MySQL storage engine, misconfigured it, configured it correctly. - Disabled file storage engine, set it to something invalid, set it to something valid. - Verified max_allowed_packet is read correctly. Application mode: - Configured local file storage. - Uploaded large and small files. - Verified larger files were written to local storage. - Verified smaller files were written to MySQL blob storage. Documentation: - Read documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 695
2011-07-20 07:48:38 +02:00
'PhabricatorProjectSubproject' => 'applications/project/storage/subproject',
Automatically redirect 404's that wouldn't be 404s if they had a trailing slash to their trailing-slash counterparts.
2011-04-04 19:29:46 +02:00
'PhabricatorRedirectController' => 'applications/base/controller/redirect',
Fix conservative CSRF token cycling limit Summary: We currently cycle CSRF tokens every hour and check for the last two valid ones. This means that a form could go stale in as little as an hour, and is certainly stale after two. When a stale form is submitted, you basically get a terrible heisen-state where some of your data might persist if you're lucky but more likely it all just vanishes. The .js file below outlines some more details. This is a pretty terrible UX and we don't need to be as conservative about CSRF validation as we're being. Remedy this problem by: - Accepting the last 6 CSRF tokens instead of the last 1 (i.e., pages are valid for at least 6 hours, and for as long as 7). - Using JS to refresh the CSRF token every 55 minutes (i.e., pages connected to the internet are valid indefinitely). - Showing the user an explicit message about what went wrong when CSRF validation fails so the experience is less bewildering. They should now only be able to submit with a bad CSRF token if: - They load a page, disconnect from the internet for 7 hours, reconnect, and submit the form within 55 minutes; or - They are actually the victim of a CSRF attack. We could eventually fix the first one by tracking reconnects, which might be "free" once the notification server gets built. It will probably never be an issue in practice. Test Plan: - Reduced CSRF cycle frequency to 2 seconds, submitted a form after 15 seconds, got the CSRF exception. - Reduced csrf-refresh cycle frequency to 3 seconds, submitted a form after 15 seconds, got a clean form post. - Added debugging code the the csrf refresh to make sure it was doing sensible things (pulling different tokens, finding all the inputs). Reviewed By: aran Reviewers: tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 660
2011-07-13 23:05:18 +02:00
'PhabricatorRefreshCSRFController' => 'applications/auth/controller/refresh',
Link "DNNNN" and "TNNNN" in Phabricator remarkup. Summary: Autolink Differential and Maniphest objects. Test Plan: Typed "D12345" and "T12345" into the Differential comment preview, got links. Typed "http://www.elsewhere.com/D12345" and got a single link to that URI, not a mess where the D12345 part linked incorrectly. Reviewers: aran CC: Differential Revision: 35
2011-02-12 03:06:43 +01:00
'PhabricatorRemarkupRuleDifferential' => 'infrastructure/markup/remarkup/markuprule/differential',
Provide a "reference-with-full-name" syntax for Remarkup Summary: Provide a {T123} syntax which pulls in the entire name of an object, not just a link to it. A major use for this is organizing projects using wiki pages. Since handle links show object status now, this lets you organize stuff in an ad-hoc way and get a reasonable overview of it. We can make handles richer in the future, too. The performance on this isn't perfect (it adds some potential single gets) but I think it's okay for now and I don't want to make remarkup engine even more complex until the preprocess/postprocess stuff has had a chance to settle and I'm more confident it works. In Differential and Maniphest we'll also incorrectly cache the object state/name, but that'll fix itself once I move the cache code to use preprocess/postprocess correctly. Test Plan: - See https://secure.phabricator.com/file/view/PHID-FILE-5f9ca32407bec20899b9/ for an example. - Generated and looked over the documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran, hunterbridges CC: skrul, aran, jungejason, epriestley Differential Revision: 784
2011-08-05 17:50:26 +02:00
'PhabricatorRemarkupRuleDifferentialHandle' => 'infrastructure/markup/remarkup/markuprule/handle/differential',
Restore linking of Diffusion commits.
2011-04-11 12:02:19 +02:00
'PhabricatorRemarkupRuleDiffusion' => 'infrastructure/markup/remarkup/markuprule/diffusion',
Rough implementation of drag-and-drop file uploads Summary: This gets all the major pieces working. Allows you to drag-and-drop files in Differential and Phriction, and embed files in remarkup with {Fxxx} references. See also task. I'm explicitly not documenting this yet since it's still pretty rough. Test Plan: Dragged and dropped stuff into Differential and Phriction. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran, tomo Commenters: tomo CC: aran, tomo, jungejason Differential Revision: 674
2011-07-15 23:17:55 +02:00
'PhabricatorRemarkupRuleEmbedFile' => 'infrastructure/markup/remarkup/markuprule/embedobject',
Image macros for Phabricator! Summary: Added long waited image macro support for differential and others. Test Plan: Tried a couple of different macros and made sure they appear nicely in the comment preview. Made sure that the normal comments are shown correctly. Reviewed By: epriestley Reviewers: epriestley CC: jungejason, tuomaspelkonen, epriestley Differential Revision: 129
2011-04-14 00:15:48 +02:00
'PhabricatorRemarkupRuleImageMacro' => 'infrastructure/markup/remarkup/markuprule/imagemacro',
Link "DNNNN" and "TNNNN" in Phabricator remarkup. Summary: Autolink Differential and Maniphest objects. Test Plan: Typed "D12345" and "T12345" into the Differential comment preview, got links. Typed "http://www.elsewhere.com/D12345" and got a single link to that URI, not a mess where the D12345 part linked incorrectly. Reviewers: aran CC: Differential Revision: 35
2011-02-12 03:06:43 +01:00
'PhabricatorRemarkupRuleManiphest' => 'infrastructure/markup/remarkup/markuprule/maniphest',
Provide a "reference-with-full-name" syntax for Remarkup Summary: Provide a {T123} syntax which pulls in the entire name of an object, not just a link to it. A major use for this is organizing projects using wiki pages. Since handle links show object status now, this lets you organize stuff in an ad-hoc way and get a reasonable overview of it. We can make handles richer in the future, too. The performance on this isn't perfect (it adds some potential single gets) but I think it's okay for now and I don't want to make remarkup engine even more complex until the preprocess/postprocess stuff has had a chance to settle and I'm more confident it works. In Differential and Maniphest we'll also incorrectly cache the object state/name, but that'll fix itself once I move the cache code to use preprocess/postprocess correctly. Test Plan: - See https://secure.phabricator.com/file/view/PHID-FILE-5f9ca32407bec20899b9/ for an example. - Generated and looked over the documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran, hunterbridges CC: skrul, aran, jungejason, epriestley Differential Revision: 784
2011-08-05 17:50:26 +02:00
'PhabricatorRemarkupRuleManiphestHandle' => 'infrastructure/markup/remarkup/markuprule/handle/maniphest',
Basic @mentions support Summary: Provides basic Remarkup support for @mentions. No application integration yet so these aren't terribly useful until that happens. Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-83d68e7af6085ae928df/ Reviewers: tomo, mroch, jsp Commenters: tomo CC: aran, tomo, epriestley Differential Revision: 517
2011-06-24 19:59:57 +02:00
'PhabricatorRemarkupRuleMention' => 'infrastructure/markup/remarkup/markuprule/mention',
Provide a "reference-with-full-name" syntax for Remarkup Summary: Provide a {T123} syntax which pulls in the entire name of an object, not just a link to it. A major use for this is organizing projects using wiki pages. Since handle links show object status now, this lets you organize stuff in an ad-hoc way and get a reasonable overview of it. We can make handles richer in the future, too. The performance on this isn't perfect (it adds some potential single gets) but I think it's okay for now and I don't want to make remarkup engine even more complex until the preprocess/postprocess stuff has had a chance to settle and I'm more confident it works. In Differential and Maniphest we'll also incorrectly cache the object state/name, but that'll fix itself once I move the cache code to use preprocess/postprocess correctly. Test Plan: - See https://secure.phabricator.com/file/view/PHID-FILE-5f9ca32407bec20899b9/ for an example. - Generated and looked over the documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran, hunterbridges CC: skrul, aran, jungejason, epriestley Differential Revision: 784
2011-08-05 17:50:26 +02:00
'PhabricatorRemarkupRuleObjectHandle' => 'infrastructure/markup/remarkup/markuprule/handle',
Add comment linking to Maniphest and Differential Summary: Allows you to link to comments with "D123#3" or "T123#3", then adds a pile of JS to try to make it not terrible. :/ The thing I'm trying to avoid here is when someone says "look at this! http://blog.com/#comment-239291" and you click and your browser jumps somewhere random and you have no idea which comment they meant. Since I really hate this, I've tried to avoid it by making sure the comment is always highlighted. Test Plan: Put T1#1 and D1#1 in remarkup and verified they linked properly. Clicked anchors on individual comments. Faked all comments hidden in Differential and verified they expanded on anchor or anchor change. Reviewed By: aran Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen CC: aran, epriestley Differential Revision: 383
2011-05-31 19:23:31 +02:00
'PhabricatorRemarkupRuleObjectName' => 'infrastructure/markup/remarkup/markuprule/objectname',
Add P### link to paste Summary:Make a new directory, src/infrastructure/markup/remarkup/markuprule/paste/ Make a new class called PhabricatorRemarkupRulePaste in that directory. Add the rule to DifferentialMarkupEngineFactory. Test Plan: Created a task in maniphest. Put P1 and P2 in the content. Created P1 and P2 in Paste. Verified P1 and P2 were highlighted and linked correctly. Reviewers:epriestley, codeblock CC:jungejason Differential Revision: 539
2011-06-27 08:57:43 +02:00
'PhabricatorRemarkupRulePaste' => 'infrastructure/markup/remarkup/markuprule/paste',
Basic remarkup integration for Phriction Summary: Document linking and some general layout improvements. I'd like to eventually do more meta-dataey things with links (like store them separately and check them for 404s) but this is a decent start. Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-d756b94a06b69c273fce/ Reviewed By: jungejason Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 650
2011-07-12 05:14:46 +02:00
'PhabricatorRemarkupRulePhriction' => 'infrastructure/markup/remarkup/markuprule/phriction',
Restore image proxying to Remarkup Summary: Previously, Remarkup allowed you to paste in an image URI and get an inline image. However, it did this by hotlinking the image which isn't so hot in an open source product. Restore this feature, but use image proxying instead. The existing image macro code does most of the work. There is a mild security risk depending on the network setup so I've left this default-disabled and made a note about it. It should be safe to enable for Facebook. Test Plan: Pasted in image and non-image links, got reasonable behavior. Verified proxying appears to work. Verified that file:// shenanigans produce 400. Reviewed By: tuomaspelkonen Reviewers: aran, jungejason, tuomaspelkonen Commenters: cpiro CC: aran, cpiro, tuomaspelkonen Differential Revision: 214
2011-05-02 23:20:24 +02:00
'PhabricatorRemarkupRuleProxyImage' => 'infrastructure/markup/remarkup/markuprule/proxyimage',
Embedded youtube videos. Summary: Markup support for embedding Youtube videos. Test Plan: https://www.youtube.com/watch?v=Vw4KVoEVcr0 was embedded Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley Differential Revision: 353
2011-05-27 21:50:02 +02:00
'PhabricatorRemarkupRuleYoutube' => 'infrastructure/markup/remarkup/markuprule/youtube',
Rough cut of Repositories and GitHub post-receive hooks. Summary: Test Plan: Reviewers: CC:
2011-02-13 03:26:15 +01:00
'PhabricatorRepository' => 'applications/repository/storage/repository',
Sync up UUIDs and create project configs.
2011-04-06 05:49:31 +02:00
'PhabricatorRepositoryArcanistProject' => 'applications/repository/storage/arcanistproject',
'PhabricatorRepositoryArcanistProjectEditController' => 'applications/repository/controller/arcansistprojectedit',
Rough cut of repository tracking Summary: Basic scaffolding for repository tracking, plus daemon infrastructure (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk). Test Plan: parsed Javelin git commit history via daemon Reviewers: CC:
2011-03-07 07:29:22 +01:00
'PhabricatorRepositoryCommit' => 'applications/repository/storage/commit',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorRepositoryCommitChangeParserWorker' => 'applications/repository/worker/commitchangeparser/base',
'PhabricatorRepositoryCommitData' => 'applications/repository/storage/commitdata',
Rough cut of repository tracking Summary: Basic scaffolding for repository tracking, plus daemon infrastructure (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk). Test Plan: parsed Javelin git commit history via daemon Reviewers: CC:
2011-03-07 07:29:22 +01:00
'PhabricatorRepositoryCommitDiscoveryDaemon' => 'applications/repository/daemon/commitdiscovery/base',
HeraldCommitAdapter and some related junk.
2011-04-04 08:23:36 +02:00
'PhabricatorRepositoryCommitHeraldWorker' => 'applications/repository/worker/herald',
Add basic detail-parser functionality.
2011-04-02 02:11:05 +02:00
'PhabricatorRepositoryCommitMessageDetailParser' => 'applications/repository/parser/base',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorRepositoryCommitMessageParserWorker' => 'applications/repository/worker/commitmessageparser/base',
Add Related Commits for Owners Summary: For each commit, find the affected packages, and provide a way to search by package. Test Plan: create commits that touch and don't touch two packages, and verify that they display correctly in all the UI pages. Reviewers: epriestley, blair, nh, tuomaspelkonen Reviewed By: epriestley CC: benmathews, aran, epriestley, btrahan, jungejason, mpodobnik, prithvi Maniphest Tasks: T83 Differential Revision: 1208
2011-12-14 09:53:25 +01:00
'PhabricatorRepositoryCommitOwnersWorker' => 'applications/repository/worker/owner',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorRepositoryCommitParserWorker' => 'applications/repository/worker/base',
'PhabricatorRepositoryCommitTaskDaemon' => 'applications/repository/daemon/committask',
Rough cut of Repositories and GitHub post-receive hooks. Summary: Test Plan: Reviewers: CC:
2011-02-13 03:26:15 +01:00
'PhabricatorRepositoryController' => 'applications/repository/controller/base',
'PhabricatorRepositoryCreateController' => 'applications/repository/controller/create',
'PhabricatorRepositoryDAO' => 'applications/repository/storage/base',
Rough cut of repository tracking Summary: Basic scaffolding for repository tracking, plus daemon infrastructure (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk). Test Plan: parsed Javelin git commit history via daemon Reviewers: CC:
2011-03-07 07:29:22 +01:00
'PhabricatorRepositoryDaemon' => 'applications/repository/daemon/base',
Add basic detail-parser functionality.
2011-04-02 02:11:05 +02:00
'PhabricatorRepositoryDefaultCommitMessageDetailParser' => 'applications/repository/parser/default',
Fix repository deletion Summary: I never actually wrote this controller. Test Plan: Deleted a repository via web UI. Reviewed By: tuomaspelkonen Reviewers: tuomaspelkonen, jungejason, aran Commenters: aran CC: aran, tuomaspelkonen, epriestley Differential Revision: 231
2011-05-05 21:53:39 +02:00
'PhabricatorRepositoryDeleteController' => 'applications/repository/controller/delete',
Rough cut of Repositories and GitHub post-receive hooks. Summary: Test Plan: Reviewers: CC:
2011-02-13 03:26:15 +01:00
'PhabricatorRepositoryEditController' => 'applications/repository/controller/edit',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorRepositoryGitCommitChangeParserWorker' => 'applications/repository/worker/commitchangeparser/git',
Rough cut of repository tracking Summary: Basic scaffolding for repository tracking, plus daemon infrastructure (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk). Test Plan: parsed Javelin git commit history via daemon Reviewers: CC:
2011-03-07 07:29:22 +01:00
'PhabricatorRepositoryGitCommitDiscoveryDaemon' => 'applications/repository/daemon/commitdiscovery/git',
Relax the same-origin check in the Git commit discovery daemon Summary: Git accepts either "git@x:/path" or "ssh://git@x.com/path" URIs to mean the exact same thing, which is causing some false positives and confusion, particularly because we sometimes mutate URIs. Since this is just a sanity check, we don't really care about the username, domain or credentials -- matching the paths is good enough. We're just trying to make it hard to shoot yourself in the foot by copy-pasting the same local path into two repositories and forgetting to change one, like I did. :P Relax the check to only verify the paths are the same. Test Plan: - Ran unit tests, which should fully cover things. - Ran commit discovery daemon in debug mode on incorrectly and correctly configured repositories. Reviewers: ajtrichards, jungejason, btrahan Reviewed By: jungejason CC: aran, jungejason Maniphest Tasks: T710 Differential Revision: https://secure.phabricator.com/D1279
2011-12-23 17:11:11 +01:00
'PhabricatorRepositoryGitCommitDiscoveryDaemonTestCase' => 'applications/repository/daemon/commitdiscovery/git/__tests__',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorRepositoryGitCommitMessageParserWorker' => 'applications/repository/worker/commitmessageparser/git',
Improve awkward Diffusion query plans.
2011-03-21 01:46:02 +01:00
'PhabricatorRepositoryGitFetchDaemon' => 'applications/repository/daemon/gitfetch',
Rough cut of Repositories and GitHub post-receive hooks. Summary: Test Plan: Reviewers: CC:
2011-02-13 03:26:15 +01:00
'PhabricatorRepositoryListController' => 'applications/repository/controller/list',
Basic support for Mercurial in Diffusion Summary: Change import script plus almost all the view stuff. Still some rough edges but this seems to mostly work. Blame is currently unsupported but I think everything else works properly. Test Plan: Imported the hg repository itself. It doesn't immediately seem completely broken. Here are some screens: https://secure.phabricator.com/file/view/PHID-FILE-1438b71cc7c4a2eb4569/ https://secure.phabricator.com/file/view/PHID-FILE-3cec4f72f39e7de2d041/ https://secure.phabricator.com/file/view/PHID-FILE-2ea4883f160e8e5098f9/ https://secure.phabricator.com/file/view/PHID-FILE-35f751a36ebf65399ade/ All the parsers were able to churn through it without errors. Ran the new "reparse.php" script in various one-commit and repository modes. Browsed/imported some git repos for good measure. NOTE: The hg repository is only 15,000 commits and around 1,000 files. Performance is okay but hg doesn't provide performant, native APIs to get some data efficiently so we have to do some dumb stuff. If some of these interfaces are cripplingly slow or whatever, let me know and we can start bundling some Mercurial extensions with Arcanist. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, Makinde, epriestley Differential Revision: 960
2011-09-26 20:07:38 +02:00
'PhabricatorRepositoryMercurialCommitChangeParserWorker' => 'applications/repository/worker/commitchangeparser/mercurial',
Add a Mercurial commit discovery daemon Summary: Repository import has three major steps: - Commit discovery (serial) - Message parsing (parallel, mostly VCS independent) - Change parsing (parallel, highly VCS dependent) This implements commit discovery for Mercurial, similar to git's parsing: - List the heads of all the branches. - If we haven't already discovered them, follow them back to their roots (or the first commit we have discovered). - Import all the newly discovered commits, oldest first. This is a little complicated but it ensures we discover commits in depth order, so the discovery process is robust against interruption/failure. If we just inserted commits as we went, we might read the tip, insert it, and then crash. When we ran again, we'd think we had already discovered commits older than HEAD. This also allows later stages to rely on being able to find Phabricator commit IDs which correspond to parent commits. NOTE: This importer is fairly slow because "hg" has a large startup time (compare "hg --version" to "git --version" and "svn --version"; on my machine, hg has 60ms of overhead for any command) and we need to run many commands (see the whole "hg id" mess). You can expect something like 10,000 per hour, which means you may need to run overnight to discover a large repository (IIRC, the svn/git discovery processes are both about an order of magnitude faster). We could improve this with batching, but I want to keep it as simple as possible for now. Test Plan: Discovered all the commits in the main Mercurial repository, http://selenic.com/repo/hg. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, Makinde Differential Revision: 943
2011-09-16 12:56:23 +02:00
'PhabricatorRepositoryMercurialCommitDiscoveryDaemon' => 'applications/repository/daemon/commitdiscovery/mercurial',
Add a Mercurial message parser Summary: See D943, this is the second parse stage. This will mark Differential revisions as "Committed" among other things. Almost all the logic here is shared between VCSes so the implementation itself is straightforward. Test Plan: Parsed all messages for the official Mercurial repository. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, Makinde Differential Revision: 944
2011-09-16 18:37:15 +02:00
'PhabricatorRepositoryMercurialCommitMessageParserWorker' => 'applications/repository/worker/commitmessageparser/mercurial',
Add Mercurial repository configuration and local pull support Summary: No actual parsing/import yet, but now you can define and pull Mercurial repositories. I merged most of the local pull code so we can share it between hg/git. Test Plan: - Created a new Mercurial repository to track Codeigniter off Bitbucket - Edited / saved / etc. - Launched the mercurial pull daemon, it pulled the repo. Killed and relaunched, it updated the repo. - Launched the git fetch deamon, it still works correctly. Reviewers: Makinde, aran, jungejason, tuomaspelkonen Reviewed By: Makinde CC: aran, Makinde Differential Revision: 793
2011-08-09 21:47:46 +02:00
'PhabricatorRepositoryMercurialPullDaemon' => 'applications/repository/daemon/mercurialpull',
'PhabricatorRepositoryPullLocalDaemon' => 'applications/repository/daemon/pulllocal',
Restore "Shortcuts" feature to Diffusion.
2011-03-31 09:33:44 +02:00
'PhabricatorRepositoryShortcut' => 'applications/repository/storage/shortcut',
Diffusion change parser for SVN. Summary: there is a small possibility this works correctly Test Plan: Reviewers: CC:
2011-03-11 23:13:23 +01:00
'PhabricatorRepositorySvnCommitChangeParserWorker' => 'applications/repository/worker/commitchangeparser/svn',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorRepositorySvnCommitDiscoveryDaemon' => 'applications/repository/daemon/commitdiscovery/svn',
'PhabricatorRepositorySvnCommitMessageParserWorker' => 'applications/repository/worker/commitmessageparser/svn',
Add storage for repository symbol tracking Summary: See T315 for an extensive description of this feature. Adds the descibed storage table. Test Plan: Used phpsh to read/write symbol objects. Reviewers: jungejason, nh, tuomaspelkonen, aran Reviewed By: tuomaspelkonen CC: aran, epriestley, tuomaspelkonen Differential Revision: 897
2011-09-05 02:31:16 +02:00
'PhabricatorRepositorySymbol' => 'applications/repository/storage/symbol',
Relax the same-origin check in the Git commit discovery daemon Summary: Git accepts either "git@x:/path" or "ssh://git@x.com/path" URIs to mean the exact same thing, which is causing some false positives and confusion, particularly because we sometimes mutate URIs. Since this is just a sanity check, we don't really care about the username, domain or credentials -- matching the paths is good enough. We're just trying to make it hard to shoot yourself in the foot by copy-pasting the same local path into two repositories and forgetting to change one, like I did. :P Relax the check to only verify the paths are the same. Test Plan: - Ran unit tests, which should fully cover things. - Ran commit discovery daemon in debug mode on incorrectly and correctly configured repositories. Reviewers: ajtrichards, jungejason, btrahan Reviewed By: jungejason CC: aran, jungejason Maniphest Tasks: T710 Differential Revision: https://secure.phabricator.com/D1279
2011-12-23 17:11:11 +01:00
'PhabricatorRepositoryTestCase' => 'applications/repository/storage/repository/__tests__',
Rough cut of repository tracking Summary: Basic scaffolding for repository tracking, plus daemon infrastructure (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk). Test Plan: parsed Javelin git commit history via daemon Reviewers: CC:
2011-03-07 07:29:22 +01:00
'PhabricatorRepositoryType' => 'applications/repository/constants/repositorytype',
Add an Amazon S3 storage engine for Phabricator Summary: Implements an S3 storage engine option for Phabricator. Test Plan: - Uploaded files to S3. - Looked at them. - Verified they appeared in S3 using the S3 file browser. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 752
2011-07-31 22:54:58 +02:00
'PhabricatorS3FileStorageEngine' => 'applications/files/engine/s3',
Add a "setup" mode which guides new users through application configuration Summary: Alters the installation instructions to guide installers into a "setup" mode which does config file sanity checking. Test Plan: Put myself in setup mode, simulated all the failures it detects, took myself out of setup mode, Phabricator works OK. Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran CC: aran, tuomaspelkonen, epriestley Differential Revision: 230
2011-05-05 20:00:05 +02:00
'PhabricatorSQLPatchList' => 'infrastructure/setup/sql',
Rought cut of search. Summary: Botched this pretty badly in git so we'll see how much I broke. :/ Test Plan: Reviewers: CC:
2011-02-15 00:34:20 +01:00
'PhabricatorSearchAbstractDocument' => 'applications/search/index/abstractdocument',
Allow revisions to be edited from Maniphest Summary: You can currently attach tasks to revisions from Differential, but not revisions to tasks from Maniphest. Allow editing from either side. This logic is kind of tricky but the alternative was massive code duplication. Test Plan: Added and removed revisions from maniphest. Added and removed tasks from differential. This should have no impact on the Facebook install since none of this is used there. Reviewed By: aran Reviewers: tomo, tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 288
2011-05-16 20:43:39 +02:00
'PhabricatorSearchAttachController' => 'applications/search/controller/attach',
Rought cut of search. Summary: Botched this pretty badly in git so we'll see how much I broke. :/ Test Plan: Reviewers: CC:
2011-02-15 00:34:20 +01:00
'PhabricatorSearchBaseController' => 'applications/search/controller/base',
Add commits to the Phabricator search index Summary: create the indexer for commit Test Plan: run the reindex_one_commit.php against one existing commit and it is returned in search result on the webpage; run parse_one_commit against another commit; modified reindex_everything.php to let it only parse one commit after loading all commits. Reviewed By: epriestley Reviewers: epriestley, aran CC: aran, jungejason, epriestley, debow Differential Revision: 490
2011-06-20 06:02:48 +02:00
'PhabricatorSearchCommitIndexer' => 'applications/search/index/indexer/repository',
Rought cut of search. Summary: Botched this pretty badly in git so we'll see how much I broke. :/ Test Plan: Reviewers: CC:
2011-02-15 00:34:20 +01:00
'PhabricatorSearchController' => 'applications/search/controller/search',
'PhabricatorSearchDAO' => 'applications/search/storage/base',
'PhabricatorSearchDifferentialIndexer' => 'applications/search/index/indexer/differential',
'PhabricatorSearchDocument' => 'applications/search/storage/document/document',
'PhabricatorSearchDocumentField' => 'applications/search/storage/document/field',
'PhabricatorSearchDocumentIndexer' => 'applications/search/index/indexer/base',
'PhabricatorSearchDocumentRelationship' => 'applications/search/storage/document/relationship',
Provide an indirection layer between documents and the search engine Summary: In preparation for adding another search engine (see T355): - Rename "executor" to "engine". - Move all engine-specific operations into the engine. Specifically, this means that indexing moves out of the document store and into the engine (it was sort of silly where it was before). - Split choice of an engine into an overridable "selector" class, a base API, and a concrete MySQL implementation (just like storage engine selection). - Make all callers go through the indirection layer. The default selector just unconditionally selects the MySQL engine, but now (with D786) I can build an Elastic Search engine and you guys can build a multi-target engine if you want and I don't get there fast enough. Test Plan: - Created a new document (task). - Searched for and found it. - Viewed index reconstruction. Reviewed By: jungejason Reviewers: jungejason, amckinley, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 788
2011-08-08 00:14:23 +02:00
'PhabricatorSearchEngine' => 'applications/search/engine/base',
'PhabricatorSearchEngineMySQL' => 'applications/search/engine/mysql',
'PhabricatorSearchEngineSelector' => 'applications/search/selector/base',
Rought cut of search. Summary: Botched this pretty badly in git so we'll see how much I broke. :/ Test Plan: Reviewers: CC:
2011-02-15 00:34:20 +01:00
'PhabricatorSearchField' => 'applications/search/constants/field',
Index "owner" relationship in search correctly for Revisions Summary: The owners of a revision are only really the reviewers when the revision is in NEEDS_REVIEW. Also build a raw indexed document viewer so you can look at the index of a document from the web interface. Finally, reindex revisions when comments are added, not just when the revision itself is edited. Test Plan: Toggled abandon/reclaim on a revision and verified the relationships indexed properly. Reviewed By: jungejason Reviewers: aran, jungejason, tuomaspelkonen CC: aran, epriestley, jungejason Differential Revision: 470
2011-06-15 16:43:43 +02:00
'PhabricatorSearchIndexController' => 'applications/search/controller/index',
Rought cut of search. Summary: Botched this pretty badly in git so we'll see how much I broke. :/ Test Plan: Reviewers: CC:
2011-02-15 00:34:20 +01:00
'PhabricatorSearchManiphestIndexer' => 'applications/search/index/indexer/maniphest',
Phriction handles and search Summary: Index Phriction documents in search, and allow PhabricatorObjectHandleData to load them. Test Plan: Searched for "pokemons", got my wiki page as a search result. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, hsb Differential Revision: 648
2011-07-12 02:29:08 +02:00
'PhabricatorSearchPhrictionIndexer' => 'applications/search/index/indexer/phriction',
Rought cut of search. Summary: Botched this pretty badly in git so we'll see how much I broke. :/ Test Plan: Reviewers: CC:
2011-02-15 00:34:20 +01:00
'PhabricatorSearchQuery' => 'applications/search/storage/query',
'PhabricatorSearchRelationship' => 'applications/search/constants/relationship',
Improve search result listing Summary: Make it prettier, paginate, add user pictures, show document types, clean some stuff up a little. Plenty of room for improvement but this should make it a lot more useful. Test Plan: Here's what the new one looks like: https://secure.phabricator.com/file/view/PHID-FILE-edce2b83c2e3a121c2b7/ Reviewed By: jungejason Reviewers: tomo, jungejason, aran, tuomaspelkonen, mroch Commenters: tomo CC: aran, tomo, jungejason, epriestley Differential Revision: 545
2011-06-28 23:35:02 +02:00
'PhabricatorSearchResultView' => 'applications/search/view/searchresult',
Allow revisions to be edited from Maniphest Summary: You can currently attach tasks to revisions from Differential, but not revisions to tasks from Maniphest. Allow editing from either side. This logic is kind of tricky but the alternative was massive code duplication. Test Plan: Added and removed revisions from maniphest. Added and removed tasks from differential. This should have no impact on the Facebook install since none of this is used there. Reviewed By: aran Reviewers: tomo, tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 288
2011-05-16 20:43:39 +02:00
'PhabricatorSearchSelectController' => 'applications/search/controller/select',
Index users in search results. Summary: Add users to the search results. I need to follow this up with a patch to make the search results stop being terrible. I'll do that. Test Plan: Searched for users, ran "reindex_all_users.php" Reviewed By: jungejason Reviewers: tomo, jungejason, aran CC: aran, jungejason Differential Revision: 508
2011-06-23 22:31:20 +02:00
'PhabricatorSearchUserIndexer' => 'applications/search/index/indexer/user',
Add a "setup" mode which guides new users through application configuration Summary: Alters the installation instructions to guide installers into a "setup" mode which does config file sanity checking. Test Plan: Put myself in setup mode, simulated all the failures it detects, took myself out of setup mode, Phabricator works OK. Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran CC: aran, tuomaspelkonen, epriestley Differential Revision: 230
2011-05-05 20:00:05 +02:00
'PhabricatorSetup' => 'infrastructure/setup',
Port the "Slowvote" application Summary: Port slowvote. This has some style/layout roughness but gets us most of the way there. I'll followup to fix some of the markup issues. Test Plan: Created and voted in several different kinds of poll. Reviewed By: codeblock Reviewers: codeblock, tomo, jungejason, aran, tuomaspelkonen Commenters: aran, jungejason CC: aran, codeblock, jungejason, epriestley Differential Revision: 613
2011-07-08 20:13:11 +02:00
'PhabricatorSlowvoteChoice' => 'applications/slowvote/storage/choice',
'PhabricatorSlowvoteComment' => 'applications/slowvote/storage/comment',
'PhabricatorSlowvoteController' => 'applications/slowvote/controller/base',
'PhabricatorSlowvoteCreateController' => 'applications/slowvote/controller/create',
'PhabricatorSlowvoteDAO' => 'applications/slowvote/storage/base',
'PhabricatorSlowvoteListController' => 'applications/slowvote/controller/list',
'PhabricatorSlowvoteOption' => 'applications/slowvote/storage/option',
'PhabricatorSlowvotePoll' => 'applications/slowvote/storage/poll',
'PhabricatorSlowvotePollController' => 'applications/slowvote/controller/poll',
More phabricator organizational stuff.
2011-01-23 02:48:55 +01:00
'PhabricatorStandardPageView' => 'view/page/standard',
Add /status/
2011-04-08 20:13:29 +02:00
'PhabricatorStatusController' => 'applications/status/base',
Add a custom lint name hook to Phabricator Summary: Allow Conduit method so they stop raising lint warnings. See D874. Test Plan: Ran "arc lint" on conduit files and was no longer given frivolous warnings. Reviewers: nh, jungejason, tuomaspelkonen, aran Reviewed By: nh CC: aran, nh, epriestley Differential Revision: 875
2011-08-30 22:12:20 +02:00
'PhabricatorSymbolNameLinter' => 'infrastructure/lint/hook/xhpastsymbolname',
Clean up Phabricator interface to syntax highlighting Summary: Reduce the amount of code duplication here and allow for an override configuration on the filename.map stuff. Test Plan: Checked paste, diffusion and differential syntax highlighting and everything appeared reasonable. Reviewed By: codeblock Reviewers: tuomaspelkonen, codeblock, jungejason, aran CC: aran, codeblock, epriestley Differential Revision: 601
2011-07-06 21:12:17 +02:00
'PhabricatorSyntaxHighlighter' => 'applications/markup/syntax',
Rough cut of Workers Summary: workers do work, provided I have written them correctly. perhaps it is so. Test Plan: Reviewers: CC:
2011-03-10 22:48:29 +01:00
'PhabricatorTaskmasterDaemon' => 'infrastructure/daemon/workers/taskmaster',
Provide an "isolated" database connection for testing Summary: This provides a new connection which doesn't connect to anything, so effects can be isolated to the current process (for unit testing). Test Plan: Ran unit tests. Reviewed By: aran Reviewers: aran, tuomaspelkonen, jungejason CC: aran, epriestley Differential Revision: 193
2011-04-30 19:11:41 +02:00
'PhabricatorTestCase' => 'infrastructure/testing/testcase',
Rough cut of Workers Summary: workers do work, provided I have written them correctly. perhaps it is so. Test Plan: Reviewers: CC:
2011-03-10 22:48:29 +01:00
'PhabricatorTimelineCursor' => 'infrastructure/daemon/timeline/storage/cursor',
'PhabricatorTimelineDAO' => 'infrastructure/daemon/timeline/storage/base',
'PhabricatorTimelineEvent' => 'infrastructure/daemon/timeline/storage/event',
'PhabricatorTimelineEventData' => 'infrastructure/daemon/timeline/storage/eventdata',
'PhabricatorTimelineIterator' => 'infrastructure/daemon/timeline/cursor/iterator',
Countdown Summary: Addon that allows you to create a live countdown page to some event. Here is the ticket that this code is based on https://secure.phabricator.com/T36 Test Plan: Tested by manually setting dates in the timer.js file and checking if they made sense. I'm not sure if it works across different timezones though. Reviewers: epriestley CC: Differential Revision: 436
2011-06-13 01:06:17 +02:00
'PhabricatorTimer' => 'applications/countdown/storage/timer',
Basic image thumbnailing Summary: This is still very rough but provides basic support for generating image thumbnails. I need to separate stuff out a bit but I'm going to integrate into Maniphest before I hit the profile stuff so this seems like a reasonable starting point. Test Plan: Generated some image thumbnails in various sizes. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 333
2011-05-22 23:40:51 +02:00
'PhabricatorTransformedFile' => 'applications/files/storage/transformed',
Add a little more unit test documentation, fail loudly when isolation prevents a query Summary: - Provide an example unit test, and document it. - Document database isolation better. - When we issue an unsimulated query to the isolated connection, throw a helpful message. - Pygments is complaining about my madeup "lang=demo", change it to "lang=text". Test Plan: - Ran the unit test (sanity check). - Ran all other unit tests (verify I didn't break isolation). - Added a queryfx(..., 'SELECT 1') to a test and verified it throws. - Read the documentation. Reviewed By: edward Reviewers: edward, jungejason, tuomaspelkonen, aran CC: aran, edward Differential Revision: 773
2011-08-03 17:17:53 +02:00
'PhabricatorTrivialTestCase' => 'infrastructure/testing/testcase/__tests__',
Typeaheads
2011-01-25 22:48:05 +01:00
'PhabricatorTypeaheadCommonDatasourceController' => 'applications/typeahead/controller/common',
'PhabricatorTypeaheadDatasourceController' => 'applications/typeahead/controller/base',
AphrontPagerView and UIExamples.
2011-04-01 02:06:33 +02:00
'PhabricatorUIExample' => 'applications/uiexample/examples/base',
'PhabricatorUIExampleController' => 'applications/uiexample/controller/base',
'PhabricatorUIExampleRenderController' => 'applications/uiexample/controller/render',
AphrontListFilterView, for list filtering.
2011-04-04 00:50:06 +02:00
'PhabricatorUIListFilterExample' => 'applications/uiexample/examples/listfilter',
AphrontPagerView and UIExamples.
2011-04-01 02:06:33 +02:00
'PhabricatorUIPagerExample' => 'applications/uiexample/examples/pager',
Basic user/account tool.
2011-01-24 03:09:16 +01:00
'PhabricatorUser' => 'applications/people/storage/user',
Refactor user settings Summary: I want to do two things here: - Add SSH Keys - Move "Preferences" into this panel But this controller was pretty gigantic and messy. Split it apart and use delegation instead. There are no functional changes. I changed some of the conduit certificate text to simplify it since no one should need to go through that workflow anymore, given the existence of "arc install-certificate". Test Plan: - Edited realname, including attempting to remove it. - Edited profile picture. - Edited timezone. - Edited email, including attempting to remove it. - Regenerated condiut certificate. - Linked and unlinked an OAuth account. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 688
2011-07-18 17:02:00 +02:00
'PhabricatorUserAccountSettingsPanelController' => 'applications/people/controller/settings/panels/account',
'PhabricatorUserConduitSettingsPanelController' => 'applications/people/controller/settings/panels/conduit',
Basic user/account tool.
2011-01-24 03:09:16 +01:00
'PhabricatorUserDAO' => 'applications/people/storage/base',
Add optional "Re:" prefix to all threaded mail and allow disabling mail about your own actions Summary: - Mail.app on Lion has cumbersome threading rules, see T782. Add an option to stick "Re: " in front of all threaded mail so it behaves. This is horrible, but apparently the least-horrible option. - While I was in there, I added an option for T228. Test Plan: - Sent a bunch of threaded and unthreaded mail with varous "Re:" settings, seemed to get "Re:" in the right places. - Disabled email about my stuff, created a task with just me, got voided mail, added a CC, got mail to just the CC. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, mkjones Maniphest Tasks: T228, T782 Differential Revision: https://secure.phabricator.com/D1448
2012-01-18 05:32:28 +01:00
'PhabricatorUserEmailPreferenceSettingsPanelController' => 'applications/people/controller/settings/panels/emailpref',
Refactor user settings Summary: I want to do two things here: - Add SSH Keys - Move "Preferences" into this panel But this controller was pretty gigantic and messy. Split it apart and use delegation instead. There are no functional changes. I changed some of the conduit certificate text to simplify it since no one should need to go through that workflow anymore, given the existence of "arc install-certificate". Test Plan: - Edited realname, including attempting to remove it. - Edited profile picture. - Edited timezone. - Edited email, including attempting to remove it. - Regenerated condiut certificate. - Linked and unlinked an OAuth account. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 688
2011-07-18 17:02:00 +02:00
'PhabricatorUserEmailSettingsPanelController' => 'applications/people/controller/settings/panels/email',
Provide an activity log for login and administrative actions Summary: This isn't complete, but I figured I'd ship it for review while it's still smallish. Provide an activity log for high-level system actions (logins, admin actions). This basically allows two things to happen: - The log itself is useful if there are shenanigans. - Password login can check it and start CAPTCHA'ing users after a few failed attempts. I'm going to change how the admin stuff works a little bit too, since right now you can make someone an agent, grab their certificate, revert them back to a normal user, and then act on their behalf over Conduit. This is a little silly, I'm going to move "agent" to the create workflow instead. I'll also add a confirm/email step to the administrative password reset flow. Test Plan: Took various administrative and non-administrative actions, they appeared in the logs. Filtered the logs in a bunch of different ways. Reviewers: jungejason, tuomaspelkonen, aran CC: Differential Revision: 302
2011-05-18 03:42:21 +02:00
'PhabricatorUserLog' => 'applications/people/storage/log',
Github OAuth Summary: Test Plan: Reviewers: CC:
2011-02-21 07:47:56 +01:00
'PhabricatorUserOAuthInfo' => 'applications/people/storage/useroauthinfo',
Refactor user settings Summary: I want to do two things here: - Add SSH Keys - Move "Preferences" into this panel But this controller was pretty gigantic and messy. Split it apart and use delegation instead. There are no functional changes. I changed some of the conduit certificate text to simplify it since no one should need to go through that workflow anymore, given the existence of "arc install-certificate". Test Plan: - Edited realname, including attempting to remove it. - Edited profile picture. - Edited timezone. - Edited email, including attempting to remove it. - Regenerated condiut certificate. - Linked and unlinked an OAuth account. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 688
2011-07-18 17:02:00 +02:00
'PhabricatorUserOAuthSettingsPanelController' => 'applications/people/controller/settings/panels/oauth',
Add change password settings panel Summary: In password-based auth environments, there is now a user settings panel to allow them to change their password. Test Plan: Click settings, choose password from the left: * enter current password, new password (twice), log out, and log in with new password * enter current password, non-matching passwords, and get error * enter invalid old password, and get error * use firebug to change csrf token and verify that it does not save with and invalid token Changed config to disable password auth, loaded settings panel and saw that password was no longer visible. Tried loading the panel anyway and got redirected. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: 890
2011-09-04 10:53:58 +02:00
'PhabricatorUserPasswordSettingsPanelController' => 'applications/people/controller/settings/panels/password',
Move "Preferences" to "Settings" Summary: It makes more sense to just make this a settings panel rather than a standalone app, particularly since setting panels are relatively well separated now. Also default-disabled the SSH Keys interface since it won't currently be useful for most installs. Test Plan: Edited preferences. Reviewed By: jungejason Reviewers: tuomaspelkonen, jungejason, aran CC: aran, jungejason Differential Revision: 716
2011-07-24 20:02:08 +02:00
'PhabricatorUserPreferenceSettingsPanelController' => 'applications/people/controller/settings/panels/preferences',
User preferences ported from tools Summary: Internal tools, e.g., differential and diffusion have user defined preferences for monospaced font and the option for showing either the name of the tool or the glyph of the tool in the title. These preferences were ported to phabricator. These preferences can be modified in /preferences/ and they both affect diffusion and differential at the moment. Test Plan: * Created an empty database * Loaded /preferences/ and modified the monospaced font and clicked save * Confirmed that the same page was loaded with the message that preferences have been saved and that the example text used the user defined font * in /preferences/ changed the option to show tool names as plain text and clicked save * Confirmed that the same page was loaded with '[Preferences]' in the title instead of a glyph * These same tests were also executed for differential and diffusion Reviewers: epriestley CC: jungejason Differential Revision: 91
2011-03-31 04:21:09 +02:00
'PhabricatorUserPreferences' => 'applications/people/storage/preferences',
Slightly more sophisticated profiles. Summary: Test Plan: Reviewers: CC:
2011-02-20 03:28:41 +01:00
'PhabricatorUserProfile' => 'applications/people/storage/profile',
Unify profile and avatar images, move profile editing into settings Summary: See T266. Combine these interfaces into one and move it to settings. Test Plan: Edited my profile and account. Reviewers: codeblock, tcook, jungejason, tuomaspelkonen, aran CC: Differential Revision: 722
2011-07-25 00:03:59 +02:00
'PhabricatorUserProfileSettingsPanelController' => 'applications/people/controller/settings/panels/profile',
Allow users to associate SSH Public Keys with their accounts Summary: With the sshd-vcs thing I hacked together, this will enable Phabricator to host repositories without requiring users to have SSH accounts. I also fixed "subporjects" and added an explicit ENGINE to it. Test Plan: Created, edited and deleted public keys. Attempted to add the same public key twice. Attempted to add invalid and unnamed public keys. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran, cadamo, codeblock CC: aran, epriestley Differential Revision: 711
2011-07-22 19:17:57 +02:00
'PhabricatorUserSSHKey' => 'applications/people/storage/usersshkey',
'PhabricatorUserSSHKeysSettingsPanelController' => 'applications/people/controller/settings/panels/sshkeys',
Some acutal conduit authentication.
2011-02-06 07:36:21 +01:00
'PhabricatorUserSettingsController' => 'applications/people/controller/settings',
Refactor user settings Summary: I want to do two things here: - Add SSH Keys - Move "Preferences" into this panel But this controller was pretty gigantic and messy. Split it apart and use delegation instead. There are no functional changes. I changed some of the conduit certificate text to simplify it since no one should need to go through that workflow anymore, given the existence of "arc install-certificate". Test Plan: - Edited realname, including attempting to remove it. - Edited profile picture. - Edited timezone. - Edited email, including attempting to remove it. - Regenerated condiut certificate. - Linked and unlinked an OAuth account. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 688
2011-07-18 17:02:00 +02:00
'PhabricatorUserSettingsPanelController' => 'applications/people/controller/settings/panels/base',
Unify logic for username validation Summary: Revisit of D1254. Don't require lowercase, just standardize the logic. The current implementation has nonuniform logic -- PeopleEditController forbids uppercase. Test Plan: Ran unit tests, see also D1254. Reviewers: btrahan, jungejason, aran Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D1415
2012-01-16 16:30:28 +01:00
'PhabricatorUserTestCase' => 'applications/people/storage/user/__tests__',
Rough cut of Workers Summary: workers do work, provided I have written them correctly. perhaps it is so. Test Plan: Reviewers: CC:
2011-03-10 22:48:29 +01:00
'PhabricatorWorker' => 'infrastructure/daemon/workers/worker',
'PhabricatorWorkerDAO' => 'infrastructure/daemon/workers/storage/base',
'PhabricatorWorkerTask' => 'infrastructure/daemon/workers/storage/task',
'PhabricatorWorkerTaskData' => 'infrastructure/daemon/workers/storage/taskdata',
Improve daemon console.
2011-03-27 07:55:18 +02:00
'PhabricatorWorkerTaskDetailController' => 'applications/daemon/controller/workertaskdetail',
Add buttons to delete or free tasks from the queue Summary: See T709. I also ran into a case in Drydock where this is useful for testing/development. Test Plan: Freed lease of a task; deleted a task. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T709 Differential Revision: https://secure.phabricator.com/D1469
2012-01-24 01:36:32 +01:00
'PhabricatorWorkerTaskUpdateController' => 'applications/daemon/controller/workertaskupdate',
xhpastview
2011-04-07 04:17:05 +02:00
'PhabricatorXHPASTViewController' => 'applications/xhpastview/controller/base',
'PhabricatorXHPASTViewDAO' => 'applications/xhpastview/storage/base',
'PhabricatorXHPASTViewFrameController' => 'applications/xhpastview/controller/viewframe',
'PhabricatorXHPASTViewFramesetController' => 'applications/xhpastview/controller/viewframeset',
'PhabricatorXHPASTViewInputController' => 'applications/xhpastview/controller/viewinput',
'PhabricatorXHPASTViewPanelController' => 'applications/xhpastview/controller/viewpanel',
'PhabricatorXHPASTViewParseTree' => 'applications/xhpastview/storage/parsetree',
'PhabricatorXHPASTViewRunController' => 'applications/xhpastview/controller/run',
'PhabricatorXHPASTViewStreamController' => 'applications/xhpastview/controller/viewstream',
'PhabricatorXHPASTViewTreeController' => 'applications/xhpastview/controller/viewtree',
Very rough cut of DarkConsole + XHProf
2011-02-02 22:48:52 +01:00
'PhabricatorXHProfController' => 'applications/xhprof/controller/base',
'PhabricatorXHProfProfileController' => 'applications/xhprof/controller/profile',
'PhabricatorXHProfProfileSymbolView' => 'applications/xhprof/view/symbol',
'PhabricatorXHProfProfileTopLevelView' => 'applications/xhprof/view/toplevel',
Publish Phriction edits to feed Summary: Basic integration between Phriction and feed. Test Plan: Created and edited some documents, they published to feed. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, hsb Differential Revision: 653
2011-07-12 16:23:04 +02:00
'PhrictionActionConstants' => 'applications/phriction/constants/action',
Allow Phriction documents to be deleted Summary: - Add a "delete" operation. Delete is just a special edit which removes the page from indexes and shows a notice that the document has been deleted. - When a user deletes all the content on a page, treat it as a delete. - When a conduit call deletes all the content on a page, treat it as a delete. - Add page status to Conduit. - Add change type field to history. - Added a couple of constants to support a future 'move' change, which would move content from one document to another. Test Plan: - Verified deleted pages vanish from the document index (and restoring them puts them back). - Verified deleted pages show "This page has been deleted...". - Created, edited and deleted a document via Conduit. - Deleted pages via "delete" button. - Deleted pages via editing content to nothing. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: skrul, aran, btrahan, epriestley Maniphest Tasks: T680 Differential Revision: 1230
2011-12-17 18:19:08 +01:00
'PhrictionChangeType' => 'applications/phriction/constants/changetype',
Publish Phriction edits to feed Summary: Basic integration between Phriction and feed. Test Plan: Created and edited some documents, they published to feed. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, hsb Differential Revision: 653
2011-07-12 16:23:04 +02:00
'PhrictionConstants' => 'applications/phriction/constants/base',
Basic edit/create workflow for Phriction Summary: This is another chunk of D636, I just simplified it a bit and added slugs. When you go to a page like /w/pokemon/, it allows you to create or edit the page. Title vs slug stuff is a little funky but I think mostly-reasonable. Test Plan: Created and edited /w/, /w/pokemon/, etc. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, aran, tuomaspelkonen CC: aran, hsb Differential Revision: 643
2011-07-11 21:34:53 +02:00
'PhrictionContent' => 'applications/phriction/storage/content',
Phriction basics Summary: Basically a copy/paste of parts of D636, but with two changes: - Fully separate the index table ("document") from the content table ("content"). I think this will be a cleaner solution in the long run. - Build slugs into the document structure. This doesn't do anything useful, it just normalizes slugs and lays some groundwork. Test Plan: - Visited various /w/ pages and saw them normalize correctly. - Verified the DAO works by inserting dummy rows. Reviewed By: codeblock Reviewers: hsb, codeblock, jungejason, aran, tuomaspelkonen CC: aran, codeblock, epriestley Differential Revision: 638
2011-07-11 17:54:22 +02:00
'PhrictionController' => 'applications/phriction/controller/base',
'PhrictionDAO' => 'applications/phriction/storage/base',
Allow Phriction documents to be deleted Summary: - Add a "delete" operation. Delete is just a special edit which removes the page from indexes and shows a notice that the document has been deleted. - When a user deletes all the content on a page, treat it as a delete. - When a conduit call deletes all the content on a page, treat it as a delete. - Add page status to Conduit. - Add change type field to history. - Added a couple of constants to support a future 'move' change, which would move content from one document to another. Test Plan: - Verified deleted pages vanish from the document index (and restoring them puts them back). - Verified deleted pages show "This page has been deleted...". - Created, edited and deleted a document via Conduit. - Deleted pages via "delete" button. - Deleted pages via editing content to nothing. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: skrul, aran, btrahan, epriestley Maniphest Tasks: T680 Differential Revision: 1230
2011-12-17 18:19:08 +01:00
'PhrictionDeleteController' => 'applications/phriction/controller/delete',
Show change diffs in Phriction Summary: This is really rough and needs work (particularly, there's some diff code I really need to refactor since I sort-of-copy-pasted it) but basically functional. Show text changes between diffs and allow users to revert to earlier versions. Differential's line-oriented diff style isn't ideal for large blocks of text but I'm betting this is probably good enough in most cases. We can see how bad it is in practice and then fix it if needbe. I added a bunch of support for "description" but didn't add the feature in this diff, I'll either follow up or task it out since it should be a pretty straightforward change. Test Plan: Looked at history for several Phriction documents, clicked "previous change" / "next change", clicked revert buttons. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen CC: aran, hsb, epriestley Differential Revision: 687
2011-07-17 20:06:02 +02:00
'PhrictionDiffController' => 'applications/phriction/controller/diff',
Phriction basics Summary: Basically a copy/paste of parts of D636, but with two changes: - Fully separate the index table ("document") from the content table ("content"). I think this will be a cleaner solution in the long run. - Build slugs into the document structure. This doesn't do anything useful, it just normalizes slugs and lays some groundwork. Test Plan: - Visited various /w/ pages and saw them normalize correctly. - Verified the DAO works by inserting dummy rows. Reviewed By: codeblock Reviewers: hsb, codeblock, jungejason, aran, tuomaspelkonen CC: aran, codeblock, epriestley Differential Revision: 638
2011-07-11 17:54:22 +02:00
'PhrictionDocument' => 'applications/phriction/storage/document',
'PhrictionDocumentController' => 'applications/phriction/controller/document',
Provide access to Phriction via Conduit Summary: Provide three Phriction methods for programmatic access to Phriction: - phriction.info: get information about a document - phriction.history: get change history for a document - phriction.edit: create or update a document I moved all the editing/creation logic into a new PhrictionDocumentEditor to share code between the Conduit and Web edit pathways. Test Plan: Got info and history via conduit. Edited and created new pages via conduit and web. Reviewers: hsb, jungejason, tuomaspelkonen, aran, hunterbridges Reviewed By: hunterbridges CC: skrul, aran, hunterbridges Differential Revision: 866
2011-08-26 21:50:28 +02:00
'PhrictionDocumentEditor' => 'applications/phriction/editor/document',
Add a document preview to Phriction Summary: Preview Phriction documents as they are edited, similar to how Differential/Maniphest work. Test Plan: Mashed my keyboard while editing a Phriction document. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, hsb Differential Revision: 684
2011-07-17 03:25:45 +02:00
'PhrictionDocumentPreviewController' => 'applications/phriction/controller/documentpreview',
Allow Phriction documents to be deleted Summary: - Add a "delete" operation. Delete is just a special edit which removes the page from indexes and shows a notice that the document has been deleted. - When a user deletes all the content on a page, treat it as a delete. - When a conduit call deletes all the content on a page, treat it as a delete. - Add page status to Conduit. - Add change type field to history. - Added a couple of constants to support a future 'move' change, which would move content from one document to another. Test Plan: - Verified deleted pages vanish from the document index (and restoring them puts them back). - Verified deleted pages show "This page has been deleted...". - Created, edited and deleted a document via Conduit. - Deleted pages via "delete" button. - Deleted pages via editing content to nothing. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: skrul, aran, btrahan, epriestley Maniphest Tasks: T680 Differential Revision: 1230
2011-12-17 18:19:08 +01:00
'PhrictionDocumentStatus' => 'applications/phriction/constants/documentstatus',
Add hierarchical breadcrumbs to Phriction Summary: Show ancestor pages when viewing a page in Phriction. Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-042368dbadaa8ab826ec/ Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran Commenters: aran CC: aran, hsb, epriestley Differential Revision: 654
2011-07-12 17:08:03 +02:00
'PhrictionDocumentTestCase' => 'applications/phriction/storage/document/__tests__',
Basic edit/create workflow for Phriction Summary: This is another chunk of D636, I just simplified it a bit and added slugs. When you go to a page like /w/pokemon/, it allows you to create or edit the page. Title vs slug stuff is a little funky but I think mostly-reasonable. Test Plan: Created and edited /w/, /w/pokemon/, etc. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, aran, tuomaspelkonen CC: aran, hsb Differential Revision: 643
2011-07-11 21:34:53 +02:00
'PhrictionEditController' => 'applications/phriction/controller/edit',
Very basic Phriction history view Summary: Provide a (mostly useless, currently) table of document edits. Test Plan: Looked at document history for several of my high-quality sandbox wiki pages. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, aran, tuomaspelkonen CC: aran, hsb Differential Revision: 644
2011-07-12 00:06:19 +02:00
'PhrictionHistoryController' => 'applications/phriction/controller/history',
Basic Phriction list view Summary: Pretty much ripped from D636, but somewhat simplified. Lists all the documents in the system. Test Plan: Looked at both of the views, seems to work correctly. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, hsb, epriestley Differential Revision: 645
2011-07-12 00:42:12 +02:00
'PhrictionListController' => 'applications/phriction/controller/list',
Fix qsprintf() '%nd' conversion Summary: I broke this a little bit in my overzealous D1174, since this block validates both '%nd' (nullable integer) and '%d' (non-nullable integer). Clean up the conditional checks so we catch the bad case ('%d' on a PHID converting to 0) but let the good case ('%nd' with null) through. Test Plan: Unit tests failed; applied patch; unit tests pass. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T670 Differential Revision: 1201
2011-12-14 02:34:41 +01:00
'QueryFormattingTestCase' => 'storage/qsprintf/__tests__',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
),
'function' =>
array(
Improve time localization code Summary: - We throw on a missing date right now, in the DateTime constructor. This can happen in reasonable cases and this is display code, so handle it more gracefully (see T520). - This stuff is a little slow and we sometimes render many hundreds of dates per page. I've been seeing it in profiles on and off. Memoize timezones to improve performance. - Some minor code duplication that would have become less-minor with the constructor change, consolidate the logic. - Add some unit tests and a little documentation. Test Plan: - Ran unit tests. - Profiled 1,000 calls to phabricator_datetime(), cost dropped from ~49ms to ~19ms with addition of memoization. This is still slower than I'd like but I don't think there's an easy way to squeeze it down further. Reviewers: ajtrichards, jungejason, nh, tuomaspelkonen, aran Reviewed By: ajtrichards CC: aran, ajtrichards, epriestley Differential Revision: 966
2011-09-27 18:03:55 +02:00
'__phabricator_format_local_time' => 'view/utils',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'_qsprintf_check_scalar_type' => 'storage/qsprintf',
'_qsprintf_check_type' => 'storage/qsprintf',
PhabricatorEnv 'infratructure' -> 'infrastructure' (rofl) Recaptcha Email Login / Forgot Password Password Reset
2011-01-31 20:55:26 +01:00
'celerity_generate_unique_node_id' => 'infrastructure/celerity/api',
'celerity_register_resource_map' => 'infrastructure/celerity/map',
'javelin_render_tag' => 'infrastructure/javelin/markup',
Add timezone support Summary: Allows user-configurable timezones. Adds a preference panel, and migrates to the new date rendering in easily-modified areas of the code. ***In progress***. Test Plan: Check database to make sure the field is being changed when the settings are changed; check affected views to see how they render times. Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley, toulouse Differential Revision: 475
2011-06-18 22:07:02 +02:00
'phabricator_date' => 'view/utils',
'phabricator_datetime' => 'view/utils',
Clean up the revision list view a bit.
2011-01-31 03:24:57 +01:00
'phabricator_format_relative_time' => 'view/utils',
'phabricator_format_units_generic' => 'view/utils',
Rought cut of search. Summary: Botched this pretty badly in git so we'll see how much I broke. :/ Test Plan: Reviewers: CC:
2011-02-15 00:34:20 +01:00
'phabricator_render_form' => 'infrastructure/javelin/markup',
Add timezone support Summary: Allows user-configurable timezones. Adds a preference panel, and migrates to the new date rendering in easily-modified areas of the code. ***In progress***. Test Plan: Check database to make sure the field is being changed when the settings are changed; check affected views to see how they render times. Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley, toulouse Differential Revision: 475
2011-06-18 22:07:02 +02:00
'phabricator_time' => 'view/utils',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'qsprintf' => 'storage/qsprintf',
'queryfx' => 'storage/queryfx',
'queryfx_all' => 'storage/queryfx',
'queryfx_one' => 'storage/queryfx',
PhabricatorEnv 'infratructure' -> 'infrastructure' (rofl) Recaptcha Email Login / Forgot Password Password Reset
2011-01-31 20:55:26 +01:00
'require_celerity_resource' => 'infrastructure/celerity/api',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'vqsprintf' => 'storage/qsprintf',
'vqueryfx' => 'storage/queryfx',
DifferentialRevisionList
2011-01-27 20:35:04 +01:00
'vqueryfx_all' => 'storage/queryfx',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'xsprintf_query' => 'storage/qsprintf',
),
'requires_class' =>
array(
Allow Celerity to return "304 Not Modified" responses Summary: We always return HTTP 200 right now and don't send a "Last-Modified" header, so browsers download more data then necessary if you sit on a page mashing reload (for example). Test Plan: Used Charles to verify HTTP response codes from 400, 404 and 304 responses. Mashed reload a bunch and saw that the server sent back 304s. Changed the resource hash seed and saw 200s, then 304s on reload. Reviewed By: tuomaspelkonen Reviewers: tuomaspelkonen, jungejason, aran CC: bmaurer, aran, tuomaspelkonen Differential Revision: 253
2011-05-09 10:10:40 +02:00
'Aphront304Response' => 'AphrontResponse',
Write pathway for Differential Comments
2011-01-30 21:08:40 +01:00
'Aphront400Response' => 'AphrontResponse',
Send 403 for admin pages without being admin Summary: I've also moved the response generation for 404 from ##AphrontDefaultApplicationConfiguration## to ##buildResponseString()## Test Plan: Visit / Visit /mail/ Visit /x/ Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley, vrana Differential Revision: https://secure.phabricator.com/D1406
2012-01-15 10:07:56 +01:00
'Aphront403Response' => 'AphrontWebpageResponse',
'Aphront404Response' => 'AphrontWebpageResponse',
Javelin integration.
2011-01-25 20:57:47 +01:00
'AphrontAjaxResponse' => 'AphrontResponse',
Improve drag-and-drop uploader Summary: Make it discoverable, show uploading progress, show file thumbnails, allow you to remove files, make it a generic form component. Test Plan: Uploaded ducks Reviewed By: tomo Reviewers: aran, tomo, jungejason, tuomaspelkonen CC: anjali, aran, epriestley, tomo Differential Revision: 334
2011-05-23 01:11:41 +02:00
'AphrontAttachedFileView' => 'AphrontView',
Fix conservative CSRF token cycling limit Summary: We currently cycle CSRF tokens every hour and check for the last two valid ones. This means that a form could go stale in as little as an hour, and is certainly stale after two. When a stale form is submitted, you basically get a terrible heisen-state where some of your data might persist if you're lucky but more likely it all just vanishes. The .js file below outlines some more details. This is a pretty terrible UX and we don't need to be as conservative about CSRF validation as we're being. Remedy this problem by: - Accepting the last 6 CSRF tokens instead of the last 1 (i.e., pages are valid for at least 6 hours, and for as long as 7). - Using JS to refresh the CSRF token every 55 minutes (i.e., pages connected to the internet are valid indefinitely). - Showing the user an explicit message about what went wrong when CSRF validation fails so the experience is less bewildering. They should now only be able to submit with a bad CSRF token if: - They load a page, disconnect from the internet for 7 hours, reconnect, and submit the form within 55 minutes; or - They are actually the victim of a CSRF attack. We could eventually fix the first one by tracking reconnects, which might be "free" once the notification server gets built. It will probably never be an issue in practice. Test Plan: - Reduced CSRF cycle frequency to 2 seconds, submitted a form after 15 seconds, got the CSRF exception. - Reduced csrf-refresh cycle frequency to 3 seconds, submitted a form after 15 seconds, got a clean form post. - Added debugging code the the csrf refresh to make sure it was doing sensible things (pulling different tokens, finding all the inputs). Reviewed By: aran Reviewers: tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 660
2011-07-13 23:05:18 +02:00
'AphrontCSRFException' => 'AphrontException',
Build a basic calendar view Summary: This is a very small step toward building a Status and possibly an Oncall tool. Build a calendar view which renders months. Much of my hesitance to bang these tools out is that dealing with dates/calendaring is basically horrible, so I'm trying to ease into it. This calendar is locale-aware and all that jazz. Test Plan: - See: https://secure.phabricator.com/file/view/PHID-FILE-c07a9c663a7d040d2529/ - Verified that months have the right number of days, today is the right day of the week, months begin on the day after previous months end on, etc. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran Commenters: cwbeck, jungejason CC: blair, aran, epriestley, cwbeck, jungejason Differential Revision: 791
2011-08-08 03:26:31 +02:00
'AphrontCalendarMonthView' => 'AphrontView',
Tweak style on "Create Another Task" button Summary: Not totally sure I'm in love with this but I think it's somewhat non-terrible, despite the lack of lens flare. Also made "Cancel" take you back to the task if you got to "Create" from "Create Another Task". Test Plan: - Style: https://secure.phabricator.com/file/view/PHID-FILE-ad37d3c1f3b2c7a7a7d1/ - Hit "Cancel" from "Create Another", got sent back to task. - Hit "Cancel" from normal create, got sent back to list. - Tried to save an invalid task after making changes to CC/Projects, changes were preserved. Reviewed By: codeblock Reviewers: hunterbridges, jungejason, tuomaspelkonen, aran, codeblock CC: aran, epriestley, codeblock Differential Revision: 736
2011-07-27 19:46:22 +02:00
'AphrontContextBarView' => 'AphrontView',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'AphrontCrumbsView' => 'AphrontView',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontDefaultApplicationConfiguration' => 'AphrontApplicationConfiguration',
'AphrontDefaultApplicationController' => 'AphrontController',
'AphrontDialogResponse' => 'AphrontResponse',
'AphrontDialogView' => 'AphrontView',
'AphrontErrorView' => 'AphrontView',
Improve file preview in Maniphest Summary: Show large thumbnails of attached files in Maniphest. Test Plan: Looked at large thumbnails in Maniphest. Reviewed By: jungejason Reviewers: tomo, aran, jungejason, tuomaspelkonen CC: anjali, aran, epriestley, jungejason Differential Revision: 335
2011-05-23 02:06:42 +02:00
'AphrontFilePreviewView' => 'AphrontView',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'AphrontFileResponse' => 'AphrontResponse',
MetaMTA
2011-01-26 02:40:21 +01:00
'AphrontFormCheckboxControl' => 'AphrontFormControl',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontFormControl' => 'AphrontView',
Various fixes, particularly on the revision update workflow.
2011-02-05 02:53:14 +01:00
'AphrontFormDividerControl' => 'AphrontFormControl',
Improve drag-and-drop uploader Summary: Make it discoverable, show uploading progress, show file thumbnails, allow you to remove files, make it a generic form component. Test Plan: Uploaded ducks Reviewed By: tomo Reviewers: aran, tomo, jungejason, tuomaspelkonen CC: anjali, aran, epriestley, tomo Differential Revision: 334
2011-05-23 01:11:41 +02:00
'AphrontFormDragAndDropUploadControl' => 'AphrontFormControl',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'AphrontFormFileControl' => 'AphrontFormControl',
Allow projects to be quickly added from the Maniphest task creation interface Summary: Provide a quick workflow for adding a new project. This ended up being sort of complicated because we don't currently put forms in dialogs. I separated the actual <form /> tag out of the display/layout of AphrontFormView to enable this (the dialog is itself a form). Limitations: if you create a new project and then remove it, it won't appear in the tokenizer until you reload the page. We need to add the ability for the datasource to drop its cache to enable this, which is super complicated. Test Plan: Used "Create new project" to add a new project when creating a task. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: anjali, aran, epriestley Differential Revision: 422
2011-06-10 00:28:29 +02:00
'AphrontFormLayoutView' => 'AphrontView',
Conduit: user.find
2011-01-24 20:36:53 +01:00
'AphrontFormMarkupControl' => 'AphrontFormControl',
PhabricatorEnv 'infratructure' -> 'infrastructure' (rofl) Recaptcha Email Login / Forgot Password Password Reset
2011-01-31 20:55:26 +01:00
'AphrontFormPasswordControl' => 'AphrontFormControl',
'AphrontFormRecaptchaControl' => 'AphrontFormControl',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontFormSelectControl' => 'AphrontFormControl',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'AphrontFormStaticControl' => 'AphrontFormControl',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontFormSubmitControl' => 'AphrontFormControl',
'AphrontFormTextAreaControl' => 'AphrontFormControl',
'AphrontFormTextControl' => 'AphrontFormControl',
AphrontListFilterView, for list filtering.
2011-04-04 00:50:06 +02:00
'AphrontFormToggleButtonsControl' => 'AphrontFormControl',
Typeaheads
2011-01-25 22:48:05 +01:00
'AphrontFormTokenizerControl' => 'AphrontFormControl',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontFormView' => 'AphrontView',
Unify headsup action lists. Summary: Test Plan: Reviewers: CC:
2011-02-20 21:50:28 +01:00
'AphrontHeadsupActionListView' => 'AphrontView',
'AphrontHeadsupActionView' => 'AphrontView',
Provide an "isolated" database connection for testing Summary: This provides a new connection which doesn't connect to anything, so effects can be isolated to the current process (for unit testing). Test Plan: Ran unit tests. Reviewed By: aran Reviewers: aran, tuomaspelkonen, jungejason CC: aran, epriestley Differential Revision: 193
2011-04-30 19:11:41 +02:00
'AphrontIsolatedDatabaseConnection' => 'AphrontDatabaseConnection',
'AphrontIsolatedDatabaseConnectionTestCase' => 'PhabricatorTestCase',
Examples using JX.View Summary: Provide a dirt-simple working example of client-side templating and reactive programming. Test Plan: Load the examples Reviewers: epriestley, mroch, tomo Reviewed By: epriestley CC: ide, schrockn, aran, rzadorozny, epriestley Differential Revision: 908
2011-09-07 23:01:13 +02:00
'AphrontJavelinView' => 'AphrontView',
Provide basic keyboard navigation support for Differential. Summary: ReviewBoard has a fancier version of this feature that's more granular -- the keyboard can focus on individual changes. I think that's good and intend to implement something similar, but this gets us a step closer and gets rid of some of the bookkeeping stuff like making shortcuts discoverable. (I have another brnach with Maniphest merging which also uses fatcow icons, which is why the README seems a little out of context.) Test Plan: Used "j" and "k" to jump between changesets. Pressed "?" and got a list of available shortcuts. Reviewed By: tuomaspelkonen Reviewers: aran, jungejason, tuomaspelkonen CC: moskov, aran, epriestley, tuomaspelkonen Differential Revision: 412
2011-06-08 20:53:10 +02:00
'AphrontKeyboardShortcutsAvailableView' => 'AphrontView',
AphrontListFilterView, for list filtering.
2011-04-04 00:50:06 +02:00
'AphrontListFilterView' => 'AphrontView',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontMySQLDatabaseConnection' => 'AphrontDatabaseConnection',
'AphrontNullView' => 'AphrontView',
'AphrontPageView' => 'AphrontView',
AphrontPagerView and UIExamples.
2011-04-01 02:06:33 +02:00
'AphrontPagerView' => 'AphrontView',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontPanelView' => 'AphrontView',
Improve error message for Conduit path problems Summary: A few people in IRC have been having issues here recently. If you misconfigure the IRC bot, e.g., you get a 200 response back with a bunch of login HTML in it. This is unhelpful. Try to detect that a conduit request is going to the wrong path and raise a concise, explicit error which is comprehensible from the CLI. Also created a "PlainText" response and moved the IE nosniff header to the base response object. Test Plan: As a logged-out user, hit various nonsense with "?__conduit__=true" in the URI. Got good error messages. Hit nonsense without it, got login screens. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T775 Differential Revision: https://secure.phabricator.com/D1407
2012-01-15 20:06:13 +01:00
'AphrontPlainTextResponse' => 'AphrontResponse',
Improve schema upgrade workflow for unprivileged users Summary: In a basically reasonable configuration where you connect with a non-privileged user from the web workflow, upgrade_schema.php won't have enough privileges. Allow the user to override the normal auth with -u and -p. Test Plan: Tried to do a schema upgrade with an underprivileged user, got a useful error message instead of garbage. Reviewed By: Girish Reviewers: Girish, davidrecordon, jungejason, tuomaspelkonen, aran CC: aran, epriestley, Girish Differential Revision: 191
2011-04-30 09:18:13 +02:00
'AphrontQueryAccessDeniedException' => 'AphrontQueryRecoverableException',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontQueryConnectionException' => 'AphrontQueryException',
'AphrontQueryConnectionLostException' => 'AphrontQueryRecoverableException',
'AphrontQueryCountException' => 'AphrontQueryException',
Basic Facebook OAuth implementation.
2011-01-31 06:28:45 +01:00
'AphrontQueryDuplicateKeyException' => 'AphrontQueryException',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontQueryObjectMissingException' => 'AphrontQueryException',
'AphrontQueryParameterException' => 'AphrontQueryException',
'AphrontQueryRecoverableException' => 'AphrontQueryException',
Authentication
2011-01-26 22:21:12 +01:00
'AphrontRedirectException' => 'AphrontException',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontRedirectResponse' => 'AphrontResponse',
Allow revisions to be edited from Maniphest Summary: You can currently attach tasks to revisions from Differential, but not revisions to tasks from Maniphest. Allow editing from either side. This logic is kind of tricky but the alternative was massive code duplication. Test Plan: Added and removed revisions from maniphest. Added and removed tasks from differential. This should have no impact on the Facebook install since none of this is used there. Reviewed By: aran Reviewers: tomo, tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 288
2011-05-16 20:43:39 +02:00
'AphrontReloadResponse' => 'AphrontRedirectResponse',
Make 404 page somewhat prettier.
2011-01-30 18:15:01 +01:00
'AphrontRequestFailureView' => 'AphrontView',
Add getStrList() to AphrontRequest Summary: - We have a few places where we do some kind of ad-hoc comma list tokenizing, and I'm adding another one in D1290. Add a helper to the request object. - Add some unit tests. Test Plan: - Ran unit tests. - Used PHID manager, Maniphest custom view, and Repository project editor. Reviewers: btrahan, fratrik, jungejason Reviewed By: btrahan CC: aran, btrahan, epriestley Differential Revision: https://secure.phabricator.com/D1302
2012-01-04 06:57:45 +01:00
'AphrontRequestTestCase' => 'PhabricatorTestCase',
Take the first step on the long journey of fixing "Projects" Summary: - Allow more than the 100 most recent projects to be viewed. - Provide some useful filters. - Default the view to your projects, not all projects. - Put query logic in a query object. - Put filter view logic in a view object. We can port more stuff to it later. Test Plan: Looked at active/owned/all projects. Set page size to 5 and paged through projects. Reviewers: btrahan, jungejason, zeeg Reviewed By: btrahan CC: aran, btrahan Differential Revision: 1227
2011-12-17 02:08:18 +01:00
'AphrontSideNavFilterView' => 'AphrontView',
Conduit server-side basics.
2011-01-24 18:00:29 +01:00
'AphrontSideNavView' => 'AphrontView',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontTableView' => 'AphrontView',
Some herald improvements.
2011-03-23 04:41:02 +01:00
'AphrontTokenizerTemplateView' => 'AphrontView',
Some owners read workflows.
2011-04-04 04:20:47 +02:00
'AphrontTypeaheadTemplateView' => 'AphrontView',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
'AphrontWebpageResponse' => 'AphrontResponse',
Celerity, a Haste-style static resource management system.
2011-01-25 18:59:31 +01:00
'CelerityResourceController' => 'AphrontController',
Add cycle detection to celerity mapper Summary: create CelerityResourceGraph, which extends AbstractDirectedGraph. since we've done a bunch of work already to load the resource graph into memory CelerityResourceGraph simply stores a copy and makes loadEdges work off that stored copy. Test Plan: made phabricator-prefab require herald-rule-editor ~/code/phabricator> ./scripts/celerity_mapper.php webroot Finding static resources... Processing 154 files.......................................................................................................................................................... [2011-11-22 11:28:29] EXCEPTION: (Exception) Cycle detected in resource graph: phabricator-prefab => herald-rule-editor => phabricator-prefab at [/Users/btrahan/Dropbox/code/phabricator/scripts/celerity_mapper.php:173] fixed phabricator-prefab requiring herald-rule-editor. re-ran celerity_mapper and no errors! Reviewers: epriestley Reviewed By: epriestley CC: aran, btrahan, epriestley Differential Revision: 1132
2011-11-22 20:36:57 +01:00
'CelerityResourceGraph' => 'AbstractDirectedGraph',
Add an "arcanist.projectinfo" Conduit call Summary: We currently rely on "remote_hooks_enabled" in .arcconfig to determine whether commands like "arc amend" and "arc merge" should imply "arc mark-committed". However, this is a historical artifact that is now bad for a bunch of reasons: - The option name is confusing, it really means 'repository is tracked'. - The option is hard to discover and generally sucks. - We can empirically determine the right answer since we now know if a project is in a tracked repository. Add a call which arcanist can make on these workflows to figure out if it is interacting with a project in a tracked repository or not. Also added an "isTracked()" convenience method to reduce the number of magic strings all over the place. Test Plan: Ran "arcanist.projectinfo" for nonexistent, untracked and tracked projects. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, epriestley, Makinde Differential Revision: 945
2011-09-16 20:42:45 +02:00
'ConduitAPI_arcanist_Method' => 'ConduitAPIMethod',
'ConduitAPI_arcanist_projectinfo_Method' => 'ConduitAPI_arcanist_Method',
Conduit: conduit.connect
2011-01-24 20:30:10 +01:00
'ConduitAPI_conduit_connect_Method' => 'ConduitAPIMethod',
"arc install-certificate", server-side components Summary: Provides a new workflow for making it non-horrible to install certificates. Basically you run "arc install-certificate" and then copy/paste a short token off a webpage and it does the ~/.arcrc edits for you. Test Plan: Installed certificates, used bad tokens, hit rate limiting. Reviewed By: aran Reviewers: aran, jungejason, tuomaspelkonen CC: aran Differential Revision: 460
2011-06-14 21:17:14 +02:00
'ConduitAPI_conduit_getcertificate_Method' => 'ConduitAPIMethod',
conduit.ping Summary: Test Plan: Reviewers: CC:
2011-02-19 07:36:32 +01:00
'ConduitAPI_conduit_ping_Method' => 'ConduitAPIMethod',
Diffusion/phd/console improvements.
2011-03-15 21:38:14 +01:00
'ConduitAPI_daemon_launched_Method' => 'ConduitAPIMethod',
'ConduitAPI_daemon_log_Method' => 'ConduitAPIMethod',
Add a "createcomment" method to Differential Summary: Added a new method differential.createcomment Task ID: #752014 Test Plan: I created a test diff and called this method via the conduit from a client PHP script to add comments. I confirmed that 1) the comment appeared on the revision, 2) URLs within the comment were turned into hyperlinks, and 3) Phabricator sent a notification email to the people watching the test diff. Reviewers: nh, jungejason, epriestley Reviewed By: nh CC: aran, nh Differential Revision: 1128
2011-11-18 18:16:40 +01:00
'ConduitAPI_differential_createcomment_Method' => 'ConduitAPIMethod',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'ConduitAPI_differential_creatediff_Method' => 'ConduitAPIMethod',
differential.createrevision Summary: Conduit method. Test Plan: Meta Reviewers: CC: Differential Revision: 23
2011-02-06 22:49:23 +01:00
'ConduitAPI_differential_createrevision_Method' => 'ConduitAPIMethod',
differential.find Summary: Test Plan: meta Reviewers: CC:
2011-02-06 23:43:06 +01:00
'ConduitAPI_differential_find_Method' => 'ConduitAPIMethod',
Added a conduit method for getting all the diffs for a revision. Summary: Loading all diffs for a differential revision is needed by at least perflab. Test Plan: Created a simple script that queried the conduit and made sure that it returned correct values. Reviewed By: jungejason Reviewers: jungejason CC: epriestley, jungejason Differential Revision: 155
2011-04-21 00:29:02 +02:00
'ConduitAPI_differential_getalldiffs_Method' => 'ConduitAPIMethod',
Conduit: differential.getcommitmessage Summary: Test Plan: Reviewers: CC:
2011-02-09 18:41:26 +01:00
'ConduitAPI_differential_getcommitmessage_Method' => 'ConduitAPIMethod',
differential.getcommitpaths Summary: Test Plan: Reviewers: CC:
2011-02-19 07:28:03 +01:00
'ConduitAPI_differential_getcommitpaths_Method' => 'ConduitAPIMethod',
Provide differential.getdiff, useful for 'arc patch'. Summary: Test Plan: ran 'arc patch' Reviewers: CC:
2011-02-19 07:15:28 +01:00
'ConduitAPI_differential_getdiff_Method' => 'ConduitAPIMethod',
add a getrevision conduit method Summary: Add a method to get the information about a revision, including its full list of diffs. We could add an option to just return the diff IDs if we wanted. For my use case, I need the full set of information for each diff, so fewer round trips is better. This is also how the old json.php page used to work. Test Plan: Tuomas tested it in his sandbox. Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, epriestley CC: tuomaspelkonen Differential Revision: 156
2011-04-21 01:38:16 +02:00
'ConduitAPI_differential_getrevision_Method' => 'ConduitAPIMethod',
Add author to differential.getrevisionfeedback Summary: Add the author PHID to the differential.getrevisionfeedback conduit api method Test Plan: issue differential.getrevisionfeedback query via conduit against a valid revision and verify author phid is included in results Reviewers: epriestley Reviewed By: epriestley CC: epriestley, aran, jungejason, tuomaspelkonen, jonathanhester Differential Revision: 1190
2011-12-12 20:55:55 +01:00
'ConduitAPI_differential_getrevisioncomments_Method' => 'ConduitAPIMethod',
Added a conduit method for querying revision feedback. Summary: Push tools needs information about differential revision comments. Added a method that returns the needed information. Test Plan: Tested that /intern/push/merges shows correct information. Reviewed By: jungejason Reviewers: jungejason CC: epriestley, jungejason Differential Revision: 152
2011-04-20 01:24:45 +02:00
'ConduitAPI_differential_getrevisionfeedback_Method' => 'ConduitAPIMethod',
differential.markcommitted Summary: Test Plan: Reviewers: CC:
2011-02-09 18:48:26 +01:00
'ConduitAPI_differential_markcommitted_Method' => 'ConduitAPIMethod',
differential.parsecommitmessage Test plan: meta
2011-02-06 22:42:00 +01:00
'ConduitAPI_differential_parsecommitmessage_Method' => 'ConduitAPIMethod',
Add differential.query conduit method Summary: Created a differential.query conduit method that is built on top of DifferentialRevisionQuery. I also added support for querying by author, ccs, and reviewers to DifferentialRevisionQuery, so feature parity can be brought up to match differential.find and its backing class DifferentialRevisionListData. Test Plan: Tried a few calls to the conduit call using the web interface, and got back reasonable looking data. Reviewers: epriestley, jungejason, btrahan Reviewed By: epriestley CC: aran, nh, epriestley Differential Revision: 1158
2011-12-02 01:57:06 +01:00
'ConduitAPI_differential_query_Method' => 'ConduitAPIMethod',
Conduit: differential.setdiffproperty
2011-01-24 21:07:34 +01:00
'ConduitAPI_differential_setdiffproperty_Method' => 'ConduitAPIMethod',
differential.updaterevision Summary: Test Plan: meta Reviewers: CC: Differential Revision: 24
2011-02-06 23:00:32 +01:00
'ConduitAPI_differential_updaterevision_Method' => 'ConduitAPIMethod',
Enable updating task->revision assoc Summary: add a conduit method to enable querying revisions' phid from their revision_IDs, and another one to update the task->revision assoc. Test Plan: for querying revision_phid method, tested empty, one, and two revisions in the query. For the one to update the task->revision assoc, I have another diff in facebook which verified it add and remove assoc correctly. Reviewers: tuomaspelkonen, epriestley CC: Differential Revision: 165
2011-04-22 03:47:04 +02:00
'ConduitAPI_differential_updatetaskrevisionassoc_Method' => 'ConduitAPIMethod',
Added a conduit call to update arc unit results for a postponed test. Summary: It was not possible before to update arc unit results for a postponed test. This change makes it possible. Also the number of postponed tests are shown in differential. Let me know if this looks too Facebook specific. Test Plan: Tested the conduit call manually from Conduit Console and updated test results for a diff that had 20 postponed tests. Reviewed By: jungejason Reviewers: epriestley, jungejason Commenters: epriestley CC: slawekbiel, aran, tuomaspelkonen, jungejason, epriestley Differential Revision: 416
2011-06-09 01:16:59 +02:00
'ConduitAPI_differential_updateunitresults_Method' => 'ConduitAPIMethod',
Expose symbol information over Conduit Summary: I want to add a command like "where is ArcanistUnitTestEngine" to phabot. I also want to add a symbol typeahead to Diffusion and generally finish up that feature since it's useful but only half-implemented. Consolidate the query logic and expose the data over Conduit. Test Plan: Used /symbol/ and Conduit to lookup symbols. Reviewers: btrahan, jungejason Reviewed By: jungejason CC: aran, jungejason Maniphest Tasks: T315 Differential Revision: https://secure.phabricator.com/D1260
2011-12-21 18:39:33 +01:00
'ConduitAPI_diffusion_findsymbols_Method' => 'ConduitAPIMethod',
First cut at diffusion.getcommits method
2011-04-14 01:39:08 +02:00
'ConduitAPI_diffusion_getcommits_Method' => 'ConduitAPIMethod',
diffusion.getrecentcommitsbypath Summary: Implement diffusion.getrecentcommitsbypath, a Conduit wrapper over DiffusionHistoryQuery which returns results suitable for consumption by diffusion.getcommits. Test Plan: Conduit console Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley Differential Revision: 315
2011-05-20 00:36:17 +02:00
'ConduitAPI_diffusion_getrecentcommitsbypath_Method' => 'ConduitAPIMethod',
Build basic infrastructure for an activity feed Summary: This defines an extremely basic version of an activity feed, like Facebook's news feed. It doesn't do much of interest yet. Test Plan: Published some feed stories: https://secure.phabricator.com/file/view/PHID-FILE-5061aa72105bbdc05b21/ Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran Commenters: codeblock, jungejason CC: aran, epriestley, codeblock, tuomaspelkonen, jungejason Differential Revision: 593
2011-07-05 17:35:18 +02:00
'ConduitAPI_feed_publish_Method' => 'ConduitAPIMethod',
Add file.download to Conduit Summary: This is required to make "arc patch" and "arc export" support binary changes. Test Plan: Called from web console and "arc". Reviewed By: aran Reviewers: tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 326
2011-05-21 18:53:50 +02:00
'ConduitAPI_file_download_Method' => 'ConduitAPIMethod',
Add a 'file.info' Conduit method Summary: Need this for 'arc upload' and 'arc download'. Given a file PHID or ID, provides information about it. Test Plan: - Implemented 'arc upload' and 'arc download' based on 'file.info'. - Used Conduit API console to test method. Reviewed By: codeblock Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran, codeblock, epriestley Differential Revision: 741
2011-07-29 19:00:16 +02:00
'ConduitAPI_file_info_Method' => 'ConduitAPIMethod',
Conduit server-side basics.
2011-01-24 18:00:29 +01:00
'ConduitAPI_file_upload_Method' => 'ConduitAPIMethod',
Provide a basic maniphest.createtask method via Conduit Summary: This could be a lot fancier but let's see what else we need. Also fixed some bugs with maniphest.info. Test Plan: Used the Conduit web console to create some tasks with different values. Reviewers: jungejason, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, jungejason, epriestley Differential Revision: 824
2011-08-18 00:19:48 +02:00
'ConduitAPI_maniphest_Method' => 'ConduitAPIMethod',
'ConduitAPI_maniphest_createtask_Method' => 'ConduitAPI_maniphest_Method',
Add "maniphest.find" to Conduit Summary: Execute searches like the primary Maniphest task list. Let me know what else you guys need from this API. Test Plan: Executed "maniphest.info" and "maniphest.find" Reviewers: jungejason, tuomaspelkonen, aran, nh Reviewed By: nh CC: blair, skrul, aran, jungejason, epriestley, nh, tuomaspelkonen Differential Revision: 867
2011-08-27 01:52:57 +02:00
'ConduitAPI_maniphest_find_Method' => 'ConduitAPI_maniphest_Method',
Added conduit method to get maniphest transactions Summary: Added a Conduit API method to return all transactions for a given set of task_ids. This will be used to comments and other important information about the tasks. Test Plan: Use Conduit to execute ##maniphest.gettasktransactions## and visually verify that transaction information is returned. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1361
2012-01-11 04:51:55 +01:00
'ConduitAPI_maniphest_gettasktransactions_Method' => 'ConduitAPI_maniphest_Method',
Provide a basic maniphest.createtask method via Conduit Summary: This could be a lot fancier but let's see what else we need. Also fixed some bugs with maniphest.info. Test Plan: Used the Conduit web console to create some tasks with different values. Reviewers: jungejason, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, jungejason, epriestley Differential Revision: 824
2011-08-18 00:19:48 +02:00
'ConduitAPI_maniphest_info_Method' => 'ConduitAPI_maniphest_Method',
Add a "maniphest.update" Conduit method Summary: - Add maniphest.update - Add support for auxiliary fields to maniphest.createtask Test Plan: - Created tasks with maniphest.createtask - Updated tasks with maniphest.update Reviewers: btrahan, jungejason, zeeg Reviewed By: btrahan CC: aran, btrahan Differential Revision: https://secure.phabricator.com/D1330
2012-01-06 04:02:50 +01:00
'ConduitAPI_maniphest_update_Method' => 'ConduitAPI_maniphest_Method',
Provide a paste.create Conduit method Summary: - Allow the console to handle abstract classes correctly. - Move paste dictionary generation to an abstract base class. - Add paste.create. - Add 'objectName', 'parentPHID', and 'content' to Paste info dictionaries (you can use filePHID with file.download to get the content but I think just always sending it back is reasonable). Test Plan: - Use paste.create to create new pastes. - Used paste.info to get existing pastes. - Checked console UI to make sure "paste." didn't show up or anything silly/dumb like that. - Tried to call the method "paste" and got the right exception. Reviewed By: codeblock Reviewers: codeblock, jungejason, tuomaspelkonen, aran CC: aran, codeblock Differential Revision: 747
2011-07-30 03:31:14 +02:00
'ConduitAPI_paste_Method' => 'ConduitAPIMethod',
'ConduitAPI_paste_create_Method' => 'ConduitAPI_paste_Method',
'ConduitAPI_paste_info_Method' => 'ConduitAPI_paste_Method',
Adding conduit API method to find owner for the affected file Summary: Adding method that given a path will go up the folder hierarchy until it finds the owning package and return owners for that package. Task ID: #403724 Test Plan: Tried the new API call through console on various path combinations Reviewed By: epriestley Reviewers: epriestley, dpepper, tuomaspelkonen CC: epriestley, Leon Revert Plan: n/a Tags: bootcamp, Push Efficiency - begin *PUBLIC* platform impact section - Bugzilla: # - end platform impact - Differential Revision: 126
2011-04-12 06:51:36 +02:00
'ConduitAPI_path_getowners_Method' => 'ConduitAPIMethod',
Add user.info and phid.info Conduit methods Summary: Allow user and arbitrary object lookup by PHID. Test Plan: Executed user.whoami, user.info, user.find and phid.info via Conduit console. Reviewers: jungejason, tuomaspelkonen, aran, nh Reviewed By: nh CC: skrul, aran, nh, jungejason, epriestley Differential Revision: 870
2011-08-30 21:03:58 +02:00
'ConduitAPI_phid_Method' => 'ConduitAPIMethod',
'ConduitAPI_phid_info_Method' => 'ConduitAPI_phid_Method',
Provide access to Phriction via Conduit Summary: Provide three Phriction methods for programmatic access to Phriction: - phriction.info: get information about a document - phriction.history: get change history for a document - phriction.edit: create or update a document I moved all the editing/creation logic into a new PhrictionDocumentEditor to share code between the Conduit and Web edit pathways. Test Plan: Got info and history via conduit. Edited and created new pages via conduit and web. Reviewers: hsb, jungejason, tuomaspelkonen, aran, hunterbridges Reviewed By: hunterbridges CC: skrul, aran, hunterbridges Differential Revision: 866
2011-08-26 21:50:28 +02:00
'ConduitAPI_phriction_Method' => 'ConduitAPIMethod',
'ConduitAPI_phriction_edit_Method' => 'ConduitAPI_phriction_Method',
'ConduitAPI_phriction_history_Method' => 'ConduitAPI_phriction_Method',
'ConduitAPI_phriction_info_Method' => 'ConduitAPI_phriction_Method',
Add project.query to Conduit Summary: Add a conduit method to query project information. Test Plan: Ran method from API test console. Reviewers: bill, btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T681 Differential Revision: https://secure.phabricator.com/D1444
2012-01-18 01:29:35 +01:00
'ConduitAPI_project_Method' => 'ConduitAPIMethod',
'ConduitAPI_project_query_Method' => 'ConduitAPI_project_Method',
Conduit method for slowvote.poll.info. Summary: Provides a slowvote.poll.info method. Test Plan: Web console - seemed to work fine. Reviewers: epriestley, phuzion CC: Differential Revision: 659
2011-07-13 04:18:20 +02:00
'ConduitAPI_slowvote_info_Method' => 'ConduitAPIMethod',
Add user.info and phid.info Conduit methods Summary: Allow user and arbitrary object lookup by PHID. Test Plan: Executed user.whoami, user.info, user.find and phid.info via Conduit console. Reviewers: jungejason, tuomaspelkonen, aran, nh Reviewed By: nh CC: skrul, aran, nh, jungejason, epriestley Differential Revision: 870
2011-08-30 21:03:58 +02:00
'ConduitAPI_user_Method' => 'ConduitAPIMethod',
'ConduitAPI_user_find_Method' => 'ConduitAPI_user_Method',
'ConduitAPI_user_info_Method' => 'ConduitAPI_user_Method',
'ConduitAPI_user_whoami_Method' => 'ConduitAPI_user_Method',
Add a "Config" plugin to DarkConsole. Summary: This plugin lets you see how the host is configured at runtime. Test Plan: Reviewers: CC:
2011-02-12 01:48:43 +01:00
'DarkConsoleConfigPlugin' => 'DarkConsolePlugin',
Flesh out some DarkConsole stuff.
2011-02-03 07:38:42 +01:00
'DarkConsoleController' => 'PhabricatorController',
Very rough cut of DarkConsole + XHProf
2011-02-02 22:48:52 +01:00
'DarkConsoleErrorLogPlugin' => 'DarkConsolePlugin',
Add an "Event" plugin to DarkConsole for event inspection Summary: Shows events which a page dispatched, plus all the registered listeners. Test Plan: Pretty basic for now, but works OK: https://secure.phabricator.com/file/view/PHID-FILE-49fcd23081ce55cf9369/ (I also made it dispatch some dummy events to verify they show up.) Reviewers: aran Reviewed By: aran CC: aran Differential Revision: 973
2011-09-30 21:54:17 +02:00
'DarkConsoleEventPlugin' => 'DarkConsolePlugin',
Move event framework from Phabricator to libphutil Summary: Move event framework from Phabricator to libphutil so it can be used in other phutil projects, such as Arcanist. Test plan: Use along with path to libphutil, events should work as expected. Reviewers: epriestley Differential Revision: 1098
2011-11-10 02:23:33 +01:00
'DarkConsoleEventPluginAPI' => 'PhutilEventListener',
Very rough cut of DarkConsole + XHProf
2011-02-02 22:48:52 +01:00
'DarkConsoleRequestPlugin' => 'DarkConsolePlugin',
'DarkConsoleServicesPlugin' => 'DarkConsolePlugin',
'DarkConsoleXHProfPlugin' => 'DarkConsolePlugin',
Improve behavior when user submits a no-op action in Differential Summary: See T730 and the slightly-less-pretty version of this in D1398. When a user takes an action in Differential that has no effect (for instance, accepting an already-accepted revision), prompt them: Action Has No Effect You can not accept this revision because it has already been accepted. Do you want to post the feedback anyway, as a normal comment? [Cancel] [Post as Comment] If they have no comment text, the dialog only says "Cancel". I think this is probably the best way to balance all the concerns here -- it might occasionally be a little annoying, but that should be rare, and it should never be confusing (the current workflow is extremely confusing). This also fixes the issue where you can add all sorts of CCs who are already part of the revision, either explicitly or via mentions. Test Plan: Posted some has-effect and has-no-effect comments, made different choices in the dialog, everything seems to work OK? Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, vrana Maniphest Tasks: T730 Differential Revision: https://secure.phabricator.com/D1403
2012-01-14 20:39:22 +01:00
'DifferentialActionHasNoEffectException' => 'DifferentialException',
AddCommentView
2011-01-30 20:02:22 +01:00
'DifferentialAddCommentView' => 'AphrontView',
Build an "affected path" index when attaching diffs to revisions Summary: See T262. This creates the index on the Differential side which we need in order to execute this query efficiently on the Diffusion side. Also renames "DiffusionGitPathIDQuery" to "DiffusionPathIDQuery", this query object has nothing to do with git. Test Plan: Attached top-level and sub-level diffs to revisions and verified they populated the table with sensible data. Reviewers: bmaurer, aravindn, fmoo, jungejason, nh, tuomaspelkonen, aran CC: Differential Revision: 931
2011-09-14 19:59:52 +02:00
'DifferentialAffectedPath' => 'DifferentialDAO',
Move Differential's simple fields to the extensible field schema Summary: Differential has a bunch of display-only fields, implement them all as field specifications instead of hard-coded fields. Also add some more documentation and fix redundant string constants in blame rev/revert plan fields. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 807
2011-08-14 20:29:56 +02:00
'DifferentialApplyPatchFieldSpecification' => 'DifferentialFieldSpecification',
Move Differential's read-only fields to the extensible field schema Summary: Move additional fields (which rely on loading handles) to the extensible field classes and out of hardcoding in the controller. Depends on D807. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 808
2011-08-14 21:33:54 +02:00
'DifferentialArcanistProjectFieldSpecification' => 'DifferentialFieldSpecification',
'DifferentialAuthorFieldSpecification' => 'DifferentialFieldSpecification',
Add basic auxiliary field storage for Differential Summary: Precursor to building this out to solve T343. This is similar to the Maniphest fields we landed recently, although I think they're dissimilar enough that it isn't worth going crazy trying to make them share code, at least for now. This doesn't really do anything yet, just adds a storage object and a couple of selector/field indirection classes. Test Plan: Ran SQL upgrade script, created an aux field. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 798
2011-08-10 20:29:08 +02:00
'DifferentialAuxiliaryField' => 'DifferentialDAO',
Provide builtin definitions for "Blame Revision" and "Revert Plan" fields Summary: This is just to ease transitions for any installs which use these fields (e.g., Facebook). I'll write some docs and a migration script once this stuff is a little more solid, too. Depends on D800. Technically these are "better" than the current fields since they show up other places than the edit screen (derp derp). Test Plan: Created a field selector which provides these; verified they work by typing stuff into them and saving the revision. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 801
2011-08-11 00:36:18 +02:00
'DifferentialBlameRevisionFieldSpecification' => 'DifferentialFieldSpecification',
DifferentialRevisionEditor
2011-01-26 02:17:19 +01:00
'DifferentialCCWelcomeMail' => 'DifferentialReviewRequestMail',
Move Differential's remaining field views to extensble field schema Summary: Move all the rest of the fields into the custom field schema, for revision views. I left a couple of stubs in here (willWriteRevision, didWriteRevision) since I'd planned to do edits here too, but this diff is sort of big-ish already. I'll do all the edit fields in the next revision. Depends on D808. Test Plan: Viewed, edited and conduit'ed some revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 809
2011-08-14 22:55:30 +02:00
'DifferentialCCsFieldSpecification' => 'DifferentialFieldSpecification',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'DifferentialChangeset' => 'DifferentialDAO',
DifferentialDiffView
2011-01-24 22:18:41 +01:00
'DifferentialChangesetDetailView' => 'AphrontView',
Javelin integration.
2011-01-25 20:57:47 +01:00
'DifferentialChangesetListView' => 'AphrontView',
DifferentialChangesetView
2011-01-25 00:52:35 +01:00
'DifferentialChangesetViewController' => 'DifferentialController',
Basic Differential revision feedback view.
2011-01-30 19:37:36 +01:00
'DifferentialComment' => 'DifferentialDAO',
Write pathway for Differential Comments
2011-01-30 21:08:40 +01:00
'DifferentialCommentMail' => 'DifferentialMail',
Differential comment previews.
2011-02-01 03:05:20 +01:00
'DifferentialCommentPreviewController' => 'DifferentialController',
Write pathway for Differential Comments
2011-01-30 21:08:40 +01:00
'DifferentialCommentSaveController' => 'DifferentialController',
Move Differential's read-only fields to the extensible field schema Summary: Move additional fields (which rely on loading handles) to the extensible field classes and out of hardcoding in the controller. Depends on D807. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 808
2011-08-14 21:33:54 +02:00
'DifferentialCommitsFieldSpecification' => 'DifferentialFieldSpecification',
DifferentialDiffView
2011-01-24 22:18:41 +01:00
'DifferentialController' => 'PhabricatorController',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'DifferentialDAO' => 'PhabricatorLiskDAO',
Add basic auxiliary field storage for Differential Summary: Precursor to building this out to solve T343. This is similar to the Maniphest fields we landed recently, although I think they're dissimilar enough that it isn't worth going crazy trying to make them share code, at least for now. This doesn't really do anything yet, just adds a storage object and a couple of selector/field indirection classes. Test Plan: Ran SQL upgrade script, created an aux field. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 798
2011-08-10 20:29:08 +02:00
'DifferentialDefaultFieldSelector' => 'DifferentialFieldSelector',
Move Differential's read-only fields to the extensible field schema Summary: Move additional fields (which rely on loading handles) to the extensible field classes and out of hardcoding in the controller. Depends on D807. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 808
2011-08-14 21:33:54 +02:00
'DifferentialDependenciesFieldSpecification' => 'DifferentialFieldSpecification',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'DifferentialDiff' => 'DifferentialDAO',
DifferentialRevisionEditor
2011-01-26 02:17:19 +01:00
'DifferentialDiffContentMail' => 'DifferentialMail',
Differential lazyweb diff create workflow.
2011-02-05 21:20:18 +01:00
'DifferentialDiffCreateController' => 'DifferentialController',
Conduit: differential.setdiffproperty
2011-01-24 21:07:34 +01:00
'DifferentialDiffProperty' => 'DifferentialDAO',
DifferentialDiffView
2011-01-24 22:18:41 +01:00
'DifferentialDiffTableOfContentsView' => 'AphrontView',
'DifferentialDiffViewController' => 'DifferentialController',
Add reply handler for differential revision Summary: add email reply handler so that the user can reply to a differential email to act on the revision. It generates the reply-to email address, creates email body text with supported commands list, and handle the action request on the differential revision. Right now the reply-to handing is disabled in the config file. But a site using Phabricator can enable it and implement a class inheriting from DifferentialReplyHandler to enable customized email handing. Later we will need to add code to DifferentialMail.php to support sending separate email to each email recipient to achieve better security (see D226). The reply-to will be something like D<revision_id>+<user_id>+<hash>@domain.com. We will create separate task for it. Test Plan: tried comment on a revision from web UI and the email was sent out as before without any change. When a subclass of DifferentialReplyHandler is implemented and enabled, email's reply-to is set and email text is added. Reply to the email with valid command did create action to the revision. Reviewed By: epriestley Reviewers: tuomaspelkonen, epriestley, slawekbiel, dpepper CC: aran, epriestley, jungejason Differential Revision: 224
2011-05-01 04:40:05 +02:00
'DifferentialExceptionMail' => 'DifferentialMail',
Move Differential's simple fields to the extensible field schema Summary: Differential has a bunch of display-only fields, implement them all as field specifications instead of hard-coded fields. Also add some more documentation and fix redundant string constants in blame rev/revert plan fields. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 807
2011-08-14 20:29:56 +02:00
'DifferentialExportPatchFieldSpecification' => 'DifferentialFieldSpecification',
Drive revision update from Conduit via custom fields Summary: When we create or update a revision, we use a parsed commit message dictionary to edit its fields. Drive consumption of the dictionary through custom fields instead of hardcoding. This requires adding some fields which don't really do anything right now to cover fields which appear only in the commit message. Test Plan: "arc diff"'d this revision against localhost, "arc diff"'d again to update. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 811
2011-08-15 03:52:09 +02:00
'DifferentialGitSVNIDFieldSpecification' => 'DifferentialFieldSpecification',
Move Differential's simple fields to the extensible field schema Summary: Differential has a bunch of display-only fields, implement them all as field specifications instead of hard-coded fields. Also add some more documentation and fix redundant string constants in blame rev/revert plan fields. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 807
2011-08-14 20:29:56 +02:00
'DifferentialHostFieldSpecification' => 'DifferentialFieldSpecification',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'DifferentialHunk' => 'DifferentialDAO',
Bring in JX.Workflow and the inline commenting behavior, plus sync Javelin.
2011-02-02 00:52:04 +01:00
'DifferentialInlineComment' => 'DifferentialDAO',
InlineComments
2011-02-02 01:42:36 +01:00
'DifferentialInlineCommentEditController' => 'DifferentialController',
Inline comment-related fixes.
2011-02-03 04:38:43 +01:00
'DifferentialInlineCommentPreviewController' => 'DifferentialController',
InlineComments
2011-02-02 01:42:36 +01:00
'DifferentialInlineCommentView' => 'AphrontView',
Move Differential's simple fields to the extensible field schema Summary: Differential has a bunch of display-only fields, implement them all as field specifications instead of hard-coded fields. Also add some more documentation and fix redundant string constants in blame rev/revert plan fields. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 807
2011-08-14 20:29:56 +02:00
'DifferentialLinesFieldSpecification' => 'DifferentialFieldSpecification',
Move Differential's remaining field views to extensble field schema Summary: Move all the rest of the fields into the custom field schema, for revision views. I left a couple of stubs in here (willWriteRevision, didWriteRevision) since I'd planned to do edits here too, but this diff is sort of big-ish already. I'll do all the edit fields in the next revision. Depends on D808. Test Plan: Viewed, edited and conduit'ed some revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 809
2011-08-14 22:55:30 +02:00
'DifferentialLintFieldSpecification' => 'DifferentialFieldSpecification',
Display local commit information in Differential Summary: After D857, we try to attach local commit information to revisions. If this information is available, display it on the revision. Design on this is a little rough, I might try to combine this into the revision update view or something like that since we're starting to take up a lot of real estate for metadata. Test Plan: Local diffed this and got some commit info. Reviewers: jungejason, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, epriestley, jungejason Differential Revision: 872
2011-08-30 20:34:07 +02:00
'DifferentialLocalCommitsView' => 'AphrontView',
Move Differential's read-only fields to the extensible field schema Summary: Move additional fields (which rely on loading handles) to the extensible field classes and out of hardcoding in the controller. Depends on D807. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 808
2011-08-14 21:33:54 +02:00
'DifferentialManiphestTasksFieldSpecification' => 'DifferentialFieldSpecification',
DifferentialRevisionEditor
2011-01-26 02:17:19 +01:00
'DifferentialNewDiffMail' => 'DifferentialReviewRequestMail',
Move Differential's simple fields to the extensible field schema Summary: Differential has a bunch of display-only fields, implement them all as field specifications instead of hard-coded fields. Also add some more documentation and fix redundant string constants in blame rev/revert plan fields. Test Plan: Viewed, edited, and hit conduit for revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 807
2011-08-14 20:29:56 +02:00
'DifferentialPathFieldSpecification' => 'DifferentialFieldSpecification',
Provide basic capabilities to make Differential column width flexible Summary: - Make wrap width settable in PHP. - Dynamically generate max-width based on configurable maximum width. - Constrain non-diff elements to standard width. - Provide a configuration setting. Test Plan: Set various things to 100 / 120, as far as I could tell everything seemed to render sensibly? This should have no effect on 80-col changes. Reviewed By: jdperlow Reviewers: jdperlow, tuomaspelkonen, jungejason, aran CC: aran, jdperlow Differential Revision: 413
2011-06-08 21:39:03 +02:00
'DifferentialPrimaryPaneView' => 'AphrontView',
Support email multiplexing for private Reply-To addresses Summary: Provide a base PhabricatorMailReplyHandler class which handles the plumbing for multiplexing email if necessary and supporting public and private reply handler addressses. DifferentialReplyHandler now extends it, and a new ManiphestReplyHandler also does. The general approach here is that we have three supported cases: - no reply handler, default config, same as what we're doing now - public reply handler, requires overriding classes but just sets "reply-to" to some address the install generates and still sends only one email - private reply handler, provides a default generation mechanism or you can override it and splits mail apart so we send one to each recipient Test Plan: Sent email from Maniphest and Differential with and without reply-handler-domains set. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley Differential Revision: 254
2011-05-10 01:31:26 +02:00
'DifferentialReplyHandler' => 'PhabricatorMailReplyHandler',
Provide builtin definitions for "Blame Revision" and "Revert Plan" fields Summary: This is just to ease transitions for any installs which use these fields (e.g., Facebook). I'll write some docs and a migration script once this stuff is a little more solid, too. Depends on D800. Technically these are "better" than the current fields since they show up other places than the edit screen (derp derp). Test Plan: Created a field selector which provides these; verified they work by typing stuff into them and saving the revision. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 801
2011-08-11 00:36:18 +02:00
'DifferentialRevertPlanFieldSpecification' => 'DifferentialFieldSpecification',
DifferentialRevisionEditor
2011-01-26 02:17:19 +01:00
'DifferentialReviewRequestMail' => 'DifferentialMail',
Drive revision update from Conduit via custom fields Summary: When we create or update a revision, we use a parsed commit message dictionary to edit its fields. Drive consumption of the dictionary through custom fields instead of hardcoding. This requires adding some fields which don't really do anything right now to cover fields which appear only in the commit message. Test Plan: "arc diff"'d this revision against localhost, "arc diff"'d again to update. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 811
2011-08-15 03:52:09 +02:00
'DifferentialReviewedByFieldSpecification' => 'DifferentialFieldSpecification',
Move Differential's remaining field views to extensble field schema Summary: Move all the rest of the fields into the custom field schema, for revision views. I left a couple of stubs in here (willWriteRevision, didWriteRevision) since I'd planned to do edits here too, but this diff is sort of big-ish already. I'll do all the edit fields in the next revision. Depends on D808. Test Plan: Viewed, edited and conduit'ed some revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 809
2011-08-14 22:55:30 +02:00
'DifferentialReviewersFieldSpecification' => 'DifferentialFieldSpecification',
Conduit: differential.creatediff
2011-01-24 20:01:53 +01:00
'DifferentialRevision' => 'DifferentialDAO',
Basic Differential revision feedback view.
2011-01-30 19:37:36 +01:00
'DifferentialRevisionCommentListView' => 'AphrontView',
'DifferentialRevisionCommentView' => 'AphrontView',
DifferentialRevisionView
2011-01-27 23:55:52 +01:00
'DifferentialRevisionDetailView' => 'AphrontView',
RevisionEdit
2011-01-25 22:26:09 +01:00
'DifferentialRevisionEditController' => 'DifferentialController',
Emit full URIs to identify Differential revisions Summary: - Previously, used IDs like "33" to match a commit to a Differential revision. This has a namespacing problem because we now have an arbitrarily large number of Phabricator installs in the world, and they may want to track commits from other installs. - In Differential, parse raw IDs or full URIs. Emit only full URIs. - In Repositories, parse only full URIs. - This might cause a few commits to not be picked up in rare circumstances. Users can fix them with "arc mark-committed". This should be exceedingly rare because of hash matching. - There are some caveats for reparsing older repositories, see comments inline. I don't think there's much broad impact here. Test Plan: - Created a new revision, got a full URI. - Updated revision, worked correctly. - Ran unit tests. - Monkeyed with "Differential Revision" field. - Reviewers: btrahan, jungejason Reviewers: btrahan, jungejason Reviewed By: jungejason CC: aran, epriestley, jungejason Maniphest Tasks: T54, T692 Differential Revision: 1250
2011-12-21 00:40:24 +01:00
'DifferentialRevisionIDFieldParserTestCase' => 'PhabricatorTestCase',
Drive revision update from Conduit via custom fields Summary: When we create or update a revision, we use a parsed commit message dictionary to edit its fields. Drive consumption of the dictionary through custom fields instead of hardcoding. This requires adding some fields which don't really do anything right now to cover fields which appear only in the commit message. Test Plan: "arc diff"'d this revision against localhost, "arc diff"'d again to update. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 811
2011-08-15 03:52:09 +02:00
'DifferentialRevisionIDFieldSpecification' => 'DifferentialFieldSpecification',
RevisionList
2011-01-26 00:19:06 +01:00
'DifferentialRevisionListController' => 'DifferentialController',
Separate revision list rendering logic into a RevisionListView Summary: I want to throw this in Diffusion as part of T262, but it's embedded in the controller right now. Split it out. Test Plan: Looked at various revision list views, no changes. Reviewers: jungejason, nh, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, jungejason Differential Revision: 977
2011-10-02 20:42:41 +02:00
'DifferentialRevisionListView' => 'AphrontView',
Move Differential's remaining field views to extensble field schema Summary: Move all the rest of the fields into the custom field schema, for revision views. I left a couple of stubs in here (willWriteRevision, didWriteRevision) since I'd planned to do edits here too, but this diff is sort of big-ish already. I'll do all the edit fields in the next revision. Depends on D808. Test Plan: Viewed, edited and conduit'ed some revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 809
2011-08-14 22:55:30 +02:00
'DifferentialRevisionStatusFieldSpecification' => 'DifferentialFieldSpecification',
DifferentialRevisionView
2011-01-27 23:55:52 +01:00
'DifferentialRevisionUpdateHistoryView' => 'AphrontView',
'DifferentialRevisionViewController' => 'DifferentialController',
Make subscribe/unsubscribe work properly on Revisions. Summary: Test Plan: Reviewers: CC:
2011-02-19 23:36:13 +01:00
'DifferentialSubscribeController' => 'DifferentialController',
Implement all field edit interfaces on the custom field schema Summary: Moves the revision edit controller to be completely schema-driven. Depends on D810. Test Plan: Edited revisions. Entered intentionally invalid values to trigger error conditions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 810
2011-08-14 23:28:08 +02:00
'DifferentialSummaryFieldSpecification' => 'DifferentialFieldSpecification',
'DifferentialTestPlanFieldSpecification' => 'DifferentialFieldSpecification',
'DifferentialTitleFieldSpecification' => 'DifferentialFieldSpecification',
Move Differential's remaining field views to extensble field schema Summary: Move all the rest of the fields into the custom field schema, for revision views. I left a couple of stubs in here (willWriteRevision, didWriteRevision) since I'd planned to do edits here too, but this diff is sort of big-ish already. I'll do all the edit fields in the next revision. Depends on D808. Test Plan: Viewed, edited and conduit'ed some revisions. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 809
2011-08-14 22:55:30 +02:00
'DifferentialUnitFieldSpecification' => 'DifferentialFieldSpecification',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionBranchTableView' => 'DiffusionView',
Diffusion: basic browse view Summary: Synthesizes elements of Diffusion's browse view, Confusion's git support and Phabricator's repository infrastructure to provide a basic browse view for Phabricator Diffusion. This is basically a straight port of Confusion but uses Phabricator's Repository object and uses a real data object instead of arrays. Test Plan: Browsed Javelin in Phabricator at a very basic level. Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson, epriestley Differential Revision: 58
2011-03-08 02:25:47 +01:00
'DiffusionBrowseController' => 'DiffusionController',
Diffusion: basic file browse capability Summary: Very rough cut of file browsing. Not terribly useful yet, but it does cause file data to appear in the browser window. Test Plan: viewed a file from a git repo Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson Differential Revision: 64
2011-03-08 18:54:55 +01:00
'DiffusionBrowseFileController' => 'DiffusionController',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionBrowseTableView' => 'DiffusionView',
Browse / git improvements.
2011-03-14 06:03:30 +01:00
'DiffusionChangeController' => 'DiffusionController',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionCommitChangeTableView' => 'DiffusionView',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'DiffusionCommitController' => 'DiffusionController',
Restore "author" link to diffusion Summary: create the page by getting data from the search result. Test Plan: load page with url /author/, /author/valid_username, and /uathor/invalid_username, and verified that it works as expected. Reviewed By: epriestley Reviewers: epriestley, tuomaspelkonen Commenters: tuomaspelkonen CC: hwang, aran, tuomaspelkonen, epriestley, jungejason Differential Revision: 723
2011-07-24 02:09:03 +02:00
'DiffusionCommitListController' => 'DiffusionController',
Show all branches a commit appears on Summary: We show the contextual branch (always the repository default branch) when viewing a commit. Instead, show all branches the commit appears on. Also pull some of the duplicated DiffusionXQuery stuff into a DiffusionQuery base class, I'll do a followup to reduce more duplication. Test Plan: Looked at a commit in Git. My HG and SVN setups are a little borked so I kind of faked tests in them -- I'm fixing them now. Reviewers: btrahan, jungejason, fratrik Reviewed By: btrahan CC: aran Maniphest Tasks: T768 Differential Revision: https://secure.phabricator.com/D1458
2012-01-19 20:49:51 +01:00
'DiffusionContainsQuery' => 'DiffusionQuery',
Rough version of DiffusionHomeController Summary: My strategy here is to synthesize Diffusion + Confusion (jwilson's git support for Diffusion) + Repository/Commit stuff into Phabricator and kill all birds with one stone. This probably involves the least total work since we have to do this port step anyway and a lot of the Phabricator primitives are in better shape than the trunk primitives. Test Plan: Looked at it in my sandbox, which has some parsed commits. Reviewers: jwilson, aran, jungejason CC: Differential Revision: 57
2011-03-08 00:13:36 +01:00
'DiffusionController' => 'PhabricatorController',
Rough cut of Diffusion change view.
2011-03-31 02:36:16 +02:00
'DiffusionDiffController' => 'DiffusionController',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionGitBranchQuery' => 'DiffusionBranchQuery',
Make tracked git repositories use an implicit 'origin' remote Summary: See T624. I originally wrote this to require an explicit remote, but this creates an ugly "origin:" in all the URIs and makes T270 more difficult. Treat all branch names as implying 'origin/'. Test Plan: - Pulled and imported a fresh copy of libphutil without issues. - Browsed various git repositories. - Browsed Javelin's various branches. - Ran upgrade script, got a bunch of clean 'origin/master' -> 'master' conversions. - Tried to specify an explicit remote in a default branch name. - Unit tests. Reviewers: nh, jungejason, btrahan Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T624 Differential Revision: https://secure.phabricator.com/D1269
2011-12-22 21:24:12 +01:00
'DiffusionGitBranchQueryTestCase' => 'PhabricatorTestCase',
Diffusion: basic browse view Summary: Synthesizes elements of Diffusion's browse view, Confusion's git support and Phabricator's repository infrastructure to provide a basic browse view for Phabricator Diffusion. This is basically a straight port of Confusion but uses Phabricator's Repository object and uses a real data object instead of arrays. Test Plan: Browsed Javelin in Phabricator at a very basic level. Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson, epriestley Differential Revision: 58
2011-03-08 02:25:47 +01:00
'DiffusionGitBrowseQuery' => 'DiffusionBrowseQuery',
Show all branches a commit appears on Summary: We show the contextual branch (always the repository default branch) when viewing a commit. Instead, show all branches the commit appears on. Also pull some of the duplicated DiffusionXQuery stuff into a DiffusionQuery base class, I'll do a followup to reduce more duplication. Test Plan: Looked at a commit in Git. My HG and SVN setups are a little borked so I kind of faked tests in them -- I'm fixing them now. Reviewers: btrahan, jungejason, fratrik Reviewed By: btrahan CC: aran Maniphest Tasks: T768 Differential Revision: https://secure.phabricator.com/D1458
2012-01-19 20:49:51 +01:00
'DiffusionGitContainsQuery' => 'DiffusionContainsQuery',
Basic DiffusionGitDiffQuery.
2011-03-31 03:17:36 +02:00
'DiffusionGitDiffQuery' => 'DiffusionDiffQuery',
Diffusion: basic file browse capability Summary: Very rough cut of file browsing. Not terribly useful yet, but it does cause file data to appear in the browser window. Test Plan: viewed a file from a git repo Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson Differential Revision: 64
2011-03-08 18:54:55 +01:00
'DiffusionGitFileContentQuery' => 'DiffusionFileContentQuery',
Diffusion: rough cut of history view Summary: Very very rough approximation of history view. I left out all the log parsing stuff for now since we should be able to just look it up in a Repository table and I think that'll be a bit faster, although we can muck around and see. Test Plan: Looked at history of a path Reviewed By: jwilson Reviewers: aran, jwilson CC: epriestley, jwilson Differential Revision: 66
2011-03-09 02:31:44 +01:00
'DiffusionGitHistoryQuery' => 'DiffusionHistoryQuery',
Add more change metadata to SVN and git.
2011-03-31 08:27:06 +02:00
'DiffusionGitLastModifiedQuery' => 'DiffusionLastModifiedQuery',
Diffusion: encapsulate request in DiffusionRequest Summary: Put an indirection layer between controllers and URI management, adding branches to git repositories. Test Plan: Looked at browse, history browse, file browse views, bad branches, bad commits Reviewed By: jwilson Reviewers: aran, jwilson CC: jwilson, epriestley Differential Revision: 65
2011-03-08 23:29:02 +01:00
'DiffusionGitRequest' => 'DiffusionRequest',
Diffusion: rough cut of history view Summary: Very very rough approximation of history view. I left out all the log parsing stuff for now since we should be able to just look it up in a Repository table and I think that'll be a bit faster, although we can muck around and see. Test Plan: Looked at history of a path Reviewed By: jwilson Reviewers: aran, jwilson CC: epriestley, jwilson Differential Revision: 66
2011-03-09 02:31:44 +01:00
'DiffusionHistoryController' => 'DiffusionController',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionHistoryTableView' => 'DiffusionView',
Rough version of DiffusionHomeController Summary: My strategy here is to synthesize Diffusion + Confusion (jwilson's git support for Diffusion) + Repository/Commit stuff into Phabricator and kill all birds with one stone. This probably involves the least total work since we have to do this port step anyway and a lot of the Phabricator primitives are in better shape than the trunk primitives. Test Plan: Looked at it in my sandbox, which has some parsed commits. Reviewers: jwilson, aran, jungejason CC: Differential Revision: 57
2011-03-08 00:13:36 +01:00
'DiffusionHomeController' => 'DiffusionController',
Add more change metadata to SVN and git.
2011-03-31 08:27:06 +02:00
'DiffusionLastModifiedController' => 'DiffusionController',
Basic support for Mercurial in Diffusion Summary: Change import script plus almost all the view stuff. Still some rough edges but this seems to mostly work. Blame is currently unsupported but I think everything else works properly. Test Plan: Imported the hg repository itself. It doesn't immediately seem completely broken. Here are some screens: https://secure.phabricator.com/file/view/PHID-FILE-1438b71cc7c4a2eb4569/ https://secure.phabricator.com/file/view/PHID-FILE-3cec4f72f39e7de2d041/ https://secure.phabricator.com/file/view/PHID-FILE-2ea4883f160e8e5098f9/ https://secure.phabricator.com/file/view/PHID-FILE-35f751a36ebf65399ade/ All the parsers were able to churn through it without errors. Ran the new "reparse.php" script in various one-commit and repository modes. Browsed/imported some git repos for good measure. NOTE: The hg repository is only 15,000 commits and around 1,000 files. Performance is okay but hg doesn't provide performant, native APIs to get some data efficiently so we have to do some dumb stuff. If some of these interfaces are cripplingly slow or whatever, let me know and we can start bundling some Mercurial extensions with Arcanist. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, Makinde, epriestley Differential Revision: 960
2011-09-26 20:07:38 +02:00
'DiffusionMercurialBranchQuery' => 'DiffusionBranchQuery',
'DiffusionMercurialBrowseQuery' => 'DiffusionBrowseQuery',
Show all branches a commit appears on Summary: We show the contextual branch (always the repository default branch) when viewing a commit. Instead, show all branches the commit appears on. Also pull some of the duplicated DiffusionXQuery stuff into a DiffusionQuery base class, I'll do a followup to reduce more duplication. Test Plan: Looked at a commit in Git. My HG and SVN setups are a little borked so I kind of faked tests in them -- I'm fixing them now. Reviewers: btrahan, jungejason, fratrik Reviewed By: btrahan CC: aran Maniphest Tasks: T768 Differential Revision: https://secure.phabricator.com/D1458
2012-01-19 20:49:51 +01:00
'DiffusionMercurialContainsQuery' => 'DiffusionContainsQuery',
Basic support for Mercurial in Diffusion Summary: Change import script plus almost all the view stuff. Still some rough edges but this seems to mostly work. Blame is currently unsupported but I think everything else works properly. Test Plan: Imported the hg repository itself. It doesn't immediately seem completely broken. Here are some screens: https://secure.phabricator.com/file/view/PHID-FILE-1438b71cc7c4a2eb4569/ https://secure.phabricator.com/file/view/PHID-FILE-3cec4f72f39e7de2d041/ https://secure.phabricator.com/file/view/PHID-FILE-2ea4883f160e8e5098f9/ https://secure.phabricator.com/file/view/PHID-FILE-35f751a36ebf65399ade/ All the parsers were able to churn through it without errors. Ran the new "reparse.php" script in various one-commit and repository modes. Browsed/imported some git repos for good measure. NOTE: The hg repository is only 15,000 commits and around 1,000 files. Performance is okay but hg doesn't provide performant, native APIs to get some data efficiently so we have to do some dumb stuff. If some of these interfaces are cripplingly slow or whatever, let me know and we can start bundling some Mercurial extensions with Arcanist. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, Makinde, epriestley Differential Revision: 960
2011-09-26 20:07:38 +02:00
'DiffusionMercurialDiffQuery' => 'DiffusionDiffQuery',
'DiffusionMercurialFileContentQuery' => 'DiffusionFileContentQuery',
'DiffusionMercurialHistoryQuery' => 'DiffusionHistoryQuery',
'DiffusionMercurialLastModifiedQuery' => 'DiffusionLastModifiedQuery',
'DiffusionMercurialRequest' => 'DiffusionRequest',
Some owners read workflows.
2011-04-04 04:20:47 +02:00
'DiffusionPathCompleteController' => 'DiffusionController',
Fix a dirname() edge case in Diffusion Summary: dirname('x') returns '.', not '/'; this caused some issues for repositories with files at the root. There are some cases in the parsers where I should probably swap this out too but I'll wait until I'm doing some more rigorous testing since that stuff is a bit fragile and this fixes an immediate issue. Test Plan: Ran unit tests. Viewed a file at root level in a test repository. Reviewers: jungejason, nh, tuomaspelkonen, aran Reviewed By: nh CC: aran, nh Differential Revision: 932
2011-09-14 20:23:39 +02:00
'DiffusionPathQueryTestCase' => 'PhabricatorTestCase',
Some owners read workflows.
2011-04-04 04:20:47 +02:00
'DiffusionPathValidateController' => 'DiffusionController',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionRepositoryController' => 'DiffusionController',
Show all branches a commit appears on Summary: We show the contextual branch (always the repository default branch) when viewing a commit. Instead, show all branches the commit appears on. Also pull some of the duplicated DiffusionXQuery stuff into a DiffusionQuery base class, I'll do a followup to reduce more duplication. Test Plan: Looked at a commit in Git. My HG and SVN setups are a little borked so I kind of faked tests in them -- I'm fixing them now. Reviewers: btrahan, jungejason, fratrik Reviewed By: btrahan CC: aran Maniphest Tasks: T768 Differential Revision: https://secure.phabricator.com/D1458
2012-01-19 20:49:51 +01:00
'DiffusionSVNContainsQuery' => 'DiffusionContainsQuery',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionSvnBrowseQuery' => 'DiffusionBrowseQuery',
Rough cut of Diffusion change view.
2011-03-31 02:36:16 +02:00
'DiffusionSvnDiffQuery' => 'DiffusionDiffQuery',
Browse / git improvements.
2011-03-14 06:03:30 +01:00
'DiffusionSvnFileContentQuery' => 'DiffusionFileContentQuery',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionSvnHistoryQuery' => 'DiffusionHistoryQuery',
Add more change metadata to SVN and git.
2011-03-31 08:27:06 +02:00
'DiffusionSvnLastModifiedQuery' => 'DiffusionLastModifiedQuery',
Add syntax highlight to diffusion. Summary: use XHPAST parser to parse the file, and generate a table for the code to highlight it. This is part of the task of "Port Diffusion's Browse File view to Phabricator". Test Plan: browse file, try commit version, line number functionality. Reviewed By: epriestley Reviewers: epriestley CC: epriestley Differential Revision: 83
2011-03-23 03:34:47 +01:00
'DiffusionSvnRequest' => 'DiffusionRequest',
Add a simple symbol lookup interface for cross-references Summary: This will get fancier, but here's a basic interface for doing symbol lookups. Still all pretty tentative. Test Plan: Looked up various things, got some sensible results. Reviewers: jungejason, nh, tuomaspelkonen, aran Reviewed By: tuomaspelkonen CC: aran, tuomaspelkonen Differential Revision: 900
2011-09-05 19:43:24 +02:00
'DiffusionSymbolController' => 'DiffusionController',
Make the Diffusion UI vaguely usable in some cases.
2011-03-13 01:17:34 +01:00
'DiffusionView' => 'AphrontView',
Drydock Rough Cut Summary: Rough cut of Drydock. This is very basic and doesn't do much of use yet (it //does// allocate EC2 machines as host resources and expose interfaces to them), but I think the overall structure is more or less reasonable. == Interfaces Vision: Applications interact with Drydock resources through DrydockInterfaces, like **command**, **filesystem** and **httpd** interfaces. Each interface allows applications to perform some kind of operation on the resource, like executing commands, reading/writing files, or configuring a web server. Interfaces have a concrete, specific API: // Filesystem Interface $fs = $lease->getInterface('filesystem'); // Constants, some day? $fs->writeFile('index.html', 'hello world!'); // Command Interface $cmd = $lease->getInterface('command'); echo $cmd->execx('uptime'); // HTTPD Interface $httpd = $lease->getInterface('httpd'); $httpd->restart(); Interfaces are mostly just stock, although installs might add new interfaces if they expose different ways to interact with resources (for instance, a resource might want to expose a new 'MongoDB' interface or whatever). Currently: We have like part of a command interface. == Leases Vision: Leases keep track of which resources are in use, and what they're being used for. They allow us to know when we need to allocate more resources (too many sandcastles on the existing hosts, e.g.) and when we can release resources (because they are no longer being used). They also give applications something to hold while resources are being allocated. // EXAMPLE: How this should work some day. $allocator = new DrydockAllocator(); $allocator->setResourceType('sandcastle'); $allocator->setAttributes( array( 'diffID' => $diff->getID(), )); $lease = $allocator->allocate(); $diff->setSandcastleLeaseID($lease->getID()); // ... if ($lease->getStatus() == DrydockLeaseStatus::STATUS_ACTIVE) { $sandcastle_link = $lease->getInterface('httpd')->getURI('/'); } else { $sandcastle_link = 'Still building your sandcastle...'; } echo "Sandcastle for this diff: ".$sandcastle_link; // EXAMPLE: How this actually works now. $allocator = new DrydockAllocator(); $allocator->setResourceType('host'); // NOTE: Allocation is currently synchronous but will be task-driven soon. $lease = $allocator->allocate(); Leases are completely stock, installs will not define new lease types. Currently: Leases exist and work but are very very basic. == Resources Vision: Resources represent some actual thing we've put somewhere, whether it's a host, a block of storage, a webroot, or whatever else. Applications interact through resources by acquiring leases to them, and then getting interfaces through these leases. The lease acquisition process has a side effect of allocating new resources if a lease can't be acquired on existing resources (e.g., the application wants storage but all storage resources are full) and things are configured to autoscale. Resources may themselves acquire leases in order to allocate. For instance, a storage resource might first acquire a lease to a host resource. A 'test scaffold' resource might lease a storage resource and a mysql resource. Not all resources are auto-allocate: the entry-level version of Drydock is that you manually allocate a couple boxes and configure them through the web console. Then, e.g., 'storage' / 'webroot' resources allocate on top of them, but the host pool itself does not autoscale. Resources are completely stock, they are abstract shells representing any arbitrary thing. Currently: Resource exist ('host' only) but are very very basic. == Blueprints Vision: Blueprints contain instructions for building interfaces to, (possibly) allocating, updating, managing, and destroying a specific type of resource in a specific location. One way to think of them is that they are scripts for creating and deleting resources. For example, the LocalHost, RemoteHost and EC2Host blueprints can all manage 'host' resources. Eventually, we will support more types of resources (storage, webroot, sandcastle, test scaffold, phacility deployment) and more providers for resource types, some of which will be in the Phabricator mainline and some of which will be custom. Blueprints are very custom and specific to application types, so installs will define new blueprints if they are making significant use of Drydock. Currently: They exist but have few capabilities. The stock blueprints do nearly nothing useful. There is a technically functional blueprint for host allocation in EC2. == Allocator This is just the actual code to execute the lease acquisition process. Test Plan: Ran "drydock_control.php" script, it allocated a machine in EC2, acquired a lease on it, interfaced with it, and then released the lease. Ran it again, got a fresh lease on the existing resource. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D1454
2012-01-11 20:18:40 +01:00
'DrydockCommandInterface' => 'DrydockInterface',
'DrydockController' => 'PhabricatorController',
'DrydockDAO' => 'PhabricatorLiskDAO',
'DrydockEC2HostBlueprint' => 'DrydockRemoteHostBlueprint',
'DrydockLease' => 'DrydockDAO',
'DrydockLeaseListController' => 'DrydockController',
'DrydockLeaseStatus' => 'DrydockConstants',
'DrydockLocalCommandInterface' => 'DrydockCommandInterface',
'DrydockLocalHostBlueprint' => 'DrydockBlueprint',
'DrydockRemoteHostBlueprint' => 'DrydockBlueprint',
'DrydockResource' => 'DrydockDAO',
'DrydockResourceAllocateController' => 'DrydockController',
'DrydockResourceListController' => 'DrydockController',
'DrydockResourceStatus' => 'DrydockConstants',
'DrydockSSHCommandInterface' => 'DrydockCommandInterface',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldAction' => 'HeraldDAO',
Enable admin to view and delete other users' herald rules Summary: enable admin to delete user's herald rules. This is useful for managing non-active users' rules. For example, ex-employees' rules. The code change includes: - Added a 'All' tab which is only accessible to admin. - Refactor out a HeraldRuleListView which is used by both the home controller and the all rule controller Test Plan: delete an ex-employee rule as an admin; disable myself as admin and verified that I don't have access to view other user's rules and I'am not be able to delete them; also verified that as a non-admin, I can still view, create and delete my own rules. Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, epriestley, jungejason Differential Revision: 1064
2011-11-06 09:07:04 +01:00
'HeraldAllRulesController' => 'HeraldController',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldApplyTranscript' => 'HeraldDAO',
HeraldCommitAdapter and some related junk.
2011-04-04 08:23:36 +02:00
'HeraldCommitAdapter' => 'HeraldObjectAdapter',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldCondition' => 'HeraldDAO',
Rough cut of Herald home controller.
2011-03-22 21:49:46 +01:00
'HeraldController' => 'PhabricatorController',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldDAO' => 'PhabricatorLiskDAO',
Herald CSS, plus edit/save/delete.
2011-03-24 19:07:36 +01:00
'HeraldDeleteController' => 'HeraldController',
Rough cut of herald transcripts and Differential adapter.
2011-03-25 05:32:26 +01:00
'HeraldDifferentialRevisionAdapter' => 'HeraldObjectAdapter',
Very rough cut at Herald test console.
2011-03-24 21:49:21 +01:00
'HeraldDryRunAdapter' => 'HeraldObjectAdapter',
Rough cut of Herald home controller.
2011-03-22 21:49:46 +01:00
'HeraldHomeController' => 'HeraldController',
Herald 'new rule type' interface.
2011-03-22 22:34:38 +01:00
'HeraldNewController' => 'HeraldController',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldRule' => 'HeraldDAO',
Horrendously rough cut of Herald rule editor.
2011-03-22 23:27:52 +01:00
'HeraldRuleController' => 'HeraldController',
Enable admin to view and delete other users' herald rules Summary: enable admin to delete user's herald rules. This is useful for managing non-active users' rules. For example, ex-employees' rules. The code change includes: - Added a 'All' tab which is only accessible to admin. - Refactor out a HeraldRuleListView which is used by both the home controller and the all rule controller Test Plan: delete an ex-employee rule as an admin; disable myself as admin and verified that I don't have access to view other user's rules and I'am not be able to delete them; also verified that as a non-admin, I can still view, create and delete my own rules. Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, epriestley, jungejason Differential Revision: 1064
2011-11-06 09:07:04 +01:00
'HeraldRuleListView' => 'AphrontView',
Very rough cut at Herald test console.
2011-03-24 21:49:21 +01:00
'HeraldTestConsoleController' => 'HeraldController',
Herald skeleton.
2011-03-22 21:22:40 +01:00
'HeraldTranscript' => 'HeraldDAO',
Rough cut of herald transcripts and Differential adapter.
2011-03-25 05:32:26 +01:00
'HeraldTranscriptController' => 'HeraldController',
'HeraldTranscriptListController' => 'HeraldController',
Examples using JX.View Summary: Provide a dirt-simple working example of client-side templating and reactive programming. Test Plan: Load the examples Reviewers: epriestley, mroch, tomo Reviewed By: epriestley CC: ide, schrockn, aran, rzadorozny, epriestley Differential Revision: 908
2011-09-07 23:01:13 +02:00
'JavelinReactorExample' => 'PhabricatorUIExample',
'JavelinViewExample' => 'PhabricatorUIExample',
'JavelinViewExampleServerView' => 'AphrontView',
Provide connection isolation to Lisk and enable it by default in tests Summary: Allow Lisk to be put into process-isolated mode which establishes only isolated connections. By default, put it into this mode when running unit tests. Build some simple unit tests around object insertion and updating. NOTE: The one flaw in this is that $dao->establishConnection() still punches through the isolation layer. I need to do an API change to fix this though so I'm holding it for now. It will probably just rename getConnection() to establishConnection() and then rename establishConnection() to something scary like establishLiveExternalConnection(). Test Plan: Ran unit tests. Reviewed By: aran Reviewers: aran, tuomaspelkonen, jungejason CC: aran, epriestley Differential Revision: 194
2011-04-30 19:11:59 +02:00
'LiskIsolationTestCase' => 'PhabricatorTestCase',
'LiskIsolationTestDAO' => 'LiskDAO',
Publish feed stories from Maniphest Summary: I didn't get around to this earlier; add Feed/Maniphest integration. This is partly motivated by wanting Projects to not be terrible. Pretty straightforward. Test Plan: - Created, updated, reassigned and closed a task. - Verified feed stories render reasonably. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T681 Differential Revision: 1232
2011-12-17 22:27:11 +01:00
'ManiphestAction' => 'PhrictionConstants',
Support for config-based custom fields in Maniphest Test Plan: Add fields to config based on specification on T335. View on Task Edit and Task Detail. Supported types are string, int and select Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley, hunterbridges Differential Revision: 753
2011-07-27 18:49:50 +02:00
'ManiphestAuxiliaryFieldDefaultSpecification' => 'ManiphestAuxiliaryFieldSpecification',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestController' => 'PhabricatorController',
'ManiphestDAO' => 'PhabricatorLiskDAO',
Tweak Maniphest custom fields Summary: - Fix a bug where 'caption' didn't do anything. - Provide an abstract base implementation for extensions. - Add some documentation. - Expose aux fields via conduit. Test Plan: Added some fields like "Dinosaur", "Kilograms" and "derp" on my local install. Read documentation. Reviewed By: jungejason Reviewers: hunterbridges, jungejason, tuomaspelkonen, aran CC: aran, philc, jungejason Differential Revision: 785
2011-08-05 18:44:43 +02:00
'ManiphestDefaultTaskExtensions' => 'ManiphestTaskExtensions',
Support email multiplexing for private Reply-To addresses Summary: Provide a base PhabricatorMailReplyHandler class which handles the plumbing for multiplexing email if necessary and supporting public and private reply handler addressses. DifferentialReplyHandler now extends it, and a new ManiphestReplyHandler also does. The general approach here is that we have three supported cases: - no reply handler, default config, same as what we're doing now - public reply handler, requires overriding classes but just sets "reply-to" to some address the install generates and still sends only one email - private reply handler, provides a default generation mechanism or you can override it and splits mail apart so we send one to each recipient Test Plan: Sent email from Maniphest and Differential with and without reply-handler-domains set. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley Differential Revision: 254
2011-05-10 01:31:26 +02:00
'ManiphestReplyHandler' => 'PhabricatorMailReplyHandler',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestTask' => 'ManiphestDAO',
Key Value Store for ManiphestTask Test Plan: Look at a task detail. Some dummy attributes are automatically added in ManiphestTaskDetailController. Reviewed By: epriestley Differential Revision: 730
2011-07-26 00:34:56 +02:00
'ManiphestTaskAuxiliaryStorage' => 'ManiphestDAO',
Show description changes in Maniphest Summary: When a task description is updated, there's currently no way to see the change. Build an "expanded summary" mode for transactions that shows description change details. Also include changes in the email. Test Plan: Changed task descriptions, clicked "show details", read email. Reviewed By: aran Reviewers: tuomaspelkonen, jungejason, aran CC: anjali, aran, epriestley Differential Revision: 320
2011-05-21 03:56:18 +02:00
'ManiphestTaskDescriptionChangeController' => 'ManiphestController',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestTaskDetailController' => 'ManiphestController',
Enable task editing in Maniphest. Summary: Test Plan: Reviewers: CC:
2011-02-20 23:15:53 +01:00
'ManiphestTaskEditController' => 'ManiphestController',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestTaskListController' => 'ManiphestController',
Slightly improve Maniphest documentation.
2011-07-04 22:04:22 +02:00
'ManiphestTaskListView' => 'ManiphestView',
'ManiphestTaskOwner' => 'ManiphestConstants',
'ManiphestTaskPriority' => 'ManiphestConstants',
Allow Maniphest tasks to be filtered by Project Summary: Major things taking place here: - A new table for storing <task, project> relationships. - Moved all task query logic into a dedicated class. - Added a "projects" filter to the UI. I was originally going to try to drive this off the main search index but the perf benefits of a custom schema make an overwhelming argument in favor of doing it this way. Test Plan: Filtered tasks by author and owner and zero, one, and more than one project. Exercised all the group/sort options. Ran the index script over my 100k task corpus. Edited task-project membership and verified the index updated. Reviewed By: cadamo Reviewers: gc3, jungejason, cadamo, tuomaspelkonen, aran CC: aran, cadamo, epriestley Differential Revision: 556
2011-06-30 01:16:33 +02:00
'ManiphestTaskProject' => 'ManiphestDAO',
Slightly improve Maniphest documentation.
2011-07-04 22:04:22 +02:00
'ManiphestTaskStatus' => 'ManiphestConstants',
Added subscriber view to Maniphest. Summary: People want to see all the tasks they have subscribed to in one view. A new table was added for this to make queries faster. Test Plan: Tested that the view was initially empty. After running the reindex_maniphest.php script, I saw the correct tasks there. Added myself as a subscriber to one task and made sure the view was updated. Removed myself as a subscriber from one task and made sure the view was updated again. Reviewed By: epriestley Reviewers: epriestley, jungejason, codeblock CC: aran, rm, epriestley Differential Revision: 603
2011-07-07 19:24:49 +02:00
'ManiphestTaskSubscriber' => 'ManiphestDAO',
Slightly improve Maniphest documentation.
2011-07-04 22:04:22 +02:00
'ManiphestTaskSummaryView' => 'ManiphestView',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestTransaction' => 'ManiphestDAO',
Slightly improve Maniphest documentation.
2011-07-04 22:04:22 +02:00
'ManiphestTransactionDetailView' => 'ManiphestView',
'ManiphestTransactionListView' => 'ManiphestView',
Add comment previews to Maniphest Summary: Moves shared code from Differential and Maniphest comment previews into PhabricatorShapedRequest, and then implements Maniphest previews. This doesn't implement comment drafts, I'll follow up with that but it requires this and is completely separable. This also always shows the preview as "commented" rather than previewing the actual transaction. I'll follow up with that but I think it will require a little factoring and this is useful even without transaction details. I need to tweak the styling a bit too. Test Plan: Typed text in Maniphest and Differential. Toggled Differential action. Made comments. Reviewed By: rm Reviewers: rm, tuomaspelkonen, jungejason, aran CC: aran, rm Differential Revision: 258
2011-05-10 17:29:28 +02:00
'ManiphestTransactionPreviewController' => 'ManiphestController',
Maniphest wireframes Summary: Test Plan: Reviewers: CC:
2011-02-08 19:53:59 +01:00
'ManiphestTransactionSaveController' => 'ManiphestController',
Slightly improve Maniphest documentation.
2011-07-04 22:04:22 +02:00
'ManiphestTransactionType' => 'ManiphestConstants',
'ManiphestView' => 'AphrontView',
I guess this can support JS too.
2011-01-30 01:16:09 +01:00
'Phabricator404Controller' => 'PhabricatorController',
Add Basic Auditing Functionalities Summary: add basic auditing functionalities. For the related commits for a package, we detect the following conditions which might be suspicious to the owners of the package: * no revision specified * revision not found * author not match * reviewedby not match * owners not involved * commit author not recognized The owners of the package can change the status of the audit entries by accepting it or specify concern. The owner can turn on/off the auditing for a package. Test Plan: * verified that non-owner cannot see the details of the audit and cannot modify it * verified that all the audit reasons can be detected * tested dropdown filtering and package search * verified really normal change not detected * verified accept/concern a commit * tested enable/disable a package for auditing * verified one audit applies to all <commit, packages> to the packages the auditor owns * verified that re-parsing a commit won't have effect if there exists a relationship for <commit, package> already Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, benmathews, btrahan, mpodobnik, prithvi, TomL, epriestley Differential Revision: 1242
2011-12-18 00:52:54 +01:00
'PhabricatorAuditComment' => 'PhabricatorAuditDAO',
'PhabricatorAuditController' => 'PhabricatorController',
'PhabricatorAuditDAO' => 'PhabricatorLiskDAO',
'PhabricatorAuditEditController' => 'PhabricatorAuditController',
Authentication
2011-01-26 22:21:12 +01:00
'PhabricatorAuthController' => 'PhabricatorController',
Build a basic calendar view Summary: This is a very small step toward building a Status and possibly an Oncall tool. Build a calendar view which renders months. Much of my hesitance to bang these tools out is that dealing with dates/calendaring is basically horrible, so I'm trying to ease into it. This calendar is locale-aware and all that jazz. Test Plan: - See: https://secure.phabricator.com/file/view/PHID-FILE-c07a9c663a7d040d2529/ - Verified that months have the right number of days, today is the right day of the week, months begin on the day after previous months end on, etc. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran Commenters: cwbeck, jungejason CC: blair, aran, epriestley, cwbeck, jungejason Differential Revision: 791
2011-08-08 03:26:31 +02:00
'PhabricatorCalendarBrowseController' => 'PhabricatorCalendarController',
'PhabricatorCalendarController' => 'PhabricatorController',
Conduit server-side basics.
2011-01-24 18:00:29 +01:00
'PhabricatorConduitAPIController' => 'PhabricatorConduitController',
"arc install-certificate", server-side components Summary: Provides a new workflow for making it non-horrible to install certificates. Basically you run "arc install-certificate" and then copy/paste a short token off a webpage and it does the ~/.arcrc edits for you. Test Plan: Installed certificates, used bad tokens, hit rate limiting. Reviewed By: aran Reviewers: aran, jungejason, tuomaspelkonen CC: aran Differential Revision: 460
2011-06-14 21:17:14 +02:00
'PhabricatorConduitCertificateToken' => 'PhabricatorConduitDAO',
Conduit server-side basics.
2011-01-24 18:00:29 +01:00
'PhabricatorConduitConnectionLog' => 'PhabricatorConduitDAO',
'PhabricatorConduitConsoleController' => 'PhabricatorConduitController',
'PhabricatorConduitController' => 'PhabricatorController',
'PhabricatorConduitDAO' => 'PhabricatorLiskDAO',
'PhabricatorConduitLogController' => 'PhabricatorConduitController',
'PhabricatorConduitMethodCallLog' => 'PhabricatorConduitDAO',
"arc install-certificate", server-side components Summary: Provides a new workflow for making it non-horrible to install certificates. Basically you run "arc install-certificate" and then copy/paste a short token off a webpage and it does the ~/.arcrc edits for you. Test Plan: Installed certificates, used bad tokens, hit rate limiting. Reviewed By: aran Reviewers: aran, jungejason, tuomaspelkonen CC: aran Differential Revision: 460
2011-06-14 21:17:14 +02:00
'PhabricatorConduitTokenController' => 'PhabricatorConduitController',
Track content sources (email, web, conduit, mobile) for replies Summary: When an object is updated, record the content source for the update. This mostly isn't terribly useful but one concrete thing I want to do with it is let admins audit via-email replies more easily since there are a bunch of options which let you do hyjinx if you intentionally configure them insecurely. I think having a little more auditability around this feature is generally good. At some point I'm going to turn this into a link admins can click to see details. It also allows us to see how frequently different mechanisms are used, and lets you see if someone is at their desk or on a mobile or whatever, at least indirectly. The "tablet" and "mobile" sources are currently unused but I figured I'd throw them in anyway. SMS support should definitely happen at some point. Not 100% sure about the design for this, I might change it to plain text at some point. Test Plan: Updated objects and saw update sources rendered. Reviewers: jungejason, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, epriestley, jungejason Differential Revision: 844
2011-08-22 19:25:45 +02:00
'PhabricatorContentSourceView' => 'AphrontView',
More phabricator organizational stuff.
2011-01-23 02:48:55 +01:00
'PhabricatorController' => 'AphrontController',
Countdown Summary: Addon that allows you to create a live countdown page to some event. Here is the ticket that this code is based on https://secure.phabricator.com/T36 Test Plan: Tested by manually setting dates in the timer.js file and checking if they made sense. I'm not sure if it works across different timezones though. Reviewers: epriestley CC: Differential Revision: 436
2011-06-13 01:06:17 +02:00
'PhabricatorCountdownController' => 'PhabricatorController',
'PhabricatorCountdownDAO' => 'PhabricatorLiskDAO',
'PhabricatorCountdownDeleteController' => 'PhabricatorCountdownController',
'PhabricatorCountdownEditController' => 'PhabricatorCountdownController',
'PhabricatorCountdownListController' => 'PhabricatorCountdownController',
'PhabricatorCountdownViewController' => 'PhabricatorCountdownController',
Rough cut of repository tracking Summary: Basic scaffolding for repository tracking, plus daemon infrastructure (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk). Test Plan: parsed Javelin git commit history via daemon Reviewers: CC:
2011-03-07 07:29:22 +01:00
'PhabricatorDaemon' => 'PhutilDaemon',
Improve web tools for viewing daemons Summary: - Provides an "all daemons" view to look at more than the first 15 daemons. - Provides a "combined log" view with a large page size, to quickly look at the log across all the daemons, making it easier to find issues when you have a bunch of the same daemon and only one is having issues. - When viewing the web console on the same host as a daemon, show whether it's running or not. Test Plan: Clicked the various daemon log interfaces. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 215
2011-05-03 02:05:22 +02:00
'PhabricatorDaemonCombinedLogController' => 'PhabricatorDaemonController',
Rough cut of Workers Summary: workers do work, provided I have written them correctly. perhaps it is so. Test Plan: Reviewers: CC:
2011-03-10 22:48:29 +01:00
'PhabricatorDaemonConsoleController' => 'PhabricatorDaemonController',
'PhabricatorDaemonController' => 'PhabricatorController',
Diffusion/phd/console improvements.
2011-03-15 21:38:14 +01:00
'PhabricatorDaemonDAO' => 'PhabricatorLiskDAO',
'PhabricatorDaemonLog' => 'PhabricatorDaemonDAO',
'PhabricatorDaemonLogEvent' => 'PhabricatorDaemonDAO',
Improve web tools for viewing daemons Summary: - Provides an "all daemons" view to look at more than the first 15 daemons. - Provides a "combined log" view with a large page size, to quickly look at the log across all the daemons, making it easier to find issues when you have a bunch of the same daemon and only one is having issues. - When viewing the web console on the same host as a daemon, show whether it's running or not. Test Plan: Clicked the various daemon log interfaces. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 215
2011-05-03 02:05:22 +02:00
'PhabricatorDaemonLogEventsView' => 'AphrontView',
'PhabricatorDaemonLogListController' => 'PhabricatorDaemonController',
'PhabricatorDaemonLogListView' => 'AphrontView',
Diffusion/phd/console improvements.
2011-03-15 21:38:14 +01:00
'PhabricatorDaemonLogViewController' => 'PhabricatorDaemonController',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorDaemonTimelineConsoleController' => 'PhabricatorDaemonController',
'PhabricatorDaemonTimelineEventController' => 'PhabricatorDaemonController',
Allow Phabricator storage engines to be extended and configured Summary: See T344. Currently, there's a hard-coded 12MB filesize limit and some awkward interactions with MySQL's max_allowed_packet. Make this system generally more robust: - Move the upload limit to configuration. - Add setup steps which reconcile max_allowed_packet vs MySQL file storage limits. - Add a layer of indirection between uploading files and storage engines. - Allow the definition of new storage engines. - Define a local disk storage engine. - Add a "storage engine selector" class which manages choosing which storage engines to put files in. - Document storage engines. - Document file storage classes. Test Plan: Setup mode: - Disabled MySQL storage engine, misconfigured it, configured it correctly. - Disabled file storage engine, set it to something invalid, set it to something valid. - Verified max_allowed_packet is read correctly. Application mode: - Configured local file storage. - Uploaded large and small files. - Verified larger files were written to local storage. - Verified smaller files were written to MySQL blob storage. Documentation: - Read documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 695
2011-07-20 07:48:38 +02:00
'PhabricatorDefaultFileStorageEngineSelector' => 'PhabricatorFileStorageEngineSelector',
Provide an indirection layer between documents and the search engine Summary: In preparation for adding another search engine (see T355): - Rename "executor" to "engine". - Move all engine-specific operations into the engine. Specifically, this means that indexing moves out of the document store and into the engine (it was sort of silly where it was before). - Split choice of an engine into an overridable "selector" class, a base API, and a concrete MySQL implementation (just like storage engine selection). - Make all callers go through the indirection layer. The default selector just unconditionally selects the MySQL engine, but now (with D786) I can build an Elastic Search engine and you guys can build a multi-target engine if you want and I don't get there fast enough. Test Plan: - Created a new document (task). - Searched for and found it. - Viewed index reconstruction. Reviewed By: jungejason Reviewers: jungejason, amckinley, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 788
2011-08-08 00:14:23 +02:00
'PhabricatorDefaultSearchEngineSelector' => 'PhabricatorSearchEngineSelector',
More phabricator organizational stuff.
2011-01-23 02:48:55 +01:00
'PhabricatorDirectoryCategory' => 'PhabricatorDirectoryDAO',
'PhabricatorDirectoryCategoryDeleteController' => 'PhabricatorDirectoryController',
'PhabricatorDirectoryCategoryEditController' => 'PhabricatorDirectoryController',
'PhabricatorDirectoryCategoryListController' => 'PhabricatorDirectoryController',
'PhabricatorDirectoryController' => 'PhabricatorController',
'PhabricatorDirectoryDAO' => 'PhabricatorLiskDAO',
'PhabricatorDirectoryItem' => 'PhabricatorDirectoryDAO',
'PhabricatorDirectoryItemDeleteController' => 'PhabricatorDirectoryController',
'PhabricatorDirectoryItemEditController' => 'PhabricatorDirectoryController',
'PhabricatorDirectoryItemListController' => 'PhabricatorDirectoryController',
'PhabricatorDirectoryMainController' => 'PhabricatorDirectoryController',
Admin and disabled flags for users Summary: Provide an "isAdmin" flag for users, to designate administrative users. Restore the account editing interface and allow it to set role flags and reset passwords. Provide an "isDisabled" flag for users and shut down all system access for them. Test Plan: Created "admin" and "disabled" users. Did administrative things with the admin user. Tried to do stuff with the disabled user and was rebuffed. Tried to access administrative interfaces with a normal non-admin user and was denied. Reviewed By: aran Reviewers: tuomaspelkonen, jungejason, aran CC: ccheever, aran Differential Revision: 278
2011-05-12 19:06:54 +02:00
'PhabricatorDisabledUserController' => 'PhabricatorAuthController',
Revision comment drafts.
2011-02-06 01:57:21 +01:00
'PhabricatorDraft' => 'PhabricatorDraftDAO',
'PhabricatorDraftDAO' => 'PhabricatorLiskDAO',
PhabricatorEnv 'infratructure' -> 'infrastructure' (rofl) Recaptcha Email Login / Forgot Password Password Reset
2011-01-31 20:55:26 +01:00
'PhabricatorEmailLoginController' => 'PhabricatorAuthController',
'PhabricatorEmailTokenController' => 'PhabricatorAuthController',
Lock down accepted next URI values for redirect after login Summary: I locked this down a little bit recently, but make double-extra-super-sure that we aren't sending the user anywhere suspicious or open-redirecty. This also locks down protocol-relative URIs (//evil.com/path) although I don't think any browsers do bad stuff with them in this context, and header injection URIs (although I don't think any of the modern PHP runtimes are vulnerable). Test Plan: - Ran tests. - Hit redirect page with valid and invalid next URIs; was punted to / for invalid ones and to the right place for valid ones. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: arice, aran, epriestley, btrahan Differential Revision: https://secure.phabricator.com/D1369
2012-01-12 01:07:36 +01:00
'PhabricatorEnvTestCase' => 'PhabricatorTestCase',
Move event framework from Phabricator to libphutil Summary: Move event framework from Phabricator to libphutil so it can be used in other phutil projects, such as Arcanist. Test plan: Use along with path to libphutil, events should work as expected. Reviewers: epriestley Differential Revision: 1098
2011-11-10 02:23:33 +01:00
'PhabricatorEvent' => 'PhutilEvent',
'PhabricatorEventType' => 'PhutilEventType',
Build basic infrastructure for an activity feed Summary: This defines an extremely basic version of an activity feed, like Facebook's news feed. It doesn't do much of interest yet. Test Plan: Published some feed stories: https://secure.phabricator.com/file/view/PHID-FILE-5061aa72105bbdc05b21/ Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran Commenters: codeblock, jungejason CC: aran, epriestley, codeblock, tuomaspelkonen, jungejason Differential Revision: 593
2011-07-05 17:35:18 +02:00
'PhabricatorFeedController' => 'PhabricatorController',
'PhabricatorFeedDAO' => 'PhabricatorLiskDAO',
Provide a public view of feed Summary: Depends on D628. Provides a config option so you can set up a public feed, which you can iframe. This needs some work but sort of works. Test Plan: Loaded the public feed as a logged-out user. Reviewed By: codeblock Reviewers: jungejason, tuomaspelkonen, aran, codeblock CC: aran, codeblock Differential Revision: 635
2011-07-10 03:03:59 +02:00
'PhabricatorFeedPublicStreamController' => 'PhabricatorFeedController',
Build basic infrastructure for an activity feed Summary: This defines an extremely basic version of an activity feed, like Facebook's news feed. It doesn't do much of interest yet. Test Plan: Published some feed stories: https://secure.phabricator.com/file/view/PHID-FILE-5061aa72105bbdc05b21/ Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran Commenters: codeblock, jungejason CC: aran, epriestley, codeblock, tuomaspelkonen, jungejason Differential Revision: 593
2011-07-05 17:35:18 +02:00
'PhabricatorFeedStoryData' => 'PhabricatorFeedDAO',
Publish Differential stories into feed Summary: Basic hookup for Differential -> Feed. Also introduces "one-line" stories for less-important stuff. Test Plan: Interacted with some revisions, got feed stories out of it. Reviewed By: jungejason Reviewers: jungejason, aran, tuomaspelkonen, codeblock CC: aran, jungejason Differential Revision: 632
2011-07-10 00:44:49 +02:00
'PhabricatorFeedStoryDifferential' => 'PhabricatorFeedStory',
Publish feed stories from Maniphest Summary: I didn't get around to this earlier; add Feed/Maniphest integration. This is partly motivated by wanting Projects to not be terrible. Pretty straightforward. Test Plan: - Created, updated, reassigned and closed a task. - Verified feed stories render reasonably. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T681 Differential Revision: 1232
2011-12-17 22:27:11 +01:00
'PhabricatorFeedStoryManiphest' => 'PhabricatorFeedStory',
Publish Phriction edits to feed Summary: Basic integration between Phriction and feed. Test Plan: Created and edited some documents, they published to feed. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, hsb Differential Revision: 653
2011-07-12 16:23:04 +02:00
'PhabricatorFeedStoryPhriction' => 'PhabricatorFeedStory',
Build basic infrastructure for an activity feed Summary: This defines an extremely basic version of an activity feed, like Facebook's news feed. It doesn't do much of interest yet. Test Plan: Published some feed stories: https://secure.phabricator.com/file/view/PHID-FILE-5061aa72105bbdc05b21/ Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran Commenters: codeblock, jungejason CC: aran, epriestley, codeblock, tuomaspelkonen, jungejason Differential Revision: 593
2011-07-05 17:35:18 +02:00
'PhabricatorFeedStoryReference' => 'PhabricatorFeedDAO',
Improve feed stories with "style", and build basic status update stories. Summary: Straightfoward iteration on feed. Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-d07077119dc834e76618/ Reviewed By: codeblock Reviewers: jungejason, aran, tuomaspelkonen, codeblock CC: aran, codeblock, epriestley Differential Revision: 631
2011-07-09 22:28:09 +02:00
'PhabricatorFeedStoryStatus' => 'PhabricatorFeedStory',
Publish Differential stories into feed Summary: Basic hookup for Differential -> Feed. Also introduces "one-line" stories for less-important stuff. Test Plan: Interacted with some revisions, got feed stories out of it. Reviewed By: jungejason Reviewers: jungejason, aran, tuomaspelkonen, codeblock CC: aran, jungejason Differential Revision: 632
2011-07-10 00:44:49 +02:00
'PhabricatorFeedStoryTypeConstants' => 'PhabricatorFeedConstants',
Build basic infrastructure for an activity feed Summary: This defines an extremely basic version of an activity feed, like Facebook's news feed. It doesn't do much of interest yet. Test Plan: Published some feed stories: https://secure.phabricator.com/file/view/PHID-FILE-5061aa72105bbdc05b21/ Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran Commenters: codeblock, jungejason CC: aran, epriestley, codeblock, tuomaspelkonen, jungejason Differential Revision: 593
2011-07-05 17:35:18 +02:00
'PhabricatorFeedStoryUnknown' => 'PhabricatorFeedStory',
'PhabricatorFeedStoryView' => 'PhabricatorFeedView',
'PhabricatorFeedStreamController' => 'PhabricatorFeedController',
'PhabricatorFeedView' => 'AphrontView',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'PhabricatorFile' => 'PhabricatorFileDAO',
Provide a setting which forces all file views to be served from an alternate domain Summary: See D758, D759. - Provide a strongly recommended setting which permits configuration of an alternate domain. - Lock cookies down better: set them on the exact domain, and use SSL-only if the configuration is HTTPS. - Prevent Phabriator from setting cookies on other domains. This assumes D759 will land, it is not effective without that change. Test Plan: - Attempted to login from a different domain and was rejected. - Logged out, logged back in normally. - Put install in setup mode and verified it revealed a warning. - Configured an alterate domain. - Tried to view an image with an old URI, got a 400. - Went to /files/ and verified links rendered to the alternate domain. - Viewed an alternate domain file. - Tried to view an alternate domain file without the secret key, got a 404. Reviewers: andrewjcg, erling, aran, tuomaspelkonen, jungejason, codeblock CC: aran Differential Revision: 760
2011-08-02 07:24:00 +02:00
'PhabricatorFileAltViewController' => 'PhabricatorFileController',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'PhabricatorFileController' => 'PhabricatorController',
'PhabricatorFileDAO' => 'PhabricatorLiskDAO',
Allow files to be deleted Summary: A couple of people mentioned that they've had users accidentally upload sensitive files. Allow files to be deleted. (At some point it might be nice to keep the file handle around and log who deleted it, but this addresses the immediate problem without needing too much work.) Test Plan: Deleted some files. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T780 Differential Revision: https://secure.phabricator.com/D1423
2012-01-16 22:26:44 +01:00
'PhabricatorFileDeleteController' => 'PhabricatorFileController',
Drag-and-drop upload for Maniphest Summary: This needs a bunch of UI polish (critically, it's totally undiscoverable) but it basically works correctly. I'll clean it up in some followups. Test Plan: Uploaded some files via drag-and-drop, made comments, etc. Reviewed By: aran Reviewers: tomo, aran, jungejason, tuomaspelkonen CC: anjali, aran Differential Revision: 332
2011-05-22 20:55:10 +02:00
'PhabricatorFileDropUploadController' => 'PhabricatorFileController',
Image macros for Phabricator! Summary: Added long waited image macro support for differential and others. Test Plan: Tried a couple of different macros and made sure they appear nicely in the comment preview. Made sure that the normal comments are shown correctly. Reviewed By: epriestley Reviewers: epriestley CC: jungejason, tuomaspelkonen, epriestley Differential Revision: 129
2011-04-14 00:15:48 +02:00
'PhabricatorFileImageMacro' => 'PhabricatorFileDAO',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'PhabricatorFileListController' => 'PhabricatorFileController',
Web editor/browser for image macros Summary: Restores the old "pokedex" feature and allows easy definition of new macros. Only good can come of this! Critical feature!! Test Plan: nyancat Reviewed By: tuomaspelkonen Reviewers: aran, bh, tomo, jungejason, tuomaspelkonen CC: aran, tuomaspelkonen Differential Revision: 220
2011-05-03 19:45:45 +02:00
'PhabricatorFileMacroDeleteController' => 'PhabricatorFileController',
'PhabricatorFileMacroEditController' => 'PhabricatorFileController',
'PhabricatorFileMacroListController' => 'PhabricatorFileController',
Restore image proxying to Remarkup Summary: Previously, Remarkup allowed you to paste in an image URI and get an inline image. However, it did this by hotlinking the image which isn't so hot in an open source product. Restore this feature, but use image proxying instead. The existing image macro code does most of the work. There is a mild security risk depending on the network setup so I've left this default-disabled and made a note about it. It should be safe to enable for Facebook. Test Plan: Pasted in image and non-image links, got reasonable behavior. Verified proxying appears to work. Verified that file:// shenanigans produce 400. Reviewed By: tuomaspelkonen Reviewers: aran, jungejason, tuomaspelkonen Commenters: cpiro CC: aran, cpiro, tuomaspelkonen Differential Revision: 214
2011-05-02 23:20:24 +02:00
'PhabricatorFileProxyController' => 'PhabricatorFileController',
'PhabricatorFileProxyImage' => 'PhabricatorFileDAO',
Files - kill tabs Summary: kill tabs for Files application. Technique is the "filter list" on the left hand side, with separation for "Files" versus "Image Macros". UI quirks include: - the page title does not change for the 3 files filters while it does change for each of the two image macro filters. - standalone "file" pages do not have the filter view - you can visit /file/upload/ standalone and it doesn't have the pretty filter list on it Please do give direction on these quirks if you like. :) This change also neuters the ?author= functionality for files. The code is written such that it can easily be brought back. Test Plan: clicked around on the filters, liked what I saw. uploaded files fancy-like and basic-like and it worked! made image macros and it worked! Reviewers: epriestley Reviewed By: epriestley CC: aran, btrahan, epriestley Maniphest Tasks: T631 Differential Revision: 1219
2011-12-15 07:37:23 +01:00
'PhabricatorFileSideNavView' => 'AphrontView',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'PhabricatorFileStorageBlob' => 'PhabricatorFileDAO',
Basic image thumbnailing Summary: This is still very rough but provides basic support for generating image thumbnails. I need to separate stuff out a bit but I'm going to integrate into Maniphest before I hit the profile stuff so this seems like a reasonable starting point. Test Plan: Generated some image thumbnails in various sizes. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 333
2011-05-22 23:40:51 +02:00
'PhabricatorFileTransformController' => 'PhabricatorFileController',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'PhabricatorFileUploadController' => 'PhabricatorFileController',
Files - kill tabs Summary: kill tabs for Files application. Technique is the "filter list" on the left hand side, with separation for "Files" versus "Image Macros". UI quirks include: - the page title does not change for the 3 files filters while it does change for each of the two image macro filters. - standalone "file" pages do not have the filter view - you can visit /file/upload/ standalone and it doesn't have the pretty filter list on it Please do give direction on these quirks if you like. :) This change also neuters the ?author= functionality for files. The code is written such that it can easily be brought back. Test Plan: clicked around on the filters, liked what I saw. uploaded files fancy-like and basic-like and it worked! made image macros and it worked! Reviewers: epriestley Reviewed By: epriestley CC: aran, btrahan, epriestley Maniphest Tasks: T631 Differential Revision: 1219
2011-12-15 07:37:23 +01:00
'PhabricatorFileUploadView' => 'AphrontView',
Phabricator file upload application.
2011-01-23 03:33:00 +01:00
'PhabricatorFileViewController' => 'PhabricatorFileController',
Add a garbage collector daemon Summary: Phabricator generates a bunch of data that we don't need to keep around forever, add a GC daemon to get rid of it with some basic configuration options. This needs a couple more diffs to get some of the details but I think this is a reasonable start. I also fixed a couple of UI things related to this, e.g. the daemon logs page going crazy when a daemon gets stuck in a loop and dumps tons of data to stdout. Test Plan: - Ran gc daemon in 'phd debug' mode and saw it delete stuff, then sleep once it had cleaned everything up. - Mucked around with TTLs and verified they work correctly. - Viewed gc'd transcripts in the web interface and made sure they displayed okay. - Viewed daemon logs before/after garbage collection. - Running some run-at / run-for tests now, I'll update if the daemon doesn't shut off in ~10-15 minutes. :P Reviewed By: tuomaspelkonen Reviewers: jungejason, tuomaspelkonen, aran CC: aran, tuomaspelkonen, epriestley Differential Revision: 583
2011-07-03 18:47:31 +02:00
'PhabricatorGarbageCollectorDaemon' => 'PhabricatorDaemon',
Rough cut of Workers Summary: workers do work, provided I have written them correctly. perhaps it is so. Test Plan: Reviewers: CC:
2011-03-10 22:48:29 +01:00
'PhabricatorGoodForNothingWorker' => 'PhabricatorWorker',
Provide basic structure for keyboard shortcuts Summary: Implements a simple infrastructure for keyboard shortcuts, see T184, and a "help" shortcut. There's a lot of room for refinement here but I think it basically works. Each shortcut can also provide a "tooltip" handler which allows it to show help when the alt/option key is held down. Test Plan: Pressed "?" and got help. Pressed "?" in various contexts where it should not activate (modifier keys, text input focused) and didn't get help. Reviewers: aran, tuomaspelkonen, jungejason CC: moskov Differential Revision: 362
2011-05-28 20:36:00 +02:00
'PhabricatorHelpController' => 'PhabricatorController',
'PhabricatorHelpKeyboardShortcutController' => 'PhabricatorHelpController',
Very basic IRC Bot Summary: This is sort of a silly/fun project but I think there's some utility. For example, mroch added some handlers to an eggdrop or something similar to look for "D12345" and print out the title/link, which was actually pretty useful. We could also add logging here and subsume the more-or-less unowned Facebook tool that does the same thing, especially since we can get a bunch of good stuff it doesn't support (like search) more or less for free. This is also an easy way to provide some example code for writing Conduit system agents. This is a minimal implementation which creates a bot that connects to a hard-coded server and sits there indefinitely. Next steps: - Add conduit/sysagent support - Write differential/maniphest/diffusion handlers - Move configuration to the web interface (?) and integrate with phd - Write a logging handler? Test Plan: Ran bot with "exec_daemon.php", it connected to the hard-coded server and sat there indefinitely. Reviewed By: aran Reviewers: codeblock, mroch, tuomaspelkonen, aran, jungejason CC: aran, epriestley Differential Revision: 283
2011-05-15 18:29:48 +02:00
'PhabricatorIRCBot' => 'PhabricatorDaemon',
Add an example notification handler to the IRC bot Summary: Simple notificaiton handler that reads the difx event timeline and posts notifications to IRC. Test Plan: Ran it in #phabricator. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Differential Revision: https://secure.phabricator.com/D1337
2012-01-06 20:31:00 +01:00
'PhabricatorIRCDifferentialNotificationHandler' => 'PhabricatorIRCHandler',
Add an "IRC Object Name" handler for D12345 Summary: I need to add some more conduit methods / info to make this at all useful but here's some basics. Test Plan: Hung out in #phabot-test Reviewed By: mroch Reviewers: mroch, codeblock, aran, jungejason, tuomaspelkonen CC: aran, mroch, epriestley Differential Revision: 300
2011-05-17 23:40:25 +02:00
'PhabricatorIRCObjectNameHandler' => 'PhabricatorIRCHandler',
Very basic IRC Bot Summary: This is sort of a silly/fun project but I think there's some utility. For example, mroch added some handlers to an eggdrop or something similar to look for "D12345" and print out the title/link, which was actually pretty useful. We could also add logging here and subsume the more-or-less unowned Facebook tool that does the same thing, especially since we can get a bunch of good stuff it doesn't support (like search) more or less for free. This is also an easy way to provide some example code for writing Conduit system agents. This is a minimal implementation which creates a bot that connects to a hard-coded server and sits there indefinitely. Next steps: - Add conduit/sysagent support - Write differential/maniphest/diffusion handlers - Move configuration to the web interface (?) and integrate with phd - Write a logging handler? Test Plan: Ran bot with "exec_daemon.php", it connected to the hard-coded server and sat there indefinitely. Reviewed By: aran Reviewers: codeblock, mroch, tuomaspelkonen, aran, jungejason CC: aran, epriestley Differential Revision: 283
2011-05-15 18:29:48 +02:00
'PhabricatorIRCProtocolHandler' => 'PhabricatorIRCHandler',
Add test to check all symbols can be loaded Summary: make sure all symboles can be loaded to avoid issues like missing methods in descendants of abstract base class. Test Plan: ran it and verified it passes; remove a method in a descendant class and verified that the test failed. Reviewers: epriestley, nh Reviewed By: nh CC: aran, nh, jungejason Differential Revision: 1023
2011-10-20 03:26:21 +02:00
'PhabricatorInfrastructureTestCase' => 'PhabricatorTestCase',
Bring Javelin into Phabricator via git submodule, not copy-and-paste Summary: Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt packages. This is not so great. Pull it in as a submodule instead and make all the Phabriator resources declare proper dependency trees. Add Javelin linting. Test Plan: I tried to run through pretty much all the JS functionality on the site. This is still a high-risk change, but I did a pretty thorough test Differential: inline comments, revealing diffs, list tokenizers, comment preview, editing/deleting comments, add review action. Maniphest: list tokenizer, comment actions Herald: rule editing, tokenizers, add/remove rows Reviewed By: tomo Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen CC: aran, tomo, epriestley Differential Revision: 223
2011-05-04 00:11:55 +02:00
'PhabricatorJavelinLinter' => 'ArcanistLinter',
'PhabricatorLintEngine' => 'PhutilLintEngine',
More phabricator organizational stuff.
2011-01-23 02:48:55 +01:00
'PhabricatorLiskDAO' => 'LiskDAO',
Allow Phabricator storage engines to be extended and configured Summary: See T344. Currently, there's a hard-coded 12MB filesize limit and some awkward interactions with MySQL's max_allowed_packet. Make this system generally more robust: - Move the upload limit to configuration. - Add setup steps which reconcile max_allowed_packet vs MySQL file storage limits. - Add a layer of indirection between uploading files and storage engines. - Allow the definition of new storage engines. - Define a local disk storage engine. - Add a "storage engine selector" class which manages choosing which storage engines to put files in. - Document storage engines. - Document file storage classes. Test Plan: Setup mode: - Disabled MySQL storage engine, misconfigured it, configured it correctly. - Disabled file storage engine, set it to something invalid, set it to something valid. - Verified max_allowed_packet is read correctly. Application mode: - Configured local file storage. - Uploaded large and small files. - Verified larger files were written to local storage. - Verified smaller files were written to MySQL blob storage. Documentation: - Read documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 695
2011-07-20 07:48:38 +02:00
'PhabricatorLocalDiskFileStorageEngine' => 'PhabricatorFileStorageEngine',
Improve time localization code Summary: - We throw on a missing date right now, in the DateTime constructor. This can happen in reasonable cases and this is display code, so handle it more gracefully (see T520). - This stuff is a little slow and we sometimes render many hundreds of dates per page. I've been seeing it in profiles on and off. Memoize timezones to improve performance. - Some minor code duplication that would have become less-minor with the constructor change, consolidate the logic. - Add some unit tests and a little documentation. Test Plan: - Ran unit tests. - Profiled 1,000 calls to phabricator_datetime(), cost dropped from ~49ms to ~19ms with addition of memoization. This is still slower than I'd like but I don't think there's an easy way to squeeze it down further. Reviewers: ajtrichards, jungejason, nh, tuomaspelkonen, aran Reviewed By: ajtrichards CC: aran, ajtrichards, epriestley Differential Revision: 966
2011-09-27 18:03:55 +02:00
'PhabricatorLocalTimeTestCase' => 'PhabricatorTestCase',
Authentication
2011-01-26 22:21:12 +01:00
'PhabricatorLoginController' => 'PhabricatorAuthController',
Validate logins, and simplify email password resets Summary: - There are some recent reports of login issues, see T755 and T754. I'm not really sure what's going on, but this is an attempt at getting some more information. - When we login a user by setting 'phusr' and 'phsid', send them to /login/validate/ to validate that the cookies actually got set. - Do email password resets in two steps: first, log the user in. Redirect them through validate, then give them the option to reset their password. - Don't CSRF logged-out users. It technically sort of works most of the time right now, but is silly. If we need logged-out CSRF we should generate it in some more reliable way. Test Plan: - Logged in with username/password. - Logged in with OAuth. - Logged in with email password reset. - Sent bad values to /login/validate/, got appropriate errors. - Reset password. - Verified next_uri still works. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan, j3kuntz Maniphest Tasks: T754, T755 Differential Revision: https://secure.phabricator.com/D1353
2012-01-10 23:42:07 +01:00
'PhabricatorLoginValidateController' => 'PhabricatorAuthController',
CSRF / Logout
2011-01-31 03:52:29 +01:00
'PhabricatorLogoutController' => 'PhabricatorAuthController',
Very basic daemon infrastructure, plus MetaMTA daemon. Summary: Amazon SES seems to be working well, except that it takes more than a second to send mail in-process. Kick it out of process. (Between this and the ImplementationAdapter layer, MetaMTA almost makes sense. :/) Test Plan: Ran the daemon and got a flood of unsent test email. Reviewers: CC:
2011-02-10 02:39:55 +01:00
'PhabricatorMailImplementationAmazonSESAdapter' => 'PhabricatorMailImplementationPHPMailerLiteAdapter',
PHPMailerLite
2011-01-26 18:33:31 +01:00
'PhabricatorMailImplementationPHPMailerLiteAdapter' => 'PhabricatorMailImplementationAdapter',
Add support for SendGrid as an outbound mail adapter Summary: SendGrid is a popular mail delivery platform, similar to Amazon SES. Provide support for delivering email via their REST API. Test Plan: Created a SendGrid account, configured my local install to use it, sent some mail, received mail. Reviewers: tuomaspelkonen, jungejason, aran CC: ccheever Differential Revision: 347
2011-05-26 19:00:26 +02:00
'PhabricatorMailImplementationSendGridAdapter' => 'PhabricatorMailImplementationAdapter',
Fix a threading issue with Amazon SES Summary: Amazon SES does not allow us to set a Message-ID header, which means that threads are incorrect in Mail.app (and presumably other applications which respect In-Reply-To and References) because the initial email does not have anything which attaches it to the rest of the thread. To fix this, never rely on Message-ID if the mailer doesn't support Message-ID. (In the Amazon SES case, Amazon generates its own Message-ID which we can't know ahead of time). I additionally used all the Lisk isolation from the other tests to make this testable and wrote tests for it. I also moved the idea of a thread ID lower in the stack and out of DifferentialMail, which should not be responsible for implementation details. NOTE: If you push this, it will cause a one-time break of threading for everyone using Outlook since I've changed the seed for generating Thread-Index. I feel like this is okay to avoid introducing more complexity here. Test Plan: Created and then updated a revision, messages delivered over Amazon SES threaded correctly in Mail.app. Verified headers. Unit tests. Reviewed By: rm Reviewers: aran, tuomaspelkonen, jungejason, rm Commenters: aran CC: aran, rm, epriestley Differential Revision: 195
2011-04-30 20:47:00 +02:00
'PhabricatorMailImplementationTestAdapter' => 'PhabricatorMailImplementationAdapter',
MetaMTA
2011-01-26 02:40:21 +01:00
'PhabricatorMetaMTAController' => 'PhabricatorController',
'PhabricatorMetaMTADAO' => 'PhabricatorLiskDAO',
Use PhabricatorDaemon for sending emails. Summary: Make PhabricatorMetaMTADaemon extend PhabricatorDaemon. Test Plan: send mail with the new daemon. Reviewed By: epriestley Reviewers: epriestley CC: epriestley Differential Revision: 74
2011-03-17 01:46:29 +01:00
'PhabricatorMetaMTADaemon' => 'PhabricatorDaemon',
Fix reply email parsing for linebreaks in "On <date>, <user> wrote:" quote identifier Summary: Move the parser to a separate class so it can be easily unit tested, add some tests. Properly parse emails with linebreaks in the quote line. Test Plan: Ran unit tests, used mail receiver to reply to an object. Reviewed By: cadamo Reviewers: aran, jungejason, tuomaspelkonen, cadamo CC: aran, cadamo, epriestley Differential Revision: 392
2011-06-01 17:33:14 +02:00
'PhabricatorMetaMTAEmailBodyParserTestCase' => 'PhabricatorTestCase',
MetaMTA
2011-01-26 02:40:21 +01:00
'PhabricatorMetaMTAListController' => 'PhabricatorMetaMTAController',
'PhabricatorMetaMTAMail' => 'PhabricatorMetaMTADAO',
Fix a threading issue with Amazon SES Summary: Amazon SES does not allow us to set a Message-ID header, which means that threads are incorrect in Mail.app (and presumably other applications which respect In-Reply-To and References) because the initial email does not have anything which attaches it to the rest of the thread. To fix this, never rely on Message-ID if the mailer doesn't support Message-ID. (In the Amazon SES case, Amazon generates its own Message-ID which we can't know ahead of time). I additionally used all the Lisk isolation from the other tests to make this testable and wrote tests for it. I also moved the idea of a thread ID lower in the stack and out of DifferentialMail, which should not be responsible for implementation details. NOTE: If you push this, it will cause a one-time break of threading for everyone using Outlook since I've changed the seed for generating Thread-Index. I feel like this is okay to avoid introducing more complexity here. Test Plan: Created and then updated a revision, messages delivered over Amazon SES threaded correctly in Mail.app. Verified headers. Unit tests. Reviewed By: rm Reviewers: aran, tuomaspelkonen, jungejason, rm Commenters: aran CC: aran, rm, epriestley Differential Revision: 195
2011-04-30 20:47:00 +02:00
'PhabricatorMetaMTAMailTestCase' => 'PhabricatorTestCase',
Mailing lists
2011-01-26 19:40:38 +01:00
'PhabricatorMetaMTAMailingList' => 'PhabricatorMetaMTADAO',
'PhabricatorMetaMTAMailingListEditController' => 'PhabricatorMetaMTAController',
'PhabricatorMetaMTAMailingListsController' => 'PhabricatorMetaMTAController',
Support email replies in Phabricator Summary: Provides support for per-user x per-object unique reply-to email addresses, plus SMTP integration. This does not actually make Phabricator use these in outbound email. Test Plan: Used test console to validate in-Phabricator routing and handling. Piped emails into the "mail_handler.php" script to validate mail parsing. Configured sendmail and sent mail to Phabricator. Technically I haven't conducted all parts of this test on the same machine since I lost the will to configure more SMTP servers after configuring phabricator.com Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 226
2011-05-05 08:09:42 +02:00
'PhabricatorMetaMTAReceiveController' => 'PhabricatorMetaMTAController',
'PhabricatorMetaMTAReceivedListController' => 'PhabricatorMetaMTAController',
'PhabricatorMetaMTAReceivedMail' => 'PhabricatorMetaMTADAO',
MetaMTA
2011-01-26 02:40:21 +01:00
'PhabricatorMetaMTASendController' => 'PhabricatorMetaMTAController',
Enable SendGrid Parse API as an inbound email handler Summary: Sendmail is seriously difficult to configure; SendGrid is extremely easy. It's also pretty expensive ($80/mo) but there are a bunch of startups that already have plans so it's effectively free for them. Test Plan: Configured SendGrid and sent reply email through it. Reviewed By: aran Reviewers: tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 376
2011-05-30 20:07:05 +02:00
'PhabricatorMetaMTASendGridReceiveController' => 'PhabricatorMetaMTAController',
MetaMetaView
2011-01-26 18:08:26 +01:00
'PhabricatorMetaMTAViewController' => 'PhabricatorMetaMTAController',
Allow Phabricator storage engines to be extended and configured Summary: See T344. Currently, there's a hard-coded 12MB filesize limit and some awkward interactions with MySQL's max_allowed_packet. Make this system generally more robust: - Move the upload limit to configuration. - Add setup steps which reconcile max_allowed_packet vs MySQL file storage limits. - Add a layer of indirection between uploading files and storage engines. - Allow the definition of new storage engines. - Define a local disk storage engine. - Add a "storage engine selector" class which manages choosing which storage engines to put files in. - Document storage engines. - Document file storage classes. Test Plan: Setup mode: - Disabled MySQL storage engine, misconfigured it, configured it correctly. - Disabled file storage engine, set it to something invalid, set it to something valid. - Verified max_allowed_packet is read correctly. Application mode: - Configured local file storage. - Uploaded large and small files. - Verified larger files were written to local storage. - Verified smaller files were written to MySQL blob storage. Documentation: - Read documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 695
2011-07-20 07:48:38 +02:00
'PhabricatorMySQLFileStorageEngine' => 'PhabricatorFileStorageEngine',
Modularize oauth.
2011-02-28 04:47:22 +01:00
'PhabricatorOAuthDefaultRegistrationController' => 'PhabricatorOAuthRegistrationController',
Github OAuth Summary: Test Plan: Reviewers: CC:
2011-02-21 07:47:56 +01:00
'PhabricatorOAuthDiagnosticsController' => 'PhabricatorAuthController',
'PhabricatorOAuthFailureView' => 'AphrontView',
'PhabricatorOAuthLoginController' => 'PhabricatorAuthController',
'PhabricatorOAuthProviderFacebook' => 'PhabricatorOAuthProvider',
'PhabricatorOAuthProviderGithub' => 'PhabricatorOAuthProvider',
Add Google as an OAuth2 provider (BETA) Summary: This is pretty straightforward, except: - We need to request read/write access to the address book to get the account ID (which we MUST have) and real name, email and account name (which we'd like to have). This is way more access than we should need, but there's apparently no "get_loggedin_user_basic_information" type of call in the Google API suite (or, at least, I couldn't find one). - We can't get the profile picture or profile URI since there's no Plus API access and Google users don't have meaningful public pages otherwise. - Google doesn't save the fact that you've authorized the app, so every time you want to login you need to reaffirm that you want to give us silly amounts of access. Phabricator sessions are pretty long-duration though so this shouldn't be a major issue. Test Plan: - Registered, logged out, and logged in with Google. - Registered, logged out, and logged in with Facebook / Github to make sure I didn't break anything. - Linked / unlinked Google accounts. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: aran CC: aran, epriestley, Makinde Differential Revision: 916
2011-09-09 01:37:22 +02:00
'PhabricatorOAuthProviderGoogle' => 'PhabricatorOAuthProvider',
Modularize oauth.
2011-02-28 04:47:22 +01:00
'PhabricatorOAuthRegistrationController' => 'PhabricatorAuthController',
OAuth linking/unlinking controls. Summary: Test Plan: Reviewers: CC:
2011-02-22 07:51:34 +01:00
'PhabricatorOAuthUnlinkController' => 'PhabricatorAuthController',
Basic task dependencies for Maniphest Summary: This allows you to edit dependencies. It is a better patch than it used to be. It depends on D725. - If you create a cycle, it just throws an exception and aborts the workflow. It should not do this. - Tasks which depend on the current task aren't shown in the UI. Need to add a new table for this. - Transaction text says "attached Task" but should probably say "added a dependency on task". Test Plan: Created valid and invalid dependencies between tasks. Created valid and invalid dependencies between revisions. Reviewed By: tuomaspelkonen Reviewers: davidreuss, jungejason, tuomaspelkonen, aran Commenters: codeblock CC: aran, codeblock, tuomaspelkonen, epriestley Differential Revision: 595
2011-07-05 22:18:47 +02:00
'PhabricatorObjectGraph' => 'AbstractDirectedGraph',
Add object status to Handles Summary: We use ObjectHandles as proxy objects which can refer to any other object in the system. Add the concept of the underlying object's "status" (e.g., open, closed or busy). This allows us to render completed tasks and revisions with strikethrough. In the future, if we implement OOO or something, we could render users with a "busy" status if they're on vacation, etc. Test Plan: Viewed a task with closed revisions and dependencies: https://secure.phabricator.com/file/view/PHID-FILE-6183e81286fa3288d33d/ Reviewed By: codeblock Reviewers: codeblock, hunterbridges, jungejason, tuomaspelkonen, aran CC: aran, codeblock Differential Revision: 772
2011-08-03 15:37:18 +02:00
'PhabricatorObjectHandleStatus' => 'PhabricatorObjectHandleConstants',
Add Related Commits for Owners Summary: For each commit, find the affected packages, and provide a way to search by package. Test Plan: create commits that touch and don't touch two packages, and verify that they display correctly in all the UI pages. Reviewers: epriestley, blair, nh, tuomaspelkonen Reviewed By: epriestley CC: benmathews, aran, epriestley, btrahan, jungejason, mpodobnik, prithvi Maniphest Tasks: T83 Differential Revision: 1208
2011-12-14 09:53:25 +01:00
'PhabricatorOwnerRelatedListController' => 'PhabricatorOwnersController',
owners
2011-04-03 23:48:36 +02:00
'PhabricatorOwnersController' => 'PhabricatorController',
'PhabricatorOwnersDAO' => 'PhabricatorLiskDAO',
Some owners write workflows.
2011-04-04 07:03:27 +02:00
'PhabricatorOwnersDeleteController' => 'PhabricatorOwnersController',
owners
2011-04-03 23:48:36 +02:00
'PhabricatorOwnersDetailController' => 'PhabricatorOwnersController',
Some owners write workflows.
2011-04-04 07:03:27 +02:00
'PhabricatorOwnersEditController' => 'PhabricatorOwnersController',
owners
2011-04-03 23:48:36 +02:00
'PhabricatorOwnersListController' => 'PhabricatorOwnersController',
'PhabricatorOwnersOwner' => 'PhabricatorOwnersDAO',
'PhabricatorOwnersPackage' => 'PhabricatorOwnersDAO',
Add Related Commits for Owners Summary: For each commit, find the affected packages, and provide a way to search by package. Test Plan: create commits that touch and don't touch two packages, and verify that they display correctly in all the UI pages. Reviewers: epriestley, blair, nh, tuomaspelkonen Reviewed By: epriestley CC: benmathews, aran, epriestley, btrahan, jungejason, mpodobnik, prithvi Maniphest Tasks: T83 Differential Revision: 1208
2011-12-14 09:53:25 +01:00
'PhabricatorOwnersPackageCommitRelationship' => 'PhabricatorOwnersDAO',
owners
2011-04-03 23:48:36 +02:00
'PhabricatorOwnersPath' => 'PhabricatorOwnersDAO',
Introduce PHID generation.
2011-01-23 06:09:13 +01:00
'PhabricatorPHID' => 'PhabricatorPHIDDAO',
'PhabricatorPHIDController' => 'PhabricatorController',
'PhabricatorPHIDDAO' => 'PhabricatorLiskDAO',
PhabricatorObjectHandles
2011-01-26 18:02:09 +01:00
'PhabricatorPHIDLookupController' => 'PhabricatorPHIDController',
Pastebin Summary: This is Paste. It needs some work, but epriestley recommended that I just commit something that works, and expand on that later. Specifically, it lacks the ability to view a raw paste right now, and to turn off line numbers, making it hard to copy/paste from for now. It works for showing other people code, however. Test Plan: Pasted stuff, and was able to view it, and see it in the list on /paste/. Put a file extension in the title, and saw that syntax highlighting worked as expected. Reviewers: epriestley CC: Differential Revision: 424
2011-06-10 08:53:53 +02:00
'PhabricatorPaste' => 'PhabricatorPasteDAO',
'PhabricatorPasteController' => 'PhabricatorController',
'PhabricatorPasteDAO' => 'PhabricatorLiskDAO',
"Paste" application tweaks Summary: Tweaks to the paste app: - I realized that unlike all the other apps, it makes more sense for the default view of this one to be "create paste" instead of "list pastes" since when you access the application directly you are most often wanting to share something. Swap list out of the default slot and make edit the default. - Make the textarea bigger (usability). - Allow you to copy an existing paste. - Implement 'raw view'. - Tweak/adjust list view (usability, formatting). - Tweak page titles. Test Plan: Created, copied, and listed pastes. Viewed raw paste. Created an invalid paste. Tried to create a copy of a nonexistant paste. Reviewed By: codeblock Reviewers: codeblock, jungejason, aran, tuomaspelkonen CC: aran, epriestley, codeblock Differential Revision: 456
2011-06-14 04:12:30 +02:00
'PhabricatorPasteListController' => 'PhabricatorPasteController',
Pastebin Summary: This is Paste. It needs some work, but epriestley recommended that I just commit something that works, and expand on that later. Specifically, it lacks the ability to view a raw paste right now, and to turn off line numbers, making it hard to copy/paste from for now. It works for showing other people code, however. Test Plan: Pasted stuff, and was able to view it, and see it in the list on /paste/. Put a file extension in the title, and saw that syntax highlighting worked as expected. Reviewers: epriestley CC: Differential Revision: 424
2011-06-10 08:53:53 +02:00
'PhabricatorPasteViewController' => 'PhabricatorPasteController',
Basic user/account tool.
2011-01-24 03:09:16 +01:00
'PhabricatorPeopleController' => 'PhabricatorController',
'PhabricatorPeopleEditController' => 'PhabricatorPeopleController',
'PhabricatorPeopleListController' => 'PhabricatorPeopleController',
Provide an activity log for login and administrative actions Summary: This isn't complete, but I figured I'd ship it for review while it's still smallish. Provide an activity log for high-level system actions (logins, admin actions). This basically allows two things to happen: - The log itself is useful if there are shenanigans. - Password login can check it and start CAPTCHA'ing users after a few failed attempts. I'm going to change how the admin stuff works a little bit too, since right now you can make someone an agent, grab their certificate, revert them back to a normal user, and then act on their behalf over Conduit. This is a little silly, I'm going to move "agent" to the create workflow instead. I'll also add a confirm/email step to the administrative password reset flow. Test Plan: Took various administrative and non-administrative actions, they appeared in the logs. Filtered the logs in a bunch of different ways. Reviewers: jungejason, tuomaspelkonen, aran CC: Differential Revision: 302
2011-05-18 03:42:21 +02:00
'PhabricatorPeopleLogsController' => 'PhabricatorPeopleController',
Basic user/account tool.
2011-01-24 03:09:16 +01:00
'PhabricatorPeopleProfileController' => 'PhabricatorPeopleController',
Rough cut of Project profile improvements Summary: - Old page was useless and dumb. - New page looks a little less bad, functions a little less poorly. - Still lots of work to be done. Test Plan: - Viewed a project. - Clicked all the links on the left nav. - Here is a screenshot: https://secure.phabricator.com/file/view/PHID-FILE-4buzquotb3fo4dhlicrw/ Reviewers: btrahan, jungejason Reviewed By: jungejason CC: aran, jungejason Maniphest Tasks: T681 Differential Revision: 1246
2011-12-17 05:01:38 +01:00
'PhabricatorProfileHeaderView' => 'AphrontView',
Rough cut of projects. Summary: Test Plan: Reviewers: CC:
2011-02-21 03:41:23 +01:00
'PhabricatorProject' => 'PhabricatorProjectDAO',
'PhabricatorProjectAffiliation' => 'PhabricatorProjectDAO',
'PhabricatorProjectAffiliationEditController' => 'PhabricatorProjectController',
'PhabricatorProjectController' => 'PhabricatorController',
Allow affiliations to carry project ownership information; transform profile images correctly Summary: This is sort of doing two things at once: - Add an "isOwner" flag to Project Affiliation to lay the groundwork for T237. - Rename the "QuickCreate" workflow to "Create" and funnel all creation through it. - Reorganize the image transformation stuff and use it to correctly crop/resize uploaded images. Test Plan: Created and edited projects and affailiations. Uploaded project, user, and profile photos. Verified existing thumbnailing in Maniphest still works properly. Reviewed By: cadamo Reviewers: cadamo, aran, jungejason, tuomaspelkonen CC: aran, epriestley, cadamo Differential Revision: 529
2011-06-26 17:37:47 +02:00
'PhabricatorProjectCreateController' => 'PhabricatorProjectController',
Rough cut of projects. Summary: Test Plan: Reviewers: CC:
2011-02-21 03:41:23 +01:00
'PhabricatorProjectDAO' => 'PhabricatorLiskDAO',
'PhabricatorProjectListController' => 'PhabricatorProjectController',
'PhabricatorProjectProfile' => 'PhabricatorProjectDAO',
'PhabricatorProjectProfileController' => 'PhabricatorProjectController',
Project list and profile view modifications Summary: Added some change on the project's list view, to show information about active tasks, population, etc. Also modified the "profile view", and added a class "PhabricatorProfileView" to render the profile, both on projects and users. Test Plan: play around the project directory :) Reviewers: epriestley ericfrenkiel CC: Differential Revision: 477
2011-06-18 10:13:56 +02:00
'PhabricatorProjectProfileEditController' => 'PhabricatorProjectController',
Allow Phabricator storage engines to be extended and configured Summary: See T344. Currently, there's a hard-coded 12MB filesize limit and some awkward interactions with MySQL's max_allowed_packet. Make this system generally more robust: - Move the upload limit to configuration. - Add setup steps which reconcile max_allowed_packet vs MySQL file storage limits. - Add a layer of indirection between uploading files and storage engines. - Allow the definition of new storage engines. - Define a local disk storage engine. - Add a "storage engine selector" class which manages choosing which storage engines to put files in. - Document storage engines. - Document file storage classes. Test Plan: Setup mode: - Disabled MySQL storage engine, misconfigured it, configured it correctly. - Disabled file storage engine, set it to something invalid, set it to something valid. - Verified max_allowed_packet is read correctly. Application mode: - Configured local file storage. - Uploaded large and small files. - Verified larger files were written to local storage. - Verified smaller files were written to MySQL blob storage. Documentation: - Read documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, epriestley, jungejason Differential Revision: 695
2011-07-20 07:48:38 +02:00
'PhabricatorProjectSubproject' => 'PhabricatorProjectDAO',
Automatically redirect 404's that wouldn't be 404s if they had a trailing slash to their trailing-slash counterparts.
2011-04-04 19:29:46 +02:00
'PhabricatorRedirectController' => 'PhabricatorController',
Fix conservative CSRF token cycling limit Summary: We currently cycle CSRF tokens every hour and check for the last two valid ones. This means that a form could go stale in as little as an hour, and is certainly stale after two. When a stale form is submitted, you basically get a terrible heisen-state where some of your data might persist if you're lucky but more likely it all just vanishes. The .js file below outlines some more details. This is a pretty terrible UX and we don't need to be as conservative about CSRF validation as we're being. Remedy this problem by: - Accepting the last 6 CSRF tokens instead of the last 1 (i.e., pages are valid for at least 6 hours, and for as long as 7). - Using JS to refresh the CSRF token every 55 minutes (i.e., pages connected to the internet are valid indefinitely). - Showing the user an explicit message about what went wrong when CSRF validation fails so the experience is less bewildering. They should now only be able to submit with a bad CSRF token if: - They load a page, disconnect from the internet for 7 hours, reconnect, and submit the form within 55 minutes; or - They are actually the victim of a CSRF attack. We could eventually fix the first one by tracking reconnects, which might be "free" once the notification server gets built. It will probably never be an issue in practice. Test Plan: - Reduced CSRF cycle frequency to 2 seconds, submitted a form after 15 seconds, got the CSRF exception. - Reduced csrf-refresh cycle frequency to 3 seconds, submitted a form after 15 seconds, got a clean form post. - Added debugging code the the csrf refresh to make sure it was doing sensible things (pulling different tokens, finding all the inputs). Reviewed By: aran Reviewers: tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 660
2011-07-13 23:05:18 +02:00
'PhabricatorRefreshCSRFController' => 'PhabricatorAuthController',
Add comment linking to Maniphest and Differential Summary: Allows you to link to comments with "D123#3" or "T123#3", then adds a pile of JS to try to make it not terrible. :/ The thing I'm trying to avoid here is when someone says "look at this! http://blog.com/#comment-239291" and you click and your browser jumps somewhere random and you have no idea which comment they meant. Since I really hate this, I've tried to avoid it by making sure the comment is always highlighted. Test Plan: Put T1#1 and D1#1 in remarkup and verified they linked properly. Clicked anchors on individual comments. Faked all comments hidden in Differential and verified they expanded on anchor or anchor change. Reviewed By: aran Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen CC: aran, epriestley Differential Revision: 383
2011-05-31 19:23:31 +02:00
'PhabricatorRemarkupRuleDifferential' => 'PhabricatorRemarkupRuleObjectName',
Provide a "reference-with-full-name" syntax for Remarkup Summary: Provide a {T123} syntax which pulls in the entire name of an object, not just a link to it. A major use for this is organizing projects using wiki pages. Since handle links show object status now, this lets you organize stuff in an ad-hoc way and get a reasonable overview of it. We can make handles richer in the future, too. The performance on this isn't perfect (it adds some potential single gets) but I think it's okay for now and I don't want to make remarkup engine even more complex until the preprocess/postprocess stuff has had a chance to settle and I'm more confident it works. In Differential and Maniphest we'll also incorrectly cache the object state/name, but that'll fix itself once I move the cache code to use preprocess/postprocess correctly. Test Plan: - See https://secure.phabricator.com/file/view/PHID-FILE-5f9ca32407bec20899b9/ for an example. - Generated and looked over the documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran, hunterbridges CC: skrul, aran, jungejason, epriestley Differential Revision: 784
2011-08-05 17:50:26 +02:00
'PhabricatorRemarkupRuleDifferentialHandle' => 'PhabricatorRemarkupRuleObjectHandle',
Restore linking of Diffusion commits.
2011-04-11 12:02:19 +02:00
'PhabricatorRemarkupRuleDiffusion' => 'PhutilRemarkupRule',
Rough implementation of drag-and-drop file uploads Summary: This gets all the major pieces working. Allows you to drag-and-drop files in Differential and Phriction, and embed files in remarkup with {Fxxx} references. See also task. I'm explicitly not documenting this yet since it's still pretty rough. Test Plan: Dragged and dropped stuff into Differential and Phriction. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran, tomo Commenters: tomo CC: aran, tomo, jungejason Differential Revision: 674
2011-07-15 23:17:55 +02:00
'PhabricatorRemarkupRuleEmbedFile' => 'PhutilRemarkupRule',
Image macros for Phabricator! Summary: Added long waited image macro support for differential and others. Test Plan: Tried a couple of different macros and made sure they appear nicely in the comment preview. Made sure that the normal comments are shown correctly. Reviewed By: epriestley Reviewers: epriestley CC: jungejason, tuomaspelkonen, epriestley Differential Revision: 129
2011-04-14 00:15:48 +02:00
'PhabricatorRemarkupRuleImageMacro' => 'PhutilRemarkupRule',
Add comment linking to Maniphest and Differential Summary: Allows you to link to comments with "D123#3" or "T123#3", then adds a pile of JS to try to make it not terrible. :/ The thing I'm trying to avoid here is when someone says "look at this! http://blog.com/#comment-239291" and you click and your browser jumps somewhere random and you have no idea which comment they meant. Since I really hate this, I've tried to avoid it by making sure the comment is always highlighted. Test Plan: Put T1#1 and D1#1 in remarkup and verified they linked properly. Clicked anchors on individual comments. Faked all comments hidden in Differential and verified they expanded on anchor or anchor change. Reviewed By: aran Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen CC: aran, epriestley Differential Revision: 383
2011-05-31 19:23:31 +02:00
'PhabricatorRemarkupRuleManiphest' => 'PhabricatorRemarkupRuleObjectName',
Provide a "reference-with-full-name" syntax for Remarkup Summary: Provide a {T123} syntax which pulls in the entire name of an object, not just a link to it. A major use for this is organizing projects using wiki pages. Since handle links show object status now, this lets you organize stuff in an ad-hoc way and get a reasonable overview of it. We can make handles richer in the future, too. The performance on this isn't perfect (it adds some potential single gets) but I think it's okay for now and I don't want to make remarkup engine even more complex until the preprocess/postprocess stuff has had a chance to settle and I'm more confident it works. In Differential and Maniphest we'll also incorrectly cache the object state/name, but that'll fix itself once I move the cache code to use preprocess/postprocess correctly. Test Plan: - See https://secure.phabricator.com/file/view/PHID-FILE-5f9ca32407bec20899b9/ for an example. - Generated and looked over the documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran, hunterbridges CC: skrul, aran, jungejason, epriestley Differential Revision: 784
2011-08-05 17:50:26 +02:00
'PhabricatorRemarkupRuleManiphestHandle' => 'PhabricatorRemarkupRuleObjectHandle',
Basic @mentions support Summary: Provides basic Remarkup support for @mentions. No application integration yet so these aren't terribly useful until that happens. Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-83d68e7af6085ae928df/ Reviewers: tomo, mroch, jsp Commenters: tomo CC: aran, tomo, epriestley Differential Revision: 517
2011-06-24 19:59:57 +02:00
'PhabricatorRemarkupRuleMention' => 'PhutilRemarkupRule',
Provide a "reference-with-full-name" syntax for Remarkup Summary: Provide a {T123} syntax which pulls in the entire name of an object, not just a link to it. A major use for this is organizing projects using wiki pages. Since handle links show object status now, this lets you organize stuff in an ad-hoc way and get a reasonable overview of it. We can make handles richer in the future, too. The performance on this isn't perfect (it adds some potential single gets) but I think it's okay for now and I don't want to make remarkup engine even more complex until the preprocess/postprocess stuff has had a chance to settle and I'm more confident it works. In Differential and Maniphest we'll also incorrectly cache the object state/name, but that'll fix itself once I move the cache code to use preprocess/postprocess correctly. Test Plan: - See https://secure.phabricator.com/file/view/PHID-FILE-5f9ca32407bec20899b9/ for an example. - Generated and looked over the documentation. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran, hunterbridges CC: skrul, aran, jungejason, epriestley Differential Revision: 784
2011-08-05 17:50:26 +02:00
'PhabricatorRemarkupRuleObjectHandle' => 'PhutilRemarkupRule',
Add comment linking to Maniphest and Differential Summary: Allows you to link to comments with "D123#3" or "T123#3", then adds a pile of JS to try to make it not terrible. :/ The thing I'm trying to avoid here is when someone says "look at this! http://blog.com/#comment-239291" and you click and your browser jumps somewhere random and you have no idea which comment they meant. Since I really hate this, I've tried to avoid it by making sure the comment is always highlighted. Test Plan: Put T1#1 and D1#1 in remarkup and verified they linked properly. Clicked anchors on individual comments. Faked all comments hidden in Differential and verified they expanded on anchor or anchor change. Reviewed By: aran Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen CC: aran, epriestley Differential Revision: 383
2011-05-31 19:23:31 +02:00
'PhabricatorRemarkupRuleObjectName' => 'PhutilRemarkupRule',
Add P### link to paste Summary:Make a new directory, src/infrastructure/markup/remarkup/markuprule/paste/ Make a new class called PhabricatorRemarkupRulePaste in that directory. Add the rule to DifferentialMarkupEngineFactory. Test Plan: Created a task in maniphest. Put P1 and P2 in the content. Created P1 and P2 in Paste. Verified P1 and P2 were highlighted and linked correctly. Reviewers:epriestley, codeblock CC:jungejason Differential Revision: 539
2011-06-27 08:57:43 +02:00
'PhabricatorRemarkupRulePaste' => 'PhabricatorRemarkupRuleObjectName',
Basic remarkup integration for Phriction Summary: Document linking and some general layout improvements. I'd like to eventually do more meta-dataey things with links (like store them separately and check them for 404s) but this is a decent start. Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-d756b94a06b69c273fce/ Reviewed By: jungejason Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 650
2011-07-12 05:14:46 +02:00
'PhabricatorRemarkupRulePhriction' => 'PhutilRemarkupRule',
Restore image proxying to Remarkup Summary: Previously, Remarkup allowed you to paste in an image URI and get an inline image. However, it did this by hotlinking the image which isn't so hot in an open source product. Restore this feature, but use image proxying instead. The existing image macro code does most of the work. There is a mild security risk depending on the network setup so I've left this default-disabled and made a note about it. It should be safe to enable for Facebook. Test Plan: Pasted in image and non-image links, got reasonable behavior. Verified proxying appears to work. Verified that file:// shenanigans produce 400. Reviewed By: tuomaspelkonen Reviewers: aran, jungejason, tuomaspelkonen Commenters: cpiro CC: aran, cpiro, tuomaspelkonen Differential Revision: 214
2011-05-02 23:20:24 +02:00
'PhabricatorRemarkupRuleProxyImage' => 'PhutilRemarkupRule',
Embedded youtube videos. Summary: Markup support for embedding Youtube videos. Test Plan: https://www.youtube.com/watch?v=Vw4KVoEVcr0 was embedded Reviewed By: epriestley Reviewers: epriestley CC: aran, epriestley Differential Revision: 353
2011-05-27 21:50:02 +02:00
'PhabricatorRemarkupRuleYoutube' => 'PhutilRemarkupRule',
Rough cut of Repositories and GitHub post-receive hooks. Summary: Test Plan: Reviewers: CC:
2011-02-13 03:26:15 +01:00
'PhabricatorRepository' => 'PhabricatorRepositoryDAO',
Sync up UUIDs and create project configs.
2011-04-06 05:49:31 +02:00
'PhabricatorRepositoryArcanistProject' => 'PhabricatorRepositoryDAO',
'PhabricatorRepositoryArcanistProjectEditController' => 'PhabricatorRepositoryController',
Rough cut of repository tracking Summary: Basic scaffolding for repository tracking, plus daemon infrastructure (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk). Test Plan: parsed Javelin git commit history via daemon Reviewers: CC:
2011-03-07 07:29:22 +01:00
'PhabricatorRepositoryCommit' => 'PhabricatorRepositoryDAO',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorRepositoryCommitChangeParserWorker' => 'PhabricatorRepositoryCommitParserWorker',
'PhabricatorRepositoryCommitData' => 'PhabricatorRepositoryDAO',
Rough cut of repository tracking Summary: Basic scaffolding for repository tracking, plus daemon infrastructure (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk). Test Plan: parsed Javelin git commit history via daemon Reviewers: CC:
2011-03-07 07:29:22 +01:00
'PhabricatorRepositoryCommitDiscoveryDaemon' => 'PhabricatorRepositoryDaemon',
HeraldCommitAdapter and some related junk.
2011-04-04 08:23:36 +02:00
'PhabricatorRepositoryCommitHeraldWorker' => 'PhabricatorRepositoryCommitParserWorker',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorRepositoryCommitMessageParserWorker' => 'PhabricatorRepositoryCommitParserWorker',
Add Related Commits for Owners Summary: For each commit, find the affected packages, and provide a way to search by package. Test Plan: create commits that touch and don't touch two packages, and verify that they display correctly in all the UI pages. Reviewers: epriestley, blair, nh, tuomaspelkonen Reviewed By: epriestley CC: benmathews, aran, epriestley, btrahan, jungejason, mpodobnik, prithvi Maniphest Tasks: T83 Differential Revision: 1208
2011-12-14 09:53:25 +01:00
'PhabricatorRepositoryCommitOwnersWorker' => 'PhabricatorRepositoryCommitParserWorker',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorRepositoryCommitParserWorker' => 'PhabricatorWorker',
'PhabricatorRepositoryCommitTaskDaemon' => 'PhabricatorRepositoryDaemon',
Rough cut of Repositories and GitHub post-receive hooks. Summary: Test Plan: Reviewers: CC:
2011-02-13 03:26:15 +01:00
'PhabricatorRepositoryController' => 'PhabricatorController',
Diffusion change parser for SVN. Summary: there is a small possibility this works correctly Test Plan: Reviewers: CC:
2011-03-11 23:13:23 +01:00
'PhabricatorRepositoryCreateController' => 'PhabricatorRepositoryController',
Rough cut of Repositories and GitHub post-receive hooks. Summary: Test Plan: Reviewers: CC:
2011-02-13 03:26:15 +01:00
'PhabricatorRepositoryDAO' => 'PhabricatorLiskDAO',
Rough cut of repository tracking Summary: Basic scaffolding for repository tracking, plus daemon infrastructure (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk). Test Plan: parsed Javelin git commit history via daemon Reviewers: CC:
2011-03-07 07:29:22 +01:00
'PhabricatorRepositoryDaemon' => 'PhabricatorDaemon',
Add basic detail-parser functionality.
2011-04-02 02:11:05 +02:00
'PhabricatorRepositoryDefaultCommitMessageDetailParser' => 'PhabricatorRepositoryCommitMessageDetailParser',
Fix repository deletion Summary: I never actually wrote this controller. Test Plan: Deleted a repository via web UI. Reviewed By: tuomaspelkonen Reviewers: tuomaspelkonen, jungejason, aran Commenters: aran CC: aran, tuomaspelkonen, epriestley Differential Revision: 231
2011-05-05 21:53:39 +02:00
'PhabricatorRepositoryDeleteController' => 'PhabricatorRepositoryController',
Diffusion change parser for SVN. Summary: there is a small possibility this works correctly Test Plan: Reviewers: CC:
2011-03-11 23:13:23 +01:00
'PhabricatorRepositoryEditController' => 'PhabricatorRepositoryController',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorRepositoryGitCommitChangeParserWorker' => 'PhabricatorRepositoryCommitChangeParserWorker',
Rough cut of repository tracking Summary: Basic scaffolding for repository tracking, plus daemon infrastructure (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk). Test Plan: parsed Javelin git commit history via daemon Reviewers: CC:
2011-03-07 07:29:22 +01:00
'PhabricatorRepositoryGitCommitDiscoveryDaemon' => 'PhabricatorRepositoryCommitDiscoveryDaemon',
Relax the same-origin check in the Git commit discovery daemon Summary: Git accepts either "git@x:/path" or "ssh://git@x.com/path" URIs to mean the exact same thing, which is causing some false positives and confusion, particularly because we sometimes mutate URIs. Since this is just a sanity check, we don't really care about the username, domain or credentials -- matching the paths is good enough. We're just trying to make it hard to shoot yourself in the foot by copy-pasting the same local path into two repositories and forgetting to change one, like I did. :P Relax the check to only verify the paths are the same. Test Plan: - Ran unit tests, which should fully cover things. - Ran commit discovery daemon in debug mode on incorrectly and correctly configured repositories. Reviewers: ajtrichards, jungejason, btrahan Reviewed By: jungejason CC: aran, jungejason Maniphest Tasks: T710 Differential Revision: https://secure.phabricator.com/D1279
2011-12-23 17:11:11 +01:00
'PhabricatorRepositoryGitCommitDiscoveryDaemonTestCase' => 'PhabricatorTestCase',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorRepositoryGitCommitMessageParserWorker' => 'PhabricatorRepositoryCommitMessageParserWorker',
Add Mercurial repository configuration and local pull support Summary: No actual parsing/import yet, but now you can define and pull Mercurial repositories. I merged most of the local pull code so we can share it between hg/git. Test Plan: - Created a new Mercurial repository to track Codeigniter off Bitbucket - Edited / saved / etc. - Launched the mercurial pull daemon, it pulled the repo. Killed and relaunched, it updated the repo. - Launched the git fetch deamon, it still works correctly. Reviewers: Makinde, aran, jungejason, tuomaspelkonen Reviewed By: Makinde CC: aran, Makinde Differential Revision: 793
2011-08-09 21:47:46 +02:00
'PhabricatorRepositoryGitFetchDaemon' => 'PhabricatorRepositoryPullLocalDaemon',
Diffusion change parser for SVN. Summary: there is a small possibility this works correctly Test Plan: Reviewers: CC:
2011-03-11 23:13:23 +01:00
'PhabricatorRepositoryListController' => 'PhabricatorRepositoryController',
Basic support for Mercurial in Diffusion Summary: Change import script plus almost all the view stuff. Still some rough edges but this seems to mostly work. Blame is currently unsupported but I think everything else works properly. Test Plan: Imported the hg repository itself. It doesn't immediately seem completely broken. Here are some screens: https://secure.phabricator.com/file/view/PHID-FILE-1438b71cc7c4a2eb4569/ https://secure.phabricator.com/file/view/PHID-FILE-3cec4f72f39e7de2d041/ https://secure.phabricator.com/file/view/PHID-FILE-2ea4883f160e8e5098f9/ https://secure.phabricator.com/file/view/PHID-FILE-35f751a36ebf65399ade/ All the parsers were able to churn through it without errors. Ran the new "reparse.php" script in various one-commit and repository modes. Browsed/imported some git repos for good measure. NOTE: The hg repository is only 15,000 commits and around 1,000 files. Performance is okay but hg doesn't provide performant, native APIs to get some data efficiently so we have to do some dumb stuff. If some of these interfaces are cripplingly slow or whatever, let me know and we can start bundling some Mercurial extensions with Arcanist. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, Makinde, epriestley Differential Revision: 960
2011-09-26 20:07:38 +02:00
'PhabricatorRepositoryMercurialCommitChangeParserWorker' => 'PhabricatorRepositoryCommitChangeParserWorker',
Add a Mercurial commit discovery daemon Summary: Repository import has three major steps: - Commit discovery (serial) - Message parsing (parallel, mostly VCS independent) - Change parsing (parallel, highly VCS dependent) This implements commit discovery for Mercurial, similar to git's parsing: - List the heads of all the branches. - If we haven't already discovered them, follow them back to their roots (or the first commit we have discovered). - Import all the newly discovered commits, oldest first. This is a little complicated but it ensures we discover commits in depth order, so the discovery process is robust against interruption/failure. If we just inserted commits as we went, we might read the tip, insert it, and then crash. When we ran again, we'd think we had already discovered commits older than HEAD. This also allows later stages to rely on being able to find Phabricator commit IDs which correspond to parent commits. NOTE: This importer is fairly slow because "hg" has a large startup time (compare "hg --version" to "git --version" and "svn --version"; on my machine, hg has 60ms of overhead for any command) and we need to run many commands (see the whole "hg id" mess). You can expect something like 10,000 per hour, which means you may need to run overnight to discover a large repository (IIRC, the svn/git discovery processes are both about an order of magnitude faster). We could improve this with batching, but I want to keep it as simple as possible for now. Test Plan: Discovered all the commits in the main Mercurial repository, http://selenic.com/repo/hg. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, Makinde Differential Revision: 943
2011-09-16 12:56:23 +02:00
'PhabricatorRepositoryMercurialCommitDiscoveryDaemon' => 'PhabricatorRepositoryCommitDiscoveryDaemon',
Add a Mercurial message parser Summary: See D943, this is the second parse stage. This will mark Differential revisions as "Committed" among other things. Almost all the logic here is shared between VCSes so the implementation itself is straightforward. Test Plan: Parsed all messages for the official Mercurial repository. Reviewers: Makinde, jungejason, nh, tuomaspelkonen, aran Reviewed By: Makinde CC: aran, Makinde Differential Revision: 944
2011-09-16 18:37:15 +02:00
'PhabricatorRepositoryMercurialCommitMessageParserWorker' => 'PhabricatorRepositoryCommitMessageParserWorker',
Add Mercurial repository configuration and local pull support Summary: No actual parsing/import yet, but now you can define and pull Mercurial repositories. I merged most of the local pull code so we can share it between hg/git. Test Plan: - Created a new Mercurial repository to track Codeigniter off Bitbucket - Edited / saved / etc. - Launched the mercurial pull daemon, it pulled the repo. Killed and relaunched, it updated the repo. - Launched the git fetch deamon, it still works correctly. Reviewers: Makinde, aran, jungejason, tuomaspelkonen Reviewed By: Makinde CC: aran, Makinde Differential Revision: 793
2011-08-09 21:47:46 +02:00
'PhabricatorRepositoryMercurialPullDaemon' => 'PhabricatorRepositoryPullLocalDaemon',
'PhabricatorRepositoryPullLocalDaemon' => 'PhabricatorRepositoryDaemon',
Restore "Shortcuts" feature to Diffusion.
2011-03-31 09:33:44 +02:00
'PhabricatorRepositoryShortcut' => 'PhabricatorRepositoryDAO',
Diffusion change parser for SVN. Summary: there is a small possibility this works correctly Test Plan: Reviewers: CC:
2011-03-11 23:13:23 +01:00
'PhabricatorRepositorySvnCommitChangeParserWorker' => 'PhabricatorRepositoryCommitChangeParserWorker',
Increase parseriness of some parsery things. Summary: None of these are parsnips. Test Plan: Reviewers: CC:
2011-03-11 18:34:22 +01:00
'PhabricatorRepositorySvnCommitDiscoveryDaemon' => 'PhabricatorRepositoryCommitDiscoveryDaemon',
'PhabricatorRepositorySvnCommitMessageParserWorker' => 'PhabricatorRepositoryCommitMessageParserWorker',
Add storage for repository symbol tracking Summary: See T315 for an extensive description of this feature. Adds the descibed storage table. Test Plan: Used phpsh to read/write symbol objects. Reviewers: jungejason, nh, tuomaspelkonen, aran Reviewed By: tuomaspelkonen CC: aran, epriestley, tuomaspelkonen Differential Revision: 897
2011-09-05 02:31:16 +02:00
'PhabricatorRepositorySymbol' => 'PhabricatorRepositoryDAO',
Relax the same-origin check in the Git commit discovery daemon Summary: Git accepts either "git@x:/path" or "ssh://git@x.com/path" URIs to mean the exact same thing, which is causing some false positives and confusion, particularly because we sometimes mutate URIs. Since this is just a sanity check, we don't really care about the username, domain or credentials -- matching the paths is good enough. We're just trying to make it hard to shoot yourself in the foot by copy-pasting the same local path into two repositories and forgetting to change one, like I did. :P Relax the check to only verify the paths are the same. Test Plan: - Ran unit tests, which should fully cover things. - Ran commit discovery daemon in debug mode on incorrectly and correctly configured repositories. Reviewers: ajtrichards, jungejason, btrahan Reviewed By: jungejason CC: aran, jungejason Maniphest Tasks: T710 Differential Revision: https://secure.phabricator.com/D1279
2011-12-23 17:11:11 +01:00
'PhabricatorRepositoryTestCase' => 'PhabricatorTestCase',
Add an Amazon S3 storage engine for Phabricator Summary: Implements an S3 storage engine option for Phabricator. Test Plan: - Uploaded files to S3. - Looked at them. - Verified they appeared in S3 using the S3 file browser. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 752
2011-07-31 22:54:58 +02:00
'PhabricatorS3FileStorageEngine' => 'PhabricatorFileStorageEngine',
Allow revisions to be edited from Maniphest Summary: You can currently attach tasks to revisions from Differential, but not revisions to tasks from Maniphest. Allow editing from either side. This logic is kind of tricky but the alternative was massive code duplication. Test Plan: Added and removed revisions from maniphest. Added and removed tasks from differential. This should have no impact on the Facebook install since none of this is used there. Reviewed By: aran Reviewers: tomo, tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 288
2011-05-16 20:43:39 +02:00
'PhabricatorSearchAttachController' => 'PhabricatorSearchController',
Rought cut of search. Summary: Botched this pretty badly in git so we'll see how much I broke. :/ Test Plan: Reviewers: CC:
2011-02-15 00:34:20 +01:00
'PhabricatorSearchBaseController' => 'PhabricatorController',
Add commits to the Phabricator search index Summary: create the indexer for commit Test Plan: run the reindex_one_commit.php against one existing commit and it is returned in search result on the webpage; run parse_one_commit against another commit; modified reindex_everything.php to let it only parse one commit after loading all commits. Reviewed By: epriestley Reviewers: epriestley, aran CC: aran, jungejason, epriestley, debow Differential Revision: 490
2011-06-20 06:02:48 +02:00
'PhabricatorSearchCommitIndexer' => 'PhabricatorSearchDocumentIndexer',
Rought cut of search. Summary: Botched this pretty badly in git so we'll see how much I broke. :/ Test Plan: Reviewers: CC:
2011-02-15 00:34:20 +01:00
'PhabricatorSearchController' => 'PhabricatorSearchBaseController',
'PhabricatorSearchDAO' => 'PhabricatorLiskDAO',
'PhabricatorSearchDifferentialIndexer' => 'PhabricatorSearchDocumentIndexer',
'PhabricatorSearchDocument' => 'PhabricatorSearchDAO',
'PhabricatorSearchDocumentField' => 'PhabricatorSearchDAO',
'PhabricatorSearchDocumentRelationship' => 'PhabricatorSearchDAO',
Provide an indirection layer between documents and the search engine Summary: In preparation for adding another search engine (see T355): - Rename "executor" to "engine". - Move all engine-specific operations into the engine. Specifically, this means that indexing moves out of the document store and into the engine (it was sort of silly where it was before). - Split choice of an engine into an overridable "selector" class, a base API, and a concrete MySQL implementation (just like storage engine selection). - Make all callers go through the indirection layer. The default selector just unconditionally selects the MySQL engine, but now (with D786) I can build an Elastic Search engine and you guys can build a multi-target engine if you want and I don't get there fast enough. Test Plan: - Created a new document (task). - Searched for and found it. - Viewed index reconstruction. Reviewed By: jungejason Reviewers: jungejason, amckinley, tuomaspelkonen, aran CC: aran, jungejason, epriestley Differential Revision: 788
2011-08-08 00:14:23 +02:00
'PhabricatorSearchEngineMySQL' => 'PhabricatorSearchEngine',
Index "owner" relationship in search correctly for Revisions Summary: The owners of a revision are only really the reviewers when the revision is in NEEDS_REVIEW. Also build a raw indexed document viewer so you can look at the index of a document from the web interface. Finally, reindex revisions when comments are added, not just when the revision itself is edited. Test Plan: Toggled abandon/reclaim on a revision and verified the relationships indexed properly. Reviewed By: jungejason Reviewers: aran, jungejason, tuomaspelkonen CC: aran, epriestley, jungejason Differential Revision: 470
2011-06-15 16:43:43 +02:00
'PhabricatorSearchIndexController' => 'PhabricatorSearchBaseController',
Rought cut of search. Summary: Botched this pretty badly in git so we'll see how much I broke. :/ Test Plan: Reviewers: CC:
2011-02-15 00:34:20 +01:00
'PhabricatorSearchManiphestIndexer' => 'PhabricatorSearchDocumentIndexer',
Phriction handles and search Summary: Index Phriction documents in search, and allow PhabricatorObjectHandleData to load them. Test Plan: Searched for "pokemons", got my wiki page as a search result. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, hsb Differential Revision: 648
2011-07-12 02:29:08 +02:00
'PhabricatorSearchPhrictionIndexer' => 'PhabricatorSearchDocumentIndexer',
Rought cut of search. Summary: Botched this pretty badly in git so we'll see how much I broke. :/ Test Plan: Reviewers: CC:
2011-02-15 00:34:20 +01:00
'PhabricatorSearchQuery' => 'PhabricatorSearchDAO',
Improve search result listing Summary: Make it prettier, paginate, add user pictures, show document types, clean some stuff up a little. Plenty of room for improvement but this should make it a lot more useful. Test Plan: Here's what the new one looks like: https://secure.phabricator.com/file/view/PHID-FILE-edce2b83c2e3a121c2b7/ Reviewed By: jungejason Reviewers: tomo, jungejason, aran, tuomaspelkonen, mroch Commenters: tomo CC: aran, tomo, jungejason, epriestley Differential Revision: 545
2011-06-28 23:35:02 +02:00
'PhabricatorSearchResultView' => 'AphrontView',
Allow revisions to be edited from Maniphest Summary: You can currently attach tasks to revisions from Differential, but not revisions to tasks from Maniphest. Allow editing from either side. This logic is kind of tricky but the alternative was massive code duplication. Test Plan: Added and removed revisions from maniphest. Added and removed tasks from differential. This should have no impact on the Facebook install since none of this is used there. Reviewed By: aran Reviewers: tomo, tuomaspelkonen, jungejason, aran CC: aran, epriestley Differential Revision: 288
2011-05-16 20:43:39 +02:00
'PhabricatorSearchSelectController' => 'PhabricatorSearchController',
Index users in search results. Summary: Add users to the search results. I need to follow this up with a patch to make the search results stop being terrible. I'll do that. Test Plan: Searched for users, ran "reindex_all_users.php" Reviewed By: jungejason Reviewers: tomo, jungejason, aran CC: aran, jungejason Differential Revision: 508
2011-06-23 22:31:20 +02:00
'PhabricatorSearchUserIndexer' => 'PhabricatorSearchDocumentIndexer',
Port the "Slowvote" application Summary: Port slowvote. This has some style/layout roughness but gets us most of the way there. I'll followup to fix some of the markup issues. Test Plan: Created and voted in several different kinds of poll. Reviewed By: codeblock Reviewers: codeblock, tomo, jungejason, aran, tuomaspelkonen Commenters: aran, jungejason CC: aran, codeblock, jungejason, epriestley Differential Revision: 613
2011-07-08 20:13:11 +02:00
'PhabricatorSlowvoteChoice' => 'PhabricatorSlowvoteDAO',
'PhabricatorSlowvoteComment' => 'PhabricatorSlowvoteDAO',
'PhabricatorSlowvoteController' => 'PhabricatorController',
'PhabricatorSlowvoteCreateController' => 'PhabricatorSlowvoteController',
'PhabricatorSlowvoteDAO' => 'PhabricatorLiskDAO',
'PhabricatorSlowvoteListController' => 'PhabricatorSlowvoteController',
'PhabricatorSlowvoteOption' => 'PhabricatorSlowvoteDAO',
'PhabricatorSlowvotePoll' => 'PhabricatorSlowvoteDAO',
'PhabricatorSlowvotePollController' => 'PhabricatorSlowvoteController',
More phabricator organizational stuff.
2011-01-23 02:48:55 +01:00
'PhabricatorStandardPageView' => 'AphrontPageView',
Add /status/
2011-04-08 20:13:29 +02:00
'PhabricatorStatusController' => 'PhabricatorController',
Add a custom lint name hook to Phabricator Summary: Allow Conduit method so they stop raising lint warnings. See D874. Test Plan: Ran "arc lint" on conduit files and was no longer given frivolous warnings. Reviewers: nh, jungejason, tuomaspelkonen, aran Reviewed By: nh CC: aran, nh, epriestley Differential Revision: 875
2011-08-30 22:12:20 +02:00
'PhabricatorSymbolNameLinter' => 'ArcanistXHPASTLintNamingHook',
Rough cut of Workers Summary: workers do work, provided I have written them correctly. perhaps it is so. Test Plan: Reviewers: CC:
2011-03-10 22:48:29 +01:00
'PhabricatorTaskmasterDaemon' => 'PhabricatorDaemon',
Provide an "isolated" database connection for testing Summary: This provides a new connection which doesn't connect to anything, so effects can be isolated to the current process (for unit testing). Test Plan: Ran unit tests. Reviewed By: aran Reviewers: aran, tuomaspelkonen, jungejason CC: aran, epriestley Differential Revision: 193
2011-04-30 19:11:41 +02:00
'PhabricatorTestCase' => 'ArcanistPhutilTestCase',
Rough cut of repository tracking Summary: Basic scaffolding for repository tracking, plus daemon infrastructure (Timelines, Cursors) and some fixes (memory usage, mysql_connect() junk). Test Plan: parsed Javelin git commit history via daemon Reviewers: CC:
2011-03-07 07:29:22 +01:00
'PhabricatorTimelineCursor' => 'PhabricatorTimelineDAO',
'PhabricatorTimelineDAO' => 'PhabricatorLiskDAO',
'PhabricatorTimelineEvent' => 'PhabricatorTimelineDAO',
'PhabricatorTimelineEventData' => 'PhabricatorTimelineDAO',
Countdown Summary: Addon that allows you to create a live countdown page to some event. Here is the ticket that this code is based on https://secure.phabricator.com/T36 Test Plan: Tested by manually setting dates in the timer.js file and checking if they made sense. I'm not sure if it works across different timezones though. Reviewers: epriestley CC: Differential Revision: 436
2011-06-13 01:06:17 +02:00
'PhabricatorTimer' => 'PhabricatorCountdownDAO',
Basic image thumbnailing Summary: This is still very rough but provides basic support for generating image thumbnails. I need to separate stuff out a bit but I'm going to integrate into Maniphest before I hit the profile stuff so this seems like a reasonable starting point. Test Plan: Generated some image thumbnails in various sizes. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran CC: aran Differential Revision: 333
2011-05-22 23:40:51 +02:00
'PhabricatorTransformedFile' => 'PhabricatorFileDAO',
Add a little more unit test documentation, fail loudly when isolation prevents a query Summary: - Provide an example unit test, and document it. - Document database isolation better. - When we issue an unsimulated query to the isolated connection, throw a helpful message. - Pygments is complaining about my madeup "lang=demo", change it to "lang=text". Test Plan: - Ran the unit test (sanity check). - Ran all other unit tests (verify I didn't break isolation). - Added a queryfx(..., 'SELECT 1') to a test and verified it throws. - Read the documentation. Reviewed By: edward Reviewers: edward, jungejason, tuomaspelkonen, aran CC: aran, edward Differential Revision: 773
2011-08-03 17:17:53 +02:00
'PhabricatorTrivialTestCase' => 'PhabricatorTestCase',
Typeaheads
2011-01-25 22:48:05 +01:00
'PhabricatorTypeaheadCommonDatasourceController' => 'PhabricatorTypeaheadDatasourceController',
'PhabricatorTypeaheadDatasourceController' => 'PhabricatorController',
AphrontPagerView and UIExamples.
2011-04-01 02:06:33 +02:00
'PhabricatorUIExampleController' => 'PhabricatorController',
'PhabricatorUIExampleRenderController' => 'PhabricatorUIExampleController',
AphrontListFilterView, for list filtering.
2011-04-04 00:50:06 +02:00
'PhabricatorUIListFilterExample' => 'PhabricatorUIExample',
AphrontPagerView and UIExamples.
2011-04-01 02:06:33 +02:00
'PhabricatorUIPagerExample' => 'PhabricatorUIExample',
Basic user/account tool.
2011-01-24 03:09:16 +01:00
'PhabricatorUser' => 'PhabricatorUserDAO',
Refactor user settings Summary: I want to do two things here: - Add SSH Keys - Move "Preferences" into this panel But this controller was pretty gigantic and messy. Split it apart and use delegation instead. There are no functional changes. I changed some of the conduit certificate text to simplify it since no one should need to go through that workflow anymore, given the existence of "arc install-certificate". Test Plan: - Edited realname, including attempting to remove it. - Edited profile picture. - Edited timezone. - Edited email, including attempting to remove it. - Regenerated condiut certificate. - Linked and unlinked an OAuth account. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 688
2011-07-18 17:02:00 +02:00
'PhabricatorUserAccountSettingsPanelController' => 'PhabricatorUserSettingsPanelController',
'PhabricatorUserConduitSettingsPanelController' => 'PhabricatorUserSettingsPanelController',
Basic user/account tool.
2011-01-24 03:09:16 +01:00
'PhabricatorUserDAO' => 'PhabricatorLiskDAO',
Add optional "Re:" prefix to all threaded mail and allow disabling mail about your own actions Summary: - Mail.app on Lion has cumbersome threading rules, see T782. Add an option to stick "Re: " in front of all threaded mail so it behaves. This is horrible, but apparently the least-horrible option. - While I was in there, I added an option for T228. Test Plan: - Sent a bunch of threaded and unthreaded mail with varous "Re:" settings, seemed to get "Re:" in the right places. - Disabled email about my stuff, created a task with just me, got voided mail, added a CC, got mail to just the CC. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, mkjones Maniphest Tasks: T228, T782 Differential Revision: https://secure.phabricator.com/D1448
2012-01-18 05:32:28 +01:00
'PhabricatorUserEmailPreferenceSettingsPanelController' => 'PhabricatorUserSettingsPanelController',
Refactor user settings Summary: I want to do two things here: - Add SSH Keys - Move "Preferences" into this panel But this controller was pretty gigantic and messy. Split it apart and use delegation instead. There are no functional changes. I changed some of the conduit certificate text to simplify it since no one should need to go through that workflow anymore, given the existence of "arc install-certificate". Test Plan: - Edited realname, including attempting to remove it. - Edited profile picture. - Edited timezone. - Edited email, including attempting to remove it. - Regenerated condiut certificate. - Linked and unlinked an OAuth account. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 688
2011-07-18 17:02:00 +02:00
'PhabricatorUserEmailSettingsPanelController' => 'PhabricatorUserSettingsPanelController',
Provide an activity log for login and administrative actions Summary: This isn't complete, but I figured I'd ship it for review while it's still smallish. Provide an activity log for high-level system actions (logins, admin actions). This basically allows two things to happen: - The log itself is useful if there are shenanigans. - Password login can check it and start CAPTCHA'ing users after a few failed attempts. I'm going to change how the admin stuff works a little bit too, since right now you can make someone an agent, grab their certificate, revert them back to a normal user, and then act on their behalf over Conduit. This is a little silly, I'm going to move "agent" to the create workflow instead. I'll also add a confirm/email step to the administrative password reset flow. Test Plan: Took various administrative and non-administrative actions, they appeared in the logs. Filtered the logs in a bunch of different ways. Reviewers: jungejason, tuomaspelkonen, aran CC: Differential Revision: 302
2011-05-18 03:42:21 +02:00
'PhabricatorUserLog' => 'PhabricatorUserDAO',
Github OAuth Summary: Test Plan: Reviewers: CC:
2011-02-21 07:47:56 +01:00
'PhabricatorUserOAuthInfo' => 'PhabricatorUserDAO',
Refactor user settings Summary: I want to do two things here: - Add SSH Keys - Move "Preferences" into this panel But this controller was pretty gigantic and messy. Split it apart and use delegation instead. There are no functional changes. I changed some of the conduit certificate text to simplify it since no one should need to go through that workflow anymore, given the existence of "arc install-certificate". Test Plan: - Edited realname, including attempting to remove it. - Edited profile picture. - Edited timezone. - Edited email, including attempting to remove it. - Regenerated condiut certificate. - Linked and unlinked an OAuth account. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 688
2011-07-18 17:02:00 +02:00
'PhabricatorUserOAuthSettingsPanelController' => 'PhabricatorUserSettingsPanelController',
Add change password settings panel Summary: In password-based auth environments, there is now a user settings panel to allow them to change their password. Test Plan: Click settings, choose password from the left: * enter current password, new password (twice), log out, and log in with new password * enter current password, non-matching passwords, and get error * enter invalid old password, and get error * use firebug to change csrf token and verify that it does not save with and invalid token Changed config to disable password auth, loaded settings panel and saw that password was no longer visible. Tried loading the panel anyway and got redirected. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: 890
2011-09-04 10:53:58 +02:00
'PhabricatorUserPasswordSettingsPanelController' => 'PhabricatorUserSettingsPanelController',
Move "Preferences" to "Settings" Summary: It makes more sense to just make this a settings panel rather than a standalone app, particularly since setting panels are relatively well separated now. Also default-disabled the SSH Keys interface since it won't currently be useful for most installs. Test Plan: Edited preferences. Reviewed By: jungejason Reviewers: tuomaspelkonen, jungejason, aran CC: aran, jungejason Differential Revision: 716
2011-07-24 20:02:08 +02:00
'PhabricatorUserPreferenceSettingsPanelController' => 'PhabricatorUserSettingsPanelController',
User preferences ported from tools Summary: Internal tools, e.g., differential and diffusion have user defined preferences for monospaced font and the option for showing either the name of the tool or the glyph of the tool in the title. These preferences were ported to phabricator. These preferences can be modified in /preferences/ and they both affect diffusion and differential at the moment. Test Plan: * Created an empty database * Loaded /preferences/ and modified the monospaced font and clicked save * Confirmed that the same page was loaded with the message that preferences have been saved and that the example text used the user defined font * in /preferences/ changed the option to show tool names as plain text and clicked save * Confirmed that the same page was loaded with '[Preferences]' in the title instead of a glyph * These same tests were also executed for differential and diffusion Reviewers: epriestley CC: jungejason Differential Revision: 91
2011-03-31 04:21:09 +02:00
'PhabricatorUserPreferences' => 'PhabricatorUserDAO',
Slightly more sophisticated profiles. Summary: Test Plan: Reviewers: CC:
2011-02-20 03:28:41 +01:00
'PhabricatorUserProfile' => 'PhabricatorUserDAO',
Unify profile and avatar images, move profile editing into settings Summary: See T266. Combine these interfaces into one and move it to settings. Test Plan: Edited my profile and account. Reviewers: codeblock, tcook, jungejason, tuomaspelkonen, aran CC: Differential Revision: 722
2011-07-25 00:03:59 +02:00
'PhabricatorUserProfileSettingsPanelController' => 'PhabricatorUserSettingsPanelController',
Allow users to associate SSH Public Keys with their accounts Summary: With the sshd-vcs thing I hacked together, this will enable Phabricator to host repositories without requiring users to have SSH accounts. I also fixed "subporjects" and added an explicit ENGINE to it. Test Plan: Created, edited and deleted public keys. Attempted to add the same public key twice. Attempted to add invalid and unnamed public keys. Reviewed By: aran Reviewers: jungejason, tuomaspelkonen, aran, cadamo, codeblock CC: aran, epriestley Differential Revision: 711
2011-07-22 19:17:57 +02:00
'PhabricatorUserSSHKey' => 'PhabricatorUserDAO',
'PhabricatorUserSSHKeysSettingsPanelController' => 'PhabricatorUserSettingsPanelController',
Some acutal conduit authentication.
2011-02-06 07:36:21 +01:00
'PhabricatorUserSettingsController' => 'PhabricatorPeopleController',
Refactor user settings Summary: I want to do two things here: - Add SSH Keys - Move "Preferences" into this panel But this controller was pretty gigantic and messy. Split it apart and use delegation instead. There are no functional changes. I changed some of the conduit certificate text to simplify it since no one should need to go through that workflow anymore, given the existence of "arc install-certificate". Test Plan: - Edited realname, including attempting to remove it. - Edited profile picture. - Edited timezone. - Edited email, including attempting to remove it. - Regenerated condiut certificate. - Linked and unlinked an OAuth account. Reviewed By: jungejason Reviewers: jungejason, tuomaspelkonen, aran CC: aran, jungejason Differential Revision: 688
2011-07-18 17:02:00 +02:00
'PhabricatorUserSettingsPanelController' => 'PhabricatorPeopleController',
Unify logic for username validation Summary: Revisit of D1254. Don't require lowercase, just standardize the logic. The current implementation has nonuniform logic -- PeopleEditController forbids uppercase. Test Plan: Ran unit tests, see also D1254. Reviewers: btrahan, jungejason, aran Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D1415
2012-01-16 16:30:28 +01:00
'PhabricatorUserTestCase' => 'PhabricatorTestCase',
Rough cut of Workers Summary: workers do work, provided I have written them correctly. perhaps it is so. Test Plan: Reviewers: CC:
2011-03-10 22:48:29 +01:00
'PhabricatorWorkerDAO' => 'PhabricatorLiskDAO',
'PhabricatorWorkerTask' => 'PhabricatorWorkerDAO',
'PhabricatorWorkerTaskData' => 'PhabricatorWorkerDAO',
Improve daemon console.
2011-03-27 07:55:18 +02:00
'PhabricatorWorkerTaskDetailController' => 'PhabricatorDaemonController',
Add buttons to delete or free tasks from the queue Summary: See T709. I also ran into a case in Drydock where this is useful for testing/development. Test Plan: Freed lease of a task; deleted a task. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T709 Differential Revision: https://secure.phabricator.com/D1469
2012-01-24 01:36:32 +01:00
'PhabricatorWorkerTaskUpdateController' => 'PhabricatorDaemonController',
xhpastview
2011-04-07 04:17:05 +02:00
'PhabricatorXHPASTViewController' => 'PhabricatorController',
'PhabricatorXHPASTViewDAO' => 'PhabricatorLiskDAO',
'PhabricatorXHPASTViewFrameController' => 'PhabricatorXHPASTViewController',
'PhabricatorXHPASTViewFramesetController' => 'PhabricatorXHPASTViewController',
'PhabricatorXHPASTViewInputController' => 'PhabricatorXHPASTViewPanelController',
'PhabricatorXHPASTViewPanelController' => 'PhabricatorXHPASTViewController',
'PhabricatorXHPASTViewParseTree' => 'PhabricatorXHPASTViewDAO',
'PhabricatorXHPASTViewRunController' => 'PhabricatorXHPASTViewController',
'PhabricatorXHPASTViewStreamController' => 'PhabricatorXHPASTViewPanelController',
'PhabricatorXHPASTViewTreeController' => 'PhabricatorXHPASTViewPanelController',
Very rough cut of DarkConsole + XHProf
2011-02-02 22:48:52 +01:00
'PhabricatorXHProfController' => 'PhabricatorController',
'PhabricatorXHProfProfileController' => 'PhabricatorXHProfController',
'PhabricatorXHProfProfileSymbolView' => 'AphrontView',
'PhabricatorXHProfProfileTopLevelView' => 'AphrontView',
Publish Phriction edits to feed Summary: Basic integration between Phriction and feed. Test Plan: Created and edited some documents, they published to feed. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, hsb Differential Revision: 653
2011-07-12 16:23:04 +02:00
'PhrictionActionConstants' => 'PhrictionConstants',
Allow Phriction documents to be deleted Summary: - Add a "delete" operation. Delete is just a special edit which removes the page from indexes and shows a notice that the document has been deleted. - When a user deletes all the content on a page, treat it as a delete. - When a conduit call deletes all the content on a page, treat it as a delete. - Add page status to Conduit. - Add change type field to history. - Added a couple of constants to support a future 'move' change, which would move content from one document to another. Test Plan: - Verified deleted pages vanish from the document index (and restoring them puts them back). - Verified deleted pages show "This page has been deleted...". - Created, edited and deleted a document via Conduit. - Deleted pages via "delete" button. - Deleted pages via editing content to nothing. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: skrul, aran, btrahan, epriestley Maniphest Tasks: T680 Differential Revision: 1230
2011-12-17 18:19:08 +01:00
'PhrictionChangeType' => 'PhrictionConstants',
Basic edit/create workflow for Phriction Summary: This is another chunk of D636, I just simplified it a bit and added slugs. When you go to a page like /w/pokemon/, it allows you to create or edit the page. Title vs slug stuff is a little funky but I think mostly-reasonable. Test Plan: Created and edited /w/, /w/pokemon/, etc. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, aran, tuomaspelkonen CC: aran, hsb Differential Revision: 643
2011-07-11 21:34:53 +02:00
'PhrictionContent' => 'PhrictionDAO',
Phriction basics Summary: Basically a copy/paste of parts of D636, but with two changes: - Fully separate the index table ("document") from the content table ("content"). I think this will be a cleaner solution in the long run. - Build slugs into the document structure. This doesn't do anything useful, it just normalizes slugs and lays some groundwork. Test Plan: - Visited various /w/ pages and saw them normalize correctly. - Verified the DAO works by inserting dummy rows. Reviewed By: codeblock Reviewers: hsb, codeblock, jungejason, aran, tuomaspelkonen CC: aran, codeblock, epriestley Differential Revision: 638
2011-07-11 17:54:22 +02:00
'PhrictionController' => 'PhabricatorController',
'PhrictionDAO' => 'PhabricatorLiskDAO',
Allow Phriction documents to be deleted Summary: - Add a "delete" operation. Delete is just a special edit which removes the page from indexes and shows a notice that the document has been deleted. - When a user deletes all the content on a page, treat it as a delete. - When a conduit call deletes all the content on a page, treat it as a delete. - Add page status to Conduit. - Add change type field to history. - Added a couple of constants to support a future 'move' change, which would move content from one document to another. Test Plan: - Verified deleted pages vanish from the document index (and restoring them puts them back). - Verified deleted pages show "This page has been deleted...". - Created, edited and deleted a document via Conduit. - Deleted pages via "delete" button. - Deleted pages via editing content to nothing. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: skrul, aran, btrahan, epriestley Maniphest Tasks: T680 Differential Revision: 1230
2011-12-17 18:19:08 +01:00
'PhrictionDeleteController' => 'PhrictionController',
Show change diffs in Phriction Summary: This is really rough and needs work (particularly, there's some diff code I really need to refactor since I sort-of-copy-pasted it) but basically functional. Show text changes between diffs and allow users to revert to earlier versions. Differential's line-oriented diff style isn't ideal for large blocks of text but I'm betting this is probably good enough in most cases. We can see how bad it is in practice and then fix it if needbe. I added a bunch of support for "description" but didn't add the feature in this diff, I'll either follow up or task it out since it should be a pretty straightforward change. Test Plan: Looked at history for several Phriction documents, clicked "previous change" / "next change", clicked revert buttons. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen CC: aran, hsb, epriestley Differential Revision: 687
2011-07-17 20:06:02 +02:00
'PhrictionDiffController' => 'PhrictionController',
Phriction basics Summary: Basically a copy/paste of parts of D636, but with two changes: - Fully separate the index table ("document") from the content table ("content"). I think this will be a cleaner solution in the long run. - Build slugs into the document structure. This doesn't do anything useful, it just normalizes slugs and lays some groundwork. Test Plan: - Visited various /w/ pages and saw them normalize correctly. - Verified the DAO works by inserting dummy rows. Reviewed By: codeblock Reviewers: hsb, codeblock, jungejason, aran, tuomaspelkonen CC: aran, codeblock, epriestley Differential Revision: 638
2011-07-11 17:54:22 +02:00
'PhrictionDocument' => 'PhrictionDAO',
'PhrictionDocumentController' => 'PhrictionController',
Add a document preview to Phriction Summary: Preview Phriction documents as they are edited, similar to how Differential/Maniphest work. Test Plan: Mashed my keyboard while editing a Phriction document. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, hsb Differential Revision: 684
2011-07-17 03:25:45 +02:00
'PhrictionDocumentPreviewController' => 'PhrictionController',
Allow Phriction documents to be deleted Summary: - Add a "delete" operation. Delete is just a special edit which removes the page from indexes and shows a notice that the document has been deleted. - When a user deletes all the content on a page, treat it as a delete. - When a conduit call deletes all the content on a page, treat it as a delete. - Add page status to Conduit. - Add change type field to history. - Added a couple of constants to support a future 'move' change, which would move content from one document to another. Test Plan: - Verified deleted pages vanish from the document index (and restoring them puts them back). - Verified deleted pages show "This page has been deleted...". - Created, edited and deleted a document via Conduit. - Deleted pages via "delete" button. - Deleted pages via editing content to nothing. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: skrul, aran, btrahan, epriestley Maniphest Tasks: T680 Differential Revision: 1230
2011-12-17 18:19:08 +01:00
'PhrictionDocumentStatus' => 'PhrictionConstants',
Add hierarchical breadcrumbs to Phriction Summary: Show ancestor pages when viewing a page in Phriction. Test Plan: https://secure.phabricator.com/file/view/PHID-FILE-042368dbadaa8ab826ec/ Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran Commenters: aran CC: aran, hsb, epriestley Differential Revision: 654
2011-07-12 17:08:03 +02:00
'PhrictionDocumentTestCase' => 'PhabricatorTestCase',
Basic edit/create workflow for Phriction Summary: This is another chunk of D636, I just simplified it a bit and added slugs. When you go to a page like /w/pokemon/, it allows you to create or edit the page. Title vs slug stuff is a little funky but I think mostly-reasonable. Test Plan: Created and edited /w/, /w/pokemon/, etc. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, aran, tuomaspelkonen CC: aran, hsb Differential Revision: 643
2011-07-11 21:34:53 +02:00
'PhrictionEditController' => 'PhrictionController',
Very basic Phriction history view Summary: Provide a (mostly useless, currently) table of document edits. Test Plan: Looked at document history for several of my high-quality sandbox wiki pages. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, aran, tuomaspelkonen CC: aran, hsb Differential Revision: 644
2011-07-12 00:06:19 +02:00
'PhrictionHistoryController' => 'PhrictionController',
Basic Phriction list view Summary: Pretty much ripped from D636, but somewhat simplified. Lists all the documents in the system. Test Plan: Looked at both of the views, seems to work correctly. Reviewed By: hsb Reviewers: hsb, codeblock, jungejason, tuomaspelkonen, aran CC: aran, hsb, epriestley Differential Revision: 645
2011-07-12 00:42:12 +02:00
'PhrictionListController' => 'PhrictionController',
Fix qsprintf() '%nd' conversion Summary: I broke this a little bit in my overzealous D1174, since this block validates both '%nd' (nullable integer) and '%d' (non-nullable integer). Clean up the conditional checks so we catch the bad case ('%d' on a PHID converting to 0) but let the good case ('%nd' with null) through. Test Plan: Unit tests failed; applied patch; unit tests pass. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T670 Differential Revision: 1201
2011-12-14 02:34:41 +01:00
'QueryFormattingTestCase' => 'PhabricatorTestCase',
Import some code, some of which may be relevant to the project.
2011-01-16 22:51:39 +01:00
),
'requires_interface' =>
array(
),
));
Copy permalink