revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-03 07:59:15 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/resources/sql/autopatches/20190412.dashboard.13.rebuild.php

10 lines
211 B
PHP
Raw Normal View History

Reindex dashboards and panels (allow migrations to queue a job to queue other indexing jobs) Summary: Depends on D20411. Ref T13272. Dashboards and panels have new indexes (Ferret and usage edges) that need a rebuild. For large datasets like commits we have the "activity" flow in T11932, but realistically these rebuilds won't take more than a few minutes on any realistic install so we should be able to just queue them up as migrations. Let migrations insert a job to basically run `bin/search index --type SomeObjectType`, then do that for dashboards and panels. (I'll do Herald rules in a followup too, but I want to tweak one indexing thing there.) Test Plan: Ran the migration, ran `bin/phd debug task`, saw everything get indexed with no manual intervention. Reviewers: amckinley Reviewed By: amckinley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13272 Differential Revision: https://secure.phabricator.com/D20412
2019-04-12 14:17:58 -07:00
<?php
Introduce storage patch "phases" to allow index-rebuilding patches to execute after worker queue schema changes Summary: Ref T13591. Some storage patches queue worker tasks, currently always to rebuild search indexes. These patches can not execute in creation order if a later patch modifies the worker task table, since they'll try to perform a modern INSERT against an out-of-date table schema. Such a modification is desirable in the context of T13591, but making it causes these patches to fail. Patches have an existing "after" mechanism which allows them to have explicit dependencies. This mechanism could be used to resolve this issue, but all patches with a dependency like this would need to be updated every time the queue table changes. Instead, introduce "phases" to provide broader ordering rules. There are now two phases: "default" and "worker". Patches in the "worker" phase execute after patches in the "default" phase. Phases may eventually be further separated, but Test Plan: - Ran `bin/storage status`, saw patches annotated with phases. - Will apply `containerPHID` changes on top of this. Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13591 Differential Revision: https://secure.phabricator.com/D21529
2021-01-28 10:28:23 -08:00
// @phase worker
Reindex dashboards and panels (allow migrations to queue a job to queue other indexing jobs) Summary: Depends on D20411. Ref T13272. Dashboards and panels have new indexes (Ferret and usage edges) that need a rebuild. For large datasets like commits we have the "activity" flow in T11932, but realistically these rebuilds won't take more than a few minutes on any realistic install so we should be able to just queue them up as migrations. Let migrations insert a job to basically run `bin/search index --type SomeObjectType`, then do that for dashboards and panels. (I'll do Herald rules in a followup too, but I want to tweak one indexing thing there.) Test Plan: Ran the migration, ran `bin/phd debug task`, saw everything get indexed with no manual intervention. Reviewers: amckinley Reviewed By: amckinley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13272 Differential Revision: https://secure.phabricator.com/D20412
2019-04-12 14:17:58 -07:00
PhabricatorRebuildIndexesWorker::rebuildObjectsWithQuery(
'PhabricatorDashboardQuery');
PhabricatorRebuildIndexesWorker::rebuildObjectsWithQuery(
'PhabricatorDashboardPanelQuery');
Copy permalink