2012-11-09 03:37:15 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
final class DiffusionLintSaveRunner {
|
|
|
|
private $arc = 'arc';
|
|
|
|
private $severity = ArcanistLintSeverity::SEVERITY_ADVICE;
|
|
|
|
private $all = false;
|
|
|
|
private $chunkSize = 256;
|
|
|
|
|
|
|
|
private $svnRoot;
|
|
|
|
private $lintCommit;
|
|
|
|
private $branch;
|
|
|
|
private $conn;
|
|
|
|
private $deletes = array();
|
|
|
|
private $inserts = array();
|
|
|
|
|
|
|
|
|
|
|
|
public function setArc($path) {
|
|
|
|
$this->arc = $path;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setSeverity($string) {
|
|
|
|
$this->severity = $string;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setAll($bool) {
|
|
|
|
$this->all = $bool;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setChunkSize($number) {
|
|
|
|
$this->chunkSize = $number;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
public function run($dir) {
|
|
|
|
$working_copy = ArcanistWorkingCopyIdentity::newFromPath($dir);
|
|
|
|
$api = ArcanistRepositoryAPI::newAPIFromWorkingCopyIdentity($working_copy);
|
|
|
|
$this->svnRoot = id(new PhutilURI($api->getSourceControlPath()))->getPath();
|
|
|
|
|
|
|
|
$project_id = $working_copy->getProjectID();
|
|
|
|
$project = id(new PhabricatorRepositoryArcanistProject())
|
|
|
|
->loadOneWhere('name = %s', $project_id);
|
|
|
|
if (!$project || !$project->getRepositoryID()) {
|
|
|
|
throw new Exception("Couldn't find repository for {$project_id}.");
|
|
|
|
}
|
|
|
|
|
|
|
|
$branch_name = $api->getBranchName();
|
|
|
|
$this->branch = new PhabricatorRepositoryBranch();
|
|
|
|
$this->conn = $this->branch->establishConnection('w');
|
|
|
|
$this->branch = $this->branch->loadOneWhere(
|
|
|
|
'repositoryID = %d AND name = %s',
|
|
|
|
$project->getRepositoryID(),
|
|
|
|
$branch_name);
|
|
|
|
|
|
|
|
$this->lintCommit = null;
|
|
|
|
if (!$this->branch) {
|
|
|
|
$this->branch = id(new PhabricatorRepositoryBranch())
|
|
|
|
->setRepositoryID($project->getRepositoryID())
|
|
|
|
->setName($branch_name)
|
|
|
|
->save();
|
|
|
|
} else if (!$this->all) {
|
|
|
|
$this->lintCommit = $this->branch->getLintCommit();
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($this->lintCommit) {
|
|
|
|
try {
|
|
|
|
$all_files = $api->getChangedFiles($this->lintCommit);
|
|
|
|
} catch (ArcanistCapabilityNotSupportedException $ex) {
|
|
|
|
$this->lintCommit = null;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!$this->lintCommit) {
|
|
|
|
$where = ($this->svnRoot
|
|
|
|
? qsprintf($this->conn, 'AND path LIKE %>', $this->svnRoot.'/')
|
|
|
|
: '');
|
|
|
|
queryfx(
|
|
|
|
$this->conn,
|
|
|
|
'DELETE FROM %T WHERE branchID = %d %Q',
|
|
|
|
PhabricatorRepository::TABLE_LINTMESSAGE,
|
|
|
|
$this->branch->getID(),
|
|
|
|
$where);
|
|
|
|
$all_files = $api->getAllFiles();
|
|
|
|
}
|
|
|
|
|
|
|
|
$this->deletes = array();
|
|
|
|
$this->inserts = array();
|
|
|
|
$count = 0;
|
|
|
|
|
|
|
|
$files = array();
|
|
|
|
foreach ($all_files as $file => $val) {
|
|
|
|
$count++;
|
|
|
|
if (!$this->lintCommit) {
|
|
|
|
$file = $val;
|
|
|
|
} else {
|
|
|
|
$this->deletes[] = $this->svnRoot.'/'.$file;
|
|
|
|
if ($val & ArcanistRepositoryAPI::FLAG_DELETED) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
$files[$file] = $file;
|
|
|
|
|
|
|
|
if (count($files) >= $this->chunkSize) {
|
|
|
|
$this->runArcLint($files);
|
|
|
|
$files = array();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
$this->runArcLint($files);
|
|
|
|
$this->saveLintMessages();
|
2012-11-30 02:41:21 +01:00
|
|
|
$this->branch->setLintCommit($api->getUnderlyingWorkingCopyRevision());
|
2012-11-09 03:37:15 +01:00
|
|
|
$this->branch->save();
|
|
|
|
|
|
|
|
return $count;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
private function runArcLint(array $files) {
|
|
|
|
if (!$files) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
echo '.';
|
|
|
|
try {
|
|
|
|
$future = new ExecFuture(
|
|
|
|
'%C lint --severity %s --output json %Ls',
|
|
|
|
$this->arc,
|
|
|
|
$this->severity,
|
|
|
|
$files);
|
|
|
|
|
|
|
|
foreach (new LinesOfALargeExecFuture($future) as $json) {
|
|
|
|
$paths = json_decode($json, true);
|
|
|
|
if (!is_array($paths)) {
|
|
|
|
fprintf(STDERR, "Invalid JSON: {$json}\n");
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
foreach ($paths as $path => $messages) {
|
|
|
|
if (!isset($files[$path])) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
foreach ($messages as $message) {
|
|
|
|
$this->inserts[] = qsprintf(
|
|
|
|
$this->conn,
|
|
|
|
'(%d, %s, %d, %s, %s, %s, %s)',
|
|
|
|
$this->branch->getID(),
|
|
|
|
$this->svnRoot.'/'.$path,
|
|
|
|
idx($message, 'line', 0),
|
|
|
|
idx($message, 'code', ''),
|
|
|
|
idx($message, 'severity', ''),
|
|
|
|
idx($message, 'name', ''),
|
|
|
|
idx($message, 'description', ''));
|
|
|
|
}
|
|
|
|
|
|
|
|
if (count($this->deletes) >= 1024 || count($this->inserts) >= 256) {
|
|
|
|
$this->saveLintMessages($this->branch);
|
|
|
|
$this->deletes = array();
|
|
|
|
$this->inserts = array();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
} catch (Exception $ex) {
|
|
|
|
fprintf(STDERR, $ex->getMessage()."\n");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
private function saveLintMessages() {
|
|
|
|
$this->conn->openTransaction();
|
|
|
|
|
|
|
|
foreach (array_chunk($this->deletes, 1024) as $paths) {
|
|
|
|
queryfx(
|
|
|
|
$this->conn,
|
|
|
|
'DELETE FROM %T WHERE branchID = %d AND path IN (%Ls)',
|
|
|
|
PhabricatorRepository::TABLE_LINTMESSAGE,
|
|
|
|
$this->branch->getID(),
|
|
|
|
$paths);
|
|
|
|
}
|
|
|
|
|
|
|
|
foreach (array_chunk($this->inserts, 256) as $values) {
|
|
|
|
queryfx(
|
|
|
|
$this->conn,
|
|
|
|
'INSERT INTO %T
|
|
|
|
(branchID, path, line, code, severity, name, description)
|
|
|
|
VALUES %Q',
|
|
|
|
PhabricatorRepository::TABLE_LINTMESSAGE,
|
|
|
|
implode(', ', $values));
|
|
|
|
}
|
|
|
|
|
|
|
|
$this->conn->saveTransaction();
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|