2011-01-25 18:59:31 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
|
* This file is automatically generated. Use 'celerity_mapper.php' to rebuild
|
|
|
|
|
* it.
|
|
|
|
|
* @generated
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
celerity_register_resource_map(array(
|
Improve drag-and-drop uploader
Summary:
Make it discoverable, show uploading progress, show file thumbnails, allow you
to remove files, make it a generic form component.
Test Plan:
Uploaded ducks
Reviewed By: tomo
Reviewers: aran, tomo, jungejason, tuomaspelkonen
CC: anjali, aran, epriestley, tomo
Differential Revision: 334
2011-05-23 01:11:41 +02:00
|
|
|
'aphront-attached-file-view-css' =>
|
|
|
|
|
array(
|
2011-06-01 04:42:28 +02:00
|
|
|
'uri' => '/res/a6ca5487/rsrc/css/aphront/attached-file-view.css',
|
Improve drag-and-drop uploader
Summary:
Make it discoverable, show uploading progress, show file thumbnails, allow you
to remove files, make it a generic form component.
Test Plan:
Uploaded ducks
Reviewed By: tomo
Reviewers: aran, tomo, jungejason, tuomaspelkonen
CC: anjali, aran, epriestley, tomo
Differential Revision: 334
2011-05-23 01:11:41 +02:00
|
|
|
'type' => 'css',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/css/aphront/attached-file-view.css',
|
|
|
|
|
),
|
2011-06-14 05:41:07 +02:00
|
|
|
'aphront-crumbs-view-css' =>
|
2011-02-02 22:48:52 +01:00
|
|
|
array(
|
2011-06-14 05:41:07 +02:00
|
|
|
'uri' => '/res/9009e6bd/rsrc/css/aphront/crumbs-view.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-02-02 22:48:52 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-06-14 05:41:07 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/crumbs-view.css',
|
2011-02-02 22:48:52 +01:00
|
|
|
),
|
2011-06-14 05:41:07 +02:00
|
|
|
'aphront-dark-console-css' =>
|
2011-01-25 20:31:40 +01:00
|
|
|
array(
|
2011-07-12 00:06:19 +02:00
|
|
|
'uri' => '/res/1a9f84bb/rsrc/css/aphront/dark-console.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 20:31:40 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-06-14 05:41:07 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/dark-console.css',
|
2011-06-10 03:56:47 +02:00
|
|
|
),
|
2011-06-14 05:41:07 +02:00
|
|
|
'aphront-dialog-view-css' =>
|
2011-06-10 03:56:47 +02:00
|
|
|
array(
|
2011-06-14 05:41:07 +02:00
|
|
|
'uri' => '/res/61a58113/rsrc/css/aphront/dialog-view.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-02-06 01:43:28 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-06-14 05:41:07 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/dialog-view.css',
|
2011-02-06 01:43:28 +01:00
|
|
|
),
|
2011-06-14 05:41:07 +02:00
|
|
|
'aphront-error-view-css' =>
|
2011-01-25 20:31:40 +01:00
|
|
|
array(
|
2011-06-14 05:41:07 +02:00
|
|
|
'uri' => '/res/e4c5e4ed/rsrc/css/aphront/error-view.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 20:31:40 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-06-14 05:41:07 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/error-view.css',
|
2011-01-25 20:31:40 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'aphront-form-view-css' =>
|
2011-02-20 21:50:28 +01:00
|
|
|
array(
|
2011-06-10 00:28:29 +02:00
|
|
|
'uri' => '/res/8ee16aba/rsrc/css/aphront/form-view.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-02-20 21:50:28 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/form-view.css',
|
2011-03-23 03:34:47 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'aphront-headsup-action-list-view-css' =>
|
2011-03-23 03:34:47 +01:00
|
|
|
array(
|
2011-06-20 23:21:17 +02:00
|
|
|
'uri' => '/res/af3dff49/rsrc/css/aphront/headsup-action-list-view.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-03-23 03:34:47 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/headsup-action-list-view.css',
|
2011-02-20 21:50:28 +01:00
|
|
|
),
|
2011-05-11 21:25:29 +02:00
|
|
|
'aphront-list-filter-view-css' =>
|
2011-05-10 17:29:28 +02:00
|
|
|
array(
|
Allow Maniphest to scale to a massive size
Summary:
Maniphest is missing some keys and some query strategy which will make it
cumbersome to manage more than a few tens of thousands of tasks.
Test Plan:
Handily manipulated 100k-scale task groups. Maniphest takes about 250ms to
select and render pages of 1,000 tasks and has no problem paging and filtering
them, etc. We should be good to scale to multiple millions of tasks with these
changes.
Reviewed By: gc3
Reviewers: fratrik, jungejason, aran, tuomaspelkonen, gc3
Commenters: jungejason
CC: anjali, aran, epriestley, gc3, jungejason
Differential Revision: 534
2011-06-27 03:50:17 +02:00
|
|
|
'uri' => '/res/0f5ddaba/rsrc/css/aphront/list-filter-view.css',
|
2011-05-11 21:25:29 +02:00
|
|
|
'type' => 'css',
|
2011-05-10 17:29:28 +02:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-11 21:25:29 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/list-filter-view.css',
|
2011-05-10 17:29:28 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'aphront-pager-view-css' =>
|
2011-01-30 18:15:01 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/43fb79f0/rsrc/css/aphront/pager-view.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-30 18:15:01 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/pager-view.css',
|
2011-01-30 18:15:01 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'aphront-panel-view-css' =>
|
2011-01-25 20:31:40 +01:00
|
|
|
array(
|
2011-05-22 20:55:10 +02:00
|
|
|
'uri' => '/res/e0139b9c/rsrc/css/aphront/panel-view.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 20:31:40 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/panel-view.css',
|
2011-01-25 20:31:40 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'aphront-request-failure-view-css' =>
|
2011-01-25 20:31:40 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/c9a43002/rsrc/css/aphront/request-failure-view.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 20:31:40 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/request-failure-view.css',
|
2011-01-25 20:31:40 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'aphront-side-nav-view-css' =>
|
2011-01-25 22:48:05 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/f92966bd/rsrc/css/aphront/side-nav-view.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 22:48:05 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/side-nav-view.css',
|
2011-01-25 22:48:05 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'aphront-table-view-css' =>
|
2011-01-25 22:48:05 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/910e83ec/rsrc/css/aphront/table-view.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 22:48:05 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/table-view.css',
|
2011-01-25 22:48:05 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'aphront-tokenizer-control-css' =>
|
2011-04-05 21:24:21 +02:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/f530af47/rsrc/css/aphront/tokenizer.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-04-05 21:24:21 +02:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
2011-05-03 19:45:45 +02:00
|
|
|
0 => 'aphront-typeahead-control-css',
|
2011-04-05 21:24:21 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/tokenizer.css',
|
2011-04-05 21:24:21 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'aphront-typeahead-control-css' =>
|
2011-04-05 21:24:21 +02:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/a05236a6/rsrc/css/aphront/typeahead.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-04-05 21:24:21 +02:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/aphront/typeahead.css',
|
2011-04-05 21:24:21 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'differential-changeset-view-css' =>
|
2011-01-25 18:59:31 +01:00
|
|
|
array(
|
2011-06-10 17:34:17 +02:00
|
|
|
'uri' => '/res/d2923406/rsrc/css/application/differential/changeset-view.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 18:59:31 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/differential/changeset-view.css',
|
2011-01-25 18:59:31 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'differential-core-view-css' =>
|
2011-02-01 03:05:20 +01:00
|
|
|
array(
|
2011-06-20 23:21:17 +02:00
|
|
|
'uri' => '/res/438fe316/rsrc/css/application/differential/core.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-02-01 03:05:20 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/differential/core.css',
|
2011-02-01 03:05:20 +01:00
|
|
|
),
|
Add "Undo" for editing Differential inline comments
Summary:
When a user hits 'cancel' on a 'new', 'edit', or 'reply' operation, add a little
"Changes discarded. __Undo__" insert so they can get their change back. No undo
for delete since there's an explicit prompt. Once this lands we can make
'escape' work again to close dialogs.
This change started feeling really good when I was merging all the duplicate
code and making things more consistent, but by the time I started writing client
rendering it felt gross. I'm not really thrilled with it but I guess it's a step
forward? The feature seems pretty OK in practice. Let me know how much barfing
this causes and I can try to remedy the most acute concerns.
This also fixes a bug where replies always (?) appear on the 'new' side of the
diff (I think?).
Test Plan:
Applied 'new', 'edit', 'delete' and 'reply' operations, pressed 'cancel' and
'okay' in each case, with and without changing text where relevant. All
behaviors seem to conform with expectations, except that canceling out of 'edit'
without changing the text gives you an option to undo when it shouldn't really.
There's no super easy way to get at the original text right now.
Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen
CC: simpkins, aran, epriestley
Differential Revision: 406
2011-06-08 01:11:10 +02:00
|
|
|
'differential-inline-comment-editor' =>
|
|
|
|
|
array(
|
2011-06-10 16:36:42 +02:00
|
|
|
'uri' => '/res/5e4f0aa4/rsrc/js/application/differential/DifferentialInlineCommentEditor.js',
|
Add "Undo" for editing Differential inline comments
Summary:
When a user hits 'cancel' on a 'new', 'edit', or 'reply' operation, add a little
"Changes discarded. __Undo__" insert so they can get their change back. No undo
for delete since there's an explicit prompt. Once this lands we can make
'escape' work again to close dialogs.
This change started feeling really good when I was merging all the duplicate
code and making things more consistent, but by the time I started writing client
rendering it felt gross. I'm not really thrilled with it but I guess it's a step
forward? The feature seems pretty OK in practice. Let me know how much barfing
this causes and I can try to remedy the most acute concerns.
This also fixes a bug where replies always (?) appear on the 'new' side of the
diff (I think?).
Test Plan:
Applied 'new', 'edit', 'delete' and 'reply' operations, pressed 'cancel' and
'okay' in each case, with and without changing text where relevant. All
behaviors seem to conform with expectations, except that canceling out of 'edit'
without changing the text gives you an option to undo when it shouldn't really.
There's no super easy way to get at the original text right now.
Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen
CC: simpkins, aran, epriestley
Differential Revision: 406
2011-06-08 01:11:10 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-dom',
|
|
|
|
|
1 => 'javelin-workflow',
|
|
|
|
|
2 => 'javelin-util',
|
|
|
|
|
3 => 'javelin-stratcom',
|
|
|
|
|
4 => 'javelin-install',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/differential/DifferentialInlineCommentEditor.js',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'differential-revision-add-comment-css' =>
|
2011-01-25 20:31:40 +01:00
|
|
|
array(
|
Tweak Maniphest CSS, fix remarkup in description change views
Summary:
Various CSS tweaks and fixes:
- Add remarkup styling to description change views, missed this before.
- Fix CSS so that transactions with only one item (e.g., changed priority)
don't have weird floater underneath them.
- Add more space between transaction items.
- Make default background color lighter and less heavy.
- Use beigey color for comment form in Maniphest.
- Share more CSS between Maniphest and Differential (previews, feedback).
- Move "Leap Into Action" call to Differential, replace Maniphest with
thematically-consistent "Weigh In" (obviously, Maniphest has a nautical theme).
Test Plan:
Browsed Maniphest and Differential in a couple browsers, styling all seems
correct.
Reviewed By: tomo
Reviewers: tomo, aran, jungejason, tuomaspelkonen
CC: anjali, aran, tomo
Differential Revision: 328
2011-05-22 17:49:07 +02:00
|
|
|
'uri' => '/res/849748d3/rsrc/css/application/differential/add-comment.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 20:31:40 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/differential/add-comment.css',
|
2011-01-25 20:31:40 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'differential-revision-comment-css' =>
|
2011-01-25 20:31:40 +01:00
|
|
|
array(
|
2011-07-08 22:28:59 +02:00
|
|
|
'uri' => '/res/9fb8013b/rsrc/css/application/differential/revision-comment.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-27 23:55:52 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/differential/revision-comment.css',
|
2011-01-27 23:55:52 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'differential-revision-comment-list-css' =>
|
2011-01-30 19:37:36 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/3b31faa3/rsrc/css/application/differential/revision-comment-list.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-30 19:37:36 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/differential/revision-comment-list.css',
|
2011-01-30 19:37:36 +01:00
|
|
|
),
|
2011-05-28 20:36:00 +02:00
|
|
|
'differential-revision-detail-css' =>
|
2011-05-31 19:23:31 +02:00
|
|
|
array(
|
2011-06-10 16:36:42 +02:00
|
|
|
'uri' => '/res/015e5995/rsrc/css/application/differential/revision-detail.css',
|
2011-05-28 20:36:00 +02:00
|
|
|
'type' => 'css',
|
2011-05-31 19:23:31 +02:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-28 20:36:00 +02:00
|
|
|
'disk' => '/rsrc/css/application/differential/revision-detail.css',
|
2011-05-31 19:23:31 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'differential-revision-history-css' =>
|
2011-01-27 23:55:52 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/0d7d515d/rsrc/css/application/differential/revision-history.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-27 23:55:52 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/differential/revision-history.css',
|
2011-01-27 23:55:52 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'differential-table-of-contents-css' =>
|
2011-01-27 23:55:52 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/d173445b/rsrc/css/application/differential/table-of-contents.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 20:31:40 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/differential/table-of-contents.css',
|
2011-01-25 20:31:40 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'diffusion-commit-view-css' =>
|
2011-01-25 20:31:40 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/bc39d876/rsrc/css/application/diffusion/commit-view.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 20:31:40 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/diffusion/commit-view.css',
|
2011-01-25 20:31:40 +01:00
|
|
|
),
|
2011-05-24 04:52:13 +02:00
|
|
|
'diffusion-source-css' =>
|
|
|
|
|
array(
|
|
|
|
|
'uri' => '/res/db4566b6/rsrc/css/application/diffusion/diffusion-source.css',
|
|
|
|
|
'type' => 'css',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/css/application/diffusion/diffusion-source.css',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'herald-css' =>
|
2011-01-25 20:31:40 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/5051f3ab/rsrc/css/application/herald/herald.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 20:31:40 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/herald/herald.css',
|
2011-01-25 20:31:40 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'herald-rule-editor' =>
|
2011-03-24 19:07:36 +01:00
|
|
|
array(
|
2011-07-05 23:30:20 +02:00
|
|
|
'uri' => '/res/ba957508/rsrc/js/application/herald/HeraldRuleEditor.js',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'js',
|
2011-03-24 19:07:36 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
2011-05-03 19:45:45 +02:00
|
|
|
0 => 'multirow-row-manager',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
1 => 'javelin-install',
|
|
|
|
|
2 => 'javelin-typeahead',
|
|
|
|
|
3 => 'javelin-util',
|
|
|
|
|
4 => 'javelin-dom',
|
|
|
|
|
5 => 'javelin-tokenizer',
|
|
|
|
|
6 => 'javelin-typeahead-preloaded-source',
|
|
|
|
|
7 => 'javelin-stratcom',
|
|
|
|
|
8 => 'javelin-json',
|
2011-03-24 19:07:36 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/herald/HeraldRuleEditor.js',
|
2011-03-24 19:07:36 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'herald-test-css' =>
|
2011-03-24 19:07:36 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/c0cd6bdb/rsrc/css/application/herald/herald-test.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'css',
|
2011-03-24 19:07:36 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/herald/herald-test.css',
|
2011-03-24 19:07:36 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'javelin-behavior' =>
|
|
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/b28adfa1/rsrc/js/javelin/lib/behavior.js',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
2011-05-09 19:39:43 +02:00
|
|
|
0 => 'javelin-magical-init',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/lib/behavior.js',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-aphront-basic-tokenizer' =>
|
2011-02-08 19:53:59 +01:00
|
|
|
array(
|
2011-06-10 00:28:29 +02:00
|
|
|
'uri' => '/res/5e183bd5/rsrc/js/application/core/behavior-tokenizer.js',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'js',
|
2011-02-08 19:53:59 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-typeahead',
|
|
|
|
|
2 => 'javelin-tokenizer',
|
|
|
|
|
3 => 'javelin-typeahead-preloaded-source',
|
|
|
|
|
4 => 'javelin-dom',
|
2011-06-10 00:28:29 +02:00
|
|
|
5 => 'javelin-stratcom',
|
2011-02-08 19:53:59 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/core/behavior-tokenizer.js',
|
2011-02-08 19:53:59 +01:00
|
|
|
),
|
Improve drag-and-drop uploader
Summary:
Make it discoverable, show uploading progress, show file thumbnails, allow you
to remove files, make it a generic form component.
Test Plan:
Uploaded ducks
Reviewed By: tomo
Reviewers: aran, tomo, jungejason, tuomaspelkonen
CC: anjali, aran, epriestley, tomo
Differential Revision: 334
2011-05-23 01:11:41 +02:00
|
|
|
'javelin-behavior-aphront-drag-and-drop' =>
|
|
|
|
|
array(
|
|
|
|
|
'uri' => '/res/170115f4/rsrc/js/application/core/behavior-drag-and-drop.js',
|
|
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
2 => 'javelin-util',
|
|
|
|
|
3 => 'phabricator-drag-and-drop-file-upload',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/core/behavior-drag-and-drop.js',
|
|
|
|
|
),
|
2011-05-23 23:33:54 +02:00
|
|
|
'javelin-behavior-aphront-form-disable-on-submit' =>
|
|
|
|
|
array(
|
|
|
|
|
'uri' => '/res/6c659ede/rsrc/js/application/core/behavior-form.js',
|
|
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-stratcom',
|
|
|
|
|
2 => 'javelin-dom',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/core/behavior-form.js',
|
|
|
|
|
),
|
2011-06-13 01:06:17 +02:00
|
|
|
'javelin-behavior-countdown-timer' =>
|
|
|
|
|
array(
|
2011-06-10 00:28:29 +02:00
|
|
|
'uri' => '/res/9eef8193/rsrc/js/application/countdown/timer.js',
|
2011-06-13 01:06:17 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
2 => 'javelin-util',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/countdown/timer.js',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-dark-console' =>
|
2011-02-08 19:53:59 +01:00
|
|
|
array(
|
2011-06-08 17:48:48 +02:00
|
|
|
'uri' => '/res/c80156c4/rsrc/js/application/core/behavior-dark-console.js',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'js',
|
2011-02-08 19:53:59 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-stratcom',
|
|
|
|
|
2 => 'javelin-util',
|
|
|
|
|
3 => 'javelin-dom',
|
|
|
|
|
4 => 'javelin-request',
|
2011-06-08 17:48:48 +02:00
|
|
|
5 => 'phabricator-keyboard-shortcut',
|
2011-02-08 19:53:59 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/core/behavior-dark-console.js',
|
2011-02-08 19:53:59 +01:00
|
|
|
),
|
2011-06-10 03:56:47 +02:00
|
|
|
'javelin-behavior-differential-accept-with-errors' =>
|
|
|
|
|
array(
|
|
|
|
|
'uri' => '/res/41c4685b/rsrc/js/application/differential/behavior-accept-with-errors.js',
|
|
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/differential/behavior-accept-with-errors.js',
|
|
|
|
|
),
|
2011-06-24 21:21:48 +02:00
|
|
|
'javelin-behavior-differential-add-reviewers-and-ccs' =>
|
2011-02-08 19:53:59 +01:00
|
|
|
array(
|
2011-06-24 21:21:48 +02:00
|
|
|
'uri' => '/res/fc352745/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-02-08 19:53:59 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
2 => 'javelin-tokenizer',
|
|
|
|
|
3 => 'javelin-typeahead',
|
|
|
|
|
4 => 'javelin-typeahead-preloaded-source',
|
2011-02-08 19:53:59 +01:00
|
|
|
),
|
2011-06-24 21:21:48 +02:00
|
|
|
'disk' => '/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js',
|
2011-02-08 19:53:59 +01:00
|
|
|
),
|
2011-05-11 21:25:29 +02:00
|
|
|
'javelin-behavior-differential-comment-jump' =>
|
|
|
|
|
array(
|
2011-05-13 03:56:30 +02:00
|
|
|
'uri' => '/res/be77fced/rsrc/js/application/differential/behavior-comment-jump.js',
|
2011-05-11 21:25:29 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-util',
|
|
|
|
|
2 => 'javelin-dom',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/differential/behavior-comment-jump.js',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-differential-diff-radios' =>
|
2011-01-25 20:31:40 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/004cb66f/rsrc/js/application/differential/behavior-diff-radios.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-01-25 20:31:40 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-stratcom',
|
|
|
|
|
2 => 'javelin-dom',
|
2011-01-25 20:31:40 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/differential/behavior-diff-radios.js',
|
2011-01-25 20:31:40 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-differential-edit-inline-comments' =>
|
2011-02-20 02:33:53 +01:00
|
|
|
array(
|
2011-06-10 16:36:42 +02:00
|
|
|
'uri' => '/res/9d4ca5d7/rsrc/js/application/differential/behavior-edit-inline-comments.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-02-20 02:33:53 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-stratcom',
|
|
|
|
|
2 => 'javelin-dom',
|
Add "Undo" for editing Differential inline comments
Summary:
When a user hits 'cancel' on a 'new', 'edit', or 'reply' operation, add a little
"Changes discarded. __Undo__" insert so they can get their change back. No undo
for delete since there's an explicit prompt. Once this lands we can make
'escape' work again to close dialogs.
This change started feeling really good when I was merging all the duplicate
code and making things more consistent, but by the time I started writing client
rendering it felt gross. I'm not really thrilled with it but I guess it's a step
forward? The feature seems pretty OK in practice. Let me know how much barfing
this causes and I can try to remedy the most acute concerns.
This also fixes a bug where replies always (?) appear on the 'new' side of the
diff (I think?).
Test Plan:
Applied 'new', 'edit', 'delete' and 'reply' operations, pressed 'cancel' and
'okay' in each case, with and without changing text where relevant. All
behaviors seem to conform with expectations, except that canceling out of 'edit'
without changing the text gives you an option to undo when it shouldn't really.
There's no super easy way to get at the original text right now.
Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen
CC: simpkins, aran, epriestley
Differential Revision: 406
2011-06-08 01:11:10 +02:00
|
|
|
3 => 'javelin-util',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
4 => 'javelin-vector',
|
Add "Undo" for editing Differential inline comments
Summary:
When a user hits 'cancel' on a 'new', 'edit', or 'reply' operation, add a little
"Changes discarded. __Undo__" insert so they can get their change back. No undo
for delete since there's an explicit prompt. Once this lands we can make
'escape' work again to close dialogs.
This change started feeling really good when I was merging all the duplicate
code and making things more consistent, but by the time I started writing client
rendering it felt gross. I'm not really thrilled with it but I guess it's a step
forward? The feature seems pretty OK in practice. Let me know how much barfing
this causes and I can try to remedy the most acute concerns.
This also fixes a bug where replies always (?) appear on the 'new' side of the
diff (I think?).
Test Plan:
Applied 'new', 'edit', 'delete' and 'reply' operations, pressed 'cancel' and
'okay' in each case, with and without changing text where relevant. All
behaviors seem to conform with expectations, except that canceling out of 'edit'
without changing the text gives you an option to undo when it shouldn't really.
There's no super easy way to get at the original text right now.
Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen
CC: simpkins, aran, epriestley
Differential Revision: 406
2011-06-08 01:11:10 +02:00
|
|
|
5 => 'differential-inline-comment-editor',
|
2011-02-20 02:33:53 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/differential/behavior-edit-inline-comments.js',
|
2011-02-20 02:33:53 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-differential-feedback-preview' =>
|
2011-04-04 04:20:47 +02:00
|
|
|
array(
|
2011-05-10 17:29:28 +02:00
|
|
|
'uri' => '/res/ab8a7d60/rsrc/js/application/differential/behavior-comment-preview.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-04-04 04:20:47 +02:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-stratcom',
|
|
|
|
|
2 => 'javelin-dom',
|
|
|
|
|
3 => 'javelin-request',
|
|
|
|
|
4 => 'javelin-util',
|
2011-05-10 17:29:28 +02:00
|
|
|
5 => 'phabricator-shaped-request',
|
2011-04-04 04:20:47 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/differential/behavior-comment-preview.js',
|
2011-04-04 04:20:47 +02:00
|
|
|
),
|
2011-06-08 20:53:10 +02:00
|
|
|
'javelin-behavior-differential-keyboard-navigation' =>
|
|
|
|
|
array(
|
2011-07-08 22:28:59 +02:00
|
|
|
'uri' => '/res/3bdfaec7/rsrc/js/application/differential/behavior-keyboard-nav.js',
|
2011-06-08 20:53:10 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
2 => 'phabricator-keyboard-shortcut',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/differential/behavior-keyboard-nav.js',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-differential-populate' =>
|
2011-01-25 18:59:31 +01:00
|
|
|
array(
|
2011-05-13 15:12:21 +02:00
|
|
|
'uri' => '/res/025171e1/rsrc/js/application/differential/behavior-populate.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-01-25 18:59:31 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-request',
|
|
|
|
|
2 => 'javelin-util',
|
|
|
|
|
3 => 'javelin-dom',
|
2011-01-25 18:59:31 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/differential/behavior-populate.js',
|
2011-01-25 18:59:31 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-differential-show-all-comments' =>
|
2011-04-01 02:06:33 +02:00
|
|
|
array(
|
2011-05-31 19:23:31 +02:00
|
|
|
'uri' => '/res/bcc990f0/rsrc/js/application/differential/behavior-show-all-comments.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-04-01 02:06:33 +02:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-stratcom',
|
|
|
|
|
2 => 'javelin-dom',
|
2011-04-01 02:06:33 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/differential/behavior-show-all-comments.js',
|
2011-04-01 02:06:33 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-differential-show-more' =>
|
2011-02-02 00:52:04 +01:00
|
|
|
array(
|
Add "Undo" for editing Differential inline comments
Summary:
When a user hits 'cancel' on a 'new', 'edit', or 'reply' operation, add a little
"Changes discarded. __Undo__" insert so they can get their change back. No undo
for delete since there's an explicit prompt. Once this lands we can make
'escape' work again to close dialogs.
This change started feeling really good when I was merging all the duplicate
code and making things more consistent, but by the time I started writing client
rendering it felt gross. I'm not really thrilled with it but I guess it's a step
forward? The feature seems pretty OK in practice. Let me know how much barfing
this causes and I can try to remedy the most acute concerns.
This also fixes a bug where replies always (?) appear on the 'new' side of the
diff (I think?).
Test Plan:
Applied 'new', 'edit', 'delete' and 'reply' operations, pressed 'cancel' and
'okay' in each case, with and without changing text where relevant. All
behaviors seem to conform with expectations, except that canceling out of 'edit'
without changing the text gives you an option to undo when it shouldn't really.
There's no super easy way to get at the original text right now.
Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen
CC: simpkins, aran, epriestley
Differential Revision: 406
2011-06-08 01:11:10 +02:00
|
|
|
'uri' => '/res/a766c717/rsrc/js/application/differential/behavior-show-more.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-02-02 00:52:04 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
2 => 'javelin-request',
|
|
|
|
|
3 => 'javelin-util',
|
|
|
|
|
4 => 'javelin-stratcom',
|
2011-02-02 00:52:04 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/differential/behavior-show-more.js',
|
2011-02-02 00:52:04 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-diffusion-jump-to' =>
|
2011-01-30 22:20:56 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/4b63e436/rsrc/js/application/diffusion/behavior-jump-to.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-01-30 22:20:56 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-util',
|
|
|
|
|
2 => 'javelin-vector',
|
|
|
|
|
3 => 'javelin-dom',
|
2011-01-30 22:20:56 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/diffusion/behavior-jump-to.js',
|
2011-01-30 22:20:56 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-diffusion-pull-lastmodified' =>
|
2011-01-25 20:57:47 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/29fe2790/rsrc/js/application/diffusion/behavior-pull-lastmodified.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-01-25 20:57:47 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
2 => 'javelin-util',
|
|
|
|
|
3 => 'javelin-request',
|
2011-01-25 20:57:47 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/diffusion/behavior-pull-lastmodified.js',
|
2011-01-25 20:57:47 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-error-log' =>
|
2011-02-02 22:48:52 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/a5cb42a5/rsrc/js/application/core/behavior-error-log.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-02-02 22:48:52 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-dom',
|
2011-02-02 22:48:52 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/core/behavior-error-log.js',
|
2011-02-02 22:48:52 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-herald-rule-editor' =>
|
2011-04-14 23:44:54 +02:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/77a0c945/rsrc/js/application/herald/herald-rule-editor.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-04-05 21:24:21 +02:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
2011-05-03 19:45:45 +02:00
|
|
|
0 => 'herald-rule-editor',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
1 => 'javelin-behavior',
|
2011-04-05 21:24:21 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/herald/herald-rule-editor.js',
|
2011-04-05 21:24:21 +02:00
|
|
|
),
|
2011-06-10 00:28:29 +02:00
|
|
|
'javelin-behavior-maniphest-project-create' =>
|
|
|
|
|
array(
|
|
|
|
|
'uri' => '/res/85a0eaf9/rsrc/js/application/maniphest/behavior-project-create.js',
|
|
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
2 => 'javelin-stratcom',
|
|
|
|
|
3 => 'javelin-workflow',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/maniphest/behavior-project-create.js',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-maniphest-transaction-controls' =>
|
2011-02-17 07:14:09 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/94a2a395/rsrc/js/application/maniphest/behavior-transaction-controls.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-02-17 07:14:09 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
2 => 'javelin-tokenizer',
|
|
|
|
|
3 => 'javelin-typeahead',
|
|
|
|
|
4 => 'javelin-typeahead-preloaded-source',
|
2011-02-17 07:14:09 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/maniphest/behavior-transaction-controls.js',
|
2011-02-17 07:14:09 +01:00
|
|
|
),
|
2011-05-21 03:56:18 +02:00
|
|
|
'javelin-behavior-maniphest-transaction-expand' =>
|
|
|
|
|
array(
|
|
|
|
|
'uri' => '/res/966410de/rsrc/js/application/maniphest/behavior-transaction-expand.js',
|
|
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
2 => 'javelin-workflow',
|
|
|
|
|
3 => 'javelin-stratcom',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/maniphest/behavior-transaction-expand.js',
|
|
|
|
|
),
|
2011-05-10 17:29:28 +02:00
|
|
|
'javelin-behavior-maniphest-transaction-preview' =>
|
|
|
|
|
array(
|
2011-05-11 13:20:44 +02:00
|
|
|
'uri' => '/res/44e86555/rsrc/js/application/maniphest/behavior-transaction-preview.js',
|
2011-05-10 17:29:28 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
2 => 'javelin-util',
|
|
|
|
|
3 => 'phabricator-shaped-request',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/maniphest/behavior-transaction-preview.js',
|
|
|
|
|
),
|
Fix conservative CSRF token cycling limit
Summary:
We currently cycle CSRF tokens every hour and check for the last two valid ones.
This means that a form could go stale in as little as an hour, and is certainly
stale after two.
When a stale form is submitted, you basically get a terrible heisen-state where
some of your data might persist if you're lucky but more likely it all just
vanishes. The .js file below outlines some more details.
This is a pretty terrible UX and we don't need to be as conservative about CSRF
validation as we're being. Remedy this problem by:
- Accepting the last 6 CSRF tokens instead of the last 1 (i.e., pages are
valid for at least 6 hours, and for as long as 7).
- Using JS to refresh the CSRF token every 55 minutes (i.e., pages connected
to the internet are valid indefinitely).
- Showing the user an explicit message about what went wrong when CSRF
validation fails so the experience is less bewildering.
They should now only be able to submit with a bad CSRF token if:
- They load a page, disconnect from the internet for 7 hours, reconnect, and
submit the form within 55 minutes; or
- They are actually the victim of a CSRF attack.
We could eventually fix the first one by tracking reconnects, which might be
"free" once the notification server gets built. It will probably never be an
issue in practice.
Test Plan:
- Reduced CSRF cycle frequency to 2 seconds, submitted a form after 15
seconds, got the CSRF exception.
- Reduced csrf-refresh cycle frequency to 3 seconds, submitted a form after 15
seconds, got a clean form post.
- Added debugging code the the csrf refresh to make sure it was doing sensible
things (pulling different tokens, finding all the inputs).
Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
CC: aran, epriestley
Differential Revision: 660
2011-07-13 23:05:18 +02:00
|
|
|
0 =>
|
|
|
|
|
array(
|
|
|
|
|
'uri' => '/res/1da00bfe/rsrc/js/javelin/lib/__tests__/URI.js',
|
|
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-uri',
|
|
|
|
|
1 => 'javelin-php-serializer',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/lib/__tests__/URI.js',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-owners-path-editor' =>
|
2011-01-25 22:48:05 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/9cf78ffc/rsrc/js/application/owners/owners-path-editor.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-01-25 22:48:05 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
2011-05-03 19:45:45 +02:00
|
|
|
0 => 'owners-path-editor',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
1 => 'javelin-behavior',
|
2011-01-25 22:48:05 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/owners/owners-path-editor.js',
|
2011-01-25 22:48:05 +01:00
|
|
|
),
|
2011-05-28 20:36:00 +02:00
|
|
|
'javelin-behavior-phabricator-keyboard-shortcuts' =>
|
|
|
|
|
array(
|
2011-07-05 23:30:20 +02:00
|
|
|
'uri' => '/res/94b009e2/rsrc/js/application/core/behavior-keyboard-shortcuts.js',
|
2011-05-28 20:36:00 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-workflow',
|
|
|
|
|
2 => 'javelin-json',
|
|
|
|
|
3 => 'phabricator-keyboard-shortcut',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/core/behavior-keyboard-shortcuts.js',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-phabricator-object-selector' =>
|
2011-02-05 20:45:13 +01:00
|
|
|
array(
|
2011-06-14 16:55:04 +02:00
|
|
|
'uri' => '/res/34f9a11e/rsrc/js/application/core/behavior-object-selector.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-02-05 20:45:13 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
2 => 'javelin-request',
|
|
|
|
|
3 => 'javelin-util',
|
|
|
|
|
4 => 'javelin-stratcom',
|
2011-02-05 20:45:13 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/core/behavior-object-selector.js',
|
2011-02-05 20:45:13 +01:00
|
|
|
),
|
2011-05-31 19:23:31 +02:00
|
|
|
'javelin-behavior-phabricator-watch-anchor' =>
|
|
|
|
|
array(
|
|
|
|
|
'uri' => '/res/bb6fa5b2/rsrc/js/application/core/behavior-watch-anchor.js',
|
|
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-stratcom',
|
|
|
|
|
2 => 'javelin-util',
|
|
|
|
|
3 => 'javelin-dom',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/core/behavior-watch-anchor.js',
|
|
|
|
|
),
|
Fix conservative CSRF token cycling limit
Summary:
We currently cycle CSRF tokens every hour and check for the last two valid ones.
This means that a form could go stale in as little as an hour, and is certainly
stale after two.
When a stale form is submitted, you basically get a terrible heisen-state where
some of your data might persist if you're lucky but more likely it all just
vanishes. The .js file below outlines some more details.
This is a pretty terrible UX and we don't need to be as conservative about CSRF
validation as we're being. Remedy this problem by:
- Accepting the last 6 CSRF tokens instead of the last 1 (i.e., pages are
valid for at least 6 hours, and for as long as 7).
- Using JS to refresh the CSRF token every 55 minutes (i.e., pages connected
to the internet are valid indefinitely).
- Showing the user an explicit message about what went wrong when CSRF
validation fails so the experience is less bewildering.
They should now only be able to submit with a bad CSRF token if:
- They load a page, disconnect from the internet for 7 hours, reconnect, and
submit the form within 55 minutes; or
- They are actually the victim of a CSRF attack.
We could eventually fix the first one by tracking reconnects, which might be
"free" once the notification server gets built. It will probably never be an
issue in practice.
Test Plan:
- Reduced CSRF cycle frequency to 2 seconds, submitted a form after 15
seconds, got the CSRF exception.
- Reduced csrf-refresh cycle frequency to 3 seconds, submitted a form after 15
seconds, got a clean form post.
- Added debugging code the the csrf refresh to make sure it was doing sensible
things (pulling different tokens, finding all the inputs).
Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
CC: aran, epriestley
Differential Revision: 660
2011-07-13 23:05:18 +02:00
|
|
|
'javelin-behavior-refresh-csrf' =>
|
|
|
|
|
array(
|
|
|
|
|
'uri' => '/res/39aa51f7/rsrc/js/application/core/behavior-refresh-csrf.js',
|
|
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-request',
|
|
|
|
|
1 => 'javelin-behavior',
|
|
|
|
|
2 => 'javelin-dom',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/core/behavior-refresh-csrf.js',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-behavior-workflow' =>
|
2011-03-23 01:08:08 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/079f49c3/rsrc/js/application/core/behavior-workflow.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-03-23 01:08:08 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-behavior',
|
|
|
|
|
1 => 'javelin-stratcom',
|
|
|
|
|
2 => 'javelin-workflow',
|
2011-03-23 01:08:08 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/core/behavior-workflow.js',
|
2011-03-23 01:08:08 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'javelin-dom' =>
|
|
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/34e7f2b5/rsrc/js/javelin/lib/DOM.js',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
2011-05-09 19:39:43 +02:00
|
|
|
0 => 'javelin-magical-init',
|
|
|
|
|
1 => 'javelin-install',
|
|
|
|
|
2 => 'javelin-util',
|
|
|
|
|
3 => 'javelin-vector',
|
|
|
|
|
4 => 'javelin-stratcom',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/lib/DOM.js',
|
|
|
|
|
),
|
|
|
|
|
'javelin-event' =>
|
2011-02-05 07:45:42 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/25c7c9e8/rsrc/js/javelin/core/Event.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-02-05 07:45:42 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-install',
|
2011-02-05 07:45:42 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'disk' => '/rsrc/js/javelin/core/Event.js',
|
2011-02-05 07:45:42 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'javelin-install' =>
|
2011-02-01 03:05:20 +01:00
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/b6692f42/rsrc/js/javelin/core/install.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-02-01 03:05:20 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-util',
|
2011-05-09 19:39:43 +02:00
|
|
|
1 => 'javelin-magical-init',
|
2011-02-01 03:05:20 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'disk' => '/rsrc/js/javelin/core/install.js',
|
2011-02-01 03:05:20 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'javelin-json' =>
|
2011-02-03 22:20:43 +01:00
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/f23dbfbd/rsrc/js/javelin/lib/JSON.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-02-03 22:20:43 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-util',
|
2011-02-03 22:20:43 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'disk' => '/rsrc/js/javelin/lib/JSON.js',
|
2011-02-03 22:20:43 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'javelin-magical-init' =>
|
2011-02-02 00:52:04 +01:00
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/6a069362/rsrc/js/javelin/core/init.js',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/core/init.js',
|
|
|
|
|
),
|
|
|
|
|
'javelin-mask' =>
|
|
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/28e3bd9c/rsrc/js/javelin/lib/Mask.js',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-vector',
|
|
|
|
|
2 => 'javelin-dom',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/lib/Mask.js',
|
|
|
|
|
),
|
|
|
|
|
'javelin-request' =>
|
|
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/786bfe6f/rsrc/js/javelin/lib/Request.js',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-stratcom',
|
|
|
|
|
2 => 'javelin-util',
|
|
|
|
|
3 => 'javelin-behavior',
|
2011-07-04 07:43:37 +02:00
|
|
|
4 => 'javelin-json',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/lib/Request.js',
|
|
|
|
|
),
|
|
|
|
|
'javelin-stratcom' =>
|
|
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/d6cf4631/rsrc/js/javelin/core/Stratcom.js',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-event',
|
|
|
|
|
2 => 'javelin-util',
|
|
|
|
|
3 => 'javelin-magical-init',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/core/Stratcom.js',
|
|
|
|
|
),
|
|
|
|
|
'javelin-tokenizer' =>
|
|
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/c2dbba74/rsrc/js/javelin/lib/control/tokenizer/Tokenizer.js',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
2011-05-09 19:39:43 +02:00
|
|
|
0 => 'javelin-dom',
|
|
|
|
|
1 => 'javelin-util',
|
|
|
|
|
2 => 'javelin-stratcom',
|
|
|
|
|
3 => 'javelin-install',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/lib/control/tokenizer/Tokenizer.js',
|
|
|
|
|
),
|
|
|
|
|
'javelin-typeahead' =>
|
|
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/354d32f1/rsrc/js/javelin/lib/control/typeahead/Typeahead.js',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-dom',
|
|
|
|
|
2 => 'javelin-vector',
|
|
|
|
|
3 => 'javelin-util',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/lib/control/typeahead/Typeahead.js',
|
|
|
|
|
),
|
2011-07-04 07:43:37 +02:00
|
|
|
'javelin-typeahead-composite-source' =>
|
|
|
|
|
array(
|
|
|
|
|
'uri' => '/res/9873d21c/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js',
|
|
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-typeahead-source',
|
|
|
|
|
2 => 'javelin-util',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js',
|
|
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'javelin-typeahead-normalizer' =>
|
|
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/a5d60e3c/rsrc/js/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-install',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js',
|
|
|
|
|
),
|
|
|
|
|
'javelin-typeahead-ondemand-source' =>
|
|
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/b2e527e4/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-util',
|
|
|
|
|
2 => 'javelin-stratcom',
|
|
|
|
|
3 => 'javelin-request',
|
|
|
|
|
4 => 'javelin-typeahead-source',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js',
|
|
|
|
|
),
|
|
|
|
|
'javelin-typeahead-preloaded-source' =>
|
|
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/f3c1e7c7/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-util',
|
|
|
|
|
2 => 'javelin-stratcom',
|
|
|
|
|
3 => 'javelin-request',
|
|
|
|
|
4 => 'javelin-typeahead-source',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js',
|
|
|
|
|
),
|
|
|
|
|
'javelin-typeahead-source' =>
|
|
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/8a3aa262/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadSource.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-02-02 00:52:04 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-util',
|
|
|
|
|
2 => 'javelin-dom',
|
|
|
|
|
3 => 'javelin-typeahead-normalizer',
|
2011-02-02 00:52:04 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadSource.js',
|
2011-02-02 00:52:04 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'javelin-uri' =>
|
2011-01-25 20:57:47 +01:00
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/1c0ead43/rsrc/js/javelin/lib/URI.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-01-25 20:57:47 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-util',
|
2011-05-09 19:39:43 +02:00
|
|
|
2 => 'javelin-stratcom',
|
2011-01-25 20:57:47 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'disk' => '/rsrc/js/javelin/lib/URI.js',
|
2011-01-25 20:57:47 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'javelin-util' =>
|
2011-02-05 20:06:56 +01:00
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/725cc90d/rsrc/js/javelin/core/util.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-02-05 20:06:56 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'disk' => '/rsrc/js/javelin/core/util.js',
|
2011-02-05 20:06:56 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'javelin-vector' =>
|
2011-02-01 05:38:13 +01:00
|
|
|
array(
|
2011-07-05 23:07:14 +02:00
|
|
|
'uri' => '/res/50535cb8/rsrc/js/javelin/lib/Vector.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-02-01 05:38:13 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-event',
|
2011-02-01 05:38:13 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'disk' => '/rsrc/js/javelin/lib/Vector.js',
|
2011-02-01 05:38:13 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'javelin-workflow' =>
|
2011-03-23 01:08:08 +01:00
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/91a04640/rsrc/js/javelin/lib/Workflow.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-03-23 01:08:08 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-stratcom',
|
|
|
|
|
1 => 'javelin-request',
|
|
|
|
|
2 => 'javelin-dom',
|
|
|
|
|
3 => 'javelin-vector',
|
|
|
|
|
4 => 'javelin-install',
|
|
|
|
|
5 => 'javelin-util',
|
|
|
|
|
6 => 'javelin-mask',
|
|
|
|
|
7 => 'javelin-uri',
|
2011-03-23 01:08:08 +01:00
|
|
|
),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
'disk' => '/rsrc/js/javelin/lib/Workflow.js',
|
2011-03-23 01:08:08 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'mainphest-task-detail-css' =>
|
2011-03-23 01:08:08 +01:00
|
|
|
array(
|
Tweak Maniphest CSS, fix remarkup in description change views
Summary:
Various CSS tweaks and fixes:
- Add remarkup styling to description change views, missed this before.
- Fix CSS so that transactions with only one item (e.g., changed priority)
don't have weird floater underneath them.
- Add more space between transaction items.
- Make default background color lighter and less heavy.
- Use beigey color for comment form in Maniphest.
- Share more CSS between Maniphest and Differential (previews, feedback).
- Move "Leap Into Action" call to Differential, replace Maniphest with
thematically-consistent "Weigh In" (obviously, Maniphest has a nautical theme).
Test Plan:
Browsed Maniphest and Differential in a couple browsers, styling all seems
correct.
Reviewed By: tomo
Reviewers: tomo, aran, jungejason, tuomaspelkonen
CC: anjali, aran, tomo
Differential Revision: 328
2011-05-22 17:49:07 +02:00
|
|
|
'uri' => '/res/dbefc148/rsrc/css/application/maniphest/task-detail.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-03-23 01:08:08 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/maniphest/task-detail.css',
|
2011-03-23 01:08:08 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'maniphest-task-summary-css' =>
|
2011-02-08 19:53:59 +01:00
|
|
|
array(
|
2011-06-24 21:21:48 +02:00
|
|
|
'uri' => '/res/14cb4b5d/rsrc/css/application/maniphest/task-summary.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-02-08 19:53:59 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/maniphest/task-summary.css',
|
2011-03-31 08:27:06 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'maniphest-transaction-detail-css' =>
|
2011-03-31 08:27:06 +02:00
|
|
|
array(
|
2011-06-14 16:55:04 +02:00
|
|
|
'uri' => '/res/149fccab/rsrc/css/application/maniphest/transaction-detail.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-03-31 08:27:06 +02:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/maniphest/transaction-detail.css',
|
2011-02-08 19:53:59 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'multirow-row-manager' =>
|
2011-01-25 18:59:31 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/0a9b3dee/rsrc/js/application/core/MultirowRowManager.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-01-25 18:59:31 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-stratcom',
|
|
|
|
|
2 => 'javelin-dom',
|
|
|
|
|
3 => 'javelin-util',
|
2011-01-25 18:59:31 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/core/MultirowRowManager.js',
|
2011-01-25 18:59:31 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'owners-path-editor' =>
|
2011-04-04 04:20:47 +02:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/e6c51eb6/rsrc/js/application/owners/OwnersPathEditor.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-04-04 04:20:47 +02:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
2011-05-03 19:45:45 +02:00
|
|
|
0 => 'multirow-row-manager',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
1 => 'javelin-install',
|
|
|
|
|
2 => 'path-typeahead',
|
|
|
|
|
3 => 'javelin-dom',
|
|
|
|
|
4 => 'javelin-util',
|
2011-04-04 04:20:47 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/owners/OwnersPathEditor.js',
|
2011-04-04 04:20:47 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'owners-path-editor-css' =>
|
2011-01-25 18:59:31 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/9bc5332c/rsrc/css/application/owners/owners-path-editor.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 18:59:31 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/owners/owners-path-editor.css',
|
2011-01-25 18:59:31 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'path-typeahead' =>
|
2011-04-04 04:20:47 +02:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/1343345d/rsrc/js/application/herald/PathTypeahead.js',
|
2011-05-03 19:45:45 +02:00
|
|
|
'type' => 'js',
|
2011-04-04 04:20:47 +02:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-typeahead',
|
|
|
|
|
2 => 'javelin-dom',
|
|
|
|
|
3 => 'javelin-request',
|
|
|
|
|
4 => 'javelin-typeahead-ondemand-source',
|
|
|
|
|
5 => 'javelin-util',
|
2011-04-04 04:20:47 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/js/application/herald/PathTypeahead.js',
|
2011-04-04 04:20:47 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'phabricator-core-buttons-css' =>
|
2011-04-04 04:20:47 +02:00
|
|
|
array(
|
Simplify Maniphest button filter toggle things
Summary:
Although these filters work pretty well, you still end up doing a double take
sometimes. Make the behavior simpler and more consistent by adding an "All"
button to "Open / Closed" so all three rows behave the same way (before, the top
row was toggleable but the other rows were select-only-one).
I played around with the styles a little bit too to try to make the selected
state more obvious.
sandra/anjali, let me know if this is good enough once it lands or if I should
go further in playing around with the styles and making it more clear.
Test Plan:
Filtered tasks with the various filter buttons, verified the task list
accurately represented the filters.
Reviewed By: tuomaspelkonen
Reviewers: tuomaspelkonen, jungejason, aran
CC: anjali, sandra, aran, epriestley, tuomaspelkonen
Differential Revision: 364
2011-05-28 22:28:56 +02:00
|
|
|
'uri' => '/res/3059cf79/rsrc/css/core/buttons.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-04-04 04:20:47 +02:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/core/buttons.css',
|
2011-04-04 04:20:47 +02:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'phabricator-core-css' =>
|
2011-01-25 18:59:31 +01:00
|
|
|
array(
|
2011-06-14 05:41:07 +02:00
|
|
|
'uri' => '/res/bd20d04b/rsrc/css/core/core.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 18:59:31 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/core/core.css',
|
2011-01-25 18:59:31 +01:00
|
|
|
),
|
2011-06-13 01:06:17 +02:00
|
|
|
'phabricator-countdown-css' =>
|
|
|
|
|
array(
|
2011-06-14 05:41:07 +02:00
|
|
|
'uri' => '/res/0f646281/rsrc/css/application/countdown/timer.css',
|
2011-06-13 01:06:17 +02:00
|
|
|
'type' => 'css',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/css/application/countdown/timer.css',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'phabricator-directory-css' =>
|
2011-01-25 18:59:31 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/a3d307c5/rsrc/css/application/directory/phabricator-directory.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 18:59:31 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/directory/phabricator-directory.css',
|
2011-01-25 18:59:31 +01:00
|
|
|
),
|
2011-05-22 20:55:10 +02:00
|
|
|
'phabricator-drag-and-drop-file-upload' =>
|
|
|
|
|
array(
|
Improve drag-and-drop uploader
Summary:
Make it discoverable, show uploading progress, show file thumbnails, allow you
to remove files, make it a generic form component.
Test Plan:
Uploaded ducks
Reviewed By: tomo
Reviewers: aran, tomo, jungejason, tuomaspelkonen
CC: anjali, aran, epriestley, tomo
Differential Revision: 334
2011-05-23 01:11:41 +02:00
|
|
|
'uri' => '/res/63a06ad9/rsrc/js/application/core/DragAndDropFileUpload.js',
|
2011-05-22 20:55:10 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-util',
|
|
|
|
|
2 => 'javelin-request',
|
|
|
|
|
3 => 'javelin-dom',
|
|
|
|
|
4 => 'javelin-uri',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/core/DragAndDropFileUpload.js',
|
|
|
|
|
),
|
2011-07-09 22:28:09 +02:00
|
|
|
'phabricator-feed-css' =>
|
|
|
|
|
array(
|
2011-07-10 00:44:49 +02:00
|
|
|
'uri' => '/res/32e5879b/rsrc/css/application/feed/feed.css',
|
2011-07-09 22:28:09 +02:00
|
|
|
'type' => 'css',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/css/application/feed/feed.css',
|
|
|
|
|
),
|
2011-05-28 20:36:00 +02:00
|
|
|
'phabricator-keyboard-shortcut' =>
|
|
|
|
|
array(
|
|
|
|
|
'uri' => '/res/beed38cd/rsrc/js/application/core/KeyboardShortcut.js',
|
|
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-util',
|
|
|
|
|
2 => 'phabricator-keyboard-shortcut-manager',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/core/KeyboardShortcut.js',
|
|
|
|
|
),
|
|
|
|
|
'phabricator-keyboard-shortcut-manager' =>
|
|
|
|
|
array(
|
2011-06-20 23:21:17 +02:00
|
|
|
'uri' => '/res/04767571/rsrc/js/application/core/KeyboardShortcutManager.js',
|
2011-05-28 20:36:00 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-util',
|
|
|
|
|
2 => 'javelin-stratcom',
|
|
|
|
|
3 => 'javelin-dom',
|
2011-06-08 20:53:10 +02:00
|
|
|
4 => 'javelin-vector',
|
2011-05-28 20:36:00 +02:00
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/core/KeyboardShortcutManager.js',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'phabricator-object-selector-css' =>
|
2011-01-25 22:48:05 +01:00
|
|
|
array(
|
2011-06-10 17:34:17 +02:00
|
|
|
'uri' => '/res/608461d2/rsrc/css/application/objectselector/object-selector.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 22:48:05 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
2011-05-03 19:45:45 +02:00
|
|
|
0 => 'aphront-dialog-view-css',
|
2011-01-25 22:48:05 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/objectselector/object-selector.css',
|
2011-01-25 22:48:05 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'phabricator-profile-css' =>
|
2011-01-25 22:48:05 +01:00
|
|
|
array(
|
2011-07-08 01:08:43 +02:00
|
|
|
'uri' => '/res/ebe1ac2f/rsrc/css/application/profile/profile-view.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-01-25 22:48:05 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-06-18 10:13:56 +02:00
|
|
|
'disk' => '/rsrc/css/application/profile/profile-view.css',
|
2011-01-30 01:10:05 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'phabricator-remarkup-css' =>
|
2011-02-02 00:52:04 +01:00
|
|
|
array(
|
2011-07-10 01:17:36 +02:00
|
|
|
'uri' => '/res/7ca89111/rsrc/css/core/remarkup.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-02-02 00:52:04 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/core/remarkup.css',
|
2011-02-02 00:52:04 +01:00
|
|
|
),
|
Improve search result listing
Summary:
Make it prettier, paginate, add user pictures, show document types, clean some
stuff up a little. Plenty of room for improvement but this should make it a lot
more useful.
Test Plan:
Here's what the new one looks like:
https://secure.phabricator.com/file/view/PHID-FILE-edce2b83c2e3a121c2b7/
Reviewed By: jungejason
Reviewers: tomo, jungejason, aran, tuomaspelkonen, mroch
Commenters: tomo
CC: aran, tomo, jungejason, epriestley
Differential Revision: 545
2011-06-28 23:35:02 +02:00
|
|
|
'phabricator-search-results-css' =>
|
|
|
|
|
array(
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/f8a86e27/rsrc/css/application/search/search-results.css',
|
Improve search result listing
Summary:
Make it prettier, paginate, add user pictures, show document types, clean some
stuff up a little. Plenty of room for improvement but this should make it a lot
more useful.
Test Plan:
Here's what the new one looks like:
https://secure.phabricator.com/file/view/PHID-FILE-edce2b83c2e3a121c2b7/
Reviewed By: jungejason
Reviewers: tomo, jungejason, aran, tuomaspelkonen, mroch
Commenters: tomo
CC: aran, tomo, jungejason, epriestley
Differential Revision: 545
2011-06-28 23:35:02 +02:00
|
|
|
'type' => 'css',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/css/application/search/search-results.css',
|
|
|
|
|
),
|
2011-05-10 17:29:28 +02:00
|
|
|
'phabricator-shaped-request' =>
|
|
|
|
|
array(
|
2011-05-24 04:30:44 +02:00
|
|
|
'uri' => '/res/d7ba774e/rsrc/js/application/core/ShapedRequest.js',
|
2011-05-10 17:29:28 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
0 => 'javelin-install',
|
|
|
|
|
1 => 'javelin-util',
|
|
|
|
|
2 => 'javelin-request',
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/js/application/core/ShapedRequest.js',
|
|
|
|
|
),
|
2011-07-08 20:13:11 +02:00
|
|
|
'phabricator-slowvote-css' =>
|
|
|
|
|
array(
|
2011-07-09 22:28:09 +02:00
|
|
|
'uri' => '/res/94d20443/rsrc/css/application/slowvote/slowvote.css',
|
2011-07-08 20:13:11 +02:00
|
|
|
'type' => 'css',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/css/application/slowvote/slowvote.css',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'phabricator-standard-page-view' =>
|
2011-02-02 00:52:04 +01:00
|
|
|
array(
|
2011-06-20 22:49:17 +02:00
|
|
|
'uri' => '/res/e8238633/rsrc/css/application/base/standard-page-view.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-02-02 00:52:04 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/base/standard-page-view.css',
|
2011-03-23 03:34:47 +01:00
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'phabricator-ui-example-css' =>
|
2011-03-23 03:34:47 +01:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/0cef078b/rsrc/css/application/uiexample/example.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-03-23 03:34:47 +01:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/application/uiexample/example.css',
|
2011-03-31 08:27:06 +02:00
|
|
|
),
|
2011-07-11 21:34:53 +02:00
|
|
|
'phriction-document-css' =>
|
|
|
|
|
array(
|
Fix conservative CSRF token cycling limit
Summary:
We currently cycle CSRF tokens every hour and check for the last two valid ones.
This means that a form could go stale in as little as an hour, and is certainly
stale after two.
When a stale form is submitted, you basically get a terrible heisen-state where
some of your data might persist if you're lucky but more likely it all just
vanishes. The .js file below outlines some more details.
This is a pretty terrible UX and we don't need to be as conservative about CSRF
validation as we're being. Remedy this problem by:
- Accepting the last 6 CSRF tokens instead of the last 1 (i.e., pages are
valid for at least 6 hours, and for as long as 7).
- Using JS to refresh the CSRF token every 55 minutes (i.e., pages connected
to the internet are valid indefinitely).
- Showing the user an explicit message about what went wrong when CSRF
validation fails so the experience is less bewildering.
They should now only be able to submit with a bad CSRF token if:
- They load a page, disconnect from the internet for 7 hours, reconnect, and
submit the form within 55 minutes; or
- They are actually the victim of a CSRF attack.
We could eventually fix the first one by tracking reconnects, which might be
"free" once the notification server gets built. It will probably never be an
issue in practice.
Test Plan:
- Reduced CSRF cycle frequency to 2 seconds, submitted a form after 15
seconds, got the CSRF exception.
- Reduced csrf-refresh cycle frequency to 3 seconds, submitted a form after 15
seconds, got a clean form post.
- Added debugging code the the csrf refresh to make sure it was doing sensible
things (pulling different tokens, finding all the inputs).
Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
CC: aran, epriestley
Differential Revision: 660
2011-07-13 23:05:18 +02:00
|
|
|
'uri' => '/res/77d5f57f/rsrc/css/application/phriction/phriction-document-css.css',
|
2011-07-11 21:34:53 +02:00
|
|
|
'type' => 'css',
|
|
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
|
|
|
|
'disk' => '/rsrc/css/application/phriction/phriction-document-css.css',
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'syntax-highlighting-css' =>
|
2011-03-31 08:27:06 +02:00
|
|
|
array(
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/e5cc3d88/rsrc/css/core/syntax.css',
|
2011-04-15 03:08:10 +02:00
|
|
|
'type' => 'css',
|
2011-03-31 08:27:06 +02:00
|
|
|
'requires' =>
|
|
|
|
|
array(
|
|
|
|
|
),
|
2011-05-03 19:45:45 +02:00
|
|
|
'disk' => '/rsrc/css/core/syntax.css',
|
2011-02-02 00:52:04 +01:00
|
|
|
),
|
2011-01-30 01:10:05 +01:00
|
|
|
), array (
|
|
|
|
|
'packages' =>
|
|
|
|
|
array (
|
2011-05-09 10:10:40 +02:00
|
|
|
'03ef179e' =>
|
2011-05-09 19:39:43 +02:00
|
|
|
array (
|
2011-05-09 10:10:40 +02:00
|
|
|
'name' => 'diffusion.pkg.css',
|
2011-05-03 19:45:45 +02:00
|
|
|
'symbols' =>
|
|
|
|
|
array (
|
2011-05-09 10:10:40 +02:00
|
|
|
0 => 'diffusion-commit-view-css',
|
2011-05-03 19:45:45 +02:00
|
|
|
),
|
2011-05-09 10:10:40 +02:00
|
|
|
'uri' => '/res/pkg/03ef179e/diffusion.pkg.css',
|
|
|
|
|
'type' => 'css',
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
),
|
2011-07-04 07:43:37 +02:00
|
|
|
'25f94e94' =>
|
2011-05-09 10:10:40 +02:00
|
|
|
array (
|
|
|
|
|
'name' => 'typeahead.pkg.js',
|
|
|
|
|
'symbols' =>
|
|
|
|
|
array (
|
|
|
|
|
0 => 'javelin-typeahead',
|
|
|
|
|
1 => 'javelin-typeahead-normalizer',
|
|
|
|
|
2 => 'javelin-typeahead-source',
|
|
|
|
|
3 => 'javelin-typeahead-preloaded-source',
|
|
|
|
|
4 => 'javelin-typeahead-ondemand-source',
|
|
|
|
|
5 => 'javelin-tokenizer',
|
|
|
|
|
6 => 'javelin-behavior-aphront-basic-tokenizer',
|
|
|
|
|
),
|
2011-07-04 07:43:37 +02:00
|
|
|
'uri' => '/res/pkg/25f94e94/typeahead.pkg.js',
|
|
|
|
|
'type' => 'js',
|
|
|
|
|
),
|
2011-07-05 23:07:14 +02:00
|
|
|
'307df223' =>
|
2011-07-04 07:43:37 +02:00
|
|
|
array (
|
|
|
|
|
'name' => 'javelin.pkg.js',
|
|
|
|
|
'symbols' =>
|
|
|
|
|
array (
|
|
|
|
|
0 => 'javelin-util',
|
|
|
|
|
1 => 'javelin-install',
|
|
|
|
|
2 => 'javelin-event',
|
|
|
|
|
3 => 'javelin-stratcom',
|
|
|
|
|
4 => 'javelin-behavior',
|
|
|
|
|
5 => 'javelin-request',
|
|
|
|
|
6 => 'javelin-vector',
|
|
|
|
|
7 => 'javelin-dom',
|
|
|
|
|
8 => 'javelin-json',
|
|
|
|
|
9 => 'javelin-uri',
|
|
|
|
|
),
|
2011-07-05 23:07:14 +02:00
|
|
|
'uri' => '/res/pkg/307df223/javelin.pkg.js',
|
2011-05-09 10:10:40 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
),
|
2011-07-10 01:17:36 +02:00
|
|
|
'95b66c1a' =>
|
|
|
|
|
array (
|
|
|
|
|
'name' => 'differential.pkg.css',
|
|
|
|
|
'symbols' =>
|
|
|
|
|
array (
|
|
|
|
|
0 => 'differential-core-view-css',
|
|
|
|
|
1 => 'differential-changeset-view-css',
|
|
|
|
|
2 => 'differential-revision-detail-css',
|
|
|
|
|
3 => 'differential-revision-history-css',
|
|
|
|
|
4 => 'differential-table-of-contents-css',
|
|
|
|
|
5 => 'differential-revision-comment-css',
|
|
|
|
|
6 => 'differential-revision-add-comment-css',
|
|
|
|
|
7 => 'differential-revision-comment-list-css',
|
|
|
|
|
),
|
|
|
|
|
'uri' => '/res/pkg/95b66c1a/differential.pkg.css',
|
|
|
|
|
'type' => 'css',
|
|
|
|
|
),
|
|
|
|
|
'a06761eb' =>
|
2011-07-09 22:28:09 +02:00
|
|
|
array (
|
|
|
|
|
'name' => 'core.pkg.css',
|
|
|
|
|
'symbols' =>
|
|
|
|
|
array (
|
|
|
|
|
0 => 'phabricator-core-css',
|
|
|
|
|
1 => 'phabricator-core-buttons-css',
|
|
|
|
|
2 => 'phabricator-standard-page-view',
|
|
|
|
|
3 => 'aphront-dialog-view-css',
|
|
|
|
|
4 => 'aphront-form-view-css',
|
|
|
|
|
5 => 'aphront-panel-view-css',
|
|
|
|
|
6 => 'aphront-side-nav-view-css',
|
|
|
|
|
7 => 'aphront-table-view-css',
|
|
|
|
|
8 => 'aphront-crumbs-view-css',
|
|
|
|
|
9 => 'aphront-tokenizer-control-css',
|
|
|
|
|
10 => 'aphront-typeahead-control-css',
|
|
|
|
|
11 => 'aphront-list-filter-view-css',
|
|
|
|
|
12 => 'phabricator-directory-css',
|
|
|
|
|
13 => 'phabricator-remarkup-css',
|
|
|
|
|
14 => 'syntax-highlighting-css',
|
|
|
|
|
),
|
2011-07-10 01:17:36 +02:00
|
|
|
'uri' => '/res/pkg/a06761eb/core.pkg.css',
|
2011-07-08 22:28:59 +02:00
|
|
|
'type' => 'css',
|
|
|
|
|
),
|
2011-07-05 23:30:20 +02:00
|
|
|
'd0713563' =>
|
2011-06-10 17:34:17 +02:00
|
|
|
array (
|
|
|
|
|
'name' => 'workflow.pkg.js',
|
|
|
|
|
'symbols' =>
|
|
|
|
|
array (
|
|
|
|
|
0 => 'javelin-mask',
|
|
|
|
|
1 => 'javelin-workflow',
|
|
|
|
|
2 => 'javelin-behavior-workflow',
|
|
|
|
|
3 => 'javelin-behavior-aphront-form-disable-on-submit',
|
|
|
|
|
4 => 'phabricator-keyboard-shortcut-manager',
|
|
|
|
|
5 => 'phabricator-keyboard-shortcut',
|
|
|
|
|
6 => 'javelin-behavior-phabricator-keyboard-shortcuts',
|
|
|
|
|
),
|
2011-07-05 23:30:20 +02:00
|
|
|
'uri' => '/res/pkg/d0713563/workflow.pkg.js',
|
2011-07-04 07:43:37 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
),
|
|
|
|
|
'da416e1c' =>
|
|
|
|
|
array (
|
|
|
|
|
'name' => 'differential.pkg.js',
|
|
|
|
|
'symbols' =>
|
|
|
|
|
array (
|
|
|
|
|
0 => 'javelin-behavior-differential-feedback-preview',
|
|
|
|
|
1 => 'javelin-behavior-differential-edit-inline-comments',
|
|
|
|
|
2 => 'javelin-behavior-differential-populate',
|
|
|
|
|
3 => 'javelin-behavior-differential-show-more',
|
|
|
|
|
4 => 'javelin-behavior-differential-diff-radios',
|
|
|
|
|
),
|
|
|
|
|
'uri' => '/res/pkg/da416e1c/differential.pkg.js',
|
2011-06-10 17:34:17 +02:00
|
|
|
'type' => 'js',
|
|
|
|
|
),
|
2011-01-30 01:10:05 +01:00
|
|
|
),
|
|
|
|
|
'reverse' =>
|
|
|
|
|
array (
|
2011-07-10 01:17:36 +02:00
|
|
|
'aphront-crumbs-view-css' => 'a06761eb',
|
|
|
|
|
'aphront-dialog-view-css' => 'a06761eb',
|
|
|
|
|
'aphront-form-view-css' => 'a06761eb',
|
|
|
|
|
'aphront-list-filter-view-css' => 'a06761eb',
|
|
|
|
|
'aphront-panel-view-css' => 'a06761eb',
|
|
|
|
|
'aphront-side-nav-view-css' => 'a06761eb',
|
|
|
|
|
'aphront-table-view-css' => 'a06761eb',
|
|
|
|
|
'aphront-tokenizer-control-css' => 'a06761eb',
|
|
|
|
|
'aphront-typeahead-control-css' => 'a06761eb',
|
2011-07-08 22:28:59 +02:00
|
|
|
'differential-changeset-view-css' => '95b66c1a',
|
|
|
|
|
'differential-core-view-css' => '95b66c1a',
|
|
|
|
|
'differential-revision-add-comment-css' => '95b66c1a',
|
|
|
|
|
'differential-revision-comment-css' => '95b66c1a',
|
|
|
|
|
'differential-revision-comment-list-css' => '95b66c1a',
|
|
|
|
|
'differential-revision-detail-css' => '95b66c1a',
|
|
|
|
|
'differential-revision-history-css' => '95b66c1a',
|
|
|
|
|
'differential-table-of-contents-css' => '95b66c1a',
|
2011-05-09 10:10:40 +02:00
|
|
|
'diffusion-commit-view-css' => '03ef179e',
|
2011-07-05 23:07:14 +02:00
|
|
|
'javelin-behavior' => '307df223',
|
2011-07-04 07:43:37 +02:00
|
|
|
'javelin-behavior-aphront-basic-tokenizer' => '25f94e94',
|
2011-07-05 23:30:20 +02:00
|
|
|
'javelin-behavior-aphront-form-disable-on-submit' => 'd0713563',
|
2011-06-10 16:36:42 +02:00
|
|
|
'javelin-behavior-differential-diff-radios' => 'da416e1c',
|
|
|
|
|
'javelin-behavior-differential-edit-inline-comments' => 'da416e1c',
|
|
|
|
|
'javelin-behavior-differential-feedback-preview' => 'da416e1c',
|
|
|
|
|
'javelin-behavior-differential-populate' => 'da416e1c',
|
|
|
|
|
'javelin-behavior-differential-show-more' => 'da416e1c',
|
2011-07-05 23:30:20 +02:00
|
|
|
'javelin-behavior-phabricator-keyboard-shortcuts' => 'd0713563',
|
|
|
|
|
'javelin-behavior-workflow' => 'd0713563',
|
2011-07-05 23:07:14 +02:00
|
|
|
'javelin-dom' => '307df223',
|
|
|
|
|
'javelin-event' => '307df223',
|
|
|
|
|
'javelin-install' => '307df223',
|
|
|
|
|
'javelin-json' => '307df223',
|
2011-07-05 23:30:20 +02:00
|
|
|
'javelin-mask' => 'd0713563',
|
2011-07-05 23:07:14 +02:00
|
|
|
'javelin-request' => '307df223',
|
|
|
|
|
'javelin-stratcom' => '307df223',
|
2011-07-04 07:43:37 +02:00
|
|
|
'javelin-tokenizer' => '25f94e94',
|
|
|
|
|
'javelin-typeahead' => '25f94e94',
|
|
|
|
|
'javelin-typeahead-normalizer' => '25f94e94',
|
|
|
|
|
'javelin-typeahead-ondemand-source' => '25f94e94',
|
|
|
|
|
'javelin-typeahead-preloaded-source' => '25f94e94',
|
|
|
|
|
'javelin-typeahead-source' => '25f94e94',
|
2011-07-05 23:07:14 +02:00
|
|
|
'javelin-uri' => '307df223',
|
|
|
|
|
'javelin-util' => '307df223',
|
|
|
|
|
'javelin-vector' => '307df223',
|
2011-07-05 23:30:20 +02:00
|
|
|
'javelin-workflow' => 'd0713563',
|
2011-07-10 01:17:36 +02:00
|
|
|
'phabricator-core-buttons-css' => 'a06761eb',
|
|
|
|
|
'phabricator-core-css' => 'a06761eb',
|
|
|
|
|
'phabricator-directory-css' => 'a06761eb',
|
2011-07-05 23:30:20 +02:00
|
|
|
'phabricator-keyboard-shortcut' => 'd0713563',
|
|
|
|
|
'phabricator-keyboard-shortcut-manager' => 'd0713563',
|
2011-07-10 01:17:36 +02:00
|
|
|
'phabricator-remarkup-css' => 'a06761eb',
|
|
|
|
|
'phabricator-standard-page-view' => 'a06761eb',
|
|
|
|
|
'syntax-highlighting-css' => 'a06761eb',
|
2011-01-25 22:48:05 +01:00
|
|
|
),
|
2011-01-25 18:59:31 +01:00
|
|
|
));
|
