2011-02-05 20:06:56 +01:00
|
|
|
/**
|
|
|
|
|
* @provides javelin-behavior-differential-show-all-comments
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
* @requires javelin-behavior
|
|
|
|
|
* javelin-stratcom
|
|
|
|
|
* javelin-dom
|
2011-02-05 20:06:56 +01:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
JX.behavior('differential-show-all-comments', function(config) {
|
|
|
|
|
|
|
|
|
|
JX.Stratcom.listen(
|
|
|
|
|
'click',
|
|
|
|
|
'differential-show-all-comments',
|
|
|
|
|
function(e) {
|
|
|
|
|
JX.DOM.setContent(
|
|
|
|
|
e.getNode('differential-all-comments-container'),
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
JX.$H(config.markup));
|
2011-02-05 20:06:56 +01:00
|
|
|
e.kill();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
});
|
