2011-06-14 21:17:14 +02:00
|
|
|
<?php
|
|
|
|
|
2011-07-04 21:03:36 +02:00
|
|
|
/**
|
|
|
|
* @group conduit
|
|
|
|
*/
|
2012-03-10 00:46:25 +01:00
|
|
|
final class PhabricatorConduitTokenController
|
|
|
|
extends PhabricatorConduitController {
|
2011-06-14 21:17:14 +02:00
|
|
|
|
|
|
|
public function processRequest() {
|
|
|
|
|
|
|
|
$user = $this->getRequest()->getUser();
|
|
|
|
|
2011-08-17 21:00:35 +02:00
|
|
|
// Ideally we'd like to verify this, but it's fine to leave it unguarded
|
|
|
|
// for now and verifying it would need some Ajax junk or for the user to
|
|
|
|
// click a button or similar.
|
|
|
|
$unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
|
|
|
|
|
2011-06-14 21:17:14 +02:00
|
|
|
$old_token = id(new PhabricatorConduitCertificateToken())
|
|
|
|
->loadOneWhere(
|
|
|
|
'userPHID = %s',
|
|
|
|
$user->getPHID());
|
|
|
|
if ($old_token) {
|
|
|
|
$old_token->delete();
|
|
|
|
}
|
|
|
|
|
|
|
|
$token = id(new PhabricatorConduitCertificateToken())
|
|
|
|
->setUserPHID($user->getPHID())
|
Replace callsites to sha1() that use it to asciify entropy with
Filesystem::readRandomCharacters()
Summary: See T547. To improve auditability of use of crypto-sensitive hash
functions, use Filesystem::readRandomCharacters() in place of
sha1(Filesystem::readRandomBytes()) when we're just generating random ASCII
strings.
Test Plan:
- Generated a new PHID.
- Logged out and logged back in (to test sessions).
- Regenerated Conduit certificate.
- Created a new task, verified mail key generated sensibly.
- Created a new revision, verified mail key generated sensibly.
- Ran "arc list", got blocked, installed new certificate, ran "arc list"
again.
Reviewers: jungejason, nh, tuomaspelkonen, aran, benmathews
Reviewed By: jungejason
CC: aran, epriestley, jungejason
Differential Revision: 1000
2011-10-11 04:22:30 +02:00
|
|
|
->setToken(Filesystem::readRandomCharacters(40))
|
2011-06-14 21:17:14 +02:00
|
|
|
->save();
|
|
|
|
|
|
|
|
$panel = new AphrontPanelView();
|
|
|
|
$panel->setHeader('Certificate Install Token');
|
|
|
|
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
|
|
|
|
|
|
|
|
$panel->appendChild(
|
|
|
|
'<p class="aphront-form-instructions">Copy and paste this token into '.
|
|
|
|
'the prompt given to you by "arc install-certificate":</p>'.
|
|
|
|
'<p style="padding: 0 0 1em 4em;">'.
|
|
|
|
'<strong>'.phutil_escape_html($token->getToken()).'</strong>'.
|
|
|
|
'</p>'.
|
|
|
|
'<p class="aphront-form-instructions">arc will then complete the '.
|
|
|
|
'install process for you.</p>');
|
|
|
|
|
2012-01-26 21:47:23 +01:00
|
|
|
$this->setShowSideNav(false);
|
2011-06-14 21:17:14 +02:00
|
|
|
|
|
|
|
return $this->buildStandardPageResponse(
|
|
|
|
$panel,
|
|
|
|
array(
|
|
|
|
'title' => 'Certificate Install Token',
|
|
|
|
));
|
|
|
|
}
|
|
|
|
}
|