2011-01-31 03:24:57 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copyright 2011 Facebook, Inc.
|
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
2011-06-18 22:07:02 +02:00
|
|
|
function phabricator_date($epoch, $user) {
|
Improve time localization code
Summary:
- We throw on a missing date right now, in the DateTime constructor. This can
happen in reasonable cases and this is display code, so handle it more
gracefully (see T520).
- This stuff is a little slow and we sometimes render many hundreds of dates
per page. I've been seeing it in profiles on and off. Memoize timezones to
improve performance.
- Some minor code duplication that would have become less-minor with the
constructor change, consolidate the logic.
- Add some unit tests and a little documentation.
Test Plan:
- Ran unit tests.
- Profiled 1,000 calls to phabricator_datetime(), cost dropped from ~49ms to
~19ms with addition of memoization. This is still slower than I'd like but I
don't think there's an easy way to squeeze it down further.
Reviewers: ajtrichards, jungejason, nh, tuomaspelkonen, aran
Reviewed By: ajtrichards
CC: aran, ajtrichards, epriestley
Differential Revision: 966
2011-09-27 18:03:55 +02:00
|
|
|
return __phabricator_format_local_time(
|
|
|
|
$epoch,
|
|
|
|
$user,
|
|
|
|
'M j Y');
|
2011-06-18 22:07:02 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
function phabricator_time($epoch, $user) {
|
Improve time localization code
Summary:
- We throw on a missing date right now, in the DateTime constructor. This can
happen in reasonable cases and this is display code, so handle it more
gracefully (see T520).
- This stuff is a little slow and we sometimes render many hundreds of dates
per page. I've been seeing it in profiles on and off. Memoize timezones to
improve performance.
- Some minor code duplication that would have become less-minor with the
constructor change, consolidate the logic.
- Add some unit tests and a little documentation.
Test Plan:
- Ran unit tests.
- Profiled 1,000 calls to phabricator_datetime(), cost dropped from ~49ms to
~19ms with addition of memoization. This is still slower than I'd like but I
don't think there's an easy way to squeeze it down further.
Reviewers: ajtrichards, jungejason, nh, tuomaspelkonen, aran
Reviewed By: ajtrichards
CC: aran, ajtrichards, epriestley
Differential Revision: 966
2011-09-27 18:03:55 +02:00
|
|
|
return __phabricator_format_local_time(
|
|
|
|
$epoch,
|
|
|
|
$user,
|
|
|
|
'g:i A');
|
2011-06-18 22:07:02 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
function phabricator_datetime($epoch, $user) {
|
Improve time localization code
Summary:
- We throw on a missing date right now, in the DateTime constructor. This can
happen in reasonable cases and this is display code, so handle it more
gracefully (see T520).
- This stuff is a little slow and we sometimes render many hundreds of dates
per page. I've been seeing it in profiles on and off. Memoize timezones to
improve performance.
- Some minor code duplication that would have become less-minor with the
constructor change, consolidate the logic.
- Add some unit tests and a little documentation.
Test Plan:
- Ran unit tests.
- Profiled 1,000 calls to phabricator_datetime(), cost dropped from ~49ms to
~19ms with addition of memoization. This is still slower than I'd like but I
don't think there's an easy way to squeeze it down further.
Reviewers: ajtrichards, jungejason, nh, tuomaspelkonen, aran
Reviewed By: ajtrichards
CC: aran, ajtrichards, epriestley
Differential Revision: 966
2011-09-27 18:03:55 +02:00
|
|
|
return __phabricator_format_local_time(
|
|
|
|
$epoch,
|
|
|
|
$user,
|
|
|
|
'M j Y, g:i A');
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Internal date rendering method. Do not call this directly; instead, call
|
|
|
|
* @{function:phabricator_date}, @{function:phabricator_time}, or
|
|
|
|
* @{function:phabricator_datetime}.
|
|
|
|
*
|
|
|
|
* @param int Unix epoch timestamp.
|
|
|
|
* @param PhabricatorUser User viewing the timestamp.
|
|
|
|
* @param string Date format, as per DateTime class.
|
|
|
|
* @return string Formatted, local date/time.
|
|
|
|
*/
|
|
|
|
function __phabricator_format_local_time($epoch, $user, $format) {
|
|
|
|
if (!$epoch) {
|
|
|
|
// If we're missing date information for something, the DateTime class will
|
|
|
|
// throw an exception when we try to construct an object. Since this is a
|
|
|
|
// display function, just return an empty string.
|
|
|
|
return '';
|
|
|
|
}
|
|
|
|
|
|
|
|
$user_zone = $user->getTimezoneIdentifier();
|
|
|
|
|
|
|
|
static $zones = array();
|
|
|
|
if (empty($zones[$user_zone])) {
|
|
|
|
$zones[$user_zone] = new DateTimeZone($user_zone);
|
|
|
|
}
|
|
|
|
$zone = $zones[$user_zone];
|
|
|
|
|
|
|
|
// NOTE: Although DateTime takes a second DateTimeZone parameter to its
|
|
|
|
// constructor, it ignores it if the date string includes timezone
|
|
|
|
// information. Further, it treats epoch timestamps ("@946684800") as having
|
|
|
|
// a UTC timezone. Set the timezone explicitly after constructing the object.
|
Use phabricator_ time functions in more places
Summary:
Replace some more date() calls with locale-aware calls.
Also, at least on my system, the DateTimeZone / DateTime stuff didn't actually
work and always rendered in UTC. Fixed that.
Test Plan:
Viewed daemon console, differential revisions, files, and maniphest timestamps
in multiple timezones.
Reviewed By: toulouse
Reviewers: toulouse, fratrik, jungejason, aran, tuomaspelkonen
CC: aran, toulouse
Differential Revision: 530
2011-06-26 18:22:52 +02:00
|
|
|
$date = new DateTime('@'.$epoch);
|
|
|
|
$date->setTimeZone($zone);
|
Improve time localization code
Summary:
- We throw on a missing date right now, in the DateTime constructor. This can
happen in reasonable cases and this is display code, so handle it more
gracefully (see T520).
- This stuff is a little slow and we sometimes render many hundreds of dates
per page. I've been seeing it in profiles on and off. Memoize timezones to
improve performance.
- Some minor code duplication that would have become less-minor with the
constructor change, consolidate the logic.
- Add some unit tests and a little documentation.
Test Plan:
- Ran unit tests.
- Profiled 1,000 calls to phabricator_datetime(), cost dropped from ~49ms to
~19ms with addition of memoization. This is still slower than I'd like but I
don't think there's an easy way to squeeze it down further.
Reviewers: ajtrichards, jungejason, nh, tuomaspelkonen, aran
Reviewed By: ajtrichards
CC: aran, ajtrichards, epriestley
Differential Revision: 966
2011-09-27 18:03:55 +02:00
|
|
|
|
|
|
|
return $date->format($format);
|
2011-06-18 22:07:02 +02:00
|
|
|
}
|
|
|
|
|
2011-01-31 03:24:57 +01:00
|
|
|
function phabricator_format_relative_time($duration) {
|
|
|
|
return phabricator_format_units_generic(
|
|
|
|
$duration,
|
|
|
|
array(60, 60, 24, 7),
|
|
|
|
array('s', 'm', 'h', 'd', 'w'),
|
|
|
|
$precision = 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
function phabricator_format_units_generic(
|
|
|
|
$n,
|
|
|
|
array $scales,
|
|
|
|
array $labels,
|
|
|
|
$precision = 0,
|
|
|
|
&$remainder = null) {
|
|
|
|
|
2011-02-22 19:24:49 +01:00
|
|
|
$is_negative = false;
|
2011-01-31 03:24:57 +01:00
|
|
|
if ($n < 0) {
|
|
|
|
$is_negative = true;
|
|
|
|
$n = abs($n);
|
|
|
|
}
|
|
|
|
|
|
|
|
$remainder = 0;
|
|
|
|
$accum = 1;
|
|
|
|
|
|
|
|
$scale = array_shift($scales);
|
|
|
|
$label = array_shift($labels);
|
|
|
|
while ($n > $scale && count($labels)) {
|
|
|
|
$remainder += ($n % $scale) * $accum;
|
|
|
|
$n /= $scale;
|
|
|
|
$accum *= $scale;
|
|
|
|
$label = array_shift($labels);
|
|
|
|
if (!count($scales)) {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
$scale = array_shift($scales);
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($is_negative) {
|
|
|
|
$n = -$n;
|
|
|
|
$remainder = -$remainder;
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($precision) {
|
|
|
|
$num_string = number_format($n, $precision);
|
|
|
|
} else {
|
|
|
|
$num_string = (int)floor($n);
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($label) {
|
|
|
|
$num_string .= ' '.$label;
|
|
|
|
}
|
|
|
|
|
|
|
|
return $num_string;
|
|
|
|
}
|
|
|
|
|