revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-26 23:40:57 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/resources/sql/autopatches/20170328.reviewers.01.void.sql

3 lines
92 B
MySQL
Raw Normal View History

Fix an issue where "Request Review" of a fully-accepted revision would transition to "Accepted" Summary: Ref T10967. This is explained in more detail in T10967#217125 When an author does "Request Review" on an accepted revision, void (in the sense of "cancel out", like a bank check) any "accepted" reviewers on the current diff. Test Plan: - Create a revision with author A and reviewer B. - Accept as B. - "Request Review" as A. - (With sticky accepts enabled.) - Before patch: revision swithced back to "accepted". - After patch: the earlier review is "voided" by te "Request Review", and the revision switches to "Review Requested". Reviewers: chad Reviewed By: chad Maniphest Tasks: T10967 Differential Revision: https://secure.phabricator.com/D17566
2017-03-28 14:23:42 +02:00
ALTER TABLE {$NAMESPACE}_differential.differential_reviewer
ADD voidedPHID VARBINARY(64);
Copy permalink