2011-01-23 18:09:16 -08:00
|
|
|
<?php
|
|
|
|
|
2013-05-31 10:51:20 -07:00
|
|
|
final class PhabricatorUser
|
|
|
|
extends PhabricatorUserDAO
|
2013-06-07 09:55:55 -07:00
|
|
|
implements
|
|
|
|
PhutilPerson,
|
|
|
|
PhabricatorPolicyInterface,
|
|
|
|
PhabricatorCustomFieldInterface {
|
2011-01-23 18:09:16 -08:00
|
|
|
|
2011-02-05 22:36:21 -08:00
|
|
|
const SESSION_TABLE = 'phabricator_session';
|
2011-10-23 13:25:52 -07:00
|
|
|
const NAMETOKEN_TABLE = 'user_nametoken';
|
2013-08-13 14:37:23 -07:00
|
|
|
const MAXIMUM_USERNAME_LENGTH = 64;
|
2011-02-05 22:36:21 -08:00
|
|
|
|
2011-01-23 18:09:16 -08:00
|
|
|
protected $userName;
|
|
|
|
protected $realName;
|
2012-04-19 15:36:09 -07:00
|
|
|
protected $sex;
|
2012-06-14 18:08:06 -07:00
|
|
|
protected $translation;
|
2011-01-26 13:21:12 -08:00
|
|
|
protected $passwordSalt;
|
|
|
|
protected $passwordHash;
|
2011-01-30 21:28:45 -08:00
|
|
|
protected $profileImagePHID;
|
2011-06-20 13:00:31 -07:00
|
|
|
protected $timezoneIdentifier = '';
|
2011-01-23 18:09:16 -08:00
|
|
|
|
2011-02-02 22:38:42 -08:00
|
|
|
protected $consoleEnabled = 0;
|
|
|
|
protected $consoleVisible = 0;
|
|
|
|
protected $consoleTab = '';
|
2011-02-02 13:59:52 -08:00
|
|
|
|
2011-02-05 22:36:21 -08:00
|
|
|
protected $conduitCertificate;
|
|
|
|
|
2011-04-12 19:00:54 -07:00
|
|
|
protected $isSystemAgent = 0;
|
2011-05-12 10:06:54 -07:00
|
|
|
protected $isAdmin = 0;
|
|
|
|
protected $isDisabled = 0;
|
Improve handling of email verification and "activated" accounts
Summary:
Small step forward which improves existing stuff or lays groudwork for future stuff:
- Currently, to check for email verification, we have to single-query the email address on every page. Instead, denoramlize it into the user object.
- Migrate all the existing users.
- When the user verifies an email, mark them as `isEmailVerified` if the email is their primary email.
- Just make the checks look at the `isEmailVerified` field.
- Add a new check, `isUserActivated()`, to cover email-verified plus disabled. Currently, a non-verified-but-not-disabled user could theoretically use Conduit over SSH, if anyone deployed it. Tighten that up.
- Add an `isApproved` flag, which is always true for now. In a future diff, I want to add a default-on admin approval queue for new accounts, to prevent configuration mistakes. The way it will work is:
- When the queue is enabled, registering users are created with `isApproved = false`.
- Admins are sent an email, "[Phabricator] New User Approval (alincoln)", telling them that a new user is waiting for approval.
- They go to the web UI and approve the user.
- Manually-created accounts are auto-approved.
- The email will have instructions for disabling the queue.
I think this queue will be helpful for new installs and give them peace of mind, and when you go to disable it we have a better opportunity to warn you about exactly what that means.
Generally, I want to improve the default safety of registration, since if you just blindly coast through the path of least resistance right now your install ends up pretty open, and realistically few installs are on VPNs.
Test Plan:
- Ran migration, verified `isEmailVerified` populated correctly.
- Created a new user, checked DB for verified (not verified).
- Verified, checked DB (now verified).
- Used Conduit, People, Diffusion.
Reviewers: btrahan
Reviewed By: btrahan
CC: chad, aran
Differential Revision: https://secure.phabricator.com/D7572
2013-11-12 14:37:04 -08:00
|
|
|
protected $isEmailVerified = 0;
|
2013-11-13 11:24:56 -08:00
|
|
|
protected $isApproved = 0;
|
2011-04-12 18:19:09 -07:00
|
|
|
|
2014-03-19 19:28:04 -07:00
|
|
|
private $profileImage = self::ATTACHABLE;
|
2013-03-24 06:42:31 -07:00
|
|
|
private $profile = null;
|
2013-07-26 14:05:19 -07:00
|
|
|
private $status = self::ATTACHABLE;
|
2011-03-31 18:46:53 -07:00
|
|
|
private $preferences = null;
|
2013-02-28 11:01:40 -08:00
|
|
|
private $omnipotent = false;
|
2013-08-14 09:53:59 -07:00
|
|
|
private $customFields = self::ATTACHABLE;
|
2011-03-30 19:21:09 -07:00
|
|
|
|
2014-01-23 14:03:54 -08:00
|
|
|
private $alternateCSRFString = self::ATTACHABLE;
|
|
|
|
|
2011-10-07 15:03:00 -07:00
|
|
|
protected function readField($field) {
|
2011-11-16 09:49:18 -08:00
|
|
|
switch ($field) {
|
|
|
|
case 'timezoneIdentifier':
|
|
|
|
// If the user hasn't set one, guess the server's time.
|
|
|
|
return nonempty(
|
|
|
|
$this->timezoneIdentifier,
|
|
|
|
date_default_timezone_get());
|
|
|
|
// Make sure these return booleans.
|
|
|
|
case 'isAdmin':
|
|
|
|
return (bool)$this->isAdmin;
|
|
|
|
case 'isDisabled':
|
|
|
|
return (bool)$this->isDisabled;
|
|
|
|
case 'isSystemAgent':
|
|
|
|
return (bool)$this->isSystemAgent;
|
Improve handling of email verification and "activated" accounts
Summary:
Small step forward which improves existing stuff or lays groudwork for future stuff:
- Currently, to check for email verification, we have to single-query the email address on every page. Instead, denoramlize it into the user object.
- Migrate all the existing users.
- When the user verifies an email, mark them as `isEmailVerified` if the email is their primary email.
- Just make the checks look at the `isEmailVerified` field.
- Add a new check, `isUserActivated()`, to cover email-verified plus disabled. Currently, a non-verified-but-not-disabled user could theoretically use Conduit over SSH, if anyone deployed it. Tighten that up.
- Add an `isApproved` flag, which is always true for now. In a future diff, I want to add a default-on admin approval queue for new accounts, to prevent configuration mistakes. The way it will work is:
- When the queue is enabled, registering users are created with `isApproved = false`.
- Admins are sent an email, "[Phabricator] New User Approval (alincoln)", telling them that a new user is waiting for approval.
- They go to the web UI and approve the user.
- Manually-created accounts are auto-approved.
- The email will have instructions for disabling the queue.
I think this queue will be helpful for new installs and give them peace of mind, and when you go to disable it we have a better opportunity to warn you about exactly what that means.
Generally, I want to improve the default safety of registration, since if you just blindly coast through the path of least resistance right now your install ends up pretty open, and realistically few installs are on VPNs.
Test Plan:
- Ran migration, verified `isEmailVerified` populated correctly.
- Created a new user, checked DB for verified (not verified).
- Verified, checked DB (now verified).
- Used Conduit, People, Diffusion.
Reviewers: btrahan
Reviewed By: btrahan
CC: chad, aran
Differential Revision: https://secure.phabricator.com/D7572
2013-11-12 14:37:04 -08:00
|
|
|
case 'isEmailVerified':
|
|
|
|
return (bool)$this->isEmailVerified;
|
|
|
|
case 'isApproved':
|
|
|
|
return (bool)$this->isApproved;
|
2011-11-16 09:49:18 -08:00
|
|
|
default:
|
|
|
|
return parent::readField($field);
|
2011-10-07 15:03:00 -07:00
|
|
|
}
|
2011-01-31 16:00:42 -08:00
|
|
|
}
|
2011-01-30 18:52:29 -08:00
|
|
|
|
Improve handling of email verification and "activated" accounts
Summary:
Small step forward which improves existing stuff or lays groudwork for future stuff:
- Currently, to check for email verification, we have to single-query the email address on every page. Instead, denoramlize it into the user object.
- Migrate all the existing users.
- When the user verifies an email, mark them as `isEmailVerified` if the email is their primary email.
- Just make the checks look at the `isEmailVerified` field.
- Add a new check, `isUserActivated()`, to cover email-verified plus disabled. Currently, a non-verified-but-not-disabled user could theoretically use Conduit over SSH, if anyone deployed it. Tighten that up.
- Add an `isApproved` flag, which is always true for now. In a future diff, I want to add a default-on admin approval queue for new accounts, to prevent configuration mistakes. The way it will work is:
- When the queue is enabled, registering users are created with `isApproved = false`.
- Admins are sent an email, "[Phabricator] New User Approval (alincoln)", telling them that a new user is waiting for approval.
- They go to the web UI and approve the user.
- Manually-created accounts are auto-approved.
- The email will have instructions for disabling the queue.
I think this queue will be helpful for new installs and give them peace of mind, and when you go to disable it we have a better opportunity to warn you about exactly what that means.
Generally, I want to improve the default safety of registration, since if you just blindly coast through the path of least resistance right now your install ends up pretty open, and realistically few installs are on VPNs.
Test Plan:
- Ran migration, verified `isEmailVerified` populated correctly.
- Created a new user, checked DB for verified (not verified).
- Verified, checked DB (now verified).
- Used Conduit, People, Diffusion.
Reviewers: btrahan
Reviewed By: btrahan
CC: chad, aran
Differential Revision: https://secure.phabricator.com/D7572
2013-11-12 14:37:04 -08:00
|
|
|
|
|
|
|
/**
|
|
|
|
* Is this a live account which has passed required approvals? Returns true
|
|
|
|
* if this is an enabled, verified (if required), approved (if required)
|
|
|
|
* account, and false otherwise.
|
|
|
|
*
|
|
|
|
* @return bool True if this is a standard, usable account.
|
|
|
|
*/
|
|
|
|
public function isUserActivated() {
|
|
|
|
if ($this->getIsDisabled()) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!$this->getIsApproved()) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (PhabricatorUserEmail::isEmailVerificationRequired()) {
|
|
|
|
if (!$this->getIsEmailVerified()) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2011-01-23 18:09:16 -08:00
|
|
|
public function getConfiguration() {
|
|
|
|
return array(
|
|
|
|
self::CONFIG_AUX_PHID => true,
|
2011-10-07 15:03:00 -07:00
|
|
|
self::CONFIG_PARTIAL_OBJECTS => true,
|
2011-01-23 18:09:16 -08:00
|
|
|
) + parent::getConfiguration();
|
|
|
|
}
|
|
|
|
|
|
|
|
public function generatePHID() {
|
2011-03-02 18:58:21 -08:00
|
|
|
return PhabricatorPHID::generateNewPHID(
|
2013-07-26 14:05:19 -07:00
|
|
|
PhabricatorPeoplePHIDTypeUser::TYPECONST);
|
2011-01-23 18:09:16 -08:00
|
|
|
}
|
|
|
|
|
2012-07-17 12:06:33 -07:00
|
|
|
public function setPassword(PhutilOpaqueEnvelope $envelope) {
|
Mask typed passwords as they are entered into 'accountadmin'
Summary:
Currently, we echo the password as the user types it. This turns out to be a bit
of an issue in over-the-shoulder installs. Instead, disable tty echo while the
user is typing their password so nothing is shown (like how 'sudo' works).
Also show a better error message if the user chooses a duplicate email; without
testing for this we just throw a duplicate key exception when saving, which
isn't easy to understand. The other duplicate key exception is duplicate
username, which is impossible (the script updates rather than creating in this
case).
There's currently a bug where creating a user and setting their password at the
same time doesn't work. This is because we hash the PHID into the password hash,
but it's empty if the user hasn't been persisted yet. Make sure the user is
persisted before setting their password.
Finally, fix an issue where $original would have the new username set, creating
a somewhat confusing summary at the end.
I'm also going to improve the password behavior/explanation here once I add
welcome emails ("Hi Joe, epriestley created an account for you on Phabricator,
click here to login...").
Test Plan:
- Typed a password and didn't have it echoed. I also tested this on Ubuntu
without encountering problems.
- Chose a duplicate email, got a useful error message instead of the exception
I'd encountered earlier.
- Created a new user with a password in one pass and logged in as that user,
this worked properly.
- Verified summary table does not contain username for new users.
Reviewed By: jungejason
Reviewers: jungejason, tuomaspelkonen, aran
CC: moskov, jr, aran, jungejason
Differential Revision: 358
2011-05-28 07:17:42 -07:00
|
|
|
if (!$this->getPHID()) {
|
|
|
|
throw new Exception(
|
|
|
|
"You can not set a password for an unsaved user because their PHID ".
|
|
|
|
"is a salt component in the password hash.");
|
|
|
|
}
|
|
|
|
|
2012-07-17 12:06:33 -07:00
|
|
|
if (!strlen($envelope->openEnvelope())) {
|
2011-05-12 10:06:54 -07:00
|
|
|
$this->setPasswordHash('');
|
|
|
|
} else {
|
2014-02-18 09:31:30 -08:00
|
|
|
$this->setPasswordSalt(md5(Filesystem::readRandomBytes(32)));
|
2012-07-17 12:06:33 -07:00
|
|
|
$hash = $this->hashPassword($envelope);
|
2014-02-18 09:31:30 -08:00
|
|
|
$this->setPasswordHash($hash->openEnvelope());
|
2011-05-12 10:06:54 -07:00
|
|
|
}
|
2011-01-26 13:21:12 -08:00
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2012-06-14 18:08:06 -07:00
|
|
|
// To satisfy PhutilPerson.
|
|
|
|
public function getSex() {
|
|
|
|
return $this->sex;
|
|
|
|
}
|
|
|
|
|
2012-06-15 23:21:25 -07:00
|
|
|
public function getTranslation() {
|
|
|
|
try {
|
|
|
|
if ($this->translation &&
|
|
|
|
class_exists($this->translation) &&
|
|
|
|
is_subclass_of($this->translation, 'PhabricatorTranslation')) {
|
|
|
|
return $this->translation;
|
|
|
|
}
|
|
|
|
} catch (PhutilMissingSymbolException $ex) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
2011-10-24 12:27:16 -07:00
|
|
|
public function isLoggedIn() {
|
|
|
|
return !($this->getPHID() === null);
|
|
|
|
}
|
|
|
|
|
2011-02-05 22:36:21 -08:00
|
|
|
public function save() {
|
2011-10-07 15:03:00 -07:00
|
|
|
if (!$this->getConduitCertificate()) {
|
|
|
|
$this->setConduitCertificate($this->generateConduitCertificate());
|
2011-02-05 22:36:21 -08:00
|
|
|
}
|
2011-06-23 13:31:20 -07:00
|
|
|
$result = parent::save();
|
|
|
|
|
2013-06-07 10:22:45 -07:00
|
|
|
if ($this->profile) {
|
|
|
|
$this->profile->save();
|
|
|
|
}
|
|
|
|
|
2011-10-23 13:25:52 -07:00
|
|
|
$this->updateNameTokens();
|
Improve Search architecture
Summary:
The search indexing API has several problems right now:
- Always runs in-process.
- It would be nice to push this into the task queue for performance. However, the API currently passses an object all the way through (and some indexers depend on preloaded object attributes), so it can't be dumped into the task queue at any stage since we can't serialize it.
- Being able to use the task queue will also make rebuilding indexes faster.
- Instead, make the API phid-oriented.
- No uniform indexing API.
- Each "Editor" currently calls SomeCustomIndexer::indexThing(). This won't work with AbstractTransactions. The API is also just weird.
- Instead, provide a uniform API.
- No uniform CLI.
- We have `scripts/search/reindex_everything.php`, but it doesn't actually index everything. Each new document type needs to be separately added to it, leading to stuff like D3839. Third-party applications can't provide indexers.
- Instead, let indexers expose documents for indexing.
- Not application-oriented.
- All the indexers live in search/ right now, which isn't the right organization in an application-orietned view of the world.
- Instead, move indexers to applications and load them with SymbolLoader.
Test Plan:
- `bin/search index`
- Indexed one revision, one task.
- Indexed `--type TASK`, `--type DREV`, etc., for all types.
- Indexed `--all`.
- Added the word "saboteur" to a revision, task, wiki page, and question and then searched for it.
- Creating users is a pain; searched for a user after indexing.
- Creating commits is a pain; searched for a commit after indexing.
- Mocks aren't currently loadable in the result view, so their indexing is moot.
Reviewers: btrahan, vrana
Reviewed By: btrahan
CC: 20after4, aran
Maniphest Tasks: T1991, T2104
Differential Revision: https://secure.phabricator.com/D4261
2012-12-21 14:21:31 -08:00
|
|
|
|
|
|
|
id(new PhabricatorSearchIndexer())
|
2014-01-14 13:22:56 -08:00
|
|
|
->queueDocumentForIndexing($this->getPHID());
|
2011-06-23 13:31:20 -07:00
|
|
|
|
|
|
|
return $result;
|
2011-02-05 22:36:21 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
private function generateConduitCertificate() {
|
Replace callsites to sha1() that use it to asciify entropy with
Filesystem::readRandomCharacters()
Summary: See T547. To improve auditability of use of crypto-sensitive hash
functions, use Filesystem::readRandomCharacters() in place of
sha1(Filesystem::readRandomBytes()) when we're just generating random ASCII
strings.
Test Plan:
- Generated a new PHID.
- Logged out and logged back in (to test sessions).
- Regenerated Conduit certificate.
- Created a new task, verified mail key generated sensibly.
- Created a new revision, verified mail key generated sensibly.
- Ran "arc list", got blocked, installed new certificate, ran "arc list"
again.
Reviewers: jungejason, nh, tuomaspelkonen, aran, benmathews
Reviewed By: jungejason
CC: aran, epriestley, jungejason
Differential Revision: 1000
2011-10-10 19:22:30 -07:00
|
|
|
return Filesystem::readRandomCharacters(255);
|
2011-02-05 22:36:21 -08:00
|
|
|
}
|
|
|
|
|
2012-07-17 12:06:33 -07:00
|
|
|
public function comparePassword(PhutilOpaqueEnvelope $envelope) {
|
|
|
|
if (!strlen($envelope->openEnvelope())) {
|
2011-05-12 10:06:54 -07:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
if (!strlen($this->getPasswordHash())) {
|
|
|
|
return false;
|
|
|
|
}
|
2014-02-18 09:31:30 -08:00
|
|
|
|
|
|
|
return PhabricatorPasswordHasher::comparePassword(
|
|
|
|
$this->getPasswordHashInput($envelope),
|
2014-02-18 10:12:47 -08:00
|
|
|
new PhutilOpaqueEnvelope($this->getPasswordHash()));
|
2011-01-26 13:21:12 -08:00
|
|
|
}
|
|
|
|
|
2014-02-18 09:31:30 -08:00
|
|
|
private function getPasswordHashInput(PhutilOpaqueEnvelope $password) {
|
|
|
|
$input =
|
|
|
|
$this->getUsername().
|
|
|
|
$password->openEnvelope().
|
|
|
|
$this->getPHID().
|
|
|
|
$this->getPasswordSalt();
|
|
|
|
|
|
|
|
return new PhutilOpaqueEnvelope($input);
|
|
|
|
}
|
|
|
|
|
|
|
|
private function hashPassword(PhutilOpaqueEnvelope $password) {
|
|
|
|
$hasher = PhabricatorPasswordHasher::getBestHasher();
|
|
|
|
|
|
|
|
$input_envelope = $this->getPasswordHashInput($password);
|
2014-02-18 10:12:47 -08:00
|
|
|
return $hasher->getPasswordHashForStorage($input_envelope);
|
2011-01-26 13:21:12 -08:00
|
|
|
}
|
|
|
|
|
2011-01-31 11:55:26 -08:00
|
|
|
const CSRF_CYCLE_FREQUENCY = 3600;
|
2013-08-07 16:09:05 -07:00
|
|
|
const CSRF_SALT_LENGTH = 8;
|
2011-01-31 11:55:26 -08:00
|
|
|
const CSRF_TOKEN_LENGTH = 16;
|
2013-08-07 16:09:05 -07:00
|
|
|
const CSRF_BREACH_PREFIX = 'B@';
|
2011-01-31 11:55:26 -08:00
|
|
|
|
|
|
|
const EMAIL_CYCLE_FREQUENCY = 86400;
|
|
|
|
const EMAIL_TOKEN_LENGTH = 24;
|
|
|
|
|
2013-08-07 16:09:05 -07:00
|
|
|
private function getRawCSRFToken($offset = 0) {
|
2011-01-31 11:55:26 -08:00
|
|
|
return $this->generateToken(
|
|
|
|
time() + (self::CSRF_CYCLE_FREQUENCY * $offset),
|
|
|
|
self::CSRF_CYCLE_FREQUENCY,
|
|
|
|
PhabricatorEnv::getEnvConfig('phabricator.csrf-key'),
|
|
|
|
self::CSRF_TOKEN_LENGTH);
|
2011-01-30 18:52:29 -08:00
|
|
|
}
|
|
|
|
|
2013-08-07 16:09:05 -07:00
|
|
|
/**
|
|
|
|
* @phutil-external-symbol class PhabricatorStartup
|
|
|
|
*/
|
|
|
|
public function getCSRFToken() {
|
|
|
|
$salt = PhabricatorStartup::getGlobal('csrf.salt');
|
|
|
|
if (!$salt) {
|
|
|
|
$salt = Filesystem::readRandomCharacters(self::CSRF_SALT_LENGTH);
|
|
|
|
PhabricatorStartup::setGlobal('csrf.salt', $salt);
|
|
|
|
}
|
Fix conservative CSRF token cycling limit
Summary:
We currently cycle CSRF tokens every hour and check for the last two valid ones.
This means that a form could go stale in as little as an hour, and is certainly
stale after two.
When a stale form is submitted, you basically get a terrible heisen-state where
some of your data might persist if you're lucky but more likely it all just
vanishes. The .js file below outlines some more details.
This is a pretty terrible UX and we don't need to be as conservative about CSRF
validation as we're being. Remedy this problem by:
- Accepting the last 6 CSRF tokens instead of the last 1 (i.e., pages are
valid for at least 6 hours, and for as long as 7).
- Using JS to refresh the CSRF token every 55 minutes (i.e., pages connected
to the internet are valid indefinitely).
- Showing the user an explicit message about what went wrong when CSRF
validation fails so the experience is less bewildering.
They should now only be able to submit with a bad CSRF token if:
- They load a page, disconnect from the internet for 7 hours, reconnect, and
submit the form within 55 minutes; or
- They are actually the victim of a CSRF attack.
We could eventually fix the first one by tracking reconnects, which might be
"free" once the notification server gets built. It will probably never be an
issue in practice.
Test Plan:
- Reduced CSRF cycle frequency to 2 seconds, submitted a form after 15
seconds, got the CSRF exception.
- Reduced csrf-refresh cycle frequency to 3 seconds, submitted a form after 15
seconds, got a clean form post.
- Added debugging code the the csrf refresh to make sure it was doing sensible
things (pulling different tokens, finding all the inputs).
Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
CC: aran, epriestley
Differential Revision: 660
2011-07-13 14:05:18 -07:00
|
|
|
|
2013-08-07 16:09:05 -07:00
|
|
|
// Generate a token hash to mitigate BREACH attacks against SSL. See
|
|
|
|
// discussion in T3684.
|
|
|
|
$token = $this->getRawCSRFToken();
|
|
|
|
$hash = PhabricatorHash::digest($token, $salt);
|
|
|
|
return 'B@'.$salt.substr($hash, 0, self::CSRF_TOKEN_LENGTH);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function validateCSRFToken($token) {
|
|
|
|
$salt = null;
|
|
|
|
$version = 'plain';
|
|
|
|
|
|
|
|
// This is a BREACH-mitigating token. See T3684.
|
|
|
|
$breach_prefix = self::CSRF_BREACH_PREFIX;
|
|
|
|
$breach_prelen = strlen($breach_prefix);
|
|
|
|
|
|
|
|
if (!strncmp($token, $breach_prefix, $breach_prelen)) {
|
|
|
|
$version = 'breach';
|
|
|
|
$salt = substr($token, $breach_prelen, self::CSRF_SALT_LENGTH);
|
|
|
|
$token = substr($token, $breach_prelen + self::CSRF_SALT_LENGTH);
|
|
|
|
}
|
|
|
|
|
Fix conservative CSRF token cycling limit
Summary:
We currently cycle CSRF tokens every hour and check for the last two valid ones.
This means that a form could go stale in as little as an hour, and is certainly
stale after two.
When a stale form is submitted, you basically get a terrible heisen-state where
some of your data might persist if you're lucky but more likely it all just
vanishes. The .js file below outlines some more details.
This is a pretty terrible UX and we don't need to be as conservative about CSRF
validation as we're being. Remedy this problem by:
- Accepting the last 6 CSRF tokens instead of the last 1 (i.e., pages are
valid for at least 6 hours, and for as long as 7).
- Using JS to refresh the CSRF token every 55 minutes (i.e., pages connected
to the internet are valid indefinitely).
- Showing the user an explicit message about what went wrong when CSRF
validation fails so the experience is less bewildering.
They should now only be able to submit with a bad CSRF token if:
- They load a page, disconnect from the internet for 7 hours, reconnect, and
submit the form within 55 minutes; or
- They are actually the victim of a CSRF attack.
We could eventually fix the first one by tracking reconnects, which might be
"free" once the notification server gets built. It will probably never be an
issue in practice.
Test Plan:
- Reduced CSRF cycle frequency to 2 seconds, submitted a form after 15
seconds, got the CSRF exception.
- Reduced csrf-refresh cycle frequency to 3 seconds, submitted a form after 15
seconds, got a clean form post.
- Added debugging code the the csrf refresh to make sure it was doing sensible
things (pulling different tokens, finding all the inputs).
Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
CC: aran, epriestley
Differential Revision: 660
2011-07-13 14:05:18 -07:00
|
|
|
// When the user posts a form, we check that it contains a valid CSRF token.
|
|
|
|
// Tokens cycle each hour (every CSRF_CYLCE_FREQUENCY seconds) and we accept
|
|
|
|
// either the current token, the next token (users can submit a "future"
|
|
|
|
// token if you have two web frontends that have some clock skew) or any of
|
|
|
|
// the last 6 tokens. This means that pages are valid for up to 7 hours.
|
|
|
|
// There is also some Javascript which periodically refreshes the CSRF
|
|
|
|
// tokens on each page, so theoretically pages should be valid indefinitely.
|
|
|
|
// However, this code may fail to run (if the user loses their internet
|
|
|
|
// connection, or there's a JS problem, or they don't have JS enabled).
|
|
|
|
// Choosing the size of the window in which we accept old CSRF tokens is
|
|
|
|
// an issue of balancing concerns between security and usability. We could
|
|
|
|
// choose a very narrow (e.g., 1-hour) window to reduce vulnerability to
|
|
|
|
// attacks using captured CSRF tokens, but it's also more likely that real
|
|
|
|
// users will be affected by this, e.g. if they close their laptop for an
|
|
|
|
// hour, open it back up, and try to submit a form before the CSRF refresh
|
|
|
|
// can kick in. Since the user experience of submitting a form with expired
|
|
|
|
// CSRF is often quite bad (you basically lose data, or it's a big pain to
|
|
|
|
// recover at least) and I believe we gain little additional protection
|
|
|
|
// by keeping the window very short (the overwhelming value here is in
|
|
|
|
// preventing blind attacks, and most attacks which can capture CSRF tokens
|
|
|
|
// can also just capture authentication information [sniffing networks]
|
|
|
|
// or act as the user [xss]) the 7 hour default seems like a reasonable
|
|
|
|
// balance. Other major platforms have much longer CSRF token lifetimes,
|
|
|
|
// like Rails (session duration) and Django (forever), which suggests this
|
|
|
|
// is a reasonable analysis.
|
|
|
|
$csrf_window = 6;
|
|
|
|
|
|
|
|
for ($ii = -$csrf_window; $ii <= 1; $ii++) {
|
2013-08-07 16:09:05 -07:00
|
|
|
$valid = $this->getRawCSRFToken($ii);
|
|
|
|
switch ($version) {
|
|
|
|
// TODO: We can remove this after the BREACH version has been in the
|
|
|
|
// wild for a while.
|
|
|
|
case 'plain':
|
|
|
|
if ($token == $valid) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case 'breach':
|
|
|
|
$digest = PhabricatorHash::digest($valid, $salt);
|
|
|
|
if (substr($digest, 0, self::CSRF_TOKEN_LENGTH) == $token) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
throw new Exception("Unknown CSRF token format!");
|
2011-01-30 18:52:29 -08:00
|
|
|
}
|
|
|
|
}
|
Validate logins, and simplify email password resets
Summary:
- There are some recent reports of login issues, see T755 and T754. I'm not
really sure what's going on, but this is an attempt at getting some more
information.
- When we login a user by setting 'phusr' and 'phsid', send them to
/login/validate/ to validate that the cookies actually got set.
- Do email password resets in two steps: first, log the user in. Redirect them
through validate, then give them the option to reset their password.
- Don't CSRF logged-out users. It technically sort of works most of the time
right now, but is silly. If we need logged-out CSRF we should generate it in
some more reliable way.
Test Plan:
- Logged in with username/password.
- Logged in with OAuth.
- Logged in with email password reset.
- Sent bad values to /login/validate/, got appropriate errors.
- Reset password.
- Verified next_uri still works.
Reviewers: btrahan, jungejason
Reviewed By: btrahan
CC: aran, btrahan, j3kuntz
Maniphest Tasks: T754, T755
Differential Revision: https://secure.phabricator.com/D1353
2012-01-10 14:42:07 -08:00
|
|
|
|
2011-01-30 18:52:29 -08:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2011-01-31 11:55:26 -08:00
|
|
|
private function generateToken($epoch, $frequency, $key, $len) {
|
2014-01-23 14:03:54 -08:00
|
|
|
if ($this->getPHID()) {
|
|
|
|
$vec = $this->getPHID().$this->getPasswordHash();
|
|
|
|
} else {
|
|
|
|
$vec = $this->getAlternateCSRFString();
|
|
|
|
}
|
|
|
|
|
2011-01-31 11:55:26 -08:00
|
|
|
$time_block = floor($epoch / $frequency);
|
2014-01-23 14:03:54 -08:00
|
|
|
$vec = $vec.$key.$time_block;
|
|
|
|
|
2011-12-18 11:00:39 -08:00
|
|
|
return substr(PhabricatorHash::digest($vec), 0, $len);
|
2011-01-30 18:52:29 -08:00
|
|
|
}
|
|
|
|
|
2012-05-07 10:29:33 -07:00
|
|
|
private function generateEmailToken(
|
|
|
|
PhabricatorUserEmail $email,
|
|
|
|
$offset = 0) {
|
|
|
|
|
|
|
|
$key = implode(
|
|
|
|
'-',
|
|
|
|
array(
|
|
|
|
PhabricatorEnv::getEnvConfig('phabricator.csrf-key'),
|
|
|
|
$this->getPHID(),
|
|
|
|
$email->getVerificationCode(),
|
|
|
|
));
|
|
|
|
|
2011-01-31 11:55:26 -08:00
|
|
|
return $this->generateToken(
|
|
|
|
time() + ($offset * self::EMAIL_CYCLE_FREQUENCY),
|
|
|
|
self::EMAIL_CYCLE_FREQUENCY,
|
2012-05-07 10:29:33 -07:00
|
|
|
$key,
|
2011-01-31 11:55:26 -08:00
|
|
|
self::EMAIL_TOKEN_LENGTH);
|
|
|
|
}
|
|
|
|
|
2012-05-07 10:29:33 -07:00
|
|
|
public function validateEmailToken(
|
|
|
|
PhabricatorUserEmail $email,
|
|
|
|
$token) {
|
2011-01-31 11:55:26 -08:00
|
|
|
for ($ii = -1; $ii <= 1; $ii++) {
|
2012-05-07 10:29:33 -07:00
|
|
|
$valid = $this->generateEmailToken($email, $ii);
|
2011-01-31 11:55:26 -08:00
|
|
|
if ($token == $valid) {
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2012-05-07 10:29:33 -07:00
|
|
|
public function getEmailLoginURI(PhabricatorUserEmail $email = null) {
|
|
|
|
if (!$email) {
|
|
|
|
$email = $this->loadPrimaryEmail();
|
|
|
|
if (!$email) {
|
|
|
|
throw new Exception("User has no primary email!");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
$token = $this->generateEmailToken($email);
|
2013-11-20 10:36:00 -08:00
|
|
|
|
|
|
|
$uri = '/login/etoken/'.$token.'/';
|
|
|
|
try {
|
|
|
|
$uri = PhabricatorEnv::getProductionURI($uri);
|
|
|
|
} catch (Exception $ex) {
|
|
|
|
// If a user runs `bin/auth recover` before configuring the base URI,
|
|
|
|
// just show the path. We don't have any way to figure out the domain.
|
|
|
|
// See T4132.
|
|
|
|
}
|
|
|
|
|
Revise administrative workflow for user creation
Summary:
- When an administrator creates a user, provide an option to send a welcome
email. Right now this workflow kind of dead-ends.
- Prevent administrators from changing the "System Agent" flag. If they can
change it, they can grab another user's certificate and then act as them. This
is a vaguely weaker security policy than is exhibited elsewhere in the
application. Instead, make user accounts immutably normal users or system agents
at creation time.
- Prevent administrators from changing email addresses after account creation.
Same deal as conduit certs. The 'bin/accountadmin' script can still do this if a
user has a real problem.
- Prevent administrators from resetting passwords. There's no need for this
anymore with welcome emails plus email login and it raises the same issues.
Test Plan:
- Created a new account, selected "send welcome email", got a welcome email,
logged in with the link inside it.
- Created a new system agent.
- Reset an account's password.
Reviewed By: aran
Reviewers: tuomaspelkonen, jungejason, aran
CC: anjali, aran, epriestley
Differential Revision: 379
2011-05-30 14:59:17 -07:00
|
|
|
$uri = new PhutilURI($uri);
|
2013-11-20 10:36:00 -08:00
|
|
|
|
2012-05-07 10:29:33 -07:00
|
|
|
return $uri->alter('email', $email->getAddress());
|
|
|
|
}
|
|
|
|
|
2013-03-24 06:42:31 -07:00
|
|
|
public function attachUserProfile(PhabricatorUserProfile $profile) {
|
|
|
|
$this->profile = $profile;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function loadUserProfile() {
|
|
|
|
if ($this->profile) {
|
|
|
|
return $this->profile;
|
|
|
|
}
|
|
|
|
|
|
|
|
$profile_dao = new PhabricatorUserProfile();
|
|
|
|
$this->profile = $profile_dao->loadOneWhere('userPHID = %s',
|
|
|
|
$this->getPHID());
|
|
|
|
|
|
|
|
if (!$this->profile) {
|
|
|
|
$profile_dao->setUserPHID($this->getPHID());
|
|
|
|
$this->profile = $profile_dao;
|
|
|
|
}
|
|
|
|
|
|
|
|
return $this->profile;
|
|
|
|
}
|
|
|
|
|
2012-05-07 10:29:33 -07:00
|
|
|
public function loadPrimaryEmailAddress() {
|
|
|
|
$email = $this->loadPrimaryEmail();
|
|
|
|
if (!$email) {
|
|
|
|
throw new Exception("User has no primary email address!");
|
|
|
|
}
|
|
|
|
return $email->getAddress();
|
|
|
|
}
|
|
|
|
|
|
|
|
public function loadPrimaryEmail() {
|
2012-05-25 13:11:33 -07:00
|
|
|
return $this->loadOneRelative(
|
|
|
|
new PhabricatorUserEmail(),
|
|
|
|
'userPHID',
|
|
|
|
'getPHID',
|
|
|
|
'(isPrimary = 1)');
|
Allow installs to require email verification
Summary:
Allow installs to require users to verify email addresses before they can use Phabricator. If a user logs in without a verified email address, they're given instructions to verify their address.
This isn't too useful on its own since we don't actually have arbitrary email registration, but the next step is to allow installs to restrict email to only some domains (e.g., @mycompany.com).
Test Plan:
- Verification
- Set verification requirement to `true`.
- Tried to use Phabricator with an unverified account, was told to verify.
- Tried to use Conduit, was given a verification error.
- Verified account, used Phabricator.
- Unverified account, reset password, verified implicit verification, used Phabricator.
- People Admin Interface
- Viewed as admin. Clicked "Administrate User".
- Viewed as non-admin
- Sanity Checks
- Used Conduit normally from web/CLI with a verified account.
- Logged in/out.
- Sent password reset email.
- Created a new user.
- Logged in with an unverified user but with the configuration set to off.
Reviewers: btrahan, vrana, jungejason
Reviewed By: btrahan
CC: aran, csilvers
Maniphest Tasks: T1184
Differential Revision: https://secure.phabricator.com/D2520
2012-05-21 12:47:38 -07:00
|
|
|
}
|
|
|
|
|
2011-03-30 19:21:09 -07:00
|
|
|
public function loadPreferences() {
|
|
|
|
if ($this->preferences) {
|
|
|
|
return $this->preferences;
|
|
|
|
}
|
|
|
|
|
2013-09-02 12:40:04 -07:00
|
|
|
$preferences = null;
|
|
|
|
if ($this->getPHID()) {
|
|
|
|
$preferences = id(new PhabricatorUserPreferences())->loadOneWhere(
|
|
|
|
'userPHID = %s',
|
|
|
|
$this->getPHID());
|
|
|
|
}
|
2011-03-30 19:21:09 -07:00
|
|
|
|
|
|
|
if (!$preferences) {
|
|
|
|
$preferences = new PhabricatorUserPreferences();
|
|
|
|
$preferences->setUserPHID($this->getPHID());
|
|
|
|
|
|
|
|
$default_dict = array(
|
|
|
|
PhabricatorUserPreferences::PREFERENCE_TITLES => 'glyph',
|
2012-01-16 11:08:54 -08:00
|
|
|
PhabricatorUserPreferences::PREFERENCE_EDITOR => '',
|
2013-01-19 17:40:48 -08:00
|
|
|
PhabricatorUserPreferences::PREFERENCE_MONOSPACED => '',
|
|
|
|
PhabricatorUserPreferences::PREFERENCE_DARK_CONSOLE => 0);
|
2011-03-30 19:21:09 -07:00
|
|
|
|
|
|
|
$preferences->setPreferences($default_dict);
|
|
|
|
}
|
|
|
|
|
|
|
|
$this->preferences = $preferences;
|
|
|
|
return $preferences;
|
|
|
|
}
|
|
|
|
|
2012-04-04 17:53:16 -07:00
|
|
|
public function loadEditorLink($path, $line, $callsign) {
|
2012-01-16 11:08:54 -08:00
|
|
|
$editor = $this->loadPreferences()->getPreference(
|
|
|
|
PhabricatorUserPreferences::PREFERENCE_EDITOR);
|
2012-12-03 15:51:18 -08:00
|
|
|
|
|
|
|
if (is_array($path)) {
|
|
|
|
$multiedit = $this->loadPreferences()->getPreference(
|
|
|
|
PhabricatorUserPreferences::PREFERENCE_MULTIEDIT);
|
|
|
|
switch ($multiedit) {
|
|
|
|
case '':
|
|
|
|
$path = implode(' ', $path);
|
|
|
|
break;
|
|
|
|
case 'disable':
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-03-17 13:00:37 -07:00
|
|
|
if (!strlen($editor)) {
|
|
|
|
return null;
|
2012-01-16 11:08:54 -08:00
|
|
|
}
|
2014-03-17 13:00:37 -07:00
|
|
|
|
|
|
|
$uri = strtr($editor, array(
|
|
|
|
'%%' => '%',
|
|
|
|
'%f' => phutil_escape_uri($path),
|
|
|
|
'%l' => phutil_escape_uri($line),
|
|
|
|
'%r' => phutil_escape_uri($callsign),
|
|
|
|
));
|
|
|
|
|
|
|
|
// The resulting URI must have an allowed protocol. Otherwise, we'll return
|
|
|
|
// a link to an error page explaining the misconfiguration.
|
|
|
|
|
|
|
|
$ok = PhabricatorHelpEditorProtocolController::hasAllowedProtocol($uri);
|
|
|
|
if (!$ok) {
|
|
|
|
return '/help/editorprotocol/';
|
|
|
|
}
|
|
|
|
|
|
|
|
return (string)$uri;
|
2012-01-16 11:08:54 -08:00
|
|
|
}
|
|
|
|
|
2014-01-23 14:03:54 -08:00
|
|
|
public function getAlternateCSRFString() {
|
|
|
|
return $this->assertAttached($this->alternateCSRFString);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function attachAlternateCSRFString($string) {
|
|
|
|
$this->alternateCSRFString = $string;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-10-23 13:25:52 -07:00
|
|
|
private static function tokenizeName($name) {
|
|
|
|
if (function_exists('mb_strtolower')) {
|
|
|
|
$name = mb_strtolower($name, 'UTF-8');
|
|
|
|
} else {
|
|
|
|
$name = strtolower($name);
|
|
|
|
}
|
|
|
|
$name = trim($name);
|
|
|
|
if (!strlen($name)) {
|
|
|
|
return array();
|
|
|
|
}
|
|
|
|
return preg_split('/\s+/', $name);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Populate the nametoken table, which used to fetch typeahead results. When
|
|
|
|
* a user types "linc", we want to match "Abraham Lincoln" from on-demand
|
|
|
|
* typeahead sources. To do this, we need a separate table of name fragments.
|
|
|
|
*/
|
|
|
|
public function updateNameTokens() {
|
|
|
|
$tokens = array_merge(
|
|
|
|
self::tokenizeName($this->getRealName()),
|
|
|
|
self::tokenizeName($this->getUserName()));
|
|
|
|
$tokens = array_unique($tokens);
|
|
|
|
$table = self::NAMETOKEN_TABLE;
|
|
|
|
$conn_w = $this->establishConnection('w');
|
|
|
|
|
|
|
|
$sql = array();
|
|
|
|
foreach ($tokens as $token) {
|
|
|
|
$sql[] = qsprintf(
|
|
|
|
$conn_w,
|
|
|
|
'(%d, %s)',
|
|
|
|
$this->getID(),
|
|
|
|
$token);
|
|
|
|
}
|
|
|
|
|
|
|
|
queryfx(
|
|
|
|
$conn_w,
|
|
|
|
'DELETE FROM %T WHERE userID = %d',
|
|
|
|
$table,
|
|
|
|
$this->getID());
|
|
|
|
if ($sql) {
|
|
|
|
queryfx(
|
|
|
|
$conn_w,
|
|
|
|
'INSERT INTO %T (userID, token) VALUES %Q',
|
|
|
|
$table,
|
|
|
|
implode(', ', $sql));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-01-06 10:44:12 -08:00
|
|
|
public function sendWelcomeEmail(PhabricatorUser $admin) {
|
|
|
|
$admin_username = $admin->getUserName();
|
|
|
|
$admin_realname = $admin->getRealName();
|
|
|
|
$user_username = $this->getUserName();
|
|
|
|
$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
|
|
|
|
|
|
|
|
$base_uri = PhabricatorEnv::getProductionURI('/');
|
|
|
|
|
|
|
|
$uri = $this->getEmailLoginURI();
|
|
|
|
$body = <<<EOBODY
|
|
|
|
Welcome to Phabricator!
|
|
|
|
|
|
|
|
{$admin_username} ({$admin_realname}) has created an account for you.
|
|
|
|
|
|
|
|
Username: {$user_username}
|
|
|
|
|
|
|
|
To login to Phabricator, follow this link and set a password:
|
|
|
|
|
|
|
|
{$uri}
|
|
|
|
|
|
|
|
After you have set a password, you can login in the future by going here:
|
|
|
|
|
|
|
|
{$base_uri}
|
|
|
|
|
|
|
|
EOBODY;
|
|
|
|
|
|
|
|
if (!$is_serious) {
|
|
|
|
$body .= <<<EOBODY
|
|
|
|
|
|
|
|
Love,
|
|
|
|
Phabricator
|
|
|
|
|
|
|
|
EOBODY;
|
|
|
|
}
|
|
|
|
|
|
|
|
$mail = id(new PhabricatorMetaMTAMail())
|
|
|
|
->addTos(array($this->getPHID()))
|
|
|
|
->setSubject('[Phabricator] Welcome to Phabricator')
|
|
|
|
->setBody($body)
|
|
|
|
->saveAndSend();
|
|
|
|
}
|
|
|
|
|
2012-06-06 07:09:56 -07:00
|
|
|
public function sendUsernameChangeEmail(
|
|
|
|
PhabricatorUser $admin,
|
|
|
|
$old_username) {
|
|
|
|
|
|
|
|
$admin_username = $admin->getUserName();
|
|
|
|
$admin_realname = $admin->getRealName();
|
|
|
|
$new_username = $this->getUserName();
|
|
|
|
|
|
|
|
$password_instructions = null;
|
2013-06-20 11:18:48 -07:00
|
|
|
if (PhabricatorAuthProviderPassword::getPasswordProvider()) {
|
2012-06-06 07:09:56 -07:00
|
|
|
$uri = $this->getEmailLoginURI();
|
|
|
|
$password_instructions = <<<EOTXT
|
|
|
|
If you use a password to login, you'll need to reset it before you can login
|
|
|
|
again. You can reset your password by following this link:
|
|
|
|
|
|
|
|
{$uri}
|
|
|
|
|
|
|
|
And, of course, you'll need to use your new username to login from now on. If
|
|
|
|
you use OAuth to login, nothing should change.
|
|
|
|
|
|
|
|
EOTXT;
|
|
|
|
}
|
|
|
|
|
|
|
|
$body = <<<EOBODY
|
|
|
|
{$admin_username} ({$admin_realname}) has changed your Phabricator username.
|
|
|
|
|
|
|
|
Old Username: {$old_username}
|
|
|
|
New Username: {$new_username}
|
|
|
|
|
|
|
|
{$password_instructions}
|
|
|
|
EOBODY;
|
|
|
|
|
|
|
|
$mail = id(new PhabricatorMetaMTAMail())
|
|
|
|
->addTos(array($this->getPHID()))
|
|
|
|
->setSubject('[Phabricator] Username Changed')
|
|
|
|
->setBody($body)
|
|
|
|
->saveAndSend();
|
|
|
|
}
|
|
|
|
|
2012-06-06 07:09:05 -07:00
|
|
|
public static function describeValidUsername() {
|
2013-08-13 14:37:23 -07:00
|
|
|
return pht(
|
|
|
|
'Usernames must contain only numbers, letters, period, underscore and '.
|
|
|
|
'hyphen, and can not end with a period. They must have no more than %d '.
|
|
|
|
'characters.',
|
|
|
|
new PhutilNumber(self::MAXIMUM_USERNAME_LENGTH));
|
2012-06-06 07:09:05 -07:00
|
|
|
}
|
|
|
|
|
2012-01-16 07:30:28 -08:00
|
|
|
public static function validateUsername($username) {
|
2012-06-13 08:39:02 -07:00
|
|
|
// NOTE: If you update this, make sure to update:
|
|
|
|
//
|
|
|
|
// - Remarkup rule for @mentions.
|
|
|
|
// - Routing rule for "/p/username/".
|
|
|
|
// - Unit tests, obviously.
|
|
|
|
// - describeValidUsername() method, above.
|
|
|
|
|
2013-08-13 14:37:23 -07:00
|
|
|
if (strlen($username) > self::MAXIMUM_USERNAME_LENGTH) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2014-03-13 12:42:41 -07:00
|
|
|
return (bool)preg_match('/^[a-zA-Z0-9._-]*[a-zA-Z0-9_-]\z/', $username);
|
2012-01-16 07:30:28 -08:00
|
|
|
}
|
|
|
|
|
2012-04-27 17:44:10 -07:00
|
|
|
public static function getDefaultProfileImageURI() {
|
|
|
|
return celerity_get_resource_uri('/rsrc/image/avatar.png');
|
|
|
|
}
|
|
|
|
|
2014-02-06 10:07:29 -08:00
|
|
|
public function attachStatus(PhabricatorCalendarEvent $status) {
|
2013-07-26 14:05:19 -07:00
|
|
|
$this->status = $status;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getStatus() {
|
2014-02-06 10:07:29 -08:00
|
|
|
return $this->assertAttached($this->status);
|
2013-07-26 14:05:19 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
public function hasStatus() {
|
|
|
|
return $this->status !== self::ATTACHABLE;
|
|
|
|
}
|
|
|
|
|
2013-03-24 06:42:31 -07:00
|
|
|
public function attachProfileImageURI($uri) {
|
|
|
|
$this->profileImage = $uri;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2014-03-19 19:28:04 -07:00
|
|
|
public function getProfileImageURI() {
|
|
|
|
return $this->assertAttached($this->profileImage);
|
|
|
|
}
|
|
|
|
|
2012-04-27 17:44:10 -07:00
|
|
|
public function loadProfileImageURI() {
|
2014-03-19 19:28:04 -07:00
|
|
|
if ($this->profileImage && $this->profileImage !== self::ATTACHABLE) {
|
2013-03-24 06:42:31 -07:00
|
|
|
return $this->profileImage;
|
|
|
|
}
|
|
|
|
|
2012-04-27 17:44:10 -07:00
|
|
|
$src_phid = $this->getProfileImagePHID();
|
|
|
|
|
2013-01-02 14:03:36 -08:00
|
|
|
if ($src_phid) {
|
2013-09-30 09:38:13 -07:00
|
|
|
// TODO: (T603) Can we get rid of this entirely and move it to
|
|
|
|
// PeopleQuery with attach/attachable?
|
2013-01-02 14:03:36 -08:00
|
|
|
$file = id(new PhabricatorFile())->loadOneWhere('phid = %s', $src_phid);
|
|
|
|
if ($file) {
|
2013-03-24 06:42:31 -07:00
|
|
|
$this->profileImage = $file->getBestURI();
|
2013-01-02 14:03:36 -08:00
|
|
|
}
|
2012-04-27 17:44:10 -07:00
|
|
|
}
|
|
|
|
|
2013-03-24 06:42:31 -07:00
|
|
|
if (!$this->profileImage) {
|
|
|
|
$this->profileImage = self::getDefaultProfileImageURI();
|
|
|
|
}
|
|
|
|
|
|
|
|
return $this->profileImage;
|
2012-04-27 17:44:10 -07:00
|
|
|
}
|
|
|
|
|
2012-05-17 21:46:45 -07:00
|
|
|
public function getFullName() {
|
|
|
|
return $this->getUsername().' ('.$this->getRealName().')';
|
|
|
|
}
|
|
|
|
|
2012-06-14 18:08:06 -07:00
|
|
|
public function __toString() {
|
|
|
|
return $this->getUsername();
|
|
|
|
}
|
|
|
|
|
2012-05-07 10:29:33 -07:00
|
|
|
public static function loadOneWithEmailAddress($address) {
|
|
|
|
$email = id(new PhabricatorUserEmail())->loadOneWhere(
|
|
|
|
'address = %s',
|
|
|
|
$address);
|
|
|
|
if (!$email) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
return id(new PhabricatorUser())->loadOneWhere(
|
|
|
|
'phid = %s',
|
|
|
|
$email->getUserPHID());
|
|
|
|
}
|
|
|
|
|
2013-02-28 11:01:40 -08:00
|
|
|
|
|
|
|
/* -( Omnipotence )-------------------------------------------------------- */
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Returns true if this user is omnipotent. Omnipotent users bypass all policy
|
|
|
|
* checks.
|
|
|
|
*
|
|
|
|
* @return bool True if the user bypasses policy checks.
|
|
|
|
*/
|
|
|
|
public function isOmnipotent() {
|
|
|
|
return $this->omnipotent;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Get an omnipotent user object for use in contexts where there is no acting
|
|
|
|
* user, notably daemons.
|
|
|
|
*
|
|
|
|
* @return PhabricatorUser An omnipotent user.
|
|
|
|
*/
|
|
|
|
public static function getOmnipotentUser() {
|
|
|
|
static $user = null;
|
|
|
|
if (!$user) {
|
|
|
|
$user = new PhabricatorUser();
|
|
|
|
$user->omnipotent = true;
|
|
|
|
$user->makeEphemeral();
|
|
|
|
}
|
|
|
|
return $user;
|
|
|
|
}
|
|
|
|
|
2013-05-31 10:51:20 -07:00
|
|
|
|
|
|
|
/* -( PhabricatorPolicyInterface )----------------------------------------- */
|
|
|
|
|
|
|
|
|
|
|
|
public function getCapabilities() {
|
|
|
|
return array(
|
|
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getPolicy($capability) {
|
|
|
|
switch ($capability) {
|
|
|
|
case PhabricatorPolicyCapability::CAN_VIEW:
|
|
|
|
return PhabricatorPolicies::POLICY_PUBLIC;
|
|
|
|
case PhabricatorPolicyCapability::CAN_EDIT:
|
|
|
|
return PhabricatorPolicies::POLICY_NOONE;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
public function hasAutomaticCapability($capability, PhabricatorUser $viewer) {
|
|
|
|
return $this->getPHID() && ($viewer->getPHID() === $this->getPHID());
|
|
|
|
}
|
|
|
|
|
2013-09-27 08:43:41 -07:00
|
|
|
public function describeAutomaticCapability($capability) {
|
|
|
|
switch ($capability) {
|
|
|
|
case PhabricatorPolicyCapability::CAN_EDIT:
|
|
|
|
return pht('Only you can edit your information.');
|
|
|
|
default:
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-05-31 10:51:20 -07:00
|
|
|
|
2013-06-07 09:55:55 -07:00
|
|
|
/* -( PhabricatorCustomFieldInterface )------------------------------------ */
|
|
|
|
|
|
|
|
|
|
|
|
public function getCustomFieldSpecificationForRole($role) {
|
2013-06-07 10:22:45 -07:00
|
|
|
return PhabricatorEnv::getEnvConfig('user.fields');
|
2013-06-07 09:55:55 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
public function getCustomFieldBaseClass() {
|
Support configuration-driven custom fields
Summary:
Ref T1702. Ref T3718. There are a couple of things going on here:
**PhabricatorCustomFieldList**: I added `PhabricatorCustomFieldList`, which is just a convenience class for dealing with lists of fields. Often, current field code does something like this inline in a Controller:
foreach ($fields as $field) {
// do some junk
}
Often, that junk has some slightly subtle implications. Move all of it to `$list->doSomeJunk()` methods (like `appendFieldsToForm()`, `loadFieldsFromStorage()`) to reduce code duplication and prevent errors. This additionally moves an existing list-convenience method there, out of `PhabricatorPropertyListView`.
**PhabricatorUserConfiguredCustomFieldStorage**: Adds `PhabricatorUserConfiguredCustomFieldStorage` for storing custom field data (like "ICQ Handle", "Phone Number", "Desk", "Favorite Flower", etc).
**Configuration-Driven Custom Fields**: Previously, I was thinking about doing these with interfaces, but as I thought about it more I started to dislike that approach. Instead, I built proxies into `PhabricatorCustomField`. Basically, this means that fields (like a custom, configuration-driven "Favorite Flower" field) can just use some other Field to actually provide their implementation (like a "standard" field which knows how to render text areas). The previous approach would have involed subclasssing the "standard" field and implementing an interface, but that would mean that every application would have at least two "base" fields and generally just seemed bleh as I worked through it.
The cost of this approach is that we need a bunch of `proxy` junk in the base class, but that's a one-time cost and I think it simplifies all the implementations and makes them a lot less magical (e.g., all of the custom fields now extend the right base field classes).
**Fixed Some Bugs**: Some of this code hadn't really been run yet and had minor bugs.
Test Plan:
{F54240}
{F54241}
{F54242}
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T1702, T1703, T3718
Differential Revision: https://secure.phabricator.com/D6749
2013-08-14 08:10:16 -07:00
|
|
|
return 'PhabricatorUserCustomField';
|
2013-06-07 09:55:55 -07:00
|
|
|
}
|
|
|
|
|
2013-08-14 09:53:59 -07:00
|
|
|
public function getCustomFields() {
|
|
|
|
return $this->assertAttached($this->customFields);
|
2013-06-07 09:55:55 -07:00
|
|
|
}
|
|
|
|
|
2013-08-14 09:53:59 -07:00
|
|
|
public function attachCustomFields(PhabricatorCustomFieldAttachment $fields) {
|
|
|
|
$this->customFields = $fields;
|
2013-06-07 09:55:55 -07:00
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-01-23 18:09:16 -08:00
|
|
|
}
|