revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 02:42:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/__celerity_resource_map__.php

4277 lines
127 KiB
PHP
Raw Normal View History

Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
<?php
/**
* This file is automatically generated. Use 'celerity_mapper.php' to rebuild
* it.
* @generated
*/
celerity_register_resource_map(array(
Conpherence CSS tweaks. Summary: Just a rough pass at the CSS on Conpherence. Need a second pass for the widgets. Test Plan: Reload Conpherence, Chrome, FF Reviewers: btrahan, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4661
2013-01-26 00:48:04 +01:00
'/rsrc/image/actions/edit.png' =>
array(
'hash' => 'ae90914d120ac3838ddc633b480343f3',
'uri' => '/res/ae90914d/rsrc/image/actions/edit.png',
'disk' => '/rsrc/image/actions/edit.png',
'type' => 'png',
),
Add Apple Touch Icon. Summary: Adds an icon if you add Phabricator as a web app on your iPhone. Test Plan: Test on simulator and in iOS. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5444
2013-03-25 19:24:17 +01:00
'/rsrc/image/apple-touch-icon.png' =>
array(
'hash' => '3380adf2dd4a5efa0885618bc5943640',
'uri' => '/res/3380adf2/rsrc/image/apple-touch-icon.png',
'disk' => '/rsrc/image/apple-touch-icon.png',
'type' => 'png',
),
Highlight copied/moved lines in Differential Summary: The color used for this feature is pretty important and I am bad with colors. Test Plan: View diff created by D2320 with some copied lines and one line changed: {F10604, size=full} Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2321
2012-04-26 09:18:42 +02:00
'/rsrc/image/avatar.png' =>
array(
'hash' => '1c5f255071537f05406adee86717ff27',
'uri' => '/res/1c5f2550/rsrc/image/avatar.png',
'disk' => '/rsrc/image/avatar.png',
'type' => 'png',
),
Change background for image views in Differential Summary: Many images in Differential changesets are icons designed for use on dark backgrounds. This makes them invisible on Differential's white background. This adds an option to use a darker background instead so you can see the images. Currently this behavior is triggered on hover. (Also, it's a rather garish fuchsia.) It seems fine UX-wise but I'm not totally sure of it. Test Plan: Load diff containing grippy_texture. Marvel at the grippy fuchsia. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3272
2012-08-14 02:21:16 +02:00
'/rsrc/image/checker_dark.png' =>
array(
'hash' => '640f795343df76ebe5409aae6187e57f',
'uri' => '/res/640f7953/rsrc/image/checker_dark.png',
'disk' => '/rsrc/image/checker_dark.png',
'type' => 'png',
),
'/rsrc/image/checker_light.png' =>
array(
'hash' => '7f8f3ef8beb0f2cc4cc69efb9e1c3308',
'uri' => '/res/7f8f3ef8/rsrc/image/checker_light.png',
'disk' => '/rsrc/image/checker_light.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/credit_cards.png' =>
array(
'hash' => '681448de424ea159b6ea68af04c046ae',
'uri' => '/res/681448de/rsrc/image/credit_cards.png',
'disk' => '/rsrc/image/credit_cards.png',
'type' => 'png',
),
DarkConsole: fix rendering, move request log, load over ajax Summary: This accomplishes three major goals: # Fixes phutil_render_tag -> phutil_tag callsites in DarkConsole. # Moves the Ajax request log to a new panel on the left. This panel (and the tabs panel) get scrollbars when they get large, instead of making the page constantly scroll down. # Loads the panel content over ajax, instead of dumping it into the page body / ajax response body. I've been planning to do this for about 3 years, which is why the plugins are architected the way they are. This should make debugging easier by making response bodies not be 50%+ darkconsole stuff. Additionally, load the plugins dynamically (the old method predates library maps and PhutilSymbolLoader). Test Plan: {F30675} - Switched between requests and tabs, reloaded page, saw same tab. - Used "analyze queries", "profile page", triggered errors. - Verified page does not load anything by default if dark console is closed with Charles. - Generally banged on it a bit. Reviewers: vrana, btrahan, chad Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4692
2013-01-29 03:45:32 +01:00
'/rsrc/image/darkload.gif' =>
array(
'hash' => '3a52cb7145d6e70f461fed21273117f2',
'uri' => '/res/3a52cb71/rsrc/image/darkload.gif',
'disk' => '/rsrc/image/darkload.gif',
'type' => 'gif',
),
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
'/rsrc/image/divot.png' =>
array(
'hash' => '3be267bd11ea375bf68e808893718e0e',
'uri' => '/res/3be267bd/rsrc/image/divot.png',
'disk' => '/rsrc/image/divot.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/grippy_texture.png' =>
array(
'hash' => 'a8945e12ceeaddd5b491a8d81cfa19c1',
'uri' => '/res/a8945e12/rsrc/image/grippy_texture.png',
'disk' => '/rsrc/image/grippy_texture.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/arrow_branch.png' =>
array(
'hash' => 'f27b67520766e3d971722bcff703f3a8',
'uri' => '/res/f27b6752/rsrc/image/icon/fatcow/arrow_branch.png',
'disk' => '/rsrc/image/icon/fatcow/arrow_branch.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/arrow_merge.png' =>
array(
'hash' => 'c4bd97f3b1257439e2123ef69d2194d0',
'uri' => '/res/c4bd97f3/rsrc/image/icon/fatcow/arrow_merge.png',
'disk' => '/rsrc/image/icon/fatcow/arrow_merge.png',
'type' => 'png',
),
dark console - introduce "request log" section Summary: this section gets updated for each and every request. clicking a given entry updates the larger dark-console area to have the information from that request Test Plan: clicked around in maniphest and observed request log populating correctly. clicked a few entries in request log and saw it updated properly. clicked a different tab in the dark-console and it worked. clicked a different request log entry and it opened the dark console to the proper request on the proper tab. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1136 Differential Revision: https://secure.phabricator.com/D2574
2012-05-25 19:14:17 +02:00
'/rsrc/image/icon/fatcow/bullet_black.png' =>
array(
'hash' => '718f9c560a13766796f1be7dfaadeeab',
'uri' => '/res/718f9c56/rsrc/image/icon/fatcow/bullet_black.png',
'disk' => '/rsrc/image/icon/fatcow/bullet_black.png',
'type' => 'png',
),
Highlight away status by bullet and display it everywhere Summary: D2484#13 Test Plan: Display revision list. Display revision detail. Reviewers: epriestley Reviewed By: epriestley CC: btrahan, aran, Koolvin Differential Revision: https://secure.phabricator.com/D2501
2012-05-19 18:18:34 +02:00
'/rsrc/image/icon/fatcow/bullet_orange.png' =>
array(
'hash' => 'c3bf91b65baacb27f2af143ab9180119',
'uri' => '/res/c3bf91b6/rsrc/image/icon/fatcow/bullet_orange.png',
'disk' => '/rsrc/image/icon/fatcow/bullet_orange.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/bullet_red.png' =>
array(
'hash' => '00273e4aa6ea3de630295610d6c9560c',
'uri' => '/res/00273e4a/rsrc/image/icon/fatcow/bullet_red.png',
'disk' => '/rsrc/image/icon/fatcow/bullet_red.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/icon/fatcow/calendar_edit.png' =>
array(
'hash' => 'de249c0f4f37bf5b2c69ff39ec5573fb',
'uri' => '/res/de249c0f/rsrc/image/icon/fatcow/calendar_edit.png',
'disk' => '/rsrc/image/icon/fatcow/calendar_edit.png',
'type' => 'png',
),
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
'/rsrc/image/icon/fatcow/document_black.png' =>
array(
'hash' => '44d65a7f05a9c921719deedc160d68f7',
'uri' => '/res/44d65a7f/rsrc/image/icon/fatcow/document_black.png',
'disk' => '/rsrc/image/icon/fatcow/document_black.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/icon/fatcow/flag_blue.png' =>
array(
'hash' => '75a080492f900fbe489e4b27e403962b',
'uri' => '/res/75a08049/rsrc/image/icon/fatcow/flag_blue.png',
'disk' => '/rsrc/image/icon/fatcow/flag_blue.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_finish.png' =>
array(
'hash' => '4af11fc7fab8e4610cbc3c88a02d4f78',
'uri' => '/res/4af11fc7/rsrc/image/icon/fatcow/flag_finish.png',
'disk' => '/rsrc/image/icon/fatcow/flag_finish.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_ghost.png' =>
array(
'hash' => '14c9f30a37b43f276f27a27a924bf02d',
'uri' => '/res/14c9f30a/rsrc/image/icon/fatcow/flag_ghost.png',
'disk' => '/rsrc/image/icon/fatcow/flag_ghost.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_green.png' =>
array(
'hash' => 'fed01374cd396cb774872762dcc447e1',
'uri' => '/res/fed01374/rsrc/image/icon/fatcow/flag_green.png',
'disk' => '/rsrc/image/icon/fatcow/flag_green.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_orange.png' =>
array(
'hash' => '88008cb8bb99761a37e5a743e2455aeb',
'uri' => '/res/88008cb8/rsrc/image/icon/fatcow/flag_orange.png',
'disk' => '/rsrc/image/icon/fatcow/flag_orange.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_pink.png' =>
array(
'hash' => '2f199f06ffc3dfc81b7561a057e0bc33',
'uri' => '/res/2f199f06/rsrc/image/icon/fatcow/flag_pink.png',
'disk' => '/rsrc/image/icon/fatcow/flag_pink.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_purple.png' =>
array(
'hash' => '16358629dc86c39550b575586eb5df80',
'uri' => '/res/16358629/rsrc/image/icon/fatcow/flag_purple.png',
'disk' => '/rsrc/image/icon/fatcow/flag_purple.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_red.png' =>
array(
'hash' => '210c28b4d93c439a499f5814f5e05772',
'uri' => '/res/210c28b4/rsrc/image/icon/fatcow/flag_red.png',
'disk' => '/rsrc/image/icon/fatcow/flag_red.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_yellow.png' =>
array(
'hash' => 'bdfd73744a80bb80329ae50bc8a5f962',
'uri' => '/res/bdfd7374/rsrc/image/icon/fatcow/flag_yellow.png',
'disk' => '/rsrc/image/icon/fatcow/flag_yellow.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/folder.png' =>
array(
'hash' => '25e46cf9d210dde2242332296f79938c',
'uri' => '/res/25e46cf9/rsrc/image/icon/fatcow/folder.png',
'disk' => '/rsrc/image/icon/fatcow/folder.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/folder_go.png' =>
array(
'hash' => 'ba922ff7959309f51a14cb7ed5124d8b',
'uri' => '/res/ba922ff7/rsrc/image/icon/fatcow/folder_go.png',
'disk' => '/rsrc/image/icon/fatcow/folder_go.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/key_question.png' =>
array(
'hash' => '530a6448a4b91edec091a9292ccfd3d9',
'uri' => '/res/530a6448/rsrc/image/icon/fatcow/key_question.png',
'disk' => '/rsrc/image/icon/fatcow/key_question.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/link.png' =>
array(
'hash' => 'be1bea49b216548433014f3324902928',
'uri' => '/res/be1bea49/rsrc/image/icon/fatcow/link.png',
'disk' => '/rsrc/image/icon/fatcow/link.png',
'type' => 'png',
),
Display flag in Flag dialog Summary: I had no idea what checkered is. Test Plan: Flagged revision, flagged task. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3346
2012-08-21 06:47:44 +02:00
'/rsrc/image/icon/fatcow/page_white_edit.png' =>
array(
'hash' => 'e7b7e7f2d9730bc80bc5c9eac1f3e36d',
'uri' => '/res/e7b7e7f2/rsrc/image/icon/fatcow/page_white_edit.png',
'disk' => '/rsrc/image/icon/fatcow/page_white_edit.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/icon/fatcow/page_white_link.png' =>
array(
'hash' => '1cfbad14412bda6c6f132dcc7c8725fd',
'uri' => '/res/1cfbad14/rsrc/image/icon/fatcow/page_white_link.png',
'disk' => '/rsrc/image/icon/fatcow/page_white_link.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/page_white_put.png' =>
array(
'hash' => 'bb7308aa5ac40137a8262da395a267fd',
'uri' => '/res/bb7308aa/rsrc/image/icon/fatcow/page_white_put.png',
'disk' => '/rsrc/image/icon/fatcow/page_white_put.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/page_white_text.png' =>
array(
'hash' => 'e47d590b626f617fb7d1d44e96e8fd11',
'uri' => '/res/e47d590b/rsrc/image/icon/fatcow/page_white_text.png',
'disk' => '/rsrc/image/icon/fatcow/page_white_text.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/conduit.png' =>
array(
'hash' => '1cae0656580aa3cd0b54b9d98306b1b9',
'uri' => '/res/1cae0656/rsrc/image/icon/fatcow/source/conduit.png',
'disk' => '/rsrc/image/icon/fatcow/source/conduit.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/email.png' =>
array(
'hash' => '93bdb3e168da1ed68f50c42125729d4e',
'uri' => '/res/93bdb3e1/rsrc/image/icon/fatcow/source/email.png',
'disk' => '/rsrc/image/icon/fatcow/source/email.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/fax.png' =>
array(
'hash' => 'd7dedf229841f2d041b347afd881596f',
'uri' => '/res/d7dedf22/rsrc/image/icon/fatcow/source/fax.png',
'disk' => '/rsrc/image/icon/fatcow/source/fax.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/mobile.png' =>
array(
'hash' => '786e7146d1e7d7318baf76c9d2baad97',
'uri' => '/res/786e7146/rsrc/image/icon/fatcow/source/mobile.png',
'disk' => '/rsrc/image/icon/fatcow/source/mobile.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/tablet.png' =>
array(
'hash' => '374cd40e4965be6b2fbdef4059d0ca05',
'uri' => '/res/374cd40e/rsrc/image/icon/fatcow/source/tablet.png',
'disk' => '/rsrc/image/icon/fatcow/source/tablet.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/web.png' =>
array(
'hash' => 'f4882a8f5619ba505ca033f72a340635',
'uri' => '/res/f4882a8f/rsrc/image/icon/fatcow/source/web.png',
'disk' => '/rsrc/image/icon/fatcow/source/web.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/default160x120.png' =>
array(
'hash' => '1b52ebd1fe0eee3ed0abfc382991b265',
'uri' => '/res/1b52ebd1/rsrc/image/icon/fatcow/thumbnails/default160x120.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/default160x120.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/default60x45.png' =>
array(
'hash' => '048d851d8d1daad4754e891e734c1899',
'uri' => '/res/048d851d/rsrc/image/icon/fatcow/thumbnails/default60x45.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/default60x45.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/image160x120.png' =>
array(
'hash' => '434acbd8dbbc2da9f09f6205a396eba1',
'uri' => '/res/434acbd8/rsrc/image/icon/fatcow/thumbnails/image160x120.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/image160x120.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/image60x45.png' =>
array(
'hash' => '29f7872dc53588fe0b8f0b330c7ee23a',
'uri' => '/res/29f7872d/rsrc/image/icon/fatcow/thumbnails/image60x45.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/image60x45.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/pdf160x120.png' =>
array(
'hash' => '39d2e22541658a3472ba41ae2fa548e5',
'uri' => '/res/39d2e225/rsrc/image/icon/fatcow/thumbnails/pdf160x120.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/pdf160x120.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/pdf60x45.png' =>
array(
'hash' => 'b3572e9317cbed5184d12bdfabed2727',
'uri' => '/res/b3572e93/rsrc/image/icon/fatcow/thumbnails/pdf60x45.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/pdf60x45.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/zip160x120.png' =>
array(
'hash' => 'e505108688a903b5cfb674707a289bcc',
'uri' => '/res/e5051086/rsrc/image/icon/fatcow/thumbnails/zip160x120.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/zip160x120.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/zip60x45.png' =>
array(
'hash' => 'f00716f4e8f7a95e70d43504f06be0a6',
'uri' => '/res/f00716f4/rsrc/image/icon/fatcow/thumbnails/zip60x45.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/zip60x45.png',
'type' => 'png',
),
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
'/rsrc/image/icon/lightbox/close-2.png' =>
array(
'hash' => '72ff3ddcc1ed5d19a715ed6242114b53',
'uri' => '/res/72ff3ddc/rsrc/image/icon/lightbox/close-2.png',
'disk' => '/rsrc/image/icon/lightbox/close-2.png',
'type' => 'png',
),
'/rsrc/image/icon/lightbox/close-hover-2.png' =>
array(
'hash' => '6ad4bd4a7820547a1d9041752546ba16',
'uri' => '/res/6ad4bd4a/rsrc/image/icon/lightbox/close-hover-2.png',
'disk' => '/rsrc/image/icon/lightbox/close-hover-2.png',
'type' => 'png',
),
'/rsrc/image/icon/lightbox/left-arrow-2.png' =>
array(
'hash' => 'd84cbb0d42739f87b8f25b2f1d2f1153',
'uri' => '/res/d84cbb0d/rsrc/image/icon/lightbox/left-arrow-2.png',
'disk' => '/rsrc/image/icon/lightbox/left-arrow-2.png',
'type' => 'png',
),
'/rsrc/image/icon/lightbox/left-arrow-hover-2.png' =>
array(
'hash' => 'cdf05f98fff3f390cd8df0c89894a3e1',
'uri' => '/res/cdf05f98/rsrc/image/icon/lightbox/left-arrow-hover-2.png',
'disk' => '/rsrc/image/icon/lightbox/left-arrow-hover-2.png',
'type' => 'png',
),
'/rsrc/image/icon/lightbox/right-arrow-2.png' =>
array(
'hash' => '52021038cb6995c71f62a804bc2d420d',
'uri' => '/res/52021038/rsrc/image/icon/lightbox/right-arrow-2.png',
'disk' => '/rsrc/image/icon/lightbox/right-arrow-2.png',
'type' => 'png',
),
'/rsrc/image/icon/lightbox/right-arrow-hover-2.png' =>
array(
'hash' => '65d5756b7b9cfcdeb2eb197a9aa6bbd2',
'uri' => '/res/65d5756b/rsrc/image/icon/lightbox/right-arrow-hover-2.png',
'disk' => '/rsrc/image/icon/lightbox/right-arrow-hover-2.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/icon/subscribe.png' =>
array(
'hash' => '5f47a4b17de245af39a4e7a097e40623',
'uri' => '/res/5f47a4b1/rsrc/image/icon/subscribe.png',
'disk' => '/rsrc/image/icon/subscribe.png',
'type' => 'png',
),
'/rsrc/image/icon/tango/attachment.png' =>
array(
'hash' => '776fed2de89803fd8a0ba4b9deede230',
'uri' => '/res/776fed2d/rsrc/image/icon/tango/attachment.png',
'disk' => '/rsrc/image/icon/tango/attachment.png',
'type' => 'png',
),
'/rsrc/image/icon/tango/edit.png' =>
array(
'hash' => 'c0028d99dcf4e9559bbf3c88ce2d8a8d',
'uri' => '/res/c0028d99/rsrc/image/icon/tango/edit.png',
'disk' => '/rsrc/image/icon/tango/edit.png',
'type' => 'png',
),
Open files in very large diffs inline Summary: This allows writing inline comments and reduces different behavior between normal and very large diffs. Test Plan: Verify that normal diff works. Verify that very large diff works. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2361
2012-05-01 21:09:50 +02:00
'/rsrc/image/icon/tango/go-down.png' =>
array(
'hash' => '96862812cbb0445573c264dc057b8300',
'uri' => '/res/96862812/rsrc/image/icon/tango/go-down.png',
'disk' => '/rsrc/image/icon/tango/go-down.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/icon/tango/log.png' =>
array(
'hash' => 'a6f72499bef279ff6807a7dbc5148f1e',
'uri' => '/res/a6f72499/rsrc/image/icon/tango/log.png',
'disk' => '/rsrc/image/icon/tango/log.png',
'type' => 'png',
),
'/rsrc/image/icon/tango/upload.png' =>
array(
'hash' => '8c11b63d6d99db3d7159c5d9a94e3062',
'uri' => '/res/8c11b63d/rsrc/image/icon/tango/upload.png',
'disk' => '/rsrc/image/icon/tango/upload.png',
'type' => 'png',
),
'/rsrc/image/icon/unsubscribe.png' =>
array(
'hash' => '29429ad65aa3af50b072b32087057361',
'uri' => '/res/29429ad6/rsrc/image/icon/unsubscribe.png',
'disk' => '/rsrc/image/icon/unsubscribe.png',
'type' => 'png',
),
Simplify lightboxing and fix a few things Summary: Minor tweaks to lightboxes. - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it. - Make the lightbox go over the menu bar -- was it intentional that it wasn't? - Make 'jx-mask' use "position: fixed;" too. - Add a loading indicator. - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area. I'm going to do a couple of other tweaks here but need to update JX.Mask. Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3795
2012-10-24 02:34:43 +02:00
'/rsrc/image/loading.gif' =>
array(
'hash' => '664297671941142f37d8c89e717ff2ce',
'uri' => '/res/66429767/rsrc/image/loading.gif',
'disk' => '/rsrc/image/loading.gif',
'type' => 'gif',
),
Minor, updates from @chad: - Use a gradient on the main menu. - Slightly darken the application menu. - Use kerned logo text. - Use cleaner logo image. - Adjust search input colors to fit the darker scheme better.
2012-08-21 01:02:36 +02:00
'/rsrc/image/main_texture.png' =>
array(
'hash' => 'e34d8143384721be73ec9b7532a977ab',
'uri' => '/res/e34d8143/rsrc/image/main_texture.png',
'disk' => '/rsrc/image/main_texture.png',
'type' => 'png',
),
Fix various app nav issues Summary: - Fix width, corresponding to wider sprites. - Sprite the "Audit" icon. - Mark the meta-application as device-ready. - Fix some collapse/expand bugs with the draggable local navs. - Add texture to local nav. - Darken the application nav to make it more cohesive with the main nav. I think this is an improvement? Test Plan: See screenshots. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran, netfoxcity Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3338
2012-08-20 23:13:15 +02:00
'/rsrc/image/menu_texture.png' =>
array(
Dark sidebar everywhere Summary: First pass at testing out a dark sidebar everywhere. Wanting feedback with real test time before implementing before commiting. Thoughts - Aligns with Mobile, Tablet UI experience. - Creates 'application' feel on Desktop. - Begins to make Phabricator feel like a branded UI. Cons - Probably contensious visually. TODO: - Update diff view sidebar. - Make breadcrumbs appear above content area, not above nav. - Change background texture on crumbs to match table headers. Test Plan: Testing Nav with fellow co-workers. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4427
2013-01-14 22:40:51 +01:00
'hash' => 'ad020b1529b3a3b3480ca9de1d5f1e40',
'uri' => '/res/ad020b15/rsrc/image/menu_texture.png',
Fix various app nav issues Summary: - Fix width, corresponding to wider sprites. - Sprite the "Audit" icon. - Mark the meta-application as device-ready. - Fix some collapse/expand bugs with the draggable local navs. - Add texture to local nav. - Darken the application nav to make it more cohesive with the main nav. I think this is an improvement? Test Plan: See screenshots. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran, netfoxcity Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3338
2012-08-20 23:13:15 +02:00
'disk' => '/rsrc/image/menu_texture.png',
'type' => 'png',
),
Minor, fix celerity map.
2013-04-01 05:07:47 +02:00
'/rsrc/image/people/harding.png' =>
array(
'hash' => '818b035ace2c480aa8df7b7f11cef58b',
'uri' => '/res/818b035a/rsrc/image/people/harding.png',
'disk' => '/rsrc/image/people/harding.png',
'type' => 'png',
),
'/rsrc/image/people/jefferson.png' =>
array(
'hash' => '55fe807ff02f9320e595fb59442e2038',
'uri' => '/res/55fe807f/rsrc/image/people/jefferson.png',
'disk' => '/rsrc/image/people/jefferson.png',
'type' => 'png',
),
'/rsrc/image/people/lincoln.png' =>
array(
'hash' => '2363337947ab52fd5fda79e4a004e930',
'uri' => '/res/23633379/rsrc/image/people/lincoln.png',
'disk' => '/rsrc/image/people/lincoln.png',
'type' => 'png',
),
'/rsrc/image/people/mckinley.png' =>
array(
'hash' => '0b7b05dd47c49a0874670e5e8200bba8',
'uri' => '/res/0b7b05dd/rsrc/image/people/mckinley.png',
'disk' => '/rsrc/image/people/mckinley.png',
'type' => 'png',
),
'/rsrc/image/people/taft.png' =>
array(
'hash' => 'f3e47d45b59b0b009fd536dabae9a151',
'uri' => '/res/f3e47d45/rsrc/image/people/taft.png',
'disk' => '/rsrc/image/people/taft.png',
'type' => 'png',
),
'/rsrc/image/people/washington.png' =>
array(
'hash' => '01412761cab769f7993d69eba986d949',
'uri' => '/res/01412761/rsrc/image/people/washington.png',
'disk' => '/rsrc/image/people/washington.png',
'type' => 'png',
),
'/rsrc/image/phrequent_active.png' =>
array(
'hash' => '716cddc08630eaa33934b2008723cac0',
'uri' => '/res/716cddc0/rsrc/image/phrequent_active.png',
'disk' => '/rsrc/image/phrequent_active.png',
'type' => 'png',
),
'/rsrc/image/phrequent_inactive.png' =>
array(
'hash' => 'f9099683873c01c5de1dc6650bd668fe',
'uri' => '/res/f9099683/rsrc/image/phrequent_inactive.png',
'disk' => '/rsrc/image/phrequent_inactive.png',
'type' => 'png',
),
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'/rsrc/image/search.png' =>
array(
Minor, reduce prominence of main menu icons.
2012-08-06 00:07:12 +02:00
'hash' => 'ff7da044e6f923b8f569dec11f97e5e5',
'uri' => '/res/ff7da044/rsrc/image/search.png',
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'disk' => '/rsrc/image/search.png',
'type' => 'png',
),
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'/rsrc/image/sprite-actions-X2.png' =>
array(
'hash' => 'dee876887537d0f941f89ea41adf6631',
'uri' => '/res/dee87688/rsrc/image/sprite-actions-X2.png',
'disk' => '/rsrc/image/sprite-actions-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-actions.png' =>
array(
'hash' => '6b58724a27c34412edb421dc25b4b091',
'uri' => '/res/6b58724a/rsrc/image/sprite-actions.png',
'disk' => '/rsrc/image/sprite-actions.png',
'type' => 'png',
),
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'/rsrc/image/sprite-apps-X2.png' =>
array(
Update icons Summary: Add icons for releeph, phage, workphlow, prequent, adventure, and xhprof. Accidentally includes phame. Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5540
2013-04-02 23:28:11 +02:00
'hash' => '35a4b5c92f0b05a6a06c8a8e2f409d9e',
'uri' => '/res/35a4b5c9/rsrc/image/sprite-apps-X2.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/sprite-apps-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-apps-large-X2.png' =>
array(
Rework desktop header Summary: Removes the glow icons and uses a hover change. Fixes phantom anchors. Test Plan: Review in Chrome at various sizes (phone tablet). Check that icons still work. Check that mobile menus render when clicked. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2876 Differential Revision: https://secure.phabricator.com/D5549
2013-04-03 17:26:36 +02:00
'hash' => '6295f60df446103f0de702f25bc502e1',
'uri' => '/res/6295f60d/rsrc/image/sprite-apps-large-X2.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/sprite-apps-large-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-apps-large.png' =>
array(
Rework desktop header Summary: Removes the glow icons and uses a hover change. Fixes phantom anchors. Test Plan: Review in Chrome at various sizes (phone tablet). Check that icons still work. Check that mobile menus render when clicked. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2876 Differential Revision: https://secure.phabricator.com/D5549
2013-04-03 17:26:36 +02:00
'hash' => '734d9268dd3a69102b194a7461c68631',
'uri' => '/res/734d9268/rsrc/image/sprite-apps-large.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/sprite-apps-large.png',
'type' => 'png',
),
'/rsrc/image/sprite-apps-xlarge.png' =>
array(
Added Feed icons. Summary: Adds a feed icon for feed applications. Test Plan: Photoshop Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4388
2013-01-10 19:00:18 +01:00
'hash' => '992d2c278b6a22c0fa874d457a252fbd',
'uri' => '/res/992d2c27/rsrc/image/sprite-apps-xlarge.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/sprite-apps-xlarge.png',
'type' => 'png',
),
'/rsrc/image/sprite-apps.png' =>
array(
Update icons Summary: Add icons for releeph, phage, workphlow, prequent, adventure, and xhprof. Accidentally includes phame. Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5540
2013-04-02 23:28:11 +02:00
'hash' => 'eed2e0e322821e1c0836fc62639c1af1',
'uri' => '/res/eed2e0e3/rsrc/image/sprite-apps.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/sprite-apps.png',
'type' => 'png',
),
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'/rsrc/image/sprite-conpherence-X2.png' =>
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
array(
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'hash' => '5e47868b00933a9afb6c844e464e6b23',
'uri' => '/res/5e47868b/rsrc/image/sprite-conpherence-X2.png',
'disk' => '/rsrc/image/sprite-conpherence-X2.png',
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
'type' => 'png',
),
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'/rsrc/image/sprite-conpherence.png' =>
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
array(
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'hash' => 'ca51f1be25213262d68e626e4cab7f0f',
'uri' => '/res/ca51f1be/rsrc/image/sprite-conpherence.png',
'disk' => '/rsrc/image/sprite-conpherence.png',
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
'type' => 'png',
),
Document icons sprite sheet. Summary: Adds 32 and 64 px images to represent basic documents. Test Plan: Differential Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5317
2013-03-10 22:16:16 +01:00
'/rsrc/image/sprite-docs-X2.png' =>
array(
'hash' => '57d3286ce88133f3ec9240e35f6bb897',
'uri' => '/res/57d3286c/rsrc/image/sprite-docs-X2.png',
'disk' => '/rsrc/image/sprite-docs-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-docs.png' =>
array(
'hash' => 'b2b089072d6eddd831402a77c02b5736',
'uri' => '/res/b2b08907/rsrc/image/sprite-docs.png',
'disk' => '/rsrc/image/sprite-docs.png',
'type' => 'png',
),
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'/rsrc/image/sprite-gradient.png' =>
array(
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'hash' => 'e52f57d64edfddfcc2f8bd26a262dda2',
'uri' => '/res/e52f57d6/rsrc/image/sprite-gradient.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/sprite-gradient.png',
'type' => 'png',
),
Generate an icon sprite map with new sprites and 2x retina graphics Summary: - The filesystem is now the authority for which sprites are available. If you add new icons, the generation process will pick them up. - I broke out icon generation and added retina support. App icon generation still uses the old method. - Update ActionList and RemarkupControl to use the new sheet. - Use white icons on hover. - Also fixed a couple of minor issues with some stuff in Firefox/Chrome. Test Plan: {F25750} {F25751} {F25752} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2013 Differential Revision: https://secure.phabricator.com/D4027
2012-11-24 01:35:39 +01:00
'/rsrc/image/sprite-icon-X2.png' =>
array(
Action Menu (mobile) Summary: First pass here, still needs some UI work (maybe? tablets?). Getting it out to see if implementation is corrrect. Test Plan: Shrink Maniphest task on Chrome, see new UI. Toggle menu. Test on iOS. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5631
2013-04-09 21:42:03 +02:00
'hash' => '1610d410ca8730ec26232cd5698a962a',
'uri' => '/res/1610d410/rsrc/image/sprite-icon-X2.png',
Generate an icon sprite map with new sprites and 2x retina graphics Summary: - The filesystem is now the authority for which sprites are available. If you add new icons, the generation process will pick them up. - I broke out icon generation and added retina support. App icon generation still uses the old method. - Update ActionList and RemarkupControl to use the new sheet. - Use white icons on hover. - Also fixed a couple of minor issues with some stuff in Firefox/Chrome. Test Plan: {F25750} {F25751} {F25752} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2013 Differential Revision: https://secure.phabricator.com/D4027
2012-11-24 01:35:39 +01:00
'disk' => '/rsrc/image/sprite-icon-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-icon.png' =>
array(
Action Menu (mobile) Summary: First pass here, still needs some UI work (maybe? tablets?). Getting it out to see if implementation is corrrect. Test Plan: Shrink Maniphest task on Chrome, see new UI. Toggle menu. Test on iOS. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5631
2013-04-09 21:42:03 +02:00
'hash' => '891dea483c37bdc43c00372944c98165',
'uri' => '/res/891dea48/rsrc/image/sprite-icon.png',
Generate an icon sprite map with new sprites and 2x retina graphics Summary: - The filesystem is now the authority for which sprites are available. If you add new icons, the generation process will pick them up. - I broke out icon generation and added retina support. App icon generation still uses the old method. - Update ActionList and RemarkupControl to use the new sheet. - Use white icons on hover. - Also fixed a couple of minor issues with some stuff in Firefox/Chrome. Test Plan: {F25750} {F25751} {F25752} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2013 Differential Revision: https://secure.phabricator.com/D4027
2012-11-24 01:35:39 +01:00
'disk' => '/rsrc/image/sprite-icon.png',
'type' => 'png',
),
Use "flame" notification icon and bubble instead of lightning bolt Summary: Switch to the final versions of these Test Plan: Will add screenshots... Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4032
2012-11-27 23:03:25 +01:00
'/rsrc/image/sprite-menu-X2.png' =>
array(
Rework Mobile Header and Mobile Home. Summary: Mostly finished, wanted to get it into your hands to play with. I need to remove some more dead CSS and figure out where we want to put profile/logout, but overall feels pretty good. Tested a bunch in iOS and other layouts. Test Plan: Test Home, Maniphest, search bars, app menus. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2809 Differential Revision: https://secure.phabricator.com/D5407
2013-03-22 19:50:30 +01:00
'hash' => '867092041ce0a62b7e50136213ca7be1',
'uri' => '/res/86709204/rsrc/image/sprite-menu-X2.png',
Use "flame" notification icon and bubble instead of lightning bolt Summary: Switch to the final versions of these Test Plan: Will add screenshots... Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4032
2012-11-27 23:03:25 +01:00
'disk' => '/rsrc/image/sprite-menu-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-menu.png' =>
array(
Rework Mobile Header and Mobile Home. Summary: Mostly finished, wanted to get it into your hands to play with. I need to remove some more dead CSS and figure out where we want to put profile/logout, but overall feels pretty good. Tested a bunch in iOS and other layouts. Test Plan: Test Home, Maniphest, search bars, app menus. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2809 Differential Revision: https://secure.phabricator.com/D5407
2013-03-22 19:50:30 +01:00
'hash' => '21508eebdf582d7251d62bb2cd09f66d',
'uri' => '/res/21508eeb/rsrc/image/sprite-menu.png',
Use "flame" notification icon and bubble instead of lightning bolt Summary: Switch to the final versions of these Test Plan: Will add screenshots... Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4032
2012-11-27 23:03:25 +01:00
'disk' => '/rsrc/image/sprite-menu.png',
'type' => 'png',
),
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'/rsrc/image/sprite-minicons-X2.png' =>
array(
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'hash' => 'c420c6462f7e50ca9941ccc5dd9e3dec',
'uri' => '/res/c420c646/rsrc/image/sprite-minicons-X2.png',
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'disk' => '/rsrc/image/sprite-minicons-X2.png',
'type' => 'png',
),
'/rsrc/image/sprite-minicons.png' =>
array(
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'hash' => '168bb875933624b3080a1cc134e5b4ed',
'uri' => '/res/168bb875/rsrc/image/sprite-minicons.png',
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'disk' => '/rsrc/image/sprite-minicons.png',
'type' => 'png',
),
Tokens v1 Summary: Features! - Giving tokens. - Taking tokens back. - Not giving tokens. Test Plan: See screenshots. Reviewers: chad, vrana Reviewed By: chad CC: aran, btrahan Maniphest Tasks: T2541 Differential Revision: https://secure.phabricator.com/D4964
2013-02-15 16:47:14 +01:00
'/rsrc/image/sprite-tokens.png' =>
array(
'hash' => '67c46fd75c885b76ecbfe46e71a476cc',
'uri' => '/res/67c46fd7/rsrc/image/sprite-tokens.png',
'disk' => '/rsrc/image/sprite-tokens.png',
'type' => 'png',
),
Add gradient to object-list cards Summary: Adds a gradient, also re-ran sprite generator to attempt to sprite - for some reason all images were un-optimized. Test Plan: Test on UI Examples page Reviewers: epriestley, btrahan Reviewed By: btrahan CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5354
2013-03-16 01:15:57 +01:00
'/rsrc/image/texture/card-gradient.png' =>
array(
Lighten up gradient on cards Summary: Taller gradient, lighter at bottom. Also fixed right corners. Test Plan: Chrome, Photoshop Reviewers: epriestley, asherkin Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5437
2013-03-24 03:50:26 +01:00
'hash' => '268b7fdd758d4bf99db8de6770aae8af',
'uri' => '/res/268b7fdd/rsrc/image/texture/card-gradient.png',
Add gradient to object-list cards Summary: Adds a gradient, also re-ran sprite generator to attempt to sprite - for some reason all images were un-optimized. Test Plan: Test on UI Examples page Reviewers: epriestley, btrahan Reviewed By: btrahan CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5354
2013-03-16 01:15:57 +01:00
'disk' => '/rsrc/image/texture/card-gradient.png',
'type' => 'png',
),
Tweak hover blue on homepage. Summary: Yay more images? Also imageoptim'd them. Test Plan: Chrome, FF Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4455
2013-01-16 01:17:53 +01:00
'/rsrc/image/texture/dark-menu-hover.png' =>
array(
'hash' => 'a214a732644be34872e895b338b5d639',
'uri' => '/res/a214a732/rsrc/image/texture/dark-menu-hover.png',
'disk' => '/rsrc/image/texture/dark-menu-hover.png',
'type' => 'png',
),
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'/rsrc/image/texture/dark-menu.png' =>
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
array(
Tweak hover blue on homepage. Summary: Yay more images? Also imageoptim'd them. Test Plan: Chrome, FF Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4455
2013-01-16 01:17:53 +01:00
'hash' => '41ee673a762cec48a154b456ad5ac204',
'uri' => '/res/41ee673a/rsrc/image/texture/dark-menu.png',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'disk' => '/rsrc/image/texture/dark-menu.png',
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'type' => 'png',
),
Fix some ObjectItemList issues Summary: Safari has a weird bug with `border-radius` plus border color: {F35865} Move the uncolored borders to an internal div to fix this. Also tweak some positioning on icons for cards, and add a "magenta" color. Test Plan: {F35866} Reviewers: chad, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5338
2013-03-23 22:37:18 +01:00
'/rsrc/image/texture/grip.png' =>
array(
'hash' => 'f11bc231d241f1335cfca2933ad234e0',
'uri' => '/res/f11bc231/rsrc/image/texture/grip.png',
'disk' => '/rsrc/image/texture/grip.png',
'type' => 'png',
),
Minor, fix celerity map.
2013-04-01 05:07:47 +02:00
'/rsrc/image/texture/panel-header-gradient.png' =>
array(
'hash' => 'ad9204dd3ef5b12b645d80677d8ccead',
'uri' => '/res/ad9204dd/rsrc/image/texture/panel-header-gradient.png',
'disk' => '/rsrc/image/texture/panel-header-gradient.png',
'type' => 'png',
),
Update PholioMockView Styles. Summary: Less janky sidebar, new 'photoshop-like' texture for image background. Test Plan: Tested mocks with and without side comments, hover over marked squares. Tested small and large images. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5216
2013-03-05 01:01:27 +01:00
'/rsrc/image/texture/pholio-background.gif' =>
array(
'hash' => 'cf4561af116edf393dc583e5119fb412',
'uri' => '/res/cf4561af/rsrc/image/texture/pholio-background.gif',
'disk' => '/rsrc/image/texture/pholio-background.gif',
'type' => 'gif',
),
Update tables to table-kit view. Summary: Reskinning tables to table-kit mocks, which includes new textures, spacing, slightly larger fonts. Looking for early feedback before adding in new row colors and other items into the class. Test Plan: http://phab1.pushlabs.net/uiexample/view/PhabricatorSortTableExample/ Reviewers: btrahan, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4396
2013-01-11 20:24:35 +01:00
'/rsrc/image/texture/table_header.png' =>
array(
'hash' => '4ed3f56a30d3749e8f62052b9735a316',
'uri' => '/res/4ed3f56a/rsrc/image/texture/table_header.png',
'disk' => '/rsrc/image/texture/table_header.png',
'type' => 'png',
),
'/rsrc/image/texture/table_header_hover.png' =>
array(
'hash' => 'ea1f71a604e9b4859de1e25751540437',
'uri' => '/res/ea1f71a6/rsrc/image/texture/table_header_hover.png',
'disk' => '/rsrc/image/texture/table_header_hover.png',
'type' => 'png',
),
Don't add trailing slash to Search Owners link Test Plan: Clicked it. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4609
2013-01-24 03:00:22 +01:00
'/rsrc/image/texture/table_header_tall.png' =>
array(
'hash' => 'b05525601f78d759f1c5e47fd9c1a8aa',
'uri' => '/res/b0552560/rsrc/image/texture/table_header_tall.png',
'disk' => '/rsrc/image/texture/table_header_tall.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/swf/aphlict.swf' =>
array(
Minor, update celerity map.
2012-06-12 02:52:17 +02:00
'hash' => '4b9a9d83bebaf254f3790e87b45c1f92',
'uri' => '/res/4b9a9d83/rsrc/swf/aphlict.swf',
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'disk' => '/rsrc/swf/aphlict.swf',
'type' => 'swf',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'aphront-attached-file-view-css' =>
array(
'uri' => '/res/a6ca5487/rsrc/css/aphront/attached-file-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/attached-file-view.css',
),
Re-run celerity mapper Summary: D5226 nixed something I put in the celerity map. This diff adds it back, along with a bunch of other changes that `./scripts/celerity_mapper.php webroot/` decided were super important. Test Plan: Repeatedly place click actions into the HTML `document`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5253
2013-03-06 15:15:24 +01:00
'aphront-bars' =>
array(
'uri' => '/res/d7bd9032/rsrc/css/core/aphront-bars.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/aphront-bars.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'aphront-calendar-view-css' =>
array(
Minor phutil_tag/HTML fixes Summary: - In stack traces, a `,` should clearly be a `.`. - In Calendar, a 'td' got swapped with a 'p' somewhere. - In old-style transaction views, strlen() is no longer a sufficient test. Test Plan: - Verified stack traces render correctly. - Verified calendar renders correctly. - Verified Maniphest transactions with no comment no longer have a little empty div a few pixels high. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4971
2013-02-15 17:14:31 +01:00
'uri' => '/res/73061a31/rsrc/css/aphront/calendar-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/calendar-view.css',
),
'aphront-contextbar-view-css' =>
array(
Simplify side nav CSS and fix various glitches Summary: Fixes glitches in the side nav. Resolves T1828. Resolves T2156. - Elastic scrolling (T2156): in Safari on OSX, using a scroll touch on the trackpad to scroll up past the top of the document caused newer-style side menus to scroll down, leaving a visible whitespace bar. - Whitespace glitch: Particularly in Safari, scrolling down the document quickly from the top caused the top menu to scroll away before the side menu rose to meet it. Use a fixed background color bar that extends under the menu so this doesn't happen. - Use of "!important": use CSS better so we don't need to "!important" things. - Dark Console (T1828): Instead of hard-coding the top position, determine it dynamically by looking at where the content is. This also fixes the menu overlapping with the red "there are errors on this page" development bar. - General "fixed" glitchiness: don't use fixed-position for menu content other than flexible (draggable) menus. Test Plan: - Viewed and scrolled menus in Paste. Opened and closed DarkConsole. Switched devices. - Viewed and scrolled flexible menus in Differential and Diffusion. Opened and closed DarkConsole. Switched devices. Reviewers: vrana, chad, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T1828, T2156 Differential Revision: https://secure.phabricator.com/D4185
2012-12-15 00:14:14 +01:00
'uri' => '/res/ecfd5ba9/rsrc/css/aphront/context-bar.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/context-bar.css',
),
'aphront-dark-console-css' =>
array(
Update mobile menu icons Summary: Simplify the look of the mobile menu, provide active states for the menu icons. Test Plan: iOS Simulator and Chrome. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2426 Differential Revision: https://secure.phabricator.com/D5189
2013-03-03 17:17:57 +01:00
'uri' => '/res/0d316573/rsrc/css/aphront/dark-console.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/dark-console.css',
),
'aphront-dialog-view-css' =>
array(
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'uri' => '/res/7060a2fe/rsrc/css/aphront/dialog-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/dialog-view.css',
),
'aphront-error-view-css' =>
array(
Conpherence - make updating title + picture a dialogue that uses drag and drop upload control Summary: decent title. Stylistically its probably a bit rough. Also, I think @chad describes an even hotter workflow in T2418. Note this removes the "default image" thing which I don't think makes sense conceptually since by default the image changes to who replied last... Test Plan: uploaded an image - worked. uploaded a txt file - got ugly errors that file was not supported. Reviewers: epriestley, chad Reviewed By: chad CC: aran, Korvin Maniphest Tasks: T2417 Differential Revision: https://secure.phabricator.com/D4668
2013-01-27 02:14:58 +01:00
'uri' => '/res/5f43a7c5/rsrc/css/aphront/error-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/error-view.css',
),
'aphront-form-view-css' =>
array(
Reinstate AphrontFormCountedToggleButtonsControl's CSS Summary: Undoes accidental delete from https://secure.phabricator.com/D5314 Test Plan: View awesome new toggle-buttons scheme in Releeph. Reviewers: chad Reviewed By: chad CC: epriestley, aran Differential Revision: https://secure.phabricator.com/D5332
2013-03-13 19:01:15 +01:00
'uri' => '/res/ed8c70fa/rsrc/css/aphront/form-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/form-view.css',
),
'aphront-list-filter-view-css' =>
array(
Flags on mobile, fix some filter-css Summary: Sets device flag on mobile, cleans up filter css a bit. Test Plan: Tested filters on homepage, maniphest, flags, uiexamples. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5559
2013-04-03 20:29:58 +02:00
'uri' => '/res/639ea9e9/rsrc/css/aphront/list-filter-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/list-filter-view.css',
),
Minor, celerity map. (I've removed my merge rule; I think it's no good after the arc land updates of a while ago.)
2013-04-02 20:28:33 +02:00
'aphront-multi-column-view-css' =>
array(
Add a 7th column to AphrontMultiColumnView Summary: Adds a 7th column, useful for fluid calendars. Test Plan: UIExamples Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2898 Differential Revision: https://secure.phabricator.com/D5597
2013-04-06 16:23:59 +02:00
'uri' => '/res/4e5ae0f3/rsrc/css/aphront/multi-column.css',
Minor, celerity map. (I've removed my merge rule; I think it's no good after the arc land updates of a while ago.)
2013-04-02 20:28:33 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/multi-column.css',
),
AphrontNoteView Summary: This is supposed to look a lot like the way Remarkup renders a block of code, so you can render some out of context message inside another container. For example in Releeph, it renders a message someone has associated with a Releeph request. Test Plan: I've added an abstract uiexample, but the use case in Releeph is more explanatory: {F33900} Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D5125
2013-02-26 20:28:50 +01:00
'aphront-notes' =>
array(
Fixing the annoying spacing between project tags. Test Plan: Apply the changes and refresh the Maniphest task list. Reviewers: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5272
2013-03-07 17:06:42 +01:00
'uri' => '/res/f8f3dcfa/rsrc/css/core/aphront-notes.css',
AphrontNoteView Summary: This is supposed to look a lot like the way Remarkup renders a block of code, so you can render some out of context message inside another container. For example in Releeph, it renders a message someone has associated with a Releeph request. Test Plan: I've added an abstract uiexample, but the use case in Releeph is more explanatory: {F33900} Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D5125
2013-02-26 20:28:50 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/aphront-notes.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'aphront-pager-view-css' =>
array(
'uri' => '/res/43fb79f0/rsrc/css/aphront/pager-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/pager-view.css',
),
'aphront-panel-view-css' =>
array(
Fix some bad merging; I landed an old branch for D5502. Auditors: btrahan
2013-04-01 00:19:14 +02:00
'uri' => '/res/5600525c/rsrc/css/aphront/panel-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/panel-view.css',
),
'aphront-request-failure-view-css' =>
array(
'uri' => '/res/c9a43002/rsrc/css/aphront/request-failure-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/request-failure-view.css',
),
'aphront-table-view-css' =>
array(
Updates the error/notice box with cleaner look, softer colors. Summary: These colors are more inline with the look and feel and match the table colors. Test Plan: Used Inspect Element to test each color combination on an error page. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4593
2013-01-23 03:37:09 +01:00
'uri' => '/res/fd33a0f0/rsrc/css/aphront/table-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/table-view.css',
),
'aphront-tokenizer-control-css' =>
array(
Update form input styles. Summary: Adds a slight blue border, radius, and shadow to inputs and textareas (small). Better padding for legibility as well. Test Plan: Review a number of forms Reviewers: epriestley, vrana, btrahan Reviewed By: btrahan CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4383
2013-01-09 23:40:12 +01:00
'uri' => '/res/207105f0/rsrc/css/aphront/tokenizer.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
0 => 'aphront-typeahead-control-css',
),
'disk' => '/rsrc/css/aphront/tokenizer.css',
),
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'aphront-tooltip-css' =>
array(
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'uri' => '/res/3a7d8e07/rsrc/css/aphront/tooltip.css',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/tooltip.css',
),
Apront Two Column View Summary: Wanted to pull this out in case we don't use it in Maniphest, still useful perhaps in the future. Creates a sidebar that wraps when on mobile. Test Plan: Tested UIExample Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5321
2013-03-11 03:20:01 +01:00
'aphront-two-column-view-css' =>
array(
'uri' => '/res/7afa129f/rsrc/css/aphront/two-column.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/two-column.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'aphront-typeahead-control-css' =>
array(
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'uri' => '/res/ef59c20c/rsrc/css/aphront/typeahead.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/typeahead.css',
),
Display examples when editing configuratoin Summary: Show example config values to the user when available. Test Plan: {F28465} {F28466} Reviewers: btrahan, codeblock Reviewed By: btrahan CC: aran Maniphest Tasks: T2221, T2255 Differential Revision: https://secure.phabricator.com/D4311
2013-01-01 23:09:59 +01:00
'config-options-css' =>
array(
Tighten up object list 2px Summary: Pulls in the top 2px and left 2px. Also reduces to 13px as standard. The 14px never looked decent to me. Main objective here is to have it feel more table-like instead of a sea of white space. Test Plan: Tested layouts in Maniphest, Config, and UIExamples. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5551
2013-04-03 17:28:22 +02:00
'uri' => '/res/01892229/rsrc/css/application/config/config-options.css',
Display examples when editing configuratoin Summary: Show example config values to the user when available. Test Plan: {F28465} {F28466} Reviewers: btrahan, codeblock Reviewed By: btrahan CC: aran Maniphest Tasks: T2221, T2255 Differential Revision: https://secure.phabricator.com/D4311
2013-01-01 23:09:59 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/config/config-options.css',
),
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'conpherence-header-pane-css' =>
array(
Replace `/conpherence/N/` with `/conpherence/view/N/`. Summary: - Move `/N/` to `/thread/N/`. - Move `/view/N/` to `/N`/. - This makes the mobile "Conpherence -> click thread -> see thread" workflow work correctly. This also makes permalinks work correctly on mobile. Ref T2421. Test Plan: Clicked flows on desktop, mobile. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2421 Differential Revision: https://secure.phabricator.com/D5508
2013-04-01 03:28:15 +02:00
'uri' => '/res/7f7cc347/rsrc/css/application/conpherence/header-pane.css',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/conpherence/header-pane.css',
),
'conpherence-menu-css' =>
array(
Conpherence - make conpherence load the bare minimum of data Summary: also re-enables the updating of the widgets and "cleans up" the javascript a tad. Ref T2867 Test Plan: all sorts of conpherence fun like adding people to threads, adding files, pontificating, etc Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2867 Differential Revision: https://secure.phabricator.com/D5595
2013-04-08 20:13:35 +02:00
'uri' => '/res/7413379f/rsrc/css/application/conpherence/menu.css',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/conpherence/menu.css',
),
'conpherence-message-pane-css' =>
array(
Replace `/conpherence/N/` with `/conpherence/view/N/`. Summary: - Move `/N/` to `/thread/N/`. - Move `/view/N/` to `/N`/. - This makes the mobile "Conpherence -> click thread -> see thread" workflow work correctly. This also makes permalinks work correctly on mobile. Ref T2421. Test Plan: Clicked flows on desktop, mobile. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2421 Differential Revision: https://secure.phabricator.com/D5508
2013-04-01 03:28:15 +02:00
'uri' => '/res/2876cc7f/rsrc/css/application/conpherence/message-pane.css',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/conpherence/message-pane.css',
),
'conpherence-update-css' =>
array(
Merge branch 'master' into phutil_tag (Sync.)
2013-02-07 17:08:01 +01:00
'uri' => '/res/92094ed7/rsrc/css/application/conpherence/update.css',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/conpherence/update.css',
),
'conpherence-widget-pane-css' =>
array(
Fix IE dust. Summary: Silly IE. Test Plan: IE, Chrome Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5626
2013-04-09 18:48:46 +02:00
'uri' => '/res/207ef6fc/rsrc/css/application/conpherence/widget-pane.css',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/conpherence/widget-pane.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'differential-changeset-view-css' =>
array(
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'uri' => '/res/ea694162/rsrc/css/application/differential/changeset-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/changeset-view.css',
),
'differential-core-view-css' =>
array(
Simplify side nav CSS and fix various glitches Summary: Fixes glitches in the side nav. Resolves T1828. Resolves T2156. - Elastic scrolling (T2156): in Safari on OSX, using a scroll touch on the trackpad to scroll up past the top of the document caused newer-style side menus to scroll down, leaving a visible whitespace bar. - Whitespace glitch: Particularly in Safari, scrolling down the document quickly from the top caused the top menu to scroll away before the side menu rose to meet it. Use a fixed background color bar that extends under the menu so this doesn't happen. - Use of "!important": use CSS better so we don't need to "!important" things. - Dark Console (T1828): Instead of hard-coding the top position, determine it dynamically by looking at where the content is. This also fixes the menu overlapping with the red "there are errors on this page" development bar. - General "fixed" glitchiness: don't use fixed-position for menu content other than flexible (draggable) menus. Test Plan: - Viewed and scrolled menus in Paste. Opened and closed DarkConsole. Switched devices. - Viewed and scrolled flexible menus in Differential and Diffusion. Opened and closed DarkConsole. Switched devices. Reviewers: vrana, chad, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T1828, T2156 Differential Revision: https://secure.phabricator.com/D4185
2012-12-15 00:14:14 +01:00
'uri' => '/res/85fe5117/rsrc/css/application/differential/core.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/core.css',
),
'differential-inline-comment-editor' =>
array(
Make control + enter submit forms if a textarea is focused Summary: This is straightforward, except that `form.submit()` does not call onsubmit handlers. Create a `didSyntheticSubmit` event and have everything which listens for form submits listen for it too. Fixes T704. Test Plan: Hit control + enter in inline comments, main commetns, Pholio, conpherence. Verified it triggered appropriate JS (workflow / special behaviors). Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T704 Differential Revision: https://secure.phabricator.com/D4704
2013-01-28 23:11:32 +01:00
'uri' => '/res/e0ad34ac/rsrc/js/application/differential/DifferentialInlineCommentEditor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-dom',
Use an inline dialog element for inline comments in Differential Summary: The current approach of using a modal overlay dialog to create/edit inline comments is pretty silly. Use an inline textarea instead. This element isn't perfect and we have some mild modalness issues, but I think it's better than the silly thing we've got going on right now. We can keep poking it as people break it. Test Plan: - Created comments; submitted and undid them in empty and nonempty states. Used undo for nonempty states + cancel. - Edited comments; saved and canceled them. Used undo for changed state. - Replied to comments; yada yada as above. - Deleted comments. - Did various modal trickery where I clicked "Reply" on something else with a dialog already up, this very mildly glitches but I think it's not a big issue. Reviewers: vrana, btrahan, Makinde, nh Reviewed By: vrana CC: aran, epriestley Maniphest Tasks: T431 Differential Revision: https://secure.phabricator.com/D1716
2012-02-29 23:28:48 +01:00
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-install',
4 => 'javelin-request',
5 => 'javelin-workflow',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/differential/DifferentialInlineCommentEditor.js',
),
'differential-local-commits-view-css' =>
array(
Modernize file uploads Summary: Modernizes file uploads. In particular: - Adds a mobile menu, with an "Upload File" item. - Adds crumbs to the list view, detail view and upload view. - Adds "Upload File" action to crumbs. - Moves upload file to a separate page. - Removes the combined upload file + recent files page. - Makes upload file use a normal file control by default (works on mobile). - Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message. - User education on this is a little weak but I think that's a big can of worms? - Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190). T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general. @chad, do we have an "upload" icon (counterpart to "download")? Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2190 Differential Revision: https://secure.phabricator.com/D4200
2012-12-17 01:34:01 +01:00
'uri' => '/res/224f3703/rsrc/css/application/differential/local-commits-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/local-commits-view.css',
),
Further improve unit/lint rendering Summary: I think this improves things, let me know if you have feedback. Also addresses T840. Test Plan: See screenshots... Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, zeeg Maniphest Tasks: T840 Differential Revision: https://secure.phabricator.com/D2357
2012-05-01 19:15:56 +02:00
'differential-results-table-css' =>
array(
Tweak colors on differential results table. Summary: Changes the tan table with the girly blue header color. Test Plan: Chrome Reviewers: vrana, epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2176 Differential Revision: https://secure.phabricator.com/D4164
2012-12-12 17:50:55 +01:00
'uri' => '/res/aab3123c/rsrc/css/application/differential/results-table.css',
Further improve unit/lint rendering Summary: I think this improves things, let me know if you have feedback. Also addresses T840. Test Plan: See screenshots... Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, zeeg Maniphest Tasks: T840 Differential Revision: https://secure.phabricator.com/D2357
2012-05-01 19:15:56 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/results-table.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'differential-revision-add-comment-css' =>
array(
'uri' => '/res/849748d3/rsrc/css/application/differential/add-comment.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/add-comment.css',
),
'differential-revision-comment-css' =>
array(
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'uri' => '/res/42c222f4/rsrc/css/application/differential/revision-comment.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-comment.css',
),
'differential-revision-comment-list-css' =>
array(
'uri' => '/res/3b31faa3/rsrc/css/application/differential/revision-comment-list.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-comment-list.css',
),
'differential-revision-history-css' =>
array(
Modernize file uploads Summary: Modernizes file uploads. In particular: - Adds a mobile menu, with an "Upload File" item. - Adds crumbs to the list view, detail view and upload view. - Adds "Upload File" action to crumbs. - Moves upload file to a separate page. - Removes the combined upload file + recent files page. - Makes upload file use a normal file control by default (works on mobile). - Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message. - User education on this is a little weak but I think that's a big can of worms? - Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190). T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general. @chad, do we have an "upload" icon (counterpart to "download")? Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2190 Differential Revision: https://secure.phabricator.com/D4200
2012-12-17 01:34:01 +01:00
'uri' => '/res/d41bc64c/rsrc/css/application/differential/revision-history.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-history.css',
),
Highlight update time in revision list Summary: This is another experiment for reducing reviewers response time. I stole the idea (and colors) from [[ http://www.reviewboard.org/media/screenshots/2009/02/02/dashboard.png | ReviewBoard ]]. I actually quite like it (except when everything is red) and I can image that people will review just to have better color balance. The code is not production ready for these reasons: - We load holidays again and again for each revision. I couldn't cache it to static variable because it could persist multiple requests, right? - I don't know how to expand height to the whole cell (I'm really bad in CSS). - CSS rules are probably in wrong file. - We probably want to use different colors. This is how it looks: {F16406} Test Plan: Displayed revision list. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3190
2012-08-20 23:05:46 +02:00
'differential-revision-list-css' =>
array(
Sprite menu label and hover states Summary: These can all fit into the gradient sprite. Test Plan: Looked at menu with selected item, hovered over menu. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4453
2013-01-16 00:49:48 +01:00
'uri' => '/res/fe6c4721/rsrc/css/application/differential/revision-list.css',
Highlight update time in revision list Summary: This is another experiment for reducing reviewers response time. I stole the idea (and colors) from [[ http://www.reviewboard.org/media/screenshots/2009/02/02/dashboard.png | ReviewBoard ]]. I actually quite like it (except when everything is red) and I can image that people will review just to have better color balance. The code is not production ready for these reasons: - We load holidays again and again for each revision. I couldn't cache it to static variable because it could persist multiple requests, right? - I don't know how to expand height to the whole cell (I'm really bad in CSS). - CSS rules are probably in wrong file. - We probably want to use different colors. This is how it looks: {F16406} Test Plan: Displayed revision list. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3190
2012-08-20 23:05:46 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-list.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'differential-table-of-contents-css' =>
array(
Simplify side nav CSS and fix various glitches Summary: Fixes glitches in the side nav. Resolves T1828. Resolves T2156. - Elastic scrolling (T2156): in Safari on OSX, using a scroll touch on the trackpad to scroll up past the top of the document caused newer-style side menus to scroll down, leaving a visible whitespace bar. - Whitespace glitch: Particularly in Safari, scrolling down the document quickly from the top caused the top menu to scroll away before the side menu rose to meet it. Use a fixed background color bar that extends under the menu so this doesn't happen. - Use of "!important": use CSS better so we don't need to "!important" things. - Dark Console (T1828): Instead of hard-coding the top position, determine it dynamically by looking at where the content is. This also fixes the menu overlapping with the red "there are errors on this page" development bar. - General "fixed" glitchiness: don't use fixed-position for menu content other than flexible (draggable) menus. Test Plan: - Viewed and scrolled menus in Paste. Opened and closed DarkConsole. Switched devices. - Viewed and scrolled flexible menus in Differential and Diffusion. Opened and closed DarkConsole. Switched devices. Reviewers: vrana, chad, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T1828, T2156 Differential Revision: https://secure.phabricator.com/D4185
2012-12-15 00:14:14 +01:00
'uri' => '/res/4fde8bfc/rsrc/css/application/differential/table-of-contents.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/table-of-contents.css',
),
'diffusion-commit-view-css' =>
array(
Delete unused CSS Summary: Unused since D2062. Test Plan: View commit. View task. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2108
2012-04-05 19:47:20 +02:00
'uri' => '/res/b445944e/rsrc/css/application/diffusion/commit-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/commit-view.css',
),
Improve Diffusion behavior for externals Summary: - Feature request from Airtime that I missed in the feedback notes, came up yesterday. - Identify git submodules as "FILE_SUBMODULE", not "FILE_NORMAL". - Link git submodules to an external resolver endpoint, which tries to find commits in tracked repositories. - Identify git symlinks as "FILE_SYMLINK", not "FILE_NORMAL". - Add folder, file, symlink and externals icons. Test Plan: - externals/javelin is now identified as a submoudule and links to Javelin, not identified as a file and links to error. - bin/phd is now identified as a symlink. - Interfaces have pretty icons. Reviewers: btrahan, cpiro, ddfisher, keebuhm, allenjohnashton Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1975
2012-03-21 22:01:20 +01:00
'diffusion-icons-css' =>
array(
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'uri' => '/res/b93e32c9/rsrc/css/application/diffusion/diffusion-icons.css',
Improve Diffusion behavior for externals Summary: - Feature request from Airtime that I missed in the feedback notes, came up yesterday. - Identify git submodules as "FILE_SUBMODULE", not "FILE_NORMAL". - Link git submodules to an external resolver endpoint, which tries to find commits in tracked repositories. - Identify git symlinks as "FILE_SYMLINK", not "FILE_NORMAL". - Add folder, file, symlink and externals icons. Test Plan: - externals/javelin is now identified as a submoudule and links to Javelin, not identified as a file and links to error. - bin/phd is now identified as a symlink. - Interfaces have pretty icons. Reviewers: btrahan, cpiro, ddfisher, keebuhm, allenjohnashton Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1975
2012-03-21 22:01:20 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/diffusion-icons.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'diffusion-source-css' =>
array(
Load blame in Diffusion by AJAX Summary: I have blame enabled by default and displaying files with long history takes easily over 10 seconds. Load the blame data by AJAX instead. This is actually doing more work and the total response time is longer but it's worth it for me as I am interested just in the file contents quite often. I know you were talking about building blame cache but until we have it... I'm not sure if the AJAX loading indicator in bottom right corner is enough to inform the user that we are loading it on background. Test Plan: ?view=highlighted ?view=plainblame ?view=blame Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5244
2013-03-05 23:31:20 +01:00
'uri' => '/res/e76bcd50/rsrc/css/application/diffusion/diffusion-source.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/diffusion-source.css',
),
Modernize file uploads Summary: Modernizes file uploads. In particular: - Adds a mobile menu, with an "Upload File" item. - Adds crumbs to the list view, detail view and upload view. - Adds "Upload File" action to crumbs. - Moves upload file to a separate page. - Removes the combined upload file + recent files page. - Makes upload file use a normal file control by default (works on mobile). - Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message. - User education on this is a little weak but I think that's a big can of worms? - Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190). T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general. @chad, do we have an "upload" icon (counterpart to "download")? Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2190 Differential Revision: https://secure.phabricator.com/D4200
2012-12-17 01:34:01 +01:00
'global-drag-and-drop-css' =>
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
array(
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'uri' => '/res/4e24cb65/rsrc/css/application/files/global-drag-and-drop.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
Modernize file uploads Summary: Modernizes file uploads. In particular: - Adds a mobile menu, with an "Upload File" item. - Adds crumbs to the list view, detail view and upload view. - Adds "Upload File" action to crumbs. - Moves upload file to a separate page. - Removes the combined upload file + recent files page. - Makes upload file use a normal file control by default (works on mobile). - Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message. - User education on this is a little weak but I think that's a big can of worms? - Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190). T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general. @chad, do we have an "upload" icon (counterpart to "download")? Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2190 Differential Revision: https://secure.phabricator.com/D4200
2012-12-17 01:34:01 +01:00
'disk' => '/rsrc/css/application/files/global-drag-and-drop.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'herald-css' =>
array(
Clean up Login, Responsive Forms Summary: Removes the panel-view on login and adds additonal responsive styles for mobile forms. Test Plan: View in mobile browser, resize page. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4530
2013-01-19 23:30:26 +01:00
'uri' => '/res/2150a55d/rsrc/css/application/herald/herald.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/herald/herald.css',
),
'herald-rule-editor' =>
array(
Clean up Login, Responsive Forms Summary: Removes the panel-view on login and adds additonal responsive styles for mobile forms. Test Plan: View in mobile browser, resize page. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4530
2013-01-19 23:30:26 +01:00
'uri' => '/res/f35d7e23/rsrc/js/application/herald/HeraldRuleEditor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'multirow-row-manager',
1 => 'javelin-install',
2 => 'javelin-typeahead',
3 => 'javelin-util',
4 => 'javelin-dom',
5 => 'javelin-tokenizer',
6 => 'javelin-typeahead-preloaded-source',
7 => 'javelin-stratcom',
8 => 'javelin-json',
9 => 'phabricator-prefab',
),
'disk' => '/rsrc/js/application/herald/HeraldRuleEditor.js',
),
'herald-test-css' =>
array(
'uri' => '/res/c0cd6bdb/rsrc/css/application/herald/herald-test.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/herald/herald-test.css',
),
Separate the inline comment summary element into a separate view Summary: - Affects the "Inline Comments" summary table which appears in comments that have attached inlines in the discussion threads in Differential. - Prepares for inclusion in Diffusion. - No application changes (minor CSS), just factors code better. - Simplify/separate CSS. Test Plan: Looked at on-diff and off-diff comment summaries in Differential, display looked correct. Reviewers: davidreuss, nh, btrahan Reviewed By: davidreuss CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1928
2012-03-20 03:45:16 +01:00
'inline-comment-summary-css' =>
array(
'uri' => '/res/338704f7/rsrc/css/application/diff/inline-comment-summary.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diff/inline-comment-summary.css',
),
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
'javelin-aphlict' =>
array(
Improve Aphlict server Summary: - Move to port 22280 by default. - Warn when running as non-root. - Allow subscription and publish/admin ports to be configured. - Allow server to drop root after binding to 843. - Allow log path to be configured. - Add /status/ admin URI which shows server status. - Return HTTP 400 Bad Request for other requests, instead of hanging. - Minor formatting cleanup. Test Plan: Ran without root: $ node aphlict_server.js ...got a good error message. Ran with --user: $ sudo node aphlict_server.js --user=epriestley ...verified server dropped permissions. Ran with --port / --admin. Hit /status/ with GET, got status. Hit other URLs with GET, got 400. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran Differential Revision: https://secure.phabricator.com/D2737
2012-06-14 15:12:54 +02:00
'uri' => '/res/c0b9e53f/rsrc/js/application/aphlict/Aphlict.js',
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
'disk' => '/rsrc/js/application/aphlict/Aphlict.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior' =>
array(
Indicate buttons disabled in JX.Workflow Summary: We are marking disabled buttons with 'disabled' class in `behavior-form`. But we ignore `JX.Workflow` there because it has its own handling. But this handling doesn't set class so the button is disabled but it is not indicated to user. It causes troubles in Clowncopterize where users report that browser freezes before doing anything after clicking it. It probably happens also on other places. This diff solves it by using CSS3 selector on attribute (contrary to explicitly setting class in JX.Workflow). Test Plan: Add `sleep(3)` to `DifferentialCommentSaveController`. Clowncopterize empty comment. Reviewers: epriestley, tuomaspelkonen Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2264
2012-04-18 07:04:54 +02:00
'uri' => '/res/ef4eda09/rsrc/js/javelin/lib/behavior.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-magical-init',
),
'disk' => '/rsrc/js/javelin/lib/behavior.js',
),
Adds the UI dropdown panel Summary: Add a dropdown to display notificaitons. Right now there is nothing real time about it, but we do update the panel when the user clicks. This panel is only displayed if the install has notifications enabled and you have them enabled in your preferences (not using them by default). Test Plan: Turn off notifications for user1, left them on for user2. Did things from user1 and from user2 on task both were cc'd on. user2 recieved all notifications, user1 recieved nothing. Made new user, made sure everything was switched off by default. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: keebuhm, ddfisher, aran, Korvin Differential Revision: https://secure.phabricator.com/D2703
2012-06-11 18:37:06 +02:00
'javelin-behavior-aphlict-dropdown' =>
array(
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
'uri' => '/res/2418f448/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js',
Adds the UI dropdown panel Summary: Add a dropdown to display notificaitons. Right now there is nothing real time about it, but we do update the panel when the user clicks. This panel is only displayed if the install has notifications enabled and you have them enabled in your preferences (not using them by default). Test Plan: Turn off notifications for user1, left them on for user2. Did things from user1 and from user2 on task both were cc'd on. user2 recieved all notifications, user1 recieved nothing. Made new user, made sure everything was switched off by default. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: keebuhm, ddfisher, aran, Korvin Differential Revision: https://secure.phabricator.com/D2703
2012-06-11 18:37:06 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Apply AMAZING DESIGN SKILLS to notification menu Summary: I am a fancy designer! {F12665} {F12666} Test Plan: Opened/closed menu. Viewed with-notification-count and without-notification count states. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, chad, joe Maniphest Tasks: T974 Differential Revision: https://secure.phabricator.com/D2735
2012-06-14 15:13:53 +02:00
1 => 'javelin-request',
2 => 'javelin-stratcom',
3 => 'javelin-vector',
4 => 'javelin-dom',
Improve style of notifications Summary: - Gets about 25% of the way toward @chad's notification mocks. - YES: Hover states, entire notification is a click target, border, header, footer. - NO: Profile pictures (lazy), timestamps (want to refactor time code before introducing a new formatting style), app icons (they'd look funny without timestamps I think) - Deletes some old files. - Mostly trying to get this good enough to turn on by default. Test Plan: Looked at notifications. Clicked some notifications. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D4119
2012-12-08 01:26:43 +01:00
5 => 'javelin-uri',
Adds the UI dropdown panel Summary: Add a dropdown to display notificaitons. Right now there is nothing real time about it, but we do update the panel when the user clicks. This panel is only displayed if the install has notifications enabled and you have them enabled in your preferences (not using them by default). Test Plan: Turn off notifications for user1, left them on for user2. Did things from user1 and from user2 on task both were cc'd on. user2 recieved all notifications, user1 recieved nothing. Made new user, made sure everything was switched off by default. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: keebuhm, ddfisher, aran, Korvin Differential Revision: https://secure.phabricator.com/D2703
2012-06-11 18:37:06 +02:00
),
'disk' => '/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js',
),
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
'javelin-behavior-aphlict-listen' =>
array(
Improve the implementation of Notifications Summary: Currently, you can't change a notification that's already shown. There's no reason for this. (I'm planning to put file upload progress/errors in notifications.) - Make `setContent()` and `setDuration()` immediately affect the notification. - When there are more than 5 notifications, queue them up instead of dropping them. - Allow arbitrarily many classes to be added/removed. - Make the examples in the UIExamples tests more rich. Test Plan: - Verified normal notifications continue to function as expected. - Played with the UIExamples notifications: - Verified the "update every second" notification udpated every second. - Verified the permanent alert notification was yellow and requires a click to dismiss. - Verified the interactive notification responds correctly to "OK" / "Cancel". - Verified the "click every 2 seconds" notification doesn't vanish until not clicked for 2 seconds. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3653
2012-10-09 00:22:29 +02:00
'uri' => '/res/6dde3f43/rsrc/js/application/aphlict/behavior-aphlict-listen.js',
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-aphlict',
Show only one "reload" popup, use 'alert' style, click to reload Summary: Use the features from D2758. Test Plan: Updated T1 with two browser windows pointing at it, verified reload appeared, only one reload, and it appeared with 'alert' style. Reviewers: jungejason, vrana Reviewed By: jungejason CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2781
2012-06-18 23:07:45 +02:00
2 => 'javelin-stratcom',
3 => 'javelin-request',
4 => 'javelin-uri',
5 => 'javelin-dom',
Improve debug support for notifications Summary: Add a `notification.debug` setting that shows debug info in the browser. Also improve some logging/error handling stuff and fix a bug with host names. Test Plan: {F13098} Reviewers: jungejason, btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2810
2012-06-20 22:20:47 +02:00
6 => 'javelin-json',
7 => 'phabricator-notification',
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
),
'disk' => '/rsrc/js/application/aphlict/behavior-aphlict-listen.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-aphront-basic-tokenizer' =>
array(
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'uri' => '/res/22db5a80/rsrc/js/application/core/behavior-tokenizer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
1 => 'phabricator-prefab',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-tokenizer.js',
),
Merge branch 'master' into phutil_tag (Sync.)
2013-02-07 17:08:01 +01:00
'javelin-behavior-aphront-crop' =>
array(
'uri' => '/res/cda1eace/rsrc/js/application/core/behavior-crop.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-vector',
3 => 'javelin-magical-init',
),
'disk' => '/rsrc/js/application/core/behavior-crop.js',
),
Add "buoyant" headers to Differential Summary: As you scroll through a diff, add a fixed-position header to the top of the document to provide context. This is particularly useful with keyboard navigation. The technical implementation is that we seed the document with invisible markers. When the user scrolls past one, we show a header with that text until they scroll past another. Test Plan: Scrolled through a revision, was presented with context. https://secure.phabricator.com/file/data/5xhh2jmoon6ukr5qjkh3/PHID-FILE-463ituscyhyw7utnox7m/Screen_Shot_2012-02-22_at_2.48.19_PM.png Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T696 Differential Revision: https://secure.phabricator.com/D1673
2012-02-23 21:26:14 +01:00
'javelin-behavior-aphront-drag-and-drop' =>
array(
Update mobile menu icons Summary: Simplify the look of the mobile menu, provide active states for the menu icons. Test Plan: iOS Simulator and Chrome. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2426 Differential Revision: https://secure.phabricator.com/D5189
2013-03-03 17:17:57 +01:00
'uri' => '/res/8dd5fd78/rsrc/js/application/core/behavior-drag-and-drop.js',
Add "buoyant" headers to Differential Summary: As you scroll through a diff, add a fixed-position header to the top of the document to provide context. This is particularly useful with keyboard navigation. The technical implementation is that we seed the document with invisible markers. When the user scrolls past one, we show a header with that text until they scroll past another. Test Plan: Scrolled through a revision, was presented with context. https://secure.phabricator.com/file/data/5xhh2jmoon6ukr5qjkh3/PHID-FILE-463ituscyhyw7utnox7m/Screen_Shot_2012-02-22_at_2.48.19_PM.png Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T696 Differential Revision: https://secure.phabricator.com/D1673
2012-02-23 21:26:14 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Conpherence - make updating title + picture a dialogue that uses drag and drop upload control Summary: decent title. Stylistically its probably a bit rough. Also, I think @chad describes an even hotter workflow in T2418. Note this removes the "default image" thing which I don't think makes sense conceptually since by default the image changes to who replied last... Test Plan: uploaded an image - worked. uploaded a txt file - got ugly errors that file was not supported. Reviewers: epriestley, chad Reviewed By: chad CC: aran, Korvin Maniphest Tasks: T2417 Differential Revision: https://secure.phabricator.com/D4668
2013-01-27 02:14:58 +01:00
2 => 'phabricator-file-upload',
3 => 'phabricator-drag-and-drop-file-upload',
Add "buoyant" headers to Differential Summary: As you scroll through a diff, add a fixed-position header to the top of the document to provide context. This is particularly useful with keyboard navigation. The technical implementation is that we seed the document with invisible markers. When the user scrolls past one, we show a header with that text until they scroll past another. Test Plan: Scrolled through a revision, was presented with context. https://secure.phabricator.com/file/data/5xhh2jmoon6ukr5qjkh3/PHID-FILE-463ituscyhyw7utnox7m/Screen_Shot_2012-02-22_at_2.48.19_PM.png Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T696 Differential Revision: https://secure.phabricator.com/D1673
2012-02-23 21:26:14 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-drag-and-drop.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-aphront-drag-and-drop-textarea' =>
array(
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
'uri' => '/res/326d6c1c/rsrc/js/application/core/behavior-drag-and-drop-textarea.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'phabricator-drag-and-drop-file-upload',
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
3 => 'phabricator-textareautils',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-drag-and-drop-textarea.js',
),
'javelin-behavior-aphront-form-disable-on-submit' =>
array(
Minor, fix celerity map.
2013-04-01 05:07:47 +02:00
'uri' => '/res/f5a60aec/rsrc/js/application/core/behavior-form.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-form.js',
),
Show "show more..." link in "Local Commits" view in Differential Summary: Javascript! Depends on D2437 to do anything useful. Test Plan: Clicked "show more", saw more. Reviewers: csilvers, btrahan Reviewed By: csilvers CC: aran Maniphest Tasks: T1189 Differential Revision: https://secure.phabricator.com/D2438
2012-05-10 00:56:37 +02:00
'javelin-behavior-aphront-more' =>
array(
'uri' => '/res/9ad83c3c/rsrc/js/application/core/behavior-more.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-more.js',
),
Add preview and drafts to audits Summary: Add comment previews and saved drafts to audits, like Maniphest / Differential. Test Plan: Typed stuff into the box. Got a preview. Reloaded page. Stuff was still there. Submitted comment. Stuff is gone. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1699
2012-02-27 22:00:23 +01:00
'javelin-behavior-audit-preview' =>
array(
'uri' => '/res/3048b073/rsrc/js/application/diffusion/behavior-audit-preview.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/diffusion/behavior-audit-preview.js',
),
Merge branch 'master' into phutil_tag (Sync.)
2013-02-07 17:08:01 +01:00
'javelin-behavior-conpherence-drag-and-drop-photo' =>
array(
'uri' => '/res/9e3eb1cd/rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-workflow',
3 => 'phabricator-drag-and-drop-file-upload',
),
'disk' => '/rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js',
),
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'javelin-behavior-conpherence-menu' =>
array(
Conpherence - fix JS and add code to repair old bad data Summary: the JS is fragile with respect to the tokenizer coming in from the people widget. make sure to always try to load this up. Note this generally needs to get cleaned up where the server should only send down the *exact* bits the client needs. This is all TODO as part of getting this on mobile perfectly. Also note this fragility exists still in that you can break conpherence by clicking quickly before the initial tokenizer load loads. For old bad data, at some point we weren't updating participation as well as we do today in the editor class. the result is with the migration and code change some conversation participants have bad "last seen message" counts. the simplest case is the test user talking to themselves -- threads before the editor code fixes / changes will have the entire thread as unread for these folks. The other buggy case I saw was where the "last reply" to a thread wasn't being count. These issues showed up for threads February and older which is old. Test Plan: edited conpherence meta data and no JS bugs. pontificated and no JS bugs. added a person and no JS bugs. Reviewers: chad, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5622
2013-04-08 22:41:34 +02:00
'uri' => '/res/257f200d/rsrc/js/application/conpherence/behavior-menu.js',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Conpherence - fix JS and add code to repair old bad data Summary: the JS is fragile with respect to the tokenizer coming in from the people widget. make sure to always try to load this up. Note this generally needs to get cleaned up where the server should only send down the *exact* bits the client needs. This is all TODO as part of getting this on mobile perfectly. Also note this fragility exists still in that you can break conpherence by clicking quickly before the initial tokenizer load loads. For old bad data, at some point we weren't updating participation as well as we do today in the editor class. the result is with the migration and code change some conversation participants have bad "last seen message" counts. the simplest case is the test user talking to themselves -- threads before the editor code fixes / changes will have the entire thread as unread for these folks. The other buggy case I saw was where the "last reply" to a thread wasn't being count. These issues showed up for threads February and older which is old. Test Plan: edited conpherence meta data and no JS bugs. pontificated and no JS bugs. added a person and no JS bugs. Reviewers: chad, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5622
2013-04-08 22:41:34 +02:00
2 => 'javelin-util',
3 => 'javelin-request',
4 => 'javelin-stratcom',
5 => 'javelin-workflow',
6 => 'javelin-behavior-device',
7 => 'javelin-history',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
),
'disk' => '/rsrc/js/application/conpherence/behavior-menu.js',
),
Conpherence - make pontificate be all ajaxy Summary: serving up for some feedback -- does anything fancy need to happen when new messages load (say highlight em and fade the highlight out) or just scrolling down okay? in JS I have a TODO about how come it doesn't work; that code works okay in my console if I print out various debugging values and enter them in manually. Test Plan: pontificate with myself; note new message and message entry updates properly. pontificate as different user then as myself; note two messages load and message entry updates properly. pontificate as a user who isn't the last to reply; note new message and message entry updates properly Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2522 Differential Revision: https://secure.phabricator.com/D5214
2013-03-06 00:45:36 +01:00
'javelin-behavior-conpherence-pontificate' =>
array(
Conpherence - fix JS and add code to repair old bad data Summary: the JS is fragile with respect to the tokenizer coming in from the people widget. make sure to always try to load this up. Note this generally needs to get cleaned up where the server should only send down the *exact* bits the client needs. This is all TODO as part of getting this on mobile perfectly. Also note this fragility exists still in that you can break conpherence by clicking quickly before the initial tokenizer load loads. For old bad data, at some point we weren't updating participation as well as we do today in the editor class. the result is with the migration and code change some conversation participants have bad "last seen message" counts. the simplest case is the test user talking to themselves -- threads before the editor code fixes / changes will have the entire thread as unread for these folks. The other buggy case I saw was where the "last reply" to a thread wasn't being count. These issues showed up for threads February and older which is old. Test Plan: edited conpherence meta data and no JS bugs. pontificated and no JS bugs. added a person and no JS bugs. Reviewers: chad, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5622
2013-04-08 22:41:34 +02:00
'uri' => '/res/91d6418d/rsrc/js/application/conpherence/behavior-pontificate.js',
Conpherence - make pontificate be all ajaxy Summary: serving up for some feedback -- does anything fancy need to happen when new messages load (say highlight em and fade the highlight out) or just scrolling down okay? in JS I have a TODO about how come it doesn't work; that code works okay in my console if I print out various debugging values and enter them in manually. Test Plan: pontificate with myself; note new message and message entry updates properly. pontificate as different user then as myself; note two messages load and message entry updates properly. pontificate as a user who isn't the last to reply; note new message and message entry updates properly Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2522 Differential Revision: https://secure.phabricator.com/D5214
2013-03-06 00:45:36 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Add support for device swipe events Summary: Ref T2700. Allow JS to listen for swipes on devices. There are a bunch of tricky cases here and I probably didn't get them all totally right, but this interaction broadly looks like this: - We implement gesture recognition for the mouse in device modes (narrow browser), and for touch events from an actual device. - The sigil `touchable` indicates that a node wants to react to touch events. - When the user touches a `touchable` node, we start listening for moves. They might be tapping/clicking (in which case we don't care), but they might also be gesturing. - Once the user moves their finger/pointer far enough away from the tap origin, we recognize it as a gesture. I hardcoded this at 20px; I wasn't able to find any "official" Apple value, but 20px seems like a common default. - At this point, we look at where their finger has moved. - If they moved it mostly up/down, we interpret the gesture as "scroll" and just stop listening. The device does its own thing. - However, if they moved it mostly left/right, we interpret it as a "swipe". We start killing the moves so the device doesn't scroll. - Once we've recognized that a gesture is underway, we send a "gesture.swipe.start" event and then "gesture.swipe.move" events for every move. - When the user ends the gesture, we send "gesture.swipe.end". - If the user cancels the gesture (currently, only by tapping with a second finger), we send "gesture.swipe.cancel". - Gesture events have raw position data and some convenience fields. Test Plan: Wrote UI example and used it from the Desktop, iPhone simulator, and a real iphone. - The code always seems to get "scroll" vs "swipe" correct (i.e., consistent with my intentions). - The threshold feels pretty good to me. - Tapping with a second finger cancels the action. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T2700 Differential Revision: https://secure.phabricator.com/D5308
2013-03-09 22:53:15 +01:00
2 => 'javelin-util',
3 => 'javelin-workflow',
Decrease fragility of `conpherence-pontificate` behavior Summary: Currently, this behavior binds a ton of IDs. This makes the behavior fragile: if it is invoked on a page without all the right elements, some `JX.$()` tends to explode. Instead, don't assume anything is present on the page. This allows the behavior to be invoked on other pages (like the "New Conpherence" page) or pages without some elements (like some future thread-only mobile view) without creating JS errors. Test Plan: Added comments, added comments with files. Viewed "New conphenrece" page. NOTE: Control+Enter is currently broken, but this diff didn't change that behavior. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5468
2013-03-31 23:41:13 +02:00
4 => 'javelin-stratcom',
Conpherence - make pontificate be all ajaxy Summary: serving up for some feedback -- does anything fancy need to happen when new messages load (say highlight em and fade the highlight out) or just scrolling down okay? in JS I have a TODO about how come it doesn't work; that code works okay in my console if I print out various debugging values and enter them in manually. Test Plan: pontificate with myself; note new message and message entry updates properly. pontificate as different user then as myself; note two messages load and message entry updates properly. pontificate as a user who isn't the last to reply; note new message and message entry updates properly Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2522 Differential Revision: https://secure.phabricator.com/D5214
2013-03-06 00:45:36 +01:00
),
'disk' => '/rsrc/js/application/conpherence/behavior-pontificate.js',
),
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'javelin-behavior-conpherence-widget-pane' =>
array(
Conpherence - make conpherence load the bare minimum of data Summary: also re-enables the updating of the widgets and "cleans up" the javascript a tad. Ref T2867 Test Plan: all sorts of conpherence fun like adding people to threads, adding files, pontificating, etc Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2867 Differential Revision: https://secure.phabricator.com/D5595
2013-04-08 20:13:35 +02:00
'uri' => '/res/0c0fc5ef/rsrc/js/application/conpherence/behavior-widget-pane.js',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
Conpherence - add per thread notification setting Summary: Introduces a new settings panel for Conpherence specific settings. Test Plan: started a thread with a test user, thus two participants total. Replied to conpherence, toggling notification settings in between. Verified 1 or 2 emails were sent as appropos to the current toggle. Toggled global setting and verified setting was updated in conpherences where nothing was specified. Verified setting conpherence setting overrides global setting. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2521 Differential Revision: https://secure.phabricator.com/D5391
2013-03-26 21:30:35 +01:00
3 => 'javelin-workflow',
4 => 'javelin-util',
5 => 'phabricator-notification',
Conpherence V1 Summary: it's ugly. but it works. basically. See T2399 for a roughly prioritized list of what still needs to happen. Test Plan: - created a conpherence with myself from my profile - created a conpherence with myself from "new conpherence" - created a conphernece with another from "new conpherence" - created a conpherence with several others - created a conpherence with files in the initial post - verified files via comment text ("{F232} is awesome!") and via traditional attach - edited a conpherence image - verified it showed up in the header and in the conpherence menu on the left - edited a conpherence title - verified it showed up in the header and in the conpherence menu on the right - verified each widget showed up when clicked and displayed the proper data - calendar being an exception since it sucks so hard right now. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, epriestley, chad, codeblock, Korvin Maniphest Tasks: T2301 Differential Revision: https://secure.phabricator.com/D4620
2013-01-25 02:23:05 +01:00
),
'disk' => '/rsrc/js/application/conpherence/behavior-widget-pane.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-countdown-timer' =>
array(
Make countdowns (internally) embeddable Summary: You can now embed countdowns in Remarkup! Not sure what it's useful for, but there you have it. Also I may have made a hash of the markup code; I don't really know what I'm doing. Test Plan: Make a new countdown, put `{C###}` in a Differential comment. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1053 Differential Revision: https://secure.phabricator.com/D3290
2012-08-15 04:19:23 +02:00
'uri' => '/res/7468acb7/rsrc/js/application/countdown/timer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
),
'disk' => '/rsrc/js/application/countdown/timer.js',
),
'javelin-behavior-dark-console' =>
array(
When a page is profiled, profile all AJAX requests too Summary: If a page is profiled, add an "X-Phabricator-Profiler" header to all Ajax requests, and profile those too. Test Plan: Profiled a page, checked Darkconsole, saw profiles for everything. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4885
2013-02-09 22:29:47 +01:00
'uri' => '/res/89aeb6c0/rsrc/js/application/core/behavior-dark-console.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-request',
5 => 'phabricator-keyboard-shortcut',
),
'disk' => '/rsrc/js/application/core/behavior-dark-console.js',
),
Add "device" JS/CSS for reactive stuff Summary: As we work through @chad's redesign, one thing I want to do is improve the tablet/mobile experience. Add a "device" behavior which sets a "device-phone", "device-tablet" or "device-desktop" class on the root div. The behavior (device names, width triggers) is mostly based on Bootstrap. Also adds a preview viewport=meta tag, which makes the iPhone not scale the page like crazy and is a desirable end state, but currently makes the app less usable since things get cut off. Test Plan: Added some classes like this: .device-desktop { background: blue; } .device-tablet { background: orange; } .device-phone { background: yellow; } ...and loaded the site on a desktop, iPad and iPhone. Resized the window. Got the right background color in all cases. Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D3063
2012-07-25 20:51:27 +02:00
'javelin-behavior-device' =>
array(
Minor, update Celerity map.
2013-01-15 00:44:16 +01:00
'uri' => '/res/a10b851b/rsrc/js/application/core/behavior-device.js',
Add "device" JS/CSS for reactive stuff Summary: As we work through @chad's redesign, one thing I want to do is improve the tablet/mobile experience. Add a "device" behavior which sets a "device-phone", "device-tablet" or "device-desktop" class on the root div. The behavior (device names, width triggers) is mostly based on Bootstrap. Also adds a preview viewport=meta tag, which makes the iPhone not scale the page like crazy and is a desirable end state, but currently makes the app less usable since things get cut off. Test Plan: Added some classes like this: .device-desktop { background: blue; } .device-tablet { background: orange; } .device-phone { background: yellow; } ...and loaded the site on a desktop, iPad and iPhone. Resized the window. Got the right background color in all cases. Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D3063
2012-07-25 20:51:27 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-vector',
Make the top nav non-fixed-position Summary: See some discussion in D1673. - There's a concrete (if minor) problem with this in Firefox with wrapping search. - People complain about how we're stealing all their pixels. - There isn't much of a functional purpose to it since all the operations are fairly rare. - This addresses the aesthetic purpose of the fixed-position nav (not making the side nav ugly) by making the side nav scroll up 44px and then stop. Test Plan: Scrolled in desktop, tablet modes. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3412
2012-08-31 03:58:51 +02:00
4 => 'javelin-install',
Add "device" JS/CSS for reactive stuff Summary: As we work through @chad's redesign, one thing I want to do is improve the tablet/mobile experience. Add a "device" behavior which sets a "device-phone", "device-tablet" or "device-desktop" class on the root div. The behavior (device names, width triggers) is mostly based on Bootstrap. Also adds a preview viewport=meta tag, which makes the iPhone not scale the page like crazy and is a desirable end state, but currently makes the app less usable since things get cut off. Test Plan: Added some classes like this: .device-desktop { background: blue; } .device-tablet { background: orange; } .device-phone { background: yellow; } ...and loaded the site on a desktop, iPad and iPhone. Resized the window. Got the right background color in all cases. Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D3063
2012-07-25 20:51:27 +02:00
),
'disk' => '/rsrc/js/application/core/behavior-device.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-differential-accept-with-errors' =>
array(
Make all of Drydock work on Mobile Summary: This is probably not the most useful app to have work on mobile, but get the log view to do something fairly sensible. Test Plan: Looked at all Drydock views in mobile. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2015 Differential Revision: https://secure.phabricator.com/D4224
2012-12-18 00:16:44 +01:00
'uri' => '/res/8fea67b3/rsrc/js/application/differential/behavior-accept-with-errors.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-accept-with-errors.js',
),
'javelin-behavior-differential-add-reviewers-and-ccs' =>
array(
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'uri' => '/res/27be3f81/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
2 => 'phabricator-prefab',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js',
),
'javelin-behavior-differential-comment-jump' =>
array(
Update Celerity map
2012-06-14 07:47:46 +02:00
'uri' => '/res/b580229b/rsrc/js/application/differential/behavior-comment-jump.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-util',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-comment-jump.js',
),
'javelin-behavior-differential-diff-radios' =>
array(
'uri' => '/res/004cb66f/rsrc/js/application/differential/behavior-diff-radios.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-diff-radios.js',
),
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'javelin-behavior-differential-dropdown-menus' =>
array(
Minor, celerity map update.
2012-08-10 21:13:22 +02:00
'uri' => '/res/752f5dfc/rsrc/js/application/differential/behavior-dropdown-menus.js',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Add a link from Differential to Diffusion Summary: Provide an easy way to jump to Diffusion from Differential if we have the data we need to connect them. Test Plan: Tested menu in linked and unlinked diffs. Used menu item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley, btrahan Maniphest Tasks: T309 Differential Revision: https://secure.phabricator.com/D1326
2012-01-05 23:41:11 +01:00
2 => 'javelin-util',
3 => 'javelin-stratcom',
4 => 'phabricator-dropdown-menu',
5 => 'phabricator-menu-item',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
),
'disk' => '/rsrc/js/application/differential/behavior-dropdown-menus.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-differential-edit-inline-comments' =>
array(
Enable zooming text in Chrome Test Plan: Zoomed in Chrome. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1664 Differential Revision: https://secure.phabricator.com/D3310
2012-08-16 17:33:47 +02:00
'uri' => '/res/70c1f3a3/rsrc/js/application/differential/behavior-edit-inline-comments.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-util',
4 => 'javelin-vector',
5 => 'differential-inline-comment-editor',
),
'disk' => '/rsrc/js/application/differential/behavior-edit-inline-comments.js',
),
'javelin-behavior-differential-feedback-preview' =>
array(
Handle error in comment preview Test Plan: Triggered error in comment preview (see D3589), verified that the error is displayed. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3586
2012-10-01 23:56:57 +02:00
'uri' => '/res/5fbce8db/rsrc/js/application/differential/behavior-comment-preview.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-request',
4 => 'javelin-util',
5 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/differential/behavior-comment-preview.js',
),
'javelin-behavior-differential-keyboard-navigation' =>
array(
Minor, fix celerity map.
2013-02-06 17:32:36 +01:00
'uri' => '/res/89e93cc9/rsrc/js/application/differential/behavior-keyboard-nav.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Add more keyboard navigation options for inline comments Summary: - Use n/p to jump between comments. - Use r to reply to the selected comment. - Use e to edit the selected comment. Test Plan: Verified n, p, r, e, j, k, J, K, "click edit" and "click reply" behavior in as many weird cases as I could come up with. Reviewers: btrahan, jungejason, nh, cpiro, jl Reviewed By: btrahan CC: aran, btrahan, epriestley Maniphest Tasks: T583 Differential Revision: https://secure.phabricator.com/D1308
2012-01-04 17:21:22 +01:00
2 => 'javelin-stratcom',
3 => 'phabricator-keyboard-shortcut',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/differential/behavior-keyboard-nav.js',
),
'javelin-behavior-differential-populate' =>
array(
Stabilize scroll position as diffs load Summary: Try to lock the screen to whatever the user is looking at as we load changesets. Notably, this improves the use case of taking a known action on a diff. Currently, you have to wait for everything to load or the comments keep getting scrolled down. After this change, the comments stay in the same place on screen. Test Plan: Raised the autoload changeset limit from 100 to 1000, looked at a 220 changeset diff. - Reloaded it while scrolled at the top; normal behavior (no scrolling). - Reloaded it, scrolled to the bottom. Comment area now stable. - Reloaded it, kind of scrolled around the middle? Behavior seemed stable/reasonable. This one is kind of heursitic so it's hard to say I'm getting it totally right or not, but it's less important than the "bottom" case. Reviewers: vrana, btrahan, chad, dctrwatson Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D4774
2013-02-01 19:52:07 +01:00
'uri' => '/res/526c2615/rsrc/js/application/differential/behavior-populate.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-workflow',
2 => 'javelin-util',
3 => 'javelin-dom',
Show a tooltip about code coverage Summary: - Show a tip in the margin about what coverage colors mean. - Highlight the line when mousing over coverage. - Randomly change the colors to different colors. - Fix a bug with "show more" that I introduced with the other coverage diff (oops!) Test Plan: Moused over coverage things. Reviewers: tuomaspelkonen, btrahan Reviewed By: tuomaspelkonen CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1874
2012-03-13 04:04:12 +01:00
4 => 'javelin-stratcom',
Minor, update Celerity map.
2013-01-15 00:44:16 +01:00
5 => 'javelin-behavior-device',
Stabilize scroll position as diffs load Summary: Try to lock the screen to whatever the user is looking at as we load changesets. Notably, this improves the use case of taking a known action on a diff. Currently, you have to wait for everything to load or the comments keep getting scrolled down. After this change, the comments stay in the same place on screen. Test Plan: Raised the autoload changeset limit from 100 to 1000, looked at a 220 changeset diff. - Reloaded it while scrolled at the top; normal behavior (no scrolling). - Reloaded it, scrolled to the bottom. Comment area now stable. - Reloaded it, kind of scrolled around the middle? Behavior seemed stable/reasonable. This one is kind of heursitic so it's hard to say I'm getting it totally right or not, but it's less important than the "bottom" case. Reviewers: vrana, btrahan, chad, dctrwatson Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D4774
2013-02-01 19:52:07 +01:00
6 => 'javelin-vector',
7 => 'phabricator-tooltip',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/differential/behavior-populate.js',
),
'javelin-behavior-differential-show-all-comments' =>
array(
Go to correct position after revealing comments Test Plan: Go to revision with lots of comments in Firefox. Click on one of the last three comments permalink. Repeat in Chrome. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1702
2012-02-26 12:54:17 +01:00
'uri' => '/res/eaa12efc/rsrc/js/application/differential/behavior-show-all-comments.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-show-all-comments.js',
),
Hide lint and unit error details Summary: Before: {F10754} After: {F10753} Test Plan: View revision with lint warnings and unit errors. Click on Details. Click on Details. Click on Details. Click on Details. Reviewers: asukhachev, epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2351
2012-05-01 01:08:01 +02:00
'javelin-behavior-differential-show-field-details' =>
array(
Further improve unit/lint rendering Summary: I think this improves things, let me know if you have feedback. Also addresses T840. Test Plan: See screenshots... Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, zeeg Maniphest Tasks: T840 Differential Revision: https://secure.phabricator.com/D2357
2012-05-01 19:15:56 +02:00
'uri' => '/res/8d57f459/rsrc/js/application/differential/behavior-show-field-details.js',
Hide lint and unit error details Summary: Before: {F10754} After: {F10753} Test Plan: View revision with lint warnings and unit errors. Click on Details. Click on Details. Click on Details. Click on Details. Reviewers: asukhachev, epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2351
2012-05-01 01:08:01 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-show-field-details.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-differential-show-more' =>
array(
Dark sidebar everywhere Summary: First pass at testing out a dark sidebar everywhere. Wanting feedback with real test time before implementing before commiting. Thoughts - Aligns with Mobile, Tablet UI experience. - Creates 'application' feel on Desktop. - Begins to make Phabricator feel like a branded UI. Cons - Probably contensious visually. TODO: - Update diff view sidebar. - Make breadcrumbs appear above content area, not above nav. - Change background texture on crumbs to match table headers. Test Plan: Testing Nav with fellow co-workers. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4427
2013-01-14 22:40:51 +01:00
'uri' => '/res/b9f93090/rsrc/js/application/differential/behavior-show-more.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-workflow',
3 => 'javelin-util',
4 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/differential/behavior-show-more.js',
),
Update Celerity map
2012-06-14 07:47:46 +02:00
'javelin-behavior-differential-toggle-files' =>
array(
Minor: Make the Matrix characters backwards as they should be.
2012-08-24 18:36:40 +02:00
'uri' => '/res/ae937207/rsrc/js/application/differential/behavior-toggle-files.js',
Update Celerity map
2012-06-14 07:47:46 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/differential/behavior-toggle-files.js',
),
Hide selection to provide a visual cue about clipboard JS magic in Differential Summary: Inspired by D2242. Test Plan: Select text in left pane. Select text in right pane. Select all. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2249
2012-04-17 03:53:38 +02:00
'javelin-behavior-differential-user-select' =>
array(
Update Celerity map.
2012-09-24 22:56:04 +02:00
'uri' => '/res/23c51a5d/rsrc/js/application/differential/behavior-user-select.js',
Hide selection to provide a visual cue about clipboard JS magic in Differential Summary: Inspired by D2242. Test Plan: Select text in left pane. Select text in right pane. Select all. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2249
2012-04-17 03:53:38 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/differential/behavior-user-select.js',
),
Load commit branches and tags by AJAX Summary: Each query takes over 2 seconds in FBCODE. I didn't find a way how to speed them up. There's also no easy way how to parallelize them at least. So AJAX is the last instance. Test Plan: Loaded commit with one branch and no tag. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3112
2012-08-01 01:27:48 +02:00
'javelin-behavior-diffusion-commit-branches' =>
array(
Remove placeholder Summary: See discussion in D3103. We don't need this for now; if we do in the future we should probably use an alternate implementation. Test Plan: Grepped for 'placeholder', viewed UI examples. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3115
2012-08-01 03:28:08 +02:00
'uri' => '/res/1ede335a/rsrc/js/application/diffusion/behavior-commit-branches.js',
Load commit branches and tags by AJAX Summary: Each query takes over 2 seconds in FBCODE. I didn't find a way how to speed them up. There's also no easy way how to parallelize them at least. So AJAX is the last instance. Test Plan: Loaded commit with one branch and no tag. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3112
2012-08-01 01:27:48 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'javelin-request',
),
'disk' => '/rsrc/js/application/diffusion/behavior-commit-branches.js',
),
Render pretty graphical traces for commit branches, etc Summary: I AM A WIZARD Test Plan: BEHOLD Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T961 Differential Revision: https://secure.phabricator.com/D2007
2012-03-24 01:11:15 +01:00
'javelin-behavior-diffusion-commit-graph' =>
array(
Update tables to table-kit view. Summary: Reskinning tables to table-kit mocks, which includes new textures, spacing, slightly larger fonts. Looking for early feedback before adding in new row colors and other items into the class. Test Plan: http://phab1.pushlabs.net/uiexample/view/PhabricatorSortTableExample/ Reviewers: btrahan, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4396
2013-01-11 20:24:35 +01:00
'uri' => '/res/62bd2035/rsrc/js/application/diffusion/behavior-commit-graph.js',
Render pretty graphical traces for commit branches, etc Summary: I AM A WIZARD Test Plan: BEHOLD Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T961 Differential Revision: https://secure.phabricator.com/D2007
2012-03-24 01:11:15 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/diffusion/behavior-commit-graph.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-diffusion-jump-to' =>
array(
'uri' => '/res/7c42e1ba/rsrc/js/application/diffusion/behavior-jump-to.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-util',
2 => 'javelin-vector',
3 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/diffusion/behavior-jump-to.js',
),
Highlight lines on drag and drop in Diffusion Summary: Nobody knows that it's possible to highlight more lines because there's no interface for it. Test Plan: Highlighted: - single line - top to bottom - bottom to top - inside to outside Reviewers: Korvin, epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D3150
2012-08-04 18:47:51 +02:00
'javelin-behavior-diffusion-line-linker' =>
array(
Minor, update celerity map.
2013-03-05 00:03:54 +01:00
'uri' => '/res/12866f13/rsrc/js/application/diffusion/behavior-line-linker.js',
Highlight lines on drag and drop in Diffusion Summary: Nobody knows that it's possible to highlight more lines because there's no interface for it. Test Plan: Highlighted: - single line - top to bottom - bottom to top - inside to outside Reviewers: Korvin, epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D3150
2012-08-04 18:47:51 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
Minor, update celerity map.
2013-03-05 00:03:54 +01:00
3 => 'javelin-history',
Highlight lines on drag and drop in Diffusion Summary: Nobody knows that it's possible to highlight more lines because there's no interface for it. Test Plan: Highlighted: - single line - top to bottom - bottom to top - inside to outside Reviewers: Korvin, epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D3150
2012-08-04 18:47:51 +02:00
),
'disk' => '/rsrc/js/application/diffusion/behavior-line-linker.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-diffusion-pull-lastmodified' =>
array(
'uri' => '/res/29fe2790/rsrc/js/application/diffusion/behavior-pull-lastmodified.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'javelin-request',
),
'disk' => '/rsrc/js/application/diffusion/behavior-pull-lastmodified.js',
),
'javelin-behavior-error-log' =>
array(
Allow opening editor from DarkConsole error log Test Plan: Click on "passing a null index to idx()" in DarkConsole. Click on entry in stack trace. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2275
2012-04-18 21:50:06 +02:00
'uri' => '/res/f46289e9/rsrc/js/application/core/behavior-error-log.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-error-log.js',
),
Add a datepicker control Summary: I looooove JS! It makes me giddy with glee! Test Plan: Picked dates. See screenshots. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2086
2012-04-04 21:14:10 +02:00
'javelin-behavior-fancy-datepicker' =>
array(
Let datepicker jump one month forward Test Plan: Clicked on next month, didn't see year 20121. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4277
2012-12-22 01:34:35 +01:00
'uri' => '/res/0a1bc610/rsrc/js/application/core/behavior-fancy-datepicker.js',
Add a datepicker control Summary: I looooove JS! It makes me giddy with glee! Test Plan: Picked dates. See screenshots. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2086
2012-04-04 21:14:10 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-util',
2 => 'javelin-dom',
Minor, move dialogs above masks.
2012-10-23 21:07:08 +02:00
3 => 'javelin-stratcom',
4 => 'javelin-vector',
Add a datepicker control Summary: I looooove JS! It makes me giddy with glee! Test Plan: Picked dates. See screenshots. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2086
2012-04-04 21:14:10 +02:00
),
'disk' => '/rsrc/js/application/core/behavior-fancy-datepicker.js',
),
Modernize file uploads Summary: Modernizes file uploads. In particular: - Adds a mobile menu, with an "Upload File" item. - Adds crumbs to the list view, detail view and upload view. - Adds "Upload File" action to crumbs. - Moves upload file to a separate page. - Removes the combined upload file + recent files page. - Makes upload file use a normal file control by default (works on mobile). - Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message. - User education on this is a little weak but I think that's a big can of worms? - Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190). T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general. @chad, do we have an "upload" icon (counterpart to "download")? Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2190 Differential Revision: https://secure.phabricator.com/D4200
2012-12-17 01:34:01 +01:00
'javelin-behavior-global-drag-and-drop' =>
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
array(
Modernize file uploads Summary: Modernizes file uploads. In particular: - Adds a mobile menu, with an "Upload File" item. - Adds crumbs to the list view, detail view and upload view. - Adds "Upload File" action to crumbs. - Moves upload file to a separate page. - Removes the combined upload file + recent files page. - Makes upload file use a normal file control by default (works on mobile). - Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message. - User education on this is a little weak but I think that's a big can of worms? - Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190). T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general. @chad, do we have an "upload" icon (counterpart to "download")? Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2190 Differential Revision: https://secure.phabricator.com/D4200
2012-12-17 01:34:01 +01:00
'uri' => '/res/73ae3fd1/rsrc/js/application/core/behavior-global-drag-and-drop.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-uri',
Modernize file uploads Summary: Modernizes file uploads. In particular: - Adds a mobile menu, with an "Upload File" item. - Adds crumbs to the list view, detail view and upload view. - Adds "Upload File" action to crumbs. - Moves upload file to a separate page. - Removes the combined upload file + recent files page. - Makes upload file use a normal file control by default (works on mobile). - Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message. - User education on this is a little weak but I think that's a big can of worms? - Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190). T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general. @chad, do we have an "upload" icon (counterpart to "download")? Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2190 Differential Revision: https://secure.phabricator.com/D4200
2012-12-17 01:34:01 +01:00
3 => 'javelin-mask',
4 => 'phabricator-drag-and-drop-file-upload',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
Modernize file uploads Summary: Modernizes file uploads. In particular: - Adds a mobile menu, with an "Upload File" item. - Adds crumbs to the list view, detail view and upload view. - Adds "Upload File" action to crumbs. - Moves upload file to a separate page. - Removes the combined upload file + recent files page. - Makes upload file use a normal file control by default (works on mobile). - Home page, file list and file upload page are now global drop targets which accept files dropped anywhere on them. Dragging a file into the window shows a mask and an instructional message. - User education on this is a little weak but I think that's a big can of worms? - Fixes a bug where dropping multiple files into a Remarkup text area produced bad results (resolves T2190). T879 is related, although it's specifically about Maniphest. I've declined to make global drop targets yet there because there are multiple drop targets on the page with different meanings. That UI needs updating in general. @chad, do we have an "upload" icon (counterpart to "download")? Test Plan: Uploaded files in Maniphest, Differential, Files, and from Home. Dragged and dropped multiple files into Differential. Used crumbs, mobile. Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2190 Differential Revision: https://secure.phabricator.com/D4200
2012-12-17 01:34:01 +01:00
'disk' => '/rsrc/js/application/core/behavior-global-drag-and-drop.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'javelin-behavior-herald-rule-editor' =>
array(
'uri' => '/res/77a0c945/rsrc/js/application/herald/herald-rule-editor.js',
'type' => 'js',
'requires' =>
array(
0 => 'herald-rule-editor',
1 => 'javelin-behavior',
),
'disk' => '/rsrc/js/application/herald/herald-rule-editor.js',
),
Minor, update celerity map.
2013-03-05 00:03:54 +01:00
'javelin-behavior-history-install' =>
array(
'uri' => '/res/e146a99b/rsrc/js/application/core/behavior-history-install.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-history',
),
'disk' => '/rsrc/js/application/core/behavior-history-install.js',
),
Do something cooler Summary: It seemed like a good idea at the time. Test Plan: Uh huh. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3352
2012-08-22 17:20:23 +02:00
'javelin-behavior-konami' =>
array(
Simplify side nav CSS and fix various glitches Summary: Fixes glitches in the side nav. Resolves T1828. Resolves T2156. - Elastic scrolling (T2156): in Safari on OSX, using a scroll touch on the trackpad to scroll up past the top of the document caused newer-style side menus to scroll down, leaving a visible whitespace bar. - Whitespace glitch: Particularly in Safari, scrolling down the document quickly from the top caused the top menu to scroll away before the side menu rose to meet it. Use a fixed background color bar that extends under the menu so this doesn't happen. - Use of "!important": use CSS better so we don't need to "!important" things. - Dark Console (T1828): Instead of hard-coding the top position, determine it dynamically by looking at where the content is. This also fixes the menu overlapping with the red "there are errors on this page" development bar. - General "fixed" glitchiness: don't use fixed-position for menu content other than flexible (draggable) menus. Test Plan: - Viewed and scrolled menus in Paste. Opened and closed DarkConsole. Switched devices. - Viewed and scrolled flexible menus in Differential and Diffusion. Opened and closed DarkConsole. Switched devices. Reviewers: vrana, chad, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T1828, T2156 Differential Revision: https://secure.phabricator.com/D4185
2012-12-15 00:14:14 +01:00
'uri' => '/res/2199602f/rsrc/js/application/core/behavior-konami.js',
Do something cooler Summary: It seemed like a good idea at the time. Test Plan: Uh huh. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3352
2012-08-22 17:20:23 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/core/behavior-konami.js',
),
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
'javelin-behavior-lightbox-attachments' =>
array(
DarkConsole: fix rendering, move request log, load over ajax Summary: This accomplishes three major goals: # Fixes phutil_render_tag -> phutil_tag callsites in DarkConsole. # Moves the Ajax request log to a new panel on the left. This panel (and the tabs panel) get scrollbars when they get large, instead of making the page constantly scroll down. # Loads the panel content over ajax, instead of dumping it into the page body / ajax response body. I've been planning to do this for about 3 years, which is why the plugins are architected the way they are. This should make debugging easier by making response bodies not be 50%+ darkconsole stuff. Additionally, load the plugins dynamically (the old method predates library maps and PhutilSymbolLoader). Test Plan: {F30675} - Switched between requests and tabs, reloaded page, saw same tab. - Used "analyze queries", "profile page", triggered errors. - Verified page does not load anything by default if dark console is closed with Charles. - Generally banged on it a bit. Reviewers: vrana, btrahan, chad Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4692
2013-01-29 03:45:32 +01:00
'uri' => '/res/08f5e202/rsrc/js/application/core/behavior-lightbox-attachments.js',
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-mask',
Simplify lightboxing and fix a few things Summary: Minor tweaks to lightboxes. - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it. - Make the lightbox go over the menu bar -- was it intentional that it wasn't? - Make 'jx-mask' use "position: fixed;" too. - Add a loading indicator. - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area. I'm going to do a couple of other tweaks here but need to update JX.Mask. Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3795
2012-10-24 02:34:43 +02:00
4 => 'javelin-util',
5 => 'phabricator-busy',
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
),
'disk' => '/rsrc/js/application/core/behavior-lightbox-attachments.js',
),
Allow Fact app to draw charts Summary: For any count fact, allow a chart to be drawn. INCREDIBLY POWERFUL DATA ANALYSIS PLATFORM. Test Plan: Drew a chart of object counts. Drew the Maniphest burn chart. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T1562 Differential Revision: https://secure.phabricator.com/D3099
2012-07-30 19:44:08 +02:00
'javelin-behavior-line-chart' =>
array(
Add support for placeholders Summary: Support placeholder text for inputs. We currently don't use this because it requires JS and doesn't degrade (no JS means you have zero idea what the input is for if it isn't separately labeled) but there are some cases where intent is obvious from context (for example, the search input in the menu bar, which is fairly obvious on its own and will soon have a magnifying glass icon) and in such cases it's much prettier and saves a bunch of space over an explicit label. Add a behavior so we can add placeholders where they make sense. This implementation is somewhat sanity-checked agianst the two jQuery placeholder implementations I was able to google: https://github.com/danielstocks/jQuery-Placeholder/ https://github.com/mathiasbynens/jquery-placeholder Since we don't currently have any uses cases, I haven't included support for making JS access to the `value` work, for password inputs, or for dynamically altering the placeholder. Test Plan: Played around with the placeholder in the UI example in various browsers and couldn't break it. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3103
2012-07-31 01:08:10 +02:00
'uri' => '/res/1aa5ac88/rsrc/js/application/maniphest/behavior-line-chart.js',
Allow Fact app to draw charts Summary: For any count fact, allow a chart to be drawn. INCREDIBLY POWERFUL DATA ANALYSIS PLATFORM. Test Plan: Drew a chart of object counts. Drew the Maniphest burn chart. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T1562 Differential Revision: https://secure.phabricator.com/D3099
2012-07-30 19:44:08 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-vector',
),
'disk' => '/rsrc/js/application/maniphest/behavior-line-chart.js',
),
Load blame in Diffusion by AJAX Summary: I have blame enabled by default and displaying files with long history takes easily over 10 seconds. Load the blame data by AJAX instead. This is actually doing more work and the total response time is longer but it's worth it for me as I am interested just in the file contents quite often. I know you were talking about building blame cache but until we have it... I'm not sure if the AJAX loading indicator in bottom right corner is enough to inform the user that we are loading it on background. Test Plan: ?view=highlighted ?view=plainblame ?view=blame Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5244
2013-03-05 23:31:20 +01:00
'javelin-behavior-load-blame' =>
array(
'uri' => '/res/138e2961/rsrc/js/application/diffusion/behavior-load-blame.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-request',
),
'disk' => '/rsrc/js/application/diffusion/behavior-load-blame.js',
),
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
'javelin-behavior-maniphest-batch-editor' =>
array(
Get dem vitamins.
2013-04-05 19:35:49 +02:00
'uri' => '/res/00accaec/rsrc/js/application/maniphest/behavior-batch-editor.js',
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-prefab',
4 => 'multirow-row-manager',
Add "Change Priority", "Open / Close", "Comment" and "Assign" actions to Maniphest batch editor Summary: I think these are all the actions which make any sense. Test Plan: - Performed and verified each action through the batch editor. - Performed a large batch edit which applied each action type multiple times and verified the aggregate behavior was correct. Reviewers: btrahan, cpiro Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1971
2012-03-21 22:01:04 +01:00
5 => 'javelin-json',
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
),
'disk' => '/rsrc/js/application/maniphest/behavior-batch-editor.js',
),
'javelin-behavior-maniphest-batch-selector' =>
array(
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
'uri' => '/res/f8cf3b84/rsrc/js/application/maniphest/behavior-batch-selector.js',
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
3 => 'javelin-util',
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
),
'disk' => '/rsrc/js/application/maniphest/behavior-batch-selector.js',
),
Add a description preview to maniphest create / edit panel Summary: also fixes a small bug where the page title was always "Create Task". switch it to the header name which is much more descriptive / correct IMO. Test Plan: created a new task and watched the description preview update. edited an old task and saw the description preview populate with the correct existing data. edited an old task and edited the description and saw the description preview update Reviewers: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1489
2012-01-25 20:23:00 +01:00
'javelin-behavior-maniphest-description-preview' =>
array(
'uri' => '/res/8acd6f07/rsrc/js/application/maniphest/behavior-task-preview.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/maniphest/behavior-task-preview.js',
),
Allow tasks to be subprioritized by drag-and-drop Summary: Like the title says, similar to Facebook Tasks. Not sure how I really feel about this, but I guess it's kind of OK? I never used this feature in Facebook Tasks but I think some people like it. The drag-and-drop to repri across priorities feels okayish. Because subpriority is a double and we just split the difference when reprioritizing, you lose ~a bit of precision every time you repri two tasks against each other and so you can break it by swapping the priorities of two tasks ~50 times. This case is pretty silly and pathological. We can add some code to deal with this at some point if necessary. I think this also fixes the whacky task layout widths once and for all. (There are a couple of minor UI glitches like headers not vanishing and header counts not updating that I'm not fixing because I am lazy.) Test Plan: Dragged and dropped tasks around. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley, mgummelt Maniphest Tasks: T859 Differential Revision: https://secure.phabricator.com/D1731
2012-04-02 21:12:04 +02:00
'javelin-behavior-maniphest-subpriority-editor' =>
array(
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
'uri' => '/res/21b73c2a/rsrc/js/application/maniphest/behavior-subpriorityeditor.js',
Allow tasks to be subprioritized by drag-and-drop Summary: Like the title says, similar to Facebook Tasks. Not sure how I really feel about this, but I guess it's kind of OK? I never used this feature in Facebook Tasks but I think some people like it. The drag-and-drop to repri across priorities feels okayish. Because subpriority is a double and we just split the difference when reprioritizing, you lose ~a bit of precision every time you repri two tasks against each other and so you can break it by swapping the priorities of two tasks ~50 times. This case is pretty silly and pathological. We can add some code to deal with this at some point if necessary. I think this also fixes the whacky task layout widths once and for all. (There are a couple of minor UI glitches like headers not vanishing and header counts not updating that I'm not fixing because I am lazy.) Test Plan: Dragged and dropped tasks around. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley, mgummelt Maniphest Tasks: T859 Differential Revision: https://secure.phabricator.com/D1731
2012-04-02 21:12:04 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-magical-init',
2 => 'javelin-dom',
3 => 'javelin-vector',
4 => 'javelin-stratcom',
5 => 'javelin-workflow',
),
'disk' => '/rsrc/js/application/maniphest/behavior-subpriorityeditor.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-maniphest-transaction-controls' =>
array(
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'uri' => '/res/62465554/rsrc/js/application/maniphest/behavior-transaction-controls.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
2 => 'phabricator-prefab',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/maniphest/behavior-transaction-controls.js',
),
'javelin-behavior-maniphest-transaction-expand' =>
array(
'uri' => '/res/966410de/rsrc/js/application/maniphest/behavior-transaction-expand.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-workflow',
3 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/maniphest/behavior-transaction-expand.js',
),
'javelin-behavior-maniphest-transaction-preview' =>
array(
Make Maniphest Transaction preview tokenizer aware Summary: ...pretty sure the JS is too hack-tastic but it works...! :D also fixed a small error from assert_instances_of change where a null value is all errors and what have you Test Plan: played around with tasks in firefox and safari. made cc, owner, and project changes, as well as priority, etc. Reviewers: epriestley Reviewed By: epriestley CC: aran Maniphest Tasks: T1074 Differential Revision: https://secure.phabricator.com/D2234
2012-04-14 16:05:58 +02:00
'uri' => '/res/855c9f0c/rsrc/js/application/maniphest/behavior-transaction-preview.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
Make Maniphest Transaction preview tokenizer aware Summary: ...pretty sure the JS is too hack-tastic but it works...! :D also fixed a small error from assert_instances_of change where a null value is all errors and what have you Test Plan: played around with tasks in firefox and safari. made cc, owner, and project changes, as well as priority, etc. Reviewers: epriestley Reviewed By: epriestley CC: aran Maniphest Tasks: T1074 Differential Revision: https://secure.phabricator.com/D2234
2012-04-14 16:05:58 +02:00
3 => 'javelin-json',
4 => 'javelin-stratcom',
5 => 'phabricator-shaped-request',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/maniphest/behavior-transaction-preview.js',
),
'javelin-behavior-owners-path-editor' =>
array(
'uri' => '/res/9cf78ffc/rsrc/js/application/owners/owners-path-editor.js',
'type' => 'js',
'requires' =>
array(
0 => 'owners-path-editor',
1 => 'javelin-behavior',
),
'disk' => '/rsrc/js/application/owners/owners-path-editor.js',
),
Minor, map regen.
2012-08-22 00:03:01 +02:00
'javelin-behavior-phabricator-active-nav' =>
array(
Increase double click target in blame Summary: I need to select author or revision quite often. It's currently almost impossible because double click opens the link and drag-and-dropping tries to move the link. Test Plan: Double clicked in blame. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3816
2012-10-25 00:27:37 +02:00
'uri' => '/res/f879d4dd/rsrc/js/application/core/behavior-active-nav.js',
Minor, map regen.
2012-08-22 00:03:01 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-vector',
3 => 'javelin-dom',
4 => 'javelin-uri',
),
'disk' => '/rsrc/js/application/core/behavior-active-nav.js',
),
Add a "jump nav" element to the homepage, for quick tool/object navigation Summary: - Restore quick methods for getting to common features (upload file, create task, etc.) - Provide a flexible cli-like navigation element similar to stuff used at Facebook (bunny1 / lolbunny). Test Plan: Used jump nav and nav buttons. Reviewers: btrahan, fratrik Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1619
2012-02-16 02:49:23 +01:00
'javelin-behavior-phabricator-autofocus' =>
array(
'uri' => '/res/2946bb89/rsrc/js/application/core/behavior-autofocus.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-autofocus.js',
),
Minor, fix celerity map.
2013-02-06 17:32:36 +01:00
'javelin-behavior-phabricator-file-tree' =>
array(
'uri' => '/res/e9c96597/rsrc/js/application/core/behavior-file-tree.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'phabricator-keyboard-shortcut',
2 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/core/behavior-file-tree.js',
),
Add support for device swipe events Summary: Ref T2700. Allow JS to listen for swipes on devices. There are a bunch of tricky cases here and I probably didn't get them all totally right, but this interaction broadly looks like this: - We implement gesture recognition for the mouse in device modes (narrow browser), and for touch events from an actual device. - The sigil `touchable` indicates that a node wants to react to touch events. - When the user touches a `touchable` node, we start listening for moves. They might be tapping/clicking (in which case we don't care), but they might also be gesturing. - Once the user moves their finger/pointer far enough away from the tap origin, we recognize it as a gesture. I hardcoded this at 20px; I wasn't able to find any "official" Apple value, but 20px seems like a common default. - At this point, we look at where their finger has moved. - If they moved it mostly up/down, we interpret the gesture as "scroll" and just stop listening. The device does its own thing. - However, if they moved it mostly left/right, we interpret it as a "swipe". We start killing the moves so the device doesn't scroll. - Once we've recognized that a gesture is underway, we send a "gesture.swipe.start" event and then "gesture.swipe.move" events for every move. - When the user ends the gesture, we send "gesture.swipe.end". - If the user cancels the gesture (currently, only by tapping with a second finger), we send "gesture.swipe.cancel". - Gesture events have raw position data and some convenience fields. Test Plan: Wrote UI example and used it from the Desktop, iPhone simulator, and a real iphone. - The code always seems to get "scroll" vs "swipe" correct (i.e., consistent with my intentions). - The threshold feels pretty good to me. - Tapping with a second finger cancels the action. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T2700 Differential Revision: https://secure.phabricator.com/D5308
2013-03-09 22:53:15 +01:00
'javelin-behavior-phabricator-gesture' =>
array(
Support basic swipe gestures in Pholio Summary: Ref 2700. No sexy animation yet, but allows you to swipe left and right to switch photos. Generally feels pretty good to me. Also fixes a left/right but and a bug where taps could be interpreted as gestures and simplifies some touch code. derpdog Test Plan: Swiped left and right in Pholio. {F35239} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5309
2013-03-09 22:53:32 +01:00
'uri' => '/res/f186161c/rsrc/js/application/core/behavior-gesture.js',
Add support for device swipe events Summary: Ref T2700. Allow JS to listen for swipes on devices. There are a bunch of tricky cases here and I probably didn't get them all totally right, but this interaction broadly looks like this: - We implement gesture recognition for the mouse in device modes (narrow browser), and for touch events from an actual device. - The sigil `touchable` indicates that a node wants to react to touch events. - When the user touches a `touchable` node, we start listening for moves. They might be tapping/clicking (in which case we don't care), but they might also be gesturing. - Once the user moves their finger/pointer far enough away from the tap origin, we recognize it as a gesture. I hardcoded this at 20px; I wasn't able to find any "official" Apple value, but 20px seems like a common default. - At this point, we look at where their finger has moved. - If they moved it mostly up/down, we interpret the gesture as "scroll" and just stop listening. The device does its own thing. - However, if they moved it mostly left/right, we interpret it as a "swipe". We start killing the moves so the device doesn't scroll. - Once we've recognized that a gesture is underway, we send a "gesture.swipe.start" event and then "gesture.swipe.move" events for every move. - When the user ends the gesture, we send "gesture.swipe.end". - If the user cancels the gesture (currently, only by tapping with a second finger), we send "gesture.swipe.cancel". - Gesture events have raw position data and some convenience fields. Test Plan: Wrote UI example and used it from the Desktop, iPhone simulator, and a real iphone. - The code always seems to get "scroll" vs "swipe" correct (i.e., consistent with my intentions). - The threshold feels pretty good to me. - Tapping with a second finger cancels the action. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T2700 Differential Revision: https://secure.phabricator.com/D5308
2013-03-09 22:53:15 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-behavior-device',
2 => 'javelin-stratcom',
3 => 'javelin-vector',
4 => 'javelin-dom',
5 => 'javelin-magical-init',
),
'disk' => '/rsrc/js/application/core/behavior-gesture.js',
),
'javelin-behavior-phabricator-gesture-example' =>
array(
'uri' => '/res/da636e19/rsrc/js/application/uiexample/gesture-example.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-stratcom',
1 => 'javelin-behavior',
2 => 'javelin-vector',
3 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/uiexample/gesture-example.js',
),
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
'javelin-behavior-phabricator-hovercards' =>
array(
Fix the attempt of graceful alignment for Hovercards Summary: Refs T1048; Fixes T2902 - (Probably) fixes @vrana's issue. I managed to repro it on Ubuntu FF (though on Windows with 1.0GHz/512MB it's really worse...). This revises the approach to the graceful degradation for `too-far-to-the-screen-edge-edge-case`. I noticed that `x` could become very negative, up to about ~`-170px`. This is due to the //"already-on-the-left-side"// nature of object tags. `50 - 200 - 20` = `negative`. Adding `100px` (node.dimension.x / 4) to that won't really help, as the hovercard would still be offscreen. Instead, display them left-aligned with the object tags on the left edge per default, and offer centerization in center cases. This is also better for Pholio, Phriction, which have a way lower min-x than Maniphest, Differential. I also disabled placing the hovercard below the tag in case there's not enough space on the north side. The hovercard would not display 99.99% of the times after being hidden (and it retains the flickering behaviour). Another reason is also our current hide-behaviour, which only assumes north-side alignment. Adding south-side didn't really work (I'm bad with JS), so I didn't bother with it. Disabling this is //acceptable//, since it only really affects Pholio, Phriction. And nobody places object tags in the first line, anyway. Except for my test pages, of course :/ Btw, this also removes the weird jaggy horizontal shifts for object of various lengths (e.g. `{D4356}`, `{rP32ofhw0842obw}` etc.). I think that's only good. Test Plan: Hovered in Pholio, Phriction in Chrome, FF. Did not touch left screen border. Hovered in Maniphest, Differential. Tags farther to the left were aligned left, tags more in the center were pretty centered. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1048, T2902 Differential Revision: https://secure.phabricator.com/D5612
2013-04-08 03:10:43 +02:00
'uri' => '/res/7c16603a/rsrc/js/application/core/behavior-hovercard.js',
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-behavior-device',
2 => 'javelin-stratcom',
Load hovercards on-demand Summary: See discussion in D5563. This loads hovercards on-demand, and shows them once they load. Ref T1048. Test Plan: Made a preview comment like `T1`, waved my mouse over it, got a hovercard shortly thereafter. Reviewers: AnhNhan Reviewed By: AnhNhan CC: aran Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5588
2013-04-05 20:01:56 +02:00
3 => 'javelin-vector',
4 => 'phabricator-hovercard',
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
),
'disk' => '/rsrc/js/application/core/behavior-hovercard.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-phabricator-keyboard-pager' =>
array(
'uri' => '/res/56d64eff/rsrc/js/application/core/behavior-keyboard-pager.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-uri',
2 => 'phabricator-keyboard-shortcut',
),
'disk' => '/rsrc/js/application/core/behavior-keyboard-pager.js',
),
'javelin-behavior-phabricator-keyboard-shortcuts' =>
array(
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'uri' => '/res/c5eb65cd/rsrc/js/application/core/behavior-keyboard-shortcuts.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-workflow',
2 => 'javelin-json',
Fix a missing @requires Summary: Split from D1921. Lint complained. Test Plan: Lint doesn't complain. Reviewers: nh, vrana, btrahan Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1923
2012-03-20 03:17:40 +01:00
3 => 'javelin-dom',
4 => 'phabricator-keyboard-shortcut',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-keyboard-shortcuts.js',
),
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
'javelin-behavior-phabricator-nav' =>
array(
Minor, fix celerity map.
2013-02-06 17:32:36 +01:00
'uri' => '/res/222b9329/rsrc/js/application/core/behavior-phabricator-nav.js',
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Make the top nav non-fixed-position Summary: See some discussion in D1673. - There's a concrete (if minor) problem with this in Firefox with wrapping search. - People complain about how we're stealing all their pixels. - There isn't much of a functional purpose to it since all the operations are fairly rare. - This addresses the aesthetic purpose of the fixed-position nav (not making the side nav ugly) by making the side nav scroll up 44px and then stop. Test Plan: Scrolled in desktop, tablet modes. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3412
2012-08-31 03:58:51 +02:00
1 => 'javelin-behavior-device',
2 => 'javelin-stratcom',
3 => 'javelin-dom',
4 => 'javelin-magical-init',
5 => 'javelin-vector',
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
),
'disk' => '/rsrc/js/application/core/behavior-phabricator-nav.js',
),
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'javelin-behavior-phabricator-notification-example' =>
array(
Improve the implementation of Notifications Summary: Currently, you can't change a notification that's already shown. There's no reason for this. (I'm planning to put file upload progress/errors in notifications.) - Make `setContent()` and `setDuration()` immediately affect the notification. - When there are more than 5 notifications, queue them up instead of dropping them. - Allow arbitrarily many classes to be added/removed. - Make the examples in the UIExamples tests more rich. Test Plan: - Verified normal notifications continue to function as expected. - Played with the UIExamples notifications: - Verified the "update every second" notification udpated every second. - Verified the permanent alert notification was yellow and requires a click to dismiss. - Verified the interactive notification responds correctly to "OK" / "Cancel". - Verified the "click every 2 seconds" notification doesn't vanish until not clicked for 2 seconds. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3653
2012-10-09 00:22:29 +02:00
'uri' => '/res/a6d51998/rsrc/js/application/uiexample/notification-example.js',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'phabricator-notification',
1 => 'javelin-stratcom',
2 => 'javelin-behavior',
Add multiple notifications and notification types Summary: - Allow more than one notification to be shown. - Allow notifications to be customized with extra classes. Test Plan: {F12776} Reviewers: allenjohnashton, ddfisher, keebuhm, jungejason Reviewed By: jungejason CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2758
2012-06-17 20:35:36 +02:00
3 => 'javelin-uri',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
),
'disk' => '/rsrc/js/application/uiexample/notification-example.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-phabricator-object-selector' =>
array(
Minor, test fix for D2140? I think this fixes the issue in D2140, pushing to verify... Auditors: 20after4, btrahan
2012-04-07 21:58:18 +02:00
'uri' => '/res/0c4b0d82/rsrc/js/application/core/behavior-object-selector.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-request',
3 => 'javelin-util',
),
'disk' => '/rsrc/js/application/core/behavior-object-selector.js',
),
Kind-of-terrible (?) oncopy handler Summary: Works in Safari, Firefox, Chrome. Test Plan: Copied some text, threw up a little in my mouth. Reviewers: aran, tuomaspelkonen, tomo, rstout, btrahan Reviewed By: aran CC: aran, epriestley, ddfisher Maniphest Tasks: T145, T995 Differential Revision: https://secure.phabricator.com/D244
2012-03-16 03:04:59 +01:00
'javelin-behavior-phabricator-oncopy' =>
array(
Hide oncopy <pre> in Firefox Test Plan: Comment `JX.DOM.remove(pre)` to better see the problem in old code. Apply this diff and verify that the pre is not shown. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2245
2012-04-16 23:50:01 +02:00
'uri' => '/res/f490b8d1/rsrc/js/application/core/behavior-oncopy.js',
Kind-of-terrible (?) oncopy handler Summary: Works in Safari, Firefox, Chrome. Test Plan: Copied some text, threw up a little in my mouth. Reviewers: aran, tuomaspelkonen, tomo, rstout, btrahan Reviewed By: aran CC: aran, epriestley, ddfisher Maniphest Tasks: T145, T995 Differential Revision: https://secure.phabricator.com/D244
2012-03-16 03:04:59 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-oncopy.js',
),
Minor, fix bad Celerity Map merge.
2012-10-02 03:48:39 +02:00
'javelin-behavior-phabricator-remarkup-assist' =>
array(
Fix header spacing in maniphest Summary: I missed this case when updating spacing on blank headers. Test Plan: reload maniphest page with and without tasks. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4622
2013-01-24 21:39:03 +01:00
'uri' => '/res/07406487/rsrc/js/application/core/behavior-phabricator-remarkup-assist.js',
Minor, fix bad Celerity Map merge.
2012-10-02 03:48:39 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'phabricator-textareautils',
),
'disk' => '/rsrc/js/application/core/behavior-phabricator-remarkup-assist.js',
),
Implement basic transaction detail blocks Summary: Some transactions (like editing configuration values, task descriptions, or Conpherence images) can't be simply explained and need an additional larger element to show them fully (like a text diff). Support change details like this in ApplicationTransactions. Implements the element in Config, so you can see changes. Test Plan: {F32974} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2213 Differential Revision: https://secure.phabricator.com/D4984
2013-02-17 15:37:02 +01:00
'javelin-behavior-phabricator-reveal-content' =>
array(
'uri' => '/res/a4fae14a/rsrc/js/application/core/behavior-reveal-content.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-reveal-content.js',
),
Add a basic search typeahead Summary: This needs a bunch of refinement but pretty much works. Currently shows only users and applications. Plans: - Show actual search results too. - Clean up the datasource endpoint so it's less of a mess. - Make other typeaheads look more like this one. - Improve sorting. - Make object names hit the named objects as the first match. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: vrana CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3110
2012-08-01 02:58:21 +02:00
'javelin-behavior-phabricator-search-typeahead' =>
array(
Include symbols in main typeahead Summary: - Include symbols in main typeahead results. - Simplify the symbol query a bit and extend PhabricatorOffsetPagedQuery. There was some stuff around language ranking that I got rid of, I think the theory there was that mapping file extensions to languages might not work in general but I think it works fine in practice, and we have more config stuff now around guessing languages and getting the mappings right. - Make it easier to debug the typeahead by showing the results in page format for non-ajax requests. - When we have too many results, show only the top few of each type. Depends on D3116, D3117 Test Plan: Used typeahead, got symbols in results. Hit endpoint with non-ajax, got useful debug view. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3118
2012-08-01 21:36:47 +02:00
'uri' => '/res/046ab274/rsrc/js/application/core/behavior-search-typeahead.js',
Add a basic search typeahead Summary: This needs a bunch of refinement but pretty much works. Currently shows only users and applications. Plans: - Show actual search results too. - Clean up the datasource endpoint so it's less of a mess. - Make other typeaheads look more like this one. - Improve sorting. - Make object names hit the named objects as the first match. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: vrana CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3110
2012-08-01 02:58:21 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-typeahead-ondemand-source',
2 => 'javelin-typeahead',
3 => 'javelin-dom',
4 => 'javelin-uri',
Improve ordering of main typeahead results Summary: Always order applications first, then users, then other results (currently, there are no other results, of course). (This is similar to the general ordering algorithm used in JX.Prefab but has enough current/future differences that I split it rather than trying to share them.) Test Plan: Queried results, verified order. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3117
2012-08-01 21:36:33 +02:00
5 => 'javelin-util',
6 => 'javelin-stratcom',
Add a basic search typeahead Summary: This needs a bunch of refinement but pretty much works. Currently shows only users and applications. Plans: - Show actual search results too. - Clean up the datasource endpoint so it's less of a mess. - Make other typeaheads look more like this one. - Improve sorting. - Make object names hit the named objects as the first match. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: vrana CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3110
2012-08-01 02:58:21 +02:00
),
'disk' => '/rsrc/js/application/core/behavior-search-typeahead.js',
),
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'javelin-behavior-phabricator-tooltips' =>
array(
Show tooltips in the application nav Summary: Replaces the full names after D3413. Test Plan: See screenshot. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3414
2012-08-31 03:59:08 +02:00
'uri' => '/res/e0b344c6/rsrc/js/application/core/behavior-tooltip.js',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Show tooltips in the application nav Summary: Replaces the full names after D3413. Test Plan: See screenshot. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3414
2012-08-31 03:59:08 +02:00
1 => 'javelin-behavior-device',
2 => 'javelin-stratcom',
3 => 'phabricator-tooltip',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-tooltip.js',
),
Add previews to ApplicationTransaction Summary: Implements previews for Macros and Pholio. (Design is nonfinal -- kind of split the difference between `diff_full_view.png`, laziness, and space concerns. Next couple diffs will add more stuff here.) Test Plan: {F28055} Reviewers: btrahan, chad Reviewed By: btrahan CC: aran, vrana Maniphest Tasks: T2104 Differential Revision: https://secure.phabricator.com/D4246
2012-12-21 14:51:33 +01:00
'javelin-behavior-phabricator-transaction-comment-form' =>
array(
Add draft support to ApplicationTransactions Summary: When previewing, save drafts. When loading objects, restore drafts if they are available. Depends on: D665 Test Plan: - Viewed a Mock. - Typed text into the comment box. - Reloaded the page. - Text still there. - Hit submit, got my comment. - Reloaded the page. - Draft correctly deleted. - Repeated for Macros. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T2104 Differential Revision: https://secure.phabricator.com/D4252
2012-12-21 14:57:14 +01:00
'uri' => '/res/acc3ada1/rsrc/js/application/transactions/behavior-transaction-comment-form.js',
Add previews to ApplicationTransaction Summary: Implements previews for Macros and Pholio. (Design is nonfinal -- kind of split the difference between `diff_full_view.png`, laziness, and space concerns. Next couple diffs will add more stuff here.) Test Plan: {F28055} Reviewers: btrahan, chad Reviewed By: btrahan CC: aran, vrana Maniphest Tasks: T2104 Differential Revision: https://secure.phabricator.com/D4246
2012-12-21 14:51:33 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/transactions/behavior-transaction-comment-form.js',
),
Modernize the top half of Maniphest Summary: Use modern elements: crumbs, header, action list, property list, tags. No functional changes. Test Plan: {F26934} Reviewers: chad, btrahan, vrana Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D4153
2012-12-11 23:03:16 +01:00
'javelin-behavior-phabricator-transaction-list' =>
array(
Make control + enter submit forms if a textarea is focused Summary: This is straightforward, except that `form.submit()` does not call onsubmit handlers. Create a `didSyntheticSubmit` event and have everything which listens for form submits listen for it too. Fixes T704. Test Plan: Hit control + enter in inline comments, main commetns, Pholio, conpherence. Verified it triggered appropriate JS (workflow / special behaviors). Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T704 Differential Revision: https://secure.phabricator.com/D4704
2013-01-28 23:11:32 +01:00
'uri' => '/res/f1fbb474/rsrc/js/application/transactions/behavior-transaction-list.js',
Modernize the top half of Maniphest Summary: Use modern elements: crumbs, header, action list, property list, tags. No functional changes. Test Plan: {F26934} Reviewers: chad, btrahan, vrana Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D4153
2012-12-11 23:03:16 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-workflow',
3 => 'javelin-dom',
4 => 'javelin-fx',
),
'disk' => '/rsrc/js/application/transactions/behavior-transaction-list.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-phabricator-watch-anchor' =>
array(
Display flag in Flag dialog Summary: I had no idea what checkered is. Test Plan: Flagged revision, flagged task. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3346
2012-08-21 06:47:44 +02:00
'uri' => '/res/b20b1cc2/rsrc/js/application/core/behavior-watch-anchor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
Retry failed page anchor navigation Summary: When the user loads a page with an anchor on it like #thing, or clicks a link to #thing, and #thing doesn't exist, keep trying to navigate to #thing for a few seconds. This allows anchors to work when the target is in content which is later ajaxed in. In particular, this affects inline comments in Differential. Test Plan: Opened inline comment links in a new tab, was in the right place when I switched tabs. Reviewers: nh, btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan, epriestley Maniphest Tasks: T492 Differential Revision: https://secure.phabricator.com/D1327
2012-01-06 01:36:59 +01:00
3 => 'javelin-vector',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-watch-anchor.js',
),
Phame V1 - Phabricator blogging software Summary: 'cuz we need to be phamous! V1 feature set - posts -- standard thing you'd expect - a title and a remarkup-powered body and... -- "phame" title - a short string that can be used to reference the story. this gets auto-updated when you mess with the title. -- configuration - for now, do you want Facebook, Disqus or no comments? this is a per-post thing but feeds from an instance-wide configuration Please do toss out any must have features or changes. Test Plan: played around with this bad boy like whoa Reviewers: epriestley Reviewed By: epriestley CC: aran, vrana Maniphest Tasks: T1111 Differential Revision: https://secure.phabricator.com/D2202
2012-04-12 22:09:04 +02:00
'javelin-behavior-phame-post-preview' =>
array(
'uri' => '/res/ac4c503a/rsrc/js/application/phame/phame-post-preview.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/phame/phame-post-preview.js',
),
Show all photos in a Pholio mock and allow switching between them Summary: Mock page now shows all images. Switching between images is done by clicking thumbnails. Test Plan: Verified that all images are shown. Verified that by clicking thumbnail the image clicked will show. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2427 Differential Revision: https://secure.phabricator.com/D4698
2013-01-28 20:18:50 +01:00
'javelin-behavior-pholio-mock-view' =>
array(
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
'uri' => '/res/ecf5f969/rsrc/js/application/pholio/behavior-pholio-mock-view.js',
Show all photos in a Pholio mock and allow switching between them Summary: Mock page now shows all images. Switching between images is done by clicking thumbnails. Test Plan: Verified that all images are shown. Verified that by clicking thumbnail the image clicked will show. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2427 Differential Revision: https://secure.phabricator.com/D4698
2013-01-28 20:18:50 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
When an image is too wide in Pholio, scale it down Summary: Currently, if an image is too wide for the viewport, we freak out. Instead, scale it down. This means we must also scale down all the rectangles on it, which is why this is tricky. However, all the draw/load separation has made it reasonably straightforward. We'll possibly need to add some kind of "view full size" thing. I'm planning to add an element which shows "85%" or whatever if it's currently scaled. Test Plan: Before: {F33607} After: {F33608} Reviewers: chad, ljalonen Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5088
2013-02-23 15:28:34 +01:00
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-dom',
4 => 'javelin-vector',
5 => 'javelin-magical-init',
6 => 'javelin-request',
Make Pholio URIs aware of which image you are looking at Summary: Fixes T2658. Map `/Mxx/yy/` to images in a mock. Use HTML5 history stuff to make it work nicely. This also makes right-click-open-in-new-tab work correctly. Test Plan: Clicked thumbs in a mock. Right-clicked thumbs. Copy and pasted a URI. Used browser back button. Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2658 Differential Revision: https://secure.phabricator.com/D5222
2013-03-05 03:43:29 +01:00
7 => 'javelin-history',
Improve behavior of inline comment dialog Summary: Fixes T2669. - Currently, making an inline comment does not focus the textarea. Instead, focus the textarea. - Currently, the positioning is kind of buggy. Make it viewport-relative and put the dialog slightly below the inline reticle. - Use `JX.Workflow` more and simplify some of the ajax stuff. Test Plan: Created inline comments. Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2669 Differential Revision: https://secure.phabricator.com/D5229
2013-03-05 21:30:05 +01:00
8 => 'javelin-workflow',
Improve Pholio on mobile Summary: Ref T2644. This isn't perfect, but makes Pholio more-or-less usable on mobile. In particular: - Inline comments drop below the image. - Clicking the image lightboxes a full size version so you can scroll around it and inspect details. - Clicking it again dismisses it. Things that aren't good: - Can't add inline comments. This seems complicated and not critical. - Can't easily figure out which inline comments go where since there's no hover. Maybe let you tap them? Not sure if we really need this. - Thumbs are between image and image data. I'm planning to get rid of the thumbs and do swipe left/right instead. - It would be nice to scroll the lightbox to center on the part of the image you tapped. I just thought of this, though. Test Plan: {F34640} {F34641} {F34642} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2644 Differential Revision: https://secure.phabricator.com/D5232
2013-03-05 21:30:58 +01:00
9 => 'javelin-mask',
10 => 'javelin-behavior-device',
11 => 'phabricator-keyboard-shortcut',
Show all photos in a Pholio mock and allow switching between them Summary: Mock page now shows all images. Switching between images is done by clicking thumbnails. Test Plan: Verified that all images are shown. Verified that by clicking thumbnail the image clicked will show. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2427 Differential Revision: https://secure.phabricator.com/D4698
2013-01-28 20:18:50 +01:00
),
'disk' => '/rsrc/js/application/pholio/behavior-pholio-mock-view.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-phriction-document-preview' =>
array(
'uri' => '/res/f1665ecd/rsrc/js/application/phriction/phriction-document-preview.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/phriction/phriction-document-preview.js',
),
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'javelin-behavior-ponder-feedback-preview' =>
array(
'uri' => '/res/2e802dd9/rsrc/js/application/ponder/behavior-comment-preview.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/ponder/behavior-comment-preview.js',
),
'javelin-behavior-ponder-votebox' =>
array(
Add applications for Owners, Repositories, PHID manager, PHPAST Summary: See D3572. Test Plan: Viewed /applications/, saw all these applications. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3579
2012-10-01 21:56:33 +02:00
'uri' => '/res/9d091af3/rsrc/js/application/ponder/behavior-votebox.js',
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
Add applications for Owners, Repositories, PHID manager, PHPAST Summary: See D3572. Test Plan: Viewed /applications/, saw all these applications. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3579
2012-10-01 21:56:33 +02:00
3 => 'javelin-stratcom',
4 => 'javelin-request',
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
),
'disk' => '/rsrc/js/application/ponder/behavior-votebox.js',
),
Allow commits to be associated with projects and associated goodies Summary: - Commit detail view - List of projects - "edit" action which takes the user to a simple form where they can only add / remove projects. - Integrated the project relationship into the commit search indexer - fixed a bug from D790; it seems you must select the column if you're going to join against it later. Without this change searching for author or projectfails 100% for me. Test Plan: added and removed projects. verified appropriate projects showed up in detail and edit view. searched for commits by project and found the ones I was supposed to...! Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1614 Differential Revision: https://secure.phabricator.com/D3189
2012-08-08 19:03:41 +02:00
'javelin-behavior-project-create' =>
array(
'uri' => '/res/e91f3f8f/rsrc/js/application/projects/behavior-project-create.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
3 => 'javelin-workflow',
),
'disk' => '/rsrc/js/application/projects/behavior-project-create.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-refresh-csrf' =>
array(
Simplify lightboxing and fix a few things Summary: Minor tweaks to lightboxes. - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it. - Make the lightbox go over the menu bar -- was it intentional that it wasn't? - Make 'jx-mask' use "position: fixed;" too. - Add a loading indicator. - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area. I'm going to do a couple of other tweaks here but need to update JX.Mask. Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3795
2012-10-24 02:34:43 +02:00
'uri' => '/res/6fd76d0f/rsrc/js/application/core/behavior-refresh-csrf.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-request',
1 => 'javelin-behavior',
2 => 'javelin-dom',
Simplify lightboxing and fix a few things Summary: Minor tweaks to lightboxes. - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it. - Make the lightbox go over the menu bar -- was it intentional that it wasn't? - Make 'jx-mask' use "position: fixed;" too. - Add a loading indicator. - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area. I'm going to do a couple of other tweaks here but need to update JX.Mask. Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3795
2012-10-24 02:34:43 +02:00
3 => 'phabricator-busy',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-refresh-csrf.js',
),
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
'javelin-behavior-releeph-preview-branch' =>
array(
'uri' => '/res/a77ebc86/rsrc/js/application/releeph/releeph-preview-branch.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
3 => 'javelin-uri',
4 => 'javelin-util',
),
'disk' => '/rsrc/js/application/releeph/releeph-preview-branch.js',
),
'javelin-behavior-releeph-request-state-change' =>
array(
'uri' => '/res/38f96ba8/rsrc/js/application/releeph/releeph-request-state-change.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
3 => 'javelin-util',
4 => 'phabricator-keyboard-shortcut',
5 => 'phabricator-notification',
),
'disk' => '/rsrc/js/application/releeph/releeph-request-state-change.js',
),
'javelin-behavior-releeph-request-typeahead' =>
array(
'uri' => '/res/b52096e2/rsrc/js/application/releeph/releeph-request-typeahead.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-util',
2 => 'javelin-dom',
3 => 'javelin-typeahead',
4 => 'javelin-tokenizer',
5 => 'javelin-typeahead-preloaded-source',
6 => 'javelin-typeahead-ondemand-source',
7 => 'javelin-dom',
8 => 'javelin-stratcom',
9 => 'javelin-util',
),
'disk' => '/rsrc/js/application/releeph/releeph-request-typeahead.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-repository-crossreference' =>
array(
Allow double click and drag in crossreference Summary: Also simplifies the code. Test Plan: Clicked, selected, double clicked, double clicked and dragged. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, s.o.butler Differential Revision: https://secure.phabricator.com/D5048
2013-02-21 18:49:06 +01:00
'uri' => '/res/4b5fab1c/rsrc/js/application/repository/repository-crossreference.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Don't open symbols on double click Summary: My average double click speed is 10 ms but I tried to double click as I think normal people double clicks and it was around 200 ms. I don't want to make the timeout much longer because it looks like that something doesn't work. Test Plan: Double clicked on symbol. Clicked on symbol. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3509
2012-09-17 23:50:49 +02:00
2 => 'javelin-stratcom',
3 => 'javelin-uri',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/repository/repository-crossreference.js',
),
For discussion -- Stripe integration Summary: various stripe stuff, including - external stripe library - payment form - test controller to play with payment form, sample business logic My main questions / discussion topics are... - is the stripe PHP library too big? (ie should I write something more simple just for phabricator?) -- if its cool, what is the best way to include the client? (ie should I make it a submodule rather than the flat copy here?) - is the JS I wrote (too) ridiculous? -- particularly unhappy with the error message stuff being in JS *but* it seemed the best choice given the most juicy error messages come from the stripe JS such that the overall code complexity is lowest this way. - how should the stripe JS be included? -- flat copy like I did here? -- some sort of external? -- can we just load it off stripe servers at request time? (I like that from the "if stripe is down, stripe is down" perspective) - wasn't sure if the date control was too silly and should just be baked into the form? -- for some reason I feel like its good to be prepared to walk away from Stripe / switch providers here, though I think this is on the wrong side of pragmatic Test Plan: - played around with sample client form Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2096
2012-04-05 01:09:29 +02:00
'javelin-behavior-stripe-payment-form' =>
array(
Phortune v0.1: products Summary: Ref T2787. A product is the abstract representation of something you can buy or rent/subscribe to. Although the interface isn't locked down yet, this would ultimately be internal/administrative. Products likely have some user-facing skin on top of them: plans would have a purchasing/comparison flow, physical goods would have a storefront, etc., so products don't have any information like descriptions or images, just the data that Phortune needs to correctly bill accounts. Generally, this is very basic for the moment. Test Plan: {F37594} {F37595} {F37596} Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D5441
2013-03-28 17:13:07 +01:00
'uri' => '/res/30bcbbb1/rsrc/js/application/phortune/behavior-stripe-payment-form.js',
For discussion -- Stripe integration Summary: various stripe stuff, including - external stripe library - payment form - test controller to play with payment form, sample business logic My main questions / discussion topics are... - is the stripe PHP library too big? (ie should I write something more simple just for phabricator?) -- if its cool, what is the best way to include the client? (ie should I make it a submodule rather than the flat copy here?) - is the JS I wrote (too) ridiculous? -- particularly unhappy with the error message stuff being in JS *but* it seemed the best choice given the most juicy error messages come from the stripe JS such that the overall code complexity is lowest this way. - how should the stripe JS be included? -- flat copy like I did here? -- some sort of external? -- can we just load it off stripe servers at request time? (I like that from the "if stripe is down, stripe is down" perspective) - wasn't sure if the date control was too silly and should just be baked into the form? -- for some reason I feel like its good to be prepared to walk away from Stripe / switch providers here, though I think this is on the wrong side of pragmatic Test Plan: - played around with sample client form Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2096
2012-04-05 01:09:29 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-json',
Phortune v0.1: products Summary: Ref T2787. A product is the abstract representation of something you can buy or rent/subscribe to. Although the interface isn't locked down yet, this would ultimately be internal/administrative. Products likely have some user-facing skin on top of them: plans would have a purchasing/comparison flow, physical goods would have a storefront, etc., so products don't have any information like descriptions or images, just the data that Phortune needs to correctly bill accounts. Generally, this is very basic for the moment. Test Plan: {F37594} {F37595} {F37596} Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D5441
2013-03-28 17:13:07 +01:00
3 => 'javelin-workflow',
4 => 'stripe-core',
For discussion -- Stripe integration Summary: various stripe stuff, including - external stripe library - payment form - test controller to play with payment form, sample business logic My main questions / discussion topics are... - is the stripe PHP library too big? (ie should I write something more simple just for phabricator?) -- if its cool, what is the best way to include the client? (ie should I make it a submodule rather than the flat copy here?) - is the JS I wrote (too) ridiculous? -- particularly unhappy with the error message stuff being in JS *but* it seemed the best choice given the most juicy error messages come from the stripe JS such that the overall code complexity is lowest this way. - how should the stripe JS be included? -- flat copy like I did here? -- some sort of external? -- can we just load it off stripe servers at request time? (I like that from the "if stripe is down, stripe is down" perspective) - wasn't sure if the date control was too silly and should just be baked into the form? -- for some reason I feel like its good to be prepared to walk away from Stripe / switch providers here, though I think this is on the wrong side of pragmatic Test Plan: - played around with sample client form Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2096
2012-04-05 01:09:29 +02:00
),
'disk' => '/rsrc/js/application/phortune/behavior-stripe-payment-form.js',
),
Add a "toggle-class" behavior Summary: The new menu stuff needs this but it was easy to pull out on its own. Test Plan: Cliked UI example buttons. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3104
2012-07-31 01:08:42 +02:00
'javelin-behavior-toggle-class' =>
array(
Add basic support for new navigation menu Summary: Add a new left-side application menu. This menu shows which application you're in and provides a quick way to get to other applications. On desktops, menus are always shown but the app menu can be collapsed to be very small. On tablets, navigation buttons allow you to choose between the menus and the content. On phones, navigation buttons allow you to choose between the app menu, the local menu, and the content. This needs some code and UI cleanup, but has no effect yet so I think it's okay to land as-is, I'll clean it up a bit as I start integrating it. I want to play around with it a bit and see if it's good/useful or horrible anyway. Test Plan: Will include screenshots. Reviewers: vrana, btrahan, chad Reviewed By: btrahan CC: aran, alanh Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3223
2012-08-11 16:06:12 +02:00
'uri' => '/res/fa818e0f/rsrc/js/application/core/behavior-toggle-class.js',
Add a "toggle-class" behavior Summary: The new menu stuff needs this but it was easy to pull out on its own. Test Plan: Cliked UI example buttons. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3104
2012-07-31 01:08:42 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-toggle-class.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-view-placeholder' =>
array(
'uri' => '/res/5b89bdf5/rsrc/js/javelin/ext/view/ViewPlaceholder.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-view-renderer',
),
'disk' => '/rsrc/js/javelin/ext/view/ViewPlaceholder.js',
),
'javelin-behavior-workflow' =>
array(
Make control + enter submit forms if a textarea is focused Summary: This is straightforward, except that `form.submit()` does not call onsubmit handlers. Create a `didSyntheticSubmit` event and have everything which listens for form submits listen for it too. Fixes T704. Test Plan: Hit control + enter in inline comments, main commetns, Pholio, conpherence. Verified it triggered appropriate JS (workflow / special behaviors). Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T704 Differential Revision: https://secure.phabricator.com/D4704
2013-01-28 23:11:32 +01:00
'uri' => '/res/2c99beaf/rsrc/js/application/core/behavior-workflow.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-workflow',
Restore a more surgical workflow/target check Summary: D3707 removed some overbroad rules for when we trigger workflows, but there is still one case we should check for -- an <a /> without workflow inside a <form /> with workflow. This occurs in, e.g., the "help" button in Remarkup. If the node with workflow isn't a link, don't trigger workflow. This should allow the <a><img /></a> case to keep working properly. Test Plan: Clicked "?" in remarkup bar. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3722
2012-10-17 17:28:37 +02:00
3 => 'javelin-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-workflow.js',
),
'javelin-color' =>
array(
'uri' => '/res/b0439fc9/rsrc/js/javelin/ext/fx/Color.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/ext/fx/Color.js',
),
'javelin-cookie' =>
array(
'uri' => '/res/a9cddab0/rsrc/js/javelin/lib/Cookie.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/lib/Cookie.js',
),
'javelin-dom' =>
array(
DarkConsole: fix rendering, move request log, load over ajax Summary: This accomplishes three major goals: # Fixes phutil_render_tag -> phutil_tag callsites in DarkConsole. # Moves the Ajax request log to a new panel on the left. This panel (and the tabs panel) get scrollbars when they get large, instead of making the page constantly scroll down. # Loads the panel content over ajax, instead of dumping it into the page body / ajax response body. I've been planning to do this for about 3 years, which is why the plugins are architected the way they are. This should make debugging easier by making response bodies not be 50%+ darkconsole stuff. Additionally, load the plugins dynamically (the old method predates library maps and PhutilSymbolLoader). Test Plan: {F30675} - Switched between requests and tabs, reloaded page, saw same tab. - Used "analyze queries", "profile page", triggered errors. - Verified page does not load anything by default if dark console is closed with Charles. - Generally banged on it a bit. Reviewers: vrana, btrahan, chad Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4692
2013-01-29 03:45:32 +01:00
'uri' => '/res/459f3c08/rsrc/js/javelin/lib/DOM.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-magical-init',
1 => 'javelin-install',
2 => 'javelin-util',
3 => 'javelin-vector',
4 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/javelin/lib/DOM.js',
),
'javelin-dynval' =>
array(
'uri' => '/res/d89c6f88/rsrc/js/javelin/ext/reactor/core/DynVal.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-reactornode',
2 => 'javelin-util',
3 => 'javelin-reactor',
),
'disk' => '/rsrc/js/javelin/ext/reactor/core/DynVal.js',
),
'javelin-event' =>
array(
Leafy greens.
2013-04-04 20:35:22 +02:00
'uri' => '/res/809d2d58/rsrc/js/javelin/core/Event.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/core/Event.js',
),
'javelin-fx' =>
array(
Don't open symbols on double click Summary: My average double click speed is 10 ms but I tried to double click as I think normal people double clicks and it was around 200 ms. I don't want to make the timeout much longer because it looks like that something doesn't work. Test Plan: Double clicked on symbol. Clicked on symbol. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3509
2012-09-17 23:50:49 +02:00
'uri' => '/res/30ef0914/rsrc/js/javelin/ext/fx/FX.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-color',
1 => 'javelin-install',
2 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/ext/fx/FX.js',
),
'javelin-history' =>
array(
'uri' => '/res/9bb36651/rsrc/js/javelin/lib/History.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-stratcom',
1 => 'javelin-install',
2 => 'javelin-uri',
3 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/lib/History.js',
),
'javelin-install' =>
array(
'uri' => '/res/cab679ff/rsrc/js/javelin/core/install.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-util',
1 => 'javelin-magical-init',
),
'disk' => '/rsrc/js/javelin/core/install.js',
),
'javelin-json' =>
array(
'uri' => '/res/561b8056/rsrc/js/javelin/lib/JSON.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/lib/JSON.js',
),
'javelin-magical-init' =>
array(
Attempt to fix IE8 mixed content warning.
2013-02-26 17:00:20 +01:00
'uri' => '/res/2f1554da/rsrc/js/javelin/core/init.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/javelin/core/init.js',
),
'javelin-mask' =>
array(
Fix mask positioning and use mask classes in lightbox Summary: See D3795 / D3797. Also made the mask darker. Test Plan: Mask now sizes properly on window resize in all browsers / mask uses. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3798
2012-10-23 20:39:33 +02:00
'uri' => '/res/d2a35fff/rsrc/js/javelin/lib/Mask.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Fix mask positioning and use mask classes in lightbox Summary: See D3795 / D3797. Also made the mask darker. Test Plan: Mask now sizes properly on window resize in all browsers / mask uses. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3798
2012-10-23 20:39:33 +02:00
1 => 'javelin-dom',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/javelin/lib/Mask.js',
),
'javelin-reactor' =>
array(
'uri' => '/res/dfd87f3c/rsrc/js/javelin/ext/reactor/core/Reactor.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/ext/reactor/core/Reactor.js',
),
'javelin-reactor-dom' =>
array(
'uri' => '/res/701b6f39/rsrc/js/javelin/ext/reactor/dom/RDOM.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-dom',
1 => 'javelin-dynval',
2 => 'javelin-reactornode',
3 => 'javelin-install',
4 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/ext/reactor/dom/RDOM.js',
),
'javelin-reactor-node-calmer' =>
array(
'uri' => '/res/5a35920a/rsrc/js/javelin/ext/reactor/core/ReactorNodeCalmer.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-reactor',
2 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/ext/reactor/core/ReactorNodeCalmer.js',
),
'javelin-reactornode' =>
array(
'uri' => '/res/f278cc27/rsrc/js/javelin/ext/reactor/core/ReactorNode.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-reactor',
2 => 'javelin-util',
3 => 'javelin-reactor-node-calmer',
),
'disk' => '/rsrc/js/javelin/ext/reactor/core/ReactorNode.js',
),
'javelin-request' =>
array(
Modify Celerity to emit required resources on Ajax responses Summary: Companion diff to D4003. Test Plan: Rigged up a response which loaded a CSS file with `body { background: red; }`, verified page turned red after I clicked the button. Reviewers: vrana, chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T2086 Differential Revision: https://secure.phabricator.com/D4004
2012-11-21 17:37:01 +01:00
'uri' => '/res/e25d75b3/rsrc/js/javelin/lib/Request.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-stratcom',
2 => 'javelin-util',
3 => 'javelin-behavior',
4 => 'javelin-json',
5 => 'javelin-dom',
Update static resource packages Summary: These are a bit out of date; bundle things together better. Test Plan: Viewed page source for home, differential list, differential diff, maniphest list, maniphest task. Verified reasonable resource packaging. Reviewers: chad, vrana, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4002
2012-11-21 03:01:25 +01:00
6 => 'javelin-resource',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/javelin/lib/Request.js',
),
'javelin-resource' =>
array(
Don't open symbols on double click Summary: My average double click speed is 10 ms but I tried to double click as I think normal people double clicks and it was around 200 ms. I don't want to make the timeout much longer because it looks like that something doesn't work. Test Plan: Double clicked on symbol. Clicked on symbol. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3509
2012-09-17 23:50:49 +02:00
'uri' => '/res/d5a3f835/rsrc/js/javelin/lib/Resource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-magical-init',
1 => 'javelin-stratcom',
2 => 'javelin-util',
3 => 'javelin-uri',
),
'disk' => '/rsrc/js/javelin/lib/Resource.js',
),
'javelin-stratcom' =>
array(
Add draft support to ApplicationTransactions Summary: When previewing, save drafts. When loading objects, restore drafts if they are available. Depends on: D665 Test Plan: - Viewed a Mock. - Typed text into the comment box. - Reloaded the page. - Text still there. - Hit submit, got my comment. - Reloaded the page. - Draft correctly deleted. - Repeated for Macros. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T2104 Differential Revision: https://secure.phabricator.com/D4252
2012-12-21 14:57:14 +01:00
'uri' => '/res/c81f64eb/rsrc/js/javelin/core/Stratcom.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-event',
2 => 'javelin-util',
3 => 'javelin-magical-init',
),
'disk' => '/rsrc/js/javelin/core/Stratcom.js',
),
'javelin-tokenizer' =>
array(
Leafy greens.
2013-04-04 20:35:22 +02:00
'uri' => '/res/f3e738e6/rsrc/js/javelin/lib/control/tokenizer/Tokenizer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-dom',
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/lib/control/tokenizer/Tokenizer.js',
),
'javelin-typeahead' =>
array(
Use JX.Request.setRawData() Summary: See D3727. @paulshen, these are the only callsites we have in Phabricator so we can remove `setFile()` once it's clear on the Facebook side. Test Plan: Uploaded a file with drag and drop. Reviewers: paulshen, vrana, mnml0 Reviewed By: mnml0 CC: aran Differential Revision: https://secure.phabricator.com/D3769
2012-10-20 19:53:51 +02:00
'uri' => '/res/dccb789e/rsrc/js/javelin/lib/control/typeahead/Typeahead.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
2 => 'javelin-vector',
3 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/Typeahead.js',
),
'javelin-typeahead-composite-source' =>
array(
Modernize phame and add concept of "blog style" to blog post list view Summary: "blog style" for now is just "true" to make this UI render better for the blog LATER it will be a string which will choose the larger template. this will also have to do some messing around with links; when viewing on a phabricator instance links need to be a bit dirtier to carry around the blog whereas when viewing offsite we can tell what blog it is based on the host domain. anyhoo, this is future diff work Test Plan: looked at blog - less ugly. resized blog to smaller sizes - became a "single list" of goodness for quality reading quite quickly. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1373 Differential Revision: https://secure.phabricator.com/D3587
2012-10-02 00:37:02 +02:00
'uri' => '/res/99705f64/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-typeahead-source',
2 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js',
),
'javelin-typeahead-normalizer' =>
array(
'uri' => '/res/a9e97c0d/rsrc/js/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js',
),
'javelin-typeahead-ondemand-source' =>
array(
'uri' => '/res/81e531aa/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-request',
4 => 'javelin-typeahead-source',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js',
),
'javelin-typeahead-preloaded-source' =>
array(
'uri' => '/res/d464efd2/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-request',
4 => 'javelin-typeahead-source',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js',
),
'javelin-typeahead-source' =>
array(
Don't open symbols on double click Summary: My average double click speed is 10 ms but I tried to double click as I think normal people double clicks and it was around 200 ms. I don't want to make the timeout much longer because it looks like that something doesn't work. Test Plan: Double clicked on symbol. Clicked on symbol. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3509
2012-09-17 23:50:49 +02:00
'uri' => '/res/74b1f091/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadSource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-dom',
3 => 'javelin-typeahead-normalizer',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadSource.js',
),
Don't open symbols on double click Summary: My average double click speed is 10 ms but I tried to double click as I think normal people double clicks and it was around 200 ms. I don't want to make the timeout much longer because it looks like that something doesn't work. Test Plan: Double clicked on symbol. Clicked on symbol. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3509
2012-09-17 23:50:49 +02:00
'javelin-typeahead-static-source' =>
array(
'uri' => '/res/c8e247fc/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-typeahead-source',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadStaticSource.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-uri' =>
array(
Modernize phame and add concept of "blog style" to blog post list view Summary: "blog style" for now is just "true" to make this UI render better for the blog LATER it will be a string which will choose the larger template. this will also have to do some messing around with links; when viewing on a phabricator instance links need to be a bit dirtier to carry around the blog whereas when viewing offsite we can tell what blog it is based on the host domain. anyhoo, this is future diff work Test Plan: looked at blog - less ugly. resized blog to smaller sizes - became a "single list" of goodness for quality reading quite quickly. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1373 Differential Revision: https://secure.phabricator.com/D3587
2012-10-02 00:37:02 +02:00
'uri' => '/res/c107d858/rsrc/js/javelin/lib/URI.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/javelin/lib/URI.js',
),
'javelin-util' =>
array(
Don't open symbols on double click Summary: My average double click speed is 10 ms but I tried to double click as I think normal people double clicks and it was around 200 ms. I don't want to make the timeout much longer because it looks like that something doesn't work. Test Plan: Double clicked on symbol. Clicked on symbol. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3509
2012-09-17 23:50:49 +02:00
'uri' => '/res/25786b6c/rsrc/js/javelin/core/util.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/javelin/core/util.js',
),
'javelin-vector' =>
array(
Add "buoyant" headers to Differential Summary: As you scroll through a diff, add a fixed-position header to the top of the document to provide context. This is particularly useful with keyboard navigation. The technical implementation is that we seed the document with invisible markers. When the user scrolls past one, we show a header with that text until they scroll past another. Test Plan: Scrolled through a revision, was presented with context. https://secure.phabricator.com/file/data/5xhh2jmoon6ukr5qjkh3/PHID-FILE-463ituscyhyw7utnox7m/Screen_Shot_2012-02-22_at_2.48.19_PM.png Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T696 Differential Revision: https://secure.phabricator.com/D1673
2012-02-23 21:26:14 +01:00
'uri' => '/res/f240bdb3/rsrc/js/javelin/lib/Vector.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-event',
),
'disk' => '/rsrc/js/javelin/lib/Vector.js',
),
'javelin-view' =>
array(
'uri' => '/res/b98657a7/rsrc/js/javelin/ext/view/View.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/ext/view/View.js',
),
'javelin-view-html' =>
array(
'uri' => '/res/7e5a2122/rsrc/js/javelin/ext/view/HTMLView.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
),
'disk' => '/rsrc/js/javelin/ext/view/HTMLView.js',
),
'javelin-view-interpreter' =>
array(
'uri' => '/res/17e911ca/rsrc/js/javelin/ext/view/ViewInterpreter.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-view',
1 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/ext/view/ViewInterpreter.js',
),
'javelin-view-renderer' =>
array(
'uri' => '/res/db4ed5a2/rsrc/js/javelin/ext/view/ViewRenderer.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/ext/view/ViewRenderer.js',
),
'javelin-view-visitor' =>
array(
'uri' => '/res/0ef9dc43/rsrc/js/javelin/ext/view/ViewVisitor.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/ext/view/ViewVisitor.js',
),
'javelin-workflow' =>
array(
Minor phutil_tag/HTML fixes Summary: - In stack traces, a `,` should clearly be a `.`. - In Calendar, a 'td' got swapped with a 'p' somewhere. - In old-style transaction views, strlen() is no longer a sufficient test. Test Plan: - Verified stack traces render correctly. - Verified calendar renders correctly. - Verified Maniphest transactions with no comment no longer have a little empty div a few pixels high. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4971
2013-02-15 17:14:31 +01:00
'uri' => '/res/1535e366/rsrc/js/javelin/lib/Workflow.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-stratcom',
1 => 'javelin-request',
2 => 'javelin-dom',
3 => 'javelin-vector',
4 => 'javelin-install',
5 => 'javelin-util',
6 => 'javelin-mask',
7 => 'javelin-uri',
),
'disk' => '/rsrc/js/javelin/lib/Workflow.js',
),
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
'lightbox-attachment-css' =>
array(
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'uri' => '/res/4657e15d/rsrc/css/aphront/lightbox-attachment.css',
Introduce lightbox view for images Summary: images attached to maniphest tasks and mentioned in remarkup anywhere now invoke a lightbox control that lets the user page through all the images. lightbox includes a download button, next / prev buttons, and if we're not at the tippy toppy of hte page an "X" or close button. we also respond to left, right, and esc for navigating. next time we should get non-images working in here...! Test Plan: played with maniphest - looks good made comments with images. looks good. made sure multiple image comments worked. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, chad Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3705
2012-10-23 04:06:56 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/lightbox-attachment.css',
),
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
'maniphest-batch-editor' =>
array(
'uri' => '/res/fb15d744/rsrc/css/application/maniphest/batch-editor.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/batch-editor.css',
),
Iterate on Maniphest reports Summary: - These are still slow, awkward and hideous -- but slightly better than before. - Allow "open" reports to be sorted. - Add a "burn" chart/table for assessing project volatility. - Add navigation. Test Plan: Looked at reports. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T923 Differential Revision: https://secure.phabricator.com/D1737
2012-03-01 23:19:11 +01:00
'maniphest-report-css' =>
array(
'uri' => '/res/2e633fcf/rsrc/css/application/maniphest/report.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/report.css',
),
Add a description preview to maniphest create / edit panel Summary: also fixes a small bug where the page title was always "Create Task". switch it to the header name which is much more descriptive / correct IMO. Test Plan: created a new task and watched the description preview update. edited an old task and saw the description preview populate with the correct existing data. edited an old task and edited the description and saw the description preview update Reviewers: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1489
2012-01-25 20:23:00 +01:00
'maniphest-task-edit-css' =>
array(
Fix the attempt of graceful alignment for Hovercards Summary: Refs T1048; Fixes T2902 - (Probably) fixes @vrana's issue. I managed to repro it on Ubuntu FF (though on Windows with 1.0GHz/512MB it's really worse...). This revises the approach to the graceful degradation for `too-far-to-the-screen-edge-edge-case`. I noticed that `x` could become very negative, up to about ~`-170px`. This is due to the //"already-on-the-left-side"// nature of object tags. `50 - 200 - 20` = `negative`. Adding `100px` (node.dimension.x / 4) to that won't really help, as the hovercard would still be offscreen. Instead, display them left-aligned with the object tags on the left edge per default, and offer centerization in center cases. This is also better for Pholio, Phriction, which have a way lower min-x than Maniphest, Differential. I also disabled placing the hovercard below the tag in case there's not enough space on the north side. The hovercard would not display 99.99% of the times after being hidden (and it retains the flickering behaviour). Another reason is also our current hide-behaviour, which only assumes north-side alignment. Adding south-side didn't really work (I'm bad with JS), so I didn't bother with it. Disabling this is //acceptable//, since it only really affects Pholio, Phriction. And nobody places object tags in the first line, anyway. Except for my test pages, of course :/ Btw, this also removes the weird jaggy horizontal shifts for object of various lengths (e.g. `{D4356}`, `{rP32ofhw0842obw}` etc.). I think that's only good. Test Plan: Hovered in Pholio, Phriction in Chrome, FF. Did not touch left screen border. Hovered in Maniphest, Differential. Tags farther to the left were aligned left, tags more in the center were pretty centered. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1048, T2902 Differential Revision: https://secure.phabricator.com/D5612
2013-04-08 03:10:43 +02:00
'uri' => '/res/0760f768/rsrc/css/application/maniphest/task-edit.css',
Add a description preview to maniphest create / edit panel Summary: also fixes a small bug where the page title was always "Create Task". switch it to the header name which is much more descriptive / correct IMO. Test Plan: created a new task and watched the description preview update. edited an old task and saw the description preview populate with the correct existing data. edited an old task and edited the description and saw the description preview update Reviewers: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1489
2012-01-25 20:23:00 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/task-edit.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'maniphest-task-summary-css' =>
array(
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
'uri' => '/res/7aa9e2eb/rsrc/css/application/maniphest/task-summary.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/task-summary.css',
),
'maniphest-transaction-detail-css' =>
array(
Maniphest Detail view for mobile. Summary: I try to access tasks a lot on my phone, but its hard to parse. I'm sure most of this will get tossed with new transactions, but wanted to land it anyways. Test Plan: Test ticket details on iOS simulator and Chrome. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4619
2013-01-25 01:29:47 +01:00
'uri' => '/res/fb430d3e/rsrc/css/application/maniphest/transaction-detail.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/transaction-detail.css',
),
'multirow-row-manager' =>
array(
'uri' => '/res/0a9b3dee/rsrc/js/application/core/MultirowRowManager.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-util',
),
'disk' => '/rsrc/js/application/core/MultirowRowManager.js',
),
'owners-path-editor' =>
array(
Allow excluding paths from package Summary: Resolves T2149. Test Plan: $ bin/storage upgrade # /owners/ - saw + # /owners/package/1/ - saw + # /owners/edit/1/ - added exclude paths, saw correct e-mail # /rPabc123 - included paths are still highlighted and excluded not # /owners/view/search/?path=/included/ - found # /owners/view/search/?path=/excluded/ - not found # owners.query - path: /included/ # owners.query - path: /excluded/ # new unit test PhabricatorOwnersPackage::loadAffectedPackages( $repository, array('/excluded/b.php')); PhabricatorOwnersPackage::loadAffectedPackages( $repository, array('/included/a.php')); Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2149 Differential Revision: https://secure.phabricator.com/D4102
2012-12-07 02:23:56 +01:00
'uri' => '/res/29b68354/rsrc/js/application/owners/OwnersPathEditor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'multirow-row-manager',
1 => 'javelin-install',
2 => 'path-typeahead',
3 => 'javelin-dom',
4 => 'javelin-util',
Allow excluding paths from package Summary: Resolves T2149. Test Plan: $ bin/storage upgrade # /owners/ - saw + # /owners/package/1/ - saw + # /owners/edit/1/ - added exclude paths, saw correct e-mail # /rPabc123 - included paths are still highlighted and excluded not # /owners/view/search/?path=/included/ - found # /owners/view/search/?path=/excluded/ - not found # owners.query - path: /included/ # owners.query - path: /excluded/ # new unit test PhabricatorOwnersPackage::loadAffectedPackages( $repository, array('/excluded/b.php')); PhabricatorOwnersPackage::loadAffectedPackages( $repository, array('/included/a.php')); Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2149 Differential Revision: https://secure.phabricator.com/D4102
2012-12-07 02:23:56 +01:00
5 => 'phabricator-prefab',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/owners/OwnersPathEditor.js',
),
'owners-path-editor-css' =>
array(
Allow excluding paths from package Summary: Resolves T2149. Test Plan: $ bin/storage upgrade # /owners/ - saw + # /owners/package/1/ - saw + # /owners/edit/1/ - added exclude paths, saw correct e-mail # /rPabc123 - included paths are still highlighted and excluded not # /owners/view/search/?path=/included/ - found # /owners/view/search/?path=/excluded/ - not found # owners.query - path: /included/ # owners.query - path: /excluded/ # new unit test PhabricatorOwnersPackage::loadAffectedPackages( $repository, array('/excluded/b.php')); PhabricatorOwnersPackage::loadAffectedPackages( $repository, array('/included/a.php')); Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2149 Differential Revision: https://secure.phabricator.com/D4102
2012-12-07 02:23:56 +01:00
'uri' => '/res/4fcaabf6/rsrc/css/application/owners/owners-path-editor.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/owners/owners-path-editor.css',
),
Paste embeds look super cool Summary: Make Paste embeds look super cool Test Plan: {F35387} Reviewers: epriestley CC: aran, Korvin, chad, btrahan, AnhNhan Maniphest Tasks: T1770 Differential Revision: https://secure.phabricator.com/D5323
2013-03-13 14:44:27 +01:00
'paste-css' =>
array(
Add gradient to object-list cards Summary: Adds a gradient, also re-ran sprite generator to attempt to sprite - for some reason all images were un-optimized. Test Plan: Test on UI Examples page Reviewers: epriestley, btrahan Reviewed By: btrahan CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5354
2013-03-16 01:15:57 +01:00
'uri' => '/res/216fbfe9/rsrc/css/application/paste/paste.css',
Paste embeds look super cool Summary: Make Paste embeds look super cool Test Plan: {F35387} Reviewers: epriestley CC: aran, Korvin, chad, btrahan, AnhNhan Maniphest Tasks: T1770 Differential Revision: https://secure.phabricator.com/D5323
2013-03-13 14:44:27 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/paste/paste.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'path-typeahead' =>
array(
'uri' => '/res/50246fb6/rsrc/js/application/herald/PathTypeahead.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-typeahead',
2 => 'javelin-dom',
3 => 'javelin-request',
4 => 'javelin-typeahead-ondemand-source',
5 => 'javelin-util',
),
'disk' => '/rsrc/js/application/herald/PathTypeahead.js',
),
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'phabricator-action-header-view-css' =>
array(
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'uri' => '/res/948f998b/rsrc/css/layout/phabricator-action-header-view.css',
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-action-header-view.css',
),
'phabricator-action-icon-view-css' =>
array(
'uri' => '/res/8b47cf61/rsrc/css/layout/phabricator-action-icon-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-action-icon-view.css',
),
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'phabricator-action-list-view-css' =>
array(
Action Menu (mobile) Summary: First pass here, still needs some UI work (maybe? tablets?). Getting it out to see if implementation is corrrect. Test Plan: Shrink Maniphest task on Chrome, see new UI. Toggle menu. Test on iOS. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5631
2013-04-09 21:42:03 +02:00
'uri' => '/res/3d02ca59/rsrc/css/layout/phabricator-action-list-view.css',
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-action-list-view.css',
),
Add a meta-application Summary: - Adds a new "Applications" application. - Builds an application list via application config instead of via hard-coding, so we can move toward better concepts of installing/uninstalling applications, etc. - Applications indicate that they need attention with notice counts and brief status messages rathern than 50 giant tables of all sorts of app data. I want to try replacing the home screen with this screen, pretty much. Not sure if this is totally crazy or not. What does everyone else think? Test Plan: Will add screenshots. Reviewers: btrahan, chad, vrana, alanh Reviewed By: vrana CC: aran, davidreuss, champo Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3129
2012-08-02 23:07:21 +02:00
'phabricator-application-launch-view-css' =>
array(
Rework Mobile Header and Mobile Home. Summary: Mostly finished, wanted to get it into your hands to play with. I need to remove some more dead CSS and figure out where we want to put profile/logout, but overall feels pretty good. Tested a bunch in iOS and other layouts. Test Plan: Test Home, Maniphest, search bars, app menus. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2809 Differential Revision: https://secure.phabricator.com/D5407
2013-03-22 19:50:30 +01:00
'uri' => '/res/b04e66e6/rsrc/css/application/base/phabricator-application-launch-view.css',
Add a meta-application Summary: - Adds a new "Applications" application. - Builds an application list via application config instead of via hard-coding, so we can move toward better concepts of installing/uninstalling applications, etc. - Applications indicate that they need attention with notice counts and brief status messages rathern than 50 giant tables of all sorts of app data. I want to try replacing the home screen with this screen, pretty much. Not sure if this is totally crazy or not. What does everyone else think? Test Plan: Will add screenshots. Reviewers: btrahan, chad, vrana, alanh Reviewed By: vrana CC: aran, davidreuss, champo Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3129
2012-08-02 23:07:21 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/base/phabricator-application-launch-view.css',
),
Simplify lightboxing and fix a few things Summary: Minor tweaks to lightboxes. - With "position: fixed;", we don't need to do any of the scroll/resize stuff. Just remove it. - Make the lightbox go over the menu bar -- was it intentional that it wasn't? - Make 'jx-mask' use "position: fixed;" too. - Add a loading indicator. - In Differential/Maniphest/etc, a preview may bring in an image but won't bring in the CSS we need. The "real" fix is to ship CSS/JS with ajax, but that's really hard -- fake it by pulling in the right CSS any time we render a remarkup area. I'm going to do a couple of other tweaks here but need to update JX.Mask. Test Plan: Verified behavior is reasonable in Safari, Firefox, Chrome with multiple images / scroll / previews / resize. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1896 Differential Revision: https://secure.phabricator.com/D3795
2012-10-24 02:34:43 +02:00
'phabricator-busy' =>
array(
'uri' => '/res/6ec372e1/rsrc/js/application/core/Busy.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/Busy.js',
),
Add a basic chatlog Summary: This is pretty simple and unpolished, but it's getting pretty big and it seems like a reasonable starting point. - Log chat in various "channels". - Conduit record and query methods. - IRCBot integration for IRC logging Major TODO: - Web UI is really unpolished and has no search, paging, anchor-linking, etc. Basically all presentation stuff, though. - I think the bot should have a map of channels to log with channel aliases? - The "channels" should probably be in a separate table. - The "authors" should probably be correlated to Phabricator accounts somehow, where possible. Test Plan: Used phabotlocal to log #phabricator. Reviewers: kdeggelman, btrahan, Koolvin Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T837 Differential Revision: https://secure.phabricator.com/D1625
2012-02-17 19:21:38 +01:00
'phabricator-chatlog-css' =>
array(
Make chatlog a bit less awful Summary: - Default to showing the newest page of chat. - Reformat for greater readability. - Add permalinks to specific lines. - Enable jump-to-date. Test Plan: {F12200} Reviewers: Koolvin, vrana, btrahan Reviewed By: btrahan CC: kdeggelman, aran Maniphest Tasks: T837, T1065 Differential Revision: https://secure.phabricator.com/D2641
2012-06-02 23:00:08 +02:00
'uri' => '/res/f6631adc/rsrc/css/application/chatlog/chatlog.css',
Add a basic chatlog Summary: This is pretty simple and unpolished, but it's getting pretty big and it seems like a reasonable starting point. - Log chat in various "channels". - Conduit record and query methods. - IRCBot integration for IRC logging Major TODO: - Web UI is really unpolished and has no search, paging, anchor-linking, etc. Basically all presentation stuff, though. - I think the bot should have a map of channels to log with channel aliases? - The "channels" should probably be in a separate table. - The "authors" should probably be correlated to Phabricator accounts somehow, where possible. Test Plan: Used phabotlocal to log #phabricator. Reviewers: kdeggelman, btrahan, Koolvin Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T837 Differential Revision: https://secure.phabricator.com/D1625
2012-02-17 19:21:38 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/chatlog/chatlog.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-content-source-view-css' =>
array(
'uri' => '/res/8c738a93/rsrc/css/application/contentsource/content-source-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/contentsource/content-source-view.css',
),
'phabricator-core-buttons-css' =>
array(
CSS gradient buttons Summary: Creates CSS Gradients for buttons. Also tweaked hover and active styles. "Fixed" disabled state (this may require follow up diffs to correct around site) Test Plan: Tested Maniphest and UI Examples in Chrome and IE10/9/8 Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5624
2013-04-09 00:00:55 +02:00
'uri' => '/res/da2e42df/rsrc/css/core/buttons.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/buttons.css',
),
'phabricator-core-css' =>
array(
Fix IE dust. Summary: Silly IE. Test Plan: IE, Chrome Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5626
2013-04-09 18:48:46 +02:00
'uri' => '/res/263b24d7/rsrc/css/core/core.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/core.css',
),
'phabricator-countdown-css' =>
array(
'uri' => '/res/0f646281/rsrc/css/application/countdown/timer.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/countdown/timer.css',
),
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'phabricator-crumbs-view-css' =>
array(
Action Menu (mobile) Summary: First pass here, still needs some UI work (maybe? tablets?). Getting it out to see if implementation is corrrect. Test Plan: Shrink Maniphest task on Chrome, see new UI. Toggle menu. Test on iOS. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5631
2013-04-09 21:42:03 +02:00
'uri' => '/res/31ef131e/rsrc/css/layout/phabricator-crumbs-view.css',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-crumbs-view.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-directory-css' =>
array(
Replace home directory list with a dashboard Summary: Rough cut that still needs a lot of polish, but replace the directory list with more of a dashboard type thing: - Show "Unbreak Now", triage-in-your-projects, and other stuff that you're supposed to deal with, then feed. - Move tools a click a way behind nav -- this also lets us put more stuff there and subtools, etc., later. - Remove tabs. - Merge the category/item editing views. - I also added a light blue wash to the side nav, not sure if I like that or not. Test Plan: - Viewed all elements in empty and nonempty states. - Viewed applications, edited items/categories. Reviewers: btrahan, aran Reviewed By: btrahan CC: aran, epriestley, davidreuss Maniphest Tasks: T21, T631 Differential Revision: https://secure.phabricator.com/D1574
2012-02-08 01:04:48 +01:00
'uri' => '/res/61afca2b/rsrc/css/application/directory/phabricator-directory.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/directory/phabricator-directory.css',
),
'phabricator-drag-and-drop-file-upload' =>
array(
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
'uri' => '/res/df7582fd/rsrc/js/application/core/DragAndDropFileUpload.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-request',
3 => 'javelin-dom',
4 => 'javelin-uri',
Show upload status, success and failures for drag-and-drop files in notifications Summary: Currently, we do a poor job of communicating drag-and-drop upload errors. Show progress and success/failure in notifications. Test Plan: {F20671} {F20672} Uploaded files to maniphest attachments, remarkup text areas, Files tool. Reviewers: btrahan, vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3655
2012-10-09 00:23:05 +02:00
5 => 'phabricator-file-upload',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/core/DragAndDropFileUpload.js',
),
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'phabricator-dropdown-menu' =>
array(
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'uri' => '/res/2b4aa4d8/rsrc/js/application/core/DropdownMenu.js',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-dom',
3 => 'javelin-vector',
4 => 'javelin-stratcom',
5 => 'phabricator-menu-item',
),
'disk' => '/rsrc/js/application/core/DropdownMenu.js',
),
Port extension checks to new-style setup Summary: - Allow new-style setup to raise fatal setup errors. - Port extension checks to new-style setup as fatal errors. - When fatal errors are raised, abort setup and show them in a chrome-free response. Test Plan: {F29981} Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2228 Differential Revision: https://secure.phabricator.com/D4587
2013-01-23 00:16:26 +01:00
'phabricator-fatal-config-template-css' =>
array(
'uri' => '/res/6e1a8d22/rsrc/css/application/config/config-template.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/config/config-template.css',
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-feed-css' =>
array(
Mobile feed css Summary: Makes the width fluid under mobile devices. Test Plan: Test in small Chrome and iOS. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5556
2013-04-03 19:18:09 +02:00
'uri' => '/res/fa2d5d8d/rsrc/css/application/feed/feed.css',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/feed/feed.css',
),
Show upload status, success and failures for drag-and-drop files in notifications Summary: Currently, we do a poor job of communicating drag-and-drop upload errors. Show progress and success/failure in notifications. Test Plan: {F20671} {F20672} Uploaded files to maniphest attachments, remarkup text areas, Files tool. Reviewers: btrahan, vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3655
2012-10-09 00:23:05 +02:00
'phabricator-file-upload' =>
array(
Minor, fix some missing dependencies for installs with notifications off.
2012-10-09 17:34:06 +02:00
'uri' => '/res/2de10295/rsrc/js/application/core/FileUpload.js',
Show upload status, success and failures for drag-and-drop files in notifications Summary: Currently, we do a poor job of communicating drag-and-drop upload errors. Show progress and success/failure in notifications. Test Plan: {F20671} {F20672} Uploaded files to maniphest attachments, remarkup text areas, Files tool. Reviewers: btrahan, vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3655
2012-10-09 00:23:05 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Minor, fix some missing dependencies for installs with notifications off.
2012-10-09 17:34:06 +02:00
1 => 'javelin-dom',
2 => 'phabricator-notification',
Show upload status, success and failures for drag-and-drop files in notifications Summary: Currently, we do a poor job of communicating drag-and-drop upload errors. Show progress and success/failure in notifications. Test Plan: {F20671} {F20672} Uploaded files to maniphest attachments, remarkup text areas, Files tool. Reviewers: btrahan, vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D3655
2012-10-09 00:23:05 +02:00
),
'disk' => '/rsrc/js/application/core/FileUpload.js',
),
Minor, map regen.
2012-08-22 00:03:01 +02:00
'phabricator-filetree-view-css' =>
array(
Use white "+" icon for homepage tile hoverstate Summary: The easiest approach here is proably to provide a more specific rule in the sheet CSS. This saves us from having to write any JS, notably. Test Plan: Hovered over "+" on homepage. Reviewers: chad, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4579
2013-01-22 18:56:18 +01:00
'uri' => '/res/c912ed91/rsrc/css/layout/phabricator-filetree-view.css',
Minor, map regen.
2012-08-22 00:03:01 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-filetree-view.css',
),
Add "Flags" to allow users to collect the things they love Summary: Flags are a personal collection of things you want to take a look at later. You can use several different colors and add notes. Not really sure if this is actually a good idea or not but it was easy to build. Planned features: - Allow Herald rules to add flags. - In the "edit flag" dialog, have a "[x] Subscribe Me" checkbox that CCs you. - Support Diffusion. - Support Phriction. - Always show flags on an object if you have them (in every view)? - Edit dialog feels a little heavy? - More filtering in /flag/ tool. - Add a top-level links somewhere? Test Plan: Added, edited and removed flags from things. Viewed flags in flag view. Reviewers: aran, btrahan Reviewed By: btrahan CC: aran, epriestley, Koolvin Maniphest Tasks: T1041 Differential Revision: https://secure.phabricator.com/D2024
2012-03-28 01:22:40 +02:00
'phabricator-flag-css' =>
array(
Phortune v0.1: products Summary: Ref T2787. A product is the abstract representation of something you can buy or rent/subscribe to. Although the interface isn't locked down yet, this would ultimately be internal/administrative. Products likely have some user-facing skin on top of them: plans would have a purchasing/comparison flow, physical goods would have a storefront, etc., so products don't have any information like descriptions or images, just the data that Phortune needs to correctly bill accounts. Generally, this is very basic for the moment. Test Plan: {F37594} {F37595} {F37596} Reviewers: chad, btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2787 Differential Revision: https://secure.phabricator.com/D5441
2013-03-28 17:13:07 +01:00
'uri' => '/res/237234d7/rsrc/css/application/flag/flag.css',
Add "Flags" to allow users to collect the things they love Summary: Flags are a personal collection of things you want to take a look at later. You can use several different colors and add notes. Not really sure if this is actually a good idea or not but it was easy to build. Planned features: - Allow Herald rules to add flags. - In the "edit flag" dialog, have a "[x] Subscribe Me" checkbox that CCs you. - Support Diffusion. - Support Phriction. - Always show flags on an object if you have them (in every view)? - Edit dialog feels a little heavy? - More filtering in /flag/ tool. - Add a top-level links somewhere? Test Plan: Added, edited and removed flags from things. Viewed flags in flag view. Reviewers: aran, btrahan Reviewed By: btrahan CC: aran, epriestley, Koolvin Maniphest Tasks: T1041 Differential Revision: https://secure.phabricator.com/D2024
2012-03-28 01:22:40 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/flag/flag.css',
),
Make the paste creation form work on phones Summary: This is the first time I've ever had CSS actually work like it promises it does (i.e., markup the "right" way and then you don't have to change the markup later). Since I laboriously laid this whole thing out with <divs> originally, I was able to just override some of the styles and make the layout reasonable for devices. The only differences for existing forms are: - No colon after labels (looks cleaner anyway). - Non-error required text is no longer a red star but a the grey word "Required" (this is clearer). Test Plan: Viewed paste form on a phone. Viewed ~20 other forms on the site to verify that I didn't break anything. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3298
2012-08-15 23:15:12 +02:00
'phabricator-form-view-css' =>
array(
Remove overflow:hidden from form-view Summary: Typeaheads that are overflow have their contents hidden inside the form view. Test Plan: Tested Creating a Mock. Would like guidance on what this was solving so we can find something else. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2690 Differential Revision: https://secure.phabricator.com/D5290
2013-03-08 16:38:54 +01:00
'uri' => '/res/676b1ad2/rsrc/css/layout/phabricator-form-view.css',
Make the paste creation form work on phones Summary: This is the first time I've ever had CSS actually work like it promises it does (i.e., markup the "right" way and then you don't have to change the markup later). Since I laboriously laid this whole thing out with <divs> originally, I was able to just override some of the styles and make the layout reasonable for devices. The only differences for existing forms are: - No colon after labels (looks cleaner anyway). - Non-error required text is no longer a red star but a the grey word "Required" (this is clearer). Test Plan: Viewed paste form on a phone. Viewed ~20 other forms on the site to verify that I didn't break anything. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3298
2012-08-15 23:15:12 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-form-view.css',
),
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'phabricator-header-view-css' =>
array(
Add isNormalMouseEvent() to Javelin Summary: Added isNormalMouseEvent() that returns true if left mouse button triggered event click, mousedown or mouseup. Modified isNormalMouseClick() to use new function. Test Plan: Verified that new function works for click, mousedown and mouseup events. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2475 Differential Revision: https://secure.phabricator.com/D4778
2013-02-01 17:48:16 +01:00
'uri' => '/res/585b771c/rsrc/css/layout/phabricator-header-view.css',
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-header-view.css',
),
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
'phabricator-hovercard' =>
array(
Fix the attempt of graceful alignment for Hovercards Summary: Refs T1048; Fixes T2902 - (Probably) fixes @vrana's issue. I managed to repro it on Ubuntu FF (though on Windows with 1.0GHz/512MB it's really worse...). This revises the approach to the graceful degradation for `too-far-to-the-screen-edge-edge-case`. I noticed that `x` could become very negative, up to about ~`-170px`. This is due to the //"already-on-the-left-side"// nature of object tags. `50 - 200 - 20` = `negative`. Adding `100px` (node.dimension.x / 4) to that won't really help, as the hovercard would still be offscreen. Instead, display them left-aligned with the object tags on the left edge per default, and offer centerization in center cases. This is also better for Pholio, Phriction, which have a way lower min-x than Maniphest, Differential. I also disabled placing the hovercard below the tag in case there's not enough space on the north side. The hovercard would not display 99.99% of the times after being hidden (and it retains the flickering behaviour). Another reason is also our current hide-behaviour, which only assumes north-side alignment. Adding south-side didn't really work (I'm bad with JS), so I didn't bother with it. Disabling this is //acceptable//, since it only really affects Pholio, Phriction. And nobody places object tags in the first line, anyway. Except for my test pages, of course :/ Btw, this also removes the weird jaggy horizontal shifts for object of various lengths (e.g. `{D4356}`, `{rP32ofhw0842obw}` etc.). I think that's only good. Test Plan: Hovered in Pholio, Phriction in Chrome, FF. Did not touch left screen border. Hovered in Maniphest, Differential. Tags farther to the left were aligned left, tags more in the center were pretty centered. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1048, T2902 Differential Revision: https://secure.phabricator.com/D5612
2013-04-08 03:10:43 +02:00
'uri' => '/res/d70f1091/rsrc/js/application/core/Hovercard.js',
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
Load hovercards on-demand Summary: See discussion in D5563. This loads hovercards on-demand, and shows them once they load. Ref T1048. Test Plan: Made a preview comment like `T1`, waved my mouse over it, got a hovercard shortly thereafter. Reviewers: AnhNhan Reviewed By: AnhNhan CC: aran Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5588
2013-04-05 20:01:56 +02:00
1 => 'javelin-dom',
2 => 'javelin-vector',
3 => 'javelin-request',
4 => 'javelin-uri',
Hovercard front-end code & stuff Summary: Refs T1048; Depends on D5557, D5558 They hover right above your eyes. Try it out at home :D (in that case, don't forget to checkout D5557 and D5558) Worth a lot of improvement. But it's great for now after a little bit of styling. Scrape load (search current document for all hovercards and pre-load them) and lazy load (e.g. previewing comments which is not covered by scrape load) implemented. Added some seemingly useful graceful situations. Too much to the left, too much to the top. Test Plan: Tested on Ubuntu, Chrome and FF. No Windows yet, since I have it live at no place. Works pretty fine, at least it will appear. Could test left graceful fallback. Don't know what happens if you place it too far to the top. I expect either good results or placement about the center of the screen in case of glitches. For now, they'll disappear right away once the mouse leaves the object tag. Intended is when leaving both tag and hovercard. Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5563 Conflicts: src/__celerity_resource_map__.php
2013-04-05 17:31:35 +02:00
),
'disk' => '/rsrc/js/application/core/Hovercard.js',
),
First pass at hovercard design Summary: Refs T1048 - I'm pretty happy and happy to tell you Savepoint CR Everything's dummy right now. If you are testing locally, don't forget to edit the PHIDs. Or populate your own handles. Doesn't really matter. I'm mainly sending it in for the CSS, not the messy PHP code. Ignore the `margin: auto`, that's just for looking nice. Test Plan: UI Example » Hovercard Reviewers: epriestley, chad CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5519
2013-04-02 18:15:33 +02:00
'phabricator-hovercard-view-css' =>
array(
Hovercard tweaks Summary: Tightens up spacing, remove some of the borders, add alpha channel, make them all blue (sorry, red green and yellow are for 'status'). If we want to do more colors just for hovercards, I have a brown and a black in the mock, but would like to try just blue for now. Test Plan: UIExamples, Tasks, People, Diffs, and Pastes. Reviewers: epriestley, AnhNhan, btrahan CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5609
2013-04-07 06:13:11 +02:00
'uri' => '/res/80683f88/rsrc/css/layout/phabricator-hovercard-view.css',
First pass at hovercard design Summary: Refs T1048 - I'm pretty happy and happy to tell you Savepoint CR Everything's dummy right now. If you are testing locally, don't forget to edit the PHIDs. Or populate your own handles. Doesn't really matter. I'm mainly sending it in for the CSS, not the messy PHP code. Ignore the `margin: auto`, that's just for looking nice. Test Plan: UI Example » Hovercard Reviewers: epriestley, chad CC: aran, Korvin Maniphest Tasks: T1048 Differential Revision: https://secure.phabricator.com/D5519
2013-04-02 18:15:33 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-hovercard-view.css',
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-jump-nav' =>
array(
Fix Main Directory Jump Nav CSS leak Summary: Good that this isn't a water leak. Else I'd be screwed. Test Plan: Visited Main Dir. Looks normal. Visited Maniphest. Saw ominous shadow on top for saved query. Saw normal paddings for populated list filters. Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5536
2013-04-02 18:01:09 +02:00
'uri' => '/res/745c0e89/rsrc/css/application/directory/phabricator-jump-nav.css',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/directory/phabricator-jump-nav.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-keyboard-shortcut' =>
array(
'uri' => '/res/beed38cd/rsrc/js/application/core/KeyboardShortcut.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'phabricator-keyboard-shortcut-manager',
),
'disk' => '/rsrc/js/application/core/KeyboardShortcut.js',
),
'phabricator-keyboard-shortcut-manager' =>
array(
Allow speical keys to be bound to keystrokes Summary: Fixes T2711. Allows special keys (arrows, tab, return) to be bound as shortcuts. Binds left and right as shortcuts in Pholio. Test Plan: Pressed left. Pressed right. Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2711 Differential Revision: https://secure.phabricator.com/D5303
2013-03-09 06:19:24 +01:00
'uri' => '/res/d0bee7c7/rsrc/js/application/core/KeyboardShortcutManager.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-dom',
4 => 'javelin-vector',
),
'disk' => '/rsrc/js/application/core/KeyboardShortcutManager.js',
),
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'phabricator-main-menu-view' =>
array(
Rework desktop header Summary: Removes the glow icons and uses a hover change. Fixes phantom anchors. Test Plan: Review in Chrome at various sizes (phone tablet). Check that icons still work. Check that mobile menus render when clicked. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2876 Differential Revision: https://secure.phabricator.com/D5549
2013-04-03 17:26:36 +02:00
'uri' => '/res/63316e1a/rsrc/css/application/base/main-menu-view.css',
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/base/main-menu-view.css',
),
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'phabricator-menu-item' =>
array(
Fill <a href> in PhabricatorMenuItem Summary: The <a href> attribute is useful because user knows where the link goes before opening it plus he can copy it to the clipboard plus he can add it to the bookmarks. Test Plan: Display revision. View Options. Click. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D1436
2012-01-17 07:17:18 +01:00
'uri' => '/res/32fc2325/rsrc/js/application/core/DropdownMenuItem.js',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/DropdownMenuItem.js',
),
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
'phabricator-nav-view-css' =>
array(
Fix iphone scrolling behavior on homepage Summary: I see a flash of white on my iPhone emulator and on the actual device when I scroll down. Make the texture bigger to prevent it. Test Plan: Scrolled on emulator, no more white flash. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5416
2013-03-22 20:09:10 +01:00
'uri' => '/res/fb026f2e/rsrc/css/aphront/phabricator-nav-view.css',
Allow pages to use new "flexible" nav Summary: This allows the nav to be laid out with divs instead of tables and for the navigation column to be made flexible. Design is non-final, this is just a step toward reactive menus that work on tablets/phones and an application menu. I'm going to play around with flexible nav and document navigation and see if that goes anywhere. Test Plan: Will attach screenshots. Reviewers: btrahan, vrana, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3114
2012-08-01 21:31:33 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/phabricator-nav-view.css',
),
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'phabricator-notification' =>
array(
Minor, fix some missing dependencies for installs with notifications off.
2012-10-09 17:34:06 +02:00
'uri' => '/res/ad727561/rsrc/js/application/core/Notification.js',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
Add multiple notifications and notification types Summary: - Allow more than one notification to be shown. - Allow notifications to be customized with extra classes. Test Plan: {F12776} Reviewers: allenjohnashton, ddfisher, keebuhm, jungejason Reviewed By: jungejason CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2758
2012-06-17 20:35:36 +02:00
3 => 'javelin-util',
Minor, fix some missing dependencies for installs with notifications off.
2012-10-09 17:34:06 +02:00
4 => 'phabricator-notification-css',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
),
'disk' => '/rsrc/js/application/core/Notification.js',
),
'phabricator-notification-css' =>
array(
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'uri' => '/res/664b9bec/rsrc/css/aphront/notification.css',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/notification.css',
),
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'phabricator-notification-menu-css' =>
array(
Notications mobile menu Summary: Adding CSS so the notifications menu renders over content on mobile, also it was sort of broken at some point. Test Plan: Tested Mobile, Tablet and regular layouts. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5424
2013-03-23 00:15:28 +01:00
'uri' => '/res/bc245b67/rsrc/css/application/base/notification-menu.css',
Switch to new menubar Summary: - Looks better (can probably still use some tweaks), especially search. - Moves logout from weird footer location to main menu. - Reactive: on tablets and phones, the menu adjusts to remain useful. - Fixed position on desktops for future side nav changes. - Adds an icon header thing that's currently hard-coded but will be application-driven soon. Test Plan: Used menu on desktop, tablet, phone, logged in / logged out, toggled darkconsole. Will add some screenshots. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3105
2012-07-31 01:09:14 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/base/notification-menu.css',
),
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'phabricator-object-item-list-view-css' =>
array(
Add a "byline" element to ObjectItemListView Summary: At least for non-workboard views, try plain text for author information instead of profile images. Some discussion in D5451. Test Plan: {F39411} {F39412} {F39413} {F39414} {F39415} {F39416} Reviewers: chad Reviewed By: chad CC: AnhNhan, aran Differential Revision: https://secure.phabricator.com/D5605
2013-04-06 20:38:43 +02:00
'uri' => '/res/c49799c6/rsrc/css/layout/phabricator-object-item-list-view.css',
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-object-item-list-view.css',
),
Make project membership edits use transactions and PHIDs and not be awful Summary: - Split project profile editing apart from project membership editing. - Make project membership editing simpler and easier to use. - Drop role / owner stuff from the UI. Test Plan: Added and removed project members. Edited project profile information. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D3184
2012-08-07 20:57:38 +02:00
'phabricator-object-list-view-css' =>
array(
Allow commits to be associated with projects and associated goodies Summary: - Commit detail view - List of projects - "edit" action which takes the user to a simple form where they can only add / remove projects. - Integrated the project relationship into the commit search indexer - fixed a bug from D790; it seems you must select the column if you're going to join against it later. Without this change searching for author or projectfails 100% for me. Test Plan: added and removed projects. verified appropriate projects showed up in detail and edit view. searched for commits by project and found the ones I was supposed to...! Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1614 Differential Revision: https://secure.phabricator.com/D3189
2012-08-08 19:03:41 +02:00
'uri' => '/res/4f183668/rsrc/css/application/projects/phabricator-object-list-view.css',
Make project membership edits use transactions and PHIDs and not be awful Summary: - Split project profile editing apart from project membership editing. - Make project membership editing simpler and easier to use. - Drop role / owner stuff from the UI. Test Plan: Added and removed project members. Edited project profile information. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D3184
2012-08-07 20:57:38 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/projects/phabricator-object-list-view.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-object-selector-css' =>
array(
Increase the click target area for the object selector Summary: Make clicking the link also select the object (this operation is very common). Add an arrow to the left to view the object (this operation is very rare). Increase link target area to the entire cell. Also simplify some handlers. Test Plan: Clicked things with wild abandon. Behavior seemed unchanged. Reviewers: cpiro, btrahan Reviewed By: cpiro CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1962
2012-03-20 03:20:49 +01:00
'uri' => '/res/7eb4c705/rsrc/css/application/objectselector/object-selector.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
0 => 'aphront-dialog-view-css',
),
'disk' => '/rsrc/css/application/objectselector/object-selector.css',
),
Update Javelin to D3573 Summary: Pull in the latest version of Javelin. Test Plan: Used application typeahead on a ":8080" install, got sent to the right URI. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3584
2012-10-01 23:09:33 +02:00
'phabricator-pinboard-view-css' =>
array(
Re-run celerity mapper Summary: D5226 nixed something I put in the celerity map. This diff adds it back, along with a bunch of other changes that `./scripts/celerity_mapper.php webroot/` decided were super important. Test Plan: Repeatedly place click actions into the HTML `document`. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5253
2013-03-06 15:15:24 +01:00
'uri' => '/res/61ecd7cf/rsrc/css/layout/phabricator-pinboard-view.css',
Update Javelin to D3573 Summary: Pull in the latest version of Javelin. Test Plan: Used application typeahead on a ":8080" install, got sent to the right URI. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3584
2012-10-01 23:09:33 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-pinboard-view.css',
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-prefab' =>
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
array(
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'uri' => '/res/7bf0bc20/rsrc/js/application/core/Prefab.js',
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
2 => 'javelin-dom',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
3 => 'javelin-typeahead',
4 => 'javelin-tokenizer',
5 => 'javelin-typeahead-preloaded-source',
6 => 'javelin-typeahead-ondemand-source',
7 => 'javelin-dom',
8 => 'javelin-stratcom',
9 => 'javelin-util',
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'disk' => '/rsrc/js/application/core/Prefab.js',
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-profile-css' =>
array(
'uri' => '/res/9869d10b/rsrc/css/application/profile/profile-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/profile/profile-view.css',
),
'phabricator-profile-header-css' =>
array(
Add a Join / Leave button to Projects Summary: Make it easy to join or leave (well, slightly less easy) a project. Publish join/leave to feed. Fix a couple of membership editor bugs. Test Plan: Joined, left a project. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T681 Differential Revision: https://secure.phabricator.com/D1485
2012-01-25 20:51:20 +01:00
'uri' => '/res/4b1cb23b/rsrc/css/application/profile/profile-header-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/profile/profile-header-view.css',
),
Show projects on Maniphest tasks Summary: - Remove the "Priority" column, since this is indicated by the color swatch, to save space. - Reduce the "Updated" column from datetime to date only, since time isn't incredibly useful, to save space. - Show the first two projects a task is associated with, and "..." if there are more. - Show "None" (for "no owner") in a lighter color. Test Plan: Looked at tasks on homepage and in Maniphest. Reviewers: btrahan, 20after4 Reviewed By: btrahan CC: aran, edward Maniphest Tasks: T967 Differential Revision: https://secure.phabricator.com/D2065
2012-04-02 19:27:31 +02:00
'phabricator-project-tag-css' =>
array(
Fixing the annoying spacing between project tags. Test Plan: Apply the changes and refresh the Maniphest task list. Reviewers: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5272
2013-03-07 17:06:42 +01:00
'uri' => '/res/1b5efcb2/rsrc/css/application/projects/project-tag.css',
Show projects on Maniphest tasks Summary: - Remove the "Priority" column, since this is indicated by the color swatch, to save space. - Reduce the "Updated" column from datetime to date only, since time isn't incredibly useful, to save space. - Show the first two projects a task is associated with, and "..." if there are more. - Show "None" (for "no owner") in a lighter color. Test Plan: Looked at tasks on homepage and in Maniphest. Reviewers: btrahan, 20after4 Reviewed By: btrahan CC: aran, edward Maniphest Tasks: T967 Differential Revision: https://secure.phabricator.com/D2065
2012-04-02 19:27:31 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/projects/project-tag.css',
),
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'phabricator-property-list-view-css' =>
array(
Tighten pinboard view. Summary: Removes a little slop from the top and right of the pinboard view. Test Plan: Tested Macro and Pholio layouts. Things wrapped less. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5197
2013-03-03 22:32:02 +01:00
'uri' => '/res/a04cc81d/rsrc/css/layout/phabricator-property-list-view.css',
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-property-list-view.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-remarkup-css' =>
array(
Minor, update celerity map.
2013-03-19 14:48:08 +01:00
'uri' => '/res/a53fa430/rsrc/css/core/remarkup.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/remarkup.css',
),
'phabricator-search-results-css' =>
array(
'uri' => '/res/f8a86e27/rsrc/css/application/search/search-results.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/search/search-results.css',
),
Placed Radio buttons for Home Page Preferences Settings Summary: Replaced AphrontFormSelectControl in PhabricatorSettingsPanelHomePreferences with AphrontFormRadioButtonControl :). Test Plan: By checking out Home page prefreces setting and playing around the values to see if it works ! Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin, chad, demo, AnhNhan Maniphest Tasks: T2340 Differential Revision: https://secure.phabricator.com/D5414
2013-04-09 18:43:41 +02:00
'phabricator-settings-css' =>
array(
'uri' => '/res/fb9d017f/rsrc/css/application/settings/settings.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/settings/settings.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-shaped-request' =>
array(
Handle error in comment preview Test Plan: Triggered error in comment preview (see D3589), verified that the error is displayed. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3586
2012-10-01 23:56:57 +02:00
'uri' => '/res/fbdb92db/rsrc/js/application/core/ShapedRequest.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-request',
),
'disk' => '/rsrc/js/application/core/ShapedRequest.js',
),
Refactor the main menu in preparation for a mobile application menu Summary: As per discussion, this primes the existing mobile menu / menu button for "phabricator" and "application" menus. Design here is very rough, I'm just trying to get everything laid in functionally first. It's based on `frame_v3.png` but missing a lot of touches. Test Plan: {F26143} {F26144} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T1960 Differential Revision: https://secure.phabricator.com/D4058
2012-12-07 22:33:03 +01:00
'phabricator-side-menu-view-css' =>
array(
Allows a button type for menus, used in Conpherence Summary: This adds a new menu item, TYPEBUTTON, for use in Conpherence and maybe others over time. Note I need to add icon support, but I'll make them later tonight. I also changed the front facing names to 'Conversations' which is way more natural. Basically, Pholio has Mocks, Differential has Diffs, Conpherence has Conversations. Test Plan: Tested Conpherence on mobile and desktop. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2430 Differential Revision: https://secure.phabricator.com/D4691
2013-01-29 19:20:17 +01:00
'uri' => '/res/28a1e092/rsrc/css/layout/phabricator-side-menu-view.css',
Refactor the main menu in preparation for a mobile application menu Summary: As per discussion, this primes the existing mobile menu / menu button for "phabricator" and "application" menus. Design here is very rough, I'm just trying to get everything laid in functionally first. It's based on `frame_v3.png` but missing a lot of touches. Test Plan: {F26143} {F26144} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T1960 Differential Revision: https://secure.phabricator.com/D4058
2012-12-07 22:33:03 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-side-menu-view.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-slowvote-css' =>
array(
'uri' => '/res/94d20443/rsrc/css/application/slowvote/slowvote.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/slowvote/slowvote.css',
),
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'phabricator-source-code-view-css' =>
array(
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
'uri' => '/res/979d5280/rsrc/css/layout/phabricator-source-code-view.css',
Modernize Paste Summary: - Add a PhabricatorApplication. - Make most of the views work well on tablets / phones. The actual "Create" form doesn't, but everything else is good -- need to make device-friendly form layouts before I can do the form. Test Plan: Will attach screenshots. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3293
2012-08-15 19:45:06 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-source-code-view.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-standard-page-view' =>
array(
Add support for device swipe events Summary: Ref T2700. Allow JS to listen for swipes on devices. There are a bunch of tricky cases here and I probably didn't get them all totally right, but this interaction broadly looks like this: - We implement gesture recognition for the mouse in device modes (narrow browser), and for touch events from an actual device. - The sigil `touchable` indicates that a node wants to react to touch events. - When the user touches a `touchable` node, we start listening for moves. They might be tapping/clicking (in which case we don't care), but they might also be gesturing. - Once the user moves their finger/pointer far enough away from the tap origin, we recognize it as a gesture. I hardcoded this at 20px; I wasn't able to find any "official" Apple value, but 20px seems like a common default. - At this point, we look at where their finger has moved. - If they moved it mostly up/down, we interpret the gesture as "scroll" and just stop listening. The device does its own thing. - However, if they moved it mostly left/right, we interpret it as a "swipe". We start killing the moves so the device doesn't scroll. - Once we've recognized that a gesture is underway, we send a "gesture.swipe.start" event and then "gesture.swipe.move" events for every move. - When the user ends the gesture, we send "gesture.swipe.end". - If the user cancels the gesture (currently, only by tapping with a second finger), we send "gesture.swipe.cancel". - Gesture events have raw position data and some convenience fields. Test Plan: Wrote UI example and used it from the Desktop, iPhone simulator, and a real iphone. - The code always seems to get "scroll" vs "swipe" correct (i.e., consistent with my intentions). - The threshold feels pretty good to me. - Tapping with a second finger cancels the action. Reviewers: chad, btrahan Reviewed By: chad CC: aran Maniphest Tasks: T2700 Differential Revision: https://secure.phabricator.com/D5308
2013-03-09 22:53:15 +01:00
'uri' => '/res/70fa2da4/rsrc/css/application/base/standard-page-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/base/standard-page-view.css',
),
Build PhabricatorTagView Summary: Builds out most of the non-hover-stuff from `overview-hovercards.png`. Things I didn't build: - Tokens (I like them a lot but don't want to scope creep) - Functions (backend mess / future work) - Icons for tags. - Tags with pointy ends and holes in them (an earlier mock had this I think but they're gone on final) - The cyaney color for "Sporadic" since I just noticed it while typing this up. Test Plan: Looked at UIExample page. Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2089 Differential Revision: https://secure.phabricator.com/D4029
2012-11-24 15:47:06 +01:00
'phabricator-tag-view-css' =>
array(
'uri' => '/res/e10bf844/rsrc/css/layout/phabricator-tag-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-tag-view.css',
),
Minor, fix bad Celerity Map merge.
2012-10-02 03:48:39 +02:00
'phabricator-textareautils' =>
array(
'uri' => '/res/703614ea/rsrc/js/application/core/TextAreaUtils.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
'disk' => '/rsrc/js/application/core/TextAreaUtils.js',
),
Improve Lightbox behavior for nonstandard clicks Summary: When users middle click or command-click an image, we should open it in a new tab, not open a lightbox. See https://github.com/facebook/phabricator/issues/234 Test Plan: Left, middle, and command-clicked a lightbox image. Reviewers: vrana, chad, btrahan Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4020
2012-11-22 17:25:13 +01:00
'phabricator-timeline-view-css' =>
array(
Implement basic transaction detail blocks Summary: Some transactions (like editing configuration values, task descriptions, or Conpherence images) can't be simply explained and need an additional larger element to show them fully (like a text diff). Support change details like this in ApplicationTransactions. Implements the element in Config, so you can see changes. Test Plan: {F32974} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2213 Differential Revision: https://secure.phabricator.com/D4984
2013-02-17 15:37:02 +01:00
'uri' => '/res/5517bf1a/rsrc/css/layout/phabricator-timeline-view.css',
Improve Lightbox behavior for nonstandard clicks Summary: When users middle click or command-click an image, we should open it in a new tab, not open a lightbox. See https://github.com/facebook/phabricator/issues/234 Test Plan: Left, middle, and command-clicked a lightbox image. Reviewers: vrana, chad, btrahan Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4020
2012-11-22 17:25:13 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-timeline-view.css',
),
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'phabricator-tooltip' =>
array(
Add draft support to ApplicationTransactions Summary: When previewing, save drafts. When loading objects, restore drafts if they are available. Depends on: D665 Test Plan: - Viewed a Mock. - Typed text into the comment box. - Reloaded the page. - Text still there. - Hit submit, got my comment. - Reloaded the page. - Draft correctly deleted. - Repeated for Macros. Reviewers: btrahan, chad, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T2104 Differential Revision: https://secure.phabricator.com/D4252
2012-12-21 14:57:14 +01:00
'uri' => '/res/55d76b9b/rsrc/js/application/core/ToolTip.js',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-dom',
3 => 'javelin-vector',
),
'disk' => '/rsrc/js/application/core/ToolTip.js',
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-transaction-view-css' =>
array(
Pholio inline comments have a minimum size Summary: Pholio inline comments now have minimum size of 16x16 px Test Plan: Made some inlines Reviewers: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2647 Differential Revision: https://secure.phabricator.com/D5250
2013-03-10 17:22:21 +01:00
'uri' => '/res/00be4b1a/rsrc/css/aphront/transaction.css',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/transaction.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-ui-example-css' =>
array(
Add a "toggle-class" behavior Summary: The new menu stuff needs this but it was easy to pull out on its own. Test Plan: Cliked UI example buttons. Reviewers: btrahan, chad Reviewed By: btrahan CC: aran Maniphest Tasks: T1569 Differential Revision: https://secure.phabricator.com/D3104
2012-07-31 01:08:42 +02:00
'uri' => '/res/376ab671/rsrc/css/application/uiexample/example.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/uiexample/example.css',
),
'phabricator-uiexample-javelin-view' =>
array(
'uri' => '/res/a2ce2cfc/rsrc/js/application/uiexample/JavelinViewExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/uiexample/JavelinViewExample.js',
),
'phabricator-uiexample-reactor-button' =>
array(
'uri' => '/res/142127f6/rsrc/js/application/uiexample/ReactorButtonExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorButtonExample.js',
),
'phabricator-uiexample-reactor-checkbox' =>
array(
'uri' => '/res/c75cb9e9/rsrc/js/application/uiexample/ReactorCheckboxExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorCheckboxExample.js',
),
'phabricator-uiexample-reactor-focus' =>
array(
'uri' => '/res/3cc992eb/rsrc/js/application/uiexample/ReactorFocusExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorFocusExample.js',
),
'phabricator-uiexample-reactor-input' =>
array(
'uri' => '/res/4953da16/rsrc/js/application/uiexample/ReactorInputExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
5 => 'javelin-view-html',
6 => 'javelin-view-interpreter',
7 => 'javelin-view-renderer',
),
'disk' => '/rsrc/js/application/uiexample/ReactorInputExample.js',
),
'phabricator-uiexample-reactor-mouseover' =>
array(
'uri' => '/res/52a355b6/rsrc/js/application/uiexample/ReactorMouseoverExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorMouseoverExample.js',
),
'phabricator-uiexample-reactor-radio' =>
array(
'uri' => '/res/ae87f3af/rsrc/js/application/uiexample/ReactorRadioExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorRadioExample.js',
),
'phabricator-uiexample-reactor-select' =>
array(
'uri' => '/res/23cb448a/rsrc/js/application/uiexample/ReactorSelectExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorSelectExample.js',
),
'phabricator-uiexample-reactor-sendclass' =>
array(
'uri' => '/res/8cd34264/rsrc/js/application/uiexample/ReactorSendClassExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorSendClassExample.js',
),
'phabricator-uiexample-reactor-sendproperties' =>
array(
'uri' => '/res/18af54aa/rsrc/js/application/uiexample/ReactorSendPropertiesExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorSendPropertiesExample.js',
),
Minor, fix celerity map.
2013-04-01 05:07:47 +02:00
'phabricator-workboard-view-css' =>
array(
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'uri' => '/res/14217087/rsrc/css/layout/phabricator-workboard-view.css',
Minor, fix celerity map.
2013-04-01 05:07:47 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-workboard-view.css',
),
'phabricator-workpanel-view-css' =>
array(
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'uri' => '/res/ff5d5b26/rsrc/css/layout/phabricator-workpanel-view.css',
Minor, fix celerity map.
2013-04-01 05:07:47 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/layout/phabricator-workpanel-view.css',
),
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'phabricator-zindex-css' =>
array(
Move hovercard z-index up Summary: Fixes T2912. I put this above dialogs but below tooltips, which I think is the right place. Test Plan: {F39797} Reviewers: chad, AnhNhan, edward Reviewed By: chad CC: aran Maniphest Tasks: T2912 Differential Revision: https://secure.phabricator.com/D5629
2013-04-09 20:17:46 +02:00
'uri' => '/res/5a43594e/rsrc/css/core/z-index.css',
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/z-index.css',
),
Add concept of "skins" to phame, and add a phacility skin Summary: introduce an abstract "PhameBlogSkin" class and instantiate two versions -- PhabricatorBlogSkin (Default) and PhacilityBlogSkin. Most notable hack is including the directory /rsrc/images/phacility - this lets things "work" without messing around with the phacility.com CSS and instead just cutting and pasting most of the file. Test Plan: played around with Phame a bunch. In particular, created a blog with a custom domain and the phacility skin. Verified it looked good and individual posts looked okay. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1373 Differential Revision: https://secure.phabricator.com/D3687
2012-10-13 01:01:33 +02:00
'phame-css' =>
Modernize phame and add concept of "blog style" to blog post list view Summary: "blog style" for now is just "true" to make this UI render better for the blog LATER it will be a string which will choose the larger template. this will also have to do some messing around with links; when viewing on a phabricator instance links need to be a bit dirtier to carry around the blog whereas when viewing offsite we can tell what blog it is based on the host domain. anyhoo, this is future diff work Test Plan: looked at blog - less ugly. resized blog to smaller sizes - became a "single list" of goodness for quality reading quite quickly. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1373 Differential Revision: https://secure.phabricator.com/D3587
2012-10-02 00:37:02 +02:00
array(
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'uri' => '/res/8e3edb71/rsrc/css/application/phame/phame.css',
Modernize phame and add concept of "blog style" to blog post list view Summary: "blog style" for now is just "true" to make this UI render better for the blog LATER it will be a string which will choose the larger template. this will also have to do some messing around with links; when viewing on a phabricator instance links need to be a bit dirtier to carry around the blog whereas when viewing offsite we can tell what blog it is based on the host domain. anyhoo, this is future diff work Test Plan: looked at blog - less ugly. resized blog to smaller sizes - became a "single list" of goodness for quality reading quite quickly. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1373 Differential Revision: https://secure.phabricator.com/D3587
2012-10-02 00:37:02 +02:00
'type' => 'css',
'requires' =>
array(
),
Add concept of "skins" to phame, and add a phacility skin Summary: introduce an abstract "PhameBlogSkin" class and instantiate two versions -- PhabricatorBlogSkin (Default) and PhacilityBlogSkin. Most notable hack is including the directory /rsrc/images/phacility - this lets things "work" without messing around with the phacility.com CSS and instead just cutting and pasting most of the file. Test Plan: played around with Phame a bunch. In particular, created a blog with a custom domain and the phacility skin. Verified it looked good and individual posts looked okay. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1373 Differential Revision: https://secure.phabricator.com/D3687
2012-10-13 01:01:33 +02:00
'disk' => '/rsrc/css/application/phame/phame.css',
Modernize phame and add concept of "blog style" to blog post list view Summary: "blog style" for now is just "true" to make this UI render better for the blog LATER it will be a string which will choose the larger template. this will also have to do some messing around with links; when viewing on a phabricator instance links need to be a bit dirtier to carry around the blog whereas when viewing offsite we can tell what blog it is based on the host domain. anyhoo, this is future diff work Test Plan: looked at blog - less ugly. resized blog to smaller sizes - became a "single list" of goodness for quality reading quite quickly. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T1373 Differential Revision: https://secure.phabricator.com/D3587
2012-10-02 00:37:02 +02:00
),
Pholio tile to home page and mock to show first image Summary: Pholio tile to show up on home page First image is shown at mock page. Test Plan: Pholio app shows up on home page. First image is shown at mock page. Reviewers: epriestley CC: aran, Korvin Maniphest Tasks: T2356 Differential Revision: https://secure.phabricator.com/D4553
2013-01-20 18:29:34 +01:00
'pholio-css' =>
array(
Pholio inline comment now include a thumbnail and link Summary: Pholio inline comment now include a thumbnail and link to the Image being commented on Test Plan: {F36331} Reviewers: chad, epriestley Reviewed By: epriestley CC: aran, Korvin, btrahan Maniphest Tasks: T2709 Differential Revision: https://secure.phabricator.com/D5375
2013-03-20 13:36:53 +01:00
'uri' => '/res/b03fae38/rsrc/css/application/pholio/pholio.css',
Pholio tile to home page and mock to show first image Summary: Pholio tile to show up on home page First image is shown at mock page. Test Plan: Pholio app shows up on home page. First image is shown at mock page. Reviewers: epriestley CC: aran, Korvin Maniphest Tasks: T2356 Differential Revision: https://secure.phabricator.com/D4553
2013-01-20 18:29:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/pholio/pholio.css',
),
Show editor Summary: Show editor when user clicks edit button for inline comment. Test Plan: Verified that editor is shown. Reviewers: epriestley CC: aran, Korvin Maniphest Tasks: T2446 Differential Revision: https://secure.phabricator.com/D5030
2013-02-22 15:39:08 +01:00
'pholio-inline-comments-css' =>
array(
Improve Pholio on mobile Summary: Ref T2644. This isn't perfect, but makes Pholio more-or-less usable on mobile. In particular: - Inline comments drop below the image. - Clicking the image lightboxes a full size version so you can scroll around it and inspect details. - Clicking it again dismisses it. Things that aren't good: - Can't add inline comments. This seems complicated and not critical. - Can't easily figure out which inline comments go where since there's no hover. Maybe let you tap them? Not sure if we really need this. - Thumbs are between image and image data. I'm planning to get rid of the thumbs and do swipe left/right instead. - It would be nice to scroll the lightbox to center on the part of the image you tapped. I just thought of this, though. Test Plan: {F34640} {F34641} {F34642} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2644 Differential Revision: https://secure.phabricator.com/D5232
2013-03-05 21:30:58 +01:00
'uri' => '/res/8fe0edc7/rsrc/css/application/pholio/pholio-inline-comments.css',
Show editor Summary: Show editor when user clicks edit button for inline comment. Test Plan: Verified that editor is shown. Reviewers: epriestley CC: aran, Korvin Maniphest Tasks: T2446 Differential Revision: https://secure.phabricator.com/D5030
2013-02-22 15:39:08 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/pholio/pholio-inline-comments.css',
),
Minor, fix celerity map.
2013-04-01 05:07:47 +02:00
'phrequent-css' =>
array(
'uri' => '/res/9d6f3eb7/rsrc/css/application/phrequent/phrequent.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/phrequent/phrequent.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phriction-document-css' =>
array(
Modernized Phriction's Diff Controller Summary: Refs T2686 - Added additional crumb to link back to History view - Revert buttons hidden for Stub and Move changes, too - added colors to the change set to reflect the colors in the diff Test Plan: looked at various changes, verified correct appearance Reviewers: epriestley, chad, btrahan CC: aran, Korvin Maniphest Tasks: T2686 Differential Revision: https://secure.phabricator.com/D5401
2013-03-22 22:42:25 +01:00
'uri' => '/res/e71e4a67/rsrc/css/application/phriction/phriction-document-css.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/phriction/phriction-document-css.css',
),
adding comments to ponder Summary: This is pretty spartan, but it does the job. Test Plan: Patch, update storage, add some comment to your favorite question or answer. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: aran, Korvin, starruler, syrneus, me.here, victorzarate7 Maniphest Tasks: T1645 Differential Revision: https://secure.phabricator.com/D3471
2012-09-11 21:13:20 +02:00
'ponder-comment-table-css' =>
array(
'uri' => '/res/a1bb9056/rsrc/css/application/ponder/comments.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/ponder/comments.css',
),
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'ponder-core-view-css' =>
array(
adding comments to ponder Summary: This is pretty spartan, but it does the job. Test Plan: Patch, update storage, add some comment to your favorite question or answer. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: aran, Korvin, starruler, syrneus, me.here, victorzarate7 Maniphest Tasks: T1645 Differential Revision: https://secure.phabricator.com/D3471
2012-09-11 21:13:20 +02:00
'uri' => '/res/3a2d5e18/rsrc/css/application/ponder/core.css',
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/ponder/core.css',
),
'ponder-feed-view-css' =>
array(
'uri' => '/res/df22bd20/rsrc/css/application/ponder/feed.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/ponder/feed.css',
),
'ponder-post-css' =>
array(
adding comments to ponder Summary: This is pretty spartan, but it does the job. Test Plan: Patch, update storage, add some comment to your favorite question or answer. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: aran, Korvin, starruler, syrneus, me.here, victorzarate7 Maniphest Tasks: T1645 Differential Revision: https://secure.phabricator.com/D3471
2012-09-11 21:13:20 +02:00
'uri' => '/res/013b9e2c/rsrc/css/application/ponder/post.css',
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/ponder/post.css',
),
'ponder-vote-css' =>
array(
Add applications for Owners, Repositories, PHID manager, PHPAST Summary: See D3572. Test Plan: Viewed /applications/, saw all these applications. Reviewers: vrana, btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D3579
2012-10-01 21:56:33 +02:00
'uri' => '/res/ea8316c2/rsrc/css/application/ponder/vote.css',
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/ponder/vote.css',
),
Add gRaphael charting library Summary: I typed up like 30 pages here and then got my soul crushed by T895, but here's the summary: I looked at several charting libraries. There aren't very many that seem to be any good and have an open-source license. I also want the charts to be scriptable in JS so we can add good interactivity where appropriate. Raphael is an SVG drawing library which seems very solid. gRaphael is a charting library on top of Raphael that is a lot less solid, but seems kind of OK. Overall, I think this selection gives us a lot of flexibility, although we'll have to pay some costs up front. I'd rather do that then get limited later, though. That said, I'm open to other suggestions here if anyone has experience or wants to take a different stab at researching things. This is largely for @vii and D1643. Test Plan: Created a basic, fairly OK chart (see next revision). Reviewers: btrahan, vii Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1654
2012-02-22 00:10:24 +01:00
'raphael-core' =>
array(
Minor, don't minify raphael.js since it doesn't survive it Auditors: btrahan
2012-04-02 21:07:59 +02:00
'uri' => '/res/3f48575a/rsrc/js/raphael/raphael.js',
Add gRaphael charting library Summary: I typed up like 30 pages here and then got my soul crushed by T895, but here's the summary: I looked at several charting libraries. There aren't very many that seem to be any good and have an open-source license. I also want the charts to be scriptable in JS so we can add good interactivity where appropriate. Raphael is an SVG drawing library which seems very solid. gRaphael is a charting library on top of Raphael that is a lot less solid, but seems kind of OK. Overall, I think this selection gives us a lot of flexibility, although we'll have to pay some costs up front. I'd rather do that then get limited later, though. That said, I'm open to other suggestions here if anyone has experience or wants to take a different stab at researching things. This is largely for @vii and D1643. Test Plan: Created a basic, fairly OK chart (see next revision). Reviewers: btrahan, vii Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1654
2012-02-22 00:10:24 +01:00
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/raphael/raphael.js',
),
'raphael-g' =>
array(
Minor, don't minify raphael.js since it doesn't survive it Auditors: btrahan
2012-04-02 21:07:59 +02:00
'uri' => '/res/b07e5245/rsrc/js/raphael/g.raphael.js',
Add gRaphael charting library Summary: I typed up like 30 pages here and then got my soul crushed by T895, but here's the summary: I looked at several charting libraries. There aren't very many that seem to be any good and have an open-source license. I also want the charts to be scriptable in JS so we can add good interactivity where appropriate. Raphael is an SVG drawing library which seems very solid. gRaphael is a charting library on top of Raphael that is a lot less solid, but seems kind of OK. Overall, I think this selection gives us a lot of flexibility, although we'll have to pay some costs up front. I'd rather do that then get limited later, though. That said, I'm open to other suggestions here if anyone has experience or wants to take a different stab at researching things. This is largely for @vii and D1643. Test Plan: Created a basic, fairly OK chart (see next revision). Reviewers: btrahan, vii Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1654
2012-02-22 00:10:24 +01:00
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/raphael/g.raphael.js',
),
'raphael-g-line' =>
array(
Minor, don't minify raphael.js since it doesn't survive it Auditors: btrahan
2012-04-02 21:07:59 +02:00
'uri' => '/res/a59c8556/rsrc/js/raphael/g.raphael.line.js',
Add gRaphael charting library Summary: I typed up like 30 pages here and then got my soul crushed by T895, but here's the summary: I looked at several charting libraries. There aren't very many that seem to be any good and have an open-source license. I also want the charts to be scriptable in JS so we can add good interactivity where appropriate. Raphael is an SVG drawing library which seems very solid. gRaphael is a charting library on top of Raphael that is a lot less solid, but seems kind of OK. Overall, I think this selection gives us a lot of flexibility, although we'll have to pay some costs up front. I'd rather do that then get limited later, though. That said, I'm open to other suggestions here if anyone has experience or wants to take a different stab at researching things. This is largely for @vii and D1643. Test Plan: Created a basic, fairly OK chart (see next revision). Reviewers: btrahan, vii Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1654
2012-02-22 00:10:24 +01:00
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/raphael/g.raphael.line.js',
),
Releeph (Phabricator part) Summary: A copy of the Releeph release tool. Test Plan: Generally, click everything at least once. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2094 Differential Revision: https://secure.phabricator.com/D4932
2013-03-15 12:28:43 +01:00
'releeph-branch' =>
array(
'uri' => '/res/6ad6420d/rsrc/css/application/releeph/releeph-branch.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-branch.css',
),
'releeph-colors' =>
array(
'uri' => '/res/dff4b26a/rsrc/css/application/releeph/releeph-colors.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-colors.css',
),
'releeph-core' =>
array(
'uri' => '/res/853f4a73/rsrc/css/application/releeph/releeph-core.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-core.css',
),
'releeph-intents' =>
array(
'uri' => '/res/4e73e9dd/rsrc/css/application/releeph/releeph-intents.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-intents.css',
),
'releeph-preview-branch' =>
array(
'uri' => '/res/65e5dece/rsrc/css/application/releeph/releeph-preview-branch.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-preview-branch.css',
),
'releeph-project' =>
array(
'uri' => '/res/b9376e59/rsrc/css/application/releeph/releeph-project.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-project.css',
),
'releeph-request-differential-create-dialog' =>
array(
'uri' => '/res/4df30ce1/rsrc/css/application/releeph/releeph-request-differential-create-dialog.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-request-differential-create-dialog.css',
),
'releeph-request-typeahead-css' =>
array(
'uri' => '/res/9c9a1acf/rsrc/css/application/releeph/releeph-request-typeahead.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-request-typeahead.css',
),
'releeph-status' =>
array(
'uri' => '/res/588529df/rsrc/css/application/releeph/releeph-status.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/releeph/releeph-status.css',
),
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'setup-issue-css' =>
array(
Port extension checks to new-style setup Summary: - Allow new-style setup to raise fatal setup errors. - Port extension checks to new-style setup as fatal errors. - When fatal errors are raised, abort setup and show them in a chrome-free response. Test Plan: {F29981} Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T2228 Differential Revision: https://secure.phabricator.com/D4587
2013-01-23 00:16:26 +01:00
'uri' => '/res/efbb3673/rsrc/css/application/config/setup-issue.css',
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/config/setup-issue.css',
),
Minor, fix celerity map.
2013-04-01 05:07:47 +02:00
'spacing-css' =>
array(
'uri' => '/res/59e4c9b1/rsrc/css/core/spacing.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/spacing.css',
),
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'sprite-actions-css' =>
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
array(
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'uri' => '/res/41ef6a23/rsrc/css/sprite-actions.css',
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-actions.css',
),
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'sprite-apps-css' =>
array(
Update icons Summary: Add icons for releeph, phage, workphlow, prequent, adventure, and xhprof. Accidentally includes phame. Test Plan: photoshop Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5540
2013-04-02 23:28:11 +02:00
'uri' => '/res/d0b8b697/rsrc/css/sprite-apps.css',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-apps.css',
),
'sprite-apps-large-css' =>
array(
Rework desktop header Summary: Removes the glow icons and uses a hover change. Fixes phantom anchors. Test Plan: Review in Chrome at various sizes (phone tablet). Check that icons still work. Check that mobile menus render when clicked. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2876 Differential Revision: https://secure.phabricator.com/D5549
2013-04-03 17:26:36 +02:00
'uri' => '/res/0c77875d/rsrc/css/sprite-apps-large.css',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-apps-large.css',
),
'sprite-apps-xlarge-css' =>
array(
Added Feed icons. Summary: Adds a feed icon for feed applications. Test Plan: Photoshop Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4388
2013-01-10 19:00:18 +01:00
'uri' => '/res/33a8e644/rsrc/css/sprite-apps-xlarge.css',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-apps-xlarge.css',
),
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'sprite-conpherence-css' =>
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
array(
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'uri' => '/res/f6793453/rsrc/css/sprite-conpherence.css',
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
'type' => 'css',
'requires' =>
array(
),
Conpherence - some cleanup type stuff Summary: this diff does a few, not so exciting things - changes "conpher" to "conpherence" where it snuck into CSS, spritemap, etc -- I believe we now consistently call it conpherence. Feel free to change it, just change it everywhere. :D - puts the widget icons in the right order per M14 - makes the "mobile-only" widgets show the toggles only in the mobile view - also made it so clicking them does nothing for now - removes the tasks widget since we don't want it ...my time is getting chopped up funny (yay puppy) so this is just an attempt at something that can go into the codebase and not make it worse. Next up is making the widgets that show on desktop look right / not say "TODO" Test Plan: played around in Conpherence Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2530 Differential Revision: https://secure.phabricator.com/D5334
2013-03-13 21:03:51 +01:00
'disk' => '/rsrc/css/sprite-conpherence.css',
Minor, update Celerity map.
2013-01-29 02:49:09 +01:00
),
Document icons sprite sheet. Summary: Adds 32 and 64 px images to represent basic documents. Test Plan: Differential Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5317
2013-03-10 22:16:16 +01:00
'sprite-docs-css' =>
array(
'uri' => '/res/b32f93bc/rsrc/css/sprite-docs.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-docs.css',
),
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'sprite-gradient-css' =>
array(
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'uri' => '/res/fdc4dd44/rsrc/css/sprite-gradient.css',
Update celerity map after many merges, etc.
2012-12-07 22:38:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-gradient.css',
),
Generate an icon sprite map with new sprites and 2x retina graphics Summary: - The filesystem is now the authority for which sprites are available. If you add new icons, the generation process will pick them up. - I broke out icon generation and added retina support. App icon generation still uses the old method. - Update ActionList and RemarkupControl to use the new sheet. - Use white icons on hover. - Also fixed a couple of minor issues with some stuff in Firefox/Chrome. Test Plan: {F25750} {F25751} {F25752} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2013 Differential Revision: https://secure.phabricator.com/D4027
2012-11-24 01:35:39 +01:00
'sprite-icon-css' =>
array(
Action Menu (mobile) Summary: First pass here, still needs some UI work (maybe? tablets?). Getting it out to see if implementation is corrrect. Test Plan: Shrink Maniphest task on Chrome, see new UI. Toggle menu. Test on iOS. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5631
2013-04-09 21:42:03 +02:00
'uri' => '/res/fa36bb72/rsrc/css/sprite-icon.css',
Generate an icon sprite map with new sprites and 2x retina graphics Summary: - The filesystem is now the authority for which sprites are available. If you add new icons, the generation process will pick them up. - I broke out icon generation and added retina support. App icon generation still uses the old method. - Update ActionList and RemarkupControl to use the new sheet. - Use white icons on hover. - Also fixed a couple of minor issues with some stuff in Firefox/Chrome. Test Plan: {F25750} {F25751} {F25752} Reviewers: chad Reviewed By: chad CC: aran Maniphest Tasks: T2013 Differential Revision: https://secure.phabricator.com/D4027
2012-11-24 01:35:39 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-icon.css',
),
Use "flame" notification icon and bubble instead of lightning bolt Summary: Switch to the final versions of these Test Plan: Will add screenshots... Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4032
2012-11-27 23:03:25 +01:00
'sprite-menu-css' =>
array(
Rework Mobile Header and Mobile Home. Summary: Mostly finished, wanted to get it into your hands to play with. I need to remove some more dead CSS and figure out where we want to put profile/logout, but overall feels pretty good. Tested a bunch in iOS and other layouts. Test Plan: Test Home, Maniphest, search bars, app menus. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Maniphest Tasks: T2809 Differential Revision: https://secure.phabricator.com/D5407
2013-03-22 19:50:30 +01:00
'uri' => '/res/e4e428f9/rsrc/css/sprite-menu.css',
Use "flame" notification icon and bubble instead of lightning bolt Summary: Switch to the final versions of these Test Plan: Will add screenshots... Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4032
2012-11-27 23:03:25 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-menu.css',
),
Leafy greens.
2013-04-04 20:35:22 +02:00
'sprite-minicons-css' =>
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
array(
PhabricatorActionHeaderView v0 Summary: Initial pass at an action header. The idea is to support current and future planned needs in 'headers' with various colors and icons. The overall goal here is to keep markup light and allow other classes to wrap and extend with more specific features. Test Plan: Tested UIExamples and Workboards. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5585
2013-04-05 16:40:27 +02:00
'uri' => '/res/2dba70cd/rsrc/css/sprite-minicons.css',
Action Icons Summary: First pass at 'action icons' for headers and other items. Ties into future diff. Test Plan: photoshop, read the css. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5565
2013-04-04 19:38:50 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-minicons.css',
),
Tokens v1 Summary: Features! - Giving tokens. - Taking tokens back. - Not giving tokens. Test Plan: See screenshots. Reviewers: chad, vrana Reviewed By: chad CC: aran, btrahan Maniphest Tasks: T2541 Differential Revision: https://secure.phabricator.com/D4964
2013-02-15 16:47:14 +01:00
'sprite-tokens-css' =>
array(
'uri' => '/res/9ae0de5b/rsrc/css/sprite-tokens.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/sprite-tokens.css',
),
For discussion -- Stripe integration Summary: various stripe stuff, including - external stripe library - payment form - test controller to play with payment form, sample business logic My main questions / discussion topics are... - is the stripe PHP library too big? (ie should I write something more simple just for phabricator?) -- if its cool, what is the best way to include the client? (ie should I make it a submodule rather than the flat copy here?) - is the JS I wrote (too) ridiculous? -- particularly unhappy with the error message stuff being in JS *but* it seemed the best choice given the most juicy error messages come from the stripe JS such that the overall code complexity is lowest this way. - how should the stripe JS be included? -- flat copy like I did here? -- some sort of external? -- can we just load it off stripe servers at request time? (I like that from the "if stripe is down, stripe is down" perspective) - wasn't sure if the date control was too silly and should just be baked into the form? -- for some reason I feel like its good to be prepared to walk away from Stripe / switch providers here, though I think this is on the wrong side of pragmatic Test Plan: - played around with sample client form Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2096
2012-04-05 01:09:29 +02:00
'stripe-core' =>
array(
'uri' => '/res/3b0f0ad4/rsrc/js/stripe/stripe_core.js',
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/stripe/stripe_core.js',
),
'stripe-payment-form-css' =>
array(
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'uri' => '/res/634a6371/rsrc/css/application/phortune/stripe-payment-form.css',
For discussion -- Stripe integration Summary: various stripe stuff, including - external stripe library - payment form - test controller to play with payment form, sample business logic My main questions / discussion topics are... - is the stripe PHP library too big? (ie should I write something more simple just for phabricator?) -- if its cool, what is the best way to include the client? (ie should I make it a submodule rather than the flat copy here?) - is the JS I wrote (too) ridiculous? -- particularly unhappy with the error message stuff being in JS *but* it seemed the best choice given the most juicy error messages come from the stripe JS such that the overall code complexity is lowest this way. - how should the stripe JS be included? -- flat copy like I did here? -- some sort of external? -- can we just load it off stripe servers at request time? (I like that from the "if stripe is down, stripe is down" perspective) - wasn't sure if the date control was too silly and should just be baked into the form? -- for some reason I feel like its good to be prepared to walk away from Stripe / switch providers here, though I think this is on the wrong side of pragmatic Test Plan: - played around with sample client form Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2096
2012-04-05 01:09:29 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/phortune/stripe-payment-form.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'syntax-highlighting-css' =>
array(
Adding Ponder-related files. Summary: Ponder is similar in spirit to the Wiki tool, but uses a Q&A format and up/downvotes to signal user sentiment. Popular questions are moved to the top of the feed on a 5-minute cycle based on age (younger is better) and vote count (higher is better). Pre-apologies for noob diff. Test Plan: - `./bin/phd list` Should include `PonderHeatDaemon`; phd launch it if necessary. - Navigate to /ponder/ ; observe sanity when adding questions, voting on them, and adding answers. - Confirm that questions and answers are linkable using Q5 / Q5#A5 formatted object links. - Confirm that searching for Ponder Questions works using built-in search. Feedback on code / schema / whatever organization very welcome. Reviewers: nh, vrana, epriestley Reviewed By: epriestley CC: gmarcotte, aran, Korvin, starruler Differential Revision: https://secure.phabricator.com/D3136
2012-08-10 19:44:04 +02:00
'uri' => '/res/cb3b9dc0/rsrc/css/core/syntax.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/syntax.css',
),
Tokens v1 Summary: Features! - Giving tokens. - Taking tokens back. - Not giving tokens. Test Plan: See screenshots. Reviewers: chad, vrana Reviewed By: chad CC: aran, btrahan Maniphest Tasks: T2541 Differential Revision: https://secure.phabricator.com/D4964
2013-02-15 16:47:14 +01:00
'tokens-css' =>
array(
Minor phutil_tag/HTML fixes Summary: - In stack traces, a `,` should clearly be a `.`. - In Calendar, a 'td' got swapped with a 'p' somewhere. - In old-style transaction views, strlen() is no longer a sufficient test. Test Plan: - Verified stack traces render correctly. - Verified calendar renders correctly. - Verified Maniphest transactions with no comment no longer have a little empty div a few pixels high. Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4971
2013-02-15 17:14:31 +01:00
'uri' => '/res/6b3c65c7/rsrc/css/application/tokens/tokens.css',
Tokens v1 Summary: Features! - Giving tokens. - Taking tokens back. - Not giving tokens. Test Plan: See screenshots. Reviewers: chad, vrana Reviewed By: chad CC: aran, btrahan Maniphest Tasks: T2541 Differential Revision: https://secure.phabricator.com/D4964
2013-02-15 16:47:14 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/tokens/tokens.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
), array(
'packages' =>
array(
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'b3deb720' =>
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
array(
'name' => 'core.pkg.css',
'symbols' =>
array(
0 => 'phabricator-core-css',
Move all CSS "z-index" rules to "z-index.css", fix Differential z-index problem Summary: We have enough z-index rules that they're fairly hard to visualize with "git grep". Consolidate them. Then fix T2253 (missing z-index on left menu background). Test Plan: Made a Differential window really narrow, then scrolled it horizontally. Reviewers: btrahan, chad, ender Reviewed By: chad CC: aran Maniphest Tasks: T2253 Differential Revision: https://secure.phabricator.com/D4302
2012-12-30 18:30:21 +01:00
1 => 'phabricator-zindex-css',
2 => 'phabricator-core-buttons-css',
3 => 'phabricator-standard-page-view',
4 => 'aphront-dialog-view-css',
5 => 'aphront-form-view-css',
6 => 'aphront-panel-view-css',
Remove all older-style navs Summary: Move all navs to use the newer-style, darker, textured look. I'm //pretty// sure this doesn't break anything. Test Plan: Looked at a bunch of apps. Reviewers: btrahan, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4376
2013-01-09 21:03:58 +01:00
7 => 'aphront-table-view-css',
Minor, celerity derps.
2013-03-14 00:28:27 +01:00
8 => 'aphront-tokenizer-control-css',
9 => 'aphront-typeahead-control-css',
10 => 'aphront-list-filter-view-css',
11 => 'phabricator-directory-css',
12 => 'phabricator-jump-nav',
13 => 'phabricator-remarkup-css',
14 => 'syntax-highlighting-css',
15 => 'aphront-pager-view-css',
16 => 'phabricator-transaction-view-css',
17 => 'aphront-tooltip-css',
18 => 'phabricator-flag-css',
19 => 'aphront-error-view-css',
20 => 'sprite-icon-css',
21 => 'sprite-gradient-css',
22 => 'sprite-menu-css',
23 => 'sprite-apps-large-css',
24 => 'phabricator-main-menu-view',
25 => 'phabricator-notification-css',
26 => 'phabricator-notification-menu-css',
27 => 'lightbox-attachment-css',
28 => 'phabricator-header-view-css',
29 => 'phabricator-form-view-css',
30 => 'phabricator-filetree-view-css',
31 => 'phabricator-nav-view-css',
32 => 'phabricator-side-menu-view-css',
33 => 'phabricator-crumbs-view-css',
34 => 'phabricator-object-item-list-view-css',
35 => 'global-drag-and-drop-css',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
),
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'uri' => '/res/pkg/b3deb720/core.pkg.css',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
'type' => 'css',
),
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'bf16b308' =>
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
array(
'name' => 'core.pkg.js',
'symbols' =>
array(
Update static resource packages Summary: These are a bit out of date; bundle things together better. Test Plan: Viewed page source for home, differential list, differential diff, maniphest list, maniphest task. Verified reasonable resource packaging. Reviewers: chad, vrana, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4002
2012-11-21 03:01:25 +01:00
0 => 'javelin-behavior-aphront-basic-tokenizer',
1 => 'javelin-behavior-workflow',
2 => 'javelin-behavior-aphront-form-disable-on-submit',
3 => 'phabricator-keyboard-shortcut-manager',
4 => 'phabricator-keyboard-shortcut',
5 => 'javelin-behavior-phabricator-keyboard-shortcuts',
6 => 'javelin-behavior-refresh-csrf',
7 => 'javelin-behavior-phabricator-watch-anchor',
8 => 'javelin-behavior-phabricator-autofocus',
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
9 => 'phabricator-menu-item',
10 => 'phabricator-dropdown-menu',
11 => 'javelin-behavior-phabricator-oncopy',
12 => 'phabricator-tooltip',
13 => 'javelin-behavior-phabricator-tooltips',
14 => 'phabricator-prefab',
15 => 'javelin-behavior-device',
16 => 'javelin-behavior-toggle-class',
17 => 'javelin-behavior-lightbox-attachments',
18 => 'phabricator-busy',
19 => 'javelin-aphlict',
20 => 'phabricator-notification',
21 => 'javelin-behavior-aphlict-listen',
22 => 'javelin-behavior-phabricator-search-typeahead',
23 => 'javelin-behavior-konami',
24 => 'javelin-behavior-aphlict-dropdown',
25 => 'javelin-behavior-history-install',
26 => 'javelin-behavior-phabricator-gesture',
27 => 'javelin-behavior-phabricator-active-nav',
28 => 'javelin-behavior-phabricator-nav',
29 => 'javelin-behavior-phabricator-remarkup-assist',
30 => 'phabricator-textareautils',
31 => 'phabricator-file-upload',
32 => 'javelin-behavior-global-drag-and-drop',
33 => 'javelin-behavior-phabricator-reveal-content',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
),
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'uri' => '/res/pkg/bf16b308/core.pkg.js',
Update static resource packages Summary: These are a bit out of date; bundle things together better. Test Plan: Viewed page source for home, differential list, differential diff, maniphest list, maniphest task. Verified reasonable resource packaging. Reviewers: chad, vrana, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4002
2012-11-21 03:01:25 +01:00
'type' => 'js',
),
When a page is profiled, profile all AJAX requests too Summary: If a page is profiled, add an "X-Phabricator-Profiler" header to all Ajax requests, and profile those too. Test Plan: Profiled a page, checked Darkconsole, saw profiles for everything. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4885
2013-02-09 22:29:47 +01:00
'dca4a03d' =>
Update static resource packages Summary: These are a bit out of date; bundle things together better. Test Plan: Viewed page source for home, differential list, differential diff, maniphest list, maniphest task. Verified reasonable resource packaging. Reviewers: chad, vrana, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4002
2012-11-21 03:01:25 +01:00
array(
'name' => 'darkconsole.pkg.js',
'symbols' =>
array(
DarkConsole: fix rendering, move request log, load over ajax Summary: This accomplishes three major goals: # Fixes phutil_render_tag -> phutil_tag callsites in DarkConsole. # Moves the Ajax request log to a new panel on the left. This panel (and the tabs panel) get scrollbars when they get large, instead of making the page constantly scroll down. # Loads the panel content over ajax, instead of dumping it into the page body / ajax response body. I've been planning to do this for about 3 years, which is why the plugins are architected the way they are. This should make debugging easier by making response bodies not be 50%+ darkconsole stuff. Additionally, load the plugins dynamically (the old method predates library maps and PhutilSymbolLoader). Test Plan: {F30675} - Switched between requests and tabs, reloaded page, saw same tab. - Used "analyze queries", "profile page", triggered errors. - Verified page does not load anything by default if dark console is closed with Charles. - Generally banged on it a bit. Reviewers: vrana, btrahan, chad Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4692
2013-01-29 03:45:32 +01:00
0 => 'javelin-behavior-dark-console',
1 => 'javelin-behavior-error-log',
Update static resource packages Summary: These are a bit out of date; bundle things together better. Test Plan: Viewed page source for home, differential list, differential diff, maniphest list, maniphest task. Verified reasonable resource packaging. Reviewers: chad, vrana, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4002
2012-11-21 03:01:25 +01:00
),
When a page is profiled, profile all AJAX requests too Summary: If a page is profiled, add an "X-Phabricator-Profiler" header to all Ajax requests, and profile those too. Test Plan: Profiled a page, checked Darkconsole, saw profiles for everything. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4885
2013-02-09 22:29:47 +01:00
'uri' => '/res/pkg/dca4a03d/darkconsole.pkg.js',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
'type' => 'js',
),
render_tag -> tag: phabricator_render_form -> phabricator_form Summary: Convert most phabricator_render_form callsites. In the case of the "headsup view", it converts it by deleting the element entirely (this is the very old Maniphest/Differential header which we no longer use). Test Plan: Poked around a bit. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4726
2013-01-30 20:30:38 +01:00
'8aaacd1b' =>
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
array(
'name' => 'differential.pkg.css',
'symbols' =>
array(
0 => 'differential-core-view-css',
1 => 'differential-changeset-view-css',
Further improve unit/lint rendering Summary: I think this improves things, let me know if you have feedback. Also addresses T840. Test Plan: See screenshots... Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, zeeg Maniphest Tasks: T840 Differential Revision: https://secure.phabricator.com/D2357
2012-05-01 19:15:56 +02:00
2 => 'differential-results-table-css',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
3 => 'differential-revision-history-css',
Highlight update time in revision list Summary: This is another experiment for reducing reviewers response time. I stole the idea (and colors) from [[ http://www.reviewboard.org/media/screenshots/2009/02/02/dashboard.png | ReviewBoard ]]. I actually quite like it (except when everything is red) and I can image that people will review just to have better color balance. The code is not production ready for these reasons: - We load holidays again and again for each revision. I couldn't cache it to static variable because it could persist multiple requests, right? - I don't know how to expand height to the whole cell (I'm really bad in CSS). - CSS rules are probably in wrong file. - We probably want to use different colors. This is how it looks: {F16406} Test Plan: Displayed revision list. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D3190
2012-08-20 23:05:46 +02:00
4 => 'differential-revision-list-css',
5 => 'differential-table-of-contents-css',
6 => 'differential-revision-comment-css',
7 => 'differential-revision-add-comment-css',
8 => 'differential-revision-comment-list-css',
9 => 'phabricator-object-selector-css',
render_tag -> tag: phabricator_render_form -> phabricator_form Summary: Convert most phabricator_render_form callsites. In the case of the "headsup view", it converts it by deleting the element entirely (this is the very old Maniphest/Differential header which we no longer use). Test Plan: Poked around a bit. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4726
2013-01-30 20:30:38 +01:00
10 => 'phabricator-content-source-view-css',
11 => 'differential-local-commits-view-css',
12 => 'inline-comment-summary-css',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
),
render_tag -> tag: phabricator_render_form -> phabricator_form Summary: Convert most phabricator_render_form callsites. In the case of the "headsup view", it converts it by deleting the element entirely (this is the very old Maniphest/Differential header which we no longer use). Test Plan: Poked around a bit. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4726
2013-01-30 20:30:38 +01:00
'uri' => '/res/pkg/8aaacd1b/differential.pkg.css',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'type' => 'css',
),
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
'e96b08f8' =>
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
array(
'name' => 'differential.pkg.js',
'symbols' =>
array(
0 => 'phabricator-drag-and-drop-file-upload',
1 => 'phabricator-shaped-request',
2 => 'javelin-behavior-differential-feedback-preview',
3 => 'javelin-behavior-differential-edit-inline-comments',
4 => 'javelin-behavior-differential-populate',
5 => 'javelin-behavior-differential-show-more',
6 => 'javelin-behavior-differential-diff-radios',
7 => 'javelin-behavior-differential-accept-with-errors',
8 => 'javelin-behavior-differential-comment-jump',
9 => 'javelin-behavior-differential-add-reviewers-and-ccs',
10 => 'javelin-behavior-differential-keyboard-navigation',
11 => 'javelin-behavior-aphront-drag-and-drop',
12 => 'javelin-behavior-aphront-drag-and-drop-textarea',
13 => 'javelin-behavior-phabricator-object-selector',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
14 => 'javelin-behavior-repository-crossreference',
Load blame in Diffusion by AJAX Summary: I have blame enabled by default and displaying files with long history takes easily over 10 seconds. Load the blame data by AJAX instead. This is actually doing more work and the total response time is longer but it's worth it for me as I am interested just in the file contents quite often. I know you were talking about building blame cache but until we have it... I'm not sure if the AJAX loading indicator in bottom right corner is enough to inform the user that we are loading it on background. Test Plan: ?view=highlighted ?view=plainblame ?view=blame Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5244
2013-03-05 23:31:20 +01:00
15 => 'javelin-behavior-load-blame',
16 => 'differential-inline-comment-editor',
17 => 'javelin-behavior-differential-dropdown-menus',
18 => 'javelin-behavior-differential-toggle-files',
19 => 'javelin-behavior-differential-user-select',
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
),
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
'uri' => '/res/pkg/e96b08f8/differential.pkg.js',
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
'type' => 'js',
),
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'c8ce2d88' =>
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
array(
'name' => 'diffusion.pkg.css',
'symbols' =>
array(
0 => 'diffusion-commit-view-css',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
1 => 'diffusion-icons-css',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
),
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'uri' => '/res/pkg/c8ce2d88/diffusion.pkg.css',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
'type' => 'css',
),
Update tables to table-kit view. Summary: Reskinning tables to table-kit mocks, which includes new textures, spacing, slightly larger fonts. Looking for early feedback before adding in new row colors and other items into the class. Test Plan: http://phab1.pushlabs.net/uiexample/view/PhabricatorSortTableExample/ Reviewers: btrahan, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4396
2013-01-11 20:24:35 +01:00
'f96657b8' =>
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
array(
'name' => 'diffusion.pkg.js',
'symbols' =>
array(
0 => 'javelin-behavior-diffusion-pull-lastmodified',
1 => 'javelin-behavior-diffusion-commit-graph',
2 => 'javelin-behavior-audit-preview',
),
Update tables to table-kit view. Summary: Reskinning tables to table-kit mocks, which includes new textures, spacing, slightly larger fonts. Looking for early feedback before adding in new row colors and other items into the class. Test Plan: http://phab1.pushlabs.net/uiexample/view/PhabricatorSortTableExample/ Reviewers: btrahan, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4396
2013-01-11 20:24:35 +01:00
'uri' => '/res/pkg/f96657b8/diffusion.pkg.js',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'type' => 'js',
),
Leafy greens.
2013-04-04 20:35:22 +02:00
'a2f94024' =>
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
array(
'name' => 'javelin.pkg.js',
'symbols' =>
array(
0 => 'javelin-util',
1 => 'javelin-install',
2 => 'javelin-event',
3 => 'javelin-stratcom',
4 => 'javelin-behavior',
Update static resource packages Summary: These are a bit out of date; bundle things together better. Test Plan: Viewed page source for home, differential list, differential diff, maniphest list, maniphest task. Verified reasonable resource packaging. Reviewers: chad, vrana, btrahan Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D4002
2012-11-21 03:01:25 +01:00
5 => 'javelin-resource',
6 => 'javelin-request',
7 => 'javelin-vector',
8 => 'javelin-dom',
9 => 'javelin-json',
10 => 'javelin-uri',
11 => 'javelin-workflow',
12 => 'javelin-mask',
13 => 'javelin-typeahead',
14 => 'javelin-typeahead-normalizer',
15 => 'javelin-typeahead-source',
16 => 'javelin-typeahead-preloaded-source',
17 => 'javelin-typeahead-ondemand-source',
18 => 'javelin-tokenizer',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
),
Leafy greens.
2013-04-04 20:35:22 +02:00
'uri' => '/res/pkg/a2f94024/javelin.pkg.js',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'type' => 'js',
),
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
'6b1fccc6' =>
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
array(
'name' => 'maniphest.pkg.css',
'symbols' =>
array(
0 => 'maniphest-task-summary-css',
1 => 'maniphest-transaction-detail-css',
Delete unused CSS Summary: Unused since D2062. Test Plan: View commit. View task. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2108
2012-04-05 19:47:20 +02:00
2 => 'aphront-attached-file-view-css',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
3 => 'phabricator-project-tag-css',
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
),
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
'uri' => '/res/pkg/6b1fccc6/maniphest.pkg.css',
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
'type' => 'css',
),
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
'f85eb6d8' =>
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
array(
'name' => 'maniphest.pkg.js',
'symbols' =>
array(
0 => 'javelin-behavior-maniphest-batch-selector',
1 => 'javelin-behavior-maniphest-transaction-controls',
2 => 'javelin-behavior-maniphest-transaction-preview',
3 => 'javelin-behavior-maniphest-transaction-expand',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
4 => 'javelin-behavior-maniphest-subpriority-editor',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
),
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
'uri' => '/res/pkg/f85eb6d8/maniphest.pkg.js',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'type' => 'js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'reverse' =>
array(
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
'aphront-attached-file-view-css' => '6b1fccc6',
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'aphront-dialog-view-css' => 'b3deb720',
'aphront-error-view-css' => 'b3deb720',
'aphront-form-view-css' => 'b3deb720',
'aphront-list-filter-view-css' => 'b3deb720',
'aphront-pager-view-css' => 'b3deb720',
'aphront-panel-view-css' => 'b3deb720',
'aphront-table-view-css' => 'b3deb720',
'aphront-tokenizer-control-css' => 'b3deb720',
'aphront-tooltip-css' => 'b3deb720',
'aphront-typeahead-control-css' => 'b3deb720',
render_tag -> tag: phabricator_render_form -> phabricator_form Summary: Convert most phabricator_render_form callsites. In the case of the "headsup view", it converts it by deleting the element entirely (this is the very old Maniphest/Differential header which we no longer use). Test Plan: Poked around a bit. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4726
2013-01-30 20:30:38 +01:00
'differential-changeset-view-css' => '8aaacd1b',
'differential-core-view-css' => '8aaacd1b',
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
'differential-inline-comment-editor' => 'e96b08f8',
render_tag -> tag: phabricator_render_form -> phabricator_form Summary: Convert most phabricator_render_form callsites. In the case of the "headsup view", it converts it by deleting the element entirely (this is the very old Maniphest/Differential header which we no longer use). Test Plan: Poked around a bit. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4726
2013-01-30 20:30:38 +01:00
'differential-local-commits-view-css' => '8aaacd1b',
'differential-results-table-css' => '8aaacd1b',
'differential-revision-add-comment-css' => '8aaacd1b',
'differential-revision-comment-css' => '8aaacd1b',
'differential-revision-comment-list-css' => '8aaacd1b',
'differential-revision-history-css' => '8aaacd1b',
'differential-revision-list-css' => '8aaacd1b',
'differential-table-of-contents-css' => '8aaacd1b',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88',
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'global-drag-and-drop-css' => 'b3deb720',
render_tag -> tag: phabricator_render_form -> phabricator_form Summary: Convert most phabricator_render_form callsites. In the case of the "headsup view", it converts it by deleting the element entirely (this is the very old Maniphest/Differential header which we no longer use). Test Plan: Poked around a bit. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4726
2013-01-30 20:30:38 +01:00
'inline-comment-summary-css' => '8aaacd1b',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'javelin-aphlict' => 'bf16b308',
Leafy greens.
2013-04-04 20:35:22 +02:00
'javelin-behavior' => 'a2f94024',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'javelin-behavior-aphlict-dropdown' => 'bf16b308',
'javelin-behavior-aphlict-listen' => 'bf16b308',
'javelin-behavior-aphront-basic-tokenizer' => 'bf16b308',
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
'javelin-behavior-aphront-drag-and-drop' => 'e96b08f8',
'javelin-behavior-aphront-drag-and-drop-textarea' => 'e96b08f8',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'javelin-behavior-aphront-form-disable-on-submit' => 'bf16b308',
Update tables to table-kit view. Summary: Reskinning tables to table-kit mocks, which includes new textures, spacing, slightly larger fonts. Looking for early feedback before adding in new row colors and other items into the class. Test Plan: http://phab1.pushlabs.net/uiexample/view/PhabricatorSortTableExample/ Reviewers: btrahan, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4396
2013-01-11 20:24:35 +01:00
'javelin-behavior-audit-preview' => 'f96657b8',
When a page is profiled, profile all AJAX requests too Summary: If a page is profiled, add an "X-Phabricator-Profiler" header to all Ajax requests, and profile those too. Test Plan: Profiled a page, checked Darkconsole, saw profiles for everything. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4885
2013-02-09 22:29:47 +01:00
'javelin-behavior-dark-console' => 'dca4a03d',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'javelin-behavior-device' => 'bf16b308',
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
'javelin-behavior-differential-accept-with-errors' => 'e96b08f8',
'javelin-behavior-differential-add-reviewers-and-ccs' => 'e96b08f8',
'javelin-behavior-differential-comment-jump' => 'e96b08f8',
'javelin-behavior-differential-diff-radios' => 'e96b08f8',
'javelin-behavior-differential-dropdown-menus' => 'e96b08f8',
'javelin-behavior-differential-edit-inline-comments' => 'e96b08f8',
'javelin-behavior-differential-feedback-preview' => 'e96b08f8',
'javelin-behavior-differential-keyboard-navigation' => 'e96b08f8',
'javelin-behavior-differential-populate' => 'e96b08f8',
'javelin-behavior-differential-show-more' => 'e96b08f8',
'javelin-behavior-differential-toggle-files' => 'e96b08f8',
'javelin-behavior-differential-user-select' => 'e96b08f8',
Update tables to table-kit view. Summary: Reskinning tables to table-kit mocks, which includes new textures, spacing, slightly larger fonts. Looking for early feedback before adding in new row colors and other items into the class. Test Plan: http://phab1.pushlabs.net/uiexample/view/PhabricatorSortTableExample/ Reviewers: btrahan, epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4396
2013-01-11 20:24:35 +01:00
'javelin-behavior-diffusion-commit-graph' => 'f96657b8',
'javelin-behavior-diffusion-pull-lastmodified' => 'f96657b8',
When a page is profiled, profile all AJAX requests too Summary: If a page is profiled, add an "X-Phabricator-Profiler" header to all Ajax requests, and profile those too. Test Plan: Profiled a page, checked Darkconsole, saw profiles for everything. Reviewers: vrana, btrahan Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D4885
2013-02-09 22:29:47 +01:00
'javelin-behavior-error-log' => 'dca4a03d',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'javelin-behavior-global-drag-and-drop' => 'bf16b308',
'javelin-behavior-history-install' => 'bf16b308',
'javelin-behavior-konami' => 'bf16b308',
'javelin-behavior-lightbox-attachments' => 'bf16b308',
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
'javelin-behavior-load-blame' => 'e96b08f8',
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
'javelin-behavior-maniphest-batch-selector' => 'f85eb6d8',
'javelin-behavior-maniphest-subpriority-editor' => 'f85eb6d8',
'javelin-behavior-maniphest-transaction-controls' => 'f85eb6d8',
'javelin-behavior-maniphest-transaction-expand' => 'f85eb6d8',
'javelin-behavior-maniphest-transaction-preview' => 'f85eb6d8',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'javelin-behavior-phabricator-active-nav' => 'bf16b308',
'javelin-behavior-phabricator-autofocus' => 'bf16b308',
'javelin-behavior-phabricator-gesture' => 'bf16b308',
'javelin-behavior-phabricator-keyboard-shortcuts' => 'bf16b308',
'javelin-behavior-phabricator-nav' => 'bf16b308',
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
'javelin-behavior-phabricator-object-selector' => 'e96b08f8',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'javelin-behavior-phabricator-oncopy' => 'bf16b308',
'javelin-behavior-phabricator-remarkup-assist' => 'bf16b308',
'javelin-behavior-phabricator-reveal-content' => 'bf16b308',
'javelin-behavior-phabricator-search-typeahead' => 'bf16b308',
'javelin-behavior-phabricator-tooltips' => 'bf16b308',
'javelin-behavior-phabricator-watch-anchor' => 'bf16b308',
'javelin-behavior-refresh-csrf' => 'bf16b308',
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
'javelin-behavior-repository-crossreference' => 'e96b08f8',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'javelin-behavior-toggle-class' => 'bf16b308',
'javelin-behavior-workflow' => 'bf16b308',
Leafy greens.
2013-04-04 20:35:22 +02:00
'javelin-dom' => 'a2f94024',
'javelin-event' => 'a2f94024',
'javelin-install' => 'a2f94024',
'javelin-json' => 'a2f94024',
'javelin-mask' => 'a2f94024',
'javelin-request' => 'a2f94024',
'javelin-resource' => 'a2f94024',
'javelin-stratcom' => 'a2f94024',
'javelin-tokenizer' => 'a2f94024',
'javelin-typeahead' => 'a2f94024',
'javelin-typeahead-normalizer' => 'a2f94024',
'javelin-typeahead-ondemand-source' => 'a2f94024',
'javelin-typeahead-preloaded-source' => 'a2f94024',
'javelin-typeahead-source' => 'a2f94024',
'javelin-uri' => 'a2f94024',
'javelin-util' => 'a2f94024',
'javelin-vector' => 'a2f94024',
'javelin-workflow' => 'a2f94024',
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'lightbox-attachment-css' => 'b3deb720',
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
'maniphest-task-summary-css' => '6b1fccc6',
'maniphest-transaction-detail-css' => '6b1fccc6',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'phabricator-busy' => 'bf16b308',
render_tag -> tag: phabricator_render_form -> phabricator_form Summary: Convert most phabricator_render_form callsites. In the case of the "headsup view", it converts it by deleting the element entirely (this is the very old Maniphest/Differential header which we no longer use). Test Plan: Poked around a bit. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4726
2013-01-30 20:30:38 +01:00
'phabricator-content-source-view-css' => '8aaacd1b',
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'phabricator-core-buttons-css' => 'b3deb720',
'phabricator-core-css' => 'b3deb720',
'phabricator-crumbs-view-css' => 'b3deb720',
'phabricator-directory-css' => 'b3deb720',
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
'phabricator-drag-and-drop-file-upload' => 'e96b08f8',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'phabricator-dropdown-menu' => 'bf16b308',
'phabricator-file-upload' => 'bf16b308',
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'phabricator-filetree-view-css' => 'b3deb720',
'phabricator-flag-css' => 'b3deb720',
'phabricator-form-view-css' => 'b3deb720',
'phabricator-header-view-css' => 'b3deb720',
'phabricator-jump-nav' => 'b3deb720',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'phabricator-keyboard-shortcut' => 'bf16b308',
'phabricator-keyboard-shortcut-manager' => 'bf16b308',
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'phabricator-main-menu-view' => 'b3deb720',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'phabricator-menu-item' => 'bf16b308',
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'phabricator-nav-view-css' => 'b3deb720',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'phabricator-notification' => 'bf16b308',
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'phabricator-notification-css' => 'b3deb720',
'phabricator-notification-menu-css' => 'b3deb720',
'phabricator-object-item-list-view-css' => 'b3deb720',
render_tag -> tag: phabricator_render_form -> phabricator_form Summary: Convert most phabricator_render_form callsites. In the case of the "headsup view", it converts it by deleting the element entirely (this is the very old Maniphest/Differential header which we no longer use). Test Plan: Poked around a bit. Reviewers: vrana Reviewed By: vrana CC: aran Maniphest Tasks: T2432 Differential Revision: https://secure.phabricator.com/D4726
2013-01-30 20:30:38 +01:00
'phabricator-object-selector-css' => '8aaacd1b',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'phabricator-prefab' => 'bf16b308',
Use ObjectItemListView for Maniphest Summary: This isn't quite complete, but everything else is technical cleanup. Broadly: - Removed checkboxes. Selected state is now indicated with CSS, and toggled with shift-click. When nothing is selected, the text reads "Shift-Click Tasks to Select" to let users discover this feature. - Updated drag-to-reorder code to work with ObjectItemListView. - Closed/resolved is now shown with a grey footer icon. - Assigned is now shown with a user profile image handle icon, with a hover state. This could probably use some more tweaks, but overall I think it looks pretty reasonable? Test Plan: {F35897} Reviewers: chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D5340
2013-03-23 22:38:01 +01:00
'phabricator-project-tag-css' => '6b1fccc6',
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'phabricator-remarkup-css' => 'b3deb720',
Fix double-stops on profiler sampling Summary: For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile. Instead, keep track of whether it is running or not, and don't stop it a second time. Ref T2870. Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate. Reviewers: btrahan, chad CC: aran Maniphest Tasks: T2870 Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 15:26:26 +02:00
'phabricator-shaped-request' => 'e96b08f8',
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'phabricator-side-menu-view-css' => 'b3deb720',
'phabricator-standard-page-view' => 'b3deb720',
Allow tokenizer construction to fail Summary: See some discussion in D5622. Javelin explicitly prevents you from putting `<script>` tags into `JX.$H()`, which is probably a good idea, so just let this behavior fail less abruptly instead. We currently have no cases where we load something into a cache and then make a decision about whether to put it into the document or not later on; this should hold us over until we do. If and when we do, we can let those endpoints capture behaviors and replay them later or something. Test Plan: Verified tokenizers still work correctly. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D5623
2013-04-08 22:42:45 +02:00
'phabricator-textareautils' => 'bf16b308',
'phabricator-tooltip' => 'bf16b308',
Allow AphrontDialogView to use PhabricatorActionHeaderView Summary: We're baking some useful things into ActionHeader, would like to consolidate it's use around the site for consistency. Test Plan: Tested log out dialog, attach dependencies, delete document in phriction. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin, AnhNhan Differential Revision: https://secure.phabricator.com/D5635
2013-04-10 00:50:48 +02:00
'phabricator-transaction-view-css' => 'b3deb720',
'phabricator-zindex-css' => 'b3deb720',
'sprite-apps-large-css' => 'b3deb720',
'sprite-gradient-css' => 'b3deb720',
'sprite-icon-css' => 'b3deb720',
'sprite-menu-css' => 'b3deb720',
'syntax-highlighting-css' => 'b3deb720',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
));
Copy permalink