2013-07-13 19:41:49 +02:00
|
|
|
<?php
|
|
|
|
|
|
|
|
final class PhabricatorSlowvoteSearchEngine
|
|
|
|
extends PhabricatorApplicationSearchEngine {
|
|
|
|
|
|
|
|
public function buildSavedQueryFromRequest(AphrontRequest $request) {
|
|
|
|
$saved = new PhabricatorSavedQuery();
|
|
|
|
$saved->setParameter(
|
|
|
|
'authorPHIDs',
|
Allow construction of ApplicationSearch queries with GET
Summary:
Ref T3775 (discussion here). Ref T2625.
T3775 presents two problems:
# Existing tools which linked to `/differential/active/epriestley/` (that is, put a username in the URL) can't generate search links now.
# Humans can't edit the URL anymore, either.
I think (1) is an actual issue, and this fixes it. I think (2) is pretty fluff, and this doesn't really try to fix it, although it probably improves it.
The fix for (1) is:
- Provide a helper to read a parameter containing either a list of user PHIDs or a list of usernames, so `/?users[]=PHID-USER-xyz` (from a tokenizer) and `/?users=alincoln,htaft` (from an external program) are equivalent inputs.
- Rename all the form parameters to be more digestable (`authorPHIDs` -> `authors`). Almost all of them were in this form already anyway. This just gives us `?users=alincoln` instead of `userPHIDs=alincoln`.
- Inside ApplicationSearch, if a request has no query associated with it but does have query parameters, build a query from the request instead of issuing the user's default query. Basically, this means that `/differential/` runs the default query, while `/differential/?users=x` runs a custom query.
Test Plan: {F56612}
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T2625, T3775
Differential Revision: https://secure.phabricator.com/D6840
2013-08-29 20:52:29 +02:00
|
|
|
$this->readUsersFromRequest($request, 'authors'));
|
2013-07-13 19:41:49 +02:00
|
|
|
|
|
|
|
$saved->setParameter('voted', $request->getBool('voted'));
|
2014-04-24 21:00:31 +02:00
|
|
|
$saved->setParameter('statuses', $request->getArr('statuses'));
|
2013-07-13 19:41:49 +02:00
|
|
|
|
|
|
|
return $saved;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
|
|
|
|
$query = id(new PhabricatorSlowvoteQuery())
|
|
|
|
->withAuthorPHIDs($saved->getParameter('authorPHIDs', array()));
|
|
|
|
|
|
|
|
if ($saved->getParameter('voted')) {
|
|
|
|
$query->withVotesByViewer(true);
|
|
|
|
}
|
|
|
|
|
2014-04-24 21:00:31 +02:00
|
|
|
$statuses = $saved->getParameter('statuses', array());
|
|
|
|
if (count($statuses) == 1) {
|
|
|
|
$status = head($statuses);
|
|
|
|
if ($status == 'open') {
|
|
|
|
$query->withIsClosed(false);
|
|
|
|
} else {
|
|
|
|
$query->withIsClosed(true);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-07-13 19:41:49 +02:00
|
|
|
return $query;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function buildSearchForm(
|
|
|
|
AphrontFormView $form,
|
|
|
|
PhabricatorSavedQuery $saved_query) {
|
|
|
|
$phids = $saved_query->getParameter('authorPHIDs', array());
|
2013-10-07 21:51:24 +02:00
|
|
|
$author_handles = id(new PhabricatorHandleQuery())
|
2013-07-13 19:41:49 +02:00
|
|
|
->setViewer($this->requireViewer())
|
2013-09-11 21:27:28 +02:00
|
|
|
->withPHIDs($phids)
|
|
|
|
->execute();
|
2013-07-13 19:41:49 +02:00
|
|
|
|
|
|
|
$voted = $saved_query->getParameter('voted', false);
|
2014-04-24 21:00:31 +02:00
|
|
|
$statuses = $saved_query->getParameter('statuses', array());
|
2013-07-13 19:41:49 +02:00
|
|
|
|
|
|
|
$form
|
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormTokenizerControl())
|
|
|
|
->setDatasource('/typeahead/common/users/')
|
|
|
|
->setName('authors')
|
|
|
|
->setLabel(pht('Authors'))
|
2013-10-07 21:51:24 +02:00
|
|
|
->setValue($author_handles))
|
2013-07-13 19:41:49 +02:00
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormCheckboxControl())
|
|
|
|
->addCheckbox(
|
|
|
|
'voted',
|
|
|
|
1,
|
|
|
|
pht("Show only polls I've voted in."),
|
2014-04-24 21:00:31 +02:00
|
|
|
$voted))
|
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormCheckboxControl())
|
|
|
|
->setLabel(pht('Status'))
|
|
|
|
->addCheckbox(
|
|
|
|
'statuses[]',
|
|
|
|
'open',
|
|
|
|
pht('Open'),
|
|
|
|
in_array('open', $statuses))
|
|
|
|
->addCheckbox(
|
|
|
|
'statuses[]',
|
|
|
|
'closed',
|
|
|
|
pht('Closed'),
|
|
|
|
in_array('closed', $statuses)));
|
2013-07-13 19:41:49 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
protected function getURI($path) {
|
|
|
|
return '/vote/'.$path;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getBuiltinQueryNames() {
|
|
|
|
$names = array(
|
2014-04-24 21:00:31 +02:00
|
|
|
'open' => pht('Open Polls'),
|
2013-07-13 19:41:49 +02:00
|
|
|
'all' => pht('All Polls'),
|
|
|
|
);
|
|
|
|
|
|
|
|
if ($this->requireViewer()->isLoggedIn()) {
|
|
|
|
$names['authored'] = pht('Authored');
|
|
|
|
$names['voted'] = pht('Voted In');
|
|
|
|
}
|
|
|
|
|
|
|
|
return $names;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function buildSavedQueryFromBuiltin($query_key) {
|
|
|
|
$query = $this->newSavedQuery();
|
|
|
|
$query->setQueryKey($query_key);
|
|
|
|
|
|
|
|
switch ($query_key) {
|
2014-04-24 21:00:31 +02:00
|
|
|
case 'open':
|
|
|
|
return $query->setParameter('statuses', array('open'));
|
2013-07-13 19:41:49 +02:00
|
|
|
case 'all':
|
|
|
|
return $query;
|
|
|
|
case 'authored':
|
|
|
|
return $query->setParameter(
|
|
|
|
'authorPHIDs',
|
|
|
|
array($this->requireViewer()->getPHID()));
|
|
|
|
case 'voted':
|
|
|
|
return $query->setParameter('voted', true);
|
|
|
|
}
|
|
|
|
|
|
|
|
return parent::buildSavedQueryFromBuiltin($query_key);
|
|
|
|
}
|
|
|
|
|
2014-05-08 17:40:59 +02:00
|
|
|
public function getRequiredHandlePHIDsForResultList(
|
|
|
|
array $polls,
|
|
|
|
PhabricatorSavedQuery $query) {
|
|
|
|
return mpull($polls, 'getAuthorPHID');
|
|
|
|
}
|
|
|
|
|
2014-05-08 17:49:32 +02:00
|
|
|
protected function renderResultList(
|
2014-05-08 17:40:59 +02:00
|
|
|
array $polls,
|
|
|
|
PhabricatorSavedQuery $query,
|
|
|
|
array $handles) {
|
|
|
|
|
|
|
|
assert_instances_of($polls, 'PhabricatorSlowvotePoll');
|
|
|
|
$viewer = $this->requireViewer();
|
|
|
|
|
|
|
|
$list = id(new PHUIObjectItemListView())
|
|
|
|
->setUser($viewer);
|
|
|
|
|
|
|
|
$phids = mpull($polls, 'getAuthorPHID');
|
|
|
|
|
|
|
|
foreach ($polls as $poll) {
|
|
|
|
$date_created = phabricator_datetime($poll->getDateCreated(), $viewer);
|
|
|
|
if ($poll->getAuthorPHID()) {
|
|
|
|
$author = $handles[$poll->getAuthorPHID()]->renderLink();
|
|
|
|
} else {
|
|
|
|
$author = null;
|
|
|
|
}
|
|
|
|
|
|
|
|
$item = id(new PHUIObjectItemView())
|
|
|
|
->setObjectName('V'.$poll->getID())
|
|
|
|
->setHeader($poll->getQuestion())
|
|
|
|
->setHref('/V'.$poll->getID())
|
|
|
|
->setDisabled($poll->getIsClosed())
|
|
|
|
->addIcon('none', $date_created);
|
|
|
|
|
|
|
|
$description = $poll->getDescription();
|
|
|
|
if (strlen($description)) {
|
|
|
|
$item->addAttribute(phutil_utf8_shorten($poll->getDescription(), 120));
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($author) {
|
|
|
|
$item->addByline(pht('Author: %s', $author));
|
|
|
|
}
|
|
|
|
|
|
|
|
$list->addItem($item);
|
|
|
|
}
|
|
|
|
|
|
|
|
return $list;
|
|
|
|
}
|
|
|
|
|
2013-07-13 19:41:49 +02:00
|
|
|
}
|