2011-02-05 07:45:42 +01:00
|
|
|
/**
|
|
|
|
|
* @provides javelin-behavior-differential-add-reviewers
|
Bring Javelin into Phabricator via git submodule, not copy-and-paste
Summary:
Javelin is currently embedded in Phabricator via copy-and-paste of prebuilt
packages. This is not so great.
Pull it in as a submodule instead and make all the Phabriator resources declare
proper dependency trees. Add Javelin linting.
Test Plan:
I tried to run through pretty much all the JS functionality on the site. This is
still a high-risk change, but I did a pretty thorough test
Differential: inline comments, revealing diffs, list tokenizers, comment
preview, editing/deleting comments, add review action.
Maniphest: list tokenizer, comment actions
Herald: rule editing, tokenizers, add/remove rows
Reviewed By: tomo
Reviewers: aran, tomo, mroch, jungejason, tuomaspelkonen
CC: aran, tomo, epriestley
Differential Revision: 223
2011-05-04 00:11:55 +02:00
|
|
|
* @requires javelin-behavior
|
|
|
|
|
* javelin-dom
|
|
|
|
|
* javelin-tokenizer
|
|
|
|
|
* javelin-typeahead
|
|
|
|
|
* javelin-typeahead-preloaded-source
|
2011-02-05 07:45:42 +01:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
JX.behavior('differential-add-reviewers', function(config) {
|
|
|
|
|
|
|
|
|
|
var root = JX.$(config.tokenizer);
|
|
|
|
|
var datasource = new JX.TypeaheadPreloadedSource(config.src);
|
|
|
|
|
|
|
|
|
|
var typeahead = new JX.Typeahead(root);
|
|
|
|
|
typeahead.setDatasource(datasource);
|
|
|
|
|
|
|
|
|
|
var tokenizer = new JX.Tokenizer(root);
|
|
|
|
|
tokenizer.setTypeahead(typeahead);
|
|
|
|
|
tokenizer.start();
|
|
|
|
|
|
|
|
|
|
JX.DOM.listen(
|
|
|
|
|
JX.$(config.select),
|
|
|
|
|
'change',
|
|
|
|
|
null,
|
|
|
|
|
function(e) {
|
|
|
|
|
if (JX.$(config.select).value == 'add_reviewers') {
|
|
|
|
|
JX.DOM.show(JX.$(config.row));
|
|
|
|
|
tokenizer.refresh();
|
|
|
|
|
} else {
|
|
|
|
|
JX.DOM.hide(JX.$(config.row));
|
|
|
|
|
}
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
