Make mobile navigation work properly by default in more cases
Summary:
Fixes T5752. This obsoletes a bunch of old patterns and I'll follow up on those with a big "go do a bunch of mechanical code changes" task. Major goals are:
- Don't load named queries multiple times on search pages.
- Don't require extra code to get standard navigation right on mobile.
- Reduce the amount of boilerplate in ListControllers.
- Reduce the amount of boilerplate around navigation/menus in all controllers.
Specifically, here's what this does:
- The StandardPage is now a smarter/more structured object with `setNavigation()` and `setCrumbs()` methods. More rendering decisions are delayed until the last possible moment.
- It uses this to automatically add crumb actions to the application menu.
- It uses this to automatically reuse one SearchEngine instead of running queries multiple times.
- The new preferred way to build responses is `$this->newPage()` (like `$this->newDialog()`), which has structured methods for adding stuff (`setTitle()`, etc).
- SearchEngine exposes a new convenience method so you don't have to do all the controller delegation stuff.
- Building menus is generally simpler.
Test Plan:
- Tested paste list, view, edit, comment, raw controllers for functionality, mobile menu, crumbs, navigation menu.
- Edited saved queries.
- Tested Differential, Maniphest (no changes).
- Verified the paste pages don't run any duplicate NamedQuery queries.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T5752
Differential Revision: https://secure.phabricator.com/D14382
2015-11-02 12:06:28 -08:00
|
|
|
<?php
|
|
|
|
|
|
|
|
final class PHUIApplicationMenuView extends Phobject {
|
|
|
|
|
|
|
|
private $viewer;
|
|
|
|
private $crumbs;
|
|
|
|
private $searchEngine;
|
2016-01-12 14:15:59 -08:00
|
|
|
private $profileMenu;
|
Make mobile navigation work properly by default in more cases
Summary:
Fixes T5752. This obsoletes a bunch of old patterns and I'll follow up on those with a big "go do a bunch of mechanical code changes" task. Major goals are:
- Don't load named queries multiple times on search pages.
- Don't require extra code to get standard navigation right on mobile.
- Reduce the amount of boilerplate in ListControllers.
- Reduce the amount of boilerplate around navigation/menus in all controllers.
Specifically, here's what this does:
- The StandardPage is now a smarter/more structured object with `setNavigation()` and `setCrumbs()` methods. More rendering decisions are delayed until the last possible moment.
- It uses this to automatically add crumb actions to the application menu.
- It uses this to automatically reuse one SearchEngine instead of running queries multiple times.
- The new preferred way to build responses is `$this->newPage()` (like `$this->newDialog()`), which has structured methods for adding stuff (`setTitle()`, etc).
- SearchEngine exposes a new convenience method so you don't have to do all the controller delegation stuff.
- Building menus is generally simpler.
Test Plan:
- Tested paste list, view, edit, comment, raw controllers for functionality, mobile menu, crumbs, navigation menu.
- Edited saved queries.
- Tested Differential, Maniphest (no changes).
- Verified the paste pages don't run any duplicate NamedQuery queries.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T5752
Differential Revision: https://secure.phabricator.com/D14382
2015-11-02 12:06:28 -08:00
|
|
|
|
|
|
|
private $items = array();
|
|
|
|
|
|
|
|
public function setViewer(PhabricatorUser $viewer) {
|
|
|
|
$this->viewer = $viewer;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getViewer() {
|
|
|
|
return $this->viewer;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function addLabel($name) {
|
|
|
|
$item = id(new PHUIListItemView())
|
|
|
|
->setName($name);
|
|
|
|
|
|
|
|
return $this->addItem($item);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function addLink($name, $href) {
|
|
|
|
$item = id(new PHUIListItemView())
|
|
|
|
->setName($name)
|
|
|
|
->setHref($href);
|
|
|
|
|
|
|
|
return $this->addItem($item);
|
|
|
|
}
|
|
|
|
|
2016-01-12 14:15:59 -08:00
|
|
|
public function setProfileMenu(
|
|
|
|
AphrontSideNavFilterView $nav) {
|
|
|
|
$this->profileMenu = $nav;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getProfileMenu() {
|
|
|
|
return $this->profileMenu;
|
|
|
|
}
|
|
|
|
|
Make mobile navigation work properly by default in more cases
Summary:
Fixes T5752. This obsoletes a bunch of old patterns and I'll follow up on those with a big "go do a bunch of mechanical code changes" task. Major goals are:
- Don't load named queries multiple times on search pages.
- Don't require extra code to get standard navigation right on mobile.
- Reduce the amount of boilerplate in ListControllers.
- Reduce the amount of boilerplate around navigation/menus in all controllers.
Specifically, here's what this does:
- The StandardPage is now a smarter/more structured object with `setNavigation()` and `setCrumbs()` methods. More rendering decisions are delayed until the last possible moment.
- It uses this to automatically add crumb actions to the application menu.
- It uses this to automatically reuse one SearchEngine instead of running queries multiple times.
- The new preferred way to build responses is `$this->newPage()` (like `$this->newDialog()`), which has structured methods for adding stuff (`setTitle()`, etc).
- SearchEngine exposes a new convenience method so you don't have to do all the controller delegation stuff.
- Building menus is generally simpler.
Test Plan:
- Tested paste list, view, edit, comment, raw controllers for functionality, mobile menu, crumbs, navigation menu.
- Edited saved queries.
- Tested Differential, Maniphest (no changes).
- Verified the paste pages don't run any duplicate NamedQuery queries.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T5752
Differential Revision: https://secure.phabricator.com/D14382
2015-11-02 12:06:28 -08:00
|
|
|
public function addItem(PHUIListItemView $item) {
|
|
|
|
$this->items[] = $item;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setSearchEngine(PhabricatorApplicationSearchEngine $engine) {
|
|
|
|
$this->searchEngine = $engine;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getSearchEngine() {
|
|
|
|
return $this->searchEngine;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setCrumbs(PHUICrumbsView $crumbs) {
|
|
|
|
$this->crumbs = $crumbs;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getCrumbs() {
|
|
|
|
return $this->crumbs;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function buildListView() {
|
|
|
|
$viewer = $this->getViewer();
|
|
|
|
|
|
|
|
$view = id(new PHUIListView())
|
|
|
|
->setUser($viewer);
|
|
|
|
|
2016-01-12 14:15:59 -08:00
|
|
|
$profile_menu = $this->getProfileMenu();
|
|
|
|
if ($profile_menu) {
|
|
|
|
foreach ($profile_menu->getMenu()->getItems() as $item) {
|
2016-01-19 10:35:32 -08:00
|
|
|
if ($item->getHideInApplicationMenu()) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2016-01-12 14:15:59 -08:00
|
|
|
$item = clone $item;
|
|
|
|
$view->addMenuItem($item);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
Make mobile navigation work properly by default in more cases
Summary:
Fixes T5752. This obsoletes a bunch of old patterns and I'll follow up on those with a big "go do a bunch of mechanical code changes" task. Major goals are:
- Don't load named queries multiple times on search pages.
- Don't require extra code to get standard navigation right on mobile.
- Reduce the amount of boilerplate in ListControllers.
- Reduce the amount of boilerplate around navigation/menus in all controllers.
Specifically, here's what this does:
- The StandardPage is now a smarter/more structured object with `setNavigation()` and `setCrumbs()` methods. More rendering decisions are delayed until the last possible moment.
- It uses this to automatically add crumb actions to the application menu.
- It uses this to automatically reuse one SearchEngine instead of running queries multiple times.
- The new preferred way to build responses is `$this->newPage()` (like `$this->newDialog()`), which has structured methods for adding stuff (`setTitle()`, etc).
- SearchEngine exposes a new convenience method so you don't have to do all the controller delegation stuff.
- Building menus is generally simpler.
Test Plan:
- Tested paste list, view, edit, comment, raw controllers for functionality, mobile menu, crumbs, navigation menu.
- Edited saved queries.
- Tested Differential, Maniphest (no changes).
- Verified the paste pages don't run any duplicate NamedQuery queries.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T5752
Differential Revision: https://secure.phabricator.com/D14382
2015-11-02 12:06:28 -08:00
|
|
|
$crumbs = $this->getCrumbs();
|
|
|
|
if ($crumbs) {
|
|
|
|
$actions = $crumbs->getActions();
|
|
|
|
if ($actions) {
|
|
|
|
$view->newLabel(pht('Create'));
|
|
|
|
foreach ($crumbs->getActions() as $action) {
|
|
|
|
$view->addMenuItem($action);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
$engine = $this->getSearchEngine();
|
|
|
|
if ($engine) {
|
|
|
|
$engine
|
|
|
|
->setViewer($viewer)
|
|
|
|
->addNavigationItems($view);
|
|
|
|
}
|
|
|
|
|
|
|
|
foreach ($this->items as $item) {
|
|
|
|
$view->addMenuItem($item);
|
|
|
|
}
|
|
|
|
|
|
|
|
return $view;
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|