2014-02-03 19:52:15 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
final class PhabricatorDashboardEditController
|
|
|
|
extends PhabricatorDashboardController {
|
|
|
|
|
|
|
|
private $id;
|
|
|
|
|
|
|
|
public function willProcessRequest(array $data) {
|
|
|
|
$this->id = idx($data, 'id');
|
|
|
|
}
|
|
|
|
|
|
|
|
public function processRequest() {
|
|
|
|
$request = $this->getRequest();
|
|
|
|
$viewer = $request->getUser();
|
|
|
|
|
|
|
|
if ($this->id) {
|
|
|
|
$dashboard = id(new PhabricatorDashboardQuery())
|
|
|
|
->setViewer($viewer)
|
|
|
|
->withIDs(array($this->id))
|
2014-05-16 04:12:40 +02:00
|
|
|
->needPanels(true)
|
2014-02-03 19:52:15 +01:00
|
|
|
->requireCapabilities(
|
|
|
|
array(
|
|
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
|
|
))
|
|
|
|
->executeOne();
|
|
|
|
if (!$dashboard) {
|
|
|
|
return new Aphront404Response();
|
|
|
|
}
|
|
|
|
|
|
|
|
$is_new = false;
|
|
|
|
} else {
|
|
|
|
$dashboard = PhabricatorDashboard::initializeNewDashboard($viewer);
|
|
|
|
|
|
|
|
$is_new = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
$crumbs = $this->buildApplicationCrumbs();
|
|
|
|
|
|
|
|
if ($is_new) {
|
|
|
|
$title = pht('Create Dashboard');
|
|
|
|
$header = pht('Create Dashboard');
|
|
|
|
$button = pht('Create Dashboard');
|
|
|
|
$cancel_uri = $this->getApplicationURI();
|
|
|
|
|
|
|
|
$crumbs->addTextCrumb('Create Dashboard');
|
|
|
|
} else {
|
|
|
|
$id = $dashboard->getID();
|
Make the default view of dashboards be just the dashboard
Summary: Fixes T4985, add manage page, change view page to show only panels. Arguably, PhabricatorDashboardArrangeController is no longer necessary. Also, still trying to figure out if I updated all flows that involve "arrange/{id}". Probably missed some. Also not sure of the Manage Dashboard icon. Please advise.
Test Plan: Create dashboard, add panels, "view/{id}" should show just panels, Manage Dashboard should show timeline and edit links.
Reviewers: #blessed_reviewers, epriestley, chad
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T4985
Differential Revision: https://secure.phabricator.com/D9258
2014-05-22 19:59:46 +02:00
|
|
|
$cancel_uri = $this->getApplicationURI('manage/'.$id.'/');
|
2014-02-03 19:52:15 +01:00
|
|
|
|
|
|
|
$title = pht('Edit Dashboard %d', $dashboard->getID());
|
|
|
|
$header = pht('Edit Dashboard "%s"', $dashboard->getName());
|
|
|
|
$button = pht('Save Changes');
|
|
|
|
|
|
|
|
$crumbs->addTextCrumb(pht('Dashboard %d', $id), $cancel_uri);
|
|
|
|
$crumbs->addTextCrumb(pht('Edit'));
|
|
|
|
}
|
|
|
|
|
|
|
|
$v_name = $dashboard->getName();
|
2014-05-16 04:12:40 +02:00
|
|
|
$v_layout_mode = $dashboard->getLayoutConfigObject()->getLayoutMode();
|
2014-02-03 19:52:15 +01:00
|
|
|
$e_name = true;
|
|
|
|
|
|
|
|
$validation_exception = null;
|
|
|
|
if ($request->isFormPost()) {
|
|
|
|
$v_name = $request->getStr('name');
|
2014-05-16 04:12:40 +02:00
|
|
|
$v_layout_mode = $request->getStr('layout_mode');
|
2014-05-21 21:23:14 +02:00
|
|
|
$v_view_policy = $request->getStr('viewPolicy');
|
|
|
|
$v_edit_policy = $request->getStr('editPolicy');
|
2014-02-03 19:52:15 +01:00
|
|
|
|
|
|
|
$xactions = array();
|
|
|
|
|
|
|
|
$type_name = PhabricatorDashboardTransaction::TYPE_NAME;
|
2014-05-16 04:12:40 +02:00
|
|
|
$type_layout_mode = PhabricatorDashboardTransaction::TYPE_LAYOUT_MODE;
|
2014-05-21 21:23:14 +02:00
|
|
|
$type_view_policy = PhabricatorTransactions::TYPE_VIEW_POLICY;
|
|
|
|
$type_edit_policy = PhabricatorTransactions::TYPE_EDIT_POLICY;
|
2014-02-03 19:52:15 +01:00
|
|
|
|
|
|
|
$xactions[] = id(new PhabricatorDashboardTransaction())
|
|
|
|
->setTransactionType($type_name)
|
|
|
|
->setNewValue($v_name);
|
2014-05-16 04:12:40 +02:00
|
|
|
$xactions[] = id(new PhabricatorDashboardTransaction())
|
|
|
|
->setTransactionType($type_layout_mode)
|
|
|
|
->setNewValue($v_layout_mode);
|
2014-05-21 21:23:14 +02:00
|
|
|
$xactions[] = id(new PhabricatorDashboardTransaction())
|
|
|
|
->setTransactionType($type_view_policy)
|
|
|
|
->setNewValue($v_view_policy);
|
|
|
|
$xactions[] = id(new PhabricatorDashboardTransaction())
|
|
|
|
->setTransactionType($type_edit_policy)
|
|
|
|
->setNewValue($v_edit_policy);
|
2014-02-03 19:52:15 +01:00
|
|
|
|
|
|
|
try {
|
|
|
|
$editor = id(new PhabricatorDashboardTransactionEditor())
|
|
|
|
->setActor($viewer)
|
|
|
|
->setContinueOnNoEffect(true)
|
|
|
|
->setContentSourceFromRequest($request)
|
|
|
|
->applyTransactions($dashboard, $xactions);
|
|
|
|
|
Make the default view of dashboards be just the dashboard
Summary: Fixes T4985, add manage page, change view page to show only panels. Arguably, PhabricatorDashboardArrangeController is no longer necessary. Also, still trying to figure out if I updated all flows that involve "arrange/{id}". Probably missed some. Also not sure of the Manage Dashboard icon. Please advise.
Test Plan: Create dashboard, add panels, "view/{id}" should show just panels, Manage Dashboard should show timeline and edit links.
Reviewers: #blessed_reviewers, epriestley, chad
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T4985
Differential Revision: https://secure.phabricator.com/D9258
2014-05-22 19:59:46 +02:00
|
|
|
$uri = $this->getApplicationURI('manage/'.$dashboard->getID().'/');
|
|
|
|
|
2014-05-16 04:12:40 +02:00
|
|
|
return id(new AphrontRedirectResponse())->setURI($uri);
|
2014-02-03 19:52:15 +01:00
|
|
|
} catch (PhabricatorApplicationTransactionValidationException $ex) {
|
|
|
|
$validation_exception = $ex;
|
|
|
|
|
|
|
|
$e_name = $validation_exception->getShortMessage($type_name);
|
2014-05-21 21:23:14 +02:00
|
|
|
|
|
|
|
$dashboard->setViewPolicy($v_view_policy);
|
|
|
|
$dashboard->setEditPolicy($v_edit_policy);
|
2014-02-03 19:52:15 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2014-05-21 21:23:14 +02:00
|
|
|
$policies = id(new PhabricatorPolicyQuery())
|
|
|
|
->setViewer($viewer)
|
|
|
|
->setObject($dashboard)
|
|
|
|
->execute();
|
|
|
|
|
2014-05-16 04:12:40 +02:00
|
|
|
$layout_mode_options =
|
|
|
|
PhabricatorDashboardLayoutConfig::getLayoutModeSelectOptions();
|
2014-02-03 19:52:15 +01:00
|
|
|
$form = id(new AphrontFormView())
|
|
|
|
->setUser($viewer)
|
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormTextControl())
|
|
|
|
->setLabel(pht('Name'))
|
|
|
|
->setName('name')
|
|
|
|
->setValue($v_name)
|
|
|
|
->setError($e_name))
|
2014-05-21 21:23:14 +02:00
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormPolicyControl())
|
|
|
|
->setName('viewPolicy')
|
|
|
|
->setPolicyObject($dashboard)
|
|
|
|
->setCapability(PhabricatorPolicyCapability::CAN_VIEW)
|
|
|
|
->setPolicies($policies))
|
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormPolicyControl())
|
|
|
|
->setName('editPolicy')
|
|
|
|
->setPolicyObject($dashboard)
|
|
|
|
->setCapability(PhabricatorPolicyCapability::CAN_EDIT)
|
|
|
|
->setPolicies($policies))
|
2014-05-16 04:12:40 +02:00
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormSelectControl())
|
|
|
|
->setLabel(pht('Layout Mode'))
|
|
|
|
->setName('layout_mode')
|
|
|
|
->setValue($v_layout_mode)
|
|
|
|
->setOptions($layout_mode_options))
|
2014-02-03 19:52:15 +01:00
|
|
|
->appendChild(
|
|
|
|
id(new AphrontFormSubmitControl())
|
|
|
|
->setValue($button)
|
|
|
|
->addCancelButton($cancel_uri));
|
|
|
|
|
|
|
|
$box = id(new PHUIObjectBoxView())
|
|
|
|
->setHeaderText($header)
|
|
|
|
->setForm($form)
|
|
|
|
->setValidationException($validation_exception);
|
|
|
|
|
|
|
|
return $this->buildApplicationPage(
|
|
|
|
array(
|
|
|
|
$crumbs,
|
|
|
|
$box,
|
|
|
|
),
|
|
|
|
array(
|
|
|
|
'title' => $title,
|
|
|
|
'device' => true,
|
|
|
|
));
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|