revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-28 16:30:59 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/__celerity_resource_map__.php

2872 lines
85 KiB
PHP
Raw Normal View History

Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
<?php
/**
* This file is automatically generated. Use 'celerity_mapper.php' to rebuild
* it.
* @generated
*/
celerity_register_resource_map(array(
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/apps.png' =>
array(
'hash' => 'f7cb4abeb73245fea4098a02fd784653',
'uri' => '/res/f7cb4abe/rsrc/image/apps.png',
'disk' => '/rsrc/image/apps.png',
'type' => 'png',
),
Highlight copied/moved lines in Differential Summary: The color used for this feature is pretty important and I am bad with colors. Test Plan: View diff created by D2320 with some copied lines and one line changed: {F10604, size=full} Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2321
2012-04-26 09:18:42 +02:00
'/rsrc/image/avatar.png' =>
array(
'hash' => '1c5f255071537f05406adee86717ff27',
'uri' => '/res/1c5f2550/rsrc/image/avatar.png',
'disk' => '/rsrc/image/avatar.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/credit_cards.png' =>
array(
'hash' => '681448de424ea159b6ea68af04c046ae',
'uri' => '/res/681448de/rsrc/image/credit_cards.png',
'disk' => '/rsrc/image/credit_cards.png',
'type' => 'png',
),
'/rsrc/image/custom/example_facebook.png' =>
array(
'hash' => '062911a848dd7b58159d4184488ecac4',
'uri' => '/res/062911a8/rsrc/image/custom/example_facebook.png',
'disk' => '/rsrc/image/custom/example_facebook.png',
'type' => 'png',
),
'/rsrc/image/custom/example_rainbow.png' =>
array(
'hash' => '7af08c16d969a2d63b4acdbd5cee2e8f',
'uri' => '/res/7af08c16/rsrc/image/custom/example_rainbow.png',
'disk' => '/rsrc/image/custom/example_rainbow.png',
'type' => 'png',
),
'/rsrc/image/custom/example_template.png' =>
array(
'hash' => '9971fe1adb16682a18f9b588c4fc051b',
'uri' => '/res/9971fe1a/rsrc/image/custom/example_template.png',
'disk' => '/rsrc/image/custom/example_template.png',
'type' => 'png',
),
'/rsrc/image/grippy_texture.png' =>
array(
'hash' => 'a8945e12ceeaddd5b491a8d81cfa19c1',
'uri' => '/res/a8945e12/rsrc/image/grippy_texture.png',
'disk' => '/rsrc/image/grippy_texture.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/arrow_branch.png' =>
array(
'hash' => 'f27b67520766e3d971722bcff703f3a8',
'uri' => '/res/f27b6752/rsrc/image/icon/fatcow/arrow_branch.png',
'disk' => '/rsrc/image/icon/fatcow/arrow_branch.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/arrow_merge.png' =>
array(
'hash' => 'c4bd97f3b1257439e2123ef69d2194d0',
'uri' => '/res/c4bd97f3/rsrc/image/icon/fatcow/arrow_merge.png',
'disk' => '/rsrc/image/icon/fatcow/arrow_merge.png',
'type' => 'png',
),
dark console - introduce "request log" section Summary: this section gets updated for each and every request. clicking a given entry updates the larger dark-console area to have the information from that request Test Plan: clicked around in maniphest and observed request log populating correctly. clicked a few entries in request log and saw it updated properly. clicked a different tab in the dark-console and it worked. clicked a different request log entry and it opened the dark console to the proper request on the proper tab. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1136 Differential Revision: https://secure.phabricator.com/D2574
2012-05-25 19:14:17 +02:00
'/rsrc/image/icon/fatcow/bullet_black.png' =>
array(
'hash' => '718f9c560a13766796f1be7dfaadeeab',
'uri' => '/res/718f9c56/rsrc/image/icon/fatcow/bullet_black.png',
'disk' => '/rsrc/image/icon/fatcow/bullet_black.png',
'type' => 'png',
),
Highlight away status by bullet and display it everywhere Summary: D2484#13 Test Plan: Display revision list. Display revision detail. Reviewers: epriestley Reviewed By: epriestley CC: btrahan, aran, Koolvin Differential Revision: https://secure.phabricator.com/D2501
2012-05-19 18:18:34 +02:00
'/rsrc/image/icon/fatcow/bullet_orange.png' =>
array(
'hash' => 'c3bf91b65baacb27f2af143ab9180119',
'uri' => '/res/c3bf91b6/rsrc/image/icon/fatcow/bullet_orange.png',
'disk' => '/rsrc/image/icon/fatcow/bullet_orange.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/bullet_red.png' =>
array(
'hash' => '00273e4aa6ea3de630295610d6c9560c',
'uri' => '/res/00273e4a/rsrc/image/icon/fatcow/bullet_red.png',
'disk' => '/rsrc/image/icon/fatcow/bullet_red.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/icon/fatcow/calendar_edit.png' =>
array(
'hash' => 'de249c0f4f37bf5b2c69ff39ec5573fb',
'uri' => '/res/de249c0f/rsrc/image/icon/fatcow/calendar_edit.png',
'disk' => '/rsrc/image/icon/fatcow/calendar_edit.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_blue.png' =>
array(
'hash' => '75a080492f900fbe489e4b27e403962b',
'uri' => '/res/75a08049/rsrc/image/icon/fatcow/flag_blue.png',
'disk' => '/rsrc/image/icon/fatcow/flag_blue.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_finish.png' =>
array(
'hash' => '4af11fc7fab8e4610cbc3c88a02d4f78',
'uri' => '/res/4af11fc7/rsrc/image/icon/fatcow/flag_finish.png',
'disk' => '/rsrc/image/icon/fatcow/flag_finish.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_ghost.png' =>
array(
'hash' => '14c9f30a37b43f276f27a27a924bf02d',
'uri' => '/res/14c9f30a/rsrc/image/icon/fatcow/flag_ghost.png',
'disk' => '/rsrc/image/icon/fatcow/flag_ghost.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_green.png' =>
array(
'hash' => 'fed01374cd396cb774872762dcc447e1',
'uri' => '/res/fed01374/rsrc/image/icon/fatcow/flag_green.png',
'disk' => '/rsrc/image/icon/fatcow/flag_green.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_orange.png' =>
array(
'hash' => '88008cb8bb99761a37e5a743e2455aeb',
'uri' => '/res/88008cb8/rsrc/image/icon/fatcow/flag_orange.png',
'disk' => '/rsrc/image/icon/fatcow/flag_orange.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_pink.png' =>
array(
'hash' => '2f199f06ffc3dfc81b7561a057e0bc33',
'uri' => '/res/2f199f06/rsrc/image/icon/fatcow/flag_pink.png',
'disk' => '/rsrc/image/icon/fatcow/flag_pink.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_purple.png' =>
array(
'hash' => '16358629dc86c39550b575586eb5df80',
'uri' => '/res/16358629/rsrc/image/icon/fatcow/flag_purple.png',
'disk' => '/rsrc/image/icon/fatcow/flag_purple.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_red.png' =>
array(
'hash' => '210c28b4d93c439a499f5814f5e05772',
'uri' => '/res/210c28b4/rsrc/image/icon/fatcow/flag_red.png',
'disk' => '/rsrc/image/icon/fatcow/flag_red.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/flag_yellow.png' =>
array(
'hash' => 'bdfd73744a80bb80329ae50bc8a5f962',
'uri' => '/res/bdfd7374/rsrc/image/icon/fatcow/flag_yellow.png',
'disk' => '/rsrc/image/icon/fatcow/flag_yellow.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/folder.png' =>
array(
'hash' => '25e46cf9d210dde2242332296f79938c',
'uri' => '/res/25e46cf9/rsrc/image/icon/fatcow/folder.png',
'disk' => '/rsrc/image/icon/fatcow/folder.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/folder_go.png' =>
array(
'hash' => 'ba922ff7959309f51a14cb7ed5124d8b',
'uri' => '/res/ba922ff7/rsrc/image/icon/fatcow/folder_go.png',
'disk' => '/rsrc/image/icon/fatcow/folder_go.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/key_question.png' =>
array(
'hash' => '530a6448a4b91edec091a9292ccfd3d9',
'uri' => '/res/530a6448/rsrc/image/icon/fatcow/key_question.png',
'disk' => '/rsrc/image/icon/fatcow/key_question.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/link.png' =>
array(
'hash' => 'be1bea49b216548433014f3324902928',
'uri' => '/res/be1bea49/rsrc/image/icon/fatcow/link.png',
'disk' => '/rsrc/image/icon/fatcow/link.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/page_white_link.png' =>
array(
'hash' => '1cfbad14412bda6c6f132dcc7c8725fd',
'uri' => '/res/1cfbad14/rsrc/image/icon/fatcow/page_white_link.png',
'disk' => '/rsrc/image/icon/fatcow/page_white_link.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/page_white_put.png' =>
array(
'hash' => 'bb7308aa5ac40137a8262da395a267fd',
'uri' => '/res/bb7308aa/rsrc/image/icon/fatcow/page_white_put.png',
'disk' => '/rsrc/image/icon/fatcow/page_white_put.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/page_white_text.png' =>
array(
'hash' => 'e47d590b626f617fb7d1d44e96e8fd11',
'uri' => '/res/e47d590b/rsrc/image/icon/fatcow/page_white_text.png',
'disk' => '/rsrc/image/icon/fatcow/page_white_text.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/conduit.png' =>
array(
'hash' => '1cae0656580aa3cd0b54b9d98306b1b9',
'uri' => '/res/1cae0656/rsrc/image/icon/fatcow/source/conduit.png',
'disk' => '/rsrc/image/icon/fatcow/source/conduit.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/email.png' =>
array(
'hash' => '93bdb3e168da1ed68f50c42125729d4e',
'uri' => '/res/93bdb3e1/rsrc/image/icon/fatcow/source/email.png',
'disk' => '/rsrc/image/icon/fatcow/source/email.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/fax.png' =>
array(
'hash' => 'd7dedf229841f2d041b347afd881596f',
'uri' => '/res/d7dedf22/rsrc/image/icon/fatcow/source/fax.png',
'disk' => '/rsrc/image/icon/fatcow/source/fax.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/mobile.png' =>
array(
'hash' => '786e7146d1e7d7318baf76c9d2baad97',
'uri' => '/res/786e7146/rsrc/image/icon/fatcow/source/mobile.png',
'disk' => '/rsrc/image/icon/fatcow/source/mobile.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/tablet.png' =>
array(
'hash' => '374cd40e4965be6b2fbdef4059d0ca05',
'uri' => '/res/374cd40e/rsrc/image/icon/fatcow/source/tablet.png',
'disk' => '/rsrc/image/icon/fatcow/source/tablet.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/source/web.png' =>
array(
'hash' => 'f4882a8f5619ba505ca033f72a340635',
'uri' => '/res/f4882a8f/rsrc/image/icon/fatcow/source/web.png',
'disk' => '/rsrc/image/icon/fatcow/source/web.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/default160x120.png' =>
array(
'hash' => '1b52ebd1fe0eee3ed0abfc382991b265',
'uri' => '/res/1b52ebd1/rsrc/image/icon/fatcow/thumbnails/default160x120.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/default160x120.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/default60x45.png' =>
array(
'hash' => '048d851d8d1daad4754e891e734c1899',
'uri' => '/res/048d851d/rsrc/image/icon/fatcow/thumbnails/default60x45.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/default60x45.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/image160x120.png' =>
array(
'hash' => '434acbd8dbbc2da9f09f6205a396eba1',
'uri' => '/res/434acbd8/rsrc/image/icon/fatcow/thumbnails/image160x120.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/image160x120.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/image60x45.png' =>
array(
'hash' => '29f7872dc53588fe0b8f0b330c7ee23a',
'uri' => '/res/29f7872d/rsrc/image/icon/fatcow/thumbnails/image60x45.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/image60x45.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/pdf160x120.png' =>
array(
'hash' => '39d2e22541658a3472ba41ae2fa548e5',
'uri' => '/res/39d2e225/rsrc/image/icon/fatcow/thumbnails/pdf160x120.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/pdf160x120.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/pdf60x45.png' =>
array(
'hash' => 'b3572e9317cbed5184d12bdfabed2727',
'uri' => '/res/b3572e93/rsrc/image/icon/fatcow/thumbnails/pdf60x45.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/pdf60x45.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/zip160x120.png' =>
array(
'hash' => 'e505108688a903b5cfb674707a289bcc',
'uri' => '/res/e5051086/rsrc/image/icon/fatcow/thumbnails/zip160x120.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/zip160x120.png',
'type' => 'png',
),
'/rsrc/image/icon/fatcow/thumbnails/zip60x45.png' =>
array(
'hash' => 'f00716f4e8f7a95e70d43504f06be0a6',
'uri' => '/res/f00716f4/rsrc/image/icon/fatcow/thumbnails/zip60x45.png',
'disk' => '/rsrc/image/icon/fatcow/thumbnails/zip60x45.png',
'type' => 'png',
),
'/rsrc/image/icon/subscribe.png' =>
array(
'hash' => '5f47a4b17de245af39a4e7a097e40623',
'uri' => '/res/5f47a4b1/rsrc/image/icon/subscribe.png',
'disk' => '/rsrc/image/icon/subscribe.png',
'type' => 'png',
),
'/rsrc/image/icon/tango/attachment.png' =>
array(
'hash' => '776fed2de89803fd8a0ba4b9deede230',
'uri' => '/res/776fed2d/rsrc/image/icon/tango/attachment.png',
'disk' => '/rsrc/image/icon/tango/attachment.png',
'type' => 'png',
),
'/rsrc/image/icon/tango/edit.png' =>
array(
'hash' => 'c0028d99dcf4e9559bbf3c88ce2d8a8d',
'uri' => '/res/c0028d99/rsrc/image/icon/tango/edit.png',
'disk' => '/rsrc/image/icon/tango/edit.png',
'type' => 'png',
),
Open files in very large diffs inline Summary: This allows writing inline comments and reduces different behavior between normal and very large diffs. Test Plan: Verify that normal diff works. Verify that very large diff works. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2361
2012-05-01 21:09:50 +02:00
'/rsrc/image/icon/tango/go-down.png' =>
array(
'hash' => '96862812cbb0445573c264dc057b8300',
'uri' => '/res/96862812/rsrc/image/icon/tango/go-down.png',
'disk' => '/rsrc/image/icon/tango/go-down.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/icon/tango/log.png' =>
array(
'hash' => 'a6f72499bef279ff6807a7dbc5148f1e',
'uri' => '/res/a6f72499/rsrc/image/icon/tango/log.png',
'disk' => '/rsrc/image/icon/tango/log.png',
'type' => 'png',
),
'/rsrc/image/icon/tango/upload.png' =>
array(
'hash' => '8c11b63d6d99db3d7159c5d9a94e3062',
'uri' => '/res/8c11b63d/rsrc/image/icon/tango/upload.png',
'disk' => '/rsrc/image/icon/tango/upload.png',
'type' => 'png',
),
'/rsrc/image/icon/unsubscribe.png' =>
array(
'hash' => '29429ad65aa3af50b072b32087057361',
'uri' => '/res/29429ad6/rsrc/image/icon/unsubscribe.png',
'disk' => '/rsrc/image/icon/unsubscribe.png',
'type' => 'png',
),
Apply AMAZING DESIGN SKILLS to notification menu Summary: I am a fancy designer! {F12665} {F12666} Test Plan: Opened/closed menu. Viewed with-notification-count and without-notification count states. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, chad, joe Maniphest Tasks: T974 Differential Revision: https://secure.phabricator.com/D2735
2012-06-14 15:13:53 +02:00
'/rsrc/image/notification_menu.png' =>
array(
'hash' => 'f3834ad08a16fc631cd46ceb5db4fb0e',
'uri' => '/res/f3834ad0/rsrc/image/notification_menu.png',
'disk' => '/rsrc/image/notification_menu.png',
'type' => 'png',
),
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'/rsrc/image/phabricator_logo.png' =>
array(
'hash' => '7e62ff4001914cb3c87893a228f400c4',
'uri' => '/res/7e62ff40/rsrc/image/phabricator_logo.png',
'disk' => '/rsrc/image/phabricator_logo.png',
'type' => 'png',
),
'/rsrc/image/phabricator_logo_admin.png' =>
array(
'hash' => '98c8fd922b8ccf21c268b3451393a28f',
'uri' => '/res/98c8fd92/rsrc/image/phabricator_logo_admin.png',
'disk' => '/rsrc/image/phabricator_logo_admin.png',
'type' => 'png',
),
'/rsrc/image/sprite.png' =>
array(
'hash' => '8c6200d3191c0deea30f22e7b8166b15',
'uri' => '/res/8c6200d3/rsrc/image/sprite.png',
'disk' => '/rsrc/image/sprite.png',
'type' => 'png',
),
'/rsrc/swf/aphlict.swf' =>
array(
Minor, update celerity map.
2012-06-12 02:52:17 +02:00
'hash' => '4b9a9d83bebaf254f3790e87b45c1f92',
'uri' => '/res/4b9a9d83/rsrc/swf/aphlict.swf',
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'disk' => '/rsrc/swf/aphlict.swf',
'type' => 'swf',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'aphront-attached-file-view-css' =>
array(
'uri' => '/res/a6ca5487/rsrc/css/aphront/attached-file-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/attached-file-view.css',
),
'aphront-calendar-view-css' =>
array(
Don't mix different users on the same line in Calendar Summary: The current state is very confusing: {F11734, size=full} Test Plan: Display calendar for user with two different events in the same week. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2522
2012-05-21 20:59:12 +02:00
'uri' => '/res/b200376d/rsrc/css/aphront/calendar-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/calendar-view.css',
),
'aphront-contextbar-view-css' =>
array(
Ability to add reviewers while requesting review Summary: It makes perfect sense to add more reviewers while requesting review. Test Plan: Request review. Verify that Add Reviewers field shows and works. Add some reviewer. Verify that comment preview works. Submit. Verify that reviewers are saved and displayed. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1473
2012-01-24 03:34:46 +01:00
'uri' => '/res/9e0c2ed7/rsrc/css/aphront/context-bar.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/context-bar.css',
),
'aphront-crumbs-view-css' =>
array(
'uri' => '/res/9009e6bd/rsrc/css/aphront/crumbs-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/crumbs-view.css',
),
'aphront-dark-console-css' =>
array(
dark console - introduce "request log" section Summary: this section gets updated for each and every request. clicking a given entry updates the larger dark-console area to have the information from that request Test Plan: clicked around in maniphest and observed request log populating correctly. clicked a few entries in request log and saw it updated properly. clicked a different tab in the dark-console and it worked. clicked a different request log entry and it opened the dark console to the proper request on the proper tab. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1136 Differential Revision: https://secure.phabricator.com/D2574
2012-05-25 19:14:17 +02:00
'uri' => '/res/d9715ffb/rsrc/css/aphront/dark-console.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/dark-console.css',
),
'aphront-dialog-view-css' =>
array(
Hide oncopy <pre> in Firefox Test Plan: Comment `JX.DOM.remove(pre)` to better see the problem in old code. Apply this diff and verify that the pre is not shown. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2245
2012-04-16 23:50:01 +02:00
'uri' => '/res/eedc489d/rsrc/css/aphront/dialog-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/dialog-view.css',
),
'aphront-error-view-css' =>
array(
Make error views look less awful Summary: These elements look heavy and out of place right now. Test Plan: Looked at error views in uiexample page. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2144
2012-04-08 02:25:31 +02:00
'uri' => '/res/369e35eb/rsrc/css/aphront/error-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/error-view.css',
),
'aphront-form-view-css' =>
array(
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'uri' => '/res/b60e1526/rsrc/css/aphront/form-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/form-view.css',
),
'aphront-headsup-action-list-view-css' =>
array(
Add self-links for Differential and Maniphest Summary: See: https://groups.google.com/forum/?fromgroups#!topic/phabricator-dev/WolHZVVJB7k Render the `D3`, `T132`, etc., in the title as a link instead of in grey text. Also clean up some related CSS. Test Plan: Looked at a revision and a task. Reviewers: btrahan, asherwin Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2534
2012-05-22 19:52:16 +02:00
'uri' => '/res/1dce0ad7/rsrc/css/aphront/headsup-action-list-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/headsup-action-list-view.css',
),
Unify Differential/Maniphest/Diffusion styles and allow commits to be flagged explicitly Summary: - Differential, Maniphest and Diffusion use slightly different styles for the object detail panels. - Instead, use the same styles and CSS. - Add object actions to Diffusion, including "Flag". Test Plan: Looked at revisions, tasks and commit. Flagged and unflagged commits. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T1041 Differential Revision: https://secure.phabricator.com/D2062
2012-03-30 23:12:10 +02:00
'aphront-headsup-view-css' =>
array(
Add self-links for Differential and Maniphest Summary: See: https://groups.google.com/forum/?fromgroups#!topic/phabricator-dev/WolHZVVJB7k Render the `D3`, `T132`, etc., in the title as a link instead of in grey text. Also clean up some related CSS. Test Plan: Looked at a revision and a task. Reviewers: btrahan, asherwin Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2534
2012-05-22 19:52:16 +02:00
'uri' => '/res/cf759e39/rsrc/css/aphront/headsup.css',
Unify Differential/Maniphest/Diffusion styles and allow commits to be flagged explicitly Summary: - Differential, Maniphest and Diffusion use slightly different styles for the object detail panels. - Instead, use the same styles and CSS. - Add object actions to Diffusion, including "Flag". Test Plan: Looked at revisions, tasks and commit. Flagged and unflagged commits. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T1041 Differential Revision: https://secure.phabricator.com/D2062
2012-03-30 23:12:10 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/headsup.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'aphront-list-filter-view-css' =>
array(
'uri' => '/res/0f5ddaba/rsrc/css/aphront/list-filter-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/list-filter-view.css',
),
'aphront-pager-view-css' =>
array(
'uri' => '/res/43fb79f0/rsrc/css/aphront/pager-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/pager-view.css',
),
'aphront-panel-view-css' =>
array(
Refine "Tactical Command" layout and styling Summary: - Move the buttons in the jump nav to iOS-style "application" buttons in the header. These are sort of ugly right now, but I think serviceable enough. Some day we will hire a designer whose entire job is to pick up after me. - This gives us more room (allowing us to restore "Maniphest" and "Differential"). - This also disassociates the app buttons from the jump nav, which was a point of confusion (user expectation that the text input is related to the buttons). - Allow "Active Revisions" and "Assigned Tasks" to collapse completely. They didn't completely collapse before because the top-level "Active Tasks" / "Active Revisions" was sort of overloaded as quick nav to apps. Now we have app buttons. - Reduce overall size of jump nav. Test Plan: Looked at homepage in various states of need-for-attention. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1694
2012-02-27 22:14:32 +01:00
'uri' => '/res/9f08d754/rsrc/css/aphront/panel-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/panel-view.css',
),
'aphront-request-failure-view-css' =>
array(
'uri' => '/res/c9a43002/rsrc/css/aphront/request-failure-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/request-failure-view.css',
),
'aphront-side-nav-view-css' =>
array(
Replace home directory list with a dashboard Summary: Rough cut that still needs a lot of polish, but replace the directory list with more of a dashboard type thing: - Show "Unbreak Now", triage-in-your-projects, and other stuff that you're supposed to deal with, then feed. - Move tools a click a way behind nav -- this also lets us put more stuff there and subtools, etc., later. - Remove tabs. - Merge the category/item editing views. - I also added a light blue wash to the side nav, not sure if I like that or not. Test Plan: - Viewed all elements in empty and nonempty states. - Viewed applications, edited items/categories. Reviewers: btrahan, aran Reviewed By: btrahan CC: aran, epriestley, davidreuss Maniphest Tasks: T21, T631 Differential Revision: https://secure.phabricator.com/D1574
2012-02-08 01:04:48 +01:00
'uri' => '/res/ba0e18dd/rsrc/css/aphront/side-nav-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/side-nav-view.css',
),
'aphront-table-view-css' =>
array(
Display cursor hand on line number in revision but not in standalone view Summary: Partially broken by D2166. Test Plan: Hover line number in revision. Hover line number in standalone view. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2196
2012-04-11 00:00:09 +02:00
'uri' => '/res/3237398a/rsrc/css/aphront/table-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/table-view.css',
),
'aphront-tokenizer-control-css' =>
array(
'uri' => '/res/f530af47/rsrc/css/aphront/tokenizer.css',
'type' => 'css',
'requires' =>
array(
0 => 'aphront-typeahead-control-css',
),
'disk' => '/rsrc/css/aphront/tokenizer.css',
),
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'aphront-tooltip-css' =>
array(
Show user status on calendar Summary: This is a rough cut, but gets some of the basics at least. Here's what it looks like: {F11690} Some things that would be nice for future diffs: - Different colors for different event types (tasks? MEETINGS?!) - When events span across multiple days, keep them in the same row. - Switch which month you're looking at. - Show specific users instead of all. - etc etc etc Test Plan: See screenshot. Reviewers: btrahan, vrana Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2514
2012-05-21 19:24:23 +02:00
'uri' => '/res/b46170b3/rsrc/css/aphront/tooltip.css',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/tooltip.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'aphront-typeahead-control-css' =>
array(
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'uri' => '/res/311e8830/rsrc/css/aphront/typeahead.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/typeahead.css',
),
'differential-changeset-view-css' =>
array(
Unhighlight lines modified in rebase Summary: Diff of diffs display changes between new versions of file. This is bad after rebase because there can be many unrelated changes so it is hard to spot the real change. This diff unhighlights the lines that were added or removed in rebase. The changes are still visible (they can be sometimes relevant) but very subtle. Test Plan: # Add, change and delete line. Display diff. # Add and change some lines in parent. Rebase. Display diff. Display diff of diff. # Change and add some lines. Display diff. Display diff to first diff. Display diff to second diff. Reviewers: epriestley, jungejason Reviewed By: jungejason CC: jungejason, aran, Korvin Differential Revision: https://secure.phabricator.com/D2761
2012-06-15 09:53:26 +02:00
'uri' => '/res/c9706669/rsrc/css/application/differential/changeset-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/changeset-view.css',
),
'differential-core-view-css' =>
array(
Hide selection to provide a visual cue about clipboard JS magic in Differential Summary: Inspired by D2242. Test Plan: Select text in left pane. Select text in right pane. Select all. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2249
2012-04-17 03:53:38 +02:00
'uri' => '/res/2303c309/rsrc/css/application/differential/core.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/core.css',
),
'differential-inline-comment-editor' =>
array(
Don't provide Undo for empty text in Differential inline comment Test Plan: Edit inline comment. Clear its text. Hit Cancel. Try to find Undo link on the usual place with no success. Repeat for same text. Repeat for different text, this time with success. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1739
2012-03-01 07:21:40 +01:00
'uri' => '/res/c3be229c/rsrc/js/application/differential/DifferentialInlineCommentEditor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-dom',
Use an inline dialog element for inline comments in Differential Summary: The current approach of using a modal overlay dialog to create/edit inline comments is pretty silly. Use an inline textarea instead. This element isn't perfect and we have some mild modalness issues, but I think it's better than the silly thing we've got going on right now. We can keep poking it as people break it. Test Plan: - Created comments; submitted and undid them in empty and nonempty states. Used undo for nonempty states + cancel. - Edited comments; saved and canceled them. Used undo for changed state. - Replied to comments; yada yada as above. - Deleted comments. - Did various modal trickery where I clicked "Reply" on something else with a dialog already up, this very mildly glitches but I think it's not a big issue. Reviewers: vrana, btrahan, Makinde, nh Reviewed By: vrana CC: aran, epriestley Maniphest Tasks: T431 Differential Revision: https://secure.phabricator.com/D1716
2012-02-29 23:28:48 +01:00
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-install',
4 => 'javelin-request',
5 => 'javelin-workflow',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/differential/DifferentialInlineCommentEditor.js',
),
'differential-local-commits-view-css' =>
array(
'uri' => '/res/8cdacd82/rsrc/css/application/differential/local-commits-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/local-commits-view.css',
),
Further improve unit/lint rendering Summary: I think this improves things, let me know if you have feedback. Also addresses T840. Test Plan: See screenshots... Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, zeeg Maniphest Tasks: T840 Differential Revision: https://secure.phabricator.com/D2357
2012-05-01 19:15:56 +02:00
'differential-results-table-css' =>
array(
'uri' => '/res/470b474d/rsrc/css/application/differential/results-table.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/results-table.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'differential-revision-add-comment-css' =>
array(
'uri' => '/res/849748d3/rsrc/css/application/differential/add-comment.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/add-comment.css',
),
'differential-revision-comment-css' =>
array(
Make "Commandeer" yellow Summary: See T1178 Test Plan: {F10739} Reviewers: nh, btrahan, vrana, jungejason Reviewed By: nh CC: aran Maniphest Tasks: T1178 Differential Revision: https://secure.phabricator.com/D2346
2012-04-30 22:07:06 +02:00
'uri' => '/res/a4bad297/rsrc/css/application/differential/revision-comment.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-comment.css',
),
'differential-revision-comment-list-css' =>
array(
'uri' => '/res/3b31faa3/rsrc/css/application/differential/revision-comment-list.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-comment-list.css',
),
'differential-revision-history-css' =>
array(
'uri' => '/res/0d7d515d/rsrc/css/application/differential/revision-history.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-history.css',
),
'differential-table-of-contents-css' =>
array(
Add button to reveal all files in Differential Summary: D2216 tried to ask the user, this one is explicit. Test Plan: Click the button Reviewers: epriestley, lucian Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2600
2012-05-30 03:20:11 +02:00
'uri' => '/res/0ac99a19/rsrc/css/application/differential/table-of-contents.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/table-of-contents.css',
),
'diffusion-commit-view-css' =>
array(
Delete unused CSS Summary: Unused since D2062. Test Plan: View commit. View task. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2108
2012-04-05 19:47:20 +02:00
'uri' => '/res/b445944e/rsrc/css/application/diffusion/commit-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/commit-view.css',
),
Improve Diffusion behavior for externals Summary: - Feature request from Airtime that I missed in the feedback notes, came up yesterday. - Identify git submodules as "FILE_SUBMODULE", not "FILE_NORMAL". - Link git submodules to an external resolver endpoint, which tries to find commits in tracked repositories. - Identify git symlinks as "FILE_SYMLINK", not "FILE_NORMAL". - Add folder, file, symlink and externals icons. Test Plan: - externals/javelin is now identified as a submoudule and links to Javelin, not identified as a file and links to error. - bin/phd is now identified as a symlink. - Interfaces have pretty icons. Reviewers: btrahan, cpiro, ddfisher, keebuhm, allenjohnashton Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1975
2012-03-21 22:01:20 +01:00
'diffusion-icons-css' =>
array(
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'uri' => '/res/b93e32c9/rsrc/css/application/diffusion/diffusion-icons.css',
Improve Diffusion behavior for externals Summary: - Feature request from Airtime that I missed in the feedback notes, came up yesterday. - Identify git submodules as "FILE_SUBMODULE", not "FILE_NORMAL". - Link git submodules to an external resolver endpoint, which tries to find commits in tracked repositories. - Identify git symlinks as "FILE_SYMLINK", not "FILE_NORMAL". - Add folder, file, symlink and externals icons. Test Plan: - externals/javelin is now identified as a submoudule and links to Javelin, not identified as a file and links to error. - bin/phd is now identified as a symlink. - Interfaces have pretty icons. Reviewers: btrahan, cpiro, ddfisher, keebuhm, allenjohnashton Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1975
2012-03-21 22:01:20 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/diffusion-icons.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'diffusion-source-css' =>
array(
Use black bullet instead of gray background for disabled users Summary: Just because I like it more. Test Plan: View diff with comment from disabled user. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2525
2012-05-21 23:54:39 +02:00
'uri' => '/res/501fcd3a/rsrc/css/application/diffusion/diffusion-source.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/diffusion-source.css',
),
'files-css' =>
array(
'uri' => '/res/a265a77d/rsrc/css/application/files/files.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/files/files.css',
),
'herald-css' =>
array(
General Herald refactoring pass Summary: **Who can delete global rules?**: I discussed this with @jungejason. The current behavior is that the rule author or any administrator can delete a global rule, but this isn't consistent with who can edit a rule (anyone) and doesn't really make much sense (it's an artifact of the global/personal split). I proposed that anyone can delete a rule but we don't actually delete them, and log the deletion. However, when it came time to actually write the code for this I backed off a bit and continued actually deleting the rules -- I think this does a reasonable job of balancing accountability with complexity. So the new impelmentation is: - Personal rules can be deleted only by their owners. - Global rules can be deleted by any user. - All deletes are logged. - Logs are more detailed. - All logged actions can be viewed in aggregate. **Minor Cleanup** - Merged `HomeController` and `AllController`. - Moved most queries to Query classes. - Use AphrontFormSelectControl::renderSelectTag() where appropriate (this is a fairly recent addition). - Use an AphrontErrorView to render the dry run notice (this didn't exist when I ported). - Reenable some transaction code (this works again now). - Removed the ability for admins to change rule authors (this was a little buggy, messy, and doesn't make tons of sense after the personal/global rule split). - Rules which depend on other rules now display the right options (all global rules, all your personal rules for personal rules). - Fix a bug in AphrontTableView where the "no data" cell would be rendered too wide if some columns are not visible. - Allow selectFilter() in AphrontNavFilterView to be called without a 'default' argument. Test Plan: - Browsed, created, edited, deleted personal and gules. - Verified generated logs. - Did some dry runs. - Verified transcript list and transcript details. - Created/edited all/any rules; created/edited once/every time rules. - Filtered admin views by users. Reviewers: jungejason, btrahan Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D2040
2012-03-30 19:49:55 +02:00
'uri' => '/res/5051f3ab/rsrc/css/application/herald/herald.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/herald/herald.css',
),
'herald-rule-editor' =>
array(
Allow users to add flags via Herald rules Summary: Add "Mark with flag" rules to Herald. Test Plan: Created / edited a "Mark with flag" rule. Parsed revisions / commits, got flags added. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley, vrana Maniphest Tasks: T1041 Differential Revision: https://secure.phabricator.com/D2060
2012-03-30 22:51:54 +02:00
'uri' => '/res/3a2979de/rsrc/js/application/herald/HeraldRuleEditor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'multirow-row-manager',
1 => 'javelin-install',
2 => 'javelin-typeahead',
3 => 'javelin-util',
4 => 'javelin-dom',
5 => 'javelin-tokenizer',
6 => 'javelin-typeahead-preloaded-source',
7 => 'javelin-stratcom',
8 => 'javelin-json',
9 => 'phabricator-prefab',
),
'disk' => '/rsrc/js/application/herald/HeraldRuleEditor.js',
),
'herald-test-css' =>
array(
'uri' => '/res/c0cd6bdb/rsrc/css/application/herald/herald-test.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/herald/herald-test.css',
),
Separate the inline comment summary element into a separate view Summary: - Affects the "Inline Comments" summary table which appears in comments that have attached inlines in the discussion threads in Differential. - Prepares for inclusion in Diffusion. - No application changes (minor CSS), just factors code better. - Simplify/separate CSS. Test Plan: Looked at on-diff and off-diff comment summaries in Differential, display looked correct. Reviewers: davidreuss, nh, btrahan Reviewed By: davidreuss CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1928
2012-03-20 03:45:16 +01:00
'inline-comment-summary-css' =>
array(
'uri' => '/res/338704f7/rsrc/css/application/diff/inline-comment-summary.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diff/inline-comment-summary.css',
),
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
'javelin-aphlict' =>
array(
Improve Aphlict server Summary: - Move to port 22280 by default. - Warn when running as non-root. - Allow subscription and publish/admin ports to be configured. - Allow server to drop root after binding to 843. - Allow log path to be configured. - Add /status/ admin URI which shows server status. - Return HTTP 400 Bad Request for other requests, instead of hanging. - Minor formatting cleanup. Test Plan: Ran without root: $ node aphlict_server.js ...got a good error message. Ran with --user: $ sudo node aphlict_server.js --user=epriestley ...verified server dropped permissions. Ran with --port / --admin. Hit /status/ with GET, got status. Hit other URLs with GET, got 400. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran Differential Revision: https://secure.phabricator.com/D2737
2012-06-14 15:12:54 +02:00
'uri' => '/res/c0b9e53f/rsrc/js/application/aphlict/Aphlict.js',
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
'disk' => '/rsrc/js/application/aphlict/Aphlict.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior' =>
array(
Indicate buttons disabled in JX.Workflow Summary: We are marking disabled buttons with 'disabled' class in `behavior-form`. But we ignore `JX.Workflow` there because it has its own handling. But this handling doesn't set class so the button is disabled but it is not indicated to user. It causes troubles in Clowncopterize where users report that browser freezes before doing anything after clicking it. It probably happens also on other places. This diff solves it by using CSS3 selector on attribute (contrary to explicitly setting class in JX.Workflow). Test Plan: Add `sleep(3)` to `DifferentialCommentSaveController`. Clowncopterize empty comment. Reviewers: epriestley, tuomaspelkonen Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2264
2012-04-18 07:04:54 +02:00
'uri' => '/res/ef4eda09/rsrc/js/javelin/lib/behavior.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-magical-init',
),
'disk' => '/rsrc/js/javelin/lib/behavior.js',
),
Adds the UI dropdown panel Summary: Add a dropdown to display notificaitons. Right now there is nothing real time about it, but we do update the panel when the user clicks. This panel is only displayed if the install has notifications enabled and you have them enabled in your preferences (not using them by default). Test Plan: Turn off notifications for user1, left them on for user2. Did things from user1 and from user2 on task both were cc'd on. user2 recieved all notifications, user1 recieved nothing. Made new user, made sure everything was switched off by default. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: keebuhm, ddfisher, aran, Korvin Differential Revision: https://secure.phabricator.com/D2703
2012-06-11 18:37:06 +02:00
'javelin-behavior-aphlict-dropdown' =>
array(
Apply AMAZING DESIGN SKILLS to notification menu Summary: I am a fancy designer! {F12665} {F12666} Test Plan: Opened/closed menu. Viewed with-notification-count and without-notification count states. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, chad, joe Maniphest Tasks: T974 Differential Revision: https://secure.phabricator.com/D2735
2012-06-14 15:13:53 +02:00
'uri' => '/res/425c08fd/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js',
Adds the UI dropdown panel Summary: Add a dropdown to display notificaitons. Right now there is nothing real time about it, but we do update the panel when the user clicks. This panel is only displayed if the install has notifications enabled and you have them enabled in your preferences (not using them by default). Test Plan: Turn off notifications for user1, left them on for user2. Did things from user1 and from user2 on task both were cc'd on. user2 recieved all notifications, user1 recieved nothing. Made new user, made sure everything was switched off by default. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: keebuhm, ddfisher, aran, Korvin Differential Revision: https://secure.phabricator.com/D2703
2012-06-11 18:37:06 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Apply AMAZING DESIGN SKILLS to notification menu Summary: I am a fancy designer! {F12665} {F12666} Test Plan: Opened/closed menu. Viewed with-notification-count and without-notification count states. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, chad, joe Maniphest Tasks: T974 Differential Revision: https://secure.phabricator.com/D2735
2012-06-14 15:13:53 +02:00
1 => 'javelin-request',
2 => 'javelin-stratcom',
3 => 'javelin-vector',
4 => 'javelin-dom',
Adds the UI dropdown panel Summary: Add a dropdown to display notificaitons. Right now there is nothing real time about it, but we do update the panel when the user clicks. This panel is only displayed if the install has notifications enabled and you have them enabled in your preferences (not using them by default). Test Plan: Turn off notifications for user1, left them on for user2. Did things from user1 and from user2 on task both were cc'd on. user2 recieved all notifications, user1 recieved nothing. Made new user, made sure everything was switched off by default. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: keebuhm, ddfisher, aran, Korvin Differential Revision: https://secure.phabricator.com/D2703
2012-06-11 18:37:06 +02:00
),
'disk' => '/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js',
),
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
'javelin-behavior-aphlict-listen' =>
array(
Improve debug support for notifications Summary: Add a `notification.debug` setting that shows debug info in the browser. Also improve some logging/error handling stuff and fix a bug with host names. Test Plan: {F13098} Reviewers: jungejason, btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2810
2012-06-20 22:20:47 +02:00
'uri' => '/res/c716b386/rsrc/js/application/aphlict/behavior-aphlict-listen.js',
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-aphlict',
Show only one "reload" popup, use 'alert' style, click to reload Summary: Use the features from D2758. Test Plan: Updated T1 with two browser windows pointing at it, verified reload appeared, only one reload, and it appeared with 'alert' style. Reviewers: jungejason, vrana Reviewed By: jungejason CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2781
2012-06-18 23:07:45 +02:00
2 => 'javelin-stratcom',
3 => 'javelin-request',
4 => 'javelin-uri',
5 => 'javelin-dom',
Improve debug support for notifications Summary: Add a `notification.debug` setting that shows debug info in the browser. Also improve some logging/error handling stuff and fix a bug with host names. Test Plan: {F13098} Reviewers: jungejason, btrahan, vrana Reviewed By: btrahan CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2810
2012-06-20 22:20:47 +02:00
6 => 'javelin-json',
7 => 'phabricator-notification',
Make Aphlict client somewhat more approachable Summary: Provide a reasonable JS API for the Aphlict client. Provide an example behavior to invoke it. Test Plan: Ran "aphlict_server.js" with: $ sudo node aphlict_server.js Loaded /aphlict/. Opened console. Got "hello" from the server every second. Got reasonable errors with the server not present ("Security exception", but this is because it can't connect to port 843 to access the policy server). Reviewers: ddfisher, keebuhm, allenjohnashton, btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D1800
2012-03-07 05:14:03 +01:00
),
'disk' => '/rsrc/js/application/aphlict/behavior-aphlict-listen.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-aphront-basic-tokenizer' =>
array(
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'uri' => '/res/cf049052/rsrc/js/application/core/behavior-tokenizer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
1 => 'phabricator-prefab',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-tokenizer.js',
),
Add "buoyant" headers to Differential Summary: As you scroll through a diff, add a fixed-position header to the top of the document to provide context. This is particularly useful with keyboard navigation. The technical implementation is that we seed the document with invisible markers. When the user scrolls past one, we show a header with that text until they scroll past another. Test Plan: Scrolled through a revision, was presented with context. https://secure.phabricator.com/file/data/5xhh2jmoon6ukr5qjkh3/PHID-FILE-463ituscyhyw7utnox7m/Screen_Shot_2012-02-22_at_2.48.19_PM.png Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T696 Differential Revision: https://secure.phabricator.com/D1673
2012-02-23 21:26:14 +01:00
'javelin-behavior-aphront-drag-and-drop' =>
array(
'uri' => '/res/ac21045a/rsrc/js/application/core/behavior-drag-and-drop.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-drag-and-drop-file-upload',
),
'disk' => '/rsrc/js/application/core/behavior-drag-and-drop.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-aphront-drag-and-drop-textarea' =>
array(
Improve exception behavior for storage engine failures Summary: See T1021. Raise configuration or implementation exceptions immediately. When all engines fail, raise an aggregate exception with details. Test Plan: Forced all engines to fail, received an aggregate exception. Forced an engine to fail with a config exception, recevied it immediately. Reviewers: btrahan, vrana, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T1021 Differential Revision: https://secure.phabricator.com/D2157
2012-04-09 00:07:34 +02:00
'uri' => '/res/76a52ae3/rsrc/js/application/core/behavior-drag-and-drop-textarea.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'phabricator-drag-and-drop-file-upload',
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
3 => 'phabricator-paste-file-upload',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-drag-and-drop-textarea.js',
),
'javelin-behavior-aphront-form-disable-on-submit' =>
array(
Allow/fix sending forms to new tab or window Test Plan: Ctrl+click on Show Diff in Chrome - button is not grayed-out, new tab is opened. Click on it - button is grayed out. Repeat in Firefox. Reviewers: epriestley, tuomaspelkonen Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1137 Differential Revision: https://secure.phabricator.com/D2278
2012-04-19 00:13:29 +02:00
'uri' => '/res/ca54e8b9/rsrc/js/application/core/behavior-form.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-form.js',
),
Show "show more..." link in "Local Commits" view in Differential Summary: Javascript! Depends on D2437 to do anything useful. Test Plan: Clicked "show more", saw more. Reviewers: csilvers, btrahan Reviewed By: csilvers CC: aran Maniphest Tasks: T1189 Differential Revision: https://secure.phabricator.com/D2438
2012-05-10 00:56:37 +02:00
'javelin-behavior-aphront-more' =>
array(
'uri' => '/res/9ad83c3c/rsrc/js/application/core/behavior-more.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-more.js',
),
Add preview and drafts to audits Summary: Add comment previews and saved drafts to audits, like Maniphest / Differential. Test Plan: Typed stuff into the box. Got a preview. Reloaded page. Stuff was still there. Submitted comment. Stuff is gone. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1699
2012-02-27 22:00:23 +01:00
'javelin-behavior-audit-preview' =>
array(
'uri' => '/res/3048b073/rsrc/js/application/diffusion/behavior-audit-preview.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/diffusion/behavior-audit-preview.js',
),
Add "buoyant" headers to Differential Summary: As you scroll through a diff, add a fixed-position header to the top of the document to provide context. This is particularly useful with keyboard navigation. The technical implementation is that we seed the document with invisible markers. When the user scrolls past one, we show a header with that text until they scroll past another. Test Plan: Scrolled through a revision, was presented with context. https://secure.phabricator.com/file/data/5xhh2jmoon6ukr5qjkh3/PHID-FILE-463ituscyhyw7utnox7m/Screen_Shot_2012-02-22_at_2.48.19_PM.png Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T696 Differential Revision: https://secure.phabricator.com/D1673
2012-02-23 21:26:14 +01:00
'javelin-behavior-buoyant' =>
array(
'uri' => '/res/e7581db1/rsrc/js/application/core/behavior-buoyant.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-vector',
3 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-buoyant.js',
),
Iterate on Maniphest reports Summary: - These are still slow, awkward and hideous -- but slightly better than before. - Allow "open" reports to be sorted. - Add a "burn" chart/table for assessing project volatility. - Add navigation. Test Plan: Looked at reports. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T923 Differential Revision: https://secure.phabricator.com/D1737
2012-03-01 23:19:11 +01:00
'javelin-behavior-burn-chart' =>
array(
Increase the click target area for the object selector Summary: Make clicking the link also select the object (this operation is very common). Add an arrow to the left to view the object (this operation is very rare). Increase link target area to the entire cell. Also simplify some handlers. Test Plan: Clicked things with wild abandon. Behavior seemed unchanged. Reviewers: cpiro, btrahan Reviewed By: cpiro CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1962
2012-03-20 03:20:49 +01:00
'uri' => '/res/0bc23e4d/rsrc/js/application/maniphest/behavior-burn-chart.js',
Iterate on Maniphest reports Summary: - These are still slow, awkward and hideous -- but slightly better than before. - Allow "open" reports to be sorted. - Add a "burn" chart/table for assessing project volatility. - Add navigation. Test Plan: Looked at reports. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T923 Differential Revision: https://secure.phabricator.com/D1737
2012-03-01 23:19:11 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-vector',
),
'disk' => '/rsrc/js/application/maniphest/behavior-burn-chart.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-countdown-timer' =>
array(
'uri' => '/res/5ee9cb13/rsrc/js/application/countdown/timer.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
),
'disk' => '/rsrc/js/application/countdown/timer.js',
),
'javelin-behavior-dark-console' =>
array(
Fix doc links
2012-05-30 00:36:02 +02:00
'uri' => '/res/3269c0bb/rsrc/js/application/core/behavior-dark-console.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-request',
5 => 'phabricator-keyboard-shortcut',
dark console - introduce "request log" section Summary: this section gets updated for each and every request. clicking a given entry updates the larger dark-console area to have the information from that request Test Plan: clicked around in maniphest and observed request log populating correctly. clicked a few entries in request log and saw it updated properly. clicked a different tab in the dark-console and it worked. clicked a different request log entry and it opened the dark console to the proper request on the proper tab. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1136 Differential Revision: https://secure.phabricator.com/D2574
2012-05-25 19:14:17 +02:00
6 => 'javelin-behavior-dark-console-ajax',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-dark-console.js',
),
dark console - introduce "request log" section Summary: this section gets updated for each and every request. clicking a given entry updates the larger dark-console area to have the information from that request Test Plan: clicked around in maniphest and observed request log populating correctly. clicked a few entries in request log and saw it updated properly. clicked a different tab in the dark-console and it worked. clicked a different request log entry and it opened the dark console to the proper request on the proper tab. Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Koolvin Maniphest Tasks: T1136 Differential Revision: https://secure.phabricator.com/D2574
2012-05-25 19:14:17 +02:00
'javelin-behavior-dark-console-ajax' =>
array(
'uri' => '/res/ac3ab63a/rsrc/js/application/core/behavior-dark-console-ajax.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-dark-console-ajax.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-differential-accept-with-errors' =>
array(
Create option for differential custom fields to display warning on accept Summary: This adds support to differential fields to display warnings before a revision gets accepted. Since lint and unit are differential fields, the code for their warnings was moved into their respective field specification classes, so there is only one code path for warnings (lint, unit, or custom). Test Plan: Select 'Accept' on a revision with lint/unit warnings and see messages appear like they used to. Change it back to 'Comment' and they go away. Repeat with a revision without lint/unit warnings and see no warnings appear. Checked darkconsole to see no errors due to this. Reviewers: jungejason, epriestley, vrana Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2363
2012-03-27 07:16:46 +02:00
'uri' => '/res/ba5144c5/rsrc/js/application/differential/behavior-accept-with-errors.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-accept-with-errors.js',
),
'javelin-behavior-differential-add-reviewers-and-ccs' =>
array(
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'uri' => '/res/27be3f81/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
2 => 'phabricator-prefab',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js',
),
'javelin-behavior-differential-comment-jump' =>
array(
Update Celerity map
2012-06-14 07:47:46 +02:00
'uri' => '/res/b580229b/rsrc/js/application/differential/behavior-comment-jump.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-util',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-comment-jump.js',
),
'javelin-behavior-differential-diff-radios' =>
array(
'uri' => '/res/004cb66f/rsrc/js/application/differential/behavior-diff-radios.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-diff-radios.js',
),
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'javelin-behavior-differential-dropdown-menus' =>
array(
Fix dropdown for file whose diff is not displayable Summary: The current behavior is that, when the dropdown menu is clicked for a binary file, it navigates to the current revision page directly without showing the dropdown meu. The fix is to do nothing when there is no file displayed. Test Plan: - checked a diff with binary file - checked a diff with normal files Reviewers: vrana, epriestley Reviewed By: epriestley CC: epriestley, aran Differential Revision: https://secure.phabricator.com/D2801
2012-06-20 00:56:42 +02:00
'uri' => '/res/6ae5898a/rsrc/js/application/differential/behavior-dropdown-menus.js',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Add a link from Differential to Diffusion Summary: Provide an easy way to jump to Diffusion from Differential if we have the data we need to connect them. Test Plan: Tested menu in linked and unlinked diffs. Used menu item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley, btrahan Maniphest Tasks: T309 Differential Revision: https://secure.phabricator.com/D1326
2012-01-05 23:41:11 +01:00
2 => 'javelin-util',
3 => 'javelin-stratcom',
4 => 'phabricator-dropdown-menu',
5 => 'phabricator-menu-item',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
),
'disk' => '/rsrc/js/application/differential/behavior-dropdown-menus.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-differential-edit-inline-comments' =>
array(
Use subtler highlighting for copied and moved code Summary: The highlighting is distracting according to Nick Shrock and others. Real designer, Lee Byron, helped me with this. It also gives us unagressive target for jumping to the source line in future. Another feature I will probably implement is highlighting also the source of copies/moves. I will use the right side of the left column for it. Test Plan: Hover copied notifier. Hover coverage notifier. I've also checked that this doesn't break our super-flaky old/new code JavaScript detector. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin, leebyron, schrockn Differential Revision: https://secure.phabricator.com/D2443
2012-05-05 02:41:06 +02:00
'uri' => '/res/a8c804d4/rsrc/js/application/differential/behavior-edit-inline-comments.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-util',
4 => 'javelin-vector',
5 => 'differential-inline-comment-editor',
),
'disk' => '/rsrc/js/application/differential/behavior-edit-inline-comments.js',
),
'javelin-behavior-differential-feedback-preview' =>
array(
Allow users to add flags via Herald rules Summary: Add "Mark with flag" rules to Herald. Test Plan: Created / edited a "Mark with flag" rule. Parsed revisions / commits, got flags added. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley, vrana Maniphest Tasks: T1041 Differential Revision: https://secure.phabricator.com/D2060
2012-03-30 22:51:54 +02:00
'uri' => '/res/f27f3f49/rsrc/js/application/differential/behavior-comment-preview.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-request',
4 => 'javelin-util',
5 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/differential/behavior-comment-preview.js',
),
'javelin-behavior-differential-keyboard-navigation' =>
array(
Update Celerity map
2012-06-14 07:47:46 +02:00
'uri' => '/res/be43b320/rsrc/js/application/differential/behavior-keyboard-nav.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Add more keyboard navigation options for inline comments Summary: - Use n/p to jump between comments. - Use r to reply to the selected comment. - Use e to edit the selected comment. Test Plan: Verified n, p, r, e, j, k, J, K, "click edit" and "click reply" behavior in as many weird cases as I could come up with. Reviewers: btrahan, jungejason, nh, cpiro, jl Reviewed By: btrahan CC: aran, btrahan, epriestley Maniphest Tasks: T583 Differential Revision: https://secure.phabricator.com/D1308
2012-01-04 17:21:22 +01:00
2 => 'javelin-stratcom',
3 => 'phabricator-keyboard-shortcut',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/differential/behavior-keyboard-nav.js',
),
'javelin-behavior-differential-populate' =>
array(
Use subtler highlighting for copied and moved code Summary: The highlighting is distracting according to Nick Shrock and others. Real designer, Lee Byron, helped me with this. It also gives us unagressive target for jumping to the source line in future. Another feature I will probably implement is highlighting also the source of copies/moves. I will use the right side of the left column for it. Test Plan: Hover copied notifier. Hover coverage notifier. I've also checked that this doesn't break our super-flaky old/new code JavaScript detector. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin, leebyron, schrockn Differential Revision: https://secure.phabricator.com/D2443
2012-05-05 02:41:06 +02:00
'uri' => '/res/a955bf2c/rsrc/js/application/differential/behavior-populate.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-workflow',
2 => 'javelin-util',
3 => 'javelin-dom',
Show a tooltip about code coverage Summary: - Show a tip in the margin about what coverage colors mean. - Highlight the line when mousing over coverage. - Randomly change the colors to different colors. - Fix a bug with "show more" that I introduced with the other coverage diff (oops!) Test Plan: Moused over coverage things. Reviewers: tuomaspelkonen, btrahan Reviewed By: tuomaspelkonen CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1874
2012-03-13 04:04:12 +01:00
4 => 'javelin-stratcom',
5 => 'phabricator-tooltip',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/differential/behavior-populate.js',
),
'javelin-behavior-differential-show-all-comments' =>
array(
Go to correct position after revealing comments Test Plan: Go to revision with lots of comments in Firefox. Click on one of the last three comments permalink. Repeat in Chrome. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1702
2012-02-26 12:54:17 +01:00
'uri' => '/res/eaa12efc/rsrc/js/application/differential/behavior-show-all-comments.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-show-all-comments.js',
),
Hide lint and unit error details Summary: Before: {F10754} After: {F10753} Test Plan: View revision with lint warnings and unit errors. Click on Details. Click on Details. Click on Details. Click on Details. Reviewers: asukhachev, epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2351
2012-05-01 01:08:01 +02:00
'javelin-behavior-differential-show-field-details' =>
array(
Further improve unit/lint rendering Summary: I think this improves things, let me know if you have feedback. Also addresses T840. Test Plan: See screenshots... Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, zeeg Maniphest Tasks: T840 Differential Revision: https://secure.phabricator.com/D2357
2012-05-01 19:15:56 +02:00
'uri' => '/res/8d57f459/rsrc/js/application/differential/behavior-show-field-details.js',
Hide lint and unit error details Summary: Before: {F10754} After: {F10753} Test Plan: View revision with lint warnings and unit errors. Click on Details. Click on Details. Click on Details. Click on Details. Reviewers: asukhachev, epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2351
2012-05-01 01:08:01 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/differential/behavior-show-field-details.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-differential-show-more' =>
array(
Show a tooltip about code coverage Summary: - Show a tip in the margin about what coverage colors mean. - Highlight the line when mousing over coverage. - Randomly change the colors to different colors. - Fix a bug with "show more" that I introduced with the other coverage diff (oops!) Test Plan: Moused over coverage things. Reviewers: tuomaspelkonen, btrahan Reviewed By: tuomaspelkonen CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1874
2012-03-13 04:04:12 +01:00
'uri' => '/res/e92c5272/rsrc/js/application/differential/behavior-show-more.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-workflow',
3 => 'javelin-util',
4 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/differential/behavior-show-more.js',
),
Update Celerity map
2012-06-14 07:47:46 +02:00
'javelin-behavior-differential-toggle-files' =>
array(
'uri' => '/res/21bf6d48/rsrc/js/application/differential/behavior-toggle-files.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
3 => 'phabricator-keyboard-shortcut',
),
'disk' => '/rsrc/js/application/differential/behavior-toggle-files.js',
),
Hide selection to provide a visual cue about clipboard JS magic in Differential Summary: Inspired by D2242. Test Plan: Select text in left pane. Select text in right pane. Select all. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2249
2012-04-17 03:53:38 +02:00
'javelin-behavior-differential-user-select' =>
array(
'uri' => '/res/f0e3b555/rsrc/js/application/differential/behavior-user-select.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/differential/behavior-user-select.js',
),
Render pretty graphical traces for commit branches, etc Summary: I AM A WIZARD Test Plan: BEHOLD Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T961 Differential Revision: https://secure.phabricator.com/D2007
2012-03-24 01:11:15 +01:00
'javelin-behavior-diffusion-commit-graph' =>
array(
'uri' => '/res/cfe336e8/rsrc/js/application/diffusion/behavior-commit-graph.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/diffusion/behavior-commit-graph.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-diffusion-jump-to' =>
array(
'uri' => '/res/7c42e1ba/rsrc/js/application/diffusion/behavior-jump-to.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-util',
2 => 'javelin-vector',
3 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/diffusion/behavior-jump-to.js',
),
'javelin-behavior-diffusion-pull-lastmodified' =>
array(
'uri' => '/res/29fe2790/rsrc/js/application/diffusion/behavior-pull-lastmodified.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'javelin-request',
),
'disk' => '/rsrc/js/application/diffusion/behavior-pull-lastmodified.js',
),
'javelin-behavior-error-log' =>
array(
Allow opening editor from DarkConsole error log Test Plan: Click on "passing a null index to idx()" in DarkConsole. Click on entry in stack trace. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2275
2012-04-18 21:50:06 +02:00
'uri' => '/res/f46289e9/rsrc/js/application/core/behavior-error-log.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-error-log.js',
),
Add a datepicker control Summary: I looooove JS! It makes me giddy with glee! Test Plan: Picked dates. See screenshots. Reviewers: btrahan Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2086
2012-04-04 21:14:10 +02:00
'javelin-behavior-fancy-datepicker' =>
array(
'uri' => '/res/b2d89e4c/rsrc/js/application/core/behavior-fancy-datepicker.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-util',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-fancy-datepicker.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-files-drag-and-drop' =>
array(
Always redirect to My Files after upload Summary: I've found it quite confusing that uploading a single image displays the image itself but uploading more images displays My Files. I've also got a user report about it because most users don't know that they can drop the image directly to the comment textarea and they are interested mainly in the ID of the uploaded file. Test Plan: Upload a file. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1891
2012-03-14 07:06:34 +01:00
'uri' => '/res/3a7a2a8a/rsrc/js/application/core/behavior-files-drag-and-drop.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-uri',
3 => 'phabricator-drag-and-drop-file-upload',
),
'disk' => '/rsrc/js/application/core/behavior-files-drag-and-drop.js',
),
'javelin-behavior-herald-rule-editor' =>
array(
'uri' => '/res/77a0c945/rsrc/js/application/herald/herald-rule-editor.js',
'type' => 'js',
'requires' =>
array(
0 => 'herald-rule-editor',
1 => 'javelin-behavior',
),
'disk' => '/rsrc/js/application/herald/herald-rule-editor.js',
),
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
'javelin-behavior-maniphest-batch-editor' =>
array(
Add "Change Priority", "Open / Close", "Comment" and "Assign" actions to Maniphest batch editor Summary: I think these are all the actions which make any sense. Test Plan: - Performed and verified each action through the batch editor. - Performed a large batch edit which applied each action type multiple times and verified the aggregate behavior was correct. Reviewers: btrahan, cpiro Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1971
2012-03-21 22:01:04 +01:00
'uri' => '/res/d22661be/rsrc/js/application/maniphest/behavior-batch-editor.js',
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-prefab',
4 => 'multirow-row-manager',
Add "Change Priority", "Open / Close", "Comment" and "Assign" actions to Maniphest batch editor Summary: I think these are all the actions which make any sense. Test Plan: - Performed and verified each action through the batch editor. - Performed a large batch edit which applied each action type multiple times and verified the aggregate behavior was correct. Reviewers: btrahan, cpiro Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1971
2012-03-21 22:01:04 +01:00
5 => 'javelin-json',
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
),
'disk' => '/rsrc/js/application/maniphest/behavior-batch-editor.js',
),
'javelin-behavior-maniphest-batch-selector' =>
array(
'uri' => '/res/398cf8d7/rsrc/js/application/maniphest/behavior-batch-selector.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/maniphest/behavior-batch-selector.js',
),
Add a description preview to maniphest create / edit panel Summary: also fixes a small bug where the page title was always "Create Task". switch it to the header name which is much more descriptive / correct IMO. Test Plan: created a new task and watched the description preview update. edited an old task and saw the description preview populate with the correct existing data. edited an old task and edited the description and saw the description preview update Reviewers: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1489
2012-01-25 20:23:00 +01:00
'javelin-behavior-maniphest-description-preview' =>
array(
'uri' => '/res/8acd6f07/rsrc/js/application/maniphest/behavior-task-preview.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/maniphest/behavior-task-preview.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-maniphest-project-create' =>
array(
'uri' => '/res/85a0eaf9/rsrc/js/application/maniphest/behavior-project-create.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
3 => 'javelin-workflow',
),
'disk' => '/rsrc/js/application/maniphest/behavior-project-create.js',
),
Allow tasks to be subprioritized by drag-and-drop Summary: Like the title says, similar to Facebook Tasks. Not sure how I really feel about this, but I guess it's kind of OK? I never used this feature in Facebook Tasks but I think some people like it. The drag-and-drop to repri across priorities feels okayish. Because subpriority is a double and we just split the difference when reprioritizing, you lose ~a bit of precision every time you repri two tasks against each other and so you can break it by swapping the priorities of two tasks ~50 times. This case is pretty silly and pathological. We can add some code to deal with this at some point if necessary. I think this also fixes the whacky task layout widths once and for all. (There are a couple of minor UI glitches like headers not vanishing and header counts not updating that I'm not fixing because I am lazy.) Test Plan: Dragged and dropped tasks around. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley, mgummelt Maniphest Tasks: T859 Differential Revision: https://secure.phabricator.com/D1731
2012-04-02 21:12:04 +02:00
'javelin-behavior-maniphest-subpriority-editor' =>
array(
Minor, address feedback from D1731. Auditors: btrahan
2012-04-02 21:14:26 +02:00
'uri' => '/res/5e02f19a/rsrc/js/application/maniphest/behavior-subpriorityeditor.js',
Allow tasks to be subprioritized by drag-and-drop Summary: Like the title says, similar to Facebook Tasks. Not sure how I really feel about this, but I guess it's kind of OK? I never used this feature in Facebook Tasks but I think some people like it. The drag-and-drop to repri across priorities feels okayish. Because subpriority is a double and we just split the difference when reprioritizing, you lose ~a bit of precision every time you repri two tasks against each other and so you can break it by swapping the priorities of two tasks ~50 times. This case is pretty silly and pathological. We can add some code to deal with this at some point if necessary. I think this also fixes the whacky task layout widths once and for all. (There are a couple of minor UI glitches like headers not vanishing and header counts not updating that I'm not fixing because I am lazy.) Test Plan: Dragged and dropped tasks around. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley, mgummelt Maniphest Tasks: T859 Differential Revision: https://secure.phabricator.com/D1731
2012-04-02 21:12:04 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-magical-init',
2 => 'javelin-dom',
3 => 'javelin-vector',
4 => 'javelin-stratcom',
5 => 'javelin-workflow',
),
'disk' => '/rsrc/js/application/maniphest/behavior-subpriorityeditor.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-maniphest-transaction-controls' =>
array(
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'uri' => '/res/62465554/rsrc/js/application/maniphest/behavior-transaction-controls.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
2 => 'phabricator-prefab',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/maniphest/behavior-transaction-controls.js',
),
'javelin-behavior-maniphest-transaction-expand' =>
array(
'uri' => '/res/966410de/rsrc/js/application/maniphest/behavior-transaction-expand.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-workflow',
3 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/application/maniphest/behavior-transaction-expand.js',
),
'javelin-behavior-maniphest-transaction-preview' =>
array(
Make Maniphest Transaction preview tokenizer aware Summary: ...pretty sure the JS is too hack-tastic but it works...! :D also fixed a small error from assert_instances_of change where a null value is all errors and what have you Test Plan: played around with tasks in firefox and safari. made cc, owner, and project changes, as well as priority, etc. Reviewers: epriestley Reviewed By: epriestley CC: aran Maniphest Tasks: T1074 Differential Revision: https://secure.phabricator.com/D2234
2012-04-14 16:05:58 +02:00
'uri' => '/res/855c9f0c/rsrc/js/application/maniphest/behavior-transaction-preview.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
Make Maniphest Transaction preview tokenizer aware Summary: ...pretty sure the JS is too hack-tastic but it works...! :D also fixed a small error from assert_instances_of change where a null value is all errors and what have you Test Plan: played around with tasks in firefox and safari. made cc, owner, and project changes, as well as priority, etc. Reviewers: epriestley Reviewed By: epriestley CC: aran Maniphest Tasks: T1074 Differential Revision: https://secure.phabricator.com/D2234
2012-04-14 16:05:58 +02:00
3 => 'javelin-json',
4 => 'javelin-stratcom',
5 => 'phabricator-shaped-request',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/maniphest/behavior-transaction-preview.js',
),
'javelin-behavior-owners-path-editor' =>
array(
'uri' => '/res/9cf78ffc/rsrc/js/application/owners/owners-path-editor.js',
'type' => 'js',
'requires' =>
array(
0 => 'owners-path-editor',
1 => 'javelin-behavior',
),
'disk' => '/rsrc/js/application/owners/owners-path-editor.js',
),
Add a "jump nav" element to the homepage, for quick tool/object navigation Summary: - Restore quick methods for getting to common features (upload file, create task, etc.) - Provide a flexible cli-like navigation element similar to stuff used at Facebook (bunny1 / lolbunny). Test Plan: Used jump nav and nav buttons. Reviewers: btrahan, fratrik Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1619
2012-02-16 02:49:23 +01:00
'javelin-behavior-phabricator-autofocus' =>
array(
'uri' => '/res/2946bb89/rsrc/js/application/core/behavior-autofocus.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-autofocus.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-phabricator-keyboard-pager' =>
array(
'uri' => '/res/56d64eff/rsrc/js/application/core/behavior-keyboard-pager.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-uri',
2 => 'phabricator-keyboard-shortcut',
),
'disk' => '/rsrc/js/application/core/behavior-keyboard-pager.js',
),
'javelin-behavior-phabricator-keyboard-shortcuts' =>
array(
Fix a missing @requires Summary: Split from D1921. Lint complained. Test Plan: Lint doesn't complain. Reviewers: nh, vrana, btrahan Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1923
2012-03-20 03:17:40 +01:00
'uri' => '/res/06a151d8/rsrc/js/application/core/behavior-keyboard-shortcuts.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-workflow',
2 => 'javelin-json',
Fix a missing @requires Summary: Split from D1921. Lint complained. Test Plan: Lint doesn't complain. Reviewers: nh, vrana, btrahan Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1923
2012-03-20 03:17:40 +01:00
3 => 'javelin-dom',
4 => 'phabricator-keyboard-shortcut',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-keyboard-shortcuts.js',
),
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'javelin-behavior-phabricator-notification-example' =>
array(
Add multiple notifications and notification types Summary: - Allow more than one notification to be shown. - Allow notifications to be customized with extra classes. Test Plan: {F12776} Reviewers: allenjohnashton, ddfisher, keebuhm, jungejason Reviewed By: jungejason CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2758
2012-06-17 20:35:36 +02:00
'uri' => '/res/df97e4b3/rsrc/js/application/uiexample/notification-example.js',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'phabricator-notification',
1 => 'javelin-stratcom',
2 => 'javelin-behavior',
Add multiple notifications and notification types Summary: - Allow more than one notification to be shown. - Allow notifications to be customized with extra classes. Test Plan: {F12776} Reviewers: allenjohnashton, ddfisher, keebuhm, jungejason Reviewed By: jungejason CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2758
2012-06-17 20:35:36 +02:00
3 => 'javelin-uri',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
),
'disk' => '/rsrc/js/application/uiexample/notification-example.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-phabricator-object-selector' =>
array(
Minor, test fix for D2140? I think this fixes the issue in D2140, pushing to verify... Auditors: 20after4, btrahan
2012-04-07 21:58:18 +02:00
'uri' => '/res/0c4b0d82/rsrc/js/application/core/behavior-object-selector.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-request',
3 => 'javelin-util',
),
'disk' => '/rsrc/js/application/core/behavior-object-selector.js',
),
Kind-of-terrible (?) oncopy handler Summary: Works in Safari, Firefox, Chrome. Test Plan: Copied some text, threw up a little in my mouth. Reviewers: aran, tuomaspelkonen, tomo, rstout, btrahan Reviewed By: aran CC: aran, epriestley, ddfisher Maniphest Tasks: T145, T995 Differential Revision: https://secure.phabricator.com/D244
2012-03-16 03:04:59 +01:00
'javelin-behavior-phabricator-oncopy' =>
array(
Hide oncopy <pre> in Firefox Test Plan: Comment `JX.DOM.remove(pre)` to better see the problem in old code. Apply this diff and verify that the pre is not shown. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2245
2012-04-16 23:50:01 +02:00
'uri' => '/res/f490b8d1/rsrc/js/application/core/behavior-oncopy.js',
Kind-of-terrible (?) oncopy handler Summary: Works in Safari, Firefox, Chrome. Test Plan: Copied some text, threw up a little in my mouth. Reviewers: aran, tuomaspelkonen, tomo, rstout, btrahan Reviewed By: aran CC: aran, epriestley, ddfisher Maniphest Tasks: T145, T995 Differential Revision: https://secure.phabricator.com/D244
2012-03-16 03:04:59 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-oncopy.js',
),
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'javelin-behavior-phabricator-tooltips' =>
array(
'uri' => '/res/49f92a92/rsrc/js/application/core/behavior-tooltip.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'phabricator-tooltip',
),
'disk' => '/rsrc/js/application/core/behavior-tooltip.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-phabricator-watch-anchor' =>
array(
Use a simpler footer style to accommodate overly wide pages Summary: Not really thrilled about my fix for T684 in D1224. This makes some design tweaks to solve it without the awkward horizontal scrollbar in the page content div. Test Plan: Looked at diffs overflowing the window. Looked at footer on several pages. Reviewers: btrahan, jungejason, Makinde Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T684 Differential Revision: https://secure.phabricator.com/D1332
2012-01-06 16:16:56 +01:00
'uri' => '/res/880e3de4/rsrc/js/application/core/behavior-watch-anchor.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
Retry failed page anchor navigation Summary: When the user loads a page with an anchor on it like #thing, or clicks a link to #thing, and #thing doesn't exist, keep trying to navigate to #thing for a few seconds. This allows anchors to work when the target is in content which is later ajaxed in. In particular, this affects inline comments in Differential. Test Plan: Opened inline comment links in a new tab, was in the right place when I switched tabs. Reviewers: nh, btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan, epriestley Maniphest Tasks: T492 Differential Revision: https://secure.phabricator.com/D1327
2012-01-06 01:36:59 +01:00
3 => 'javelin-vector',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'disk' => '/rsrc/js/application/core/behavior-watch-anchor.js',
),
Phame V1 - Phabricator blogging software Summary: 'cuz we need to be phamous! V1 feature set - posts -- standard thing you'd expect - a title and a remarkup-powered body and... -- "phame" title - a short string that can be used to reference the story. this gets auto-updated when you mess with the title. -- configuration - for now, do you want Facebook, Disqus or no comments? this is a per-post thing but feeds from an instance-wide configuration Please do toss out any must have features or changes. Test Plan: played around with this bad boy like whoa Reviewers: epriestley Reviewed By: epriestley CC: aran, vrana Maniphest Tasks: T1111 Differential Revision: https://secure.phabricator.com/D2202
2012-04-12 22:09:04 +02:00
'javelin-behavior-phame-post-preview' =>
array(
'uri' => '/res/ac4c503a/rsrc/js/application/phame/phame-post-preview.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/phame/phame-post-preview.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-phriction-document-preview' =>
array(
'uri' => '/res/f1665ecd/rsrc/js/application/phriction/phriction-document-preview.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-util',
3 => 'phabricator-shaped-request',
),
'disk' => '/rsrc/js/application/phriction/phriction-document-preview.js',
),
'javelin-behavior-projects-resource-editor' =>
array(
'uri' => '/res/ffdde7d9/rsrc/js/application/projects/projects-resource-editor.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'phabricator-prefab',
2 => 'multirow-row-manager',
3 => 'javelin-tokenizer',
4 => 'javelin-typeahead-preloaded-source',
5 => 'javelin-typeahead',
6 => 'javelin-dom',
7 => 'javelin-json',
8 => 'javelin-util',
),
'disk' => '/rsrc/js/application/projects/projects-resource-editor.js',
),
'javelin-behavior-refresh-csrf' =>
array(
'uri' => '/res/88beba4c/rsrc/js/application/core/behavior-refresh-csrf.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-request',
1 => 'javelin-behavior',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/behavior-refresh-csrf.js',
),
'javelin-behavior-repository-crossreference' =>
array(
Use textContent instead of innerHTML for linking symbols Summary: Go to https://secure.phabricator.com/D2646#59cc9d49 and click on `array_mergev` to repro. Test Plan: Checked if the property exists in DOM inspector. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D2742
2012-06-13 23:24:25 +02:00
'uri' => '/res/8e4bbed2/rsrc/js/application/repository/repository-crossreference.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-uri',
),
'disk' => '/rsrc/js/application/repository/repository-crossreference.js',
),
For discussion -- Stripe integration Summary: various stripe stuff, including - external stripe library - payment form - test controller to play with payment form, sample business logic My main questions / discussion topics are... - is the stripe PHP library too big? (ie should I write something more simple just for phabricator?) -- if its cool, what is the best way to include the client? (ie should I make it a submodule rather than the flat copy here?) - is the JS I wrote (too) ridiculous? -- particularly unhappy with the error message stuff being in JS *but* it seemed the best choice given the most juicy error messages come from the stripe JS such that the overall code complexity is lowest this way. - how should the stripe JS be included? -- flat copy like I did here? -- some sort of external? -- can we just load it off stripe servers at request time? (I like that from the "if stripe is down, stripe is down" perspective) - wasn't sure if the date control was too silly and should just be baked into the form? -- for some reason I feel like its good to be prepared to walk away from Stripe / switch providers here, though I think this is on the wrong side of pragmatic Test Plan: - played around with sample client form Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2096
2012-04-05 01:09:29 +02:00
'javelin-behavior-stripe-payment-form' =>
array(
Delete unused CSS Summary: Unused since D2062. Test Plan: View commit. View task. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2108
2012-04-05 19:47:20 +02:00
'uri' => '/res/87c7b043/rsrc/js/application/phortune/behavior-stripe-payment-form.js',
For discussion -- Stripe integration Summary: various stripe stuff, including - external stripe library - payment form - test controller to play with payment form, sample business logic My main questions / discussion topics are... - is the stripe PHP library too big? (ie should I write something more simple just for phabricator?) -- if its cool, what is the best way to include the client? (ie should I make it a submodule rather than the flat copy here?) - is the JS I wrote (too) ridiculous? -- particularly unhappy with the error message stuff being in JS *but* it seemed the best choice given the most juicy error messages come from the stripe JS such that the overall code complexity is lowest this way. - how should the stripe JS be included? -- flat copy like I did here? -- some sort of external? -- can we just load it off stripe servers at request time? (I like that from the "if stripe is down, stripe is down" perspective) - wasn't sure if the date control was too silly and should just be baked into the form? -- for some reason I feel like its good to be prepared to walk away from Stripe / switch providers here, though I think this is on the wrong side of pragmatic Test Plan: - played around with sample client form Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2096
2012-04-05 01:09:29 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-json',
3 => 'stripe-core',
),
'disk' => '/rsrc/js/application/phortune/behavior-stripe-payment-form.js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'javelin-behavior-view-placeholder' =>
array(
'uri' => '/res/5b89bdf5/rsrc/js/javelin/ext/view/ViewPlaceholder.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-dom',
2 => 'javelin-view-renderer',
),
'disk' => '/rsrc/js/javelin/ext/view/ViewPlaceholder.js',
),
'javelin-behavior-workflow' =>
array(
Allow disabling JX.Workflow with keyboard modifier Summary: Ctrl+click opens the link to a new tab in most browsers. Shift+click to a new window. Alt+click or Meta+click downloads the target. This diff respects these conventions by disabling JX.Workflow for these modifiers. Test Plan: Click Flag Task - inline dialog. Ctrl+click Flag Task - new tab with standalone dialog. Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2276
2012-04-18 22:26:11 +02:00
'uri' => '/res/ce154288/rsrc/js/application/core/behavior-workflow.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-behavior',
1 => 'javelin-stratcom',
2 => 'javelin-workflow',
),
'disk' => '/rsrc/js/application/core/behavior-workflow.js',
),
'javelin-color' =>
array(
'uri' => '/res/b0439fc9/rsrc/js/javelin/ext/fx/Color.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/ext/fx/Color.js',
),
'javelin-cookie' =>
array(
'uri' => '/res/a9cddab0/rsrc/js/javelin/lib/Cookie.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/lib/Cookie.js',
),
'javelin-dom' =>
array(
Add colspan to Inline comment undo template Summary: Broken by D2443. Test Plan: Cancel non-empty inline comment. Reviewers: epriestley, nh Reviewed By: nh CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2486
2012-05-17 20:49:14 +02:00
'uri' => '/res/6d62f42d/rsrc/js/javelin/lib/DOM.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-magical-init',
1 => 'javelin-install',
2 => 'javelin-util',
3 => 'javelin-vector',
4 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/javelin/lib/DOM.js',
),
'javelin-dynval' =>
array(
'uri' => '/res/d89c6f88/rsrc/js/javelin/ext/reactor/core/DynVal.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-reactornode',
2 => 'javelin-util',
3 => 'javelin-reactor',
),
'disk' => '/rsrc/js/javelin/ext/reactor/core/DynVal.js',
),
'javelin-event' =>
array(
'uri' => '/res/f42fa6ea/rsrc/js/javelin/core/Event.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/core/Event.js',
),
'javelin-fx' =>
array(
'uri' => '/res/97e25a7f/rsrc/js/javelin/ext/fx/FX.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-color',
1 => 'javelin-install',
2 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/ext/fx/FX.js',
),
'javelin-history' =>
array(
'uri' => '/res/9bb36651/rsrc/js/javelin/lib/History.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-stratcom',
1 => 'javelin-install',
2 => 'javelin-uri',
3 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/lib/History.js',
),
'javelin-install' =>
array(
'uri' => '/res/cab679ff/rsrc/js/javelin/core/install.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-util',
1 => 'javelin-magical-init',
),
'disk' => '/rsrc/js/javelin/core/install.js',
),
'javelin-json' =>
array(
'uri' => '/res/561b8056/rsrc/js/javelin/lib/JSON.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/lib/JSON.js',
),
'javelin-magical-init' =>
array(
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
'uri' => '/res/caa86a45/rsrc/js/javelin/core/init.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/javelin/core/init.js',
),
'javelin-mask' =>
array(
'uri' => '/res/03ef78b8/rsrc/js/javelin/lib/Mask.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-vector',
2 => 'javelin-dom',
),
'disk' => '/rsrc/js/javelin/lib/Mask.js',
),
'javelin-reactor' =>
array(
'uri' => '/res/dfd87f3c/rsrc/js/javelin/ext/reactor/core/Reactor.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/ext/reactor/core/Reactor.js',
),
'javelin-reactor-dom' =>
array(
'uri' => '/res/701b6f39/rsrc/js/javelin/ext/reactor/dom/RDOM.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-dom',
1 => 'javelin-dynval',
2 => 'javelin-reactornode',
3 => 'javelin-install',
4 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/ext/reactor/dom/RDOM.js',
),
'javelin-reactor-node-calmer' =>
array(
'uri' => '/res/5a35920a/rsrc/js/javelin/ext/reactor/core/ReactorNodeCalmer.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-reactor',
2 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/ext/reactor/core/ReactorNodeCalmer.js',
),
'javelin-reactornode' =>
array(
'uri' => '/res/f278cc27/rsrc/js/javelin/ext/reactor/core/ReactorNode.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-reactor',
2 => 'javelin-util',
3 => 'javelin-reactor-node-calmer',
),
'disk' => '/rsrc/js/javelin/ext/reactor/core/ReactorNode.js',
),
'javelin-request' =>
array(
Avoid resolving path in celerity resource map Summary: HPHP doesn't like resolved symlinks. Also I like this code better. Test Plan: Used and not used custom Celerity map. Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D2694
2012-06-09 02:14:44 +02:00
'uri' => '/res/f256e263/rsrc/js/javelin/lib/Request.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-stratcom',
2 => 'javelin-util',
3 => 'javelin-behavior',
4 => 'javelin-json',
5 => 'javelin-dom',
),
'disk' => '/rsrc/js/javelin/lib/Request.js',
),
'javelin-resource' =>
array(
Add colspan to Inline comment undo template Summary: Broken by D2443. Test Plan: Cancel non-empty inline comment. Reviewers: epriestley, nh Reviewed By: nh CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2486
2012-05-17 20:49:14 +02:00
'uri' => '/res/0058cd36/rsrc/js/javelin/lib/Resource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-magical-init',
1 => 'javelin-stratcom',
2 => 'javelin-util',
3 => 'javelin-uri',
),
'disk' => '/rsrc/js/javelin/lib/Resource.js',
),
'javelin-stratcom' =>
array(
Indicate buttons disabled in JX.Workflow Summary: We are marking disabled buttons with 'disabled' class in `behavior-form`. But we ignore `JX.Workflow` there because it has its own handling. But this handling doesn't set class so the button is disabled but it is not indicated to user. It causes troubles in Clowncopterize where users report that browser freezes before doing anything after clicking it. It probably happens also on other places. This diff solves it by using CSS3 selector on attribute (contrary to explicitly setting class in JX.Workflow). Test Plan: Add `sleep(3)` to `DifferentialCommentSaveController`. Clowncopterize empty comment. Reviewers: epriestley, tuomaspelkonen Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2264
2012-04-18 07:04:54 +02:00
'uri' => '/res/d1888d8e/rsrc/js/javelin/core/Stratcom.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-event',
2 => 'javelin-util',
3 => 'javelin-magical-init',
),
'disk' => '/rsrc/js/javelin/core/Stratcom.js',
),
'javelin-tokenizer' =>
array(
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'uri' => '/res/a8275d0d/rsrc/js/javelin/lib/control/tokenizer/Tokenizer.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-dom',
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/lib/control/tokenizer/Tokenizer.js',
),
'javelin-typeahead' =>
array(
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'uri' => '/res/2f694700/rsrc/js/javelin/lib/control/typeahead/Typeahead.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
2 => 'javelin-vector',
3 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/Typeahead.js',
),
'javelin-typeahead-composite-source' =>
array(
'uri' => '/res/7c0d631f/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-typeahead-source',
2 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js',
),
'javelin-typeahead-normalizer' =>
array(
'uri' => '/res/a9e97c0d/rsrc/js/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js',
),
'javelin-typeahead-ondemand-source' =>
array(
'uri' => '/res/81e531aa/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-request',
4 => 'javelin-typeahead-source',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js',
),
'javelin-typeahead-preloaded-source' =>
array(
'uri' => '/res/d464efd2/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-request',
4 => 'javelin-typeahead-source',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadPreloadedSource.js',
),
'javelin-typeahead-source' =>
array(
Indicate buttons disabled in JX.Workflow Summary: We are marking disabled buttons with 'disabled' class in `behavior-form`. But we ignore `JX.Workflow` there because it has its own handling. But this handling doesn't set class so the button is disabled but it is not indicated to user. It causes troubles in Clowncopterize where users report that browser freezes before doing anything after clicking it. It probably happens also on other places. This diff solves it by using CSS3 selector on attribute (contrary to explicitly setting class in JX.Workflow). Test Plan: Add `sleep(3)` to `DifferentialCommentSaveController`. Clowncopterize empty comment. Reviewers: epriestley, tuomaspelkonen Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2264
2012-04-18 07:04:54 +02:00
'uri' => '/res/83bf292a/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadSource.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-dom',
3 => 'javelin-typeahead-normalizer',
),
'disk' => '/rsrc/js/javelin/lib/control/typeahead/source/TypeaheadSource.js',
),
'javelin-uri' =>
array(
'uri' => '/res/393ace00/rsrc/js/javelin/lib/URI.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-stratcom',
),
'disk' => '/rsrc/js/javelin/lib/URI.js',
),
'javelin-util' =>
array(
'uri' => '/res/2180bc95/rsrc/js/javelin/core/util.js',
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/javelin/core/util.js',
),
'javelin-vector' =>
array(
Add "buoyant" headers to Differential Summary: As you scroll through a diff, add a fixed-position header to the top of the document to provide context. This is particularly useful with keyboard navigation. The technical implementation is that we seed the document with invisible markers. When the user scrolls past one, we show a header with that text until they scroll past another. Test Plan: Scrolled through a revision, was presented with context. https://secure.phabricator.com/file/data/5xhh2jmoon6ukr5qjkh3/PHID-FILE-463ituscyhyw7utnox7m/Screen_Shot_2012-02-22_at_2.48.19_PM.png Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T696 Differential Revision: https://secure.phabricator.com/D1673
2012-02-23 21:26:14 +01:00
'uri' => '/res/f240bdb3/rsrc/js/javelin/lib/Vector.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-event',
),
'disk' => '/rsrc/js/javelin/lib/Vector.js',
),
'javelin-view' =>
array(
'uri' => '/res/b98657a7/rsrc/js/javelin/ext/view/View.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/ext/view/View.js',
),
'javelin-view-html' =>
array(
'uri' => '/res/7e5a2122/rsrc/js/javelin/ext/view/HTMLView.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
),
'disk' => '/rsrc/js/javelin/ext/view/HTMLView.js',
),
'javelin-view-interpreter' =>
array(
'uri' => '/res/17e911ca/rsrc/js/javelin/ext/view/ViewInterpreter.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-view',
1 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/ext/view/ViewInterpreter.js',
),
'javelin-view-renderer' =>
array(
'uri' => '/res/db4ed5a2/rsrc/js/javelin/ext/view/ViewRenderer.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
),
'disk' => '/rsrc/js/javelin/ext/view/ViewRenderer.js',
),
'javelin-view-visitor' =>
array(
'uri' => '/res/0ef9dc43/rsrc/js/javelin/ext/view/ViewVisitor.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
),
'disk' => '/rsrc/js/javelin/ext/view/ViewVisitor.js',
),
'javelin-workflow' =>
array(
'uri' => '/res/519c4e1a/rsrc/js/javelin/lib/Workflow.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-stratcom',
1 => 'javelin-request',
2 => 'javelin-dom',
3 => 'javelin-vector',
4 => 'javelin-install',
5 => 'javelin-util',
6 => 'javelin-mask',
7 => 'javelin-uri',
),
'disk' => '/rsrc/js/javelin/lib/Workflow.js',
),
Rough batch editor for Maniphest Summary: First stab at a batch editor for Maniphest. Basically, you can select a group of tasks and then import them into the "batch" interface, where you can edit all of them at once. High level goal is to make it easier for users in PM/filer/support/QA roles to deal with large numbers of tasks quickly. This implementation has a few major limitations: - The only available actions are "add projects" and "remove projects". - There is no review / undo / log stuff. - All the changes are applied in-process, which may not scale terribly well. However, the immediate need is just around projects and this seemed like a reasonable place to draw the line for a minimal useful version of the tool. Test Plan: Used batch editor to add and remove projects from groups of tasks. Reviewers: btrahan, yairlivne Reviewed By: btrahan CC: aran, epriestley, sandra Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1680
2012-02-24 22:00:48 +01:00
'maniphest-batch-editor' =>
array(
'uri' => '/res/fb15d744/rsrc/css/application/maniphest/batch-editor.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/batch-editor.css',
),
Iterate on Maniphest reports Summary: - These are still slow, awkward and hideous -- but slightly better than before. - Allow "open" reports to be sorted. - Add a "burn" chart/table for assessing project volatility. - Add navigation. Test Plan: Looked at reports. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T923 Differential Revision: https://secure.phabricator.com/D1737
2012-03-01 23:19:11 +01:00
'maniphest-report-css' =>
array(
'uri' => '/res/2e633fcf/rsrc/css/application/maniphest/report.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/report.css',
),
Add a description preview to maniphest create / edit panel Summary: also fixes a small bug where the page title was always "Create Task". switch it to the header name which is much more descriptive / correct IMO. Test Plan: created a new task and watched the description preview update. edited an old task and saw the description preview populate with the correct existing data. edited an old task and edited the description and saw the description preview update Reviewers: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1489
2012-01-25 20:23:00 +01:00
'maniphest-task-edit-css' =>
array(
'uri' => '/res/68c7863e/rsrc/css/application/maniphest/task-edit.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/task-edit.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'maniphest-task-summary-css' =>
array(
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'uri' => '/res/6e67cb30/rsrc/css/application/maniphest/task-summary.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/task-summary.css',
),
'maniphest-transaction-detail-css' =>
array(
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'uri' => '/res/24e5862f/rsrc/css/application/maniphest/transaction-detail.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/maniphest/transaction-detail.css',
),
'multirow-row-manager' =>
array(
'uri' => '/res/0a9b3dee/rsrc/js/application/core/MultirowRowManager.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-stratcom',
2 => 'javelin-dom',
3 => 'javelin-util',
),
'disk' => '/rsrc/js/application/core/MultirowRowManager.js',
),
'owners-path-editor' =>
array(
'uri' => '/res/e6c51eb6/rsrc/js/application/owners/OwnersPathEditor.js',
'type' => 'js',
'requires' =>
array(
0 => 'multirow-row-manager',
1 => 'javelin-install',
2 => 'path-typeahead',
3 => 'javelin-dom',
4 => 'javelin-util',
),
'disk' => '/rsrc/js/application/owners/OwnersPathEditor.js',
),
'owners-path-editor-css' =>
array(
'uri' => '/res/9bc5332c/rsrc/css/application/owners/owners-path-editor.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/owners/owners-path-editor.css',
),
'path-typeahead' =>
array(
'uri' => '/res/50246fb6/rsrc/js/application/herald/PathTypeahead.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-typeahead',
2 => 'javelin-dom',
3 => 'javelin-request',
4 => 'javelin-typeahead-ondemand-source',
5 => 'javelin-util',
),
'disk' => '/rsrc/js/application/herald/PathTypeahead.js',
),
Refine "Tactical Command" layout and styling Summary: - Move the buttons in the jump nav to iOS-style "application" buttons in the header. These are sort of ugly right now, but I think serviceable enough. Some day we will hire a designer whose entire job is to pick up after me. - This gives us more room (allowing us to restore "Maniphest" and "Differential"). - This also disassociates the app buttons from the jump nav, which was a point of confusion (user expectation that the text input is related to the buttons). - Allow "Active Revisions" and "Assigned Tasks" to collapse completely. They didn't completely collapse before because the top-level "Active Tasks" / "Active Revisions" was sort of overloaded as quick nav to apps. Now we have app buttons. - Reduce overall size of jump nav. Test Plan: Looked at homepage in various states of need-for-attention. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1694
2012-02-27 22:14:32 +01:00
'phabricator-app-buttons-css' =>
array(
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'uri' => '/res/1e153463/rsrc/css/application/directory/phabricator-app-buttons.css',
Refine "Tactical Command" layout and styling Summary: - Move the buttons in the jump nav to iOS-style "application" buttons in the header. These are sort of ugly right now, but I think serviceable enough. Some day we will hire a designer whose entire job is to pick up after me. - This gives us more room (allowing us to restore "Maniphest" and "Differential"). - This also disassociates the app buttons from the jump nav, which was a point of confusion (user expectation that the text input is related to the buttons). - Allow "Active Revisions" and "Assigned Tasks" to collapse completely. They didn't completely collapse before because the top-level "Active Tasks" / "Active Revisions" was sort of overloaded as quick nav to apps. Now we have app buttons. - Reduce overall size of jump nav. Test Plan: Looked at homepage in various states of need-for-attention. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1694
2012-02-27 22:14:32 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/directory/phabricator-app-buttons.css',
),
Add a basic chatlog Summary: This is pretty simple and unpolished, but it's getting pretty big and it seems like a reasonable starting point. - Log chat in various "channels". - Conduit record and query methods. - IRCBot integration for IRC logging Major TODO: - Web UI is really unpolished and has no search, paging, anchor-linking, etc. Basically all presentation stuff, though. - I think the bot should have a map of channels to log with channel aliases? - The "channels" should probably be in a separate table. - The "authors" should probably be correlated to Phabricator accounts somehow, where possible. Test Plan: Used phabotlocal to log #phabricator. Reviewers: kdeggelman, btrahan, Koolvin Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T837 Differential Revision: https://secure.phabricator.com/D1625
2012-02-17 19:21:38 +01:00
'phabricator-chatlog-css' =>
array(
Make chatlog a bit less awful Summary: - Default to showing the newest page of chat. - Reformat for greater readability. - Add permalinks to specific lines. - Enable jump-to-date. Test Plan: {F12200} Reviewers: Koolvin, vrana, btrahan Reviewed By: btrahan CC: kdeggelman, aran Maniphest Tasks: T837, T1065 Differential Revision: https://secure.phabricator.com/D2641
2012-06-02 23:00:08 +02:00
'uri' => '/res/f6631adc/rsrc/css/application/chatlog/chatlog.css',
Add a basic chatlog Summary: This is pretty simple and unpolished, but it's getting pretty big and it seems like a reasonable starting point. - Log chat in various "channels". - Conduit record and query methods. - IRCBot integration for IRC logging Major TODO: - Web UI is really unpolished and has no search, paging, anchor-linking, etc. Basically all presentation stuff, though. - I think the bot should have a map of channels to log with channel aliases? - The "channels" should probably be in a separate table. - The "authors" should probably be correlated to Phabricator accounts somehow, where possible. Test Plan: Used phabotlocal to log #phabricator. Reviewers: kdeggelman, btrahan, Koolvin Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T837 Differential Revision: https://secure.phabricator.com/D1625
2012-02-17 19:21:38 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/chatlog/chatlog.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-content-source-view-css' =>
array(
'uri' => '/res/8c738a93/rsrc/css/application/contentsource/content-source-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/contentsource/content-source-view.css',
),
'phabricator-core-buttons-css' =>
array(
Indicate buttons disabled in JX.Workflow Summary: We are marking disabled buttons with 'disabled' class in `behavior-form`. But we ignore `JX.Workflow` there because it has its own handling. But this handling doesn't set class so the button is disabled but it is not indicated to user. It causes troubles in Clowncopterize where users report that browser freezes before doing anything after clicking it. It probably happens also on other places. This diff solves it by using CSS3 selector on attribute (contrary to explicitly setting class in JX.Workflow). Test Plan: Add `sleep(3)` to `DifferentialCommentSaveController`. Clowncopterize empty comment. Reviewers: epriestley, tuomaspelkonen Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2264
2012-04-18 07:04:54 +02:00
'uri' => '/res/fc57a0c7/rsrc/css/core/buttons.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/buttons.css',
),
'phabricator-core-css' =>
array(
Use a simpler footer style to accommodate overly wide pages Summary: Not really thrilled about my fix for T684 in D1224. This makes some design tweaks to solve it without the awkward horizontal scrollbar in the page content div. Test Plan: Looked at diffs overflowing the window. Looked at footer on several pages. Reviewers: btrahan, jungejason, Makinde Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T684 Differential Revision: https://secure.phabricator.com/D1332
2012-01-06 16:16:56 +01:00
'uri' => '/res/f912ffab/rsrc/css/core/core.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/core.css',
),
'phabricator-countdown-css' =>
array(
'uri' => '/res/0f646281/rsrc/css/application/countdown/timer.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/countdown/timer.css',
),
'phabricator-directory-css' =>
array(
Replace home directory list with a dashboard Summary: Rough cut that still needs a lot of polish, but replace the directory list with more of a dashboard type thing: - Show "Unbreak Now", triage-in-your-projects, and other stuff that you're supposed to deal with, then feed. - Move tools a click a way behind nav -- this also lets us put more stuff there and subtools, etc., later. - Remove tabs. - Merge the category/item editing views. - I also added a light blue wash to the side nav, not sure if I like that or not. Test Plan: - Viewed all elements in empty and nonempty states. - Viewed applications, edited items/categories. Reviewers: btrahan, aran Reviewed By: btrahan CC: aran, epriestley, davidreuss Maniphest Tasks: T21, T631 Differential Revision: https://secure.phabricator.com/D1574
2012-02-08 01:04:48 +01:00
'uri' => '/res/61afca2b/rsrc/css/application/directory/phabricator-directory.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/directory/phabricator-directory.css',
),
'phabricator-drag-and-drop-file-upload' =>
array(
'uri' => '/res/63a06ad9/rsrc/js/application/core/DragAndDropFileUpload.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-request',
3 => 'javelin-dom',
4 => 'javelin-uri',
),
'disk' => '/rsrc/js/application/core/DragAndDropFileUpload.js',
),
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'phabricator-dropdown-menu' =>
array(
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'uri' => '/res/2b4aa4d8/rsrc/js/application/core/DropdownMenu.js',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-dom',
3 => 'javelin-vector',
4 => 'javelin-stratcom',
5 => 'phabricator-menu-item',
),
'disk' => '/rsrc/js/application/core/DropdownMenu.js',
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-feed-css' =>
array(
Don't set feed width on chromeless page Summary: Otherwise browser displays horizontal scrollbar at http://phabricator.org/. Test Plan: Add this rule in Firebug and display http://phabricator.org/. /feed/ Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2173
2012-04-10 00:07:38 +02:00
'uri' => '/res/8ddc1d44/rsrc/css/application/feed/feed.css',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/feed/feed.css',
),
Add "Flags" to allow users to collect the things they love Summary: Flags are a personal collection of things you want to take a look at later. You can use several different colors and add notes. Not really sure if this is actually a good idea or not but it was easy to build. Planned features: - Allow Herald rules to add flags. - In the "edit flag" dialog, have a "[x] Subscribe Me" checkbox that CCs you. - Support Diffusion. - Support Phriction. - Always show flags on an object if you have them (in every view)? - Edit dialog feels a little heavy? - More filtering in /flag/ tool. - Add a top-level links somewhere? Test Plan: Added, edited and removed flags from things. Viewed flags in flag view. Reviewers: aran, btrahan Reviewed By: btrahan CC: aran, epriestley, Koolvin Maniphest Tasks: T1041 Differential Revision: https://secure.phabricator.com/D2024
2012-03-28 01:22:40 +02:00
'phabricator-flag-css' =>
array(
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'uri' => '/res/36d4af36/rsrc/css/application/flag/flag.css',
Add "Flags" to allow users to collect the things they love Summary: Flags are a personal collection of things you want to take a look at later. You can use several different colors and add notes. Not really sure if this is actually a good idea or not but it was easy to build. Planned features: - Allow Herald rules to add flags. - In the "edit flag" dialog, have a "[x] Subscribe Me" checkbox that CCs you. - Support Diffusion. - Support Phriction. - Always show flags on an object if you have them (in every view)? - Edit dialog feels a little heavy? - More filtering in /flag/ tool. - Add a top-level links somewhere? Test Plan: Added, edited and removed flags from things. Viewed flags in flag view. Reviewers: aran, btrahan Reviewed By: btrahan CC: aran, epriestley, Koolvin Maniphest Tasks: T1041 Differential Revision: https://secure.phabricator.com/D2024
2012-03-28 01:22:40 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/flag/flag.css',
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-jump-nav' =>
array(
Refine "Tactical Command" layout and styling Summary: - Move the buttons in the jump nav to iOS-style "application" buttons in the header. These are sort of ugly right now, but I think serviceable enough. Some day we will hire a designer whose entire job is to pick up after me. - This gives us more room (allowing us to restore "Maniphest" and "Differential"). - This also disassociates the app buttons from the jump nav, which was a point of confusion (user expectation that the text input is related to the buttons). - Allow "Active Revisions" and "Assigned Tasks" to collapse completely. They didn't completely collapse before because the top-level "Active Tasks" / "Active Revisions" was sort of overloaded as quick nav to apps. Now we have app buttons. - Reduce overall size of jump nav. Test Plan: Looked at homepage in various states of need-for-attention. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1694
2012-02-27 22:14:32 +01:00
'uri' => '/res/8bdc0fc3/rsrc/css/application/directory/phabricator-jump-nav.css',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/directory/phabricator-jump-nav.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-keyboard-shortcut' =>
array(
'uri' => '/res/beed38cd/rsrc/js/application/core/KeyboardShortcut.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'phabricator-keyboard-shortcut-manager',
),
'disk' => '/rsrc/js/application/core/KeyboardShortcut.js',
),
'phabricator-keyboard-shortcut-manager' =>
array(
Change All Search Boxes into Jump Navs Summary: - all search boxes are now jump navs (old functionality retained if none of the jump nav patterns match) - added global keyboard shortcut '/' to focus the search box in the upper right Test Plan: - pressed '/' and noticed the search box gains keyboard focus - triggered jump nav functionality from search box and saw it worked - did a search which did not match a jump nav pattern and saw it worked (and searched in the selected context) NOTE: The search box on the /search/ page is also changed to have jump nav functionality. Old functionality is not impared. Still, this may not be desirable. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1794
2012-03-06 04:51:16 +01:00
'uri' => '/res/0be80136/rsrc/js/application/core/KeyboardShortcutManager.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-stratcom',
3 => 'javelin-dom',
4 => 'javelin-vector',
),
'disk' => '/rsrc/js/application/core/KeyboardShortcutManager.js',
),
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'phabricator-menu-item' =>
array(
Fill <a href> in PhabricatorMenuItem Summary: The <a href> attribute is useful because user knows where the link goes before opening it plus he can copy it to the clipboard plus he can add it to the bookmarks. Test Plan: Display revision. View Options. Click. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D1436
2012-01-17 07:17:18 +01:00
'uri' => '/res/32fc2325/rsrc/js/application/core/DropdownMenuItem.js',
Add a dropdown menu for Differential view options Summary: There are several open Differential tasks that are basically blocked on not having reasonable places in the UI to put things. Replace the "View Standalone / Raw" button with a "View Options" dropdown menu so we can shove things like "Expand All", "Fold / Unfold File", and "View in Diffusion" in there. This doesn't change any behavior, just puts the existing options in a menu. Test Plan: - Toggled menu open by clicking button. - Clicked menu items. - Toggled menu closed by clicking button. - Toggled menu closed by clicking document. - Toggled menu closed by opening another menu. - Toggled menu closed by selecting an item. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, btrahan Maniphest Tasks: T497, T309 Differential Revision: https://secure.phabricator.com/D1316
2012-01-05 01:52:13 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/core/DropdownMenuItem.js',
),
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'phabricator-notification' =>
array(
Add multiple notifications and notification types Summary: - Allow more than one notification to be shown. - Allow notifications to be customized with extra classes. Test Plan: {F12776} Reviewers: allenjohnashton, ddfisher, keebuhm, jungejason Reviewed By: jungejason CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2758
2012-06-17 20:35:36 +02:00
'uri' => '/res/cacd79f1/rsrc/js/application/core/Notification.js',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-dom',
2 => 'javelin-stratcom',
Add multiple notifications and notification types Summary: - Allow more than one notification to be shown. - Allow notifications to be customized with extra classes. Test Plan: {F12776} Reviewers: allenjohnashton, ddfisher, keebuhm, jungejason Reviewed By: jungejason CC: aran Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2758
2012-06-17 20:35:36 +02:00
3 => 'javelin-util',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
),
'disk' => '/rsrc/js/application/core/Notification.js',
),
'phabricator-notification-css' =>
array(
Add Z-index to notifications Summary: Currently, notifications aren't z-indexed so they can end up underneath some other elements: {F13144} Fix this so they float correctly. Test Plan: {F13166} Reviewers: jungejason, btrahan Reviewed By: jungejason CC: aran Maniphest Tasks: T1398 Differential Revision: https://secure.phabricator.com/D2834
2012-06-22 19:48:16 +02:00
'uri' => '/res/77e8c821/rsrc/css/aphront/notification.css',
Add a basic notification UI element Summary: This is //extremely// basic but dead simple and should cover us for v1, I think. Let me know what features you need. Test Plan: Used UI example page. Reviewers: allenjohnashton, ddfisher, keebuhm Reviewed By: ddfisher CC: aran, ender Maniphest Tasks: T944 Differential Revision: https://secure.phabricator.com/D2732
2012-06-14 00:00:24 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/notification.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-object-selector-css' =>
array(
Increase the click target area for the object selector Summary: Make clicking the link also select the object (this operation is very common). Add an arrow to the left to view the object (this operation is very rare). Increase link target area to the entire cell. Also simplify some handlers. Test Plan: Clicked things with wild abandon. Behavior seemed unchanged. Reviewers: cpiro, btrahan Reviewed By: cpiro CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1962
2012-03-20 03:20:49 +01:00
'uri' => '/res/7eb4c705/rsrc/css/application/objectselector/object-selector.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
0 => 'aphront-dialog-view-css',
),
'disk' => '/rsrc/css/application/objectselector/object-selector.css',
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-paste-file-upload' =>
Add a description preview to maniphest create / edit panel Summary: also fixes a small bug where the page title was always "Create Task". switch it to the header name which is much more descriptive / correct IMO. Test Plan: created a new task and watched the description preview update. edited an old task and saw the description preview populate with the correct existing data. edited an old task and edited the description and saw the description preview update Reviewers: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1489
2012-01-25 20:23:00 +01:00
array(
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'uri' => '/res/cdc939bd/rsrc/js/application/core/PasteFileUpload.js',
Add a description preview to maniphest create / edit panel Summary: also fixes a small bug where the page title was always "Create Task". switch it to the header name which is much more descriptive / correct IMO. Test Plan: created a new task and watched the description preview update. edited an old task and saw the description preview populate with the correct existing data. edited an old task and edited the description and saw the description preview update Reviewers: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1489
2012-01-25 20:23:00 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
2 => 'javelin-request',
3 => 'javelin-dom',
4 => 'javelin-uri',
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'disk' => '/rsrc/js/application/core/PasteFileUpload.js',
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-prefab' =>
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
array(
Add "Change Priority", "Open / Close", "Comment" and "Assign" actions to Maniphest batch editor Summary: I think these are all the actions which make any sense. Test Plan: - Performed and verified each action through the batch editor. - Performed a large batch edit which applied each action type multiple times and verified the aggregate behavior was correct. Reviewers: btrahan, cpiro Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T441 Differential Revision: https://secure.phabricator.com/D1971
2012-03-21 22:01:04 +01:00
'uri' => '/res/2734e45f/rsrc/js/application/core/Prefab.js',
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
2 => 'javelin-dom',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
3 => 'javelin-typeahead',
4 => 'javelin-tokenizer',
5 => 'javelin-typeahead-preloaded-source',
6 => 'javelin-typeahead-ondemand-source',
7 => 'javelin-dom',
8 => 'javelin-stratcom',
9 => 'javelin-util',
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'disk' => '/rsrc/js/application/core/Prefab.js',
Support paste file uploads Summary: This is so freaking cool that I will try to implement it also on Facebook. Idea is from http://strd6.com/2011/09/html5-javascript-pasting-image-data-in-chrome/. I don't know how to properly detect support but lying about it is not a big deal. Test Plan: Go to revision comment textarea. Paste some text data - works as usual. Paste some image data in Chrome - file is uploaded and a link to it is inserted. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1681
2012-02-24 00:47:41 +01:00
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-profile-css' =>
array(
'uri' => '/res/9869d10b/rsrc/css/application/profile/profile-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/profile/profile-view.css',
),
'phabricator-profile-header-css' =>
array(
Add a Join / Leave button to Projects Summary: Make it easy to join or leave (well, slightly less easy) a project. Publish join/leave to feed. Fix a couple of membership editor bugs. Test Plan: Joined, left a project. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T681 Differential Revision: https://secure.phabricator.com/D1485
2012-01-25 20:51:20 +01:00
'uri' => '/res/4b1cb23b/rsrc/css/application/profile/profile-header-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/profile/profile-header-view.css',
),
Show projects on Maniphest tasks Summary: - Remove the "Priority" column, since this is indicated by the color swatch, to save space. - Reduce the "Updated" column from datetime to date only, since time isn't incredibly useful, to save space. - Show the first two projects a task is associated with, and "..." if there are more. - Show "None" (for "no owner") in a lighter color. Test Plan: Looked at tasks on homepage and in Maniphest. Reviewers: btrahan, 20after4 Reviewed By: btrahan CC: aran, edward Maniphest Tasks: T967 Differential Revision: https://secure.phabricator.com/D2065
2012-04-02 19:27:31 +02:00
'phabricator-project-tag-css' =>
array(
Improve display of long project names in task list UI Summary: - Shorten long project names. - Prevent wrapping. - Fix a double-escaping issue. Test Plan: See screenshots below. Reviewers: btrahan, 20after4 Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2073
2012-04-02 20:16:05 +02:00
'uri' => '/res/6b0a5223/rsrc/css/application/projects/project-tag.css',
Show projects on Maniphest tasks Summary: - Remove the "Priority" column, since this is indicated by the color swatch, to save space. - Reduce the "Updated" column from datetime to date only, since time isn't incredibly useful, to save space. - Show the first two projects a task is associated with, and "..." if there are more. - Show "None" (for "no owner") in a lighter color. Test Plan: Looked at tasks on homepage and in Maniphest. Reviewers: btrahan, 20after4 Reviewed By: btrahan CC: aran, edward Maniphest Tasks: T967 Differential Revision: https://secure.phabricator.com/D2065
2012-04-02 19:27:31 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/projects/project-tag.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-remarkup-css' =>
array(
Highlight disabled users in Remarkup Test Plan: @btrahan @epriestley @xxx Reviewers: epriestley Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2374
2012-05-03 04:00:42 +02:00
'uri' => '/res/f6d48479/rsrc/css/core/remarkup.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/remarkup.css',
),
'phabricator-search-results-css' =>
array(
'uri' => '/res/f8a86e27/rsrc/css/application/search/search-results.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/search/search-results.css',
),
'phabricator-shaped-request' =>
array(
Send only one request at a time from ShapedRequest Summary: 'this._request' was never set so 'waiting' was always false. Result was that several requests were sent at once which wastes resources and leads to weird bugs when responses don't arrive in sending order. Blame Rev: D258 Test Plan: Write a comment extremely fast, watch for requests sent. Add sleep(5) for some inputs to DifferentialCommentPreviewController, verify correct order. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1612
2012-02-15 00:47:10 +01:00
'uri' => '/res/59029fa9/rsrc/js/application/core/ShapedRequest.js',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-request',
),
'disk' => '/rsrc/js/application/core/ShapedRequest.js',
),
'phabricator-slowvote-css' =>
array(
'uri' => '/res/94d20443/rsrc/css/application/slowvote/slowvote.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/slowvote/slowvote.css',
),
'phabricator-standard-page-view' =>
array(
Improve notification list view Summary: - Provide a filter to show just unread notifications. - Visually show which notifications are unread. - Style tweaks to make notifications more readable. Test Plan: {F13494} Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2883
2012-06-28 22:59:50 +02:00
'uri' => '/res/a233253a/rsrc/css/application/base/standard-page-view.css',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/base/standard-page-view.css',
),
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'phabricator-tooltip' =>
array(
'uri' => '/res/bcddf5de/rsrc/js/application/core/ToolTip.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-util',
2 => 'javelin-dom',
3 => 'javelin-vector',
),
'disk' => '/rsrc/js/application/core/ToolTip.js',
),
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'phabricator-transaction-view-css' =>
array(
Show audit comments on the Diffusion commit view Summary: We already allow you to create comments, but we don't show them on the commit page. After style / view unification this is easy; show comments on the commit page. Test Plan: Made comments on a commit using the audit too, saw them show up in Diffusion. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1687
2012-02-24 23:14:39 +01:00
'uri' => '/res/731959fb/rsrc/css/aphront/transaction.css',
Unify Maniphest + Differential comment styles Summary: I want to add comments to commits, and they should obviously share code with the nearly-identical comments in Maniphest and Differential. Unify code/style as much as possible. This program made possible by a generous grant from D1513. Test Plan: - Looked at a bunch of different Differential and Maniphest comments; they appeared to render identically to how they looked before. - Tested some edge cases like anchors and "show details" on description edits in Maniphest. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T904 Differential Revision: https://secure.phabricator.com/D1686
2012-02-24 22:02:35 +01:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/aphront/transaction.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'phabricator-ui-example-css' =>
array(
'uri' => '/res/0cef078b/rsrc/css/application/uiexample/example.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/uiexample/example.css',
),
'phabricator-uiexample-javelin-view' =>
array(
'uri' => '/res/a2ce2cfc/rsrc/js/application/uiexample/JavelinViewExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
),
'disk' => '/rsrc/js/application/uiexample/JavelinViewExample.js',
),
'phabricator-uiexample-reactor-button' =>
array(
'uri' => '/res/142127f6/rsrc/js/application/uiexample/ReactorButtonExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorButtonExample.js',
),
'phabricator-uiexample-reactor-checkbox' =>
array(
'uri' => '/res/c75cb9e9/rsrc/js/application/uiexample/ReactorCheckboxExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorCheckboxExample.js',
),
'phabricator-uiexample-reactor-focus' =>
array(
'uri' => '/res/3cc992eb/rsrc/js/application/uiexample/ReactorFocusExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorFocusExample.js',
),
'phabricator-uiexample-reactor-input' =>
array(
'uri' => '/res/4953da16/rsrc/js/application/uiexample/ReactorInputExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
5 => 'javelin-view-html',
6 => 'javelin-view-interpreter',
7 => 'javelin-view-renderer',
),
'disk' => '/rsrc/js/application/uiexample/ReactorInputExample.js',
),
'phabricator-uiexample-reactor-mouseover' =>
array(
'uri' => '/res/52a355b6/rsrc/js/application/uiexample/ReactorMouseoverExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorMouseoverExample.js',
),
'phabricator-uiexample-reactor-radio' =>
array(
'uri' => '/res/ae87f3af/rsrc/js/application/uiexample/ReactorRadioExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorRadioExample.js',
),
'phabricator-uiexample-reactor-select' =>
array(
'uri' => '/res/23cb448a/rsrc/js/application/uiexample/ReactorSelectExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorSelectExample.js',
),
'phabricator-uiexample-reactor-sendclass' =>
array(
'uri' => '/res/8cd34264/rsrc/js/application/uiexample/ReactorSendClassExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorSendClassExample.js',
),
'phabricator-uiexample-reactor-sendproperties' =>
array(
'uri' => '/res/18af54aa/rsrc/js/application/uiexample/ReactorSendPropertiesExample.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-install',
1 => 'javelin-view',
2 => 'javelin-util',
3 => 'javelin-dom',
4 => 'javelin-reactor-dom',
),
'disk' => '/rsrc/js/application/uiexample/ReactorSendPropertiesExample.js',
),
'phriction-document-css' =>
array(
'uri' => '/res/8d09bd7f/rsrc/css/application/phriction/phriction-document-css.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/phriction/phriction-document-css.css',
),
'project-edit-css' =>
array(
'uri' => '/res/c192b5f9/rsrc/css/application/projects/project-edit.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/projects/project-edit.css',
),
Add gRaphael charting library Summary: I typed up like 30 pages here and then got my soul crushed by T895, but here's the summary: I looked at several charting libraries. There aren't very many that seem to be any good and have an open-source license. I also want the charts to be scriptable in JS so we can add good interactivity where appropriate. Raphael is an SVG drawing library which seems very solid. gRaphael is a charting library on top of Raphael that is a lot less solid, but seems kind of OK. Overall, I think this selection gives us a lot of flexibility, although we'll have to pay some costs up front. I'd rather do that then get limited later, though. That said, I'm open to other suggestions here if anyone has experience or wants to take a different stab at researching things. This is largely for @vii and D1643. Test Plan: Created a basic, fairly OK chart (see next revision). Reviewers: btrahan, vii Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1654
2012-02-22 00:10:24 +01:00
'raphael-core' =>
array(
Minor, don't minify raphael.js since it doesn't survive it Auditors: btrahan
2012-04-02 21:07:59 +02:00
'uri' => '/res/3f48575a/rsrc/js/raphael/raphael.js',
Add gRaphael charting library Summary: I typed up like 30 pages here and then got my soul crushed by T895, but here's the summary: I looked at several charting libraries. There aren't very many that seem to be any good and have an open-source license. I also want the charts to be scriptable in JS so we can add good interactivity where appropriate. Raphael is an SVG drawing library which seems very solid. gRaphael is a charting library on top of Raphael that is a lot less solid, but seems kind of OK. Overall, I think this selection gives us a lot of flexibility, although we'll have to pay some costs up front. I'd rather do that then get limited later, though. That said, I'm open to other suggestions here if anyone has experience or wants to take a different stab at researching things. This is largely for @vii and D1643. Test Plan: Created a basic, fairly OK chart (see next revision). Reviewers: btrahan, vii Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1654
2012-02-22 00:10:24 +01:00
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/raphael/raphael.js',
),
'raphael-g' =>
array(
Minor, don't minify raphael.js since it doesn't survive it Auditors: btrahan
2012-04-02 21:07:59 +02:00
'uri' => '/res/b07e5245/rsrc/js/raphael/g.raphael.js',
Add gRaphael charting library Summary: I typed up like 30 pages here and then got my soul crushed by T895, but here's the summary: I looked at several charting libraries. There aren't very many that seem to be any good and have an open-source license. I also want the charts to be scriptable in JS so we can add good interactivity where appropriate. Raphael is an SVG drawing library which seems very solid. gRaphael is a charting library on top of Raphael that is a lot less solid, but seems kind of OK. Overall, I think this selection gives us a lot of flexibility, although we'll have to pay some costs up front. I'd rather do that then get limited later, though. That said, I'm open to other suggestions here if anyone has experience or wants to take a different stab at researching things. This is largely for @vii and D1643. Test Plan: Created a basic, fairly OK chart (see next revision). Reviewers: btrahan, vii Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1654
2012-02-22 00:10:24 +01:00
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/raphael/g.raphael.js',
),
'raphael-g-line' =>
array(
Minor, don't minify raphael.js since it doesn't survive it Auditors: btrahan
2012-04-02 21:07:59 +02:00
'uri' => '/res/a59c8556/rsrc/js/raphael/g.raphael.line.js',
Add gRaphael charting library Summary: I typed up like 30 pages here and then got my soul crushed by T895, but here's the summary: I looked at several charting libraries. There aren't very many that seem to be any good and have an open-source license. I also want the charts to be scriptable in JS so we can add good interactivity where appropriate. Raphael is an SVG drawing library which seems very solid. gRaphael is a charting library on top of Raphael that is a lot less solid, but seems kind of OK. Overall, I think this selection gives us a lot of flexibility, although we'll have to pay some costs up front. I'd rather do that then get limited later, though. That said, I'm open to other suggestions here if anyone has experience or wants to take a different stab at researching things. This is largely for @vii and D1643. Test Plan: Created a basic, fairly OK chart (see next revision). Reviewers: btrahan, vii Reviewed By: btrahan CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1654
2012-02-22 00:10:24 +01:00
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/raphael/g.raphael.line.js',
),
For discussion -- Stripe integration Summary: various stripe stuff, including - external stripe library - payment form - test controller to play with payment form, sample business logic My main questions / discussion topics are... - is the stripe PHP library too big? (ie should I write something more simple just for phabricator?) -- if its cool, what is the best way to include the client? (ie should I make it a submodule rather than the flat copy here?) - is the JS I wrote (too) ridiculous? -- particularly unhappy with the error message stuff being in JS *but* it seemed the best choice given the most juicy error messages come from the stripe JS such that the overall code complexity is lowest this way. - how should the stripe JS be included? -- flat copy like I did here? -- some sort of external? -- can we just load it off stripe servers at request time? (I like that from the "if stripe is down, stripe is down" perspective) - wasn't sure if the date control was too silly and should just be baked into the form? -- for some reason I feel like its good to be prepared to walk away from Stripe / switch providers here, though I think this is on the wrong side of pragmatic Test Plan: - played around with sample client form Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2096
2012-04-05 01:09:29 +02:00
'stripe-core' =>
array(
'uri' => '/res/3b0f0ad4/rsrc/js/stripe/stripe_core.js',
'type' => 'js',
'requires' =>
array(
),
'disk' => '/rsrc/js/stripe/stripe_core.js',
),
'stripe-payment-form-css' =>
array(
Use Celerity to version all static resources Summary: We don't use versioned URIs for images, so when they change users may get old versions. This was a particular issue with the recent logo change, which several users reported cache-related issues from. Instead, use Celerity to manage image URI versions in addition to CSS/JS. This is complicated, because we need to rewrite image URIs inside of CSS, which means the hash of a CSS file has to be derived from the current image data. Otherwise, when we updated an image the CSS wouldn't update, so we wouldn't be any better off. So basically we: - Find all the "raw" files, and put them into the map. - Find all the CSS/JS, perform content-altering transformations on it (i.e., not minification) based on the partial map, and then put it into the map based on transformed hashes. (If we wanted, we could now do CSS variables or whatever for "free", more or less.) Test Plan: - Regenerated celerity map, browsed site, verified images generated with versioned URIs. - Moved "blue" flag image over "green" flag image, regenerated map, verified "green" flag image and the associated CSS changed hashes. - Added transformation unit tests; ran unit tests. Reviewers: btrahan, vrana, jungejason Reviewed By: vrana CC: aran Maniphest Tasks: T1073 Differential Revision: https://secure.phabricator.com/D2146
2012-04-08 19:07:51 +02:00
'uri' => '/res/634a6371/rsrc/css/application/phortune/stripe-payment-form.css',
For discussion -- Stripe integration Summary: various stripe stuff, including - external stripe library - payment form - test controller to play with payment form, sample business logic My main questions / discussion topics are... - is the stripe PHP library too big? (ie should I write something more simple just for phabricator?) -- if its cool, what is the best way to include the client? (ie should I make it a submodule rather than the flat copy here?) - is the JS I wrote (too) ridiculous? -- particularly unhappy with the error message stuff being in JS *but* it seemed the best choice given the most juicy error messages come from the stripe JS such that the overall code complexity is lowest this way. - how should the stripe JS be included? -- flat copy like I did here? -- some sort of external? -- can we just load it off stripe servers at request time? (I like that from the "if stripe is down, stripe is down" perspective) - wasn't sure if the date control was too silly and should just be baked into the form? -- for some reason I feel like its good to be prepared to walk away from Stripe / switch providers here, though I think this is on the wrong side of pragmatic Test Plan: - played around with sample client form Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2096
2012-04-05 01:09:29 +02:00
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/phortune/stripe-payment-form.css',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
'syntax-highlighting-css' =>
array(
'uri' => '/res/5669beb6/rsrc/css/core/syntax.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/core/syntax.css',
),
), array(
'packages' =>
array(
Improve notification list view Summary: - Provide a filter to show just unread notifications. - Visually show which notifications are unread. - Style tweaks to make notifications more readable. Test Plan: {F13494} Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2883
2012-06-28 22:59:50 +02:00
'a05e3ec6' =>
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
array(
'name' => 'core.pkg.css',
'symbols' =>
array(
0 => 'phabricator-core-css',
1 => 'phabricator-core-buttons-css',
2 => 'phabricator-standard-page-view',
3 => 'aphront-dialog-view-css',
4 => 'aphront-form-view-css',
5 => 'aphront-panel-view-css',
6 => 'aphront-side-nav-view-css',
7 => 'aphront-table-view-css',
8 => 'aphront-crumbs-view-css',
9 => 'aphront-tokenizer-control-css',
10 => 'aphront-typeahead-control-css',
11 => 'aphront-list-filter-view-css',
12 => 'phabricator-directory-css',
13 => 'phabricator-jump-nav',
14 => 'phabricator-app-buttons-css',
15 => 'phabricator-remarkup-css',
16 => 'syntax-highlighting-css',
17 => 'aphront-pager-view-css',
18 => 'phabricator-transaction-view-css',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
19 => 'aphront-tooltip-css',
20 => 'aphront-headsup-view-css',
21 => 'phabricator-flag-css',
22 => 'aphront-error-view-css',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
),
Improve notification list view Summary: - Provide a filter to show just unread notifications. - Visually show which notifications are unread. - Style tweaks to make notifications more readable. Test Plan: {F13494} Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2883
2012-06-28 22:59:50 +02:00
'uri' => '/res/pkg/a05e3ec6/core.pkg.css',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
'type' => 'css',
),
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'f363b322' =>
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
array(
'name' => 'core.pkg.js',
'symbols' =>
array(
0 => 'javelin-mask',
1 => 'javelin-workflow',
2 => 'javelin-behavior-workflow',
3 => 'javelin-behavior-aphront-form-disable-on-submit',
4 => 'phabricator-keyboard-shortcut-manager',
5 => 'phabricator-keyboard-shortcut',
6 => 'javelin-behavior-phabricator-keyboard-shortcuts',
7 => 'javelin-behavior-refresh-csrf',
8 => 'javelin-behavior-phabricator-watch-anchor',
9 => 'javelin-behavior-phabricator-autofocus',
10 => 'phabricator-paste-file-upload',
11 => 'phabricator-menu-item',
12 => 'phabricator-dropdown-menu',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
13 => 'javelin-behavior-phabricator-oncopy',
14 => 'phabricator-tooltip',
15 => 'javelin-behavior-phabricator-tooltips',
16 => 'phabricator-prefab',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
),
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'uri' => '/res/pkg/f363b322/core.pkg.js',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
'type' => 'js',
),
Unhighlight lines modified in rebase Summary: Diff of diffs display changes between new versions of file. This is bad after rebase because there can be many unrelated changes so it is hard to spot the real change. This diff unhighlights the lines that were added or removed in rebase. The changes are still visible (they can be sometimes relevant) but very subtle. Test Plan: # Add, change and delete line. Display diff. # Add and change some lines in parent. Rebase. Display diff. Display diff of diff. # Change and add some lines. Display diff. Display diff to first diff. Display diff to second diff. Reviewers: epriestley, jungejason Reviewed By: jungejason CC: jungejason, aran, Korvin Differential Revision: https://secure.phabricator.com/D2761
2012-06-15 09:53:26 +02:00
'96bc37d6' =>
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
array(
'name' => 'differential.pkg.css',
'symbols' =>
array(
0 => 'differential-core-view-css',
1 => 'differential-changeset-view-css',
Further improve unit/lint rendering Summary: I think this improves things, let me know if you have feedback. Also addresses T840. Test Plan: See screenshots... Reviewers: vrana, btrahan, jungejason Reviewed By: vrana CC: aran, zeeg Maniphest Tasks: T840 Differential Revision: https://secure.phabricator.com/D2357
2012-05-01 19:15:56 +02:00
2 => 'differential-results-table-css',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
3 => 'differential-revision-history-css',
4 => 'differential-table-of-contents-css',
5 => 'differential-revision-comment-css',
6 => 'differential-revision-add-comment-css',
7 => 'differential-revision-comment-list-css',
8 => 'phabricator-object-selector-css',
9 => 'aphront-headsup-action-list-view-css',
10 => 'phabricator-content-source-view-css',
11 => 'differential-local-commits-view-css',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
12 => 'inline-comment-summary-css',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
),
Unhighlight lines modified in rebase Summary: Diff of diffs display changes between new versions of file. This is bad after rebase because there can be many unrelated changes so it is hard to spot the real change. This diff unhighlights the lines that were added or removed in rebase. The changes are still visible (they can be sometimes relevant) but very subtle. Test Plan: # Add, change and delete line. Display diff. # Add and change some lines in parent. Rebase. Display diff. Display diff of diff. # Change and add some lines. Display diff. Display diff to first diff. Display diff to second diff. Reviewers: epriestley, jungejason Reviewed By: jungejason CC: jungejason, aran, Korvin Differential Revision: https://secure.phabricator.com/D2761
2012-06-15 09:53:26 +02:00
'uri' => '/res/pkg/96bc37d6/differential.pkg.css',
Add a basic tooltip UI element Summary: There are a few things we can improve with tooltips. Test Plan: Moused over all the stuff on the test page. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T965 Differential Revision: https://secure.phabricator.com/D1870
2012-03-13 02:21:02 +01:00
'type' => 'css',
),
Fix dropdown for file whose diff is not displayable Summary: The current behavior is that, when the dropdown menu is clicked for a binary file, it navigates to the current revision page directly without showing the dropdown meu. The fix is to do nothing when there is no file displayed. Test Plan: - checked a diff with binary file - checked a diff with normal files Reviewers: vrana, epriestley Reviewed By: epriestley CC: epriestley, aran Differential Revision: https://secure.phabricator.com/D2801
2012-06-20 00:56:42 +02:00
'f4bbbd84' =>
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
array(
'name' => 'differential.pkg.js',
'symbols' =>
array(
0 => 'phabricator-drag-and-drop-file-upload',
1 => 'phabricator-shaped-request',
2 => 'javelin-behavior-differential-feedback-preview',
3 => 'javelin-behavior-differential-edit-inline-comments',
4 => 'javelin-behavior-differential-populate',
5 => 'javelin-behavior-differential-show-more',
6 => 'javelin-behavior-differential-diff-radios',
7 => 'javelin-behavior-differential-accept-with-errors',
8 => 'javelin-behavior-differential-comment-jump',
9 => 'javelin-behavior-differential-add-reviewers-and-ccs',
10 => 'javelin-behavior-differential-keyboard-navigation',
11 => 'javelin-behavior-aphront-drag-and-drop',
12 => 'javelin-behavior-aphront-drag-and-drop-textarea',
13 => 'javelin-behavior-phabricator-object-selector',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
14 => 'javelin-behavior-repository-crossreference',
15 => 'differential-inline-comment-editor',
16 => 'javelin-behavior-differential-dropdown-menus',
17 => 'javelin-behavior-buoyant',
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
),
Fix dropdown for file whose diff is not displayable Summary: The current behavior is that, when the dropdown menu is clicked for a binary file, it navigates to the current revision page directly without showing the dropdown meu. The fix is to do nothing when there is no file displayed. Test Plan: - checked a diff with binary file - checked a diff with normal files Reviewers: vrana, epriestley Reviewed By: epriestley CC: epriestley, aran Differential Revision: https://secure.phabricator.com/D2801
2012-06-20 00:56:42 +02:00
'uri' => '/res/pkg/f4bbbd84/differential.pkg.js',
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
'type' => 'js',
),
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'c8ce2d88' =>
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
array(
'name' => 'diffusion.pkg.css',
'symbols' =>
array(
0 => 'diffusion-commit-view-css',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
1 => 'diffusion-icons-css',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
),
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'uri' => '/res/pkg/c8ce2d88/diffusion.pkg.css',
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
'type' => 'css',
),
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'5e68be89' =>
array(
'name' => 'diffusion.pkg.js',
'symbols' =>
array(
0 => 'javelin-behavior-diffusion-pull-lastmodified',
1 => 'javelin-behavior-diffusion-commit-graph',
2 => 'javelin-behavior-audit-preview',
),
'uri' => '/res/pkg/5e68be89/diffusion.pkg.js',
'type' => 'js',
),
Avoid resolving path in celerity resource map Summary: HPHP doesn't like resolved symlinks. Also I like this code better. Test Plan: Used and not used custom Celerity map. Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D2694
2012-06-09 02:14:44 +02:00
'6fb20113' =>
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
array(
'name' => 'javelin.pkg.js',
'symbols' =>
array(
0 => 'javelin-util',
1 => 'javelin-install',
2 => 'javelin-event',
3 => 'javelin-stratcom',
4 => 'javelin-behavior',
5 => 'javelin-request',
6 => 'javelin-vector',
7 => 'javelin-dom',
8 => 'javelin-json',
9 => 'javelin-uri',
),
Avoid resolving path in celerity resource map Summary: HPHP doesn't like resolved symlinks. Also I like this code better. Test Plan: Used and not used custom Celerity map. Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D2694
2012-06-09 02:14:44 +02:00
'uri' => '/res/pkg/6fb20113/javelin.pkg.js',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'type' => 'js',
),
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'7839ae2d' =>
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
array(
'name' => 'maniphest.pkg.css',
'symbols' =>
array(
0 => 'maniphest-task-summary-css',
1 => 'maniphest-transaction-detail-css',
Delete unused CSS Summary: Unused since D2062. Test Plan: View commit. View task. Reviewers: epriestley Reviewed By: epriestley CC: aran Differential Revision: https://secure.phabricator.com/D2108
2012-04-05 19:47:20 +02:00
2 => 'aphront-attached-file-view-css',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
3 => 'phabricator-project-tag-css',
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
),
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'uri' => '/res/pkg/7839ae2d/maniphest.pkg.css',
Allow selecting text when creating inline comment Summary: It is currently not possible to select source code covered by reticle when creating comment. This diff hides reticle on mouseout from reply area. Test Plan: Hover inline comment, verify that reticle is displayed. Reply, verify that reticle is displayed when mouseover reply, hidden otherwise. Repeat for create. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1851
2012-03-10 01:04:25 +01:00
'type' => 'css',
),
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'7707de41' =>
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
array(
'name' => 'maniphest.pkg.js',
'symbols' =>
array(
0 => 'javelin-behavior-maniphest-batch-selector',
1 => 'javelin-behavior-maniphest-transaction-controls',
2 => 'javelin-behavior-maniphest-transaction-preview',
3 => 'javelin-behavior-maniphest-transaction-expand',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
4 => 'javelin-behavior-maniphest-subpriority-editor',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
),
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'uri' => '/res/pkg/7707de41/maniphest.pkg.js',
Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code Summary: - We have three nearly-identical blocks of Tokenizer construction code; consolidate them into Prefab. - Add placeholder support. - Augment server-side stuff to specify placeholder text. Test Plan: Verified behavior of Differential edit tokenizers, Differential comment tokenizers, Maniphest edit tokenizers, Maniphest comment tokenizers, Maniphest filter tokenizers, Differential filter tokenizers, Owners filter tokenizers, Owners edit tokenizers, Herald edit tokenizers, Audit filter tokenizers. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T772, T946 Differential Revision: https://secure.phabricator.com/D1844
2012-03-10 00:46:39 +01:00
'type' => 'js',
),
Indicate buttons disabled in JX.Workflow Summary: We are marking disabled buttons with 'disabled' class in `behavior-form`. But we ignore `JX.Workflow` there because it has its own handling. But this handling doesn't set class so the button is disabled but it is not indicated to user. It causes troubles in Clowncopterize where users report that browser freezes before doing anything after clicking it. It probably happens also on other places. This diff solves it by using CSS3 selector on attribute (contrary to explicitly setting class in JX.Workflow). Test Plan: Add `sleep(3)` to `DifferentialCommentSaveController`. Clowncopterize empty comment. Reviewers: epriestley, tuomaspelkonen Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2264
2012-04-18 07:04:54 +02:00
'97f65640' =>
Added Search Box Preferences Summary: Resolves T989 - users can now disable the '/' keyboard shortcut which focuses the search box - users can now disable the jump nav functionality of the search box Test Plan: - verified that the '/' keyboard shortcut works with preference enabled or unset - verified that '/' no longer has any effect and disappears from keyboard shortcuts help overlay with preference disabled - verified that search boxes have jump nav capabilities with jump nav functionality preference unset or enabled - verified that search boxes do not jump with jump nav preference disabled - verified that the jump nav still works as a jump nav with jump nav preference disabled Reviewers: epriestley Reviewed By: epriestley CC: simpkins, aran, epriestley, vrana Maniphest Tasks: T989 Differential Revision: https://secure.phabricator.com/D1902
2012-03-15 04:47:17 +01:00
array(
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
'name' => 'typeahead.pkg.js',
Added Search Box Preferences Summary: Resolves T989 - users can now disable the '/' keyboard shortcut which focuses the search box - users can now disable the jump nav functionality of the search box Test Plan: - verified that the '/' keyboard shortcut works with preference enabled or unset - verified that '/' no longer has any effect and disappears from keyboard shortcuts help overlay with preference disabled - verified that search boxes have jump nav capabilities with jump nav functionality preference unset or enabled - verified that search boxes do not jump with jump nav preference disabled - verified that the jump nav still works as a jump nav with jump nav preference disabled Reviewers: epriestley Reviewed By: epriestley CC: simpkins, aran, epriestley, vrana Maniphest Tasks: T989 Differential Revision: https://secure.phabricator.com/D1902
2012-03-15 04:47:17 +01:00
'symbols' =>
array(
Stabilize sort in celerity map Summary: Smaller diffs, better blame, less noise on a file which is usually ignored. Less conflicts in merge! Test Plan: php -l __celerity_resource_map__.php Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1909
2012-03-15 06:42:30 +01:00
0 => 'javelin-typeahead',
1 => 'javelin-typeahead-normalizer',
2 => 'javelin-typeahead-source',
3 => 'javelin-typeahead-preloaded-source',
4 => 'javelin-typeahead-ondemand-source',
5 => 'javelin-tokenizer',
6 => 'javelin-behavior-aphront-basic-tokenizer',
Added Search Box Preferences Summary: Resolves T989 - users can now disable the '/' keyboard shortcut which focuses the search box - users can now disable the jump nav functionality of the search box Test Plan: - verified that the '/' keyboard shortcut works with preference enabled or unset - verified that '/' no longer has any effect and disappears from keyboard shortcuts help overlay with preference disabled - verified that search boxes have jump nav capabilities with jump nav functionality preference unset or enabled - verified that search boxes do not jump with jump nav preference disabled - verified that the jump nav still works as a jump nav with jump nav preference disabled Reviewers: epriestley Reviewed By: epriestley CC: simpkins, aran, epriestley, vrana Maniphest Tasks: T989 Differential Revision: https://secure.phabricator.com/D1902
2012-03-15 04:47:17 +01:00
),
Indicate buttons disabled in JX.Workflow Summary: We are marking disabled buttons with 'disabled' class in `behavior-form`. But we ignore `JX.Workflow` there because it has its own handling. But this handling doesn't set class so the button is disabled but it is not indicated to user. It causes troubles in Clowncopterize where users report that browser freezes before doing anything after clicking it. It probably happens also on other places. This diff solves it by using CSS3 selector on attribute (contrary to explicitly setting class in JX.Workflow). Test Plan: Add `sleep(3)` to `DifferentialCommentSaveController`. Clowncopterize empty comment. Reviewers: epriestley, tuomaspelkonen Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2264
2012-04-18 07:04:54 +02:00
'uri' => '/res/pkg/97f65640/typeahead.pkg.js',
Added Search Box Preferences Summary: Resolves T989 - users can now disable the '/' keyboard shortcut which focuses the search box - users can now disable the jump nav functionality of the search box Test Plan: - verified that the '/' keyboard shortcut works with preference enabled or unset - verified that '/' no longer has any effect and disappears from keyboard shortcuts help overlay with preference disabled - verified that search boxes have jump nav capabilities with jump nav functionality preference unset or enabled - verified that search boxes do not jump with jump nav preference disabled - verified that the jump nav still works as a jump nav with jump nav preference disabled Reviewers: epriestley Reviewed By: epriestley CC: simpkins, aran, epriestley, vrana Maniphest Tasks: T989 Differential Revision: https://secure.phabricator.com/D1902
2012-03-15 04:47:17 +01:00
'type' => 'js',
),
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
'reverse' =>
array(
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'aphront-attached-file-view-css' => '7839ae2d',
Improve notification list view Summary: - Provide a filter to show just unread notifications. - Visually show which notifications are unread. - Style tweaks to make notifications more readable. Test Plan: {F13494} Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2883
2012-06-28 22:59:50 +02:00
'aphront-crumbs-view-css' => 'a05e3ec6',
'aphront-dialog-view-css' => 'a05e3ec6',
'aphront-error-view-css' => 'a05e3ec6',
'aphront-form-view-css' => 'a05e3ec6',
Unhighlight lines modified in rebase Summary: Diff of diffs display changes between new versions of file. This is bad after rebase because there can be many unrelated changes so it is hard to spot the real change. This diff unhighlights the lines that were added or removed in rebase. The changes are still visible (they can be sometimes relevant) but very subtle. Test Plan: # Add, change and delete line. Display diff. # Add and change some lines in parent. Rebase. Display diff. Display diff of diff. # Change and add some lines. Display diff. Display diff to first diff. Display diff to second diff. Reviewers: epriestley, jungejason Reviewed By: jungejason CC: jungejason, aran, Korvin Differential Revision: https://secure.phabricator.com/D2761
2012-06-15 09:53:26 +02:00
'aphront-headsup-action-list-view-css' => '96bc37d6',
Improve notification list view Summary: - Provide a filter to show just unread notifications. - Visually show which notifications are unread. - Style tweaks to make notifications more readable. Test Plan: {F13494} Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2883
2012-06-28 22:59:50 +02:00
'aphront-headsup-view-css' => 'a05e3ec6',
'aphront-list-filter-view-css' => 'a05e3ec6',
'aphront-pager-view-css' => 'a05e3ec6',
'aphront-panel-view-css' => 'a05e3ec6',
'aphront-side-nav-view-css' => 'a05e3ec6',
'aphront-table-view-css' => 'a05e3ec6',
'aphront-tokenizer-control-css' => 'a05e3ec6',
'aphront-tooltip-css' => 'a05e3ec6',
'aphront-typeahead-control-css' => 'a05e3ec6',
Unhighlight lines modified in rebase Summary: Diff of diffs display changes between new versions of file. This is bad after rebase because there can be many unrelated changes so it is hard to spot the real change. This diff unhighlights the lines that were added or removed in rebase. The changes are still visible (they can be sometimes relevant) but very subtle. Test Plan: # Add, change and delete line. Display diff. # Add and change some lines in parent. Rebase. Display diff. Display diff of diff. # Change and add some lines. Display diff. Display diff to first diff. Display diff to second diff. Reviewers: epriestley, jungejason Reviewed By: jungejason CC: jungejason, aran, Korvin Differential Revision: https://secure.phabricator.com/D2761
2012-06-15 09:53:26 +02:00
'differential-changeset-view-css' => '96bc37d6',
'differential-core-view-css' => '96bc37d6',
Fix dropdown for file whose diff is not displayable Summary: The current behavior is that, when the dropdown menu is clicked for a binary file, it navigates to the current revision page directly without showing the dropdown meu. The fix is to do nothing when there is no file displayed. Test Plan: - checked a diff with binary file - checked a diff with normal files Reviewers: vrana, epriestley Reviewed By: epriestley CC: epriestley, aran Differential Revision: https://secure.phabricator.com/D2801
2012-06-20 00:56:42 +02:00
'differential-inline-comment-editor' => 'f4bbbd84',
Unhighlight lines modified in rebase Summary: Diff of diffs display changes between new versions of file. This is bad after rebase because there can be many unrelated changes so it is hard to spot the real change. This diff unhighlights the lines that were added or removed in rebase. The changes are still visible (they can be sometimes relevant) but very subtle. Test Plan: # Add, change and delete line. Display diff. # Add and change some lines in parent. Rebase. Display diff. Display diff of diff. # Change and add some lines. Display diff. Display diff to first diff. Display diff to second diff. Reviewers: epriestley, jungejason Reviewed By: jungejason CC: jungejason, aran, Korvin Differential Revision: https://secure.phabricator.com/D2761
2012-06-15 09:53:26 +02:00
'differential-local-commits-view-css' => '96bc37d6',
'differential-results-table-css' => '96bc37d6',
'differential-revision-add-comment-css' => '96bc37d6',
'differential-revision-comment-css' => '96bc37d6',
'differential-revision-comment-list-css' => '96bc37d6',
'differential-revision-history-css' => '96bc37d6',
'differential-table-of-contents-css' => '96bc37d6',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88',
Unhighlight lines modified in rebase Summary: Diff of diffs display changes between new versions of file. This is bad after rebase because there can be many unrelated changes so it is hard to spot the real change. This diff unhighlights the lines that were added or removed in rebase. The changes are still visible (they can be sometimes relevant) but very subtle. Test Plan: # Add, change and delete line. Display diff. # Add and change some lines in parent. Rebase. Display diff. Display diff of diff. # Change and add some lines. Display diff. Display diff to first diff. Display diff to second diff. Reviewers: epriestley, jungejason Reviewed By: jungejason CC: jungejason, aran, Korvin Differential Revision: https://secure.phabricator.com/D2761
2012-06-15 09:53:26 +02:00
'inline-comment-summary-css' => '96bc37d6',
Avoid resolving path in celerity resource map Summary: HPHP doesn't like resolved symlinks. Also I like this code better. Test Plan: Used and not used custom Celerity map. Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D2694
2012-06-09 02:14:44 +02:00
'javelin-behavior' => '6fb20113',
Indicate buttons disabled in JX.Workflow Summary: We are marking disabled buttons with 'disabled' class in `behavior-form`. But we ignore `JX.Workflow` there because it has its own handling. But this handling doesn't set class so the button is disabled but it is not indicated to user. It causes troubles in Clowncopterize where users report that browser freezes before doing anything after clicking it. It probably happens also on other places. This diff solves it by using CSS3 selector on attribute (contrary to explicitly setting class in JX.Workflow). Test Plan: Add `sleep(3)` to `DifferentialCommentSaveController`. Clowncopterize empty comment. Reviewers: epriestley, tuomaspelkonen Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2264
2012-04-18 07:04:54 +02:00
'javelin-behavior-aphront-basic-tokenizer' => '97f65640',
Fix dropdown for file whose diff is not displayable Summary: The current behavior is that, when the dropdown menu is clicked for a binary file, it navigates to the current revision page directly without showing the dropdown meu. The fix is to do nothing when there is no file displayed. Test Plan: - checked a diff with binary file - checked a diff with normal files Reviewers: vrana, epriestley Reviewed By: epriestley CC: epriestley, aran Differential Revision: https://secure.phabricator.com/D2801
2012-06-20 00:56:42 +02:00
'javelin-behavior-aphront-drag-and-drop' => 'f4bbbd84',
'javelin-behavior-aphront-drag-and-drop-textarea' => 'f4bbbd84',
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'javelin-behavior-aphront-form-disable-on-submit' => 'f363b322',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'javelin-behavior-audit-preview' => '5e68be89',
Fix dropdown for file whose diff is not displayable Summary: The current behavior is that, when the dropdown menu is clicked for a binary file, it navigates to the current revision page directly without showing the dropdown meu. The fix is to do nothing when there is no file displayed. Test Plan: - checked a diff with binary file - checked a diff with normal files Reviewers: vrana, epriestley Reviewed By: epriestley CC: epriestley, aran Differential Revision: https://secure.phabricator.com/D2801
2012-06-20 00:56:42 +02:00
'javelin-behavior-buoyant' => 'f4bbbd84',
'javelin-behavior-differential-accept-with-errors' => 'f4bbbd84',
'javelin-behavior-differential-add-reviewers-and-ccs' => 'f4bbbd84',
'javelin-behavior-differential-comment-jump' => 'f4bbbd84',
'javelin-behavior-differential-diff-radios' => 'f4bbbd84',
'javelin-behavior-differential-dropdown-menus' => 'f4bbbd84',
'javelin-behavior-differential-edit-inline-comments' => 'f4bbbd84',
'javelin-behavior-differential-feedback-preview' => 'f4bbbd84',
'javelin-behavior-differential-keyboard-navigation' => 'f4bbbd84',
'javelin-behavior-differential-populate' => 'f4bbbd84',
'javelin-behavior-differential-show-more' => 'f4bbbd84',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'javelin-behavior-diffusion-commit-graph' => '5e68be89',
'javelin-behavior-diffusion-pull-lastmodified' => '5e68be89',
'javelin-behavior-maniphest-batch-selector' => '7707de41',
'javelin-behavior-maniphest-subpriority-editor' => '7707de41',
'javelin-behavior-maniphest-transaction-controls' => '7707de41',
'javelin-behavior-maniphest-transaction-expand' => '7707de41',
'javelin-behavior-maniphest-transaction-preview' => '7707de41',
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'javelin-behavior-phabricator-autofocus' => 'f363b322',
'javelin-behavior-phabricator-keyboard-shortcuts' => 'f363b322',
Fix dropdown for file whose diff is not displayable Summary: The current behavior is that, when the dropdown menu is clicked for a binary file, it navigates to the current revision page directly without showing the dropdown meu. The fix is to do nothing when there is no file displayed. Test Plan: - checked a diff with binary file - checked a diff with normal files Reviewers: vrana, epriestley Reviewed By: epriestley CC: epriestley, aran Differential Revision: https://secure.phabricator.com/D2801
2012-06-20 00:56:42 +02:00
'javelin-behavior-phabricator-object-selector' => 'f4bbbd84',
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'javelin-behavior-phabricator-oncopy' => 'f363b322',
'javelin-behavior-phabricator-tooltips' => 'f363b322',
'javelin-behavior-phabricator-watch-anchor' => 'f363b322',
'javelin-behavior-refresh-csrf' => 'f363b322',
Fix dropdown for file whose diff is not displayable Summary: The current behavior is that, when the dropdown menu is clicked for a binary file, it navigates to the current revision page directly without showing the dropdown meu. The fix is to do nothing when there is no file displayed. Test Plan: - checked a diff with binary file - checked a diff with normal files Reviewers: vrana, epriestley Reviewed By: epriestley CC: epriestley, aran Differential Revision: https://secure.phabricator.com/D2801
2012-06-20 00:56:42 +02:00
'javelin-behavior-repository-crossreference' => 'f4bbbd84',
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'javelin-behavior-workflow' => 'f363b322',
Avoid resolving path in celerity resource map Summary: HPHP doesn't like resolved symlinks. Also I like this code better. Test Plan: Used and not used custom Celerity map. Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D2694
2012-06-09 02:14:44 +02:00
'javelin-dom' => '6fb20113',
'javelin-event' => '6fb20113',
'javelin-install' => '6fb20113',
'javelin-json' => '6fb20113',
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'javelin-mask' => 'f363b322',
Avoid resolving path in celerity resource map Summary: HPHP doesn't like resolved symlinks. Also I like this code better. Test Plan: Used and not used custom Celerity map. Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D2694
2012-06-09 02:14:44 +02:00
'javelin-request' => '6fb20113',
'javelin-stratcom' => '6fb20113',
Indicate buttons disabled in JX.Workflow Summary: We are marking disabled buttons with 'disabled' class in `behavior-form`. But we ignore `JX.Workflow` there because it has its own handling. But this handling doesn't set class so the button is disabled but it is not indicated to user. It causes troubles in Clowncopterize where users report that browser freezes before doing anything after clicking it. It probably happens also on other places. This diff solves it by using CSS3 selector on attribute (contrary to explicitly setting class in JX.Workflow). Test Plan: Add `sleep(3)` to `DifferentialCommentSaveController`. Clowncopterize empty comment. Reviewers: epriestley, tuomaspelkonen Reviewed By: epriestley CC: aran, Koolvin Differential Revision: https://secure.phabricator.com/D2264
2012-04-18 07:04:54 +02:00
'javelin-tokenizer' => '97f65640',
'javelin-typeahead' => '97f65640',
'javelin-typeahead-normalizer' => '97f65640',
'javelin-typeahead-ondemand-source' => '97f65640',
'javelin-typeahead-preloaded-source' => '97f65640',
'javelin-typeahead-source' => '97f65640',
Avoid resolving path in celerity resource map Summary: HPHP doesn't like resolved symlinks. Also I like this code better. Test Plan: Used and not used custom Celerity map. Reviewers: epriestley, nh Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D2694
2012-06-09 02:14:44 +02:00
'javelin-uri' => '6fb20113',
'javelin-util' => '6fb20113',
'javelin-vector' => '6fb20113',
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'javelin-workflow' => 'f363b322',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'maniphest-task-summary-css' => '7839ae2d',
'maniphest-transaction-detail-css' => '7839ae2d',
Improve notification list view Summary: - Provide a filter to show just unread notifications. - Visually show which notifications are unread. - Style tweaks to make notifications more readable. Test Plan: {F13494} Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2883
2012-06-28 22:59:50 +02:00
'phabricator-app-buttons-css' => 'a05e3ec6',
Unhighlight lines modified in rebase Summary: Diff of diffs display changes between new versions of file. This is bad after rebase because there can be many unrelated changes so it is hard to spot the real change. This diff unhighlights the lines that were added or removed in rebase. The changes are still visible (they can be sometimes relevant) but very subtle. Test Plan: # Add, change and delete line. Display diff. # Add and change some lines in parent. Rebase. Display diff. Display diff of diff. # Change and add some lines. Display diff. Display diff to first diff. Display diff to second diff. Reviewers: epriestley, jungejason Reviewed By: jungejason CC: jungejason, aran, Korvin Differential Revision: https://secure.phabricator.com/D2761
2012-06-15 09:53:26 +02:00
'phabricator-content-source-view-css' => '96bc37d6',
Improve notification list view Summary: - Provide a filter to show just unread notifications. - Visually show which notifications are unread. - Style tweaks to make notifications more readable. Test Plan: {F13494} Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2883
2012-06-28 22:59:50 +02:00
'phabricator-core-buttons-css' => 'a05e3ec6',
'phabricator-core-css' => 'a05e3ec6',
'phabricator-directory-css' => 'a05e3ec6',
Fix dropdown for file whose diff is not displayable Summary: The current behavior is that, when the dropdown menu is clicked for a binary file, it navigates to the current revision page directly without showing the dropdown meu. The fix is to do nothing when there is no file displayed. Test Plan: - checked a diff with binary file - checked a diff with normal files Reviewers: vrana, epriestley Reviewed By: epriestley CC: epriestley, aran Differential Revision: https://secure.phabricator.com/D2801
2012-06-20 00:56:42 +02:00
'phabricator-drag-and-drop-file-upload' => 'f4bbbd84',
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'phabricator-dropdown-menu' => 'f363b322',
Improve notification list view Summary: - Provide a filter to show just unread notifications. - Visually show which notifications are unread. - Style tweaks to make notifications more readable. Test Plan: {F13494} Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2883
2012-06-28 22:59:50 +02:00
'phabricator-flag-css' => 'a05e3ec6',
'phabricator-jump-nav' => 'a05e3ec6',
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'phabricator-keyboard-shortcut' => 'f363b322',
'phabricator-keyboard-shortcut-manager' => 'f363b322',
'phabricator-menu-item' => 'f363b322',
Unhighlight lines modified in rebase Summary: Diff of diffs display changes between new versions of file. This is bad after rebase because there can be many unrelated changes so it is hard to spot the real change. This diff unhighlights the lines that were added or removed in rebase. The changes are still visible (they can be sometimes relevant) but very subtle. Test Plan: # Add, change and delete line. Display diff. # Add and change some lines in parent. Rebase. Display diff. Display diff of diff. # Change and add some lines. Display diff. Display diff to first diff. Display diff to second diff. Reviewers: epriestley, jungejason Reviewed By: jungejason CC: jungejason, aran, Korvin Differential Revision: https://secure.phabricator.com/D2761
2012-06-15 09:53:26 +02:00
'phabricator-object-selector-css' => '96bc37d6',
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'phabricator-paste-file-upload' => 'f363b322',
'phabricator-prefab' => 'f363b322',
Update package definitions Summary: So much Javascript. :( Test Plan: Verified major Diffusion, Differential, Maniphest interfaces pull in no unpackaged CSS/JS. Rebuilt Celerity map. Reviewers: btrahan, vrana, jungejason Reviewed By: jungejason CC: aran Differential Revision: https://secure.phabricator.com/D2248
2012-04-17 02:51:30 +02:00
'phabricator-project-tag-css' => '7839ae2d',
Improve notification list view Summary: - Provide a filter to show just unread notifications. - Visually show which notifications are unread. - Style tweaks to make notifications more readable. Test Plan: {F13494} Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2883
2012-06-28 22:59:50 +02:00
'phabricator-remarkup-css' => 'a05e3ec6',
Fix dropdown for file whose diff is not displayable Summary: The current behavior is that, when the dropdown menu is clicked for a binary file, it navigates to the current revision page directly without showing the dropdown meu. The fix is to do nothing when there is no file displayed. Test Plan: - checked a diff with binary file - checked a diff with normal files Reviewers: vrana, epriestley Reviewed By: epriestley CC: epriestley, aran Differential Revision: https://secure.phabricator.com/D2801
2012-06-20 00:56:42 +02:00
'phabricator-shaped-request' => 'f4bbbd84',
Improve notification list view Summary: - Provide a filter to show just unread notifications. - Visually show which notifications are unread. - Style tweaks to make notifications more readable. Test Plan: {F13494} Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2883
2012-06-28 22:59:50 +02:00
'phabricator-standard-page-view' => 'a05e3ec6',
Prevent Firebug from crashing in Firefox 13 / Window 7 Summary: Simpler fix for D2572. Not entirely sure why Firebug is crashing Firefox. It appears to be callstack depth related, possibly? You can sort of reproduce this like this: >>> var f = function(n) { n && f(n - 1); } >>> f(10000); // Takes a few ms to run. >>> f(40000); // Takes a few ms to run. >>> f(50000); // Hangs Firefox. If there are 2,000 files, we currently hit a stack depth of around 4,000 with the pass() rules, so it seems like we should be 10x short of exploding. Anyway, this keeps us from increasing stack depth for menus that aren't currently open and stops Firebug from crashing. Test Plan: Clicked 2000-diff revision in Firefox. Reviewers: vrana Reviewed By: vrana CC: aran Differential Revision: https://secure.phabricator.com/D2870
2012-06-27 03:22:53 +02:00
'phabricator-tooltip' => 'f363b322',
Improve notification list view Summary: - Provide a filter to show just unread notifications. - Visually show which notifications are unread. - Style tweaks to make notifications more readable. Test Plan: {F13494} Reviewers: btrahan, jungejason Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D2883
2012-06-28 22:59:50 +02:00
'phabricator-transaction-view-css' => 'a05e3ec6',
'syntax-highlighting-css' => 'a05e3ec6',
Undelete celerity map Summary: Deleted by rP460efc448932279727928f46b892f433fd277928 Test Plan: View any page Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1317
2012-01-05 02:10:34 +01:00
),
));
Copy permalink