2011-06-30 01:16:33 +02:00
|
|
|
<?php
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Query tasks by specific criteria. This class uses the higher-performance
|
|
|
|
* but less-general Maniphest indexes to satisfy queries.
|
|
|
|
*/
|
2014-07-10 00:12:48 +02:00
|
|
|
final class ManiphestTaskQuery extends PhabricatorCursorPagedPolicyAwareQuery {
|
2011-06-30 01:16:33 +02:00
|
|
|
|
2013-04-04 19:29:40 +02:00
|
|
|
private $taskIDs = array();
|
|
|
|
private $taskPHIDs = array();
|
|
|
|
private $authorPHIDs = array();
|
|
|
|
private $ownerPHIDs = array();
|
|
|
|
private $includeUnowned = null;
|
|
|
|
private $projectPHIDs = array();
|
|
|
|
private $xprojectPHIDs = array();
|
|
|
|
private $subscriberPHIDs = array();
|
|
|
|
private $anyProjectPHIDs = array();
|
|
|
|
private $anyUserProjectPHIDs = array();
|
|
|
|
private $includeNoProject = null;
|
2013-09-12 22:03:39 +02:00
|
|
|
private $dateCreatedAfter;
|
|
|
|
private $dateCreatedBefore;
|
2014-03-17 23:53:07 +01:00
|
|
|
private $dateModifiedAfter;
|
|
|
|
private $dateModifiedBefore;
|
2011-06-30 01:16:33 +02:00
|
|
|
|
2012-06-15 23:09:49 +02:00
|
|
|
private $fullTextSearch = '';
|
|
|
|
|
2011-06-30 01:16:33 +02:00
|
|
|
private $status = 'status-any';
|
|
|
|
const STATUS_ANY = 'status-any';
|
|
|
|
const STATUS_OPEN = 'status-open';
|
|
|
|
const STATUS_CLOSED = 'status-closed';
|
2012-06-29 18:17:19 +02:00
|
|
|
const STATUS_RESOLVED = 'status-resolved';
|
|
|
|
const STATUS_WONTFIX = 'status-wontfix';
|
|
|
|
const STATUS_INVALID = 'status-invalid';
|
|
|
|
const STATUS_SPITE = 'status-spite';
|
|
|
|
const STATUS_DUPLICATE = 'status-duplicate';
|
2011-06-30 01:16:33 +02:00
|
|
|
|
2013-09-10 20:07:34 +02:00
|
|
|
private $statuses;
|
2013-09-10 20:54:17 +02:00
|
|
|
private $priorities;
|
2015-03-26 19:11:23 +01:00
|
|
|
private $subpriorities;
|
2011-06-30 01:16:33 +02:00
|
|
|
|
|
|
|
private $groupBy = 'group-none';
|
|
|
|
const GROUP_NONE = 'group-none';
|
|
|
|
const GROUP_PRIORITY = 'group-priority';
|
|
|
|
const GROUP_OWNER = 'group-owner';
|
|
|
|
const GROUP_STATUS = 'group-status';
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
const GROUP_PROJECT = 'group-project';
|
2011-06-30 01:16:33 +02:00
|
|
|
|
|
|
|
private $orderBy = 'order-modified';
|
|
|
|
const ORDER_PRIORITY = 'order-priority';
|
|
|
|
const ORDER_CREATED = 'order-created';
|
|
|
|
const ORDER_MODIFIED = 'order-modified';
|
2012-08-02 23:21:13 +02:00
|
|
|
const ORDER_TITLE = 'order-title';
|
2011-06-30 01:16:33 +02:00
|
|
|
|
2014-12-11 01:27:30 +01:00
|
|
|
private $needSubscriberPHIDs;
|
2014-12-18 22:53:45 +01:00
|
|
|
private $needProjectPHIDs;
|
2015-01-12 22:42:37 +01:00
|
|
|
private $blockingTasks;
|
|
|
|
private $blockedTasks;
|
2015-02-03 22:53:35 +01:00
|
|
|
private $projectPolicyCheckFailed = false;
|
|
|
|
|
2011-06-30 01:16:33 +02:00
|
|
|
public function withAuthors(array $authors) {
|
|
|
|
$this->authorPHIDs = $authors;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2013-07-21 21:05:28 +02:00
|
|
|
public function withIDs(array $ids) {
|
2013-07-25 02:31:49 +02:00
|
|
|
$this->taskIDs = $ids;
|
2013-07-21 21:05:28 +02:00
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function withPHIDs(array $phids) {
|
|
|
|
$this->taskPHIDs = $phids;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-06-30 01:16:33 +02:00
|
|
|
public function withOwners(array $owners) {
|
|
|
|
$this->includeUnowned = false;
|
|
|
|
foreach ($owners as $k => $phid) {
|
2013-05-27 22:32:46 +02:00
|
|
|
if ($phid == ManiphestTaskOwner::OWNER_UP_FOR_GRABS || $phid === null) {
|
2011-06-30 01:16:33 +02:00
|
|
|
$this->includeUnowned = true;
|
|
|
|
unset($owners[$k]);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
$this->ownerPHIDs = $owners;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2012-10-05 00:31:04 +02:00
|
|
|
public function withAllProjects(array $projects) {
|
2012-02-29 06:08:02 +01:00
|
|
|
$this->includeNoProject = false;
|
|
|
|
foreach ($projects as $k => $phid) {
|
|
|
|
if ($phid == ManiphestTaskOwner::PROJECT_NO_PROJECT) {
|
|
|
|
$this->includeNoProject = true;
|
|
|
|
unset($projects[$k]);
|
|
|
|
}
|
|
|
|
}
|
2011-06-30 01:16:33 +02:00
|
|
|
$this->projectPHIDs = $projects;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2014-05-20 20:42:05 +02:00
|
|
|
/**
|
|
|
|
* Add an additional "all projects" constraint to existing filters.
|
|
|
|
*
|
|
|
|
* This is used by boards to supplement queries.
|
|
|
|
*
|
2014-07-23 02:03:09 +02:00
|
|
|
* @param list<phid> List of project PHIDs to add to any existing constraint.
|
2014-05-20 20:42:05 +02:00
|
|
|
* @return this
|
|
|
|
*/
|
|
|
|
public function addWithAllProjects(array $projects) {
|
|
|
|
if ($this->projectPHIDs === null) {
|
|
|
|
$this->projectPHIDs = array();
|
|
|
|
}
|
|
|
|
|
|
|
|
return $this->withAllProjects(array_merge($this->projectPHIDs, $projects));
|
|
|
|
}
|
|
|
|
|
2012-02-29 06:08:02 +01:00
|
|
|
public function withoutProjects(array $projects) {
|
|
|
|
$this->xprojectPHIDs = $projects;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-06-30 01:16:33 +02:00
|
|
|
public function withStatus($status) {
|
|
|
|
$this->status = $status;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2013-09-10 20:07:34 +02:00
|
|
|
public function withStatuses(array $statuses) {
|
|
|
|
$this->statuses = $statuses;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2013-09-10 20:54:17 +02:00
|
|
|
public function withPriorities(array $priorities) {
|
|
|
|
$this->priorities = $priorities;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2015-03-26 19:11:23 +01:00
|
|
|
public function withSubpriorities(array $subpriorities) {
|
|
|
|
$this->subpriorities = $subpriorities;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-07-07 19:24:49 +02:00
|
|
|
public function withSubscribers(array $subscribers) {
|
|
|
|
$this->subscriberPHIDs = $subscribers;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2012-06-15 23:09:49 +02:00
|
|
|
public function withFullTextSearch($fulltext_search) {
|
|
|
|
$this->fullTextSearch = $fulltext_search;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-06-30 01:16:33 +02:00
|
|
|
public function setGroupBy($group) {
|
|
|
|
$this->groupBy = $group;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setOrderBy($order) {
|
|
|
|
$this->orderBy = $order;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2012-10-05 00:30:51 +02:00
|
|
|
public function withAnyProjects(array $projects) {
|
|
|
|
$this->anyProjectPHIDs = $projects;
|
2011-07-07 22:50:56 +02:00
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2013-04-04 19:29:40 +02:00
|
|
|
public function withAnyUserProjects(array $users) {
|
|
|
|
$this->anyUserProjectPHIDs = $users;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2015-01-12 22:42:37 +01:00
|
|
|
/**
|
|
|
|
* True returns tasks that are blocking other tasks only.
|
|
|
|
* False returns tasks that are not blocking other tasks only.
|
|
|
|
* Null returns tasks regardless of blocking status.
|
|
|
|
*/
|
|
|
|
public function withBlockingTasks($mode) {
|
|
|
|
$this->blockingTasks = $mode;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function shouldJoinBlockingTasks() {
|
|
|
|
return $this->blockingTasks !== null;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* True returns tasks that are blocked by other tasks only.
|
|
|
|
* False returns tasks that are not blocked by other tasks only.
|
|
|
|
* Null returns tasks regardless of blocked by status.
|
|
|
|
*/
|
|
|
|
public function withBlockedTasks($mode) {
|
|
|
|
$this->blockedTasks = $mode;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function shouldJoinBlockedTasks() {
|
|
|
|
return $this->blockedTasks !== null;
|
|
|
|
}
|
|
|
|
|
2013-09-12 22:03:39 +02:00
|
|
|
public function withDateCreatedBefore($date_created_before) {
|
|
|
|
$this->dateCreatedBefore = $date_created_before;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function withDateCreatedAfter($date_created_after) {
|
|
|
|
$this->dateCreatedAfter = $date_created_after;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2014-03-17 23:53:07 +01:00
|
|
|
public function withDateModifiedBefore($date_modified_before) {
|
|
|
|
$this->dateModifiedBefore = $date_modified_before;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function withDateModifiedAfter($date_modified_after) {
|
|
|
|
$this->dateModifiedAfter = $date_modified_after;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2014-12-11 01:27:30 +01:00
|
|
|
public function needSubscriberPHIDs($bool) {
|
|
|
|
$this->needSubscriberPHIDs = $bool;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2014-12-18 22:53:45 +01:00
|
|
|
public function needProjectPHIDs($bool) {
|
|
|
|
$this->needProjectPHIDs = $bool;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2015-04-12 22:01:21 +02:00
|
|
|
protected function newResultObject() {
|
|
|
|
return new ManiphestTask();
|
|
|
|
}
|
|
|
|
|
2015-02-03 22:53:35 +01:00
|
|
|
protected function willExecute() {
|
|
|
|
// Make sure the user can see any projects specified in this
|
|
|
|
// query FIRST.
|
|
|
|
if ($this->projectPHIDs) {
|
|
|
|
$projects = id(new PhabricatorProjectQuery())
|
|
|
|
->setViewer($this->getViewer())
|
|
|
|
->withPHIDs($this->projectPHIDs)
|
|
|
|
->execute();
|
|
|
|
$projects = mpull($projects, null, 'getPHID');
|
|
|
|
foreach ($this->projectPHIDs as $index => $phid) {
|
|
|
|
$project = idx($projects, $phid);
|
|
|
|
if (!$project) {
|
|
|
|
unset($this->projectPHIDs[$index]);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (!$this->projectPHIDs) {
|
|
|
|
$this->projectPolicyCheckFailed = true;
|
|
|
|
}
|
|
|
|
$this->projectPHIDs = array_values($this->projectPHIDs);
|
|
|
|
}
|
2015-04-12 22:01:21 +02:00
|
|
|
|
|
|
|
// If we already have an order vector, use it as provided.
|
|
|
|
// TODO: This is a messy hack to make setOrderVector() stronger than
|
|
|
|
// setPriority().
|
|
|
|
$vector = $this->getOrderVector();
|
|
|
|
$keys = mpull(iterator_to_array($vector), 'getOrderKey');
|
|
|
|
if (array_values($keys) !== array('id')) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
$parts = array();
|
|
|
|
switch ($this->groupBy) {
|
|
|
|
case self::GROUP_NONE:
|
|
|
|
break;
|
|
|
|
case self::GROUP_PRIORITY:
|
|
|
|
$parts[] = array('priority');
|
|
|
|
break;
|
|
|
|
case self::GROUP_OWNER:
|
|
|
|
$parts[] = array('owner');
|
|
|
|
break;
|
|
|
|
case self::GROUP_STATUS:
|
|
|
|
$parts[] = array('status');
|
|
|
|
break;
|
|
|
|
case self::GROUP_PROJECT:
|
|
|
|
$parts[] = array('project');
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($this->applicationSearchOrders) {
|
|
|
|
$columns = array();
|
|
|
|
foreach ($this->applicationSearchOrders as $order) {
|
|
|
|
$part = 'custom:'.$order['key'];
|
|
|
|
if ($order['ascending']) {
|
|
|
|
$part = '-'.$part;
|
|
|
|
}
|
|
|
|
$columns[] = $part;
|
|
|
|
}
|
|
|
|
$columns[] = 'id';
|
|
|
|
$parts[] = $columns;
|
|
|
|
} else {
|
|
|
|
switch ($this->orderBy) {
|
|
|
|
case self::ORDER_PRIORITY:
|
|
|
|
$parts[] = array('priority', 'subpriority', 'id');
|
|
|
|
break;
|
|
|
|
case self::ORDER_CREATED:
|
|
|
|
$parts[] = array('id');
|
|
|
|
break;
|
|
|
|
case self::ORDER_MODIFIED:
|
|
|
|
$parts[] = array('updated', 'id');
|
|
|
|
break;
|
|
|
|
case self::ORDER_TITLE:
|
|
|
|
$parts[] = array('title', 'id');
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
$parts = array_mergev($parts);
|
|
|
|
// We may have a duplicate column if we are both ordering and grouping
|
|
|
|
// by priority.
|
|
|
|
$parts = array_unique($parts);
|
|
|
|
$this->setOrderVector($parts);
|
2015-02-03 22:53:35 +01:00
|
|
|
}
|
|
|
|
|
2015-01-13 20:56:07 +01:00
|
|
|
protected function loadPage() {
|
2015-02-03 22:53:35 +01:00
|
|
|
|
|
|
|
if ($this->projectPolicyCheckFailed) {
|
|
|
|
throw new PhabricatorEmptyQueryException();
|
|
|
|
}
|
2013-09-12 22:03:14 +02:00
|
|
|
|
2011-06-30 01:16:33 +02:00
|
|
|
$task_dao = new ManiphestTask();
|
|
|
|
$conn = $task_dao->establishConnection('r');
|
|
|
|
|
|
|
|
$where = array();
|
2011-12-02 16:30:20 +01:00
|
|
|
$where[] = $this->buildTaskIDsWhereClause($conn);
|
2012-11-01 18:47:45 +01:00
|
|
|
$where[] = $this->buildTaskPHIDsWhereClause($conn);
|
2011-06-30 01:16:33 +02:00
|
|
|
$where[] = $this->buildStatusWhereClause($conn);
|
2013-09-10 20:07:34 +02:00
|
|
|
$where[] = $this->buildStatusesWhereClause($conn);
|
2015-01-12 22:42:37 +01:00
|
|
|
$where[] = $this->buildDependenciesWhereClause($conn);
|
2011-06-30 01:16:33 +02:00
|
|
|
$where[] = $this->buildAuthorWhereClause($conn);
|
|
|
|
$where[] = $this->buildOwnerWhereClause($conn);
|
|
|
|
$where[] = $this->buildProjectWhereClause($conn);
|
2012-10-05 00:30:51 +02:00
|
|
|
$where[] = $this->buildAnyProjectWhereClause($conn);
|
2013-04-04 19:29:40 +02:00
|
|
|
$where[] = $this->buildAnyUserProjectWhereClause($conn);
|
2012-02-29 06:08:02 +01:00
|
|
|
$where[] = $this->buildXProjectWhereClause($conn);
|
2012-06-15 23:09:49 +02:00
|
|
|
$where[] = $this->buildFullTextWhereClause($conn);
|
2011-06-30 01:16:33 +02:00
|
|
|
|
2013-09-12 22:03:39 +02:00
|
|
|
if ($this->dateCreatedAfter) {
|
|
|
|
$where[] = qsprintf(
|
|
|
|
$conn,
|
2014-07-21 15:44:35 +02:00
|
|
|
'task.dateCreated >= %d',
|
2013-09-12 22:03:39 +02:00
|
|
|
$this->dateCreatedAfter);
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($this->dateCreatedBefore) {
|
|
|
|
$where[] = qsprintf(
|
|
|
|
$conn,
|
2014-07-21 15:44:35 +02:00
|
|
|
'task.dateCreated <= %d',
|
2013-09-12 22:03:39 +02:00
|
|
|
$this->dateCreatedBefore);
|
|
|
|
}
|
|
|
|
|
2014-03-17 23:53:07 +01:00
|
|
|
if ($this->dateModifiedAfter) {
|
|
|
|
$where[] = qsprintf(
|
|
|
|
$conn,
|
2014-07-21 15:44:35 +02:00
|
|
|
'task.dateModified >= %d',
|
2014-03-17 23:53:07 +01:00
|
|
|
$this->dateModifiedAfter);
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($this->dateModifiedBefore) {
|
|
|
|
$where[] = qsprintf(
|
|
|
|
$conn,
|
2014-07-21 15:44:35 +02:00
|
|
|
'task.dateModified <= %d',
|
2014-03-17 23:53:07 +01:00
|
|
|
$this->dateModifiedBefore);
|
|
|
|
}
|
|
|
|
|
2015-04-12 22:01:21 +02:00
|
|
|
if ($this->priorities) {
|
|
|
|
$where[] = qsprintf(
|
|
|
|
$conn,
|
|
|
|
'task.priority IN (%Ld)',
|
|
|
|
$this->priorities);
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($this->subpriorities) {
|
|
|
|
$where[] = qsprintf(
|
|
|
|
$conn,
|
|
|
|
'task.subpriority IN (%Lf)',
|
|
|
|
$this->subpriorities);
|
|
|
|
}
|
|
|
|
|
2013-09-13 16:13:06 +02:00
|
|
|
$where[] = $this->buildPagingClause($conn);
|
|
|
|
|
2012-10-05 00:30:51 +02:00
|
|
|
$where = $this->formatWhereClause($where);
|
2011-06-30 01:16:33 +02:00
|
|
|
|
|
|
|
$having = '';
|
|
|
|
$count = '';
|
2011-07-07 22:50:56 +02:00
|
|
|
|
2012-10-05 00:30:51 +02:00
|
|
|
if (count($this->projectPHIDs) > 1) {
|
|
|
|
// We want to treat the query as an intersection query, not a union
|
|
|
|
// query. We sum the project count and require it be the same as the
|
|
|
|
// number of projects we're searching for.
|
|
|
|
|
2014-07-18 00:42:30 +02:00
|
|
|
$count = ', COUNT(project.dst) projectCount';
|
2012-10-05 00:30:51 +02:00
|
|
|
$having = qsprintf(
|
|
|
|
$conn,
|
|
|
|
'HAVING projectCount = %d',
|
|
|
|
count($this->projectPHIDs));
|
2011-06-30 01:16:33 +02:00
|
|
|
}
|
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
$group_column = '';
|
|
|
|
switch ($this->groupBy) {
|
|
|
|
case self::GROUP_PROJECT:
|
|
|
|
$group_column = qsprintf(
|
|
|
|
$conn,
|
|
|
|
', projectGroupName.indexedObjectPHID projectGroupPHID');
|
|
|
|
break;
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
}
|
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
$rows = queryfx_all(
|
2011-06-30 01:16:33 +02:00
|
|
|
$conn,
|
2013-09-25 22:44:36 +02:00
|
|
|
'SELECT task.* %Q %Q FROM %T task %Q %Q %Q %Q %Q %Q',
|
2011-06-30 01:16:33 +02:00
|
|
|
$count,
|
2013-09-12 22:08:25 +02:00
|
|
|
$group_column,
|
2011-06-30 01:16:33 +02:00
|
|
|
$task_dao->getTableName(),
|
2013-09-12 22:08:25 +02:00
|
|
|
$this->buildJoinsClause($conn),
|
2011-06-30 01:16:33 +02:00
|
|
|
$where,
|
2013-09-12 22:08:25 +02:00
|
|
|
$this->buildGroupClause($conn),
|
2011-06-30 01:16:33 +02:00
|
|
|
$having,
|
2015-04-12 22:01:21 +02:00
|
|
|
$this->buildOrderClause($conn),
|
2013-09-10 16:53:27 +02:00
|
|
|
$this->buildLimitClause($conn));
|
2011-06-30 01:16:33 +02:00
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
switch ($this->groupBy) {
|
|
|
|
case self::GROUP_PROJECT:
|
|
|
|
$data = ipull($rows, null, 'id');
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
$data = $rows;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
$tasks = $task_dao->loadAllFromArray($data);
|
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
switch ($this->groupBy) {
|
|
|
|
case self::GROUP_PROJECT:
|
|
|
|
$results = array();
|
|
|
|
foreach ($rows as $row) {
|
|
|
|
$task = clone $tasks[$row['id']];
|
|
|
|
$task->attachGroupByProjectPHID($row['projectGroupPHID']);
|
|
|
|
$results[] = $task;
|
|
|
|
}
|
|
|
|
$tasks = $results;
|
|
|
|
break;
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
return $tasks;
|
2011-06-30 01:16:33 +02:00
|
|
|
}
|
|
|
|
|
2013-09-13 16:32:57 +02:00
|
|
|
protected function willFilterPage(array $tasks) {
|
|
|
|
if ($this->groupBy == self::GROUP_PROJECT) {
|
|
|
|
// We should only return project groups which the user can actually see.
|
|
|
|
$project_phids = mpull($tasks, 'getGroupByProjectPHID');
|
|
|
|
$projects = id(new PhabricatorProjectQuery())
|
|
|
|
->setViewer($this->getViewer())
|
|
|
|
->withPHIDs($project_phids)
|
|
|
|
->execute();
|
|
|
|
$projects = mpull($projects, null, 'getPHID');
|
|
|
|
|
|
|
|
foreach ($tasks as $key => $task) {
|
2014-05-16 17:47:06 +02:00
|
|
|
if (!$task->getGroupByProjectPHID()) {
|
|
|
|
// This task is either not in any projects, or only in projects
|
|
|
|
// which we're ignoring because they're being queried for explicitly.
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2013-09-13 16:32:57 +02:00
|
|
|
if (empty($projects[$task->getGroupByProjectPHID()])) {
|
|
|
|
unset($tasks[$key]);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return $tasks;
|
|
|
|
}
|
|
|
|
|
2014-07-18 00:42:53 +02:00
|
|
|
protected function didFilterPage(array $tasks) {
|
2014-12-11 01:27:30 +01:00
|
|
|
$phids = mpull($tasks, 'getPHID');
|
|
|
|
|
2014-12-18 22:53:45 +01:00
|
|
|
if ($this->needProjectPHIDs) {
|
|
|
|
$edge_query = id(new PhabricatorEdgeQuery())
|
|
|
|
->withSourcePHIDs($phids)
|
|
|
|
->withEdgeTypes(
|
|
|
|
array(
|
|
|
|
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST,
|
|
|
|
));
|
|
|
|
$edge_query->execute();
|
|
|
|
|
|
|
|
foreach ($tasks as $task) {
|
|
|
|
$project_phids = $edge_query->getDestinationPHIDs(
|
|
|
|
array($task->getPHID()));
|
|
|
|
$task->attachProjectPHIDs($project_phids);
|
|
|
|
}
|
2014-12-11 01:27:30 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
if ($this->needSubscriberPHIDs) {
|
|
|
|
$subscriber_sets = id(new PhabricatorSubscribersQuery())
|
|
|
|
->withObjectPHIDs($phids)
|
|
|
|
->execute();
|
|
|
|
foreach ($tasks as $task) {
|
|
|
|
$subscribers = idx($subscriber_sets, $task->getPHID(), array());
|
|
|
|
$task->attachSubscriberPHIDs($subscribers);
|
|
|
|
}
|
2014-07-18 00:42:53 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
return $tasks;
|
|
|
|
}
|
|
|
|
|
2012-11-01 18:47:45 +01:00
|
|
|
private function buildTaskIDsWhereClause(AphrontDatabaseConnection $conn) {
|
2011-12-02 16:30:20 +01:00
|
|
|
if (!$this->taskIDs) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2015-03-02 15:43:52 +01:00
|
|
|
'task.id in (%Ld)',
|
2011-12-02 16:30:20 +01:00
|
|
|
$this->taskIDs);
|
|
|
|
}
|
|
|
|
|
2012-11-01 18:47:45 +01:00
|
|
|
private function buildTaskPHIDsWhereClause(AphrontDatabaseConnection $conn) {
|
|
|
|
if (!$this->taskPHIDs) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2015-03-02 15:43:52 +01:00
|
|
|
'task.phid in (%Ls)',
|
2012-11-01 18:47:45 +01:00
|
|
|
$this->taskPHIDs);
|
|
|
|
}
|
|
|
|
|
|
|
|
private function buildStatusWhereClause(AphrontDatabaseConnection $conn) {
|
2012-06-29 18:17:19 +02:00
|
|
|
static $map = array(
|
|
|
|
self::STATUS_RESOLVED => ManiphestTaskStatus::STATUS_CLOSED_RESOLVED,
|
|
|
|
self::STATUS_WONTFIX => ManiphestTaskStatus::STATUS_CLOSED_WONTFIX,
|
|
|
|
self::STATUS_INVALID => ManiphestTaskStatus::STATUS_CLOSED_INVALID,
|
|
|
|
self::STATUS_SPITE => ManiphestTaskStatus::STATUS_CLOSED_SPITE,
|
|
|
|
self::STATUS_DUPLICATE => ManiphestTaskStatus::STATUS_CLOSED_DUPLICATE,
|
|
|
|
);
|
|
|
|
|
2011-06-30 01:16:33 +02:00
|
|
|
switch ($this->status) {
|
|
|
|
case self::STATUS_ANY:
|
|
|
|
return null;
|
|
|
|
case self::STATUS_OPEN:
|
2014-03-25 21:47:42 +01:00
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2015-03-02 15:43:52 +01:00
|
|
|
'task.status IN (%Ls)',
|
2014-03-25 21:47:42 +01:00
|
|
|
ManiphestTaskStatus::getOpenStatusConstants());
|
2011-06-30 01:16:33 +02:00
|
|
|
case self::STATUS_CLOSED:
|
2014-03-25 21:47:42 +01:00
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2015-03-02 15:43:52 +01:00
|
|
|
'task.status IN (%Ls)',
|
2014-03-25 21:47:42 +01:00
|
|
|
ManiphestTaskStatus::getClosedStatusConstants());
|
2011-06-30 01:16:33 +02:00
|
|
|
default:
|
2012-06-29 18:17:19 +02:00
|
|
|
$constant = idx($map, $this->status);
|
|
|
|
if (!$constant) {
|
|
|
|
throw new Exception("Unknown status query '{$this->status}'!");
|
|
|
|
}
|
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2015-03-02 15:43:52 +01:00
|
|
|
'task.status = %s',
|
2012-06-29 18:17:19 +02:00
|
|
|
$constant);
|
2011-06-30 01:16:33 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-09-10 20:07:34 +02:00
|
|
|
private function buildStatusesWhereClause(AphrontDatabaseConnection $conn) {
|
|
|
|
if ($this->statuses) {
|
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2015-03-02 15:43:52 +01:00
|
|
|
'task.status IN (%Ls)',
|
2013-09-10 20:07:34 +02:00
|
|
|
$this->statuses);
|
|
|
|
}
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
2012-11-01 18:47:45 +01:00
|
|
|
private function buildAuthorWhereClause(AphrontDatabaseConnection $conn) {
|
2011-06-30 01:16:33 +02:00
|
|
|
if (!$this->authorPHIDs) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2015-03-02 15:43:52 +01:00
|
|
|
'task.authorPHID in (%Ls)',
|
2011-06-30 01:16:33 +02:00
|
|
|
$this->authorPHIDs);
|
|
|
|
}
|
|
|
|
|
2012-11-01 18:47:45 +01:00
|
|
|
private function buildOwnerWhereClause(AphrontDatabaseConnection $conn) {
|
2011-06-30 01:16:33 +02:00
|
|
|
if (!$this->ownerPHIDs) {
|
|
|
|
if ($this->includeUnowned === null) {
|
|
|
|
return null;
|
|
|
|
} else if ($this->includeUnowned) {
|
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2015-03-02 15:43:52 +01:00
|
|
|
'task.ownerPHID IS NULL');
|
2011-06-30 01:16:33 +02:00
|
|
|
} else {
|
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2015-03-02 15:43:52 +01:00
|
|
|
'task.ownerPHID IS NOT NULL');
|
2011-06-30 01:16:33 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if ($this->includeUnowned) {
|
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2015-03-02 15:43:52 +01:00
|
|
|
'task.ownerPHID IN (%Ls) OR task.ownerPHID IS NULL',
|
2011-06-30 01:16:33 +02:00
|
|
|
$this->ownerPHIDs);
|
|
|
|
} else {
|
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2015-03-02 15:43:52 +01:00
|
|
|
'task.ownerPHID IN (%Ls)',
|
2011-06-30 01:16:33 +02:00
|
|
|
$this->ownerPHIDs);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-11-01 18:47:45 +01:00
|
|
|
private function buildFullTextWhereClause(AphrontDatabaseConnection $conn) {
|
2013-09-12 22:03:05 +02:00
|
|
|
if (!strlen($this->fullTextSearch)) {
|
2012-06-15 23:09:49 +02:00
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
// In doing a fulltext search, we first find all the PHIDs that match the
|
|
|
|
// fulltext search, and then use that to limit the rest of the search
|
2014-02-03 21:51:08 +01:00
|
|
|
$fulltext_query = id(new PhabricatorSavedQuery())
|
2014-05-16 21:20:13 +02:00
|
|
|
->setEngineClassName('PhabricatorSearchApplicationSearchEngine')
|
2014-02-03 21:51:08 +01:00
|
|
|
->setParameter('query', $this->fullTextSearch);
|
2013-09-24 19:50:56 +02:00
|
|
|
|
|
|
|
// NOTE: Setting this to something larger than 2^53 will raise errors in
|
|
|
|
// ElasticSearch, and billions of results won't fit in memory anyway.
|
|
|
|
$fulltext_query->setParameter('limit', 100000);
|
2014-07-24 00:05:46 +02:00
|
|
|
$fulltext_query->setParameter('type', ManiphestTaskPHIDType::TYPECONST);
|
2012-06-15 23:09:49 +02:00
|
|
|
|
|
|
|
$engine = PhabricatorSearchEngineSelector::newSelector()->newEngine();
|
|
|
|
$fulltext_results = $engine->executeSearch($fulltext_query);
|
|
|
|
|
2012-06-16 00:41:20 +02:00
|
|
|
if (empty($fulltext_results)) {
|
|
|
|
$fulltext_results = array(null);
|
|
|
|
}
|
|
|
|
|
2012-06-15 23:09:49 +02:00
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2015-03-02 15:43:52 +01:00
|
|
|
'task.phid IN (%Ls)',
|
2012-06-15 23:09:49 +02:00
|
|
|
$fulltext_results);
|
|
|
|
}
|
|
|
|
|
2015-01-12 22:42:37 +01:00
|
|
|
private function buildDependenciesWhereClause(
|
|
|
|
AphrontDatabaseConnection $conn) {
|
|
|
|
|
|
|
|
if (!$this->shouldJoinBlockedTasks() &&
|
|
|
|
!$this->shouldJoinBlockingTasks()) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
$parts = array();
|
|
|
|
if ($this->blockingTasks === true) {
|
|
|
|
$parts[] = qsprintf(
|
|
|
|
$conn,
|
2015-03-04 00:53:08 +01:00
|
|
|
'blocking.dst IS NOT NULL AND blockingtask.status IN (%Ls)',
|
|
|
|
ManiphestTaskStatus::getOpenStatusConstants());
|
2015-01-12 22:42:37 +01:00
|
|
|
} else if ($this->blockingTasks === false) {
|
|
|
|
$parts[] = qsprintf(
|
|
|
|
$conn,
|
2015-03-04 00:53:08 +01:00
|
|
|
'blocking.dst IS NULL OR blockingtask.status NOT IN (%Ls)',
|
|
|
|
ManiphestTaskStatus::getOpenStatusConstants());
|
2015-01-12 22:42:37 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
if ($this->blockedTasks === true) {
|
|
|
|
$parts[] = qsprintf(
|
|
|
|
$conn,
|
2015-03-04 00:53:08 +01:00
|
|
|
'blocked.dst IS NOT NULL AND blockedtask.status IN (%Ls)',
|
|
|
|
ManiphestTaskStatus::getOpenStatusConstants());
|
2015-01-12 22:42:37 +01:00
|
|
|
} else if ($this->blockedTasks === false) {
|
|
|
|
$parts[] = qsprintf(
|
|
|
|
$conn,
|
2015-03-04 00:53:08 +01:00
|
|
|
'blocked.dst IS NULL OR blockedtask.status NOT IN (%Ls)',
|
|
|
|
ManiphestTaskStatus::getOpenStatusConstants());
|
2015-01-12 22:42:37 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
return '('.implode(') OR (', $parts).')';
|
|
|
|
}
|
|
|
|
|
2012-11-01 18:47:45 +01:00
|
|
|
private function buildProjectWhereClause(AphrontDatabaseConnection $conn) {
|
2012-02-29 06:08:02 +01:00
|
|
|
if (!$this->projectPHIDs && !$this->includeNoProject) {
|
2011-06-30 01:16:33 +02:00
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
2012-02-29 06:08:02 +01:00
|
|
|
$parts = array();
|
|
|
|
if ($this->projectPHIDs) {
|
|
|
|
$parts[] = qsprintf(
|
|
|
|
$conn,
|
2014-07-18 00:42:30 +02:00
|
|
|
'project.dst in (%Ls)',
|
2012-02-29 06:08:02 +01:00
|
|
|
$this->projectPHIDs);
|
|
|
|
}
|
|
|
|
if ($this->includeNoProject) {
|
|
|
|
$parts[] = qsprintf(
|
|
|
|
$conn,
|
2014-07-18 00:42:30 +02:00
|
|
|
'project.dst IS NULL');
|
2012-02-29 06:08:02 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
return '('.implode(') OR (', $parts).')';
|
2011-06-30 01:16:33 +02:00
|
|
|
}
|
|
|
|
|
2012-11-01 18:47:45 +01:00
|
|
|
private function buildAnyProjectWhereClause(AphrontDatabaseConnection $conn) {
|
2012-10-05 00:30:51 +02:00
|
|
|
if (!$this->anyProjectPHIDs) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2014-07-18 00:42:30 +02:00
|
|
|
'anyproject.dst IN (%Ls)',
|
2012-10-05 00:30:51 +02:00
|
|
|
$this->anyProjectPHIDs);
|
|
|
|
}
|
|
|
|
|
2013-04-04 19:29:40 +02:00
|
|
|
private function buildAnyUserProjectWhereClause(
|
|
|
|
AphrontDatabaseConnection $conn) {
|
|
|
|
if (!$this->anyUserProjectPHIDs) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
$projects = id(new PhabricatorProjectQuery())
|
2013-09-11 21:27:28 +02:00
|
|
|
->setViewer($this->getViewer())
|
2013-04-04 19:29:40 +02:00
|
|
|
->withMemberPHIDs($this->anyUserProjectPHIDs)
|
|
|
|
->execute();
|
|
|
|
$any_user_project_phids = mpull($projects, 'getPHID');
|
2013-09-02 22:24:41 +02:00
|
|
|
if (!$any_user_project_phids) {
|
|
|
|
throw new PhabricatorEmptyQueryException();
|
|
|
|
}
|
2013-04-04 19:29:40 +02:00
|
|
|
|
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2014-07-18 00:42:30 +02:00
|
|
|
'anyproject.dst IN (%Ls)',
|
2013-04-04 19:29:40 +02:00
|
|
|
$any_user_project_phids);
|
|
|
|
}
|
|
|
|
|
2012-11-01 18:47:45 +01:00
|
|
|
private function buildXProjectWhereClause(AphrontDatabaseConnection $conn) {
|
2012-02-29 06:08:02 +01:00
|
|
|
if (!$this->xprojectPHIDs) {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
return qsprintf(
|
|
|
|
$conn,
|
2014-07-18 00:42:30 +02:00
|
|
|
'xproject.dst IS NULL');
|
2012-02-29 06:08:02 +01:00
|
|
|
}
|
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
private function buildJoinsClause(AphrontDatabaseConnection $conn_r) {
|
2014-07-18 00:42:30 +02:00
|
|
|
$edge_table = PhabricatorEdgeConfig::TABLE_NAME_EDGE;
|
2011-06-30 01:16:33 +02:00
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
$joins = array();
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
if ($this->projectPHIDs || $this->includeNoProject) {
|
|
|
|
$joins[] = qsprintf(
|
|
|
|
$conn_r,
|
2014-07-18 00:42:30 +02:00
|
|
|
'%Q JOIN %T project ON project.src = task.phid
|
|
|
|
AND project.type = %d',
|
2013-09-12 22:08:25 +02:00
|
|
|
($this->includeNoProject ? 'LEFT' : ''),
|
2014-07-18 00:42:30 +02:00
|
|
|
$edge_table,
|
|
|
|
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST);
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
}
|
|
|
|
|
2015-01-12 22:42:37 +01:00
|
|
|
if ($this->shouldJoinBlockingTasks()) {
|
|
|
|
$joins[] = qsprintf(
|
|
|
|
$conn_r,
|
|
|
|
'LEFT JOIN %T blocking ON blocking.src = task.phid '.
|
2015-02-28 23:39:07 +01:00
|
|
|
'AND blocking.type = %d '.
|
2015-03-04 00:53:08 +01:00
|
|
|
'LEFT JOIN %T blockingtask ON blocking.dst = blockingtask.phid',
|
2015-01-12 22:42:37 +01:00
|
|
|
$edge_table,
|
2015-02-28 23:39:07 +01:00
|
|
|
ManiphestTaskDependedOnByTaskEdgeType::EDGECONST,
|
2015-03-04 00:53:08 +01:00
|
|
|
id(new ManiphestTask())->getTableName());
|
2015-01-12 22:42:37 +01:00
|
|
|
}
|
|
|
|
if ($this->shouldJoinBlockedTasks()) {
|
|
|
|
$joins[] = qsprintf(
|
|
|
|
$conn_r,
|
|
|
|
'LEFT JOIN %T blocked ON blocked.src = task.phid '.
|
2015-02-28 23:39:07 +01:00
|
|
|
'AND blocked.type = %d '.
|
2015-03-04 00:53:08 +01:00
|
|
|
'LEFT JOIN %T blockedtask ON blocked.dst = blockedtask.phid',
|
2015-01-12 22:42:37 +01:00
|
|
|
$edge_table,
|
2015-02-28 23:39:07 +01:00
|
|
|
ManiphestTaskDependsOnTaskEdgeType::EDGECONST,
|
2015-03-04 00:53:08 +01:00
|
|
|
id(new ManiphestTask())->getTableName());
|
2015-01-12 22:42:37 +01:00
|
|
|
}
|
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
if ($this->anyProjectPHIDs || $this->anyUserProjectPHIDs) {
|
|
|
|
$joins[] = qsprintf(
|
|
|
|
$conn_r,
|
2014-07-18 00:42:30 +02:00
|
|
|
'JOIN %T anyproject ON anyproject.src = task.phid
|
|
|
|
AND anyproject.type = %d',
|
|
|
|
$edge_table,
|
|
|
|
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST);
|
2013-09-12 22:08:25 +02:00
|
|
|
}
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
if ($this->xprojectPHIDs) {
|
|
|
|
$joins[] = qsprintf(
|
|
|
|
$conn_r,
|
2014-07-18 00:42:30 +02:00
|
|
|
'LEFT JOIN %T xproject ON xproject.src = task.phid
|
|
|
|
AND xproject.type = %d
|
|
|
|
AND xproject.dst IN (%Ls)',
|
|
|
|
$edge_table,
|
|
|
|
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST,
|
2013-09-12 22:08:25 +02:00
|
|
|
$this->xprojectPHIDs);
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
}
|
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
if ($this->subscriberPHIDs) {
|
|
|
|
$joins[] = qsprintf(
|
|
|
|
$conn_r,
|
2014-12-11 01:27:30 +01:00
|
|
|
'JOIN %T e_ccs ON e_ccs.src = task.phid '.
|
|
|
|
'AND e_ccs.type = %s '.
|
|
|
|
'AND e_ccs.dst in (%Ls)',
|
|
|
|
PhabricatorEdgeConfig::TABLE_NAME_EDGE,
|
2015-01-03 00:33:25 +01:00
|
|
|
PhabricatorObjectHasSubscriberEdgeType::EDGECONST,
|
2014-12-11 01:27:30 +01:00
|
|
|
$this->subscriberPHIDs);
|
2013-09-12 22:08:25 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
switch ($this->groupBy) {
|
|
|
|
case self::GROUP_PROJECT:
|
|
|
|
$ignore_group_phids = $this->getIgnoreGroupedProjectPHIDs();
|
|
|
|
if ($ignore_group_phids) {
|
|
|
|
$joins[] = qsprintf(
|
|
|
|
$conn_r,
|
2014-07-18 00:42:30 +02:00
|
|
|
'LEFT JOIN %T projectGroup ON task.phid = projectGroup.src
|
|
|
|
AND projectGroup.type = %d
|
|
|
|
AND projectGroup.dst NOT IN (%Ls)',
|
|
|
|
$edge_table,
|
|
|
|
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST,
|
2013-09-12 22:08:25 +02:00
|
|
|
$ignore_group_phids);
|
|
|
|
} else {
|
|
|
|
$joins[] = qsprintf(
|
|
|
|
$conn_r,
|
2014-07-18 00:42:30 +02:00
|
|
|
'LEFT JOIN %T projectGroup ON task.phid = projectGroup.src
|
|
|
|
AND projectGroup.type = %d',
|
|
|
|
$edge_table,
|
|
|
|
PhabricatorProjectObjectHasProjectEdgeType::EDGECONST);
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
}
|
2013-09-12 22:08:25 +02:00
|
|
|
$joins[] = qsprintf(
|
|
|
|
$conn_r,
|
|
|
|
'LEFT JOIN %T projectGroupName
|
2014-07-18 00:42:30 +02:00
|
|
|
ON projectGroup.dst = projectGroupName.indexedObjectPHID',
|
2013-09-12 22:08:25 +02:00
|
|
|
id(new ManiphestNameIndex())->getTableName());
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2013-09-17 01:03:09 +02:00
|
|
|
$joins[] = $this->buildApplicationSearchJoinClause($conn_r);
|
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
return implode(' ', $joins);
|
|
|
|
}
|
|
|
|
|
2015-04-18 16:53:43 +02:00
|
|
|
protected function buildGroupClause(AphrontDatabaseConnection $conn_r) {
|
2013-09-17 01:03:09 +02:00
|
|
|
$joined_multiple_rows = (count($this->projectPHIDs) > 1) ||
|
|
|
|
(count($this->anyProjectPHIDs) > 1) ||
|
2015-01-12 22:42:37 +01:00
|
|
|
$this->shouldJoinBlockingTasks() ||
|
|
|
|
$this->shouldJoinBlockedTasks() ||
|
2013-09-17 01:03:09 +02:00
|
|
|
($this->getApplicationSearchMayJoinMultipleRows());
|
2013-09-12 22:08:25 +02:00
|
|
|
|
|
|
|
$joined_project_name = ($this->groupBy == self::GROUP_PROJECT);
|
|
|
|
|
|
|
|
// If we're joining multiple rows, we need to group the results by the
|
|
|
|
// task IDs.
|
2013-09-17 01:03:09 +02:00
|
|
|
if ($joined_multiple_rows) {
|
2013-09-12 22:08:25 +02:00
|
|
|
if ($joined_project_name) {
|
2014-07-18 00:42:30 +02:00
|
|
|
return 'GROUP BY task.phid, projectGroup.dst';
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
} else {
|
2013-09-17 01:03:09 +02:00
|
|
|
return 'GROUP BY task.phid';
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
}
|
2013-09-12 22:08:25 +02:00
|
|
|
} else {
|
|
|
|
return '';
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
}
|
2013-09-12 22:08:25 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Return project PHIDs which we should ignore when grouping tasks by
|
|
|
|
* project. For example, if a user issues a query like:
|
|
|
|
*
|
|
|
|
* Tasks in all projects: Frontend, Bugs
|
|
|
|
*
|
|
|
|
* ...then we don't show "Frontend" or "Bugs" groups in the result set, since
|
|
|
|
* they're meaningless as all results are in both groups.
|
|
|
|
*
|
|
|
|
* Similarly, for queries like:
|
|
|
|
*
|
|
|
|
* Tasks in any projects: Public Relations
|
|
|
|
*
|
|
|
|
* ...we ignore the single project, as every result is in that project. (In
|
|
|
|
* the case that there are several "any" projects, we do not ignore them.)
|
|
|
|
*
|
|
|
|
* @return list<phid> Project PHIDs which should be ignored in query
|
|
|
|
* construction.
|
|
|
|
*/
|
|
|
|
private function getIgnoreGroupedProjectPHIDs() {
|
|
|
|
$phids = array();
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
if ($this->projectPHIDs) {
|
|
|
|
$phids[] = $this->projectPHIDs;
|
|
|
|
}
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
if (count($this->anyProjectPHIDs) == 1) {
|
|
|
|
$phids[] = $this->anyProjectPHIDs;
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
}
|
|
|
|
|
2013-09-12 22:08:25 +02:00
|
|
|
// Maybe we should also exclude the "excludeProjectPHIDs"? It won't
|
|
|
|
// impact the results, but we might end up with a better query plan.
|
|
|
|
// Investigate this on real data? This is likely very rare.
|
|
|
|
|
|
|
|
return array_mergev($phids);
|
Add "Group by: Project" to Maniphest
Summary:
Allow tasks to be grouped by project. Since this is many-to-many and we're a little deficient on indexes for doing this on the database, we pull all matching tasks and group them in PHP. This shouldn't be a huge issue for any existing installs, though, and we can add keys when we run into one.
- When a task is in multiple projects, it appears under multiple headers.
- When a query has a task filter, those projects are omitted from the grouping (they'd always show everything, which isn't useful). Notably, if you search for "Differential", you can now see "Bugs", "Feature Requests", etc.
Test Plan: Selected "Group by: Project".
Reviewers: btrahan, Josereyes
Reviewed By: btrahan
CC: aran, epriestley
Maniphest Tasks: T923
Differential Revision: https://secure.phabricator.com/D1953
2012-03-20 03:47:34 +01:00
|
|
|
}
|
|
|
|
|
2015-04-13 01:44:15 +02:00
|
|
|
protected function getResultCursor($result) {
|
2013-09-13 16:13:06 +02:00
|
|
|
$id = $result->getID();
|
|
|
|
|
2015-04-13 01:44:15 +02:00
|
|
|
if ($this->groupBy == self::GROUP_PROJECT) {
|
|
|
|
return rtrim($id.'.'.$result->getGroupByProjectPHID(), '.');;
|
2013-09-13 16:13:06 +02:00
|
|
|
}
|
2015-04-13 01:44:15 +02:00
|
|
|
|
|
|
|
return $id;
|
2013-09-13 16:13:06 +02:00
|
|
|
}
|
|
|
|
|
2015-04-12 22:01:21 +02:00
|
|
|
public function getOrderableColumns() {
|
|
|
|
return parent::getOrderableColumns() + array(
|
|
|
|
'priority' => array(
|
|
|
|
'table' => 'task',
|
|
|
|
'column' => 'priority',
|
|
|
|
'type' => 'int',
|
|
|
|
),
|
|
|
|
'owner' => array(
|
|
|
|
'table' => 'task',
|
|
|
|
'column' => 'ownerOrdering',
|
|
|
|
'null' => 'head',
|
|
|
|
'reverse' => true,
|
|
|
|
'type' => 'string',
|
|
|
|
),
|
|
|
|
'status' => array(
|
|
|
|
'table' => 'task',
|
|
|
|
'column' => 'status',
|
|
|
|
'type' => 'string',
|
|
|
|
'reverse' => true,
|
|
|
|
),
|
|
|
|
'project' => array(
|
|
|
|
'table' => 'projectGroupName',
|
|
|
|
'column' => 'indexedObjectName',
|
|
|
|
'type' => 'string',
|
|
|
|
'null' => 'head',
|
|
|
|
'reverse' => true,
|
|
|
|
),
|
|
|
|
'title' => array(
|
|
|
|
'table' => 'task',
|
|
|
|
'column' => 'title',
|
|
|
|
'type' => 'string',
|
|
|
|
'reverse' => true,
|
|
|
|
),
|
|
|
|
'subpriority' => array(
|
|
|
|
'table' => 'task',
|
|
|
|
'column' => 'subpriority',
|
|
|
|
'type' => 'float',
|
|
|
|
),
|
|
|
|
'updated' => array(
|
|
|
|
'table' => 'task',
|
|
|
|
'column' => 'dateModified',
|
|
|
|
'type' => 'int',
|
|
|
|
),
|
|
|
|
);
|
|
|
|
}
|
2013-09-13 16:13:06 +02:00
|
|
|
|
2015-04-12 22:01:21 +02:00
|
|
|
protected function getPagingValueMap($cursor, array $keys) {
|
|
|
|
$cursor_parts = explode('.', $cursor, 2);
|
2013-09-13 16:13:06 +02:00
|
|
|
$task_id = $cursor_parts[0];
|
|
|
|
$group_id = idx($cursor_parts, 1);
|
|
|
|
|
2015-04-12 22:01:21 +02:00
|
|
|
$task = $this->loadCursorObject($task_id);
|
2015-04-12 07:26:19 +02:00
|
|
|
|
2015-04-12 22:01:21 +02:00
|
|
|
$map = array(
|
|
|
|
'id' => $task->getID(),
|
|
|
|
'priority' => $task->getPriority(),
|
|
|
|
'subpriority' => $task->getSubpriority(),
|
|
|
|
'owner' => $task->getOwnerOrdering(),
|
|
|
|
'status' => $task->getStatus(),
|
|
|
|
'title' => $task->getTitle(),
|
|
|
|
'updated' => $task->getDateModified(),
|
|
|
|
);
|
2013-09-13 16:13:06 +02:00
|
|
|
|
2015-04-12 22:01:21 +02:00
|
|
|
foreach ($keys as $key) {
|
|
|
|
switch ($key) {
|
|
|
|
case 'project':
|
|
|
|
$value = null;
|
|
|
|
if ($group_id) {
|
|
|
|
$paging_projects = id(new PhabricatorProjectQuery())
|
|
|
|
->setViewer($this->getViewer())
|
|
|
|
->withPHIDs(array($group_id))
|
|
|
|
->execute();
|
|
|
|
if ($paging_projects) {
|
|
|
|
$value = head($paging_projects)->getName();
|
|
|
|
}
|
2014-08-02 10:22:16 +02:00
|
|
|
}
|
2015-04-12 22:01:21 +02:00
|
|
|
$map[$key] = $value;
|
2014-08-02 10:22:16 +02:00
|
|
|
break;
|
|
|
|
}
|
2013-09-13 16:13:06 +02:00
|
|
|
}
|
|
|
|
|
2015-04-12 22:01:21 +02:00
|
|
|
foreach ($keys as $key) {
|
|
|
|
if ($this->isCustomFieldOrderKey($key)) {
|
|
|
|
$map += $this->getPagingValueMapForCustomFields($task);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2015-03-14 21:27:47 +01:00
|
|
|
|
2015-04-12 22:01:21 +02:00
|
|
|
return $map;
|
2013-09-13 16:13:06 +02:00
|
|
|
}
|
2013-09-12 22:08:25 +02:00
|
|
|
|
2015-04-12 04:00:53 +02:00
|
|
|
protected function getPrimaryTableAlias() {
|
|
|
|
return 'task';
|
2013-09-17 01:03:09 +02:00
|
|
|
}
|
|
|
|
|
Lock policy queries to their applications
Summary:
While we mostly have reasonable effective object accessibility when you lock a user out of an application, it's primarily enforced at the controller level. Users can still, e.g., load the handles of objects they can't actually see. Instead, lock the queries to the applications so that you can, e.g., never load a revision if you don't have access to Differential.
This has several parts:
- For PolicyAware queries, provide an application class name method.
- If the query specifies a class name and the user doesn't have permission to use it, fail the entire query unconditionally.
- For handles, simplify query construction and count all the PHIDs as "restricted" so we get a UI full of "restricted" instead of "unknown" handles.
Test Plan:
- Added a unit test to verify I got all the class names right.
- Browsed around, logged in/out as a normal user with public policies on and off.
- Browsed around, logged in/out as a restricted user with public policies on and off. With restrictions, saw all traces of restricted apps removed or restricted.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D7367
2013-10-22 02:20:27 +02:00
|
|
|
public function getQueryApplicationClass() {
|
2014-07-23 02:03:09 +02:00
|
|
|
return 'PhabricatorManiphestApplication';
|
Lock policy queries to their applications
Summary:
While we mostly have reasonable effective object accessibility when you lock a user out of an application, it's primarily enforced at the controller level. Users can still, e.g., load the handles of objects they can't actually see. Instead, lock the queries to the applications so that you can, e.g., never load a revision if you don't have access to Differential.
This has several parts:
- For PolicyAware queries, provide an application class name method.
- If the query specifies a class name and the user doesn't have permission to use it, fail the entire query unconditionally.
- For handles, simplify query construction and count all the PHIDs as "restricted" so we get a UI full of "restricted" instead of "unknown" handles.
Test Plan:
- Added a unit test to verify I got all the class names right.
- Browsed around, logged in/out as a normal user with public policies on and off.
- Browsed around, logged in/out as a restricted user with public policies on and off. With restrictions, saw all traces of restricted apps removed or restricted.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D7367
2013-10-22 02:20:27 +02:00
|
|
|
}
|
|
|
|
|
2011-06-30 01:16:33 +02:00
|
|
|
}
|