2011-03-31 08:27:06 +02:00
|
|
|
<?php
|
|
|
|
|
|
|
|
/*
|
2012-03-10 00:46:25 +01:00
|
|
|
* Copyright 2012 Facebook, Inc.
|
2011-03-31 08:27:06 +02:00
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
2012-03-10 00:46:25 +01:00
|
|
|
final class DiffusionLastModifiedController extends DiffusionController {
|
2011-03-31 08:27:06 +02:00
|
|
|
|
|
|
|
public function processRequest() {
|
|
|
|
$drequest = $this->getDiffusionRequest();
|
|
|
|
$request = $this->getRequest();
|
|
|
|
|
|
|
|
$modified_query = DiffusionLastModifiedQuery::newFromDiffusionRequest(
|
|
|
|
$drequest);
|
|
|
|
list($commit, $commit_data) = $modified_query->loadLastModification();
|
|
|
|
|
2011-04-03 01:39:23 +02:00
|
|
|
$phids = array();
|
Move "Rendering References" to the DifferentialChangesetParser level
Summary:
Separates changeset IDs from rendering. Now each changeset has a "rendering
reference" which is basically a description of what the ajax endpoint should
render. For Differential, it's in the form "id/vs". For Diffusion,
"branch/path;commit".
I believe this fixes pretty much all of the bugs related to "show more" breaking
in various obscure ways, although I never got a great repro for T153.
Test Plan:
Clicked "show more" in diffusion change and commit views and differential diff,
diff-of-diff, standalone-diff, standalone-diff-of-diff views. Verified refs and
'whitespace' were always sent correctly.
Made inline comments on diffs and diffs-of-diffs. Used "Reply".
Reviewed By: tuomaspelkonen
Reviewers: tuomaspelkonen, jungejason, aran
CC: aran, tuomaspelkonen, epriestley
Differential Revision: 274
2011-05-12 06:46:29 +02:00
|
|
|
if ($commit_data && $commit_data->getCommitDetail('authorPHID')) {
|
2011-04-03 01:39:23 +02:00
|
|
|
$phids = array($commit_data->getCommitDetail('authorPHID'));
|
|
|
|
}
|
|
|
|
|
|
|
|
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();
|
|
|
|
|
2011-03-31 08:27:06 +02:00
|
|
|
$output = DiffusionBrowseTableView::renderLastModifiedColumns(
|
|
|
|
$drequest->getRepository(),
|
2011-04-03 01:39:23 +02:00
|
|
|
$handles,
|
2011-03-31 08:27:06 +02:00
|
|
|
$commit,
|
|
|
|
$commit_data);
|
|
|
|
|
|
|
|
return id(new AphrontAjaxResponse())
|
|
|
|
->setContent($output);
|
|
|
|
}
|
|
|
|
}
|