2011-01-24 22:18:41 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copyright 2011 Facebook, Inc.
|
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
class DifferentialChangesetDetailView extends AphrontView {
|
|
|
|
|
2011-01-25 20:57:47 +01:00
|
|
|
private $changeset;
|
|
|
|
private $buttons = array();
|
2011-04-15 23:25:23 +02:00
|
|
|
private $revisionID;
|
Tie all the pieces for symbol cross-references together
Summary:
This makes symbol cross-references work in Differential. You need to do a little
legwork but I'll document that once the change has baked for a little while.
Basically:
- Projects are annotated with indexed languages, and "shared library" projects
(for example, symbols in Phabricator should be searched for in Arcanist and
libphutil).
- When we render a changeset, we check if its language is an indexed one. If
it is, we invoke the decorator Javascript.
- The Javascript takes you to a lookup page, which either gives you a list of
matching symbols (if several match) or redirects you instantly to the
definition.
Test Plan: Clicked class and function symbols in a diff, got jumped into
sensible sorts of places in Diffusion.
Reviewers: jungejason, nh, tuomaspelkonen, aran
Reviewed By: jungejason
CC: aran, jungejason
Differential Revision: 980
2011-10-03 01:02:56 +02:00
|
|
|
private $symbolIndex;
|
2011-01-24 22:18:41 +01:00
|
|
|
|
2011-01-25 20:57:47 +01:00
|
|
|
public function setChangeset($changeset) {
|
|
|
|
$this->changeset = $changeset;
|
2011-01-24 22:18:41 +01:00
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-01-25 20:57:47 +01:00
|
|
|
public function addButton($button) {
|
|
|
|
$this->buttons[] = $button;
|
|
|
|
return $this;
|
|
|
|
}
|
2011-01-24 22:18:41 +01:00
|
|
|
|
2011-04-15 23:25:23 +02:00
|
|
|
public function setRevisionID($revision_id) {
|
|
|
|
$this->revisionID = $revision_id;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
Tie all the pieces for symbol cross-references together
Summary:
This makes symbol cross-references work in Differential. You need to do a little
legwork but I'll document that once the change has baked for a little while.
Basically:
- Projects are annotated with indexed languages, and "shared library" projects
(for example, symbols in Phabricator should be searched for in Arcanist and
libphutil).
- When we render a changeset, we check if its language is an indexed one. If
it is, we invoke the decorator Javascript.
- The Javascript takes you to a lookup page, which either gives you a list of
matching symbols (if several match) or redirects you instantly to the
definition.
Test Plan: Clicked class and function symbols in a diff, got jumped into
sensible sorts of places in Diffusion.
Reviewers: jungejason, nh, tuomaspelkonen, aran
Reviewed By: jungejason
CC: aran, jungejason
Differential Revision: 980
2011-10-03 01:02:56 +02:00
|
|
|
public function setSymbolIndex($symbol_index) {
|
|
|
|
$this->symbolIndex = $symbol_index;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
2011-01-25 20:57:47 +01:00
|
|
|
public function render() {
|
|
|
|
require_celerity_resource('differential-changeset-view-css');
|
|
|
|
require_celerity_resource('syntax-highlighting-css');
|
2011-01-24 22:18:41 +01:00
|
|
|
|
2011-04-15 23:25:23 +02:00
|
|
|
if ($this->revisionID) {
|
|
|
|
$edit = true;
|
|
|
|
} else {
|
|
|
|
$edit = false;
|
|
|
|
}
|
2011-01-24 22:18:41 +01:00
|
|
|
|
2011-01-25 20:57:47 +01:00
|
|
|
$changeset = $this->changeset;
|
|
|
|
$class = 'differential-changeset';
|
|
|
|
if (!$edit) {
|
|
|
|
$class .= ' differential-changeset-immutable';
|
2011-01-24 22:18:41 +01:00
|
|
|
}
|
|
|
|
|
2011-05-06 21:58:53 +02:00
|
|
|
$buttons = null;
|
|
|
|
if ($this->buttons) {
|
|
|
|
$buttons =
|
|
|
|
'<div class="differential-changeset-buttons">'.
|
|
|
|
implode('', $this->buttons).
|
|
|
|
'</div>';
|
|
|
|
}
|
|
|
|
|
Tie all the pieces for symbol cross-references together
Summary:
This makes symbol cross-references work in Differential. You need to do a little
legwork but I'll document that once the change has baked for a little while.
Basically:
- Projects are annotated with indexed languages, and "shared library" projects
(for example, symbols in Phabricator should be searched for in Arcanist and
libphutil).
- When we render a changeset, we check if its language is an indexed one. If
it is, we invoke the decorator Javascript.
- The Javascript takes you to a lookup page, which either gives you a list of
matching symbols (if several match) or redirects you instantly to the
definition.
Test Plan: Clicked class and function symbols in a diff, got jumped into
sensible sorts of places in Diffusion.
Reviewers: jungejason, nh, tuomaspelkonen, aran
Reviewed By: jungejason
CC: aran, jungejason
Differential Revision: 980
2011-10-03 01:02:56 +02:00
|
|
|
$id = celerity_generate_unique_node_id();
|
|
|
|
|
|
|
|
if ($this->symbolIndex) {
|
|
|
|
Javelin::initBehavior(
|
|
|
|
'repository-crossreference',
|
|
|
|
array(
|
|
|
|
'container' => $id,
|
|
|
|
) + $this->symbolIndex);
|
|
|
|
}
|
|
|
|
|
2011-01-25 20:57:47 +01:00
|
|
|
$display_filename = $changeset->getDisplayFilename();
|
|
|
|
$output = javelin_render_tag(
|
|
|
|
'div',
|
|
|
|
array(
|
|
|
|
'sigil' => 'differential-changeset',
|
2011-02-02 01:42:36 +01:00
|
|
|
'meta' => array(
|
|
|
|
'left' => $this->changeset->getID(),
|
|
|
|
'right' => $this->changeset->getID(),
|
|
|
|
),
|
2011-01-25 20:57:47 +01:00
|
|
|
'class' => $class,
|
Tie all the pieces for symbol cross-references together
Summary:
This makes symbol cross-references work in Differential. You need to do a little
legwork but I'll document that once the change has baked for a little while.
Basically:
- Projects are annotated with indexed languages, and "shared library" projects
(for example, symbols in Phabricator should be searched for in Arcanist and
libphutil).
- When we render a changeset, we check if its language is an indexed one. If
it is, we invoke the decorator Javascript.
- The Javascript takes you to a lookup page, which either gives you a list of
matching symbols (if several match) or redirects you instantly to the
definition.
Test Plan: Clicked class and function symbols in a diff, got jumped into
sensible sorts of places in Diffusion.
Reviewers: jungejason, nh, tuomaspelkonen, aran
Reviewed By: jungejason
CC: aran, jungejason
Differential Revision: 980
2011-10-03 01:02:56 +02:00
|
|
|
'id' => $id,
|
2011-01-25 20:57:47 +01:00
|
|
|
),
|
2011-02-05 01:18:08 +01:00
|
|
|
phutil_render_tag(
|
|
|
|
'a',
|
|
|
|
array(
|
|
|
|
'name' => $changeset->getAnchorName(),
|
|
|
|
),
|
|
|
|
'').
|
2011-05-06 21:58:53 +02:00
|
|
|
$buttons.
|
2011-01-25 20:57:47 +01:00
|
|
|
'<h1>'.phutil_escape_html($display_filename).'</h1>'.
|
|
|
|
'<div style="clear: both;"></div>'.
|
|
|
|
$this->renderChildren());
|
|
|
|
|
|
|
|
return $output;
|
2011-01-24 22:18:41 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
}
|