phorge-phorge/src/applications/harbormaster/customfield/HarbormasterBuildStepCustomField.php

<?php

abstract class HarbormasterBuildStepCustomField
  extends PhabricatorCustomField {

  abstract public function getBuildTargetFieldValue();

}
Use ApplicationTransactions and CustomField to implement build steps Summary: Ref T1049. Fixes T4602. Moves all the funky field stuff to CustomField. Uses ApplicationTransactions to apply and record edits. This makes "artifact" fields a little less nice (but still perfectly usable). With D8599, I think they're reasonable overall. We can improve this in the future. All other field types are better (e.g., fixes weird bugs with "bool", fixes lots of weird behavior around required fields), and this gives us access to many new field types. Test Plan: Made a bunch of step edits. Here's an example: {F133694} Note that: - "Required" fields work correctly. - the transaction record is shown at the bottom of the page. Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T4602, T1049 Differential Revision: https://secure.phabricator.com/D8600 2014-03-26 00:08:40 +01:00			`<?php`

			`abstract class HarbormasterBuildStepCustomField`
Allow Harbormaster build plans to request additional working copies Summary: Ref T9123. To run upstream builds in Harbormaster/Drydock, we need to be able to check out `libphutil`, `arcanist` and `phabricator` next to one another. This adds an "Also Clone: ..." field to Harbormaster working copy build steps so I can type all three repos into it and get a proper clone with everything we need. This is somewhat upstream-centric and a bit narrow, but I don't think it's totally unreasonable, and most of the underlying stuff is relatively general. This adds some more typechecking and improves data/type handling for custom fields, too. In particular, it prevents users from entering an invalid/restricted value in a field (for example, you can't "Also Clone" a repository you don't have permission to see). Test Plan: Restarted build, got a Drydock resource with multiple repositories in it. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9123 Differential Revision: https://secure.phabricator.com/D14183 2015-09-29 02:57:41 +02:00			`extends PhabricatorCustomField {`

			`abstract public function getBuildTargetFieldValue();`

			`}`