revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-14 10:52:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/webroot/rsrc/css/phui/phui-list.css

355 lines
7.3 KiB
CSS
Raw Normal View History

PHUIList, PHUIDocument updates Summary: This diff covers a bit of ground. - PHUIDocumentExample has been added - PHUIDocument has been extended with new features - PhabricatorMenuView is now PHUIListView - PhabricatorMenuItemView is now PHUIItemListView Overall - I think I've gotten all the edges covered here. There is some derpi-ness that we can talk about, comments in the code. Responsive design is missing from the new features on PHUIDocument, will follow up later. Test Plan: Tested mobile and desktop menus, old phriction layout, new document views, new lists, and object lists. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6130
2013-06-05 17:41:43 +02:00
/**
* @provides phui-list-view-css
*/
Add ActionIcon to PHUIListItemView, use in Dashboards Summary: Extends PHUIListItemView to take an icon, link as an "Action Item" that displays on the right side of the menu link. Does not display on Favorites. This allows for adding edit, external, or other links (documentation?) to any menu item. Right now the secondary link is only visible when the item is selected. This feels right, but if we offer it in other ways, users may always want it visible. We could look at making it onhover. Test Plan: Add a bunch of random global and personal dashboards to my menu. Add a menu to Favorites, see no link. Test mobile, link works. {F4136699} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17505
2017-03-16 19:32:01 +01:00
.phui-list-item-view {
position: relative;
}
PHUIList, PHUIDocument updates Summary: This diff covers a bit of ground. - PHUIDocumentExample has been added - PHUIDocument has been extended with new features - PhabricatorMenuView is now PHUIListView - PhabricatorMenuItemView is now PHUIItemListView Overall - I think I've gotten all the edges covered here. There is some derpi-ness that we can talk about, comments in the code. Responsive design is missing from the new features on PHUIDocument, will follow up later. Test Plan: Tested mobile and desktop menus, old phriction layout, new document views, new lists, and object lists. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6130
2013-06-05 17:41:43 +02:00
.phui-list-item-header,
.phui-list-item-header a {
[redesign] Tokens and List Summary: Takes a pass at standardizing spacing and colors for lists and tokens. Test Plan: Tested a lot of lists, policy, timeline, quick create, diffusion. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9325
2014-05-29 05:56:20 +02:00
color: {$bluetext};
PHUIList, PHUIDocument updates Summary: This diff covers a bit of ground. - PHUIDocumentExample has been added - PHUIDocument has been extended with new features - PhabricatorMenuView is now PHUIListView - PhabricatorMenuItemView is now PHUIItemListView Overall - I think I've gotten all the edges covered here. There is some derpi-ness that we can talk about, comments in the code. Responsive design is missing from the new features on PHUIDocument, will follow up later. Test Plan: Tested mobile and desktop menus, old phriction layout, new document views, new lists, and object lists. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6130
2013-06-05 17:41:43 +02:00
font-weight: bold;
[redesign] Tokens and List Summary: Takes a pass at standardizing spacing and colors for lists and tokens. Test Plan: Tested a lot of lists, policy, timeline, quick create, diffusion. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9325
2014-05-29 05:56:20 +02:00
-webkit-font-smoothing: antialiased;
PHUIList, PHUIDocument updates Summary: This diff covers a bit of ground. - PHUIDocumentExample has been added - PHUIDocument has been extended with new features - PhabricatorMenuView is now PHUIListView - PhabricatorMenuItemView is now PHUIItemListView Overall - I think I've gotten all the edges covered here. There is some derpi-ness that we can talk about, comments in the code. Responsive design is missing from the new features on PHUIDocument, will follow up later. Test Plan: Tested mobile and desktop menus, old phriction layout, new document views, new lists, and object lists. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6130
2013-06-05 17:41:43 +02:00
}
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
/* - Sidenav and Actions -------------------------------------------------------
Sidebar and Action Menus
*/
.phui-list-sidenav {
padding: 4px 0;
}
.phui-list-sidenav .phui-list-item-type-label .phui-list-item-name {
font-weight: bold;
[redesign] Tokens and List Summary: Takes a pass at standardizing spacing and colors for lists and tokens. Test Plan: Tested a lot of lists, policy, timeline, quick create, diffusion. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9325
2014-05-29 05:56:20 +02:00
color: {$bluetext};
padding: 4px 8px 6px 8px;
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
display: block;
[redesign] Tokens and List Summary: Takes a pass at standardizing spacing and colors for lists and tokens. Test Plan: Tested a lot of lists, policy, timeline, quick create, diffusion. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9325
2014-05-29 05:56:20 +02:00
-webkit-font-smoothing: antialiased;
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
}
.phui-list-sidenav .phui-list-item-type-divider {
margin: 8px 8px 12px 8px;
[Redesign] Normalize colors on PHUIListView Summary: Darker greys, less background colors, proper borders. Ref T8099 Test Plan: Tested a tab panel and Files application. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12924
2015-05-19 18:02:07 +02:00
border-bottom: 1px solid {$thinblueborder};
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
}
.phui-list-sidenav .phui-list-item-icon {
height: 14px;
width: 14px;
display: inline-block;
position: absolute;
[Redesign] Normalize menus and lists Summary: Ref T8099, An attempt to consolidate spacing, size, and border styles of various dropdown menus and list elements. Test Plan: Look at as many lists as I could find, probably worth collapsing some of the duplicates sometime. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13517
2015-07-02 00:17:44 +02:00
top: 6px;
text-align: center;
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
}
.phui-list-sidenav .phui-list-item-icon + .phui-list-item-name {
padding-left: 20px;
}
.phui-list-sidenav .phui-list-item-has-icon {
margin: 0;
position: relative;
}
PHUIList changes for responsive design Summary: Fixes some issues with lists and tablet/mobile layouts. Test Plan: shrink my screen Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6148
2013-06-06 20:59:14 +02:00
.phui-list-sidenav .phui-list-item-view {
overflow: hidden;
}
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
.phui-list-sidenav .phui-list-item-href {
display: block;
Diviner: improve links, book index, and atom view Summary: Ref T988. Minor improvements to diviner: link stuff to a valid endpoint which actually works; fix group names on the book index; improve the topics index for atom views. Test Plan: Clicked links in an article, viewed book index, viewed an article with long headers. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T988 Differential Revision: https://secure.phabricator.com/D6598
2013-07-28 22:07:30 +02:00
padding: 4px 16px;
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
clear: both;
[redesign] Tokens and List Summary: Takes a pass at standardizing spacing and colors for lists and tokens. Test Plan: Tested a lot of lists, policy, timeline, quick create, diffusion. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9325
2014-05-29 05:56:20 +02:00
color: {$darkgreytext};
Diviner: improve links, book index, and atom view Summary: Ref T988. Minor improvements to diviner: link stuff to a valid endpoint which actually works; fix group names on the book index; improve the topics index for atom views. Test Plan: Clicked links in an article, viewed book index, viewed an article with long headers. Reviewers: btrahan, chad Reviewed By: chad CC: aran Maniphest Tasks: T988 Differential Revision: https://secure.phabricator.com/D6598
2013-07-28 22:07:30 +02:00
line-height: 18px;
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
}
Straighten out reorder permissions on form configurations Summary: Fixes T10012. The permissions here are little weird: you need edit permission on the //configurations//, not the //engines//. I was checking edit permission on the engines only. I should possibly make this a bit more consistent, the engine edit permission is just very convenient to use to enforce object create permission right now. I'll likely clean this up after T9789. Test Plan: - Tried to reorder forms as a less-privileged user, got proper policy errors. - Reordered forms normally as a regular user. Reviewers: chad Reviewed By: chad Subscribers: Luke081515.2 Maniphest Tasks: T10012 Differential Revision: https://secure.phabricator.com/D14824
2015-12-19 15:29:48 +01:00
.phabricator-side-menu .phui-list-item-disabled .phui-list-item-href,
Conpherence - Implement edit rules for rooms Summary: Fixes T7586. If you can't edit a room, the pertinent UI is greyed out. One exception is the title of the room in the full viewer; this crumb is not disabled as it would be hard to read. Otherwise though, everything is disabled nicely. Test Plan: tried to add participants when I wasn't allowed to and got an error. added participants otherwise okay. tried to edit title when i wasn't allowed and got an error. otherwise okay. left conpherence threads / rooms successfully. Reviewers: epriestley, chad Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7586 Differential Revision: https://secure.phabricator.com/D12161
2015-03-25 19:48:22 +01:00
.phui-list-sidenav .phui-list-item-disabled .phui-list-item-href {
color: {$lightgreytext};
}
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
.phui-list-sidenav .phui-list-item-has-icon .phui-list-item-href {
[Redesign] Normalize menus and lists Summary: Ref T8099, An attempt to consolidate spacing, size, and border styles of various dropdown menus and list elements. Test Plan: Look at as many lists as I could find, probably worth collapsing some of the duplicates sometime. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13517
2015-07-02 00:17:44 +02:00
padding: 4px 10px;
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
}
Add a side nav to Conduit API method console pages Summary: Ref T13072. Make large Conduit doc pages a bit more navigable. This prepares for updating "harbormaster.sendmessage" to support sending messages to builds. Test Plan: Viewed various Conduit API documentation pages, clicked links. Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T13072 Differential Revision: https://secure.phabricator.com/D21696
2021-07-16 18:53:10 +02:00
.phabricator-side-menu .phui-list-item-has-icon .phui-list-item-indented {
padding-left: 24px;
Indent multiple items from the same application in Quick Create menu Summary: Ref T10004. Happy to take another approach here or just not bother, this just struck me as a little ambiguous/confusing. Test Plan: Before, not necessarily clear that the "Create Task" header only applies to the first few items. {F1029126} After, more clear: {F1029127} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10004 Differential Revision: https://secure.phabricator.com/D14815
2015-12-17 23:27:02 +01:00
}
PHUIList changes for responsive design Summary: Fixes some issues with lists and tablet/mobile layouts. Test Plan: shrink my screen Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6148
2013-06-06 20:59:14 +02:00
.device-desktop .phui-list-sidenav .phui-list-item-href:hover {
[redesign] Tokens and List Summary: Takes a pass at standardizing spacing and colors for lists and tokens. Test Plan: Tested a lot of lists, policy, timeline, quick create, diffusion. Reviewers: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9325
2014-05-29 05:56:20 +02:00
background: {$sky};
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
color: white;
cursor: pointer;
text-decoration: none;
}
Replace Sprite-Icons with FontAwesome Summary: The removes the sprite sheet 'icons' and replaces it with FontAwesome fonts. Test Plan: - Grep for SPRITE_ICONS and replace - Grep for sprite-icons and replace - Grep for PhabricatorActionList and choose all new icons - Grep for Crumbs and fix icons - Test/Replace PHUIList Icon support - Test/Replace ObjectList Icon support (foot, epoch, etc) - Browse as many pages as I could get to - Remove sprite-icons and move remarkup to own sheet - Review this diff in Differential Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin, hach-que Differential Revision: https://secure.phabricator.com/D9052
2014-05-12 19:08:32 +02:00
.device-desktop .phui-list-sidenav .phui-list-item-href:hover .phui-icon-view {
Add an Experimental Dark Mode to Phabricator Summary: Mostly this is an exercise to clean up our CSS and Celerity processor by making sure all important color decisions are generatable. It's somewhat resonable to use if you don't review code. Posting it up here mostly so I don't lose the work. Test Plan: Visit lots and lots of pages with dark mode on and off. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D18227
2017-07-17 20:08:17 +02:00
color: {$page.content};
Replace Sprite-Icons with FontAwesome Summary: The removes the sprite sheet 'icons' and replaces it with FontAwesome fonts. Test Plan: - Grep for SPRITE_ICONS and replace - Grep for sprite-icons and replace - Grep for PhabricatorActionList and choose all new icons - Grep for Crumbs and fix icons - Test/Replace PHUIList Icon support - Test/Replace ObjectList Icon support (foot, epoch, etc) - Browse as many pages as I could get to - Remove sprite-icons and move remarkup to own sheet - Review this diff in Differential Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin, hach-que Differential Revision: https://secure.phabricator.com/D9052
2014-05-12 19:08:32 +02:00
}
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
/* - Top, Full Width Navigations -----------------------------------------------
Sets a page or box with a top navbar
*/
.phui-list-view.phui-list-navbar {
list-style: none;
overflow: hidden;
Make the "Keyboard Shortcuts" dialog in Differential less hideous Summary: Ref T13515. Adding "\" ("Open in External Editor") made this slighlty worse, but it was already pretty bad. Long ago the keys had a special style on them, but this got changed and dropped somewhere around D16568 -- although at the time, I think they still had a grey background (see T11654). Some later change removed this background. Put the background back and separate the keystrokes into groups. Test Plan: {F7370615} Maniphest Tasks: T13515 Differential Revision: https://secure.phabricator.com/D21141
2020-04-18 20:22:55 +02:00
}
.phui-list-view.phui-list-navbar-horizontal {
[Redesign] Normalize colors on PHUIListView Summary: Darker greys, less background colors, proper borders. Ref T8099 Test Plan: Tested a tab panel and Files application. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12924
2015-05-19 18:02:07 +02:00
border-bottom: 1px solid {$thinblueborder};
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
}
.phui-list-view.phui-list-navbar > li {
list-style: none;
display: block;
Make the "Keyboard Shortcuts" dialog in Differential less hideous Summary: Ref T13515. Adding "\" ("Open in External Editor") made this slighlty worse, but it was already pretty bad. Long ago the keys had a special style on them, but this got changed and dropped somewhere around D16568 -- although at the time, I think they still had a grey background (see T11654). Some later change removed this background. Put the background back and separate the keystrokes into groups. Test Plan: {F7370615} Maniphest Tasks: T13515 Differential Revision: https://secure.phabricator.com/D21141
2020-04-18 20:22:55 +02:00
}
.phui-list-view.phui-list-navbar-horizontal > li {
float: left;
[Redesign] Normalize colors on PHUIListView Summary: Darker greys, less background colors, proper borders. Ref T8099 Test Plan: Tested a tab panel and Files application. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12924
2015-05-19 18:02:07 +02:00
border-right: 1px solid {$thinblueborder};
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
}
.phui-list-navbar .phui-list-item-href {
[Redesign] Normalize colors on PHUIListView Summary: Darker greys, less background colors, proper borders. Ref T8099 Test Plan: Tested a tab panel and Files application. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12924
2015-05-19 18:02:07 +02:00
color: {$bluetext};
[Redesign] Normalize menus and lists Summary: Ref T8099, An attempt to consolidate spacing, size, and border styles of various dropdown menus and list elements. Test Plan: Look at as many lists as I could find, probably worth collapsing some of the duplicates sometime. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13517
2015-07-02 00:17:44 +02:00
line-height: 16px;
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
}
Make the "Keyboard Shortcuts" dialog in Differential less hideous Summary: Ref T13515. Adding "\" ("Open in External Editor") made this slighlty worse, but it was already pretty bad. Long ago the keys had a special style on them, but this got changed and dropped somewhere around D16568 -- although at the time, I think they still had a grey background (see T11654). Some later change removed this background. Put the background back and separate the keystrokes into groups. Test Plan: {F7370615} Maniphest Tasks: T13515 Differential Revision: https://secure.phabricator.com/D21141
2020-04-18 20:22:55 +02:00
.phui-list-navbar-horizontal .phui-list-item-href {
padding: 8px 16px;
}
.phui-list-navbar-vertical .phui-list-item-href {
padding: 8px 12px;
}
.phui-list-navbar-vertical {
box-shadow: 0 1px 0 rgba({$alphablue}, 0.05);
}
.phui-list-navbar-vertical .phui-list-item-href {
display: block;
background: #ffffff;
}
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
.phui-list-navbar .phui-list-item-selected .phui-list-item-href {
[Redesign] Normalize menus and lists Summary: Ref T8099, An attempt to consolidate spacing, size, and border styles of various dropdown menus and list elements. Test Plan: Look at as many lists as I could find, probably worth collapsing some of the duplicates sometime. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13517
2015-07-02 00:17:44 +02:00
background: {$lightbluebackground};
Add top border back to section-headers Summary: This adds back the top border on section headers and cleans up the tab CSS just a hair. Test Plan: tested files, tasks, and custom field profile. Reviewers: epriestley, btrahan CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7378
2013-10-22 17:48:12 +02:00
color: {$darkbluetext};
[Redesign] Normalize menus and lists Summary: Ref T8099, An attempt to consolidate spacing, size, and border styles of various dropdown menus and list elements. Test Plan: Look at as many lists as I could find, probably worth collapsing some of the duplicates sometime. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D13517
2015-07-02 00:17:44 +02:00
font-weight: bold;
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
}
Make the "Keyboard Shortcuts" dialog in Differential less hideous Summary: Ref T13515. Adding "\" ("Open in External Editor") made this slighlty worse, but it was already pretty bad. Long ago the keys had a special style on them, but this got changed and dropped somewhere around D16568 -- although at the time, I think they still had a grey background (see T11654). Some later change removed this background. Put the background back and separate the keystrokes into groups. Test Plan: {F7370615} Maniphest Tasks: T13515 Differential Revision: https://secure.phabricator.com/D21141
2020-04-18 20:22:55 +02:00
.phui-tab-group-view-tab-column {
width: 220px;
border-right: 1px solid {$thinblueborder};
background: {$lightgreybackground};
}
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
.phui-list-navbar .phui-list-item-href:hover {
[Redesign] Normalize colors on PHUIListView Summary: Darker greys, less background colors, proper borders. Ref T8099 Test Plan: Tested a tab panel and Files application. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T8099 Differential Revision: https://secure.phabricator.com/D12924
2015-05-19 18:02:07 +02:00
background: rgba(100,100,100,.1);
Add top border back to section-headers Summary: This adds back the top border on section headers and cleans up the tab CSS just a hair. Test Plan: tested files, tasks, and custom field profile. Reviewers: epriestley, btrahan CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7378
2013-10-22 17:48:12 +02:00
color: {$darkgreytext};
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
text-decoration: none;
}
.phui-list-navbar .phui-list-item-icon {
height: 14px;
width: 14px;
Replace Sprite-Icons with FontAwesome Summary: The removes the sprite sheet 'icons' and replaces it with FontAwesome fonts. Test Plan: - Grep for SPRITE_ICONS and replace - Grep for sprite-icons and replace - Grep for PhabricatorActionList and choose all new icons - Grep for Crumbs and fix icons - Test/Replace PHUIList Icon support - Test/Replace ObjectList Icon support (foot, epoch, etc) - Browse as many pages as I could get to - Remove sprite-icons and move remarkup to own sheet - Review this diff in Differential Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin, hach-que Differential Revision: https://secure.phabricator.com/D9052
2014-05-12 19:08:32 +02:00
font-size: 14px;
Make the "Keyboard Shortcuts" dialog in Differential less hideous Summary: Ref T13515. Adding "\" ("Open in External Editor") made this slighlty worse, but it was already pretty bad. Long ago the keys had a special style on them, but this got changed and dropped somewhere around D16568 -- although at the time, I think they still had a grey background (see T11654). Some later change removed this background. Put the background back and separate the keystrokes into groups. Test Plan: {F7370615} Maniphest Tasks: T13515 Differential Revision: https://secure.phabricator.com/D21141
2020-04-18 20:22:55 +02:00
text-align: center;
}
.phui-list-navbar-vertical .phui-list-item-icon {
margin-right: 8px;
}
.phui-list-navbar-horizontal .phui-list-item-icon {
display: block;
PHUIListView Examples, CSS Summary: This adds examples and abstracts out CSS for common nav re-use. Test Plan: Tested DocumentExample and ListExample Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6138
2013-06-06 00:03:56 +02:00
}
PHUIList changes for responsive design Summary: Fixes some issues with lists and tablet/mobile layouts. Test Plan: shrink my screen Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6148
2013-06-06 20:59:14 +02:00
Make the "Keyboard Shortcuts" dialog in Differential less hideous Summary: Ref T13515. Adding "\" ("Open in External Editor") made this slighlty worse, but it was already pretty bad. Long ago the keys had a special style on them, but this got changed and dropped somewhere around D16568 -- although at the time, I think they still had a grey background (see T11654). Some later change removed this background. Put the background back and separate the keystrokes into groups. Test Plan: {F7370615} Maniphest Tasks: T13515 Differential Revision: https://secure.phabricator.com/D21141
2020-04-18 20:22:55 +02:00
.device-phone .phui-list-view.phui-list-navbar-horizontal > li {
PHUIList changes for responsive design Summary: Fixes some issues with lists and tablet/mobile layouts. Test Plan: shrink my screen Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6148
2013-06-06 20:59:14 +02:00
float: none;
PHUIDocument view for mobile devices. Summary: Adds collapsing of the sidebar, also allows you to say where it goes on mobile (above or below content). ToC for example, above. General Navbar, below. Up to you. Test Plan: Review UIExamples and Diviner. Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6150
2013-06-06 21:47:40 +02:00
border: none;
PHUIList changes for responsive design Summary: Fixes some issues with lists and tablet/mobile layouts. Test Plan: shrink my screen Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6148
2013-06-06 20:59:14 +02:00
}
Adds status colors to navbar tabs Summary: Adds the abilit to set a status color of warning or fail to navbar tab lists (for objectheaders) Test Plan: uiexamples, photoshop Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7266
2013-10-08 04:29:05 +02:00
Add a top level tab navigation option to PHUITwoColumnView Summary: Builds out a responsive tab bar system for PHUITwoColumnView pages Test Plan: Tested at mobile, tablet, and desktop breakpoints {F5012429} {F5012430} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D18148
2017-06-22 21:10:48 +02:00
/* - Two Column View, Responsive Navigations -----------------------------------
Sets a two column page with a responsive, top navbar
*/
.phui-list-view.phui-list-tabbar {
list-style: none;
overflow: hidden;
}
.phui-list-view.phui-list-tabbar > li {
list-style: none;
float: left;
display: block;
}
.phui-list-view.phui-list-tabbar > li > * {
display: block;
}
.phui-list-tabbar .phui-list-item-href {
color: {$bluetext};
padding: 8px 24px;
line-height: 24px;
font-weight: bold;
font-size: {$biggerfontsize};
Add an Experimental Dark Mode to Phabricator Summary: Mostly this is an exercise to clean up our CSS and Celerity processor by making sure all important color decisions are generatable. It's somewhat resonable to use if you don't review code. Posting it up here mostly so I don't lose the work. Test Plan: Visit lots and lots of pages with dark mode on and off. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D18227
2017-07-17 20:08:17 +02:00
border-top: 4px solid transparent;
Add a top level tab navigation option to PHUITwoColumnView Summary: Builds out a responsive tab bar system for PHUITwoColumnView pages Test Plan: Tested at mobile, tablet, and desktop breakpoints {F5012429} {F5012430} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D18148
2017-06-22 21:10:48 +02:00
}
.phui-list-tabbar .phui-list-item-selected .phui-list-item-href {
color: {$sky};
border-bottom: 4px solid {$sky};
}
.phui-list-tabbar .phui-list-item-selected .phui-list-item-href
.phui-icon-view {
color: {$sky};
}
.device-desktop .phui-list-tabbar .phui-list-item-href:hover {
color: {$sky};
text-decoration: none;
}
.phui-list-tabbar .phui-list-item-icon {
height: 20px;
width: 20px;
display: none;
font-size: 20px;
text-align: center;
}
.device-phone .phui-list-tabbar .phui-list-item-icon {
display: inline-block;
}
.device-phone .phui-list-tabbar .phui-list-item-name {
display: none;
}
.device-phone .phui-list-tabbar .phui-list-item-href {
padding: 8px 16px;
}
.device-phone .phui-list-view.phui-list-navbar > li {
float: none;
border: none;
}
Adds status colors to navbar tabs Summary: Adds the abilit to set a status color of warning or fail to navbar tab lists (for objectheaders) Test Plan: uiexamples, photoshop Reviewers: epriestley Reviewed By: epriestley CC: Korvin, epriestley, aran Differential Revision: https://secure.phabricator.com/D7266
2013-10-08 04:29:05 +02:00
/* - Status Colors -------------------------------------------------------------
Colors for navbars
*/
.phui-list-item-warn .phui-list-item-href {
color: #bc7837;
}
.phui-list-item-fail .phui-list-item-href {
color: {$red};
}
.phui-list-item-warn.phui-list-item-selected .phui-list-item-href,
.phui-list-item-warn .phui-list-item-href:hover {
background: {$lightyellow};
color: #bc7837;
}
.phui-list-item-fail.phui-list-item-selected .phui-list-item-href,
.phui-list-item-fail .phui-list-item-href:hover {
background: {$lightred};
color: {$red};
}
.phui-list-item-warn.phui-list-item-selected .phui-list-item-href:hover {
background: #fcf0bd;
}
.phui-list-item-fail.phui-list-item-selected .phui-list-item-href:hover {
background: #f5d3d0;
}
Style text boxes and tab panels in dashboards Summary: Adds basic borders, spacing to tab panels and text boxes. Test Plan: Added some of each to my Dashboard. {F157622} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5078 Differential Revision: https://secure.phabricator.com/D9216
2014-05-20 19:53:16 +02:00
/* - Dashboards ------------------------------------------------------------ */
.dashboard-panel .phui-list-view.phui-list-navbar {
border-left: 1px solid {$lightblueborder};
border-right: 1px solid {$lightblueborder};
Dashboard CSS updates Summary: Updates ObjectList dashboarda and tweaks minor css items elsewhere. Test Plan: Test my dashboard, editing, and standalone Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9275
2014-05-24 06:48:15 +02:00
border-bottom: 1px solid {$thinblueborder};
Style text boxes and tab panels in dashboards Summary: Adds basic borders, spacing to tab panels and text boxes. Test Plan: Added some of each to my Dashboard. {F157622} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5078 Differential Revision: https://secure.phabricator.com/D9216
2014-05-20 19:53:16 +02:00
}
[Redesign] Misc Buggypoos Summary: - Give preference to Segoe on Windows - Move to Lato headers except documents - Fix diviner issues - Fix feed overwriting line-height - Fix apps launcher - Fix infoview + listview - Make tall headers less tall - Legalpad, Diviner tweaks Test Plan: Random surfing. @epriestley can you just commit this for me, connection generally shitty. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D13305
2015-06-16 15:46:53 +02:00
Hide Archived Panels from Dashboards Summary: In edit mode, Archived Panels are shown differently, with content text in grey and with the usual red tag. In view mode, Archived Panels are just not rendered. This makes it easier to design Dashboards with individual components that can be de-activated and re-activated on the fly. Closes T15366. {F325637} Test Plan: Have a Dashboard somewhere (e.g in your homepage). Visit a Panel (W-ID) and Archive it. See that now the Panel is not shown anymore on the Dashboard. Edit the Dashboard and you see the Panel again as "Archived". Anything around is just normal. Reviewers: O1 Blessed Committers, avivey Reviewed By: O1 Blessed Committers, avivey Subscribers: avivey, speck, tobiaswiese, Matthew, Cigaryno Maniphest Tasks: T15366 Differential Revision: https://we.phorge.it/D25368
2023-08-01 09:39:18 +02:00
.dashboard-panel-disabled {
color: {$lightgreytext};
}
[Redesign] Misc Buggypoos Summary: - Give preference to Segoe on Windows - Move to Lato headers except documents - Fix diviner issues - Fix feed overwriting line-height - Fix apps launcher - Fix infoview + listview - Make tall headers less tall - Legalpad, Diviner tweaks Test Plan: Random surfing. @epriestley can you just commit this for me, connection generally shitty. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Differential Revision: https://secure.phabricator.com/D13305
2015-06-16 15:46:53 +02:00
/* - Info Stack ------------------------------------------------------------ */
.phui-info-view + .phui-list-view {
margin-top: 16px;
border-top: 1px solid {$thinblueborder};
}
Add ActionIcon to PHUIListItemView, use in Dashboards Summary: Extends PHUIListItemView to take an icon, link as an "Action Item" that displays on the right side of the menu link. Does not display on Favorites. This allows for adding edit, external, or other links (documentation?) to any menu item. Right now the secondary link is only visible when the item is selected. This feels right, but if we offer it in other ways, users may always want it visible. We could look at making it onhover. Test Plan: Add a bunch of random global and personal dashboards to my menu. Add a menu to Favorites, see no link. Test mobile, link works. {F4136699} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17505
2017-03-16 19:32:01 +01:00
/* - Action Icon ----------------------------------------------------------- */
Index and surface usage sites for Dashboards Summary: Depends on D20397. Ref T13272. Similar to the recent "where are Herald rules used" stuff, show which menus Dashboards are installed in. This is mostly straightforward, except that I pulled some of the Herald logic into a parent class so it could be shared. Test Plan: {F6369164} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13272 Differential Revision: https://secure.phabricator.com/D20398
2019-04-11 18:58:48 +02:00
.phabricator-nav-local .phui-list-item-has-action-icon
.phui-list-item-action-href {
Add ActionIcon to PHUIListItemView, use in Dashboards Summary: Extends PHUIListItemView to take an icon, link as an "Action Item" that displays on the right side of the menu link. Does not display on Favorites. This allows for adding edit, external, or other links (documentation?) to any menu item. Right now the secondary link is only visible when the item is selected. This feels right, but if we offer it in other ways, users may always want it visible. We could look at making it onhover. Test Plan: Add a bunch of random global and personal dashboards to my menu. Add a menu to Favorites, see no link. Test mobile, link works. {F4136699} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17505
2017-03-16 19:32:01 +01:00
position: absolute;
width: 28px;
top: 0;
right: 0;
bottom: 0;
text-align: center;
line-height: 28px;
background-color: transparent;
display: none;
}
Index and surface usage sites for Dashboards Summary: Depends on D20397. Ref T13272. Similar to the recent "where are Herald rules used" stuff, show which menus Dashboards are installed in. This is mostly straightforward, except that I pulled some of the Herald logic into a parent class so it could be shared. Test Plan: {F6369164} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13272 Differential Revision: https://secure.phabricator.com/D20398
2019-04-11 18:58:48 +02:00
.phabricator-nav-local .phui-list-item-has-action-icon.phui-list-item-selected
On Dashboard tab panels in edit mode, make the "Tab Name" and the "Dropdown Edit Caret" into different links Summary: Ref T13272. In edit mode, tab panels now have a dropdown menu. However, this sort of overrlaps with the actual action of clicking the tab to select it. Separate these into different click targets so that "select tab X" and "open dropdown menu for X" are different operations. This is more work than it appears because: - We have an "action icon" already, used when you put a dashboard on a portal/home to create an "Edit" link. It makes sense to attach dropdowns to this, but it has some hard-coded stuff. - In applications with a "Create <thing>" in the crumbs (like Maniphest), we may use a dropdown menu if there are multiple create forms available. However, this menu renders in a weird way by reading all the properties out of an actual "View" object and building something else. - The "list of tabs" stuff shares code with different "list of tabs" navigation used by Diffusion and Instances. ..but I think I fixed everything and didn't break anything. Test Plan: - Clicked "select tab" and "open dropdown menu" as separate actions. - Viewed Diffusion, Maniphest with multiple create forms, Instances. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13272 Differential Revision: https://secure.phabricator.com/D20396
2019-04-11 16:12:13 +02:00
.phui-list-item-href {
Add ActionIcon to PHUIListItemView, use in Dashboards Summary: Extends PHUIListItemView to take an icon, link as an "Action Item" that displays on the right side of the menu link. Does not display on Favorites. This allows for adding edit, external, or other links (documentation?) to any menu item. Right now the secondary link is only visible when the item is selected. This feels right, but if we offer it in other ways, users may always want it visible. We could look at making it onhover. Test Plan: Add a bunch of random global and personal dashboards to my menu. Add a menu to Favorites, see no link. Test mobile, link works. {F4136699} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17505
2017-03-16 19:32:01 +01:00
padding-right: 32px;
}
Index and surface usage sites for Dashboards Summary: Depends on D20397. Ref T13272. Similar to the recent "where are Herald rules used" stuff, show which menus Dashboards are installed in. This is mostly straightforward, except that I pulled some of the Herald logic into a parent class so it could be shared. Test Plan: {F6369164} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13272 Differential Revision: https://secure.phabricator.com/D20398
2019-04-11 18:58:48 +02:00
.phabricator-nav-local .phui-list-item-has-action-icon.phui-list-item-selected
Add ActionIcon to PHUIListItemView, use in Dashboards Summary: Extends PHUIListItemView to take an icon, link as an "Action Item" that displays on the right side of the menu link. Does not display on Favorites. This allows for adding edit, external, or other links (documentation?) to any menu item. Right now the secondary link is only visible when the item is selected. This feels right, but if we offer it in other ways, users may always want it visible. We could look at making it onhover. Test Plan: Add a bunch of random global and personal dashboards to my menu. Add a menu to Favorites, see no link. Test mobile, link works. {F4136699} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17505
2017-03-16 19:32:01 +01:00
.phui-list-item-action-href {
display: block;
}
Index and surface usage sites for Dashboards Summary: Depends on D20397. Ref T13272. Similar to the recent "where are Herald rules used" stuff, show which menus Dashboards are installed in. This is mostly straightforward, except that I pulled some of the Herald logic into a parent class so it could be shared. Test Plan: {F6369164} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13272 Differential Revision: https://secure.phabricator.com/D20398
2019-04-11 18:58:48 +02:00
.phabricator-nav-local .phui-list-item-has-action-icon
On Dashboard tab panels in edit mode, make the "Tab Name" and the "Dropdown Edit Caret" into different links Summary: Ref T13272. In edit mode, tab panels now have a dropdown menu. However, this sort of overrlaps with the actual action of clicking the tab to select it. Separate these into different click targets so that "select tab X" and "open dropdown menu for X" are different operations. This is more work than it appears because: - We have an "action icon" already, used when you put a dashboard on a portal/home to create an "Edit" link. It makes sense to attach dropdowns to this, but it has some hard-coded stuff. - In applications with a "Create <thing>" in the crumbs (like Maniphest), we may use a dropdown menu if there are multiple create forms available. However, this menu renders in a weird way by reading all the properties out of an actual "View" object and building something else. - The "list of tabs" stuff shares code with different "list of tabs" navigation used by Diffusion and Instances. ..but I think I fixed everything and didn't break anything. Test Plan: - Clicked "select tab" and "open dropdown menu" as separate actions. - Viewed Diffusion, Maniphest with multiple create forms, Instances. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13272 Differential Revision: https://secure.phabricator.com/D20396
2019-04-11 16:12:13 +02:00
.phui-list-item-action-href:hover {
Add ActionIcon to PHUIListItemView, use in Dashboards Summary: Extends PHUIListItemView to take an icon, link as an "Action Item" that displays on the right side of the menu link. Does not display on Favorites. This allows for adding edit, external, or other links (documentation?) to any menu item. Right now the secondary link is only visible when the item is selected. This feels right, but if we offer it in other ways, users may always want it visible. We could look at making it onhover. Test Plan: Add a bunch of random global and personal dashboards to my menu. Add a menu to Favorites, see no link. Test mobile, link works. {F4136699} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17505
2017-03-16 19:32:01 +01:00
background-color: rgba({$alphablack},.05);
}
Index and surface usage sites for Dashboards Summary: Depends on D20397. Ref T13272. Similar to the recent "where are Herald rules used" stuff, show which menus Dashboards are installed in. This is mostly straightforward, except that I pulled some of the Herald logic into a parent class so it could be shared. Test Plan: {F6369164} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13272 Differential Revision: https://secure.phabricator.com/D20398
2019-04-11 18:58:48 +02:00
.phabricator-nav-local .phui-list-item-has-action-icon
.phui-list-item-action-icon {
Add ActionIcon to PHUIListItemView, use in Dashboards Summary: Extends PHUIListItemView to take an icon, link as an "Action Item" that displays on the right side of the menu link. Does not display on Favorites. This allows for adding edit, external, or other links (documentation?) to any menu item. Right now the secondary link is only visible when the item is selected. This feels right, but if we offer it in other ways, users may always want it visible. We could look at making it onhover. Test Plan: Add a bunch of random global and personal dashboards to my menu. Add a menu to Favorites, see no link. Test mobile, link works. {F4136699} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17505
2017-03-16 19:32:01 +01:00
opacity: 0.5;
}
Index and surface usage sites for Dashboards Summary: Depends on D20397. Ref T13272. Similar to the recent "where are Herald rules used" stuff, show which menus Dashboards are installed in. This is mostly straightforward, except that I pulled some of the Herald logic into a parent class so it could be shared. Test Plan: {F6369164} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13272 Differential Revision: https://secure.phabricator.com/D20398
2019-04-11 18:58:48 +02:00
.phabricator-nav-local .phui-list-item-has-action-icon
On Dashboard tab panels in edit mode, make the "Tab Name" and the "Dropdown Edit Caret" into different links Summary: Ref T13272. In edit mode, tab panels now have a dropdown menu. However, this sort of overrlaps with the actual action of clicking the tab to select it. Separate these into different click targets so that "select tab X" and "open dropdown menu for X" are different operations. This is more work than it appears because: - We have an "action icon" already, used when you put a dashboard on a portal/home to create an "Edit" link. It makes sense to attach dropdowns to this, but it has some hard-coded stuff. - In applications with a "Create <thing>" in the crumbs (like Maniphest), we may use a dropdown menu if there are multiple create forms available. However, this menu renders in a weird way by reading all the properties out of an actual "View" object and building something else. - The "list of tabs" stuff shares code with different "list of tabs" navigation used by Diffusion and Instances. ..but I think I fixed everything and didn't break anything. Test Plan: - Clicked "select tab" and "open dropdown menu" as separate actions. - Viewed Diffusion, Maniphest with multiple create forms, Instances. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13272 Differential Revision: https://secure.phabricator.com/D20396
2019-04-11 16:12:13 +02:00
.phui-list-item-action-href:hover
Add ActionIcon to PHUIListItemView, use in Dashboards Summary: Extends PHUIListItemView to take an icon, link as an "Action Item" that displays on the right side of the menu link. Does not display on Favorites. This allows for adding edit, external, or other links (documentation?) to any menu item. Right now the secondary link is only visible when the item is selected. This feels right, but if we offer it in other ways, users may always want it visible. We could look at making it onhover. Test Plan: Add a bunch of random global and personal dashboards to my menu. Add a menu to Favorites, see no link. Test mobile, link works. {F4136699} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17505
2017-03-16 19:32:01 +01:00
.phui-list-item-action-icon {
On Dashboard tab panels in edit mode, make the "Tab Name" and the "Dropdown Edit Caret" into different links Summary: Ref T13272. In edit mode, tab panels now have a dropdown menu. However, this sort of overrlaps with the actual action of clicking the tab to select it. Separate these into different click targets so that "select tab X" and "open dropdown menu for X" are different operations. This is more work than it appears because: - We have an "action icon" already, used when you put a dashboard on a portal/home to create an "Edit" link. It makes sense to attach dropdowns to this, but it has some hard-coded stuff. - In applications with a "Create <thing>" in the crumbs (like Maniphest), we may use a dropdown menu if there are multiple create forms available. However, this menu renders in a weird way by reading all the properties out of an actual "View" object and building something else. - The "list of tabs" stuff shares code with different "list of tabs" navigation used by Diffusion and Instances. ..but I think I fixed everything and didn't break anything. Test Plan: - Clicked "select tab" and "open dropdown menu" as separate actions. - Viewed Diffusion, Maniphest with multiple create forms, Instances. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13272 Differential Revision: https://secure.phabricator.com/D20396
2019-04-11 16:12:13 +02:00
opacity: 1;
Add ActionIcon to PHUIListItemView, use in Dashboards Summary: Extends PHUIListItemView to take an icon, link as an "Action Item" that displays on the right side of the menu link. Does not display on Favorites. This allows for adding edit, external, or other links (documentation?) to any menu item. Right now the secondary link is only visible when the item is selected. This feels right, but if we offer it in other ways, users may always want it visible. We could look at making it onhover. Test Plan: Add a bunch of random global and personal dashboards to my menu. Add a menu to Favorites, see no link. Test mobile, link works. {F4136699} Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17505
2017-03-16 19:32:01 +01:00
}
Fix Durable Column CSS-Overload Summary: This moves the count on the Conpherence Menu Item into a phui-list-item-count, and removes the CSS call to the entire Conphrence stack when durable column is open. Test Plan: Test with and without the chat column, and a menu with a count Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17677
2017-04-13 20:20:51 +02:00
/* - Item Counts ----------------------------------------------------------- */
.phui-list-item-count {
position: absolute;
right: 7px;
top: 7px;
background: {$blue};
border-radius: 2px;
color: #fff;
font-weight: bold;
padding: 0 5px 1px;
font-size: {$smallestfontsize};
}
Copy permalink