2012-12-11 22:59:20 +01:00
|
|
|
<?php
|
|
|
|
|
|
|
|
abstract class PhabricatorApplicationTransaction
|
|
|
|
extends PhabricatorLiskDAO
|
Modernize Macro application
Summary: Adds feed, email, notifications, comments, partial editing, subscriptions, enable/disable, flags and crumbs to Macro.
Test Plan:
{F26839}
{F26840}
{F26841}
{F26842}
{F26843}
{F26844}
{F26845}
Reviewers: vrana, btrahan, chad
Reviewed By: vrana
CC: aran
Maniphest Tasks: T2157, T175, T2104
Differential Revision: https://secure.phabricator.com/D4141
2012-12-11 23:01:03 +01:00
|
|
|
implements PhabricatorPolicyInterface {
|
2012-12-11 22:59:20 +01:00
|
|
|
|
2012-12-11 23:00:07 +01:00
|
|
|
const TARGET_TEXT = 'text';
|
|
|
|
const TARGET_HTML = 'html';
|
|
|
|
|
2012-12-11 22:59:20 +01:00
|
|
|
protected $phid;
|
|
|
|
protected $objectPHID;
|
|
|
|
protected $authorPHID;
|
|
|
|
protected $viewPolicy;
|
|
|
|
protected $editPolicy;
|
|
|
|
|
|
|
|
protected $commentPHID;
|
|
|
|
protected $commentVersion = 0;
|
|
|
|
protected $transactionType;
|
|
|
|
protected $oldValue;
|
|
|
|
protected $newValue;
|
|
|
|
|
|
|
|
protected $contentSource;
|
|
|
|
|
|
|
|
private $comment;
|
|
|
|
private $commentNotLoaded;
|
|
|
|
|
|
|
|
private $handles;
|
2012-12-11 23:00:07 +01:00
|
|
|
private $renderingTarget = self::TARGET_HTML;
|
2012-12-11 22:59:20 +01:00
|
|
|
|
|
|
|
abstract public function getApplicationTransactionType();
|
|
|
|
abstract public function getApplicationTransactionCommentObject();
|
|
|
|
abstract public function getApplicationObjectTypeName();
|
|
|
|
|
|
|
|
public function generatePHID() {
|
|
|
|
$type = PhabricatorPHIDConstants::PHID_TYPE_XACT;
|
|
|
|
$subtype = $this->getApplicationTransactionType();
|
|
|
|
|
|
|
|
return PhabricatorPHID::generateNewPHID($type, $subtype);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getConfiguration() {
|
|
|
|
return array(
|
|
|
|
self::CONFIG_AUX_PHID => true,
|
|
|
|
self::CONFIG_SERIALIZATION => array(
|
|
|
|
'oldValue' => self::SERIALIZATION_JSON,
|
|
|
|
'newValue' => self::SERIALIZATION_JSON,
|
|
|
|
),
|
|
|
|
) + parent::getConfiguration();
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setContentSource(PhabricatorContentSource $content_source) {
|
|
|
|
$this->contentSource = $content_source->serialize();
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getContentSource() {
|
|
|
|
return PhabricatorContentSource::newFromSerialized($this->contentSource);
|
|
|
|
}
|
|
|
|
|
Modernize Macro application
Summary: Adds feed, email, notifications, comments, partial editing, subscriptions, enable/disable, flags and crumbs to Macro.
Test Plan:
{F26839}
{F26840}
{F26841}
{F26842}
{F26843}
{F26844}
{F26845}
Reviewers: vrana, btrahan, chad
Reviewed By: vrana
CC: aran
Maniphest Tasks: T2157, T175, T2104
Differential Revision: https://secure.phabricator.com/D4141
2012-12-11 23:01:03 +01:00
|
|
|
public function hasComment() {
|
|
|
|
return $this->getComment() && strlen($this->getComment()->getContent());
|
|
|
|
}
|
|
|
|
|
2012-12-11 22:59:20 +01:00
|
|
|
public function getComment() {
|
|
|
|
if ($this->commentNotLoaded) {
|
|
|
|
throw new Exception("Comment for this transaction was not loaded.");
|
|
|
|
}
|
|
|
|
return $this->comment;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function attachComment(
|
|
|
|
PhabricatorApplicationTransactionComment $comment) {
|
|
|
|
$this->comment = $comment;
|
|
|
|
$this->commentNotLoaded = false;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setCommentNotLoaded($not_loaded) {
|
|
|
|
$this->commentNotLoaded = $not_loaded;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* -( Rendering )---------------------------------------------------------- */
|
|
|
|
|
2012-12-11 23:00:07 +01:00
|
|
|
public function setRenderingTarget($rendering_target) {
|
|
|
|
$this->renderingTarget = $rendering_target;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getRenderingTarget() {
|
|
|
|
return $this->renderingTarget;
|
|
|
|
}
|
|
|
|
|
2012-12-11 22:59:20 +01:00
|
|
|
public function getRequiredHandlePHIDs() {
|
|
|
|
$phids = array();
|
|
|
|
|
|
|
|
$old = $this->getOldValue();
|
|
|
|
$new = $this->getNewValue();
|
|
|
|
|
|
|
|
$phids[] = array($this->getAuthorPHID());
|
|
|
|
switch ($this->getTransactionType()) {
|
|
|
|
case PhabricatorTransactions::TYPE_SUBSCRIBERS:
|
|
|
|
$phids[] = $old;
|
|
|
|
$phids[] = $new;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return array_mergev($phids);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function setHandles(array $handles) {
|
|
|
|
$this->handles = $handles;
|
|
|
|
return $this;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getHandle($phid) {
|
|
|
|
if (empty($this->handles[$phid])) {
|
|
|
|
throw new Exception(
|
|
|
|
"Transaction requires a handle ('{$phid}') it did not load.");
|
|
|
|
}
|
|
|
|
return $this->handles[$phid];
|
|
|
|
}
|
|
|
|
|
2013-01-25 02:23:05 +01:00
|
|
|
public function getHandles() {
|
|
|
|
if ($this->handles === null) {
|
|
|
|
throw new Exception(
|
|
|
|
'Transaction requires handles and it did not load them.'
|
|
|
|
);
|
|
|
|
}
|
|
|
|
return $this->handles;
|
|
|
|
}
|
|
|
|
|
2012-12-11 22:59:20 +01:00
|
|
|
protected function renderHandleLink($phid) {
|
2012-12-11 23:00:07 +01:00
|
|
|
if ($this->renderingTarget == self::TARGET_HTML) {
|
|
|
|
return $this->getHandle($phid)->renderLink();
|
|
|
|
} else {
|
2013-02-13 23:50:15 +01:00
|
|
|
return hsprintf('%s', $this->getHandle($phid)->getName());
|
2012-12-11 23:00:07 +01:00
|
|
|
}
|
2012-12-11 22:59:20 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
protected function renderHandleList(array $phids) {
|
|
|
|
$links = array();
|
|
|
|
foreach ($phids as $phid) {
|
|
|
|
$links[] = $this->renderHandleLink($phid);
|
|
|
|
}
|
2013-02-13 23:50:15 +01:00
|
|
|
return phutil_implode_html(', ', $links);
|
2012-12-11 22:59:20 +01:00
|
|
|
}
|
|
|
|
|
2012-12-11 22:59:35 +01:00
|
|
|
public function getIcon() {
|
Modernize Macro application
Summary: Adds feed, email, notifications, comments, partial editing, subscriptions, enable/disable, flags and crumbs to Macro.
Test Plan:
{F26839}
{F26840}
{F26841}
{F26842}
{F26843}
{F26844}
{F26845}
Reviewers: vrana, btrahan, chad
Reviewed By: vrana
CC: aran
Maniphest Tasks: T2157, T175, T2104
Differential Revision: https://secure.phabricator.com/D4141
2012-12-11 23:01:03 +01:00
|
|
|
switch ($this->getTransactionType()) {
|
|
|
|
case PhabricatorTransactions::TYPE_COMMENT:
|
|
|
|
return 'comment';
|
|
|
|
case PhabricatorTransactions::TYPE_SUBSCRIBERS:
|
|
|
|
return 'message';
|
|
|
|
case PhabricatorTransactions::TYPE_VIEW_POLICY:
|
|
|
|
case PhabricatorTransactions::TYPE_EDIT_POLICY:
|
|
|
|
return 'lock';
|
|
|
|
}
|
|
|
|
|
2012-12-11 22:59:35 +01:00
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getColor() {
|
|
|
|
return null;
|
|
|
|
}
|
|
|
|
|
2012-12-11 22:59:20 +01:00
|
|
|
public function shouldHide() {
|
|
|
|
switch ($this->getTransactionType()) {
|
|
|
|
case PhabricatorTransactions::TYPE_VIEW_POLICY:
|
|
|
|
case PhabricatorTransactions::TYPE_EDIT_POLICY:
|
|
|
|
if ($this->getOldValue() === null) {
|
|
|
|
return true;
|
|
|
|
} else {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
Add ApplicationTransaction handling for transactions with no effect
Summary:
When a user submits an action with no effect (like an empty comment, an "abandon" on an already-accepted revision, or a "close, resolved" on a closed task) we want to alert them that their action isn't effective. These warnings fall into two general buckets:
- User is submitting two or more actions, and some aren't effective but some are. Prompt them to apply the effective actions only.
- A special case of this is where the only effective action is a comment. We provide tailored text ("Post Comment") in this case.
- User is submitting one action, which isn't effective. Tell them they're out of luck.
- A special case of this is an empty comment. We provide tailored text in this case.
By default, the transaction editor throws when transactions have no effect. The caller can then deal with this, or use `PhabricatorApplicationTransactionNoEffectResponse` to provide a standard dialog that gives the user information as above. For cases where we expect transactions to have no effect (notably, "edit" forms) we just continue on no-effect unconditionally.
Also fix an issue where new, combined or filtered transactions would not be represented properly in the Ajax response (i.e., return final transactions from `applyTransactions()`), and translate some strings.
Test Plan:
- Submitted empty and nonempy comments in Macro and Pholio.
- Submitted comments with new and existing "@mentions".
- Submitted edits in both applications.
Reviewers: btrahan, vrana
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T912, T2104
Differential Revision: https://secure.phabricator.com/D4160
2012-12-12 02:27:40 +01:00
|
|
|
public function getNoEffectDescription() {
|
|
|
|
|
|
|
|
switch ($this->getTransactionType()) {
|
|
|
|
case PhabricatorTransactions::TYPE_COMMENT:
|
|
|
|
return pht('You can not post an empty comment.');
|
|
|
|
case PhabricatorTransactions::TYPE_VIEW_POLICY:
|
|
|
|
return pht(
|
|
|
|
'This %s already has that view policy.',
|
|
|
|
$this->getApplicationObjectTypeName());
|
|
|
|
case PhabricatorTransactions::TYPE_EDIT_POLICY:
|
|
|
|
return pht(
|
|
|
|
'This %s already has that edit policy.',
|
|
|
|
$this->getApplicationObjectTypeName());
|
|
|
|
case PhabricatorTransactions::TYPE_SUBSCRIBERS:
|
|
|
|
return pht(
|
|
|
|
'All users are already subscribed to this %s.',
|
|
|
|
$this->getApplicationObjectTypeName());
|
|
|
|
}
|
|
|
|
|
|
|
|
return pht('Transaction has no effect.');
|
|
|
|
}
|
|
|
|
|
2012-12-11 22:59:20 +01:00
|
|
|
public function getTitle() {
|
|
|
|
$author_phid = $this->getAuthorPHID();
|
|
|
|
|
|
|
|
$old = $this->getOldValue();
|
|
|
|
$new = $this->getNewValue();
|
|
|
|
|
|
|
|
switch ($this->getTransactionType()) {
|
|
|
|
case PhabricatorTransactions::TYPE_COMMENT:
|
|
|
|
return pht(
|
|
|
|
'%s added a comment.',
|
|
|
|
$this->renderHandleLink($author_phid));
|
|
|
|
case PhabricatorTransactions::TYPE_VIEW_POLICY:
|
|
|
|
// TODO: Render human-readable.
|
|
|
|
return pht(
|
|
|
|
'%s changed the visibility of this %s from "%s" to "%s".',
|
|
|
|
$this->renderHandleLink($author_phid),
|
|
|
|
$this->getApplicationObjectTypeName(),
|
2013-02-13 23:50:15 +01:00
|
|
|
$old,
|
|
|
|
$new);
|
2012-12-11 22:59:20 +01:00
|
|
|
case PhabricatorTransactions::TYPE_EDIT_POLICY:
|
|
|
|
// TODO: Render human-readable.
|
|
|
|
return pht(
|
|
|
|
'%s changed the edit policy of this %s from "%s" to "%s".',
|
|
|
|
$this->renderHandleLink($author_phid),
|
|
|
|
$this->getApplicationObjectTypeName(),
|
2013-02-13 23:50:15 +01:00
|
|
|
$old,
|
|
|
|
$new);
|
2012-12-11 22:59:20 +01:00
|
|
|
case PhabricatorTransactions::TYPE_SUBSCRIBERS:
|
|
|
|
$add = array_diff($new, $old);
|
|
|
|
$rem = array_diff($old, $new);
|
|
|
|
|
|
|
|
if ($add && $rem) {
|
|
|
|
return pht(
|
|
|
|
'%s edited subscriber(s), added %d: %s; removed %d: %s.',
|
|
|
|
$this->renderHandleLink($author_phid),
|
|
|
|
count($add),
|
|
|
|
$this->renderHandleList($add),
|
|
|
|
count($rem),
|
|
|
|
$this->renderHandleList($rem));
|
|
|
|
} else if ($add) {
|
|
|
|
return pht(
|
|
|
|
'%s added %d subscriber(s): %s.',
|
|
|
|
$this->renderHandleLink($author_phid),
|
|
|
|
count($add),
|
|
|
|
$this->renderHandleList($add));
|
|
|
|
} else {
|
|
|
|
return pht(
|
|
|
|
'%s removed %d subscribers: %s.',
|
|
|
|
$this->renderHandleLink($author_phid),
|
|
|
|
count($rem),
|
|
|
|
$this->renderHandleList($rem));
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return pht(
|
|
|
|
'%s edited this %s.',
|
|
|
|
$this->renderHandleLink($author_phid),
|
|
|
|
$this->getApplicationObjectTypeName());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-12-11 23:00:21 +01:00
|
|
|
public function getTitleForFeed() {
|
|
|
|
$author_phid = $this->getAuthorPHID();
|
|
|
|
$object_phid = $this->getObjectPHID();
|
|
|
|
|
|
|
|
$old = $this->getOldValue();
|
|
|
|
$new = $this->getNewValue();
|
|
|
|
|
|
|
|
switch ($this->getTransactionType()) {
|
|
|
|
case PhabricatorTransactions::TYPE_COMMENT:
|
|
|
|
return pht(
|
|
|
|
'%s added a comment to %s.',
|
|
|
|
$this->renderHandleLink($author_phid),
|
|
|
|
$this->renderHandleLink($object_phid));
|
|
|
|
case PhabricatorTransactions::TYPE_VIEW_POLICY:
|
|
|
|
return pht(
|
|
|
|
'%s changed the visibility for %s.',
|
|
|
|
$this->renderHandleLink($author_phid),
|
|
|
|
$this->renderHandleLink($object_phid));
|
|
|
|
case PhabricatorTransactions::TYPE_EDIT_POLICY:
|
|
|
|
return pht(
|
|
|
|
'%s changed the edit policy for %s.',
|
|
|
|
$this->renderHandleLink($author_phid),
|
|
|
|
$this->renderHandleLink($object_phid));
|
|
|
|
case PhabricatorTransactions::TYPE_SUBSCRIBERS:
|
|
|
|
return pht(
|
|
|
|
'%s updated subscribers of %s.',
|
|
|
|
$this->renderHandleLink($author_phid),
|
|
|
|
$this->renderHandleLink($object_phid));
|
|
|
|
}
|
|
|
|
|
|
|
|
return $this->getTitle();
|
|
|
|
}
|
|
|
|
|
2012-12-11 23:00:07 +01:00
|
|
|
public function getActionStrength() {
|
|
|
|
switch ($this->getTransactionType()) {
|
|
|
|
case PhabricatorTransactions::TYPE_COMMENT:
|
|
|
|
return 0.5;
|
|
|
|
}
|
|
|
|
return 1.0;
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getActionName() {
|
|
|
|
switch ($this->getTransactionType()) {
|
|
|
|
case PhabricatorTransactions::TYPE_COMMENT:
|
|
|
|
return pht('Commented On');
|
|
|
|
case PhabricatorTransactions::TYPE_VIEW_POLICY:
|
|
|
|
case PhabricatorTransactions::TYPE_EDIT_POLICY:
|
|
|
|
return pht('Changed Policy');
|
|
|
|
case PhabricatorTransactions::TYPE_SUBSCRIBERS:
|
|
|
|
return pht('Changed Subscribers');
|
|
|
|
default:
|
|
|
|
return pht('Updated');
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getMailTags() {
|
|
|
|
return array();
|
|
|
|
}
|
|
|
|
|
2012-12-11 22:59:20 +01:00
|
|
|
|
|
|
|
/* -( PhabricatorPolicyInterface Implementation )-------------------------- */
|
|
|
|
|
|
|
|
|
|
|
|
public function getCapabilities() {
|
|
|
|
return array(
|
|
|
|
PhabricatorPolicyCapability::CAN_VIEW,
|
|
|
|
PhabricatorPolicyCapability::CAN_EDIT,
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function getPolicy($capability) {
|
|
|
|
switch ($capability) {
|
|
|
|
case PhabricatorPolicyCapability::CAN_VIEW:
|
|
|
|
return $this->getViewPolicy();
|
|
|
|
case PhabricatorPolicyCapability::CAN_EDIT:
|
|
|
|
return $this->getEditPolicy();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
public function hasAutomaticCapability($capability, PhabricatorUser $viewer) {
|
|
|
|
return ($viewer->getPHID() == $this->getAuthorPHID());
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|