phorge-phorge/resources/sql/patches/032.viewtime.sql

CREATE TABLE {$NAMESPACE}_differential.differential_viewtime (
  viewerPHID varchar(64) not null,
  objectPHID varchar(64) not null,
  viewTime int unsigned not null,
  PRIMARY KEY (viewerPHID, objectPHID)
);
SQL Patch Management: SQL Changes Summary: Splits out the SQL changes. These are most of the changes, but primarily mechanical: - Moved "initialize.sql" to "0000.legacy.sql" and partially reverted to an older version, such that patches 0000 + 000 + 001 + ... + 137 put us in the right state when applied sequentially. - Removed "create database" commands from all SQL. These are handled by separate DB patches now, so we have the data to do operations like "storage databases" (list databases) and "storage destroy" (drop databases). - Removed "phabricator_" namespace from all SQL, and replaced with "{$NAMESPACE}_" token so we can namespace databases. - Shortened some column lengths so patches apply correctly if originally created as InnoDB; also a few similar tweaks elsewhere. Test Plan: See D2323 for discussion and test plan. Reviewers: edward, vrana, btrahan, jungejason Reviewed By: btrahan CC: aran Maniphest Tasks: T140, T345 Differential Revision: https://secure.phabricator.com/D2329 2012-04-30 16:53:53 +02:00			`CREATE TABLE {$NAMESPACE}_differential.differential_viewtime (`
Differential Updates View Summary: This adds a new view to differential called Updates. The high-level goal of Updates is to enabled differential to be effectively used without email notifications. I've tried doing things like automatically deleting differential emails where I'm in the 'to' line since they show up on the main diffential page but then there's always the chance an important diff flies by without me seeing it. Also, sometimes someone comments on a diff post-commit but differential doesn't surface those diffs. I re-created a test db on my devserver using mysqldump to get data on revs > 230000 so I would have some test data. We need to add a simple viewtime table but I didn't want to do that in production. Here's the table: CREATE TABLE differential_viewtime ( viewerPHID varchar(64) not null, objectPHID varchar(64) not null, viewTime int unsigned not null, PRIMARY KEY (viewerPHID, objectPHID) ); Issues: -Once we turn this on, all diffs will be 'unviewed'. What do you think about a 'Clear All' button or something? -Maybe we should add a pager This feature would be insanely useful, let me know what you think. Test Plan: Loaded Updates in my sandbox http://phabricator.dev1577.snc6.facebook.com/differential/filter/updates/ Clicked a diff, then went back, made sure diff disappeared from Updates list Reviewed By: tuomaspelkonen Reviewers: epriestley, jungejason, tuomaspelkonen Commenters: epriestley CC: epriestley, elynde, tuomaspelkonen Differential Revision: 169 2011-04-27 10:27:06 +02:00			`viewerPHID varchar(64) not null,`
			`objectPHID varchar(64) not null,`
			`viewTime int unsigned not null,`
			`PRIMARY KEY (viewerPHID, objectPHID)`
			`);`