revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-01 18:30:59 +01:00
Code Issues Releases Wiki Activity

Fix an issue in Harbormaster when a buildable has no repository

Browse source 
Summary: Not every revision belongs to a repository, so we might end up here with `$repo` still equal to `null`. Don't fatal if we do.

Test Plan: iiam

Reviewers: btrahan, hach-que, zeeg

Reviewed By: hach-que

CC: aran

Maniphest Tasks: T1049

Differential Revision: https://secure.phabricator.com/D7771
This commit is contained in:
epriestley 2013-12-13 18:20:42 -08:00
parent 707b39c5b5
commit 0011068d7a
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/harbormaster/storage/build/HarbormasterBuild.php
View file

@ -183,9 +183,12 @@ final class HarbormasterBuild extends HarbormasterDAO
$repo = $object->getRepository(); $repo = $object->getRepository();
} }
$results['repository.callsign'] = $repo->getCallsign(); if ($repo) {
$results['repository.vcs'] = $repo->getVersionControlSystem(); $results['repository.callsign'] = $repo->getCallsign();
$results['repository.uri'] = $repo->getPublicRemoteURI(); $results['repository.vcs'] = $repo->getVersionControlSystem();
$results['repository.uri'] = $repo->getPublicRemoteURI();
}
$results['step.timestamp'] = time(); $results['step.timestamp'] = time();
$results['build.id'] = $this->getID(); $results['build.id'] = $this->getID();