Search and Replace calls to setShade

Summary: grep for setShade and update to setColor. Add deprecated warning. Test Plan: Diffusion, Workboards, Maniphest, Project tags, tokenizer, uiexamples Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, O14 ATC Monitoring Differential Revision: https://secure.phabricator.com/D17995
2024-12-27 07:50:57 +01:00 · 2017-05-22 18:59:53 +00:00 · 2017-05-22 18:59:53 +00:00 · 00400ae6f9
commit 00400ae6f9
parent 3a0a086a09
17 changed files with 26 additions and 20 deletions
--- a/src/applications/calendar/view/PHUIUserAvailabilityView.php
+++ b/src/applications/calendar/view/PHUIUserAvailabilityView.php
@ -29,7 +29,7 @@ final class PHUIUserAvailabilityView

    $away_tag = id(new PHUITagView())
      ->setType(PHUITagView::TYPE_SHADE)
-      ->setShade($color)
+      ->setColor($color)
      ->setName($name)
      ->setDotColor($color);

--- a/src/applications/conpherence/controller/ConpherenceController.php
+++ b/src/applications/conpherence/controller/ConpherenceController.php
@ -71,7 +71,7 @@ abstract class ConpherenceController extends PhabricatorController {
      if (strlen($data['topic'])) {
        $topic = id(new PHUITagView())
          ->setName($data['topic'])
-          ->setShade(PHUITagView::COLOR_VIOLET)
+          ->setColor(PHUITagView::COLOR_VIOLET)
          ->setType(PHUITagView::TYPE_SHADE)
          ->addClass('conpherence-header-topic');
        $header->addTag($topic);
--- a/src/applications/differential/constants/DifferentialRevisionStatus.php
+++ b/src/applications/differential/constants/DifferentialRevisionStatus.php
@ -65,7 +65,7 @@ final class DifferentialRevisionStatus extends Phobject {
    $tag = id(new PHUITagView())
      ->setName($status_name)
      ->setIcon(self::getRevisionStatusIcon($status))
-      ->setShade(self::getRevisionStatusColor($status))
+      ->setColor(self::getRevisionStatusColor($status))
      ->setType(PHUITagView::TYPE_SHADE);

    return $tag;
--- a/src/applications/files/controller/PhabricatorFileInfoController.php
+++ b/src/applications/files/controller/PhabricatorFileInfoController.php
@ -44,7 +44,7 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
    if ($ttl !== null) {
      $ttl_tag = id(new PHUITagView())
        ->setType(PHUITagView::TYPE_SHADE)
-        ->setShade(PHUITagView::COLOR_YELLOW)
+        ->setColor(PHUITagView::COLOR_YELLOW)
        ->setName(pht('Temporary'));
      $header->addTag($ttl_tag);
    }
@ -53,7 +53,7 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
    if ($partial) {
      $partial_tag = id(new PHUITagView())
        ->setType(PHUITagView::TYPE_SHADE)
-        ->setShade(PHUITagView::COLOR_ORANGE)
+        ->setColor(PHUITagView::COLOR_ORANGE)
        ->setName(pht('Partial Upload'));
      $header->addTag($partial_tag);
    }
--- a/src/applications/harbormaster/view/HarbormasterUnitSummaryView.php
+++ b/src/applications/harbormaster/view/HarbormasterUnitSummaryView.php
@ -56,7 +56,7 @@ final class HarbormasterUnitSummaryView extends AphrontView {

    $tag = id(new PHUITagView())
      ->setType(PHUITagView::TYPE_SHADE)
-      ->setShade($tag_color)
+      ->setColor($tag_color)
      ->setIcon($tag_icon)
      ->setName($tag_text);

--- a/src/applications/maniphest/constants/ManiphestTaskStatus.php
+++ b/src/applications/maniphest/constants/ManiphestTaskStatus.php
@ -97,7 +97,7 @@ final class ManiphestTaskStatus extends ManiphestConstants {
      ->setName($name)
      ->setIcon($icon)
      ->setType(PHUITagView::TYPE_SHADE)
-      ->setShade($color);
+      ->setColor($color);

    return $tag;
  }
--- a/src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php
+++ b/src/applications/owners/engineextension/PhabricatorOwnersHovercardEngineExtension.php
@ -64,7 +64,7 @@ final class PhabricatorOwnersHovercardEngineExtension
    if ($package->isArchived()) {
      $tag = id(new PHUITagView())
        ->setName(pht('Archived'))
-        ->setShade(PHUITagView::COLOR_INDIGO)
+        ->setColor(PHUITagView::COLOR_INDIGO)
        ->setType(PHUITagView::TYPE_OBJECT);
      $hovercard->addTag($tag);
    }
--- a/src/applications/people/view/PhabricatorUserCardView.php
+++ b/src/applications/people/view/PhabricatorUserCardView.php
@ -85,7 +85,7 @@ final class PhabricatorUserCardView extends AphrontTagView {
      ->setType(PHUITagView::TYPE_SHADE);

    if ($tag_shade !== null) {
-      $tag->setShade($tag_shade);
+      $tag->setColor($tag_shade);
    }

    $body = array();
--- a/src/applications/project/controller/PhabricatorProjectBoardViewController.php
+++ b/src/applications/project/controller/PhabricatorProjectBoardViewController.php
@ -331,7 +331,7 @@ final class PhabricatorProjectBoardViewController

      $count_tag = id(new PHUITagView())
        ->setType(PHUITagView::TYPE_SHADE)
-        ->setShade(PHUITagView::COLOR_BLUE)
+        ->setColor(PHUITagView::COLOR_BLUE)
        ->addSigil('column-points')
        ->setName(
          javelin_tag(
--- a/src/applications/project/query/PhabricatorProjectSearchEngine.php
+++ b/src/applications/project/query/PhabricatorProjectSearchEngine.php
@ -211,7 +211,7 @@ final class PhabricatorProjectSearchEngine
      $options[$color] = array(
        id(new PHUITagView())
          ->setType(PHUITagView::TYPE_SHADE)
-          ->setShade($color)
+          ->setColor($color)
          ->setName($name),
      );
    }
--- a/src/applications/project/view/ProjectBoardTaskCard.php
+++ b/src/applications/project/view/ProjectBoardTaskCard.php
@ -100,7 +100,7 @@ final class ProjectBoardTaskCard extends Phobject {
      if ($points !== null) {
        $points_tag = id(new PHUITagView())
          ->setType(PHUITagView::TYPE_SHADE)
-          ->setShade(PHUITagView::COLOR_GREY)
+          ->setColor(PHUITagView::COLOR_GREY)
          ->setSlimShady(true)
          ->setName($points)
          ->addClass('phui-workcard-points');
--- a/src/applications/search/query/PhabricatorFulltextToken.php
+++ b/src/applications/search/query/PhabricatorFulltextToken.php
@ -64,7 +64,7 @@ final class PhabricatorFulltextToken extends Phobject {

    $tag = id(new PHUITagView())
      ->setType(PHUITagView::TYPE_SHADE)
-      ->setShade($shade)
+      ->setColor($shade)
      ->setName($token->getValue());

    if ($tip !== null) {
--- a/src/applications/uiexample/examples/PHUITagExample.php
+++ b/src/applications/uiexample/examples/PHUITagExample.php
@ -187,12 +187,12 @@ final class PHUITagExample extends PhabricatorUIExample {
    foreach ($outlines as $outline) {
      $tags[] = id(new PHUITagView())
        ->setType(PHUITagView::TYPE_OUTLINE)
-        ->setShade($outline)
+        ->setColor($outline)
        ->setName($outline);
      $tags[] = hsprintf('&nbsp;');
      $tags[] = id(new PHUITagView())
        ->setType(PHUITagView::TYPE_OUTLINE)
-        ->setShade($outline)
+        ->setColor($outline)
        ->setSlimShady(true)
        ->setName($outline);
      $tags[] = hsprintf('<br /><br />');
--- a/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
+++ b/src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
@ -148,7 +148,7 @@ final class PHUIDiffInlineCommentDetailView
        ->setType(PHUITagView::TYPE_SHADE)
        ->setName(pht('Unsubmitted'))
        ->setSlimShady(true)
-        ->setShade(PHUITagView::COLOR_RED)
+        ->setColor(PHUITagView::COLOR_RED)
        ->addClass('mml inline-draft-text');
    }

@ -383,7 +383,7 @@ final class PHUIDiffInlineCommentDetailView
          ->setType(PHUITagView::TYPE_SHADE)
          ->setName(pht('Author'))
          ->setSlimShady(true)
-          ->setShade(PHUITagView::COLOR_YELLOW)
+          ->setColor(PHUITagView::COLOR_YELLOW)
          ->addClass('mml');
      }
    }
--- a/src/infrastructure/markup/rule/PhabricatorNavigationRemarkupRule.php
+++ b/src/infrastructure/markup/rule/PhabricatorNavigationRemarkupRule.php
@ -60,7 +60,7 @@ final class PhabricatorNavigationRemarkupRule extends PhutilRemarkupRule {

      $tag = id(new PHUITagView())
        ->setType(PHUITagView::TYPE_SHADE)
-        ->setShade($item_color)
+        ->setColor($item_color)
        ->setName($item_name);

      if ($item['icon']) {
--- a/src/view/phui/PHUIHeaderView.php
+++ b/src/view/phui/PHUIHeaderView.php
@ -131,7 +131,7 @@ final class PHUIHeaderView extends AphrontTagView {
    $tag = id(new PHUITagView())
      ->setName($name)
      ->setIcon($icon)
-      ->setShade($color)
+      ->setColor($color)
      ->setType(PHUITagView::TYPE_SHADE);

    return $this->addProperty(self::PROPERTY_STATUS, $tag);
--- a/src/view/phui/PHUITagView.php
+++ b/src/view/phui/PHUITagView.php
@ -57,8 +57,14 @@ final class PHUITagView extends AphrontTagView {
    return $this;
  }

-  /* Deprecated, use setColor */
+  /**
+   * This method has been deprecated, use @{method:setColor} instead.
+   *
+   * @deprecated
+   */
  public function setShade($shade) {
+    phlog(
+      pht('Deprecated call to setShade(), use setColor() instead.'));
    $this->color = $shade;
    return $this;
  }