remove unused FeedStory object in getTitleForFeed functions

Summary:
Removes an unused PhabricatorFeedStory Parameter from all getTitleForFeed() and getApplicationTransactionTitleForFeed() functions.
Ref D11088 Ref T6545

Test Plan: ran all unit tests and viewed some dashboard feeds

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6545

Differential Revision: https://secure.phabricator.com/D11146

src/applications/audit/storage/PhabricatorAuditTransaction.php

@@ -258,7 +258,7 @@ final class PhabricatorAuditTransaction
     return parent::getTitle();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $old = $this->getOldValue();
     $new = $this->getNewValue();
 
@@ -375,7 +375,7 @@ final class PhabricatorAuditTransaction
 
     }
 
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function getBodyForFeed(PhabricatorFeedStory $story) {

src/applications/config/storage/PhabricatorConfigTransaction.php

@@ -55,7 +55,7 @@ final class PhabricatorConfigTransaction
     return parent::getTitle();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story = null) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
 
     $old = $this->getOldValue();

src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php

@@ -52,7 +52,7 @@ final class PhabricatorDashboardPanelTransaction
     return parent::getTitle();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -92,7 +92,7 @@ final class PhabricatorDashboardPanelTransaction
         }
     }
 
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function getColor() {

src/applications/dashboard/storage/PhabricatorDashboardTransaction.php

@@ -42,7 +42,7 @@ final class PhabricatorDashboardTransaction
     return parent::getTitle();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -70,7 +70,7 @@ final class PhabricatorDashboardTransaction
         }
     }
 
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function getColor() {

src/applications/differential/customfield/DifferentialBlameRevisionField.php

@@ -74,8 +74,7 @@ final class DifferentialBlameRevisionField
   }
 
   public function getApplicationTransactionTitleForFeed(
-    PhabricatorApplicationTransaction $xaction,
+    PhabricatorApplicationTransaction $xaction) {
-    PhabricatorFeedStory $story) {
 
     $object_phid = $xaction->getObjectPHID();
     $author_phid = $xaction->getAuthorPHID();

src/applications/differential/customfield/DifferentialRepositoryField.php

@@ -99,8 +99,7 @@ final class DifferentialRepositoryField
   }
 
   public function getApplicationTransactionTitleForFeed(
-    PhabricatorApplicationTransaction $xaction,
+    PhabricatorApplicationTransaction $xaction) {
-    PhabricatorFeedStory $story) {
 
     $object_phid = $xaction->getObjectPHID();
     $author_phid = $xaction->getAuthorPHID();

src/applications/differential/customfield/DifferentialRevertPlanField.php

@@ -103,8 +103,7 @@ final class DifferentialRevertPlanField
   }
 
   public function getApplicationTransactionTitleForFeed(
-    PhabricatorApplicationTransaction $xaction,
+    PhabricatorApplicationTransaction $xaction) {
-    PhabricatorFeedStory $story) {
 
     $object_phid = $xaction->getObjectPHID();
     $author_phid = $xaction->getAuthorPHID();

src/applications/differential/customfield/DifferentialSummaryField.php

@@ -58,8 +58,7 @@ final class DifferentialSummaryField
   }
 
   public function getApplicationTransactionTitleForFeed(
-    PhabricatorApplicationTransaction $xaction,
+    PhabricatorApplicationTransaction $xaction) {
-    PhabricatorFeedStory $story) {
 
     $object_phid = $xaction->getObjectPHID();
     $author_phid = $xaction->getAuthorPHID();

src/applications/differential/customfield/DifferentialTestPlanField.php

@@ -72,8 +72,7 @@ final class DifferentialTestPlanField
   }
 
   public function getApplicationTransactionTitleForFeed(
-    PhabricatorApplicationTransaction $xaction,
+    PhabricatorApplicationTransaction $xaction) {
-    PhabricatorFeedStory $story) {
 
     $object_phid = $xaction->getObjectPHID();
     $author_phid = $xaction->getAuthorPHID();

src/applications/differential/customfield/DifferentialTitleField.php

@@ -75,8 +75,7 @@ final class DifferentialTitleField
   }
 
   public function getApplicationTransactionTitleForFeed(
-    PhabricatorApplicationTransaction $xaction,
+    PhabricatorApplicationTransaction $xaction) {
-    PhabricatorFeedStory $story) {
 
     $object_phid = $xaction->getObjectPHID();
     $author_phid = $xaction->getAuthorPHID();

src/applications/differential/storage/DifferentialTransaction.php

@@ -326,7 +326,7 @@ final class DifferentialTransaction extends PhabricatorApplicationTransaction {
     return parent::renderExtraInformationLink();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -452,7 +452,7 @@ final class DifferentialTransaction extends PhabricatorApplicationTransaction {
         }
     }
 
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function getIcon() {

src/applications/fund/storage/FundInitiativeTransaction.php

@@ -133,7 +133,7 @@ final class FundInitiativeTransaction
     return parent::getTitle();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -197,7 +197,7 @@ final class FundInitiativeTransaction
           $this->renderHandleLink($object_phid));
     }
 
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function getMailTags() {

src/applications/macro/storage/PhabricatorMacroTransaction.php

@@ -124,7 +124,7 @@ final class PhabricatorMacroTransaction
     return parent::getTitle();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -201,7 +201,7 @@ final class PhabricatorMacroTransaction
 
     }
 
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function getActionName() {

src/applications/maniphest/storage/ManiphestTransaction.php

@@ -554,7 +554,7 @@ final class ManiphestTransaction
     return parent::getTitle();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -711,7 +711,7 @@ final class ManiphestTransaction
         // code in the parent;
         $clone = clone $this;
         $clone->setTransactionType(PhabricatorTransactions::TYPE_EDGE);
-        return $clone->getTitleForFeed($story);
+        return $clone->getTitleForFeed();
 
       case self::TYPE_ATTACH:
         $old = nonempty($old, array());
@@ -773,7 +773,7 @@ final class ManiphestTransaction
 
     }
 
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function hasChangeDetails() {

src/applications/paste/storage/PhabricatorPasteTransaction.php

@@ -90,7 +90,7 @@ final class PhabricatorPasteTransaction
     return parent::getTitle();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -126,7 +126,7 @@ final class PhabricatorPasteTransaction
         break;
     }
 
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function getColor() {

src/applications/pholio/storage/PholioTransaction.php

@@ -209,7 +209,7 @@ final class PholioTransaction extends PhabricatorApplicationTransaction {
     return parent::getTitle();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -278,7 +278,7 @@ final class PholioTransaction extends PhabricatorApplicationTransaction {
         break;
     }
 
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function getBodyForFeed(PhabricatorFeedStory $story) {

src/applications/phriction/storage/PhrictionTransaction.php

@@ -214,7 +214,7 @@ final class PhrictionTransaction
     return parent::getTitle();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -250,7 +250,7 @@ final class PhrictionTransaction
           $this->renderHandleLink($object_phid));
 
     }
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function hasChangeDetails() {

src/applications/ponder/storage/PonderAnswerTransaction.php

@@ -60,7 +60,7 @@ final class PonderAnswerTransaction
     return parent::getTitle();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -72,7 +72,7 @@ final class PonderAnswerTransaction
           $this->renderHandleLink($object_phid));
     }
 
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function getBodyForFeed(PhabricatorFeedStory $story) {

src/applications/ponder/storage/PonderQuestionTransaction.php

@@ -202,7 +202,7 @@ final class PonderQuestionTransaction
     return parent::shouldHide();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -250,7 +250,7 @@ final class PonderQuestionTransaction
         }
     }
 
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function getBodyForFeed(PhabricatorFeedStory $story) {

src/applications/releeph/storage/ReleephProductTransaction.php

@@ -70,7 +70,7 @@ final class ReleephProductTransaction
     return parent::getTitle();
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -93,7 +93,7 @@ final class ReleephProductTransaction
         break;
     }
 
-    return parent::getTitleForFeed($story);
+    return parent::getTitleForFeed();
   }
 
   public function getNoEffectDescription() {

src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php

@@ -75,7 +75,7 @@ class PhabricatorApplicationTransactionFeedStory
     $xaction = $this->getPrimaryTransaction();
 
     $xaction->setHandles($this->getHandles());
-    $view->setTitle($xaction->getTitleForFeed($this));
+    $view->setTitle($xaction->getTitleForFeed());
 
     foreach ($xaction_phids as $xaction_phid) {
       $secondary_xaction = $this->getObject($xaction_phid);
@@ -99,7 +99,7 @@ class PhabricatorApplicationTransactionFeedStory
     $new_target = PhabricatorApplicationTransaction::TARGET_TEXT;
     $xaction->setRenderingTarget($new_target);
     $xaction->setHandles($this->getHandles());
-    $text = $xaction->getTitleForFeed($this);
+    $text = $xaction->getTitleForFeed();
     $xaction->setRenderingTarget($old_target);
     return $text;
   }

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

@@ -728,7 +728,7 @@ abstract class PhabricatorApplicationTransaction
     }
   }
 
-  public function getTitleForFeed(PhabricatorFeedStory $story) {
+  public function getTitleForFeed() {
     $author_phid = $this->getAuthorPHID();
     $object_phid = $this->getObjectPHID();
 
@@ -802,7 +802,7 @@ abstract class PhabricatorApplicationTransaction
       case PhabricatorTransactions::TYPE_CUSTOMFIELD:
         $field = $this->getTransactionCustomField();
         if ($field) {
-          return $field->getApplicationTransactionTitleForFeed($this, $story);
+          return $field->getApplicationTransactionTitleForFeed($this);
         } else {
           return pht(
             '%s edited a custom field on %s.',
@@ -1102,7 +1102,7 @@ abstract class PhabricatorApplicationTransaction
       if ($publisher->getRenderWithImpliedContext()) {
         $text[] = $xaction->getTitle();
       } else {
-        $text[] = $xaction->getTitleForFeed($story);
+        $text[] = $xaction->getTitleForFeed();
       }
 
       $xaction->setRenderingTarget($old_target);

src/infrastructure/customfield/field/PhabricatorCustomField.php

@@ -1003,12 +1003,10 @@ abstract class PhabricatorCustomField {
   }
 
   public function getApplicationTransactionTitleForFeed(
-    PhabricatorApplicationTransaction $xaction,
+    PhabricatorApplicationTransaction $xaction) {
-    PhabricatorFeedStory $story) {
     if ($this->proxy) {
       return $this->proxy->getApplicationTransactionTitleForFeed(
-        $xaction,
+        $xaction);
-        $story);
     }
 
     $author_phid = $xaction->getAuthorPHID();

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

@@ -360,8 +360,7 @@ abstract class PhabricatorStandardCustomField
   }
 
   public function getApplicationTransactionTitleForFeed(
-    PhabricatorApplicationTransaction $xaction,
+    PhabricatorApplicationTransaction $xaction) {
-    PhabricatorFeedStory $story) {
 
     $author_phid = $xaction->getAuthorPHID();
     $object_phid = $xaction->getObjectPHID();