From 006d74fde20c14c4c676f8b20e842f249edbf056 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Mon, 13 Feb 2017 11:10:27 -0800
Subject: [PATCH] Clean up some search result alignment CSS

Summary: Aligns the search result list to the right of the input box, adds a little space, removes a double border.

Test Plan: Search on desktop, mobile, tablet breakpoints. Double check normal typeahead results.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D17345
---
 resources/celerity/map.php                       | 16 ++++++++--------
 webroot/rsrc/css/aphront/typeahead.css           |  5 ++++-
 .../rsrc/css/application/base/main-menu-view.css |  7 +++----
 3 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index fd063fd5cb..245e810cd8 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -9,7 +9,7 @@ return array(
   'names' => array(
     'conpherence.pkg.css' => 'a520d619',
     'conpherence.pkg.js' => '6249a1cf',
-    'core.pkg.css' => '76a0e8c9',
+    'core.pkg.css' => '1179d101',
     'core.pkg.js' => '1fa7c0c5',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => '4815647b',
@@ -31,10 +31,10 @@ return array(
     'rsrc/css/aphront/tokenizer.css' => '9a8cb501',
     'rsrc/css/aphront/tooltip.css' => '173b9431',
     'rsrc/css/aphront/typeahead-browse.css' => '8904346a',
-    'rsrc/css/aphront/typeahead.css' => 'd4f16145',
+    'rsrc/css/aphront/typeahead.css' => '8a84cc7d',
     'rsrc/css/application/almanac/almanac.css' => 'dbb9b3af',
     'rsrc/css/application/auth/auth.css' => '0877ed6e',
-    'rsrc/css/application/base/main-menu-view.css' => '43d59288',
+    'rsrc/css/application/base/main-menu-view.css' => '5294060f',
     'rsrc/css/application/base/notification-menu.css' => '6a697e43',
     'rsrc/css/application/base/phui-theme.css' => '9f261c6b',
     'rsrc/css/application/base/standard-page-view.css' => '894d8a25',
@@ -555,7 +555,7 @@ return array(
     'aphront-table-view-css' => '6ca8e057',
     'aphront-tokenizer-control-css' => '9a8cb501',
     'aphront-tooltip-css' => '173b9431',
-    'aphront-typeahead-control-css' => 'd4f16145',
+    'aphront-typeahead-control-css' => '8a84cc7d',
     'application-search-view-css' => '66ee5d46',
     'auth-css' => '0877ed6e',
     'bulk-job-css' => 'df9c1d4a',
@@ -797,7 +797,7 @@ return array(
     'phabricator-flag-css' => 'bba8f811',
     'phabricator-keyboard-shortcut' => '1ae869f2',
     'phabricator-keyboard-shortcut-manager' => '4a021c10',
-    'phabricator-main-menu-view' => '43d59288',
+    'phabricator-main-menu-view' => '5294060f',
     'phabricator-nav-view-css' => 'e58a4a30',
     'phabricator-notification' => 'ccf1cbf8',
     'phabricator-notification-css' => '3f6c89c9',
@@ -1171,9 +1171,6 @@ return array(
       'javelin-dom',
       'javelin-request',
     ),
-    '43d59288' => array(
-      'phui-theme-css',
-    ),
     '44959b73' => array(
       'javelin-util',
       'javelin-uri',
@@ -1280,6 +1277,9 @@ return array(
       'javelin-vector',
       'javelin-typeahead-static-source',
     ),
+    '5294060f' => array(
+      'phui-theme-css',
+    ),
     '5359e785' => array(
       'javelin-install',
       'javelin-util',
diff --git a/webroot/rsrc/css/aphront/typeahead.css b/webroot/rsrc/css/aphront/typeahead.css
index 0f63918e40..bdda2703e0 100644
--- a/webroot/rsrc/css/aphront/typeahead.css
+++ b/webroot/rsrc/css/aphront/typeahead.css
@@ -4,7 +4,7 @@
 
 div.jx-typeahead-hardpoint {
   position: relative;
-  _zoom: 1; /* Some kind of IE6 fix? */ /* yes */ /* why? */
+  _zoom: 1; /* Some kind of IE6 fix? */ /* yes */ /* why? */ /* still need? */
 }
 
 div.jx-typeahead-results {
@@ -28,6 +28,9 @@ div.jx-typeahead-results a.jx-result {
   color: {$darkgreytext};
   display: block;
   font-size: {$normalfontsize};
+}
+
+div.jx-typeahead-results a.jx-result + a.jx-result {
   border-top: 1px solid {$hoverborder};
 }
 
diff --git a/webroot/rsrc/css/application/base/main-menu-view.css b/webroot/rsrc/css/application/base/main-menu-view.css
index 0860909382..28148ae71a 100644
--- a/webroot/rsrc/css/application/base/main-menu-view.css
+++ b/webroot/rsrc/css/application/base/main-menu-view.css
@@ -139,8 +139,7 @@
 }
 
 .device-desktop .phabricator-main-menu-search-target {
-  width: 320px;
-  margin-left: -150px;
+  width: 360px;
 }
 
 .device .phabricator-main-menu-search-target {
@@ -276,11 +275,11 @@ a.phabricator-core-user-menu .caret:before {
   box-shadow: {$dropshadow};
   border: 1px solid {$lightgreyborder};
   border-radius: 3px;
-  margin-left: 40px;
+  margin-left: -64px;
 }
 
 .device .phabricator-main-menu-search-target div.jx-typeahead-results {
-  margin-left: 30px;
+  margin-left: 28px;
 }
 
 .phabricator-main-search-typeahead-result .phabricator-search-icon {