From 008461a395a0d79ca5a5ae6e4b6580187e11167c Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 19 Jan 2012 17:07:25 -0800 Subject: [PATCH] Use getBestURI() to set file handle URIs Summary: getBestURI() = best URI Test Plan: It says "best" in the name so it must be the best! Also in Maniphest emails we'll link you to /view/ even for binaries and other non-viewable content. Reviewers: btrahan, jungejason Reviewed By: btrahan CC: anjali, aran Differential Revision: https://secure.phabricator.com/D1461 --- .../phid/handle/data/PhabricatorObjectHandleData.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/phid/handle/data/PhabricatorObjectHandleData.php b/src/applications/phid/handle/data/PhabricatorObjectHandleData.php index 031531fec9..a807ffa24f 100644 --- a/src/applications/phid/handle/data/PhabricatorObjectHandleData.php +++ b/src/applications/phid/handle/data/PhabricatorObjectHandleData.php @@ -326,7 +326,7 @@ class PhabricatorObjectHandleData { } else { $file = $files[$phid]; $handle->setName($file->getName()); - $handle->setURI($file->getViewURI()); + $handle->setURI($file->getBestURI()); $handle->setComplete(true); } $handles[$phid] = $handle;