mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 22:10:55 +01:00
Fix handling of Phriction conduit edits
Summary: See https://discourse.phabricator-community.org/t/conduit-method-phriction-edit-requires-title-while-the-docs-say-its-optional/2176. Make code consistent with documentation by not requiring either `content` or `title`. Test Plan: Hit the method via the UI and no longer got an error on missing `content` or `title` fields. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D19862
This commit is contained in:
parent
bf6c534b56
commit
00a7071e2d
1 changed files with 13 additions and 6 deletions
|
@ -41,12 +41,19 @@ final class PhrictionEditConduitAPIMethod extends PhrictionConduitAPIMethod {
|
|||
}
|
||||
|
||||
$xactions = array();
|
||||
$xactions[] = id(new PhrictionTransaction())
|
||||
->setTransactionType(PhrictionDocumentTitleTransaction::TRANSACTIONTYPE)
|
||||
->setNewValue($request->getValue('title'));
|
||||
$xactions[] = id(new PhrictionTransaction())
|
||||
->setTransactionType(PhrictionDocumentContentTransaction::TRANSACTIONTYPE)
|
||||
->setNewValue($request->getValue('content'));
|
||||
if ($request->getValue('title')) {
|
||||
$xactions[] = id(new PhrictionTransaction())
|
||||
->setTransactionType(
|
||||
PhrictionDocumentTitleTransaction::TRANSACTIONTYPE)
|
||||
->setNewValue($request->getValue('title'));
|
||||
}
|
||||
|
||||
if ($request->getValue('content')) {
|
||||
$xactions[] = id(new PhrictionTransaction())
|
||||
->setTransactionType(
|
||||
PhrictionDocumentContentTransaction::TRANSACTIONTYPE)
|
||||
->setNewValue($request->getValue('content'));
|
||||
}
|
||||
|
||||
$editor = id(new PhrictionTransactionEditor())
|
||||
->setActor($request->getUser())
|
||||
|
|
Loading…
Reference in a new issue