revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 17:22:42 +01:00
Code Issues Releases Wiki Activity

Set up colspec for differential 1up

Browse source 
Summary: This upgrades 1up view from "does not work" back to "barely works".

Test Plan: view diff, 1up and 2up.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D10854
This commit is contained in:
Aviv Eyal 2014-11-14 16:58:24 -08:00 committed by epriestley
parent c9c4dc1d9b
commit 00b245a566
3 changed files with 21 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
View file

@ -409,16 +409,8 @@ abstract class DifferentialChangesetHTMLRenderer
$content)));
}
private function renderColgroup() {
return phutil_tag('colgroup', array(), array(
phutil_tag('col', array('class' => 'num')),
phutil_tag('col', array('class' => 'left')),
phutil_tag('col', array('class' => 'num')),
phutil_tag('col', array('class' => 'copy')),
phutil_tag('col', array('class' => 'right')),
phutil_tag('col', array('class' => 'cov')),
));
}
abstract protected function renderColgroup();
protected function wrapChangeInTable($content) {
if (!$content) {

8
src/applications/differential/render/DifferentialChangesetOneUpRenderer.php
View file

@ -7,6 +7,14 @@ final class DifferentialChangesetOneUpRenderer
return true;
}
protected function renderColgroup() {
return phutil_tag('colgroup', array(), array(
phutil_tag('col', array('class' => 'num')),
phutil_tag('col', array('class' => 'num')),
phutil_tag('col', array('class' => 'unified')),
));
}
public function renderTextChange(
$range_start,
$range_len,

11
src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
View file

@ -7,6 +7,17 @@ final class DifferentialChangesetTwoUpRenderer
return false;
}
protected function renderColgroup() {
return phutil_tag('colgroup', array(), array(
phutil_tag('col', array('class' => 'num')),
phutil_tag('col', array('class' => 'left')),
phutil_tag('col', array('class' => 'num')),
phutil_tag('col', array('class' => 'copy')),
phutil_tag('col', array('class' => 'right')),
phutil_tag('col', array('class' => 'cov')),
));
}
public function renderTextChange(
$range_start,
$range_len,