1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00

Fix mobile action menus in Phriction

Summary: Fixes T6963. Long term will likely make this more like other document views, but not worth the time right now since this is only location.

Test Plan: Review Phriction document at desktop and mobile breakpoints. Click menu and see menu.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6963

Differential Revision: https://secure.phabricator.com/D11420
This commit is contained in:
Chad Little 2015-01-19 12:42:05 -08:00
parent 4636833f3d
commit 00faa2b2f7
2 changed files with 30 additions and 0 deletions

View file

@ -200,11 +200,14 @@ final class PhrictionDocumentController
$prop_list = new PHUIPropertyGroupView();
$prop_list->addPropertyList($properties);
}
$action_id = celerity_generate_unique_node_id();
$actions->setID($action_id);
$page_content = id(new PHUIDocumentView())
->setOffset(true)
->setFontKit(PHUIDocumentView::FONT_SOURCE_SANS)
->setHeader($header)
->setActionListID($action_id)
->appendChild(
array(
$actions,

View file

@ -16,6 +16,7 @@ final class PHUIDocumentView extends AphrontTagView {
private $bookdescription;
private $mobileview;
private $fontKit;
private $actionListID;
public function setOffset($offset) {
$this->offset = $offset;
@ -57,6 +58,11 @@ final class PHUIDocumentView extends AphrontTagView {
return $this;
}
public function setActionListID($id) {
$this->actionListID = $id;
return $this;
}
protected function getTagAttributes() {
$classes = array();
@ -150,6 +156,27 @@ final class PHUIDocumentView extends AphrontTagView {
$main_content = $this->renderChildren();
}
if ($this->actionListID) {
$icon_id = celerity_generate_unique_node_id();
$icon = id(new PHUIIconView())
->setIconFont('fa-bars');
$meta = array(
'map' => array(
$this->actionListID => 'phabricator-action-list-toggle',
$icon_id => 'phuix-dropdown-open',
),);
$mobile_menu = id(new PHUIButtonView())
->setTag('a')
->setText(pht('Actions'))
->setHref('#')
->setIcon($icon)
->addClass('phui-mobile-menu')
->setID($icon_id)
->addSigil('jx-toggle-class')
->setMetadata($meta);
$this->header->addActionLink($mobile_menu);
}
$content_inner = phutil_tag(
'div',
array(