From 00ffb190cc71b173b99ae4ab155b44a0ea9dc95d Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 12 Feb 2019 05:49:59 -0800 Subject: [PATCH] In Webhooks, label HTTP response codes as "HTTP Status Code", not "HTTP Error" Summary: See PHI1068. We currently show "HTTP Error - 200", which is misleading. Instead, label these results as "HTTP Status Code". Test Plan: {F6206016} Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D20148 --- src/applications/herald/storage/HeraldWebhookRequest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/herald/storage/HeraldWebhookRequest.php b/src/applications/herald/storage/HeraldWebhookRequest.php index 3381f6a99c..bc916fd60b 100644 --- a/src/applications/herald/storage/HeraldWebhookRequest.php +++ b/src/applications/herald/storage/HeraldWebhookRequest.php @@ -120,7 +120,7 @@ final class HeraldWebhookRequest public function getErrorTypeForDisplay() { $map = array( self::ERRORTYPE_HOOK => pht('Hook Error'), - self::ERRORTYPE_HTTP => pht('HTTP Error'), + self::ERRORTYPE_HTTP => pht('HTTP Status Code'), self::ERRORTYPE_TIMEOUT => pht('Request Timeout'), );