Found some missing icons

Summary: Did a more exhaustive grep on setIcon and found 99.9% of the icons.

Test Plan: I verified icon names on UIExamples, but unable to test some of the more complex flows visually. Mostly a read and replace.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D9088

src/applications/auth/controller/config/PhabricatorAuthListController.php

@@ -53,15 +53,15 @@ final class PhabricatorAuthListController
         $item->setBarColor('green');
         $item->addAction(
           id(new PHUIListItemView())
-            ->setIcon('delete')
+            ->setIcon('fa-times')
             ->setHref($disable_uri)
             ->addSigil('workflow'));
       } else {
         $item->setBarColor('grey');
-        $item->addIcon('delete-grey', pht('Disabled'));
+        $item->addIcon('fa-times grey', pht('Disabled'));
         $item->addAction(
           id(new PHUIListItemView())
-            ->setIcon('new')
+            ->setIcon('fa-plus')
             ->setHref($enable_uri)
             ->addSigil('workflow'));
       }

src/applications/config/controller/PhabricatorConfigIssueListController.php

@@ -58,7 +58,7 @@ final class PhabricatorConfigIssueListController
         $item->setBarColor('yellow');
         $item->addAction(
           id(new PHUIListItemView())
-            ->setIcon('unpublish')
+            ->setIcon('fa-eye-slash')
             ->setWorkflow(true)
             ->setName(pht('Ignore'))
             ->setHref('/config/ignore/'.$issue->getIssueKey().'/'));
@@ -68,7 +68,7 @@ final class PhabricatorConfigIssueListController
         $item->setDisabled(true);
         $item->addAction(
           id(new PHUIListItemView())
-            ->setIcon('preview')
+            ->setIcon('fa-eye')
             ->setWorkflow(true)
             ->setName(pht('Unignore'))
             ->setHref('/config/unignore/'.$issue->getIssueKey().'/'));

src/applications/daemon/controller/PhabricatorWorkerTaskDetailController.php

@@ -92,7 +92,7 @@ final class PhabricatorWorkerTaskDetailController
         id(new PhabricatorActionView())
           ->setName(pht('Retry Task'))
           ->setHref($this->getApplicationURI('/task/'.$id.'/retry/'))
-          ->setIcon('undo')
+          ->setIcon('fa-refresh')
           ->setWorkflow(true)
           ->setDisabled(!$can_retry));
     } else {
@@ -100,7 +100,7 @@ final class PhabricatorWorkerTaskDetailController
         id(new PhabricatorActionView())
           ->setName(pht('Cancel Task'))
           ->setHref($this->getApplicationURI('/task/'.$id.'/cancel/'))
-          ->setIcon('delete')
+          ->setIcon('fa-times')
           ->setWorkflow(true));
     }
 
@@ -111,7 +111,7 @@ final class PhabricatorWorkerTaskDetailController
       id(new PhabricatorActionView())
         ->setName(pht('Free Lease'))
         ->setHref($this->getApplicationURI('/task/'.$id.'/release/'))
-        ->setIcon('unlock')
+        ->setIcon('fa-unlock')
         ->setWorkflow(true)
         ->setDisabled(!$can_release));
 

src/applications/differential/landing/DifferentialLandingToGitHub.php

@@ -70,7 +70,7 @@ final class DifferentialLandingToGitHub
     }
 
     return $this->createActionView($revision, pht('Land to GitHub'))
-      ->setIcon('octocat');
+      ->setIcon('fa-cloud-upload');
   }
 
   public function pushWorkspaceRepository(

src/applications/diffusion/controller/DiffusionChangeController.php

@@ -113,7 +113,7 @@ final class DiffusionChangeController extends DiffusionController {
       id(new PhabricatorActionView())
         ->setName(pht('View History'))
         ->setHref($history_uri)
-        ->setIcon('history'));
+        ->setIcon('fa-clock-o'));
 
     $browse_uri = $drequest->generateURI(
       array(
@@ -124,7 +124,7 @@ final class DiffusionChangeController extends DiffusionController {
       id(new PhabricatorActionView())
         ->setName(pht('Browse Content'))
         ->setHref($browse_uri)
-        ->setIcon('file'));
+        ->setIcon('fa-files-o'));
 
     return $view;
   }

src/applications/diffusion/controller/DiffusionHistoryController.php

@@ -113,7 +113,7 @@ final class DiffusionHistoryController extends DiffusionController {
       id(new PhabricatorActionView())
         ->setName(pht('Browse Content'))
         ->setHref($browse_uri)
-        ->setIcon('file'));
+        ->setIcon('fa-files-o'));
 
     // TODO: Sometimes we do have a change view, we need to look at the most
     // recent history entry to figure it out.

src/applications/diffusion/controller/DiffusionLintController.php

@@ -279,7 +279,7 @@ final class DiffusionLintController extends DiffusionController {
       id(new PhabricatorActionView())
         ->setName(pht('View As List'))
         ->setHref($list_uri)
-        ->setIcon('transcript'));
+        ->setIcon('fa-list'));
 
     $history_uri = $drequest->generateURI(
       array(
@@ -290,7 +290,7 @@ final class DiffusionLintController extends DiffusionController {
       id(new PhabricatorActionView())
         ->setName(pht('View History'))
         ->setHref($history_uri)
-        ->setIcon('history'));
+        ->setIcon('fa-clock-o'));
 
     $browse_uri = $drequest->generateURI(
       array(
@@ -301,7 +301,7 @@ final class DiffusionLintController extends DiffusionController {
       id(new PhabricatorActionView())
         ->setName(pht('Browse Content'))
         ->setHref($browse_uri)
-        ->setIcon('file'));
+        ->setIcon('fa-files-o'));
 
     return $view;
   }

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

@@ -1098,7 +1098,7 @@ final class DiffusionRepositoryEditMainController
 
       $item->addAction(
         id(new PHUIListItemView())
-          ->setIcon('delete')
+          ->setIcon('fa-times')
           ->setHref($delete_uri)
           ->setWorkflow(true));
 

src/applications/drydock/controller/DrydockLeaseViewController.php

@@ -76,7 +76,7 @@ final class DrydockLeaseViewController extends DrydockLeaseController {
     $view->addAction(
       id(new PhabricatorActionView())
         ->setName(pht('Release Lease'))
-        ->setIcon('delete')
+        ->setIcon('fa-times')
         ->setHref($this->getApplicationURI("/lease/{$id}/release/"))
         ->setWorkflow(true)
         ->setDisabled(!$can_release));

src/applications/drydock/controller/DrydockResourceViewController.php

@@ -87,7 +87,7 @@ final class DrydockResourceViewController extends DrydockResourceController {
       id(new PhabricatorActionView())
         ->setHref($uri)
         ->setName(pht('Close Resource'))
-        ->setIcon('delete')
+        ->setIcon('fa-times')
         ->setWorkflow(true)
         ->setDisabled(!$can_close));
 

src/applications/files/controller/PhabricatorFileInfoController.php

@@ -129,7 +129,7 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
       $view->addAction(
         id(new PhabricatorActionView())
           ->setName(pht('View File'))
-          ->setIcon('preview')
+          ->setIcon('fa-file-o')
           ->setHref($file->getViewURI()));
     } else {
       $view->addAction(
@@ -138,14 +138,14 @@ final class PhabricatorFileInfoController extends PhabricatorFileController {
           ->setRenderAsForm(true)
           ->setDownload(true)
           ->setName(pht('Download File'))
-          ->setIcon('download')
+          ->setIcon('fa-download')
           ->setHref($file->getViewURI()));
     }
 
     $view->addAction(
       id(new PhabricatorActionView())
         ->setName(pht('Delete File'))
-        ->setIcon('delete')
+        ->setIcon('fa-times')
         ->setHref($this->getApplicationURI("/delete/{$id}/"))
         ->setWorkflow(true));
 

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

@@ -246,7 +246,7 @@ final class HarbormasterBuildViewController
     $list->addAction(
       id(new PhabricatorActionView())
         ->setName(pht('Restart Build'))
-        ->setIcon('backward')
+        ->setIcon('fa-backward')
         ->setHref($this->getApplicationURI('/build/restart/'.$id.'/'))
         ->setDisabled(!$can_restart)
         ->setWorkflow(true));
@@ -254,7 +254,7 @@ final class HarbormasterBuildViewController
     $list->addAction(
       id(new PhabricatorActionView())
         ->setName(pht('Stop Build'))
-        ->setIcon('stop')
+        ->setIcon('fa-stop')
         ->setHref($this->getApplicationURI('/build/stop/'.$id.'/'))
         ->setDisabled(!$can_stop)
         ->setWorkflow(true));
@@ -262,7 +262,7 @@ final class HarbormasterBuildViewController
     $list->addAction(
       id(new PhabricatorActionView())
         ->setName(pht('Resume Build'))
-        ->setIcon('play')
+        ->setIcon('fa-play')
         ->setHref($this->getApplicationURI('/build/resume/'.$id.'/'))
         ->setDisabled(!$can_resume)
         ->setWorkflow(true));

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

@@ -101,7 +101,7 @@ final class HarbormasterBuildableViewController
 
     $list->addAction(
       id(new PhabricatorActionView())
-        ->setIcon('backward')
+        ->setIcon('fa-backward')
         ->setName(pht('Restart All Builds'))
         ->setHref($this->getApplicationURI($restart_uri))
         ->setWorkflow(true)
@@ -109,7 +109,7 @@ final class HarbormasterBuildableViewController
 
     $list->addAction(
       id(new PhabricatorActionView())
-        ->setIcon('stop')
+        ->setIcon('fa-stop')
         ->setName(pht('Stop All Builds'))
         ->setHref($this->getApplicationURI($stop_uri))
         ->setWorkflow(true)
@@ -117,7 +117,7 @@ final class HarbormasterBuildableViewController
 
     $list->addAction(
       id(new PhabricatorActionView())
-        ->setIcon('play')
+        ->setIcon('fa-play')
         ->setName(pht('Resume All Builds'))
         ->setHref($this->getApplicationURI($resume_uri))
         ->setWorkflow(true)
@@ -197,11 +197,11 @@ final class HarbormasterBuildableViewController
       $item->addAttribute(HarbormasterBuild::getBuildStatusName($status));
 
       if ($build->isRestarting()) {
-        $item->addIcon('backward', pht('Restarting'));
+        $item->addIcon('fa-backward', pht('Restarting'));
       } else if ($build->isStopping()) {
-        $item->addIcon('stop', pht('Stopping'));
+        $item->addIcon('fa-stop', pht('Stopping'));
       } else if ($build->isResuming()) {
-        $item->addIcon('play', pht('Resuming'));
+        $item->addIcon('fa-play', pht('Resuming'));
       }
 
       $build_id = $build->getID();
@@ -212,7 +212,7 @@ final class HarbormasterBuildableViewController
 
       $item->addAction(
         id(new PHUIListItemView())
-          ->setIcon('backward')
+          ->setIcon('fa-backward')
           ->setName(pht('Restart'))
           ->setHref($this->getApplicationURI($restart_uri))
           ->setWorkflow(true)
@@ -221,14 +221,14 @@ final class HarbormasterBuildableViewController
       if ($build->canResumeBuild()) {
         $item->addAction(
           id(new PHUIListItemView())
-            ->setIcon('play')
+            ->setIcon('fa-play')
             ->setName(pht('Resume'))
             ->setHref($this->getApplicationURI($resume_uri))
             ->setWorkflow(true));
       } else {
         $item->addAction(
           id(new PHUIListItemView())
-            ->setIcon('stop')
+            ->setIcon('fa-stop')
             ->setName(pht('Stop'))
             ->setHref($this->getApplicationURI($stop_uri))
             ->setWorkflow(true)

src/applications/herald/query/HeraldRuleSearchEngine.php

@@ -184,24 +184,24 @@ final class HeraldRuleSearchEngine
         ->setHref($this->getApplicationURI("rule/{$id}/"));
 
       if ($rule->isPersonalRule()) {
-        $item->addIcon('user', pht('Personal Rule'));
+        $item->addIcon('fa-user', pht('Personal Rule'));
         $item->addByline(
           pht(
             'Authored by %s',
             $handles[$rule->getAuthorPHID()]->renderLink()));
       } else {
-        $item->addIcon('world', pht('Global Rule'));
+        $item->addIcon('fa-globe', pht('Global Rule'));
       }
 
       if ($rule->getIsDisabled()) {
         $item->setDisabled(true);
-        $item->addIcon('disable-grey', pht('Disabled'));
+        $item->addIcon('fa-lock grey', pht('Disabled'));
       }
 
       $item->addAction(
         id(new PHUIListItemView())
           ->setHref($this->getApplicationURI("history/{$id}/"))
-          ->setIcon('transcript')
+          ->setIcon('fa-file-text-o')
           ->setName(pht('Edit Log')));
 
       $content_type_name = idx($content_type_map, $rule->getContentType());

src/applications/phame/controller/post/PhamePostViewController.php

@@ -119,13 +119,13 @@ final class PhamePostViewController extends PhameController {
     if ($post->isDraft()) {
       $actions->addAction(
         id(new PhabricatorActionView())
-          ->setIcon('preview')
+          ->setIcon('fa-eye')
           ->setHref($this->getApplicationURI('post/publish/'.$id.'/'))
           ->setName(pht('Preview / Publish')));
     } else {
       $actions->addAction(
         id(new PhabricatorActionView())
-          ->setIcon('unpublish')
+          ->setIcon('fa-eye-slash')
           ->setHref($this->getApplicationURI('post/unpublish/'.$id.'/'))
           ->setName(pht('Unpublish'))
           ->setWorkflow(true));
@@ -133,7 +133,7 @@ final class PhamePostViewController extends PhameController {
 
     $actions->addAction(
       id(new PhabricatorActionView())
-        ->setIcon('delete')
+        ->setIcon('fa-times')
         ->setHref($this->getApplicationURI('post/delete/'.$id.'/'))
         ->setName(pht('Delete Post'))
         ->setDisabled(!$can_edit)
@@ -152,7 +152,7 @@ final class PhamePostViewController extends PhameController {
     $actions->addAction(
       id(new PhabricatorActionView())
         ->setUser($user)
-        ->setIcon('world')
+        ->setIcon('fa-globe')
         ->setHref($live_uri)
         ->setName(pht('View Live'))
         ->setDisabled(!$can_view_live)

src/applications/phragment/controller/PhragmentHistoryController.php

@@ -72,7 +72,7 @@ final class PhragmentHistoryController extends PhragmentController {
 
       if (!$first && $can_edit) {
         $item->addAction(id(new PHUIListItemView())
-          ->setIcon('undo')
+          ->setIcon('fa-refresh')
           ->setRenderNameAsTooltip(true)
           ->setWorkflow(true)
           ->setName(pht("Revert to Here"))
@@ -82,7 +82,7 @@ final class PhragmentHistoryController extends PhragmentController {
 
       $disabled = !isset($files[$version->getFilePHID()]);
       $action = id(new PHUIListItemView())
-        ->setIcon('download')
+        ->setIcon('fa-download')
         ->setDisabled($disabled || !$this->isCorrectlyConfigured())
         ->setRenderNameAsTooltip(true)
         ->setName(pht("Download"));

src/applications/phragment/controller/PhragmentSnapshotViewController.php

@@ -117,7 +117,7 @@ final class PhragmentSnapshotViewController extends PhragmentController {
         ->setName(pht('Download Snapshot as ZIP'))
         ->setHref($this->isCorrectlyConfigured() ? $zip_uri : null)
         ->setDisabled(!$this->isCorrectlyConfigured())
-        ->setIcon('zip'));
+        ->setIcon('fa-floppy-o'));
     $actions->addAction(
       id(new PhabricatorActionView())
         ->setName(pht('Delete Snapshot'))
@@ -125,7 +125,7 @@ final class PhragmentSnapshotViewController extends PhragmentController {
           "snapshot/delete/".$snapshot->getID()."/"))
         ->setDisabled(!$can_edit)
         ->setWorkflow(true)
-        ->setIcon('delete'));
+        ->setIcon('fa-times'));
     $actions->addAction(
       id(new PhabricatorActionView())
         ->setName(pht('Promote Another Snapshot to Here'))
@@ -133,7 +133,7 @@ final class PhragmentSnapshotViewController extends PhragmentController {
           "snapshot/promote/".$snapshot->getID()."/"))
         ->setDisabled(!$can_edit)
         ->setWorkflow(true)
-        ->setIcon('promote'));
+        ->setIcon('fa-arrow-up'));
 
     $properties = id(new PHUIPropertyListView())
       ->setUser($viewer)

src/applications/phragment/controller/PhragmentVersionController.php

@@ -63,7 +63,7 @@ final class PhragmentVersionController extends PhragmentController {
         ->setName(pht('Download Version'))
         ->setDisabled($file === null || !$this->isCorrectlyConfigured())
         ->setHref($this->isCorrectlyConfigured() ? $file_uri : null)
-        ->setIcon('download'));
+        ->setIcon('fa-download'));
 
     $properties = id(new PHUIPropertyListView())
       ->setUser($viewer)
@@ -113,7 +113,7 @@ final class PhragmentVersionController extends PhragmentController {
       $patch_uri = $this->getApplicationURI(
         'patch/'.$previous_version->getID().'/'.$version->getID());
       $item->addAction(id(new PHUIListItemView())
-        ->setIcon('patch')
+        ->setIcon('fa-file-o')
         ->setName(pht("Get Patch"))
         ->setHref($this->isCorrectlyConfigured() ? $patch_uri : null)
         ->setDisabled(!$this->isCorrectlyConfigured()));
@@ -124,7 +124,7 @@ final class PhragmentVersionController extends PhragmentController {
     $item->setHeader('Prior to Version 0');
     $item->addAttribute('Prior to any content (empty file)');
     $item->addAction(id(new PHUIListItemView())
-      ->setIcon('patch')
+      ->setIcon('fa-file-o')
       ->setName(pht("Get Patch"))
       ->setHref($this->getApplicationURI(
         'patch/x/'.$version->getID())));

src/applications/phrequent/query/PhrequentSearchEngine.php

@@ -182,7 +182,7 @@ final class PhrequentSearchEngine
             $usertime->getUserPHID() === $viewer->getPHID()) {
           $item->addAction(
             id(new PHUIListItemView())
-              ->setIcon('history')
+              ->setIcon('fa-time-o')
               ->addSigil('phrequent-stop-tracking')
               ->setWorkflow(true)
               ->setRenderNameAsTooltip(true)

src/applications/settings/panel/PhabricatorSettingsPanelExternalAccounts.php

@@ -76,13 +76,13 @@ final class PhabricatorSettingsPanelExternalAccounts
       if ($can_refresh) {
         $item->addAction(
           id(new PHUIListItemView())
-            ->setIcon('refresh')
+            ->setIcon('fa-refresh')
             ->setHref('/auth/refresh/'.$account->getProviderKey().'/'));
       }
 
       $item->addAction(
         id(new PHUIListItemView())
-          ->setIcon('delete')
+          ->setIcon('fa-times')
           ->setWorkflow(true)
           ->setDisabled(!$can_unlink)
           ->setHref('/auth/unlink/'.$account->getProviderKey().'/'));
@@ -124,7 +124,7 @@ final class PhabricatorSettingsPanelExternalAccounts
       $item->setHref($link_uri);
       $item->addAction(
         id(new PHUIListItemView())
-          ->setIcon('link')
+          ->setIcon('fa-link')
           ->setHref($link_uri));
 
       $linkable->addItem($item);

src/applications/uiexample/examples/PHUITimelineExample.php

@@ -29,57 +29,57 @@ final class PHUITimelineExample extends PhabricatorUIExample {
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
-      ->setIcon('love')
+      ->setIcon('fa-heart')
       ->setTitle('A minor event.');
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
-      ->setIcon('comment')
+      ->setIcon('fa-comment')
       ->appendChild('A major event with no title.');
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
-      ->setIcon('dislike')
+      ->setIcon('fa-star')
       ->setTitle('Another minor event.');
 
     $events[] = id(new PHUITimelineEventView())
-      ->setIcon('like')
+      ->setIcon('fa-trophy')
       ->setToken('medal-1')
       ->setUserHandle($handle);
 
     $events[] = id(new PHUITimelineEventView())
-      ->setIcon('dislike')
+      ->setIcon('fa-quote-left')
       ->setToken('medal-1', true)
       ->setUserHandle($handle);
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
       ->setTitle('Major Red Event')
-      ->setIcon('love')
+      ->setIcon('fa-heart-o')
       ->appendChild('This event is red!')
       ->setColor(PhabricatorTransactions::COLOR_RED);
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
-      ->setIcon('love')
+      ->setIcon('fa-female')
       ->setTitle('Minor Red Event')
       ->setColor(PhabricatorTransactions::COLOR_RED);
 
     $events[] = id(new PHUITimelineEventView())
-      ->setIcon('like')
+      ->setIcon('fa-refresh')
       ->setUserHandle($handle)
       ->setTitle('Minor Not-Red Event')
       ->setColor(PhabricatorTransactions::COLOR_GREEN);
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
-      ->setIcon('love')
+      ->setIcon('fa-calendar-o')
       ->setTitle('Minor Red Event')
       ->setColor(PhabricatorTransactions::COLOR_RED);
 
     $events[] = id(new PHUITimelineEventView())
       ->setUserHandle($handle)
-      ->setIcon('dislike')
+      ->setIcon('fa-random')
       ->setTitle('Minor Not-Red Event')
       ->setColor(PhabricatorTransactions::COLOR_BLACK);
 

src/infrastructure/customfield/config/PhabricatorCustomFieldConfigOptionType.php

@@ -83,21 +83,21 @@ final class PhabricatorCustomFieldConfigOptionType
         id(new PHUIListItemView())
           ->setHref('#')
           ->addSigil('field-spec-toggle')
-          ->setIcon('new'));
+          ->setIcon('fa-plus'));
 
       $enabled_item->setBarColor('green');
 
       if (!$field->canDisableField()) {
         $enabled_item->addAction(
           id(new PHUIListItemView())
-            ->setIcon('lock-grey'));
+            ->setIcon('fa-lock grey'));
         $enabled_item->addIcon('none', pht('Permanent Field'));
       } else {
         $enabled_item->addAction(
           id(new PHUIListItemView())
             ->setHref('#')
             ->addSigil('field-spec-toggle')
-            ->setIcon('delete'));
+            ->setIcon('fa-times'));
       }
 
       $fields[$key] = array(