Apply some autofix linter rules

Summary: Self-explanatory.

Test Plan: Eyeball it.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10454

src/aphront/configuration/AphrontApplicationConfiguration.php

@@ -52,8 +52,7 @@ abstract class AphrontApplicationConfiguration {
     return $this->path;
   }
 
-  public function willBuildRequest() {
-  }
+  public function willBuildRequest() {}
 
 
 /* -(  URI Routing  )-------------------------------------------------------- */

src/aphront/exception/AphrontCSRFException.php

@@ -1,5 +1,3 @@
 <?php
 
-final class AphrontCSRFException extends AphrontException {
-
-}
+final class AphrontCSRFException extends AphrontException {}

src/aphront/exception/AphrontException.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class AphrontException extends Exception {
-
-}
+abstract class AphrontException extends Exception {}

src/applications/audit/management/PhabricatorAuditManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorAuditManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/auth/data/PhabricatorAuthHighSecurityToken.php

@@ -1,5 +1,3 @@
 <?php
 
-final class PhabricatorAuthHighSecurityToken {
-
-}
+final class PhabricatorAuthHighSecurityToken {}

src/applications/auth/management/PhabricatorAuthManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorAuthManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/base/controller/__tests__/PhabricatorTestController.php

@@ -33,8 +33,6 @@ final class PhabricatorTestController extends PhabricatorController {
     return $this->getConfig('enabled', parent::shouldRequireEnabledUser());
   }
 
-  public function processRequest() {
-
-  }
+  public function processRequest() {}
 
 }

src/applications/cache/management/PhabricatorCacheManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorCacheManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/calendar/exception/PhabricatorCalendarEventInvalidEpochException.php

@@ -1,4 +1,3 @@
 <?php
 
-final class PhabricatorCalendarEventInvalidEpochException extends Exception {
-}
+final class PhabricatorCalendarEventInvalidEpochException extends Exception {}

src/applications/chatlog/constants/PhabricatorChatLogConstants.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhabricatorChatLogConstants {
-
-}
+abstract class PhabricatorChatLogConstants {}

src/applications/chatlog/controller/PhabricatorChatLogController.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhabricatorChatLogController extends PhabricatorController {
-
-}
+abstract class PhabricatorChatLogController extends PhabricatorController {}

src/applications/conduit/protocol/exception/ConduitMethodNotFoundException.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class ConduitMethodNotFoundException extends ConduitException {
-
-}
+abstract class ConduitMethodNotFoundException extends ConduitException {}

src/applications/config/exception/PhabricatorConfigValidationException.php

@@ -1,5 +1,3 @@
 <?php
 
-final class PhabricatorConfigValidationException extends Exception {
-
-}
+final class PhabricatorConfigValidationException extends Exception {}

src/applications/config/management/PhabricatorConfigManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorConfigManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/dashboard/controller/PhabricatorDashboardController.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhabricatorDashboardController extends PhabricatorController {
-
-}
+abstract class PhabricatorDashboardController extends PhabricatorController {}

src/applications/dashboard/customfield/PhabricatorDashboardPanelCustomField.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorDashboardPanelCustomField
-  extends PhabricatorCustomField {
-
-}
+  extends PhabricatorCustomField {}

src/applications/differential/editor/DifferentialTransactionEditor.php

@@ -1040,8 +1040,7 @@ final class DifferentialTransactionEditor
     PhabricatorLiskDAO $object,
     PhabricatorApplicationTransaction $xaction) {
 
-    switch ($xaction->getTransactionType()) {
-    }
+    switch ($xaction->getTransactionType()) {}
 
     return parent::requireCapabilities($object, $xaction);
   }

src/applications/differential/exception/DifferentialDiffCreationRejectException.php

@@ -1,5 +1,3 @@
 <?php
 
-final class DifferentialDiffCreationRejectException extends Exception {
-
-}
+final class DifferentialDiffCreationRejectException extends Exception {}

src/applications/differential/exception/DifferentialFieldParseException.php

@@ -1,5 +1,3 @@
 <?php
 
-final class DifferentialFieldParseException extends Exception {
-
-}
+final class DifferentialFieldParseException extends Exception {}

src/applications/differential/exception/DifferentialFieldValidationException.php

@@ -1,5 +1,3 @@
 <?php
 
-final class DifferentialFieldValidationException extends Exception {
-
-}
+final class DifferentialFieldValidationException extends Exception {}

src/applications/differential/management/PhabricatorHunksManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorHunksManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/diffusion/controller/DiffusionBrowseSearchController.php

@@ -133,8 +133,7 @@ final class DiffusionBrowseSearchController extends DiffusionBrowseController {
 
     try {
       Futures($futures)->limit(8)->resolveAll();
-    } catch (PhutilSyntaxHighlighterException $ex) {
-    }
+    } catch (PhutilSyntaxHighlighterException $ex) {}
 
     $rows = array();
     foreach ($results as $result) {
@@ -148,8 +147,7 @@ final class DiffusionBrowseSearchController extends DiffusionBrowseController {
 
       try {
         $string = $futures["{$path}:{$line}"]->resolve();
-      } catch (PhutilSyntaxHighlighterException $ex) {
-      }
+      } catch (PhutilSyntaxHighlighterException $ex) {}
 
       $string = phutil_tag(
         'pre',

src/applications/diffusion/controller/DiffusionPushLogController.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class DiffusionPushLogController extends DiffusionController {
-
-}
+abstract class DiffusionPushLogController extends DiffusionController {}

src/applications/diffusion/exception/DiffusionCommitHookRejectException.php

@@ -1,5 +1,3 @@
 <?php
 
-final class DiffusionCommitHookRejectException extends Exception {
-
-}
+final class DiffusionCommitHookRejectException extends Exception {}

src/applications/diffusion/ssh/DiffusionSSHMercurialWorkflow.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class DiffusionSSHMercurialWorkflow extends DiffusionSSHWorkflow {
-
-}
+abstract class DiffusionSSHMercurialWorkflow extends DiffusionSSHWorkflow {}

src/applications/doorkeeper/exception/DoorkeeperMissingLinkException.php

@@ -1,5 +1,3 @@
 <?php
 
-final class DoorkeeperMissingLinkException extends Exception {
-
-}
+final class DoorkeeperMissingLinkException extends Exception {}

src/applications/drydock/constants/DrydockConstants.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class DrydockConstants {
-
-}
+abstract class DrydockConstants {}

src/applications/drydock/customfield/DrydockBlueprintCustomField.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class DrydockBlueprintCustomField
-  extends PhabricatorCustomField {
-
-}
+  extends PhabricatorCustomField {}

src/applications/drydock/management/DrydockManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class DrydockManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/drydock/query/DrydockBlueprintSearchEngine.php

@@ -21,9 +21,7 @@ final class DrydockBlueprintSearchEngine
 
   public function buildSearchForm(
     AphrontFormView $form,
-    PhabricatorSavedQuery $saved) {
-
-  }
+    PhabricatorSavedQuery $saved) {}
 
   protected function getURI($path) {
     return '/drydock/blueprint/'.$path;

src/applications/drydock/query/DrydockLogSearchEngine.php

@@ -20,9 +20,7 @@ final class DrydockLogSearchEngine extends PhabricatorApplicationSearchEngine {
 
   public function buildSearchForm(
     AphrontFormView $form,
-    PhabricatorSavedQuery $saved) {
-
-  }
+    PhabricatorSavedQuery $saved) {}
 
   protected function getURI($path) {
     return '/drydock/log/'.$path;

src/applications/fact/controller/PhabricatorFactController.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhabricatorFactController extends PhabricatorController {
-
-}
+abstract class PhabricatorFactController extends PhabricatorController {}

src/applications/fact/management/PhabricatorFactManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorFactManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/feed/constants/PhabricatorFeedConstants.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhabricatorFeedConstants {
-
-}
+abstract class PhabricatorFeedConstants {}

src/applications/feed/management/PhabricatorFeedManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorFeedManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/files/editor/PhabricatorFileEditor.php

@@ -22,15 +22,11 @@ final class PhabricatorFileEditor
 
   protected function getCustomTransactionOldValue(
     PhabricatorLiskDAO $object,
-    PhabricatorApplicationTransaction $xaction) {
-
-  }
+    PhabricatorApplicationTransaction $xaction) {}
 
   protected function getCustomTransactionNewValue(
     PhabricatorLiskDAO $object,
-    PhabricatorApplicationTransaction $xaction) {
-
-  }
+    PhabricatorApplicationTransaction $xaction) {}
 
   protected function applyCustomInternalTransaction(
     PhabricatorLiskDAO $object,
@@ -45,8 +41,7 @@ final class PhabricatorFileEditor
 
   protected function applyCustomExternalTransaction(
     PhabricatorLiskDAO $object,
-    PhabricatorApplicationTransaction $xaction) {
-  }
+    PhabricatorApplicationTransaction $xaction) {}
 
   protected function shouldSendMail(
     PhabricatorLiskDAO $object,

src/applications/flag/constants/PhabricatorFlagConstants.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhabricatorFlagConstants {
-
-}
+abstract class PhabricatorFlagConstants {}

src/applications/flag/interface/PhabricatorFlaggableInterface.php

@@ -1,5 +1,3 @@
 <?php
 
-interface PhabricatorFlaggableInterface extends PhabricatorPHIDInterface {
-
-}
+interface PhabricatorFlaggableInterface extends PhabricatorPHIDInterface {}

src/applications/harbormaster/customfield/HarbormasterBuildStepCustomField.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class HarbormasterBuildStepCustomField
-  extends PhabricatorCustomField {
-
-}
+  extends PhabricatorCustomField {}

src/applications/harbormaster/exception/HarbormasterBuildAbortedException.php

@@ -1,5 +1,3 @@
 <?php
 
-final class HarbormasterBuildAbortedException extends Exception {
-
-}
+final class HarbormasterBuildAbortedException extends Exception {}

src/applications/harbormaster/exception/HarbormasterBuildFailureException.php

@@ -1,5 +1,3 @@
 <?php
 
-final class HarbormasterBuildFailureException extends Exception {
-
-}
+final class HarbormasterBuildFailureException extends Exception {}

src/applications/harbormaster/management/HarbormasterManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class HarbormasterManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/lipsum/management/PhabricatorLipsumManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorLipsumManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/metamta/constants/MetaMTAConstants.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class MetaMTAConstants {
-
-}
+abstract class MetaMTAConstants {}

src/applications/metamta/controller/PhabricatorMetaMTAController.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhabricatorMetaMTAController extends PhabricatorController {
-
-}
+abstract class PhabricatorMetaMTAController extends PhabricatorController {}

src/applications/metamta/exception/PhabricatorMetaMTAPermanentFailureException.php

@@ -1,6 +1,4 @@
 <?php
 
 final class PhabricatorMetaMTAPermanentFailureException
-  extends Exception {
-
-}
+  extends Exception {}

src/applications/metamta/management/PhabricatorMailManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorMailManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/nuance/constants/NuanceConstants.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class NuanceConstants {
-
-}
+abstract class NuanceConstants {}

src/applications/nuance/controller/NuanceController.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class NuanceController extends PhabricatorController {
-
-}
+abstract class NuanceController extends PhabricatorController {}

src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php

@@ -34,10 +34,8 @@ final class NuancePhabricatorFormSourceDefinition
     return $transactions;
   }
 
-  public function renderView() {
-  }
+  public function renderView() {}
 
-  public function renderListView() {
-  }
+  public function renderListView() {}
 
 }

src/applications/people/customfield/PhabricatorUserCustomField.php

@@ -1,7 +1,4 @@
 <?php
 
 abstract class PhabricatorUserCustomField
-  extends PhabricatorCustomField {
-
-
-}
+  extends PhabricatorCustomField {}

src/applications/people/lipsum/PhabricatorPeopleTestDataGenerator.php

@@ -25,8 +25,7 @@ final class PhabricatorPeopleTestDataGenerator
           ->createNewUser($user, $email_object);
 
         return $user;
-      } catch (AphrontDuplicateKeyQueryException $ex) {
-      }
+      } catch (AphrontDuplicateKeyQueryException $ex) {}
     }
   }
 

src/applications/phid/handle/const/PhabricatorObjectHandleConstants.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhabricatorObjectHandleConstants {
-
-}
+abstract class PhabricatorObjectHandleConstants {}

src/applications/phortune/constants/PhortuneConstants.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhortuneConstants {
-
-}
+abstract class PhortuneConstants {}

src/applications/phrequent/interface/PhrequentTrackableInterface.php

@@ -1,5 +1,3 @@
 <?php
 
-interface PhrequentTrackableInterface {
-
-}
+interface PhrequentTrackableInterface {}

src/applications/policy/constants/PhabricatorPolicyConstants.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhabricatorPolicyConstants {
-
-}
+abstract class PhabricatorPolicyConstants {}

src/applications/policy/controller/PhabricatorPolicyController.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhabricatorPolicyController extends PhabricatorController {
-
-}
+abstract class PhabricatorPolicyController extends PhabricatorController {}

src/applications/policy/management/PhabricatorPolicyManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorPolicyManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/ponder/constants/PonderConstants.php

@@ -1,4 +1,3 @@
 <?php
 
-abstract class PonderConstants {
-}
+abstract class PonderConstants {}

src/applications/project/constants/PhabricatorProjectConstants.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhabricatorProjectConstants {
-
-}
+abstract class PhabricatorProjectConstants {}

src/applications/project/exception/PhabricatorProjectNameCollisionException.php

@@ -4,6 +4,4 @@
  * Thrown when you try to save a project with a name too similar to another
  * project.
  */
-final class PhabricatorProjectNameCollisionException extends Exception {
-
-}
+final class PhabricatorProjectNameCollisionException extends Exception {}

src/applications/project/interface/PhabricatorProjectInterface.php

@@ -1,5 +1,3 @@
 <?php
 
-interface PhabricatorProjectInterface {
-
-}
+interface PhabricatorProjectInterface {}

src/applications/project/query/PhabricatorProjectSearchEngine.php

@@ -193,13 +193,9 @@ final class PhabricatorProjectSearchEngine
     );
   }
 
-  private function getColorValues() {
+  private function getColorValues() {}
 
-  }
-
-  private function getIconValues() {
-
-  }
+  private function getIconValues() {}
 
   protected function getRequiredHandlePHIDsForResultList(
     array $projects,

src/applications/releeph/controller/request/ReleephRequestController.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class ReleephRequestController extends ReleephController {
-
-}
+abstract class ReleephRequestController extends ReleephController {}

src/applications/repository/customfield/PhabricatorCommitCustomField.php

@@ -1,7 +1,4 @@
 <?php
 
 abstract class PhabricatorCommitCustomField
-  extends PhabricatorCustomField {
-
-
-}
+  extends PhabricatorCustomField {}

src/applications/repository/editor/PhabricatorRepositoryEditor.php

@@ -257,8 +257,7 @@ final class PhabricatorRepositoryEditor
     PhabricatorApplicationTransaction $v) {
 
     $type = $u->getTransactionType();
-    switch ($type) {
-    }
+    switch ($type) {}
 
     return parent::mergeTransactions($u, $v);
   }
@@ -271,9 +270,7 @@ final class PhabricatorRepositoryEditor
     $new = $xaction->getNewValue();
 
     $type = $xaction->getTransactionType();
-    switch ($type) {
-
-    }
+    switch ($type) {}
 
     return parent::transactionHasEffect($object, $xaction);
   }

src/applications/search/management/PhabricatorSearchManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorSearchManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/applications/system/management/PhabricatorSystemRemoveWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorSystemRemoveWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/infrastructure/celerity/management/CelerityManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class CelerityManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/infrastructure/customfield/exception/PhabricatorCustomFieldNotAttachedException.php

@@ -1,6 +1,4 @@
 <?php
 
 final class PhabricatorCustomFieldNotAttachedException
-  extends Exception {
-
-}
+  extends Exception {}

src/infrastructure/daemon/workers/exception/PhabricatorWorkerPermanentFailureException.php

@@ -1,5 +1,3 @@
 <?php
 
-final class PhabricatorWorkerPermanentFailureException extends Exception {
-
-}
+final class PhabricatorWorkerPermanentFailureException extends Exception {}

src/infrastructure/edges/constants/PhabricatorEdgeConstants.php

@@ -1,5 +1,3 @@
 <?php
 
-abstract class PhabricatorEdgeConstants {
-
-}
+abstract class PhabricatorEdgeConstants {}

src/infrastructure/events/PhabricatorAutoEventListener.php

@@ -12,6 +12,4 @@
  * startup. This allows it to be used with custom one-offs that can be dropped
  * into `phabricator/src/extensions/`.
  */
-abstract class PhabricatorAutoEventListener extends PhabricatorEventListener {
-
-}
+abstract class PhabricatorAutoEventListener extends PhabricatorEventListener {}

src/infrastructure/internationalization/management/PhabricatorInternationalizationManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorInternationalizationManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/infrastructure/query/PhabricatorEmptyQueryException.php

@@ -1,5 +1,3 @@
 <?php
 
-final class PhabricatorEmptyQueryException extends Exception {
-
-}
+final class PhabricatorEmptyQueryException extends Exception {}

src/infrastructure/sms/management/PhabricatorSMSManagementWorkflow.php

@@ -1,6 +1,4 @@
 <?php
 
 abstract class PhabricatorSMSManagementWorkflow
-  extends PhabricatorManagementWorkflow {
-
-}
+  extends PhabricatorManagementWorkflow {}

src/infrastructure/util/password/PhabricatorPasswordHasherUnavailableException.php

@@ -1,5 +1,3 @@
 <?php
 
-final class PhabricatorPasswordHasherUnavailableException extends Exception {
-
-}
+final class PhabricatorPasswordHasherUnavailableException extends Exception {}