Revert use of "user-select: all" to modify tab selection behavior

Summary:
Reverts D21419. See PHI1814. Previously, I used "user-select: all" to group sequences of spaces for selection.

However, this has a side effect: the sequence is now selected with a single click. I didn't read the docuementation on the CSS property thoroughly and missed this in testing, since I was focused on drag-selection behavior.

This behavior is enough of a net negative that I think we're in a worse state overall; revert it.

Test Plan: Straight revert.

Differential Revision: https://secure.phabricator.com/D21429

resources/celerity/map.php

@@ -9,7 +9,7 @@ return array(
   'names' => array(
     'conpherence.pkg.css' => '0e3cf785',
     'conpherence.pkg.js' => '020aebcf',
-    'core.pkg.css' => '2e175364',
+    'core.pkg.css' => 'da792a0f',
     'core.pkg.js' => '845355f4',
     'dark-console.pkg.js' => '187792c2',
     'differential.pkg.css' => '5c459f92',
@@ -115,7 +115,7 @@ return array(
     'rsrc/css/application/uiexample/example.css' => 'b4795059',
     'rsrc/css/core/core.css' => '1b29ed61',
     'rsrc/css/core/remarkup.css' => '7d3ebc86',
-    'rsrc/css/core/syntax.css' => '98fdb17e',
+    'rsrc/css/core/syntax.css' => '548567f6',
     'rsrc/css/core/z-index.css' => 'ac3bfcd4',
     'rsrc/css/diviner/diviner-shared.css' => '4bd263b0',
     'rsrc/css/font/font-awesome.css' => '3883938a',
@@ -909,7 +909,7 @@ return array(
     'sprite-login-css' => '18b368a6',
     'sprite-tokens-css' => 'f1896dc5',
     'syntax-default-css' => '055fc231',
-    'syntax-highlighting-css' => '98fdb17e',
+    'syntax-highlighting-css' => '548567f6',
     'tokens-css' => 'ce5a50bd',
     'trigger-rule' => '41b7b4f6',
     'trigger-rule-control' => '5faf27b9',
@@ -1422,6 +1422,9 @@ return array(
       'phuix-autocomplete',
       'javelin-mask',
     ),
+    '548567f6' => array(
+      'syntax-default-css',
+    ),
     '55a24e84' => array(
       'javelin-install',
       'javelin-dom',
@@ -1800,9 +1803,6 @@ return array(
       'javelin-request',
       'javelin-util',
     ),
-    '98fdb17e' => array(
-      'syntax-default-css',
-    ),
     '995f5102' => array(
       'javelin-install',
       'javelin-util',

src/applications/differential/parser/DifferentialChangesetParser.php

@@ -1604,13 +1604,6 @@ final class DifferentialChangesetParser extends Phobject {
           'span',
           array(
             'data-copy-text' => "\t",
-
-            // See PHI1814. Mark this as a single logical tab for the purposes
-            // of text selection behavior: when the user drags their mouse over
-            // the character sequence, we'd like the whole thing to select as
-            // a single unit.
-
-            'class' => 'logical-tab',
           ),
           str_repeat(' ', $ii));
         $tag = phutil_string_cast($tag);

src/applications/differential/parser/__tests__/DifferentialTabReplacementTestCase.php

@@ -4,8 +4,8 @@ final class DifferentialTabReplacementTestCase
   extends PhabricatorTestCase {
 
   public function testTabReplacement() {
-    $tab1 = "<span data-copy-text=\"\t\" class=\"logical-tab\"> </span>";
-    $tab2 = "<span data-copy-text=\"\t\" class=\"logical-tab\">  </span>";
+    $tab1 = "<span data-copy-text=\"\t\"> </span>";
+    $tab2 = "<span data-copy-text=\"\t\">  </span>";
 
     $cat = "\xF0\x9F\x90\xB1";
 

webroot/rsrc/css/core/syntax.css

@@ -39,8 +39,3 @@ span.crossreference-item {
   color: #ffffff;
   cursor: default;
 }
-
-.logical-tab {
-  user-select: all;
-  -webkit-user-select: all;
-}