1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-27 07:50:57 +01:00

Couple of Diffusion tweaks

Summary:
 - Fix spacing on InfoView inside collasped boxes
 - Fix spacing on stacked PropertyLists in TwoColumn
 - Fix spacing on Readmes on Tablets
 - Fix unset variable on importing commits

Test Plan: Review each of the above cases.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15496
This commit is contained in:
Chad Little 2016-03-18 12:01:15 -07:00
parent 61ab7afc9c
commit 01885cad1c
4 changed files with 12 additions and 8 deletions

View file

@ -65,7 +65,7 @@ return array(
'rsrc/css/application/differential/revision-list.css' => 'f3c47d33', 'rsrc/css/application/differential/revision-list.css' => 'f3c47d33',
'rsrc/css/application/differential/table-of-contents.css' => 'ae4b7a55', 'rsrc/css/application/differential/table-of-contents.css' => 'ae4b7a55',
'rsrc/css/application/diffusion/diffusion-icons.css' => '3311444d', 'rsrc/css/application/diffusion/diffusion-icons.css' => '3311444d',
'rsrc/css/application/diffusion/diffusion-readme.css' => '356a4f3c', 'rsrc/css/application/diffusion/diffusion-readme.css' => '297373eb',
'rsrc/css/application/diffusion/diffusion-source.css' => '68b30fd3', 'rsrc/css/application/diffusion/diffusion-source.css' => '68b30fd3',
'rsrc/css/application/feed/feed.css' => 'ecd4ec57', 'rsrc/css/application/feed/feed.css' => 'ecd4ec57',
'rsrc/css/application/files/global-drag-and-drop.css' => '5c1b47c2', 'rsrc/css/application/files/global-drag-and-drop.css' => '5c1b47c2',
@ -156,7 +156,7 @@ return array(
'rsrc/css/phui/phui-status.css' => '37309046', 'rsrc/css/phui/phui-status.css' => '37309046',
'rsrc/css/phui/phui-tag-view.css' => '6bbd83e2', 'rsrc/css/phui/phui-tag-view.css' => '6bbd83e2',
'rsrc/css/phui/phui-timeline-view.css' => 'a0173eba', 'rsrc/css/phui/phui-timeline-view.css' => 'a0173eba',
'rsrc/css/phui/phui-two-column-view.css' => 'c110d0c3', 'rsrc/css/phui/phui-two-column-view.css' => '37d704f3',
'rsrc/css/phui/workboards/phui-workboard-color.css' => 'ac6fe6a7', 'rsrc/css/phui/workboards/phui-workboard-color.css' => 'ac6fe6a7',
'rsrc/css/phui/workboards/phui-workboard.css' => 'e6d89647', 'rsrc/css/phui/workboards/phui-workboard.css' => 'e6d89647',
'rsrc/css/phui/workboards/phui-workcard.css' => '3646fb96', 'rsrc/css/phui/workboards/phui-workcard.css' => '3646fb96',
@ -554,7 +554,7 @@ return array(
'differential-revision-list-css' => 'f3c47d33', 'differential-revision-list-css' => 'f3c47d33',
'differential-table-of-contents-css' => 'ae4b7a55', 'differential-table-of-contents-css' => 'ae4b7a55',
'diffusion-icons-css' => '3311444d', 'diffusion-icons-css' => '3311444d',
'diffusion-readme-css' => '356a4f3c', 'diffusion-readme-css' => '297373eb',
'diffusion-source-css' => '68b30fd3', 'diffusion-source-css' => '68b30fd3',
'diviner-shared-css' => 'aa3656aa', 'diviner-shared-css' => 'aa3656aa',
'font-aleo' => '8bdb2835', 'font-aleo' => '8bdb2835',
@ -846,7 +846,7 @@ return array(
'phui-tag-view-css' => '6bbd83e2', 'phui-tag-view-css' => '6bbd83e2',
'phui-theme-css' => '027ba77e', 'phui-theme-css' => '027ba77e',
'phui-timeline-view-css' => 'a0173eba', 'phui-timeline-view-css' => 'a0173eba',
'phui-two-column-view-css' => 'c110d0c3', 'phui-two-column-view-css' => '37d704f3',
'phui-workboard-color-css' => 'ac6fe6a7', 'phui-workboard-color-css' => 'ac6fe6a7',
'phui-workboard-view-css' => 'e6d89647', 'phui-workboard-view-css' => 'e6d89647',
'phui-workcard-view-css' => '3646fb96', 'phui-workcard-view-css' => '3646fb96',

View file

@ -635,6 +635,8 @@ final class DiffusionCommitController extends DiffusionController {
$author = $author_name; $author = $author_name;
$image_uri = null; $image_uri = null;
$image_href = null; $image_href = null;
} else {
return null;
} }
$author = phutil_tag('strong', array(), $author); $author = phutil_tag('strong', array(), $author);

View file

@ -2,6 +2,7 @@
* @provides diffusion-readme-css * @provides diffusion-readme-css
*/ */
.device .diffusion-readme-view .phui-document-fluid .phui-document-view,
.device-desktop .diffusion-readme-view .phui-document-fluid .device-desktop .diffusion-readme-view .phui-document-fluid
.phui-document-view { .phui-document-view {
margin: 0; margin: 0;

View file

@ -131,6 +131,11 @@
padding: 16px 0; padding: 16px 0;
} }
.device-desktop .phui-two-column-view
.phui-property-list-properties-wrap.phui-property-list-stacked {
padding: 0 16px;
}
.device .phui-two-column-view .phui-property-list-container { .device .phui-two-column-view .phui-property-list-container {
padding: 12px 8px; padding: 12px 8px;
} }
@ -192,7 +197,3 @@
.phui-info-view { .phui-info-view {
margin: 0; margin: 0;
} }
.phui-two-column-view .phui-object-box .phui-header-shell + .phui-info-view {
margin: 16px 16px 0 16px;
}