revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 21:32:43 +01:00
Code Issues Releases Wiki Activity

Move Conpherence to "Z" monogram instead of "E"

Browse source 
Summary:
Ref T7439. Fixes T7438. This is only used in email right now.

Remain backward compatible.

Test Plan:
  - Sent a message, saw a "Z" reply address.
  - Checked the PHIDType.
  - Grepped for `"E"` and `'E'`.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7439, T7438

Differential Revision: https://secure.phabricator.com/D11956
This commit is contained in:
epriestley 2015-03-03 10:40:09 -08:00
parent 47b54389e5
commit 024a01abe8
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/conpherence/mail/ConpherenceReplyHandler.php
View file

@ -20,11 +20,11 @@ final class ConpherenceReplyHandler extends PhabricatorMailReplyHandler {
public function getPrivateReplyHandlerEmailAddress( public function getPrivateReplyHandlerEmailAddress(
PhabricatorObjectHandle $handle) { PhabricatorObjectHandle $handle) {
return $this->getDefaultPrivateReplyHandlerEmailAddress($handle, 'E'); return $this->getDefaultPrivateReplyHandlerEmailAddress($handle, 'Z');
} }
public function getPublicReplyHandlerEmailAddress() { public function getPublicReplyHandlerEmailAddress() {
return $this->getDefaultPublicReplyHandlerEmailAddress('E'); return $this->getDefaultPublicReplyHandlerEmailAddress('Z');
} }
public function getReplyHandlerInstructions() { public function getReplyHandlerInstructions() {

6
src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php
View file

@ -9,11 +9,13 @@ final class ConpherenceThreadMailReceiver
} }
protected function getObjectPattern() { protected function getObjectPattern() {
return 'E[1-9]\d*'; // TODO: Only recognize "Z" once we get closer to shipping Calendar.
return '[EZ][1-9]\d*';
} }
protected function loadObject($pattern, PhabricatorUser $viewer) { protected function loadObject($pattern, PhabricatorUser $viewer) {
$id = (int)trim($pattern, 'E'); // TODO: Only recognize "Z" once we get closer to shipping Calendar.
$id = (int)trim($pattern, 'EZ');
return id(new ConpherenceThreadQuery()) return id(new ConpherenceThreadQuery())
->setViewer($viewer) ->setViewer($viewer)