When there are no setup issues, don't show a weird empty box

Summary: Ref T13189. When there are no setup issues, we currently double-render a weird setup issues box underneath the notice. Get rid of it.

Test Plan: Viewed page with and without setup issues, saw less awkward UI.

Reviewers: amckinley

Maniphest Tasks: T13189

Differential Revision: https://secure.phabricator.com/D19609

src/applications/config/controller/PhabricatorConfigIssueListController.php

@@ -33,27 +33,26 @@ final class PhabricatorConfigIssueListController
       PhabricatorSetupCheck::GROUP_OTHER,
       'fa-question-circle');
 
-    $no_issues = null;
-    if (empty($issues)) {
-      $no_issues = id(new PHUIInfoView())
+    $title = pht('Setup Issues');
+    $header = $this->buildHeaderView($title);
+
+    if (!$issues) {
+      $issue_list = id(new PHUIInfoView())
         ->setTitle(pht('No Issues'))
         ->appendChild(
           pht('Your install has no current setup issues to resolve.'))
         ->setSeverity(PHUIInfoView::SEVERITY_NOTICE);
+    } else {
+      $issue_list = array(
+        $important,
+        $php,
+        $mysql,
+        $other,
+      );
+
+      $issue_list = $this->buildConfigBoxView(pht('Issues'), $issue_list);
     }
 
-    $title = pht('Setup Issues');
-    $header = $this->buildHeaderView($title);
-
-    $issue_list = array(
-      $important,
-      $php,
-      $mysql,
-      $other,
-    );
-
-    $issue_list = $this->buildConfigBoxView(pht('Issues'), $issue_list);
-
     $crumbs = $this->buildApplicationCrumbs()
       ->addTextCrumb($title)
       ->setBorder(true);
@@ -62,10 +61,7 @@ final class PhabricatorConfigIssueListController
       ->setHeader($header)
       ->setNavigation($nav)
       ->setFixed(true)
-      ->setMainColumn(array(
-        $no_issues,
-        $issue_list,
-      ));
+      ->setMainColumn($issue_list);
 
     return $this->newPage()
       ->setTitle($title)