revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Fix Maniphest fatal if attached tasks are not an array

Browse source 
Summary: Fixes T3678. I think some very old rows may have a junk value here. This will be obsoleted by ApplicationTransactions and other modernization, most likely, so just fix it locally.

Test Plan: looked at a task

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3678

Differential Revision: https://secure.phabricator.com/D6677
This commit is contained in:
epriestley 2013-08-05 10:27:50 -07:00
parent 3fd2c0ff90
commit 02ccca4bbd
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/maniphest/controller/ManiphestTaskDetailController.php
View file

@ -566,6 +566,10 @@ final class ManiphestTaskDetailController extends ManiphestController {
} }
$attached = $task->getAttached(); $attached = $task->getAttached();
if (!is_array($attached)) {
$attached = array();
}
$file_infos = idx($attached, PhabricatorFilePHIDTypeFile::TYPECONST); $file_infos = idx($attached, PhabricatorFilePHIDTypeFile::TYPECONST);
if ($file_infos) { if ($file_infos) {
$file_phids = array_keys($file_infos); $file_phids = array_keys($file_infos);