From 02f0c099fa25a5a6b6b75514a8095690ab9c449b Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 2 Jun 2015 15:27:49 -0700 Subject: [PATCH] Fix some minor Spaces method visibility issues Summary: Ref T8377. These were picked up by tests. Test Plan: `arc unit --everything` Reviewers: btrahan Reviewed By: btrahan Subscribers: epriestley Maniphest Tasks: T8377 Differential Revision: https://secure.phabricator.com/D13130 --- resources/celerity/map.php | 4 ++-- .../spaces/controller/PhabricatorSpacesListController.php | 2 +- .../spaces/query/PhabricatorSpacesNamespaceSearchEngine.php | 2 +- .../spaces/storage/PhabricatorSpacesNamespace.php | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 89e31085c5..9716b00f16 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -333,7 +333,7 @@ return array( 'rsrc/js/application/auth/behavior-persona-login.js' => '9414ff18', 'rsrc/js/application/calendar/behavior-day-view.js' => '5c46cff2', 'rsrc/js/application/calendar/behavior-event-all-day.js' => '38dcf3c8', - 'rsrc/js/application/calendar/behavior-recurring-edit.js' => '85c73ceb', + 'rsrc/js/application/calendar/behavior-recurring-edit.js' => '9c751e15', 'rsrc/js/application/config/behavior-reorder-fields.js' => 'b6993408', 'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '01774ab2', 'rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js' => 'cf86d16a', @@ -630,7 +630,7 @@ return array( 'javelin-behavior-project-boards' => 'ba4fa35c', 'javelin-behavior-project-create' => '065227cc', 'javelin-behavior-quicksand-blacklist' => '7927a7d3', - 'javelin-behavior-recurring-edit' => '85c73ceb', + 'javelin-behavior-recurring-edit' => '9c751e15', 'javelin-behavior-refresh-csrf' => '7814b593', 'javelin-behavior-releeph-preview-branch' => 'b2b4fbaf', 'javelin-behavior-releeph-request-state-change' => 'a0b57eb8', diff --git a/src/applications/spaces/controller/PhabricatorSpacesListController.php b/src/applications/spaces/controller/PhabricatorSpacesListController.php index 0f6ea5be15..fe439b0097 100644 --- a/src/applications/spaces/controller/PhabricatorSpacesListController.php +++ b/src/applications/spaces/controller/PhabricatorSpacesListController.php @@ -32,7 +32,7 @@ final class PhabricatorSpacesListController return $nav; } - public function buildApplicationCrumbs() { + protected function buildApplicationCrumbs() { $crumbs = parent::buildApplicationCrumbs(); $can_create = $this->hasApplicationCapability( diff --git a/src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php b/src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php index 9a6269eefa..9b4014c3dd 100644 --- a/src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php +++ b/src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php @@ -31,7 +31,7 @@ final class PhabricatorSpacesNamespaceSearchEngine return '/spaces/'.$path; } - public function getBuiltinQueryNames() { + protected function getBuiltinQueryNames() { $names = array( 'all' => pht('All Spaces'), ); diff --git a/src/applications/spaces/storage/PhabricatorSpacesNamespace.php b/src/applications/spaces/storage/PhabricatorSpacesNamespace.php index 7a9c57aa03..8271f536cb 100644 --- a/src/applications/spaces/storage/PhabricatorSpacesNamespace.php +++ b/src/applications/spaces/storage/PhabricatorSpacesNamespace.php @@ -29,7 +29,7 @@ final class PhabricatorSpacesNamespace ->setEditPolicy($edit_policy); } - public function getConfiguration() { + protected function getConfiguration() { return array( self::CONFIG_AUX_PHID => true, self::CONFIG_COLUMN_SCHEMA => array(